From patchwork Fri Sep 8 11:02:11 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jaroslaw Pelczar X-Patchwork-Id: 811604 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=2001:4830:134:3::11; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3xpf003ZL6z9s8J for ; Fri, 8 Sep 2017 23:52:32 +1000 (AEST) Received: from localhost ([::1]:45536 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dqJhu-0007JS-Iq for incoming@patchwork.ozlabs.org; Fri, 08 Sep 2017 09:52:30 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41472) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dqH3J-0000L6-0P for qemu-devel@nongnu.org; Fri, 08 Sep 2017 07:02:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dqH3E-0007CO-29 for qemu-devel@nongnu.org; Fri, 08 Sep 2017 07:02:25 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:48522) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dqH3D-0007AV-Qz for qemu-devel@nongnu.org; Fri, 08 Sep 2017 07:02:19 -0400 Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20170908110213euoutp020e21e67643daf0809622c276e073806a~iXfVaFarQ1379013790euoutp02S for ; Fri, 8 Sep 2017 11:02:13 +0000 (GMT) Received: from eusmges5.samsung.com (unknown [203.254.199.245]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20170908110213eucas1p15f11ee99d4d032b88294fa57198eb348~iXfUwHfTJ3259532595eucas1p1Q for ; Fri, 8 Sep 2017 11:02:13 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges5.samsung.com (EUCPMTA) with SMTP id 9A.3A.12743.4B872B95; Fri, 8 Sep 2017 12:02:12 +0100 (BST) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20170908110212eucas1p27c5eecf44c5501d23b322d3679a4f12d~iXfUDRbUM2183721837eucas1p2F for ; Fri, 8 Sep 2017 11:02:12 +0000 (GMT) X-AuditID: cbfec7f5-f79d06d0000031c7-ad-59b278b47403 Received: from eusync4.samsung.com ( [203.254.199.214]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 4A.62.20118.4B872B95; Fri, 8 Sep 2017 12:02:12 +0100 (BST) Received: from AMDN1843 ([106.120.52.68]) by eusync4.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0OVY00J6NJZOUG50@eusync4.samsung.com> for qemu-devel@nongnu.org; Fri, 08 Sep 2017 12:02:12 +0100 (BST) From: Jaroslaw Pelczar To: qemu-devel@nongnu.org Date: Fri, 08 Sep 2017 13:02:11 +0200 Message-id: <001801d32891$ec40b930$c4c22b90$@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset="us-ascii" Content-transfer-encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-index: AdMokUb29KFN5T8PRlCzIe249EE0ug== Content-language: pl X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrIIsWRmVeSWpSXmKPExsWy7djP87pbKjZFGjy+q2dxvHcHiwOjx5Nr m5kCGKO4bFJSczLLUov07RK4MvYemMVWsJu9YuGeqywNjC9Zuxg5OSQETCTmPbnOBmGLSVy4 tx7I5uIQEljKKPHy0gYmCKefSeJ5xyTGLkYOsI7L6+wg4ssYJe7s3MsO4XQzSXQveMMEMopN QE/i/KO3jCC2iICkxO+u08wgtrCAq0TbyvVgNSwCqhIb7s9kB7F5BSwlGu7/YIOwBSV+TL7H AmIzC+hInD22jhHClpfYvOYtM8SpChI7zr6Gmq8nca57IlS9iMTdhuesIAdJCLxllVh9sp0F osFFYtnBQ4wQtrDEq+Nb2CFsGYnLk7tZIBomM0o8XvsQylnNKNG4ZD1Ut7XEphuvmCBW8ElM 2jadGRIWvBIdbUIQJR4S+5cehBrqKLHiawPYN0ICsRLr395kmcAoNwvJc7OQPDcLyXOzkDyx gJFlFaNIamlxbnpqsalecWJucWleul5yfu4mRmDEn/53/OsOxqXHrA4xCnAwKvHwTgjdGCnE mlhWXJl7iFGCg1lJhDe9ZFOkEG9KYmVValF+fFFpTmrxIUZpDhYlcV7bqLZIIYH0xJLU7NTU gtQimCwTB6dUA+PsbaUv3L9N/hdlmHGV5xvXwb5s7sRJS7MNSgRL05Myp52f6Mp1z9bVOVYu 4VX27oWZC/gOxL0+x7vnttft2OQPuzudunu2b+Hv/Tlj+XvnfJNk5kA17h6pwmnzljxZ/W7y DJdbx/W76g5aXLr0jWPp7xeaU+IkRfOWCO2p+7H02SFVrxdqv6YqsRRnJBpqMRcVJwIAn4WF RfQCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrJLMWRmVeSWpSXmKPExsVy+t/xa7pbKjZFGmzdKG5xvHcHiwOjx5Nr m5kCGKO4bFJSczLLUov07RK4MvYemMVWsJu9YuGeqywNjC9Zuxg5OCQETCQur7PrYuQEMsUk Ltxbz9bFyMUhJLCEUaJv6mx2CKeXSWLq3ResIFVsAnoS5x+9ZQSxRQQkJX53nWYGsYUFXCXa Vq5nArFZBFQlNtyfyQ5i8wpYSjTc/8EGYQtK/Jh8jwXEZhbQkli/8zgThC0vsXnNW2aIKxQk dpx9DTVfT+Jc90SoehGJuw3PWScw8s9CMmoWklGzkIyahaRlASPLKkaR1NLi3PTcYiO94sTc 4tK8dL3k/NxNjMAA3Hbs55YdjF3vgg8xCnAwKvHwWgRvjBRiTSwrrsw9xCjBwawkwptesilS iDclsbIqtSg/vqg0J7X4EKM0B4uSOG/vntWRQgLpiSWp2ampBalFMFkmDk6pBsa9zKLtkuKJ sx2Z37mq9b5/4N9yKeWP0SbeRIvQayc4LA4wLW5+LhDifVmwNr2S23Ddi3Sf068eeDnvbN2t uDb0WLzh3fzlb3kcmg1uGfi7PmTaLZL94y+L2JaEqOjQuTbLfhed3PJuzpep3/R9VER3uTFf 13a3UPnztbo190DU/+wYHWZvYyWW4oxEQy3mouJEAJFRZwc8AgAA X-CMS-MailID: 20170908110212eucas1p27c5eecf44c5501d23b322d3679a4f12d X-Msg-Generator: CA X-Sender-IP: 182.198.249.180 X-Local-Sender: =?utf-8?b?7JW866Gc7Iqs65287ZSEG1NSUE9MLVNlY3VyZSBPUyAo?= =?utf-8?b?VFApG+yCvOyEseyghOyekBsuL1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVl?= =?utf-8?q?r?= X-Global-Sender: =?utf-8?q?Jaroslaw_Pelczar=1BSRPOL-Secure_OS_=28TP=29=1B?= =?utf-8?q?Samsung_Electronics=1B=2E/Senior_Software_Engineer?= X-Sender-Code: =?utf-8?q?C10=1BEHQ=1BC10CD02CD027394?= CMS-TYPE: 201P X-CMS-RootMailID: 20170908110212eucas1p27c5eecf44c5501d23b322d3679a4f12d X-RootMTR: 20170908110212eucas1p27c5eecf44c5501d23b322d3679a4f12d References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 210.118.77.12 X-Mailman-Approved-At: Fri, 08 Sep 2017 09:50:46 -0400 Subject: [Qemu-devel] [PATCH 1/1] AArch64: Fix single stepping of ERET instruction X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Previously when single stepping through ERET instruction via GDB would result in debugger entering the "next" PC after ERET instruction. When debugging in kernel mode, this will also cause unintended behavior, because debugger will try to access memory from EL0 point of view. Signed-off-by: Jaroslaw Pelczar Reviewed-by: Richard Henderson --- target/arm/translate-a64.c | 1 + 1 file changed, 1 insertion(+) gen_exception_internal(EXCP_DEBUG); diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index 9017e30510..1bc12d93ca 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/translate-a64.c @@ -11348,6 +11348,7 @@ static void aarch64_tr_tb_stop(DisasContextBase *dcbase, CPUState *cpu) default: gen_a64_set_pc_im(dc->pc); /* fall through */ + case DISAS_EXIT: case DISAS_JUMP: if (dc->base.singlestep_enabled) {