From patchwork Tue Dec 8 01:09:54 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?J=2E_Neusch=C3=A4fer?= X-Patchwork-Id: 1412370 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-rtc-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmx.net Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.a=rsa-sha256 header.s=badeba3b8450 header.b=AKQ2iQ0q; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4Cqhy50DXHz9sSn for ; Tue, 8 Dec 2020 12:13:17 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726526AbgLHBNI (ORCPT ); Mon, 7 Dec 2020 20:13:08 -0500 Received: from mout.gmx.net ([212.227.17.21]:50343 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726147AbgLHBNH (ORCPT ); Mon, 7 Dec 2020 20:13:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1607389839; bh=pnWfE1q4e+S1NcScWWdH3l56DjjQYX0DB2eDmmG2Qmw=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To:References; b=AKQ2iQ0qyuboRtIt3wsgQEUHoMTJK7lz8W8pTBEWLwy6qkvyOghWfRmaQj0f2Vb2A nkqAaMdN0O1K+7nnvck+SOrSmiRl76yu3a/VfLapbED0+DocT93LVNCbpmJIPfRJK5 gpeCjapk2bi1NGR6T4H4RXMyRfHU9Ap/5ej3oUmQ= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from longitude ([37.201.214.162]) by mail.gmx.com (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MJmGP-1kSrP415kP-00K6ae; Tue, 08 Dec 2020 02:10:39 +0100 From: =?utf-8?q?Jonathan_Neusch=C3=A4fer?= To: linux-kernel@vger.kernel.org Cc: Lee Jones , Rob Herring , =?utf-8?q?Jonathan_Neusch=C3=A4fer?= , Thierry Reding , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Alessandro Zummo , Alexandre Belloni , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Sam Ravnborg , Linus Walleij , Heiko Stuebner , Stephan Gerhold , Lubomir Rintel , Mark Brown , allen , Mauro Carvalho Chehab , "David S. Miller" , devicetree@vger.kernel.org, linux-pwm@vger.kernel.org, linux-rtc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Heiko Stuebner , Josua Mayer , Andreas Kemnade , Arnd Bergmann , Daniel Palmer , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Geert Uytterhoeven , Kuninori Morimoto Subject: [PATCH v6 1/7] dt-bindings: Add vendor prefix for Netronix, Inc. Date: Tue, 8 Dec 2020 02:09:54 +0100 Message-Id: <20201208011000.3060239-2-j.neuschaefer@gmx.net> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201208011000.3060239-1-j.neuschaefer@gmx.net> References: <20201208011000.3060239-1-j.neuschaefer@gmx.net> MIME-Version: 1.0 X-Provags-ID: V03:K1:jLNKQX72YE6HNCrjXmN3THj8hVdDQ5skL5MYyC79rsgWv1+w+CK rKbCb9+26R5YFuwL0WD3Sn8gAxZL+wn8+LkQ5Jc73cZL8Je13kNw9BG+eeAwId6ucIb3+53 VGzRydEuYZl64RcZEB7ZeGnFqofNJHOEXOhYy155ixfJmg330iknjH3oR0mouqnS72Y2VXq EAvLuMya4kPyfw9EnxCVA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:suINVp6qRSc=:Y4S+wKKlX+AzqPSZmgUBwl Kkm/Gce0T1WYUPv1AfdeNSpRsGxIzDyirh5F37k1Zl9xl/1E0/zr7cIcGeG8hVpgHm/P3/bc2 vcplii5VushZiy04TTpi+PHc6NfPxCJYHN4b3wSVrExqoC5bTIpoTTBGslUuJSHFN6wJTAqsD UUJGIKUw4qBk0G3OwTLODJJmgPmaQjL8Onk5CDektW0I0YXBJzojuBIkD8RMoGaKQL/tHoTKN pcNWdzArPK36Jam35dzntOpzZyfaKYW2CjZvXIwYVmcqKk8tBoG514Fh+tBKVPnp1gjknDl9H PECgsPPm6yo75HQKa8V1VGYwziKCxfPjvaaQmQzOf9HkF8wikspzIzTCy0rYiLSoNFBfXLgq8 e6vM49TxZ1RlCm1pjTihS7F1i/dmMG3cdAHhMHyTLd2tsJX419Kb1YSZe9kN+yPnexWLtXQAH vMusuE+cY0u73P47AR+b90wBIfuX6b6GACmKsSlhO3mdWg8Fd7MfGrvjANYFHNZr5UPNiq4Z+ ocr+u2LC3mIN6090uN3GUvIfzWDbHvDDwgQRh7B10v2RelDffMNkBPXaH+pT21prdGE/Q+/7O fZrQxG7BqOPDIwg1sxt76w7sTmarBJuq744+zlHMbVcP49d9mTVBV0fc6Qbdg//NMvo2rWfr4 H554fm8rI1YBwa7zqeMNU/fVnpAglU6KnKZHjAWHq6Nd/8kXgmqbo76rr1ElE8My3Fu1+1L0O hr6C24U2KYEUdHAcMFhiHl0hHH7nX28KQscgdAQMGuj5WAr5SYK94Du5S4O7RD3lcfnnNA/I1 7gflXmXX1HRQrccDqvGn/BOSNQrShzJI4u8l9Q/vG/b43NI2pFvYmGhejJy6NWU098jW0wVvJ Agob6qs2Z4H5+CMdv1oQ== Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org Netronix, Inc. (http://www.netronixinc.com/) makes ebook reader board designs, which are for example used in Kobo and Tolino devices. An alternative prefix for Netronix would be "ntx", which is already used in code released by Netronix. It is shorter, but perhaps less clear. Signed-off-by: Jonathan Neuschäfer Acked-by: Rob Herring --- v4-v6: - No changes v3: - https://lore.kernel.org/lkml/20200924192455.2484005-2-j.neuschaefer@gmx.net/ - Add Acked-by tag v2: - No changes --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+) -- 2.29.2 diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml index 2735be1a84709..cbf28f992b71e 100644 --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml @@ -726,6 +726,8 @@ patternProperties: description: Broadcom Corporation (formerly NetLogic Microsystems) "^netron-dy,.*": description: Netron DY + "^netronix,.*": + description: Netronix, Inc. "^netxeon,.*": description: Shenzhen Netxeon Technology CO., LTD "^neweast,.*": From patchwork Tue Dec 8 01:09:55 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?J=2E_Neusch=C3=A4fer?= X-Patchwork-Id: 1412374 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-rtc-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmx.net Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.a=rsa-sha256 header.s=badeba3b8450 header.b=BtUI3TIm; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4Cqhy717xDz9sSn for ; Tue, 8 Dec 2020 12:13:19 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726653AbgLHBNL (ORCPT ); Mon, 7 Dec 2020 20:13:11 -0500 Received: from mout.gmx.net ([212.227.15.15]:37375 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726247AbgLHBNJ (ORCPT ); Mon, 7 Dec 2020 20:13:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1607389841; bh=zwgIpukD+PzbwgBGrDejjNFMv1JXBd0sGsF2ybRM7R8=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To:References; b=BtUI3TImqSEcmHPyd7QedxOSkoocDu6MvHI8CPtn5R9Qp/3tqcxxZM96SCIm/k+Jq 0KP+W4nOgrRU/RSviAfdyd+FYqZz1xz4p9cYcvTVaymgd1YnaN7YyF1T9rtqotUc5i gDKiLqxr22kcKp5g5ynqrEPtLosmpzeY5z59xXUA= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from longitude ([37.201.214.162]) by mail.gmx.com (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MdNcA-1kD6ht2N0q-00ZMbv; Tue, 08 Dec 2020 02:10:41 +0100 From: =?utf-8?q?Jonathan_Neusch=C3=A4fer?= To: linux-kernel@vger.kernel.org Cc: Lee Jones , Rob Herring , =?utf-8?q?Jonathan_Neusch=C3=A4fer?= , Thierry Reding , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Alessandro Zummo , Alexandre Belloni , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Sam Ravnborg , Linus Walleij , Heiko Stuebner , Stephan Gerhold , Lubomir Rintel , Mark Brown , allen , Mauro Carvalho Chehab , "David S. Miller" , devicetree@vger.kernel.org, linux-pwm@vger.kernel.org, linux-rtc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Heiko Stuebner , Josua Mayer , Andreas Kemnade , Arnd Bergmann , Daniel Palmer , Andy Shevchenko , Rob Herring Subject: [PATCH v6 2/7] dt-bindings: mfd: Add binding for Netronix embedded controller Date: Tue, 8 Dec 2020 02:09:55 +0100 Message-Id: <20201208011000.3060239-3-j.neuschaefer@gmx.net> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201208011000.3060239-1-j.neuschaefer@gmx.net> References: <20201208011000.3060239-1-j.neuschaefer@gmx.net> MIME-Version: 1.0 X-Provags-ID: V03:K1:H6n+tRg6gp1Pqa2RaM+LSuIxVzFop3f1GBwliFyGy8zNr5eglA8 GpnXdcLa+S/eLXy95E04FmKIOu9Ez+zy7/JqjkP2wQiiqrNjritGr0WgnBBTCzSCtE52fOE kjpQtzg908G18m766EnSSepwtkUdn6GVbNXAvLaJc/Ux3VNNF4WyA9cMdq6ge/jX1RMT+Pt A9B5LHzpHmW7bgJYkvdtA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:0SYESpryKA8=:Z1Y4Va7YiJvg/oRqdG4jtG FEJORfpP2WCnc1aavBAN5OWDkiRfuYVdyMMHvBO2LEgmmBiEUqam7h+xj2wieOO6qRt/7ERUG NyjQ/IKvSAGC/rxG0VOeLlLmBhZDsqDUqVibopSN8Irs+ZmglwxkcYCzzu3hOexU7Q2tPtqie /GIEZ8HTkcLyyyjVSbx2cBAE9wTKhVor7PRPrKRlK6Jfjd0LNirP0gMI8e20hOOqeeC/Q5htN Z6r59fNvi/Jl6vAR6jK0cg6Ev5P7qlwVke1Ems9vq4GEpKuKmMdTaHn1jtrVSbOSIJbZRd3FM 0/MQbqbqt3xnFdvZSfMYzLhpZ7wHUR9ERI4Z6WOUVB9lE3le/7FaQk2SUUol5EAXy9Ve5JysZ MBUZq9Yt5Vox0w6aayQBv62nUYU5+nm8dDDy1Q9HgP7wKGFsuCANkKVM7TAHZ42EjGN8Y4ZaC QXd1F5B4rGlMxtbjhGWWQIvZUWe9MH3rWHvDxYHuzCgSSbxSwGCaW2GFrsJtgYBK/XMxOAmYO GUrTS90diNCiO2vXrrNNszOH77RMoCXhRIPXqIKeBtQh1EaijO+qU4PsLvdt3Aga/9+UvDYtR wUe3ftdgHjLWTH4FEmGk4BEDpeLFZhF1pUn/wZMqAJLgnwel7t2QbthMU3k69xypNJ7C/R8jl 7htTgnAHF2vdYTM5NK3AWaTKU972xgL4j+RSHUFbYB9tNdbWOPiGCBSUuypZOMzzXw0HxFN46 7/xCnl4Bpc3C9YRTQ6o5uaHmWlKi1o1PbSJG0DEaOa59gv9UxRvnpJMFwj34dK9IUCiTAocql fgC/4qmfdsjFbJstzJuwo+/DzC0dYKg6OdvwSydK94RGHyiHXvM2wpEEK0+nruC1naYbDIxwU Re+3USYRc9ZLrSIBsN5A== Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org This EC is found in e-book readers of multiple brands (e.g. Kobo, Tolino), and is typically implemented as a TI MSP430 microcontroller. It controls different functions of the system, such as power on/off, RTC, PWM for the backlight. The exact functionality provided can vary between boards. Signed-off-by: Jonathan Neuschäfer Reviewed-by: Rob Herring --- v5, v6: - no changes v4: - Add R-b tag v3: - https://lore.kernel.org/lkml/20200924192455.2484005-3-j.neuschaefer@gmx.net/ - Remove binding in text form patch description again - Add additionalProperties: false - Remove interrupt-controller property from example - Merge pwm/rtc nodes into main node v2: - https://lore.kernel.org/lkml/20200905133230.1014581-3-j.neuschaefer@gmx.net/ - Add the plaintext DT binding for comparison --- .../bindings/mfd/netronix,ntxec.yaml | 76 +++++++++++++++++++ 1 file changed, 76 insertions(+) create mode 100644 Documentation/devicetree/bindings/mfd/netronix,ntxec.yaml -- 2.29.2 diff --git a/Documentation/devicetree/bindings/mfd/netronix,ntxec.yaml b/Documentation/devicetree/bindings/mfd/netronix,ntxec.yaml new file mode 100644 index 0000000000000..59a630025f52f --- /dev/null +++ b/Documentation/devicetree/bindings/mfd/netronix,ntxec.yaml @@ -0,0 +1,76 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/mfd/netronix,ntxec.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Netronix Embedded Controller + +maintainers: + - Jonathan Neuschäfer + +description: | + This EC is found in e-book readers of multiple brands (e.g. Kobo, Tolino), and + is typically implemented as a TI MSP430 microcontroller. + +properties: + compatible: + const: netronix,ntxec + + reg: + items: + - description: The I2C address of the EC + + system-power-controller: + type: boolean + description: See Documentation/devicetree/bindings/power/power-controller.txt + + interrupts: + minItems: 1 + description: + The EC can signal interrupts via a GPIO line + + "#pwm-cells": + const: 2 + description: | + Number of cells in a PWM specifier. + + The following PWM channels are supported: + - 0: The PWM channel controlled by registers 0xa1-0xa7 + +required: + - compatible + - reg + +additionalProperties: false + +examples: + - | + #include + i2c { + #address-cells = <1>; + #size-cells = <0>; + + ec: embedded-controller@43 { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_ntxec>; + + compatible = "netronix,ntxec"; + reg = <0x43>; + system-power-controller; + interrupt-parent = <&gpio4>; + interrupts = <11 IRQ_TYPE_EDGE_FALLING>; + #pwm-cells = <2>; + }; + }; + + backlight { + compatible = "pwm-backlight"; + pwms = <&ec 0 50000>; + power-supply = <&backlight_regulator>; + }; + + backlight_regulator: regulator-dummy { + compatible = "regulator-fixed"; + regulator-name = "backlight"; + }; From patchwork Tue Dec 8 01:09:56 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?J=2E_Neusch=C3=A4fer?= X-Patchwork-Id: 1412369 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-rtc-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmx.net Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.a=rsa-sha256 header.s=badeba3b8450 header.b=aMgANgnK; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4Cqhy44MNgz9sVq for ; Tue, 8 Dec 2020 12:13:16 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726264AbgLHBNB (ORCPT ); Mon, 7 Dec 2020 20:13:01 -0500 Received: from mout.gmx.net ([212.227.15.18]:33695 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726247AbgLHBM7 (ORCPT ); Mon, 7 Dec 2020 20:12:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1607389844; bh=HfmzY+mOEYx4C4wVfJ2StsJL7j0bNVmAjOXr6dVo5/c=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To:References; b=aMgANgnK9vAnNX4PehxIppysmwT30VWuQQAjJbUvAtj5VuxGrrijyXGYpelUZjBj5 kzvOwggB+S6Sz+n5Ndi69bKZdT2UUNlZGTl9UP9ol6CPvw0/l/ccUM2ulaZ4ddG9Gy WMmD0RhS9bxX33UMhVYoMitxxvwsOPmr1Qe3nAtw= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from longitude ([37.201.214.162]) by mail.gmx.com (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1N1wlv-1k2MIP0egT-012KWP; Tue, 08 Dec 2020 02:10:44 +0100 From: =?utf-8?q?Jonathan_Neusch=C3=A4fer?= To: linux-kernel@vger.kernel.org Cc: Lee Jones , Rob Herring , =?utf-8?q?Jonathan_Neusch=C3=A4fer?= , Thierry Reding , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Alessandro Zummo , Alexandre Belloni , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Sam Ravnborg , Linus Walleij , Heiko Stuebner , Stephan Gerhold , Lubomir Rintel , Mark Brown , allen , Mauro Carvalho Chehab , "David S. Miller" , devicetree@vger.kernel.org, linux-pwm@vger.kernel.org, linux-rtc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Heiko Stuebner , Josua Mayer , Andreas Kemnade , Arnd Bergmann , Daniel Palmer , Andy Shevchenko Subject: [PATCH v6 3/7] mfd: Add base driver for Netronix embedded controller Date: Tue, 8 Dec 2020 02:09:56 +0100 Message-Id: <20201208011000.3060239-4-j.neuschaefer@gmx.net> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201208011000.3060239-1-j.neuschaefer@gmx.net> References: <20201208011000.3060239-1-j.neuschaefer@gmx.net> MIME-Version: 1.0 X-Provags-ID: V03:K1:ghjPRhXHk+XvkGKeAkpudi9GejhOfY34NX/uPYorrYSM2x1DUHL Jwuq0Tg31ezODZwxjD02Pw+A+Aa2e1P1AE2YZytlneG/6KgESmUukLvOuUcFSWoD7oPjhZo +5xlSfwqoY5ehSCf7cVsB8GbvldznLX15xhnk1xes7oxQSQOWltNcRFSzQsYvNcj0ZwwAHG b51syXXwbp5tvPaL+4oGw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:Dx5SIK4CN04=:QaSWBi+WFlMS8mXmNMiMxA WtVTQBs+LVTKTNhSC8HKSSqlbK4PXrgiOA5v2NSXZCmrTpkaffGqgfDANFkBww8mZr4JKzi5C GiXF28gQQ5LC2KWaYLNomiusGb6RGTOuAZ/LqERH763oYJWHExtsy6P3V6fQK9RE3BcXeGjka E/LZ73TtegG0SSmjJ6nJDCljW8EZfEoF8EUH9AKZ2wbkyuPtp201bLrr+kgpwnRqqdfr3gcaB uGGrmnogaqgZjeUrmhb/4aspw8OHWbBjOT2+SOGBPPD7OyOB3Bum5dmvFB4THjpXVaq34svKx NEE2XyiMKsQj9NY2gUKUn+ifErWVB9wSC2pOuG+he2lnfO/bwjqzW0ptbMobTKXvUtQLSUPct p63oovtyIGwUusVwlLrH7Qr7ntlolzfC++rqNUQ7b9nWxfGxYE2fxRsttirgfJlBXBXB2xlnt +YVqUSt71DIfEAiItX5ckZomTB13dMQekzIUFRmxrkxLFrA52EK4lIdapOz79Ektle8Yc/o0D y8WJeLWqgr3qLJJSIjh1M9Vor9Vye57F6FPW9hAHecqTTp5OlMzfGOqpCTs+Lgfbp9gtp4q1s QYAI2CXeljS4a2MFNc2sQrii9ow8WFQUWYoYffptBJZf9wzK2EKF3+WF3k4SArxD1J3Rogn3j X5HOBUTMKX2YLKmMIzTWkARspG08Fgs7U/VSeK4oPDUaxNuLY0sIWYig2Ts1BJTMpIKn2WL+V bzzvEYpUSFwTpylHBOL2iQ7zwRpUrYhxTUP1Wa5PcD6HKF5f2Y6nyXaEffRpU3IZHhdKR1f0f 4rdcW+hvGZ92ptWKH89QvigRB/3Aqu+gWAN6s3E+oNzejAx/bmhQN0dEwoJhms1lCVaciLXuD FADwhGWUAPBRLw0YserA== Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org The Netronix embedded controller is a microcontroller found in some e-book readers designed by the original design manufacturer Netronix, Inc. It contains RTC, battery monitoring, system power management, and PWM functionality. This driver implements register access and version detection. Third-party hardware documentation is available at: https://github.com/neuschaefer/linux/wiki/Netronix-MSP430-embedded-controller The EC supports interrupts, but the driver doesn't make use of them so far. Signed-off-by: Jonathan Neuschäfer Acked-for-MFD-by: Lee Jones --- v6: - Add Lee Jones' ACK v5: - no changes v4: - https://lore.kernel.org/lkml/20201122222739.1455132-4-j.neuschaefer@gmx.net/ - include asm/unaligned.h after linux/* - Use put_unaligned_be16 instead of open-coded big-endian packing - Clarify that 0x90=0xff00 causes an error in downstream kernel too - Add commas after non-sentinel positions - ntxec.h: declare structs device and regmap - Replace WARN_ON usage and add comments to explain errors - Replace dev_alert with dev_warn when the result isn't handled - Change subdevice registration error message to dev_err - Declare ntxec_reg8 as returning __be16 - Restructure version detection code - Spell out ODM v3: - https://lore.kernel.org/lkml/20200924192455.2484005-4-j.neuschaefer@gmx.net/ - Add (EC) to CONFIG_MFD_NTXEC prompt - Relicense as GPLv2 or later - Add email address to copyright line - remove empty lines in ntxec_poweroff and ntxec_restart functions - Split long lines - Remove 'Install ... handler' comments - Make naming of struct i2c_client parameter consistent - Remove struct ntxec_info - Rework 'depends on' lines in Kconfig, hard-depend on I2C, select REGMAP_I2C and MFD_CORE - Register subdevices via mfd_cells - Move 8-bit register conversion to ntxec.h v2: - https://lore.kernel.org/lkml/20200905133230.1014581-4-j.neuschaefer@gmx.net/ - Add a description of the device to the patch text - Unify spelling as 'Netronix embedded controller'. 'Netronix' is the proper name of the manufacturer, but 'embedded controller' is just a label that I have assigned to the device. - Switch to regmap, avoid regmap use in poweroff and reboot handlers. Inspired by cf84dc0bb40f4 ("mfd: rn5t618: Make restart handler atomic safe") - Use a list of known-working firmware versions instead of checking for a known-incompatible version - Prefix registers with NTXEC_REG_ - Define register values as constants - Various style cleanups as suggested by Lee Jones - Don't align = signs in struct initializers [Uwe Kleine-König] - Don't use dev_dbg for an error message - Explain sleep in poweroff handler - Remove (struct ntxec).client - Switch to .probe_new in i2c driver - Add .remove callback - Make CONFIG_MFD_NTXEC a tristate option --- drivers/mfd/Kconfig | 11 ++ drivers/mfd/Makefile | 1 + drivers/mfd/ntxec.c | 216 ++++++++++++++++++++++++++++++++++++++ include/linux/mfd/ntxec.h | 34 ++++++ 4 files changed, 262 insertions(+) create mode 100644 drivers/mfd/ntxec.c create mode 100644 include/linux/mfd/ntxec.h -- 2.29.2 diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig index 8b99a13669bfc..d96751f884dc6 100644 --- a/drivers/mfd/Kconfig +++ b/drivers/mfd/Kconfig @@ -990,6 +990,17 @@ config MFD_VIPERBOARD You need to select the mfd cell drivers separately. The drivers do not support all features the board exposes. +config MFD_NTXEC + tristate "Netronix embedded controller (EC)" + depends on OF || COMPILE_TEST + depends on I2C + select REGMAP_I2C + select MFD_CORE + help + Say yes here if you want to support the embedded controller found in + certain e-book readers designed by the original design manufacturer + Netronix. + config MFD_RETU tristate "Nokia Retu and Tahvo multi-function device" select MFD_CORE diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile index 1780019d24748..815c99b84019e 100644 --- a/drivers/mfd/Makefile +++ b/drivers/mfd/Makefile @@ -218,6 +218,7 @@ obj-$(CONFIG_MFD_INTEL_MSIC) += intel_msic.o obj-$(CONFIG_MFD_INTEL_PMC_BXT) += intel_pmc_bxt.o obj-$(CONFIG_MFD_PALMAS) += palmas.o obj-$(CONFIG_MFD_VIPERBOARD) += viperboard.o +obj-$(CONFIG_MFD_NTXEC) += ntxec.o obj-$(CONFIG_MFD_RC5T583) += rc5t583.o rc5t583-irq.o obj-$(CONFIG_MFD_RK808) += rk808.o obj-$(CONFIG_MFD_RN5T618) += rn5t618.o diff --git a/drivers/mfd/ntxec.c b/drivers/mfd/ntxec.c new file mode 100644 index 0000000000000..c1510711d7363 --- /dev/null +++ b/drivers/mfd/ntxec.c @@ -0,0 +1,216 @@ +// SPDX-License-Identifier: GPL-2.0-or-later +/* + * The Netronix embedded controller is a microcontroller found in some + * e-book readers designed by the original design manufacturer Netronix, Inc. + * It contains RTC, battery monitoring, system power management, and PWM + * functionality. + * + * This driver implements register access, version detection, and system + * power-off/reset. + * + * Copyright 2020 Jonathan Neuschäfer + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#define NTXEC_REG_VERSION 0x00 +#define NTXEC_REG_POWEROFF 0x50 +#define NTXEC_REG_POWERKEEP 0x70 +#define NTXEC_REG_RESET 0x90 + +#define NTXEC_POWEROFF_VALUE 0x0100 +#define NTXEC_POWERKEEP_VALUE 0x0800 +#define NTXEC_RESET_VALUE 0xff00 + +static struct i2c_client *poweroff_restart_client; + +static void ntxec_poweroff(void) +{ + int res; + u8 buf[3] = { NTXEC_REG_POWEROFF }; + struct i2c_msg msgs[] = { + { + .addr = poweroff_restart_client->addr, + .flags = 0, + .len = sizeof(buf), + .buf = buf, + }, + }; + + put_unaligned_be16(NTXEC_POWEROFF_VALUE, buf + 1); + + res = i2c_transfer(poweroff_restart_client->adapter, msgs, ARRAY_SIZE(msgs)); + if (res < 0) + dev_warn(&poweroff_restart_client->dev, + "Failed to power off (err = %d)\n", res); + + /* + * The time from the register write until the host CPU is powered off + * has been observed to be about 2.5 to 3 seconds. Sleep long enough to + * safely avoid returning from the poweroff handler. + */ + msleep(5000); +} + +static int ntxec_restart(struct notifier_block *nb, + unsigned long action, void *data) +{ + int res; + u8 buf[3] = { NTXEC_REG_RESET }; + /* + * NOTE: The lower half of the reset value is not sent, because sending + * it causes an I2C error. (The reset handler in the downstream driver + * does send the full two-byte value, but doesn't check the result). + */ + struct i2c_msg msgs[] = { + { + .addr = poweroff_restart_client->addr, + .flags = 0, + .len = sizeof(buf) - 1, + .buf = buf, + }, + }; + + put_unaligned_be16(NTXEC_RESET_VALUE, buf + 1); + + res = i2c_transfer(poweroff_restart_client->adapter, msgs, ARRAY_SIZE(msgs)); + if (res < 0) + dev_warn(&poweroff_restart_client->dev, + "Failed to restart (err = %d)\n", res); + + return NOTIFY_DONE; +} + +static struct notifier_block ntxec_restart_handler = { + .notifier_call = ntxec_restart, + .priority = 128, +}; + +static const struct regmap_config regmap_config = { + .name = "ntxec", + .reg_bits = 8, + .val_bits = 16, + .cache_type = REGCACHE_NONE, + .val_format_endian = REGMAP_ENDIAN_BIG, +}; + +static const struct mfd_cell ntxec_subdevices[] = { + { .name = "ntxec-rtc" }, + { .name = "ntxec-pwm" }, +}; + +static int ntxec_probe(struct i2c_client *client) +{ + struct ntxec *ec; + unsigned int version; + int res; + + ec = devm_kmalloc(&client->dev, sizeof(*ec), GFP_KERNEL); + if (!ec) + return -ENOMEM; + + ec->dev = &client->dev; + + ec->regmap = devm_regmap_init_i2c(client, ®map_config); + if (IS_ERR(ec->regmap)) { + dev_err(ec->dev, "Failed to set up regmap for device\n"); + return res; + } + + /* Determine the firmware version */ + res = regmap_read(ec->regmap, NTXEC_REG_VERSION, &version); + if (res < 0) { + dev_err(ec->dev, "Failed to read firmware version number\n"); + return res; + } + + /* Bail out if we encounter an unknown firmware version */ + switch (version) { + case 0xd726: /* found in Kobo Aura */ + break; + default: + dev_err(ec->dev, + "Netronix embedded controller version %04x is not supported.\n", + version); + return -ENODEV; + } + + dev_info(ec->dev, + "Netronix embedded controller version %04x detected.\n", version); + + if (of_device_is_system_power_controller(ec->dev->of_node)) { + /* + * Set the 'powerkeep' bit. This is necessary on some boards + * in order to keep the system running. + */ + res = regmap_write(ec->regmap, NTXEC_REG_POWERKEEP, + NTXEC_POWERKEEP_VALUE); + if (res < 0) + return res; + + if (poweroff_restart_client) + /* + * Another instance of the driver already took + * poweroff/restart duties. + */ + dev_err(ec->dev, "poweroff_restart_client already assigned\n"); + else + poweroff_restart_client = client; + + if (pm_power_off) + /* Another driver already registered a poweroff handler. */ + dev_err(ec->dev, "pm_power_off already assigned\n"); + else + pm_power_off = ntxec_poweroff; + + res = register_restart_handler(&ntxec_restart_handler); + if (res) + dev_err(ec->dev, + "Failed to register restart handler: %d\n", res); + } + + i2c_set_clientdata(client, ec); + + res = devm_mfd_add_devices(ec->dev, PLATFORM_DEVID_NONE, ntxec_subdevices, + ARRAY_SIZE(ntxec_subdevices), NULL, 0, NULL); + if (res) + dev_err(ec->dev, "Failed to add subdevices: %d\n", res); + + return res; +} + +static int ntxec_remove(struct i2c_client *client) +{ + if (client == poweroff_restart_client) { + poweroff_restart_client = NULL; + pm_power_off = NULL; + unregister_restart_handler(&ntxec_restart_handler); + } + + return 0; +} + +static const struct of_device_id of_ntxec_match_table[] = { + { .compatible = "netronix,ntxec", }, + {} +}; + +static struct i2c_driver ntxec_driver = { + .driver = { + .name = "ntxec", + .of_match_table = of_ntxec_match_table, + }, + .probe_new = ntxec_probe, + .remove = ntxec_remove, +}; +module_i2c_driver(ntxec_driver); diff --git a/include/linux/mfd/ntxec.h b/include/linux/mfd/ntxec.h new file mode 100644 index 0000000000000..b1de91f4fdcad --- /dev/null +++ b/include/linux/mfd/ntxec.h @@ -0,0 +1,34 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* + * Copyright 2020 Jonathan Neuschäfer + * + * Register access and version information for the Netronix embedded + * controller. + */ + +#ifndef NTXEC_H +#define NTXEC_H + +#include + +struct device; +struct regmap; + +struct ntxec { + struct device *dev; + struct regmap *regmap; +}; + +/* + * Some registers, such as the battery status register (0x41), are in + * big-endian, but others only have eight significant bits, which are in the + * first byte transmitted over I2C (the MSB of the big-endian value). + * This convenience function converts an 8-bit value to 16-bit for use in the + * second kind of register. + */ +static inline __be16 ntxec_reg8(u8 value) +{ + return value << 8; +} + +#endif From patchwork Tue Dec 8 01:09:57 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?J=2E_Neusch=C3=A4fer?= X-Patchwork-Id: 1412393 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-rtc-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmx.net Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.a=rsa-sha256 header.s=badeba3b8450 header.b=GpOxOKaz; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4CqkJ21RvDz9s0b for ; Tue, 8 Dec 2020 13:13:54 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727857AbgLHCNN (ORCPT ); Mon, 7 Dec 2020 21:13:13 -0500 Received: from mout.gmx.net ([212.227.17.22]:47989 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727179AbgLHCNM (ORCPT ); Mon, 7 Dec 2020 21:13:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1607393448; bh=3bUR5RteUD84SV4r5mV8wbesUNH5mHlrCIlD61Ezsb8=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To:References; b=GpOxOKazJK2drKKsnFN1u0m80/I6HOd+1jHzm4pGyCJnZj3/rUm9HxFssVb7W00HP yK5ttwZCmP8bDEzR6Vy3g0yy32Juxm+xPo57GpZwhUY/k5Ikt6blNQU0k0yB1Vn+20 6dlQp4U6J4AV1szC67bJrYf2ymDc6ffuvcJyrhZY= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from longitude ([37.201.214.162]) by mail.gmx.com (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MxUnp-1jxxNR2RZ3-00xow7; Tue, 08 Dec 2020 03:10:48 +0100 From: =?utf-8?q?Jonathan_Neusch=C3=A4fer?= To: linux-kernel@vger.kernel.org Cc: Lee Jones , Rob Herring , =?utf-8?q?Jonathan_Neusch=C3=A4fer?= , Thierry Reding , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Alessandro Zummo , Alexandre Belloni , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Sam Ravnborg , Linus Walleij , Heiko Stuebner , Stephan Gerhold , Lubomir Rintel , Mark Brown , allen , Mauro Carvalho Chehab , "David S. Miller" , devicetree@vger.kernel.org, linux-pwm@vger.kernel.org, linux-rtc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Heiko Stuebner , Josua Mayer , Andreas Kemnade , Arnd Bergmann , Daniel Palmer , Andy Shevchenko Subject: [PATCH v6 4/7] pwm: ntxec: Add driver for PWM function in Netronix EC Date: Tue, 8 Dec 2020 02:09:57 +0100 Message-Id: <20201208011000.3060239-5-j.neuschaefer@gmx.net> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201208011000.3060239-1-j.neuschaefer@gmx.net> References: <20201208011000.3060239-1-j.neuschaefer@gmx.net> MIME-Version: 1.0 X-Provags-ID: V03:K1:lWxKGJoo4ovv72PsBhWyfkQEz3XncuYbVKUdDerj9SxbRXx8cEs BRwsimzOE9o9dmHlfjjMFMzYB0r7qixz9FIKhD4v83QmpzWRfCOeKUlsjP+WUM/OAuT1QTt C+BHt0HbNEHJM65wvTipykCkfAG1FsNP3wq9hdE5GBRzaLtMotlNLW+nN0XntQc+zbtw6vP +BHQ9+l23JMbVeMfzk8ag== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:MCDXIrndLd4=:SHndr/Vcwfw55Ey8iZdX6x gMhcVeCi9cQd0sRhhWhp9TYyXYAn9+rgSzMzqF09W/M0uLS/UeZIUc48lwioaiEKQerPR3JpX YDAJ/aPg30K06hz8Xy/laOoHVG+Fqt2nLfzmSOBM54+UnZFMRcQVkfdiT0WY+Yam2+w8RPzuT djFpbu2HAir/XoHIZeKrtIdzqxCjhYYAz9XxqCFY9BBeXVGtzluveWkTpp3Sv0p1WSjqort8W TeZSrDmGLDkY+l+xJUBhm0Xxhbg/uEGMGoZ5AdIr02eUOynQYO67PHijbe5kebLu0lc8znCyD pI8yIgcUSYnc8/vOkve3hbmnotFNaNamRnHZKnfkAe7MqhZHjU0V/dEidtNZZZHELvhgWPGbp PfSYNOIBT7zPQvIRFHTU9pEnkAZdFRpzYagKGhTQPmT1ng36beJA6v3PpItBTwCq7nCFgvqaG /IoqD+etNDP+M7OJ3tzER3wUmR++btoNj6YhJtk+Ek1mxNIaeZ3RrHwD9vMSsr00DArbYHiWB PTFz8dG4xQDRq1K00C0hyNhn0R8izVk9WjTAEWnsLI8zo0XsUt/a+egFaqGFWo1qoQCAjl4Cx Yp/eFXhvuGfKfI6H+8k9zOdyrtJb8vpgCP8lGF2nx6ayueh5xfOVyBl6eBJbg5bcmvfaiP6Ov JN18PyI5vWm820X5zIXj6j8fIKAiXEJArbuCzp37igD+KAD64v23qi9jFTFE7KbfjnoxUq083 X3ApuezylOD6nTVTfMGOX7/U5sORgquFGIbGRxUijDEuPC2mKtTvetXd6UIDA7agflkubnpEr J7qKgdvEo/pOg5TOO0ZkC8CBNgRNJoyCyvoWK5jFQAMM8edL5v+O6GEpd7NUcOaHi1VRicrTl 3URRkx2be8sFjmbxKgVQ== Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org The Netronix EC provides a PWM output which is used for the backlight on some ebook readers. This patches adds a driver for the PWM output. The .get_state callback is not implemented, because the PWM state can't be read back from the hardware. Signed-off-by: Jonathan Neuschäfer --- v6: - Move period / duty cycle setting code to a function - Rename pwmchip_to_priv to ntxec_pwm_from_chip - Set period and duty cycle only before enabling the output - Mention that duty=0, enable=1 is assumed not to happen - Interleave writes to the period and duty cycle registers, to minimize the window of time that an inconsistent state is configured v5: - https://lore.kernel.org/lkml/20201201011513.1627028-5-j.neuschaefer@gmx.net/ - Avoid truncation of period and duty cycle to 32 bits - Make ntxec_pwm_ops const - Use regmap_multi_reg_write - Add comment about get_state to ntxec_pwm_ops - Add comments about non-atomicity of (period, duty cycle) update v4: - https://lore.kernel.org/lkml/20201122222739.1455132-5-j.neuschaefer@gmx.net/ - Document hardware/driver limitations - Only accept normal polarity - Fix a typo ("zone" -> "zero") - change MAX_PERIOD_NS to 0xffff * 125 - Clamp period to the maximum rather than returning an error - Rename private struct pointer to priv - Rearrage control flow in _probe to save a few lines and a temporary variable - Add missing MODULE_ALIAS line - Spell out ODM v3: - https://lore.kernel.org/lkml/20200924192455.2484005-5-j.neuschaefer@gmx.net/ - Relicense as GPLv2 or later - Add email address to copyright line - Remove OF compatible string and don't include linux/of_device.h - Fix bogus ?: in return line - Don't use a comma after sentinels - Avoid ret |= ... pattern - Move 8-bit register conversion to ntxec.h v2: - https://lore.kernel.org/lkml/20200905133230.1014581-6-j.neuschaefer@gmx.net/ - Various grammar and style improvements, as suggested by Uwe Kleine-König, Lee Jones, and Alexandre Belloni - Switch to regmap - Prefix registers with NTXEC_REG_ - Add help text to the Kconfig option - Use the .apply callback instead of the old API - Add a #define for the time base (125ns) - Don't change device state in .probe; this avoids multiple problems - Rework division and overflow check logic to perform divisions in 32 bits - Avoid setting duty cycle to zero, to work around a hardware quirk --- drivers/pwm/Kconfig | 8 ++ drivers/pwm/Makefile | 1 + drivers/pwm/pwm-ntxec.c | 182 ++++++++++++++++++++++++++++++++++++++++ 3 files changed, 191 insertions(+) create mode 100644 drivers/pwm/pwm-ntxec.c -- 2.29.2 diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig index 63be5362fd3a5..815f329ed5b46 100644 --- a/drivers/pwm/Kconfig +++ b/drivers/pwm/Kconfig @@ -350,6 +350,14 @@ config PWM_MXS To compile this driver as a module, choose M here: the module will be called pwm-mxs. +config PWM_NTXEC + tristate "Netronix embedded controller PWM support" + depends on MFD_NTXEC + help + Say yes here if you want to support the PWM output of the embedded + controller found in certain e-book readers designed by the original + design manufacturer Netronix. + config PWM_OMAP_DMTIMER tristate "OMAP Dual-Mode Timer PWM support" depends on OF diff --git a/drivers/pwm/Makefile b/drivers/pwm/Makefile index cbdcd55d69eef..1deb29e6ae8e5 100644 --- a/drivers/pwm/Makefile +++ b/drivers/pwm/Makefile @@ -32,6 +32,7 @@ obj-$(CONFIG_PWM_MESON) += pwm-meson.o obj-$(CONFIG_PWM_MEDIATEK) += pwm-mediatek.o obj-$(CONFIG_PWM_MTK_DISP) += pwm-mtk-disp.o obj-$(CONFIG_PWM_MXS) += pwm-mxs.o +obj-$(CONFIG_PWM_NTXEC) += pwm-ntxec.o obj-$(CONFIG_PWM_OMAP_DMTIMER) += pwm-omap-dmtimer.o obj-$(CONFIG_PWM_PCA9685) += pwm-pca9685.o obj-$(CONFIG_PWM_PXA) += pwm-pxa.o diff --git a/drivers/pwm/pwm-ntxec.c b/drivers/pwm/pwm-ntxec.c new file mode 100644 index 0000000000000..1db30a6caa3ad --- /dev/null +++ b/drivers/pwm/pwm-ntxec.c @@ -0,0 +1,182 @@ +// SPDX-License-Identifier: GPL-2.0-or-later +/* + * The Netronix embedded controller is a microcontroller found in some + * e-book readers designed by the original design manufacturer Netronix, Inc. + * It contains RTC, battery monitoring, system power management, and PWM + * functionality. + * + * This driver implements PWM output. + * + * Copyright 2020 Jonathan Neuschäfer + * + * Limitations: + * - The get_state callback is not implemented, because the current state of + * the PWM output can't be read back from the hardware. + * - The hardware can only generate normal polarity output. + * - The period and duty cycle can't be changed together in one atomic action. + */ + +#include +#include +#include +#include +#include +#include + +struct ntxec_pwm { + struct device *dev; + struct ntxec *ec; + struct pwm_chip chip; +}; + +static struct ntxec_pwm *ntxec_pwm_from_chip(struct pwm_chip *chip) +{ + return container_of(chip, struct ntxec_pwm, chip); +} + +#define NTXEC_REG_AUTO_OFF_HI 0xa1 +#define NTXEC_REG_AUTO_OFF_LO 0xa2 +#define NTXEC_REG_ENABLE 0xa3 +#define NTXEC_REG_PERIOD_LOW 0xa4 +#define NTXEC_REG_PERIOD_HIGH 0xa5 +#define NTXEC_REG_DUTY_LOW 0xa6 +#define NTXEC_REG_DUTY_HIGH 0xa7 + +/* + * The time base used in the EC is 8MHz, or 125ns. Period and duty cycle are + * measured in this unit. + */ +#define TIME_BASE_NS 125 + +/* + * The maximum input value (in nanoseconds) is determined by the time base and + * the range of the hardware registers that hold the converted value. + * It fits into 32 bits, so we can do our calculations in 32 bits as well. + */ +#define MAX_PERIOD_NS (TIME_BASE_NS * 0xffff) + +static int ntxec_pwm_set_raw_period_and_duty_cycle(struct pwm_chip *chip, + int period, int duty) +{ + struct ntxec_pwm *priv = ntxec_pwm_from_chip(chip); + + /* + * Changes to the period and duty cycle take effect as soon as the + * corresponding low byte is written, so the hardware may be configured + * to an inconsistent state after the period is written and before the + * duty cycle is fully written. If, in such a case, the old duty cycle + * is longer than the new period, the EC may output 100% for a moment. + * + * To minimize the time between the changes to period and duty cycle + * taking effect, the writes are interleaved. + */ + + struct reg_sequence regs[] = { + { NTXEC_REG_PERIOD_HIGH, ntxec_reg8(period >> 8) }, + { NTXEC_REG_DUTY_HIGH, ntxec_reg8(duty >> 8) }, + { NTXEC_REG_PERIOD_LOW, ntxec_reg8(period) }, + { NTXEC_REG_DUTY_LOW, ntxec_reg8(duty) }, + }; + + return regmap_multi_reg_write(priv->ec->regmap, regs, ARRAY_SIZE(regs)); +} + +static int ntxec_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm_dev, + const struct pwm_state *state) +{ + struct ntxec_pwm *priv = ntxec_pwm_from_chip(chip); + unsigned int period, duty; + int res; + + if (state->polarity != PWM_POLARITY_NORMAL) + return -EINVAL; + + period = min_t(u64, state->period, MAX_PERIOD_NS); + duty = min_t(u64, state->duty_cycle, period); + + period /= TIME_BASE_NS; + duty /= TIME_BASE_NS; + + /* + * Writing a duty cycle of zero puts the device into a state where + * writing a higher duty cycle doesn't result in the brightness that it + * usually results in. This can be fixed by cycling the ENABLE register. + * + * As a workaround, write ENABLE=0 when the duty cycle is zero. + * The case that something has previously set the duty cycle to zero + * but ENABLE=1, is not handled. + */ + if (state->enabled && duty != 0) { + res = ntxec_pwm_set_raw_period_and_duty_cycle(chip, period, duty); + if (res) + return res; + + res = regmap_write(priv->ec->regmap, NTXEC_REG_ENABLE, ntxec_reg8(1)); + if (res) + return res; + + /* Disable the auto-off timer */ + res = regmap_write(priv->ec->regmap, NTXEC_REG_AUTO_OFF_HI, ntxec_reg8(0xff)); + if (res) + return res; + + return regmap_write(priv->ec->regmap, NTXEC_REG_AUTO_OFF_LO, ntxec_reg8(0xff)); + } else { + return regmap_write(priv->ec->regmap, NTXEC_REG_ENABLE, ntxec_reg8(0)); + } +} + +static const struct pwm_ops ntxec_pwm_ops = { + .owner = THIS_MODULE, + .apply = ntxec_pwm_apply, + /* + * No .get_state callback, because the current state cannot be read + * back from the hardware. + */ +}; + +static int ntxec_pwm_probe(struct platform_device *pdev) +{ + struct ntxec *ec = dev_get_drvdata(pdev->dev.parent); + struct ntxec_pwm *priv; + struct pwm_chip *chip; + + priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL); + if (!priv) + return -ENOMEM; + + priv->ec = ec; + priv->dev = &pdev->dev; + + platform_set_drvdata(pdev, priv); + + chip = &priv->chip; + chip->dev = &pdev->dev; + chip->ops = &ntxec_pwm_ops; + chip->base = -1; + chip->npwm = 1; + + return pwmchip_add(chip); +} + +static int ntxec_pwm_remove(struct platform_device *pdev) +{ + struct ntxec_pwm *priv = platform_get_drvdata(pdev); + struct pwm_chip *chip = &priv->chip; + + return pwmchip_remove(chip); +} + +static struct platform_driver ntxec_pwm_driver = { + .driver = { + .name = "ntxec-pwm", + }, + .probe = ntxec_pwm_probe, + .remove = ntxec_pwm_remove, +}; +module_platform_driver(ntxec_pwm_driver); + +MODULE_AUTHOR("Jonathan Neuschäfer "); +MODULE_DESCRIPTION("PWM driver for Netronix EC"); +MODULE_LICENSE("GPL"); +MODULE_ALIAS("platform:ntxec-pwm"); From patchwork Tue Dec 8 01:09:58 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?J=2E_Neusch=C3=A4fer?= X-Patchwork-Id: 1412392 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-rtc-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmx.net Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.a=rsa-sha256 header.s=badeba3b8450 header.b=A8pr6+cN; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4CqkJ159HPz9sWK for ; Tue, 8 Dec 2020 13:13:53 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727810AbgLHCNK (ORCPT ); Mon, 7 Dec 2020 21:13:10 -0500 Received: from mout.gmx.net ([212.227.15.18]:34417 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726830AbgLHCNK (ORCPT ); Mon, 7 Dec 2020 21:13:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1607393457; bh=F3QtjZZG93hHA6vRPJKE8IwnWeenHV4ItwEp0aN02oM=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To:References; b=A8pr6+cN7UcqKm8MIbbVL/YVBiqwVGeSWa6NFTB80MWN0i6kwDsAKCnrTL+zb/qhL hjiy6KXg2jhbxk38iyIC7Ugnn+0+LWFSEsHcR5SS/tJoiYFUR3Ftz7SkRa/SJGLO/f z/DtsZpb4AF5398cMlsLHInROT21twXqofLbxoh8= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from longitude ([37.201.214.162]) by mail.gmx.com (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MjjCL-1kJQMs0Psp-00lDBu; Tue, 08 Dec 2020 03:10:57 +0100 From: =?utf-8?q?Jonathan_Neusch=C3=A4fer?= To: linux-kernel@vger.kernel.org Cc: Lee Jones , Rob Herring , =?utf-8?q?Jonathan_Neusch=C3=A4fer?= , Thierry Reding , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Alessandro Zummo , Alexandre Belloni , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Sam Ravnborg , Linus Walleij , Heiko Stuebner , Stephan Gerhold , Lubomir Rintel , Mark Brown , allen , Mauro Carvalho Chehab , "David S. Miller" , devicetree@vger.kernel.org, linux-pwm@vger.kernel.org, linux-rtc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Heiko Stuebner , Josua Mayer , Andreas Kemnade , Arnd Bergmann , Daniel Palmer , Andy Shevchenko Subject: [PATCH v6 5/7] rtc: New driver for RTC in Netronix embedded controller Date: Tue, 8 Dec 2020 02:09:58 +0100 Message-Id: <20201208011000.3060239-6-j.neuschaefer@gmx.net> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201208011000.3060239-1-j.neuschaefer@gmx.net> References: <20201208011000.3060239-1-j.neuschaefer@gmx.net> MIME-Version: 1.0 X-Provags-ID: V03:K1:sht59cd5i0srtO/cpZxBHhJuGkEEFFbVQJvUZwFZz3n/KIHtPvt yvetNFklqpjWwZS5aN7V0p+EFevvEjq2r3+buaaHnB0PRmm4PWj3eFRPSTB0FiIqe7fYq8r yagYGoU+542qE9GqAjNbpvU6bjTPW/VaK+eH2rnzUnEVlf38WqZ//Zp18Av1xmNUOodVoYQ XOnhfDcZiZVjZGRsWxQig== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:bjPLcYvEBSU=:llMiPVdh3HdX1gZn2OzTPV LUJlYJKYnyJTRk8UyUNsaan4DanqNXX2vvDCtlf5yGLuyirGzCpiuQXAQanasMpF+dsw1m3J/ N5xyX4bZoUNuovqn0Bxt/rQrtPMAp9U6QBqdSPOayIj20mjeEK1pCfcEfk14hnm/5seqdiHfs nyPwrJWYkp2clq8VL9yk2nG3Kez46lBZdLiPQuUXE93d9le/HZ5rRpViX4U+fUhQEQwGToGIU FUetirHt3G6Ln9rs6YMEu6Obw9Tnhso7yOkF1MGrvVJm6TaezI2ikM7YlBRxzbhOy5DDVAW2G RtgWDBo87Na9YdtJBGlvIHvsaHKUtHhc4EXQxm/u8674iAolT3p4m5e+eGxuM1VcWiqrDDZKo +Y+BJnFdKaSVtKV4+cFd72zkEOYJ7LzrFFXAzDIxvjcVFqHnsoEvNus0Zo4owXhHQwPAsYQ8y XOEHIF2QiPWrjnT4l687nhGI/wIKtXkPiu0bjej63LF72GD4bgAFDB5nFf84EDvGuI+dfjrPK olRTZEq8eXvOK0ODSFpQeUrWkxBZSjdmoQCKlgleg8bjgUaEsY84Iv0GbcHiI/xTGK45VCq9M ueaWovJa3ZmusAiZMO2PgfZrzkPjDzGVkP6lREn2lmhjdjjYu+I9ZGa+qAjTx6ajJVreDOBH9 UREqEZHRxoWkbnviUD0x4gO68+AiWgkZ60gCRsdvfaC8ODgyzTSdEaMHXTZLwsiGtrjC/67WE tkWORYu8Ldb+qHqbRQif9NJ37RKhGu2aOfQO1q3TywGkkygeyQ56OPa1d/c7YCTOIJp5v/oTa iXmFzCOCkoNHFX39xMf8XWN/r0FsGiuTNw7LuRWllOdnlC2d7Dbgji08REs11IVb5Qjjs5Q3B xa1WZ8toatv1qnHigEfg== Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org With this driver, mainline Linux can keep its time and date in sync with the vendor kernel. Advanced functionality like alarm and automatic power-on is not yet supported. Signed-off-by: Jonathan Neuschäfer Acked-by: Alexandre Belloni --- v6: - no changes v5: - Add Alexandre Belloni's A-b - Use regmap_multi_reg_write v4: - https://lore.kernel.org/lkml/20201122222739.1455132-6-j.neuschaefer@gmx.net/ - Remove "driver" from Kconfig entry for consistency with most other entries - Add missing MODULE_ALIAS line - Give NTXEC_REG_READ_ macros longer names - Solve the read tearing issue using Alexandre Belloni's algorithm - Solve the write tearing issue using Uwe Kleine-König's algorithm - Spell out ODM v3: - https://lore.kernel.org/lkml/20200924192455.2484005-6-j.neuschaefer@gmx.net/ - Add email address to copyright line - Remove OF compatible string and don't include linux/of_device.h - Don't use a comma after sentinels - Avoid ret |= ... pattern - Move 8-bit register conversion to ntxec.h - Relicense as GPLv2 or later v2: - https://lore.kernel.org/lkml/20200905133230.1014581-7-j.neuschaefer@gmx.net/ - Rework top-of-file comment [Lee Jones] - Sort the #include lines [Alexandre Belloni] - don't align = signs in struct initializers [Uwe Kleine-König] - Switch to regmap - Fix register number used to read minutes and seconds - Prefix registers with NTXEC_REG_ - Add help text to the Kconfig option - Use devm_rtc_allocate_device and rtc_register_device, set ->range_min and ->range_max --- drivers/rtc/Kconfig | 8 +++ drivers/rtc/Makefile | 1 + drivers/rtc/rtc-ntxec.c | 143 ++++++++++++++++++++++++++++++++++++++++ 3 files changed, 152 insertions(+) create mode 100644 drivers/rtc/rtc-ntxec.c -- 2.29.2 diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig index 65ad9d0b47ab1..fe009949728b3 100644 --- a/drivers/rtc/Kconfig +++ b/drivers/rtc/Kconfig @@ -1311,6 +1311,14 @@ config RTC_DRV_CROS_EC This driver can also be built as a module. If so, the module will be called rtc-cros-ec. +config RTC_DRV_NTXEC + tristate "Netronix embedded controller RTC" + depends on MFD_NTXEC + help + Say yes here if you want to support the RTC functionality of the + embedded controller found in certain e-book readers designed by the + original design manufacturer Netronix. + comment "on-CPU RTC drivers" config RTC_DRV_ASM9260 diff --git a/drivers/rtc/Makefile b/drivers/rtc/Makefile index bfb57464118d0..5f2a7582b2780 100644 --- a/drivers/rtc/Makefile +++ b/drivers/rtc/Makefile @@ -111,6 +111,7 @@ obj-$(CONFIG_RTC_DRV_MT7622) += rtc-mt7622.o obj-$(CONFIG_RTC_DRV_MV) += rtc-mv.o obj-$(CONFIG_RTC_DRV_MXC) += rtc-mxc.o obj-$(CONFIG_RTC_DRV_MXC_V2) += rtc-mxc_v2.o +obj-$(CONFIG_RTC_DRV_NTXEC) += rtc-ntxec.o obj-$(CONFIG_RTC_DRV_OMAP) += rtc-omap.o obj-$(CONFIG_RTC_DRV_OPAL) += rtc-opal.o obj-$(CONFIG_RTC_DRV_PALMAS) += rtc-palmas.o diff --git a/drivers/rtc/rtc-ntxec.c b/drivers/rtc/rtc-ntxec.c new file mode 100644 index 0000000000000..c7cff7802895b --- /dev/null +++ b/drivers/rtc/rtc-ntxec.c @@ -0,0 +1,143 @@ +// SPDX-License-Identifier: GPL-2.0-or-later +/* + * The Netronix embedded controller is a microcontroller found in some + * e-book readers designed by the original design manufacturer Netronix, Inc. + * It contains RTC, battery monitoring, system power management, and PWM + * functionality. + * + * This driver implements access to the RTC time and date. + * + * Copyright 2020 Jonathan Neuschäfer + */ + +#include +#include +#include +#include +#include +#include + +struct ntxec_rtc { + struct device *dev; + struct ntxec *ec; +}; + +#define NTXEC_REG_WRITE_YEAR 0x10 +#define NTXEC_REG_WRITE_MONTH 0x11 +#define NTXEC_REG_WRITE_DAY 0x12 +#define NTXEC_REG_WRITE_HOUR 0x13 +#define NTXEC_REG_WRITE_MINUTE 0x14 +#define NTXEC_REG_WRITE_SECOND 0x15 + +#define NTXEC_REG_READ_YEAR_MONTH 0x20 +#define NTXEC_REG_READ_MDAY_HOUR 0x21 +#define NTXEC_REG_READ_MINUTE_SECOND 0x23 + +static int ntxec_read_time(struct device *dev, struct rtc_time *tm) +{ + struct ntxec_rtc *rtc = dev_get_drvdata(dev); + unsigned int value; + int res; + +retry: + res = regmap_read(rtc->ec->regmap, NTXEC_REG_READ_MINUTE_SECOND, &value); + if (res < 0) + return res; + + tm->tm_min = value >> 8; + tm->tm_sec = value & 0xff; + + res = regmap_read(rtc->ec->regmap, NTXEC_REG_READ_MDAY_HOUR, &value); + if (res < 0) + return res; + + tm->tm_mday = value >> 8; + tm->tm_hour = value & 0xff; + + res = regmap_read(rtc->ec->regmap, NTXEC_REG_READ_YEAR_MONTH, &value); + if (res < 0) + return res; + + tm->tm_year = (value >> 8) + 100; + tm->tm_mon = (value & 0xff) - 1; + + /* + * Read the minutes/seconds field again. If it changed since the first + * read, we can't assume that the values read so far are consistent, + * and should start from the beginning. + */ + res = regmap_read(rtc->ec->regmap, NTXEC_REG_READ_MINUTE_SECOND, &value); + if (res < 0) + return res; + + if (tm->tm_min != value >> 8 || tm->tm_sec != (value & 0xff)) + goto retry; + + return 0; +} + +static int ntxec_set_time(struct device *dev, struct rtc_time *tm) +{ + struct ntxec_rtc *rtc = dev_get_drvdata(dev); + + /* + * To avoid time overflows while we're writing the full date/time, + * set the seconds field to zero before doing anything else. For the + * next 59 seconds (plus however long it takes until the RTC's next + * update of the second field), the seconds field will not overflow + * into the other fields. + */ + struct reg_sequence regs[] = { + { NTXEC_REG_WRITE_SECOND, ntxec_reg8(0) }, + { NTXEC_REG_WRITE_YEAR, ntxec_reg8(tm->tm_year - 100) }, + { NTXEC_REG_WRITE_MONTH, ntxec_reg8(tm->tm_mon + 1) }, + { NTXEC_REG_WRITE_DAY, ntxec_reg8(tm->tm_mday) }, + { NTXEC_REG_WRITE_HOUR, ntxec_reg8(tm->tm_hour) }, + { NTXEC_REG_WRITE_MINUTE, ntxec_reg8(tm->tm_min) }, + { NTXEC_REG_WRITE_SECOND, ntxec_reg8(tm->tm_sec) }, + }; + + return regmap_multi_reg_write(rtc->ec->regmap, regs, ARRAY_SIZE(regs)); +} + +static const struct rtc_class_ops ntxec_rtc_ops = { + .read_time = ntxec_read_time, + .set_time = ntxec_set_time, +}; + +static int ntxec_rtc_probe(struct platform_device *pdev) +{ + struct rtc_device *dev; + struct ntxec_rtc *rtc; + + rtc = devm_kzalloc(&pdev->dev, sizeof(*rtc), GFP_KERNEL); + if (!rtc) + return -ENOMEM; + + rtc->dev = &pdev->dev; + rtc->ec = dev_get_drvdata(pdev->dev.parent); + platform_set_drvdata(pdev, rtc); + + dev = devm_rtc_allocate_device(&pdev->dev); + if (IS_ERR(dev)) + return PTR_ERR(dev); + + dev->ops = &ntxec_rtc_ops; + dev->range_min = RTC_TIMESTAMP_BEGIN_2000; + dev->range_max = 9025257599LL; /* 2255-12-31 23:59:59 */ + + return rtc_register_device(dev); +} + +static struct platform_driver ntxec_rtc_driver = { + .driver = { + .name = "ntxec-rtc", + }, + .probe = ntxec_rtc_probe, +}; +module_platform_driver(ntxec_rtc_driver); + +MODULE_AUTHOR("Jonathan Neuschäfer "); +MODULE_DESCRIPTION("RTC driver for Netronix EC"); +MODULE_LICENSE("GPL"); +MODULE_ALIAS("platform:ntxec-rtc"); From patchwork Tue Dec 8 01:09:59 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?J=2E_Neusch=C3=A4fer?= X-Patchwork-Id: 1412397 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-rtc-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmx.net Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.a=rsa-sha256 header.s=badeba3b8450 header.b=c/gMM1Jw; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4CqkJ51b7gz9sWK for ; Tue, 8 Dec 2020 13:13:57 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727877AbgLHCNO (ORCPT ); Mon, 7 Dec 2020 21:13:14 -0500 Received: from mout.gmx.net ([212.227.17.21]:60517 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726830AbgLHCNN (ORCPT ); Mon, 7 Dec 2020 21:13:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1607393458; bh=WBl3UrUkR8LNzp1EKh9L7GsYc+XMH2QlTuD5DMeOSsI=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To:References; b=c/gMM1JwkqA70r2eT8hu0Vm9AHadbAa4uktdnkzeVYuQeEOnSrXJgD+mxvVojzpEY SNf2B3GhVvtGK+ouAFOcWXGWrSz6Sp+UevQ+HU9swhV4Z3Zcr7+fQGXNx1He21DmLX GBblwFY7zGouMnTCnrJ9agL3m1r3GI+KIEm24/kQ= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from longitude ([37.201.214.162]) by mail.gmx.com (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MybGX-1jwrRn2A7J-00yuzK; Tue, 08 Dec 2020 03:10:58 +0100 From: =?utf-8?q?Jonathan_Neusch=C3=A4fer?= To: linux-kernel@vger.kernel.org Cc: Lee Jones , Rob Herring , =?utf-8?q?Jonathan_Neusch=C3=A4fer?= , Thierry Reding , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Alessandro Zummo , Alexandre Belloni , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Sam Ravnborg , Linus Walleij , Heiko Stuebner , Stephan Gerhold , Lubomir Rintel , Mark Brown , allen , Mauro Carvalho Chehab , "David S. Miller" , devicetree@vger.kernel.org, linux-pwm@vger.kernel.org, linux-rtc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Heiko Stuebner , Josua Mayer , Andreas Kemnade , Arnd Bergmann , Daniel Palmer , Andy Shevchenko Subject: [PATCH v6 6/7] MAINTAINERS: Add entry for Netronix embedded controller Date: Tue, 8 Dec 2020 02:09:59 +0100 Message-Id: <20201208011000.3060239-7-j.neuschaefer@gmx.net> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201208011000.3060239-1-j.neuschaefer@gmx.net> References: <20201208011000.3060239-1-j.neuschaefer@gmx.net> MIME-Version: 1.0 X-Provags-ID: V03:K1:KrRMGiDmIbt0sBNUbCS4VOY+FTc3iGce8A+/3NciAwGds7DAC4A HU5zyIPz1YAcGXB0yBjRqBhxui/w+mWKbFBZ7CkITOfBJrecikXxPJmbwLqtlZ+kPkvfXHC n5pKbaGyqjDghlbbuyP7lQSmHJ51Ni6/TDLtwizyQ5OUwiV93GAUZm2nntPH50tKinpixa/ oV4nXdDhbB9trdckJz6Ag== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:M7CN/MeYUhE=:ZVQHiMlpAZY9664thIOZ+3 rVdlAFm00hd2Gt1Mo2SY1wLXnT3zjJH41VEZdt1hNbza93CIp6FKN+5eXOuc0qYYDke48jJmn P4ubYkj2I61CTn5W8yR6YUxQWOfPJbE1vunUwh6IZ8nYvybNmcY1KvtFan9OsAGfLjEX6kWSr vh+FnG57ORB4N5PlUM3ZQ//qylnd6puXa+rh6qZ4KDpuzvA3X26sNENoKeDYxoluwZokPd1l0 vTMFTvEOGRTlA9+y46bO5VhdH7DVqOb1I1j3FdW+IxiAVLf7zp287FQSD3Po4a6kYOPJzzFuU rJfqDGgIHbe0MdYUN2MPBSBYM2sKEuJ2mFQ8CIlqisMSfwYm+2vyFQA+DoWNc4/zHrMj+EOIy vzls3j1qvSWNH+U6tHRpuvx8jE6B+aROuoxEghc5gnzaGuj4iicblAL4Dxul10YNr7dMZbb+r RQqSyI3s4u2f5mkiBZg07T2I/9DGERGuIGlPNJGRClSOU2r3RQFPeB7CLtv+/85G9ZHkczSJP gI+j0eeJSPkLFrk76Wt2xU7lFStoe1QdBdOKzYioFFpGa3iU4eBcScFT/Rsplcv7lSynf3k2a uq8zNmOgoaet9+5NjOBT2hA9v/CQvSDZWV+HsyocU+6P6sDEXOH0FSJMEo/ZL94CFHT6/Wr87 MWoDOErflRMXAiAxcEVc9VGURa6c0/eZ7Cc98WiyuDhbN/71bRUnpSTuwPv9kpKCsmih93Fz9 ylBOFrsBSfJmzp7eYqI2ewl18ys9Dnd4AvMGNTlpuDl9+iTvibxscBJJaKOAyKopBoc+yiZoy GcrpMaVFcjoUtWgOpQ0HaTt/1LscM3ErYJyN5SFDGRZGzOVzhlUvMH5vVfJdBNHB0chSkinfa vH1/JmlYgqeehdJ90Xgw== Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org Let's make sure I'll notice when there are patches for the NTXEC drivers. Signed-off-by: Jonathan Neuschäfer --- v4-v6: - no changes v3: - https://lore.kernel.org/lkml/20200924192455.2484005-7-j.neuschaefer@gmx.net/ - Remove pwm and rtc bindings v2: - https://lore.kernel.org/lkml/20200905144503.1067124-2-j.neuschaefer@gmx.net/ - No changes --- MAINTAINERS | 9 +++++++++ 1 file changed, 9 insertions(+) -- 2.29.2 diff --git a/MAINTAINERS b/MAINTAINERS index 2daa6ee673f7f..9eedf3c1e1e09 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -12087,6 +12087,15 @@ F: include/net/netrom.h F: include/uapi/linux/netrom.h F: net/netrom/ +NETRONIX EMBEDDED CONTROLLER +M: Jonathan Neuschäfer +S: Maintained +F: Documentation/devicetree/bindings/mfd/netronix,ntxec.yaml +F: drivers/mfd/ntxec.c +F: drivers/pwm/pwm-ntxec.c +F: drivers/rtc/rtc-ntxec.c +F: include/linux/mfd/ntxec.h + NETRONOME ETHERNET DRIVERS M: Simon Horman R: Jakub Kicinski From patchwork Tue Dec 8 01:10:00 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?J=2E_Neusch=C3=A4fer?= X-Patchwork-Id: 1412395 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-rtc-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmx.net Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.a=rsa-sha256 header.s=badeba3b8450 header.b=h/s6ucfc; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4CqkJ3557Bz9sWQ for ; Tue, 8 Dec 2020 13:13:55 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727912AbgLHCNQ (ORCPT ); Mon, 7 Dec 2020 21:13:16 -0500 Received: from mout.gmx.net ([212.227.15.19]:37181 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727892AbgLHCNQ (ORCPT ); Mon, 7 Dec 2020 21:13:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1607393466; bh=OLRgMJVF5Woco/wE8srh876TdhfxC/CBxXp95Aag1Sw=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To:References; b=h/s6ucfcAiEWLKJPFuyYLAH+iY+em/PysCegmqP6m2AINFu0aMUUEKCME+fUsNw5k VjYQNKg34hGOlNNHDj/7rbnV/6Sis+eOrz1hCOcLAUSYJL8gWUJA+0PQde4/7Aw+Fg tdlO3IOh5oabvupfmWZbUWololiuP7hZDUineTMo= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from longitude ([37.201.214.162]) by mail.gmx.com (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1M8ykW-1kpEQ02tHi-0063xc; Tue, 08 Dec 2020 03:11:06 +0100 From: =?utf-8?q?Jonathan_Neusch=C3=A4fer?= To: linux-kernel@vger.kernel.org Cc: Lee Jones , Rob Herring , =?utf-8?q?Jonathan_Neusch=C3=A4fer?= , Thierry Reding , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Alessandro Zummo , Alexandre Belloni , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Sam Ravnborg , Linus Walleij , Heiko Stuebner , Stephan Gerhold , Lubomir Rintel , Mark Brown , allen , Mauro Carvalho Chehab , "David S. Miller" , devicetree@vger.kernel.org, linux-pwm@vger.kernel.org, linux-rtc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Heiko Stuebner , Josua Mayer , Andreas Kemnade , Arnd Bergmann , Daniel Palmer , Andy Shevchenko Subject: [PATCH v6 7/7] ARM: dts: imx50-kobo-aura: Add Netronix embedded controller Date: Tue, 8 Dec 2020 02:10:00 +0100 Message-Id: <20201208011000.3060239-8-j.neuschaefer@gmx.net> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201208011000.3060239-1-j.neuschaefer@gmx.net> References: <20201208011000.3060239-1-j.neuschaefer@gmx.net> MIME-Version: 1.0 X-Provags-ID: V03:K1:Hj42vB6Qt5VgXLNmP/8JQZYM4kptpRvcy4iGsqOpkwfovVUgks6 WcaKaf0DX/ow8DkZUB7XehG1fE2N1KGjZoaNLe6LvPjKwp9JCNe+ebRuXSZtP0nWOldLFnA 1D9Bt1b6hLvKp8hUCIBj3DZkUzaTPXCqH1v0YnN7muafylxCdv8fvrXf5IKfuo4ipvKZPMD CMDvtIqLqP6anv0KcmnTA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:7bZdBAIBoh8=:eSr3n2acQWh9DMJwYzNd6D 50QVJYXuhBdvO/d+HEEQuzBiICRC5g8c4BY/U/8+SMOL2+2y+cvYcdwxGbKa3uBvugL0u+MmG xL0NBLlyBCbFxEyQWnaDuX7QsCW82E1VPX3q21ki1oxDXBDAGRdJzHncVKUoqFDk6bapwwvu1 DoXMMYHsr02c0/pdL0PpAkRv/gKkDImR9BilZiEeN1rVMOeuH4LtGquod0ketLqtg4nuKXnU4 lU6L+DJiSRsPH/5sQppSieoh32+WYuxK0tGfcJuowZdXlsWIHH+RMWyx5zcoVGjqdbqpASpXL 2jLvdqsg3CYWrq6sJpIyM0VJpF7HI+N1sctwVl8Bg05X2TrDEVfklERrBt6TY1E0moqEfE3a/ 5wEvrktwFuGJvOYEH2T0UMNUIhpa3R0W+/RPY5G9c8r6hlv6ZMjhHXjUeS9dMyORAnnz0elgc IKha9ovKfK6YOB0GP+KfD6NNxzObLSmc/iMNDiwHxQwZ1tAvTYHyy8m/hDh3KwxxGYxDGlmIh 26FPx5opCvVjTYTUd2BeGwReouFMwJI7JGRik6eIEkKyD2eaw+XKrqKgsZ/8pA+YYpj3h1CDM FHh2ot19hF/CT4RQrL+I/6T6uM7kUGhPJMT81dDm5ugjqMHZk3m0e1GERkx21ikXNLC9+RkMV 3VeDCqL6INycdeE5MhZyTzLoypEjA0P77ElBL0PxFwrsU2MJ0v45ckt1U//IagUwHe69351JK IpbQgtVxcHqt6PVwZBw/XWU+Y9qrDGMocaGdWbFMjWwT9mdfGA+KffbJ1p7M/fF1/XU8TkWZR vmcabzcPtSAmRQMQaOyDFeznBfKcSiq0YKggzg9VKvSurGaD8g3fWP3NzNgvW5pUcQYxATjMD xuuMxEprrDhto9TiiOsg== Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org Enable the Netronix EC on the Kobo Aura ebook reader. Several features are still missing: - Frontlight/backlight. The vendor kernel drives the frontlight LED using the PWM output of the EC and an additional boost pin that increases the brightness. - Battery monitoring - Interrupts for RTC alarm and low-battery events Signed-off-by: Jonathan Neuschäfer --- v5, v6: - no changes v4: - Add 'grp' suffix to pinctrl node v3: - https://lore.kernel.org/lkml/20200925050818.2512375-1-j.neuschaefer@gmx.net/ - Remove interrupt-controller property from embedded-controller node - subnodes of embedded-controller node in to the main node v2: - https://lore.kernel.org/lkml/20200905144503.1067124-3-j.neuschaefer@gmx.net/ - Fix pwm-cells property (should be 2, not 1) --- arch/arm/boot/dts/imx50-kobo-aura.dts | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) -- 2.29.2 diff --git a/arch/arm/boot/dts/imx50-kobo-aura.dts b/arch/arm/boot/dts/imx50-kobo-aura.dts index 97cfd970fe742..82ce8c43be867 100644 --- a/arch/arm/boot/dts/imx50-kobo-aura.dts +++ b/arch/arm/boot/dts/imx50-kobo-aura.dts @@ -143,10 +143,24 @@ &i2c3 { pinctrl-0 = <&pinctrl_i2c3>; status = "okay"; - /* TODO: embedded controller at 0x43 */ + embedded-controller@43 { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_ec>; + compatible = "netronix,ntxec"; + reg = <0x43>; + system-power-controller; + interrupts-extended = <&gpio4 11 IRQ_TYPE_EDGE_FALLING>; + #pwm-cells = <2>; + }; }; &iomuxc { + pinctrl_ec: ecgrp { + fsl,pins = < + MX50_PAD_CSPI_SS0__GPIO4_11 0x0 /* INT */ + >; + }; + pinctrl_gpiokeys: gpiokeysgrp { fsl,pins = < MX50_PAD_CSPI_MISO__GPIO4_10 0x0