From patchwork Fri Dec 4 18:33:35 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 1411221 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-pwm-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=kleine-koenig.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4CnhFX3hmXz9ryj for ; Sat, 5 Dec 2020 05:34:40 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387879AbgLDSeY (ORCPT ); Fri, 4 Dec 2020 13:34:24 -0500 Received: from antares.kleine-koenig.org ([94.130.110.236]:48046 "EHLO antares.kleine-koenig.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387873AbgLDSeY (ORCPT ); Fri, 4 Dec 2020 13:34:24 -0500 Received: by antares.kleine-koenig.org (Postfix, from userid 1000) id 68167A96D72; Fri, 4 Dec 2020 19:33:42 +0100 (CET) From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Johan Hovold , Alex Elder , Greg Kroah-Hartman Cc: Thierry Reding , Lee Jones , linux-pwm@vger.kernel.org, greybus-dev@lists.linaro.org, devel@driverdev.osuosl.org Subject: [PATCH] greybus: Add TODO item about modernizing the pwm code Date: Fri, 4 Dec 2020 19:33:35 +0100 Message-Id: <20201204183335.3839726-1-uwe@kleine-koenig.org> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-pwm@vger.kernel.org drivers/staging/greybus/pwm.c uses the old style PWM callbacks, new drivers should stick to the atomic API instead. --- drivers/staging/greybus/TODO | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/greybus/TODO b/drivers/staging/greybus/TODO index 31f1f2cb401c..6461e0132fe3 100644 --- a/drivers/staging/greybus/TODO +++ b/drivers/staging/greybus/TODO @@ -1,3 +1,5 @@ * Convert all uses of the old GPIO API from to the GPIO descriptor API in and look up GPIO lines from device tree or ACPI. +* Make pwm.c use the struct pwm_ops::apply instead of ::config, ::set_polarity, + ::enable and ::disable.