From patchwork Tue Dec 1 08:24:29 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heinrich Schuchardt X-Patchwork-Id: 1408659 X-Patchwork-Delegate: xypron.glpk@gmx.de Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=gmx.de Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.a=rsa-sha256 header.s=badeba3b8450 header.b=FZiyTMou; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4ClZsN2BPbz9sWC for ; Tue, 1 Dec 2020 19:24:56 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 89D0982665; Tue, 1 Dec 2020 09:24:49 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.b="FZiyTMou"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 1AD3682699; Tue, 1 Dec 2020 09:24:47 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2, SPF_HELO_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from mout.gmx.net (mout.gmx.net [212.227.15.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 19CFC82663 for ; Tue, 1 Dec 2020 09:24:39 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=xypron.glpk@gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1606811076; bh=qCaVk0XlFoJF/tOWShhDIutLeD5ni28Eh7M/dVbKyFA=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date; b=FZiyTMoubkiu5oN+6hWSUUdZZwK8yvrfGRwkcpDLXsHBDbZkHEZbDHsq3qaEumCq7 Bjwoy2RpO45ws05CfUIsVrKjvaZ5JFrMwUGiZpBgledPmFRSe5PuSOkkggrj+kmCxQ GgjEu35YD1z+EC7FMBKKStYdjFddJ7hVwGtmR0hA= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from LT02.fritz.box ([62.143.246.89]) by mail.gmx.com (mrgmx005 [212.227.17.184]) with ESMTPSA (Nemesis) id 1MFsUv-1kyWdf3Gnv-00HSMM; Tue, 01 Dec 2020 09:24:36 +0100 From: Heinrich Schuchardt To: Alexander Graf Cc: Simon Glass , u-boot@lists.denx.de, Heinrich Schuchardt Subject: [PATCH 1/1] efi_loader: replace printf by log in efi_uclass.c Date: Tue, 1 Dec 2020 09:24:29 +0100 Message-Id: <20201201082429.65217-1-xypron.glpk@gmx.de> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 X-Provags-ID: V03:K1:TqVh2/TIfwhu7zeocG7in2RKcVLvt10Kw2vNzMN1uy8CahcW0rb WRYq85Pf64ZxcWrD5z58falAUSDz9nNz0kFfO0IZIErbX5vhy+oV+wf9tXTlAA88JBRsTtL SR9kh2pXLwHXEfIpPmckhBrboOScv7+jMoMPOPC9Uq2Ge6IAVnqLyzOvrJ2IpusBdB0xNSu iWgOkxj/D8UwDmU+8IEBA== X-UI-Out-Filterresults: notjunk:1;V03:K0:m71vHAXna50=:ZGTLqo/dfV4YeeBQxOAObp 2w9/XfflpyXYhwur/QC3dLbNk10gzwRh1NRk1wsN/TL9gWJO4ux3r+xsEXMIFVzhoR9EdFxWC 2a05RBVCiu8L3bkF19gbTW5RkIwPxv1lqRdwvLpYMm6siW0eGteG/8Vs2uorA/pGia3CMhSE9 /I6xHWTATZuZfmBLKI5bH1LbSARvvkrbaG+qH1XzoDQUDej5ONyhkJ2cpf+FhsWmm+wq2blgN QZ1ahBWRTAVMRsoU1JzmpzpqnjPb4le8SlllvwnJeNO3kF0IaiEuMJclmMOPEZJC/yWk/s/+m yS/eia8QRVgqk0wVmJGv2KRKhmGwYlWxansjUHDXzjaAY6C6LjlbiCClvjIO5fBmmKflLDbF1 sssyVDnEW+vKPfmhj6dqRsERXtAFShM9RRIGvhvu8ZYLQvLLOy5kvnJa5oY+8eAByoIm/PC95 K7JNvnSD1mwvHY7UY+NztNsd8yJYZiIbw/he1HARK9n3efb9E92lpvBXs/pPDMDaEaN1Rlb9H m/ZEbddGDjMbMeQTLiPwDUWI99QBT4V9s7As141W9mAhO3xdv76PeowjOPFcylhfqskLKKtwV WeuNu//ATrf6oWcHKlKEviDDJdvT6sE1gIL/V9krazJB8Yiom1DUZ6M/vouoQ/8001afmpnLr WoCOcatJA2um/9juuZGU+W76uF97xoKvy73+7S1/IzWe5Ug0zDLTxrtcUWPx7wIiTPgswGEzH KyCD29RTmaOM6cS1BqVCXPbI+QCSgSDsNOspfzJSIRRhC4h1wsd3ywUyARJp/Wr10e7RgrdEt c14AtF7E0OFI26yy4B8sNF4QQ2dVr/61d3CKcxIcaxktwM35XAoXrow187FCW9KhRGEFE/Gai 73OjBmT5/YR+9HCTH9IQ== X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.3 at phobos.denx.de X-Virus-Status: Clean Use logging functions instead of printf() and debug(). Change logging messages for uclass creation and destruction to log_debug(). Reported-by: Simon Glass Signed-off-by: Heinrich Schuchardt Reviewed-by: Simon Glass --- lib/efi_driver/efi_uclass.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) -- 2.29.2 diff --git a/lib/efi_driver/efi_uclass.c b/lib/efi_driver/efi_uclass.c index 0cf74b0361..382c2b477f 100644 --- a/lib/efi_driver/efi_uclass.c +++ b/lib/efi_driver/efi_uclass.c @@ -238,7 +238,7 @@ static efi_status_t EFIAPI efi_uc_stop( } ret = EFI_CALL(systab.boottime->free_pool(entry_buffer)); if (ret != EFI_SUCCESS) - printf("%s: ERROR: Cannot free pool\n", __func__); + log_err("Cannot free EFI memory pool\n"); /* Detach driver from controller */ ret = EFI_CALL(systab.boottime->close_protocol( @@ -260,10 +260,10 @@ static efi_status_t efi_add_driver(struct driver *drv) const struct efi_driver_ops *ops = drv->ops; struct efi_driver_binding_extended_protocol *bp; - debug("EFI: Adding driver '%s'\n", drv->name); + log_debug("Adding EFI driver '%s'\n", drv->name); if (!ops->protocol) { - printf("EFI: ERROR: protocol GUID missing for driver '%s'\n", - drv->name); + log_err("EFI protocol GUID missing for driver '%s'\n", + drv->name); return EFI_INVALID_PARAMETER; } bp = calloc(1, sizeof(struct efi_driver_binding_extended_protocol)); @@ -305,14 +305,14 @@ efi_status_t efi_driver_init(void) struct driver *drv; efi_status_t ret = EFI_SUCCESS; - debug("EFI: Initializing EFI driver framework\n"); + log_debug("Initializing EFI driver framework\n"); for (drv = ll_entry_start(struct driver, driver); drv < ll_entry_end(struct driver, driver); ++drv) { if (drv->id == UCLASS_EFI) { ret = efi_add_driver(drv); if (ret != EFI_SUCCESS) { - printf("EFI: ERROR: failed to add driver %s\n", - drv->name); + log_err("Failed to add EFI driver %s\n", + drv->name); break; } } @@ -328,7 +328,7 @@ efi_status_t efi_driver_init(void) */ static int efi_uc_init(struct uclass *class) { - printf("EFI: Initializing UCLASS_EFI\n"); + log_debug("Initializing UCLASS_EFI\n"); return 0; } @@ -340,7 +340,7 @@ static int efi_uc_init(struct uclass *class) */ static int efi_uc_destroy(struct uclass *class) { - printf("Destroying UCLASS_EFI\n"); + log_debug("Destroying UCLASS_EFI\n"); return 0; }