From patchwork Sat Jan 6 12:45:35 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 856361 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="SFa4s2u/"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3zDLqw66chz9s7n for ; Sat, 6 Jan 2018 23:46:04 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:References:To:From:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DLzw3NI0PKdGI15xPzY625WrIaOpZFJ2cI0xguVzTqk=; b=SFa4s2u/5RN0e6 uwKE4nt81gQn84v+5JmOPJ7giXRdiGZli/Mo92WFQW8EWQb9FCgJRWd9oUg/ZJJtrT7PhHv02CFEp FDnA/WtEi29Azd8Ixe1IBm0IAmZmZoY0sqC9M7IgwgMs3UGATzV/gZlHkt3h/Z3WWH8u/Q6R5w6LF vYZudAC9bCm6hdp4siYvA1KdUh1WUIH4FMkORdy01yEDRw+S8Yvcq7iEjsojCowzpU2bYhvbNdqci KN7dbVl+oNnqCtcmKN5dTcx7y9yCF+d3Fg+QWubWiB/IxgHwFpLnZCkUJMvIAjEsrrAF7x8QObCNI NS8MIoL0+eAHLBg2fAXQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.89 #1 (Red Hat Linux)) id 1eXnrM-0001C0-K7; Sat, 06 Jan 2018 12:46:00 +0000 Received: from mout.web.de ([212.227.15.14]) by bombadil.infradead.org with esmtps (Exim 4.89 #1 (Red Hat Linux)) id 1eXnrJ-0001AF-P9 for linux-mtd@lists.infradead.org; Sat, 06 Jan 2018 12:45:59 +0000 Received: from [192.168.1.3] ([85.182.74.56]) by smtp.web.de (mrweb001 [213.165.67.108]) with ESMTPSA (Nemesis) id 0LlnMG-1f6rYW40Aq-00ZNKw; Sat, 06 Jan 2018 13:45:37 +0100 Subject: [PATCH 1/3] mtd/nftlmount: Delete two error messages for a failed memory allocation in find_boot_record() From: SF Markus Elfring To: linux-mtd@lists.infradead.org, Boris Brezillon , Brian Norris , Cyrille Pitchen , David Woodhouse , Marek Vasut , Richard Weinberger References: <57d4cbcf-c99c-f3d5-e2bf-f67873f321ea@users.sourceforge.net> Message-ID: Date: Sat, 6 Jan 2018 13:45:35 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <57d4cbcf-c99c-f3d5-e2bf-f67873f321ea@users.sourceforge.net> Content-Language: en-GB X-Provags-ID: V03:K0:2/aGZPbycKjXCVUgPoZRX0GLRAlQhU6kAK4aCsjxTzj6e6FC/Pg I/0iFyvadxYHxTHNdriAlE8dqEa+ATtUX9sPCXYsNoa4ctUe5BtStlBI3fcsUyU9usIlA0w hh0cJeIn6YvyMTTGGe6u9jQ9UFeuWuSArqeQG5MI/12GZmf/RN7HiaWg+zlJHdCoO/wB0DF buPiIWyJzibgNFzgAQXcQ== X-UI-Out-Filterresults: notjunk:1; V01:K0:s8tawuZ8RKQ=:3177J1jaxdsWlE1PZ5vLyI s/0TgolzJXJkBy/BNYUjspny/DXfHMtM3aEPsJGuANhyr2dCWwxKimCKslGZ6CYkuDhkoFCwb TLqzAvVGwmJipQHgLjiJ6uAI/nxIL7IJ5PX8Y0UoMxFxH1T/vLaX4165HX53annYbOLatUABe aN3lhIk+pwFsZv9Wfq42Fup2wwAmIxBzrvKIX2WaKusWxd2/AKG5IauJ71ducBOALPT1VYh/A HpC5LEjU9eR8SYY8/0PTFILs01Kg8Y5OqD2I2GuTlJKx+3+YIW1eZJLyBBDJK1GZKBhL3zfVE ijiieohlq8rnYuztUckoM40esoLGq3R/kffxIWr0h+pifFPRakgJP6PfM1b1XQ2k/CXZQm9UB 4jN+1NJ18dQK/MjZCoxKIFusxvUyJjQFMNRzwAa1VvdWBj5cadE9YfFYLTaqudydiLJCNdivL nETZz2b1gXdlDH+Gn1xNPbYrC+++J99urjsWcYSZy710lZsJ6BcN2fGLs9ulUMlxeQtHExTdu baKN1oOfjOth6cOh4QXD8pwvIVFyTT5tpzeE95oA0VHl6Pn7cS8V4/XE1ckyiRk8A8BtvasWF NPQ1k5FyD3B+mzBTGMmxURVT9NxmOtfFhhHbwBDnpK88AvITO628yRlO77tlwcXwrOAbJ5HLU +Z2llFTIfFhQmldgFCAQ/LqccnqMWorNot9bNHDXu3LVhWJfgO7ucPkXDB1lSWtAIey5ArxJK iVIHcFKvk5CVOA0IFdsNVou2WeoR+k/PACikvxlkLaeOtnZH6ZTGB4EnV8EdneBGKbfdBmXxS W722QXu6LfICQTF90caSb1bi67hKybHWHYSDN4R2buCDEvx3V4= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180106_044558_168821_D5B92B42 X-CRM114-Status: UNSURE ( 8.24 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -2.6 (--) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-2.6 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [212.227.15.14 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [212.227.15.14 listed in wl.mailspike.net] -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-janitors@vger.kernel.org, LKML Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org From: Markus Elfring Date: Sat, 6 Jan 2018 11:04:59 +0100 Omit extra messages for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/mtd/nftlmount.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/mtd/nftlmount.c b/drivers/mtd/nftlmount.c index 184c8fbfe465..6b9634a70229 100644 --- a/drivers/mtd/nftlmount.c +++ b/drivers/mtd/nftlmount.c @@ -201,15 +201,12 @@ device is already correct. /* memory alloc */ nftl->EUNtable = kmalloc(nftl->nb_blocks * sizeof(u16), GFP_KERNEL); - if (!nftl->EUNtable) { - printk(KERN_NOTICE "NFTL: allocation of EUNtable failed\n"); + if (!nftl->EUNtable) return -ENOMEM; - } nftl->ReplUnitTable = kmalloc(nftl->nb_blocks * sizeof(u16), GFP_KERNEL); if (!nftl->ReplUnitTable) { kfree(nftl->EUNtable); - printk(KERN_NOTICE "NFTL: allocation of ReplUnitTable failed\n"); return -ENOMEM; } From patchwork Sat Jan 6 12:46:39 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 856362 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Xo6fyHU0"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3zDLs763Gsz9s7n for ; Sat, 6 Jan 2018 23:47:07 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:References:To:From:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=BUNF4z7CElD/E2MLeo5QRxGtukQ6Q+k6tbPiyDtrFTs=; b=Xo6fyHU0szv7KD 7oXtB3NC1vyJYpQa64W3pXxwpf7t5ciIOe6BDWX48SeD1RC7LbsXtGmHnrJswBiFpr5X6he4PJTKu /8wh+nBytgoMMkT3ew5/ztXfIyM26j2lkMsTj1yY7yRvve5c6mEi5cH9yiRaqE+k1a8CTrFDkFamQ KQVwFYZfPJzWt6S99V2r6fD0CFFfP4HCnkMCXPDl6v223nMokFZrl+d+tR7HaHzOk5YqJS0Ca80FR p/sUdM+86vUtlP2TowrpKEvDdaT/bcaqMXNcwGxC18oiDKMG8feVRC5Y76/V/dj+xS4ryPl/NWSFp wc3bbY3d6REhMFJZs4KA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.89 #1 (Red Hat Linux)) id 1eXnsN-0001VX-9U; Sat, 06 Jan 2018 12:47:03 +0000 Received: from mout.web.de ([212.227.15.14]) by bombadil.infradead.org with esmtps (Exim 4.89 #1 (Red Hat Linux)) id 1eXnsI-0001U8-TK for linux-mtd@lists.infradead.org; Sat, 06 Jan 2018 12:47:00 +0000 Received: from [192.168.1.3] ([85.182.74.56]) by smtp.web.de (mrweb003 [213.165.67.108]) with ESMTPSA (Nemesis) id 0MbyJ4-1eHmek3diQ-00JNb9; Sat, 06 Jan 2018 13:46:41 +0100 Subject: [PATCH 2/3] mtd/nftlmount: Delete eight unwanted spaces behind function names From: SF Markus Elfring To: linux-mtd@lists.infradead.org, Boris Brezillon , Brian Norris , Cyrille Pitchen , David Woodhouse , Marek Vasut , Richard Weinberger References: <57d4cbcf-c99c-f3d5-e2bf-f67873f321ea@users.sourceforge.net> Message-ID: <0095db26-a0ff-a400-3509-6085d701ecab@users.sourceforge.net> Date: Sat, 6 Jan 2018 13:46:39 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <57d4cbcf-c99c-f3d5-e2bf-f67873f321ea@users.sourceforge.net> Content-Language: en-GB X-Provags-ID: V03:K0:N6YA0AAd8v0TPdgzCRxgpXERU0R7jbncu06EvbuJf6gNu1sXjOH WSlzL4CHOAqbXsNBqsHx8JwQpTbPZH+L/hfVwrh03qKSYIqReODkUf8bQWMBnoe2LtvsNpY HjAfmqtNt7EaOqXR56hnS5HTyn+HZXWhuTOwMYVk29JJgvNUXctlZiX0X1NSZ2s34MMwym2 pEzDeaRq13drDD7L0AY6w== X-UI-Out-Filterresults: notjunk:1; V01:K0:GAmhp5ZWYEQ=:l9dqoFw/nKkiOkOebgv34j Fez2fdkRg4Hwdf0KgpmFC5E2sK86q8Q1mL26dXcybYgjCcSBNd+PLeAqnEO0KYiC1ZRa03/bb p3/4jWFlX95lGxJz3vQRf+Tm31kseiaaGOUhAswTLWfz6xNI/yqLXDZghoUiUvnclkGGLWS4q JX8CCN0ujuf2p7zDqq5uPyWYCwFisYAGHOmscfPVJI8Y3dlpY664UTnHu0v8a5OfwUGIoBXa8 KfclBgkx9JLWaheCoL1DkORC2EbUtC/yuma9+JPaYXcPyYRPdUtKp5pbYpMazUJz7jNedc8Cr MmW9SKtpmWQzLOj8xHTY2y1JorWOTmdPYqp+4xQBg8Uco8ZNWUDAjR1BZz1UbKnAI5H6nZPz8 J4dOR9AMsPaQZ4kyQxls7omkH9FFi8VZjfUWyj6PfKqekzDUhZhsG4d1syD7SbjfDxI8UKAF6 mcqq33B5CfI8bTHsAfnkxIKD+m0X1nNN/evoZ94ZE+rovHwhhDacRBbr7CzDVtT+QuVqSMfxu HkXvpQNQjWFU4ukBniLiDteTLN1vxzIJRsiydo2+pvPA58mkYCRiogKeOydUXUOSk7oswNJgb 1mai0U0L6jwgJXRsaCg8JU3VQEbMeHpf+fh6fmO7ZX/wX4XnzogAtShWFhPuNc6WKIxNUWo+r yjTC5UPZWYe9gDRz8BfZdn5wta6h1N9vRzYOKW9YyZ3l98BqCoL0b1i68mYkNishxt95OJGvt ZRatVPRgwsGmNyQMveI55gR7a4kmaV6biYZvDBwm2TpzOwM1mKBT0xLkhLNFKxpavmg+H6/Hv mefZ+3cbAq4J5d0360t4ZzUBukr6De0jquq8LCeoXD6VdKeQT8= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180106_044659_290695_10E5374D X-CRM114-Status: GOOD ( 11.01 ) X-Spam-Score: -2.6 (--) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-2.6 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [212.227.15.14 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [212.227.15.14 listed in wl.mailspike.net] -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-janitors@vger.kernel.org, LKML Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org From: Markus Elfring Date: Sat, 6 Jan 2018 12:55:23 +0100 The script "checkpatch.pl" pointed information out like the following. WARNING: space prohibited between function name and open parenthesis '(' Thus fix the affected source code places. Signed-off-by: Markus Elfring --- drivers/mtd/nftlmount.c | 23 ++++++++++++++--------- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/drivers/mtd/nftlmount.c b/drivers/mtd/nftlmount.c index 6b9634a70229..d1eaa87c88ba 100644 --- a/drivers/mtd/nftlmount.c +++ b/drivers/mtd/nftlmount.c @@ -314,7 +314,7 @@ int NFTL_formatblock(struct NFTLrecord *nftl, int block) 8, &retlen, (char *)&uci) < 0) goto default_uci1; - erase_mark = le16_to_cpu ((uci.EraseMark | uci.EraseMark1)); + erase_mark = le16_to_cpu(uci.EraseMark | uci.EraseMark1); if (erase_mark != ERASE_MARK) { default_uci1: uci.EraseMark = cpu_to_le16(ERASE_MARK); @@ -501,11 +501,12 @@ static int check_and_mark_free_block(struct NFTLrecord *nftl, int block) &retlen, (char *)&h1) < 0) return -1; - erase_mark = le16_to_cpu ((h1.EraseMark | h1.EraseMark1)); + erase_mark = le16_to_cpu(h1.EraseMark | h1.EraseMark1); if (erase_mark != ERASE_MARK) { /* if no erase mark, the block must be totally free. This is possible in two cases : empty filesystem or interrupted erase (very unlikely) */ - if (check_free_sectors (nftl, block * nftl->EraseSize, nftl->EraseSize, 1) != 0) + if (check_free_sectors(nftl, block * nftl->EraseSize, + nftl->EraseSize, 1) != 0) return -1; /* free block : write erase mark */ @@ -521,8 +522,9 @@ static int check_and_mark_free_block(struct NFTLrecord *nftl, int block) /* if erase mark present, need to skip it when doing check */ for (i = 0; i < nftl->EraseSize; i += SECTORSIZE) { /* check free sector */ - if (check_free_sectors (nftl, block * nftl->EraseSize + i, - SECTORSIZE, 0) != 0) + if (check_free_sectors(nftl, + block * nftl->EraseSize + i, + SECTORSIZE, 0) != 0) return -1; if (nftl_read_oob(mtd, block * nftl->EraseSize + i, @@ -608,10 +610,13 @@ int NFTL_mount(struct NFTLrecord *s) break; } - logical_block = le16_to_cpu ((h0.VirtUnitNum | h0.SpareVirtUnitNum)); - rep_block = le16_to_cpu ((h0.ReplUnitNum | h0.SpareReplUnitNum)); - nb_erases = le32_to_cpu (h1.WearInfo); - erase_mark = le16_to_cpu ((h1.EraseMark | h1.EraseMark1)); + logical_block = le16_to_cpu(h0.VirtUnitNum | + h0.SpareVirtUnitNum); + rep_block = le16_to_cpu(h0.ReplUnitNum | + h0.SpareReplUnitNum); + nb_erases = le32_to_cpu(h1.WearInfo); + erase_mark = le16_to_cpu(h1.EraseMark | + h1.EraseMark1); is_first_block = !(logical_block >> 15); logical_block = logical_block & 0x7fff; From patchwork Sat Jan 6 12:47:37 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 856363 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="e4KeN82k"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3zDLtD3tYzz9s7n for ; Sat, 6 Jan 2018 23:48:04 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:References:To:From:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Bvjezlu56asULSKqOEijDphpOlooooXpYNimZduUlDQ=; b=e4KeN82kNb6Uhx bSunATZrFolO76SFokt4M+X7FY0QSvn8+QWoAzeEp+ZLqpmGwcvaaPErsAzH6Txgba3LPin0xutBp qvWiZVnjEAa5YLQy6Nezp9/Fp8+RcjXTeyhhKoFxXAL5R5FFdUkzYfkrMKT4GfX+jfVR1IY1aRM3+ D4a1kd5eLjOGtogH/qW35KXHdXp9mxUBpz40UpM2DSeF++lcMS0wNTpjfAnwjpNvRyj/zn3GRAlwt ng4npK0/uVmGHwpviJ+rjv+IbiVteE4jWiXzevuQBv3S7uh6cVO9xuujajUOKHDchflklYF9FV3O/ XVbvBul/Vd3AKLH+g4uA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.89 #1 (Red Hat Linux)) id 1eXntH-0001mi-Mu; Sat, 06 Jan 2018 12:47:59 +0000 Received: from mout.web.de ([212.227.15.14]) by bombadil.infradead.org with esmtps (Exim 4.89 #1 (Red Hat Linux)) id 1eXntE-0001lt-Ja for linux-mtd@lists.infradead.org; Sat, 06 Jan 2018 12:47:58 +0000 Received: from [192.168.1.3] ([85.182.74.56]) by smtp.web.de (mrweb003 [213.165.67.108]) with ESMTPSA (Nemesis) id 0MZDQ4-1eJRKP3uEW-00L1Jx; Sat, 06 Jan 2018 13:47:38 +0100 Subject: [PATCH 3/3] mtd/nftlmount: Add some spaces for better code readability From: SF Markus Elfring To: linux-mtd@lists.infradead.org, Boris Brezillon , Brian Norris , Cyrille Pitchen , David Woodhouse , Marek Vasut , Richard Weinberger References: <57d4cbcf-c99c-f3d5-e2bf-f67873f321ea@users.sourceforge.net> Message-ID: Date: Sat, 6 Jan 2018 13:47:37 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <57d4cbcf-c99c-f3d5-e2bf-f67873f321ea@users.sourceforge.net> Content-Language: en-GB X-Provags-ID: V03:K0:BOhmalOy5gsqxI3pghdzvzt8M1UV03u0Sdqm5/5T7DFKgDbYb7x +ENECW1reGFkCpaE2ojFLgxH7OXTY4lHUDBUKJ0LYhGwsaOQa1w4mDrzHDhlM3nKM1Qfjwp aeM75qarVEcnKG/nrUMVEX+cQU7FWzGHNw3sfngUCpSPwarlRqTd7cRJi/IEn3cCYc54ZCX LJbtLx45kvtAWTvXjozfg== X-UI-Out-Filterresults: notjunk:1; V01:K0:g11BWUcxEzM=:d9aln261Li1ofbARDP7hJ5 4LKfI/lci12yeRgfFMJ2sHaHPQtoP9Ki4PSWrORF7jJrclxWvJqDP2++mTFNjlY32/IvVbfO1 QCEa3wB+3Ngj3tcDrJufXTXqiHviuax17JhP5vUpewc1tH6OvkM44MYDY6RES8QV+p1AHDQcQ u4o91bwJFS197vIvP2a7wvS/Hszg7zetyfZt56WuXmATMlRnl+nTCYMx7yxVaiNm37Pgt0TsG JrrkL1913xoGrOKmySuLUn058tOHWi1zqx7TyD1TKAW4tB6Ljm9Wct/ssfZdimZvqGz5wFiwP YWU2sTlCYiLK319WKQGymqAtW7iVWoHsC4QSZ0hSTLPX+YQ1+NE9+smcmVchTcKk41looHQiu ibH5c5iMi8OFFo8A2caMj3NGbUGRaFvvO9ecqYGlV857pRajFPHckK0IcVD9yDKaviT7hfQU+ xtaQDsUoSmTslAfUG/Oz+WTAf4C3VAqzl6kZ/BTYlF76+ijTnZWGbTiT9ao+UldI++B5bl2f7 Exco9aw5d1qt/Ml9C9XBNCZFqtsy85cDW3ikyPCrdii1MkSBxbM8wboElIZhB+1RGBir5TA+y sKnPiWaKxeQtVSLgz40dWGAnr8BBkvRI84hHosPNZR9VNTddp5mjC/2p9amv0fsohJ/5ftFfp F6JU3pRo/iYF2ngi3P1oXR8A7BDaUs73+PZipYnbiwsMAWgIf+8NUO/eaZD6meeV5Gw2zTs7a CTuXCONdJSTFSnI196pc7lP5/R8PXl/wSLDSlmLgoKQ7inIReEJ/RImXu5AjIjunEjDtNA0Lg Icau3bBtsfl3Js9unEw3DhigptBUVbKfdOW/3jMjW15do2/MVE= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180106_044756_983312_9B8348A9 X-CRM114-Status: GOOD ( 11.02 ) X-Spam-Score: -2.6 (--) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-2.6 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [212.227.15.14 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [212.227.15.14 listed in wl.mailspike.net] -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-janitors@vger.kernel.org, LKML Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org From: Markus Elfring Date: Sat, 6 Jan 2018 12:58:37 +0100 Use space characters at some source code places according to the Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/mtd/nftlmount.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/mtd/nftlmount.c b/drivers/mtd/nftlmount.c index d1eaa87c88ba..457f3572c582 100644 --- a/drivers/mtd/nftlmount.c +++ b/drivers/mtd/nftlmount.c @@ -253,7 +253,7 @@ The new DiskOnChip driver already scanned the bad block table. Just query it. } /* foreach (block) */ - return boot_record_count?0:-1; + return boot_record_count ? 0 : -1; } static int memcmpb(void *a, int c, int n) @@ -282,8 +282,8 @@ static int check_free_sectors(struct NFTLrecord *nftl, unsigned int address, int return -1; if (check_oob) { - if(nftl_read_oob(mtd, address, mtd->oobsize, - &retlen, &buf[SECTORSIZE]) < 0) + if (nftl_read_oob(mtd, address, mtd->oobsize, + &retlen, &buf[SECTORSIZE]) < 0) return -1; if (memcmpb(buf + SECTORSIZE, 0xff, mtd->oobsize) != 0) return -1; @@ -389,7 +389,7 @@ static void check_sectors_in_chain(struct NFTLrecord *nftl, unsigned int first_b else status = bci.Status | bci.Status1; - switch(status) { + switch (status) { case SECTOR_FREE: /* verify that the sector is really free. If not, mark as ignore */