From patchwork Wed Nov 25 18:07:35 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian May X-Patchwork-Id: 1406186 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=canonical.com Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4Ch84m4RJPz9sTc; Thu, 26 Nov 2020 05:07:52 +1100 (AEDT) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1khzCm-00047d-Kc; Wed, 25 Nov 2020 18:07:48 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1khzCk-000479-MN for kernel-team@lists.ubuntu.com; Wed, 25 Nov 2020 18:07:46 +0000 Received: from mail-pg1-f198.google.com ([209.85.215.198]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1khzCk-0002MF-Ab for kernel-team@lists.ubuntu.com; Wed, 25 Nov 2020 18:07:46 +0000 Received: by mail-pg1-f198.google.com with SMTP id f19so2253783pgm.4 for ; Wed, 25 Nov 2020 10:07:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=GFFO/4U6cT4Ou+Cas2nli8jkkjzj3nUNzfoxOUfEq6A=; b=HslMtRzkYbP8GSsgGi7Od0aWAVDZoDXTkIJ2ElDeGzbRCNTOXCljlHfT3uaqe2FOQd MagP0p6Ynwj5CyjAO0i+bN65iBiREa3n83DO4iYzYHVM4gwzt7fPjLsywVxjwmIHAqPF rIwPzpMPQHeLPTlT3arUvlowBQMYqoPWj9gAuzeGJ6JcrOnUPfuVkZbrkBmGzJ1M/i5e QfgZMQlMTMT2Fpl3Ddig9ex5xwO51SbeG4GdNE0VsyK7anoCE9Uiy0VIcSIUudwY+rRi nXChuF8kpTX5KkTHqP95ixSkQEXQDuBZdpbtTsrkidc6Oxbexe3GpqrcWKjuMlFn8kWX D56A== X-Gm-Message-State: AOAM532Y/rYt0nlYgHNI3BsWx0WQucEcRD+jcoNjkyww1jBlY08AG6Qf aGsHTdto+IPzsYUFDPHQ0gZXuq+o7FxyB5HdcLVxwboKz59z9XmqYInqC461ej83JEOqAlkZT/P 9DtM8E7mXbvZwrwaOIT+M3uhV+Ku7m/AVC18qbqyw2A== X-Received: by 2002:a65:63da:: with SMTP id n26mr4033575pgv.306.1606327664818; Wed, 25 Nov 2020 10:07:44 -0800 (PST) X-Google-Smtp-Source: ABdhPJwU6dovzOkwzufeAXa1jU37XzLT6/YK3de/t99oK6k94G8rijvl38o4613WqLmPag5FZlYsLQ== X-Received: by 2002:a65:63da:: with SMTP id n26mr4033560pgv.306.1606327664536; Wed, 25 Nov 2020 10:07:44 -0800 (PST) Received: from uws.buildd (61-220-137-34.HINET-IP.hinet.net. [61.220.137.34]) by smtp.gmail.com with ESMTPSA id d24sm2359025pjv.44.2020.11.25.10.07.42 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Nov 2020 10:07:44 -0800 (PST) From: Ian May To: kernel-team@lists.ubuntu.com Subject: [SRU][Bionic][PATCH 1/1] UBUNTU: SAUCE: net/mlx5e: IPoIB, initialize update_stat_work for ipoib devices Date: Wed, 25 Nov 2020 12:07:35 -0600 Message-Id: <20201125180735.511223-2-ian.may@canonical.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201125180735.511223-1-ian.may@canonical.com> References: <20201125180735.511223-1-ian.may@canonical.com> MIME-Version: 1.0 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" From: Amir Tzin BugLink: https://launchpad.net/bugs/1904848 mlx5e_detach_netdev cancels update_stats_work which was not initialized in ipoib netdevice profile, as a result, unloading the ib_ipoib module causes a call trace in the kernel ring buffer. current implementation inits update_stats_work in each netdev profile->init call back and cancels it in mlx5e_detach_netdev, so lets follow this guideline and init update_stat_work for ipoib netdev in it's profile->init callback. Fixes: cd565b4b51e5 ("IB/IPoIB: Support acceleration options callbacks") Signed-off-by: Amir Tzin Reviewed-by: Feras Daoud Signed-off-by: Ian May Acked-by: Stefan Bader Acked-by: Kleber Sacilotto de Souza --- drivers/net/ethernet/mellanox/mlx5/core/ipoib/ipoib.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/ipoib/ipoib.c b/drivers/net/ethernet/mellanox/mlx5/core/ipoib/ipoib.c index e97e57c64902..f9110c8beddf 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/ipoib/ipoib.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/ipoib/ipoib.c @@ -83,6 +83,7 @@ void mlx5i_init(struct mlx5_core_dev *mdev, priv->hard_mtu = MLX5_IB_GRH_BYTES + MLX5_IPOIB_HARD_LEN; mutex_init(&priv->state_lock); + INIT_DELAYED_WORK(&priv->update_stats_work, mlx5e_update_stats_work); mlx5e_build_nic_params(mdev, &priv->channels.params, profile->max_nch(mdev)); mlx5i_build_nic_params(mdev, &priv->channels.params);