From patchwork Fri Jan 5 20:02:56 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 856228 X-Patchwork-Delegate: boris.brezillon@free-electrons.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qfuflR2i"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="WuMO3uEV"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3zD0hw5QThz9ryT for ; Sat, 6 Jan 2018 10:08:48 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=TR46ms5/jyrATq297yeR9BdhZsZ/HFzByCw5nkQRjPU=; b=qfuflR2iPRRxjZae20SdESgqk8 AVUCJIVep8mbXimnMH3K3y0AVR9GXMZilH3lmUZSQevoUDAwT88mBYcKRTNxZtky7By2gpoADcjkZ X3tYR1yYjMTNaxwkpCxGfe0tI+G5OmicuqcHBRCw5/3RIdIpzcwKXQrTOr9bXOUgiVs5AW2p2UI5e nn5y2zYa2kQB1tBhfekMK79M7izqfpq/2h3m531IXabDb6wbus7C/aYeA6De7TlrpnWdjpjpd9HjZ pu+WsgtwAU5DkTpn13GQA0YyYkWQ4c+3pQp6AzadZ2gtoOm4OKVbLWrYKlw/joYUAnMxWW7WZ9GAK wk10NHSw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.89 #1 (Red Hat Linux)) id 1eXYDh-00021D-Et; Fri, 05 Jan 2018 20:04:01 +0000 Received: from mail-qk0-x241.google.com ([2607:f8b0:400d:c09::241]) by bombadil.infradead.org with esmtps (Exim 4.89 #1 (Red Hat Linux)) id 1eXYDN-0001p5-Bn for linux-mtd@lists.infradead.org; Fri, 05 Jan 2018 20:03:43 +0000 Received: by mail-qk0-x241.google.com with SMTP id 143so7349038qki.2 for ; Fri, 05 Jan 2018 12:03:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=CP3WrDB6Iwwy6z/GZQREFilgRZ9nbofx8rvBQc90ZMM=; b=WuMO3uEV+uVqSzdZqcB9tObVlV646lgStlbt0g8g94KUcnm4lz8lzUm27K+kbdKf2i EPZZZsOOaJs2kP1+kajB4AVY8MJ5RsDmW3aHL4NHXzN5uduBLBsOAryyFkq93Um2EXib 3GZj1pZSbh9OW5e3QJzlHRq1YMx3Ihe+q0aRVh23y/kKmphXOjalEI5XvwVjhMWPbn5O H3nzCEu/gowo9YzEpSfq5FNUI+f1sU27a7pmhbM4NdSPOMIja4Mueiq0XjkPP/lbTFHw 2HkQBgpCxHKKYrK/cCYAEdMgp0o1BOb8zfKx7XJuce+KFNDg4fUSvhG4Y9JnlKqsPpbF 7vVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=CP3WrDB6Iwwy6z/GZQREFilgRZ9nbofx8rvBQc90ZMM=; b=s+hAnrfBHoI0HFkyUAhiOSGhY6CUjlbGpOarKAprPhOp1II1cA94X1fFLseXyi06FZ Uf1b+fN0NmP5YgxNp4fklgr9ldFcF52e2110eiH3XZu48C4PEWF3/CZRkI7CCTBpGFHm P3TQa7eWOCHi0d8xX06UqdV053Qz+5hic5l8w/AM/9Ar32SRlaNrDqd8c8DHbngFS5MZ dc3VVRJqEUI0MFKAI/WEGRqk4tZAS1sZyvMLKUMF/ial7mXnT7V4Dl/q3FGjlkEBktmi BVNWLigjNxc3WAfYeN4Dp1ZpQ6KvsLL18WTWoy5gJhzV0cLw3GQEXaiACZhXXiMA2IlA Tgdw== X-Gm-Message-State: AKGB3mKQ082+locsHVAr7L/J2/kIG3japnZPmL3/FOtOpGyRYcfb3uz3 dO+WPLwlaM5Pjuqhpn2emmQ= X-Google-Smtp-Source: ACJfBossSRDv10ThqgSgRVy6AbxvMxI9u9YM885LImvY+2KWiUws8H1mRJhEwVqjDS3bdDQUks28mQ== X-Received: by 10.55.47.133 with SMTP id v127mr5746577qkh.351.1515182610247; Fri, 05 Jan 2018 12:03:30 -0800 (PST) Received: from localhost.localdomain ([2804:14c:482:5fa:fdf3:b3ba:f975:f9ed]) by smtp.gmail.com with ESMTPSA id x52sm3998266qta.26.2018.01.05.12.03.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 05 Jan 2018 12:03:29 -0800 (PST) From: Fabio Estevam To: boris.brezillon@free-electrons.com Subject: [PATCH 2/2] mtd: brcmnand: Add a NULL check for devm_kasprintf() Date: Fri, 5 Jan 2018 18:02:56 -0200 Message-Id: <1515182576-2704-2-git-send-email-festevam@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1515182576-2704-1-git-send-email-festevam@gmail.com> References: <1515182576-2704-1-git-send-email-festevam@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180105_120341_480174_A2B09B4C X-CRM114-Status: UNSURE ( 8.94 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -2.0 (--) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-2.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [2607:f8b0:400d:c09:0:0:0:241 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (festevam[at]gmail.com) -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fabio Estevam , architt@codeaurora.org, computersforpeace@gmail.com, linux-mtd@lists.infradead.org, cyrille.pitchen@wedev4u.fr MIME-Version: 1.0 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org From: Fabio Estevam devm_kasprintf() may fail, so we should better add a NULL check and propagate an error on failure. Signed-off-by: Fabio Estevam --- drivers/mtd/nand/brcmnand/brcmnand.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/mtd/nand/brcmnand/brcmnand.c b/drivers/mtd/nand/brcmnand/brcmnand.c index 3310e14..8942aa6 100644 --- a/drivers/mtd/nand/brcmnand/brcmnand.c +++ b/drivers/mtd/nand/brcmnand/brcmnand.c @@ -2237,6 +2237,8 @@ static int brcmnand_init_cs(struct brcmnand_host *host, struct device_node *dn) nand_set_controller_data(chip, host); mtd->name = devm_kasprintf(&pdev->dev, GFP_KERNEL, "brcmnand.%d", host->cs); + if (!mtd->name) + return -ENOMEM; mtd->owner = THIS_MODULE; mtd->dev.parent = &pdev->dev;