From patchwork Sun Nov 22 23:40:30 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rikard Falkeborn X-Patchwork-Id: 1404572 Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=BQawZD/8; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4CfRcw6BRnz9sTc for ; Mon, 23 Nov 2020 10:41:20 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726860AbgKVXkk (ORCPT ); Sun, 22 Nov 2020 18:40:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50756 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726730AbgKVXki (ORCPT ); Sun, 22 Nov 2020 18:40:38 -0500 Received: from mail-lj1-x241.google.com (mail-lj1-x241.google.com [IPv6:2a00:1450:4864:20::241]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7D201C0613CF; Sun, 22 Nov 2020 15:40:38 -0800 (PST) Received: by mail-lj1-x241.google.com with SMTP id r18so1308296ljc.2; Sun, 22 Nov 2020 15:40:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=LM91gP2nIid4DUflEoBR5rOvvtGclV/kTeDrsZg/vUA=; b=BQawZD/8wmbS8d3v9C3cInKhR9jRFF63UaGGLGQuz8y+gCwiwGfHBNwJL6giWLgSsz zbWMvBzMGxzzYkFSQaD908eVXo1uB+tTnYO+Ur4khoBRDoEeu3YJAMHGdQ8RDlHVgJM+ ml4TVI9QxbA0Ntiy13ptslFw3SzPKRonqHTaqi7S2HkJzy7OwRO1WXUjH58itgc/FXrG CyyTkNXRPatqDtbmKhzZlzyDZSGmXJm4ShB94gJF+PulnA9M4SfiQMuCYy2Df26dtYNA e15239GjQ6mCN71rD2M6YVx5WQ+ps3zzInX5WrF3zhpvDGWqUYqmhU6fI+1KS99aqkip 01sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=LM91gP2nIid4DUflEoBR5rOvvtGclV/kTeDrsZg/vUA=; b=UKZ2m8WHZcXZuigkFuLVHMNBO6fqmDFcaGJL3Hn3lzWdRp+xMrGhNqygA1Ct1UHZpY MyU+5+hGpQ5xFsUod9BJPF2tn9sxWBjfx8DBisTd4DRFzKjap6onLzf8y9qOEikYR/e7 AsMoQRR9FazKGiieG3glHb90QjzPkVqOrke4NZ+broIosf3L1q5ebuP98q0vgz+KDJzE R0ryjyYZtirqHeJpkCy1ZjEQ5AdpBjK6+746hlVHetTu9FjsifTfd3MReY+q7OowaQbr vtfmwPF8EPR/o2WcJqlhFuOONcLB6CR5O+ucl1vCJ/wM34RcZorXZswruUx1271gXc0a Hrfw== X-Gm-Message-State: AOAM53159PuzI8TRH3QhhQrnqOKcY3fCcMqQAioXxvxbFciOztZUQsI/ 2L76q6Ouz4YP80k9bbKPkvE= X-Google-Smtp-Source: ABdhPJxBuZE6wVQydaHsAVsrQ/Q8hA1TfcwCG2pmtjd/Dbr+z7/0FUYmJnxMD8Rxtyzj7NouCJZduQ== X-Received: by 2002:a2e:88c6:: with SMTP id a6mr9691453ljk.390.1606088436979; Sun, 22 Nov 2020 15:40:36 -0800 (PST) Received: from localhost.localdomain (h-158-174-22-6.NA.cust.bahnhof.se. [158.174.22.6]) by smtp.gmail.com with ESMTPSA id q13sm1178173lfk.147.2020.11.22.15.40.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 22 Nov 2020 15:40:36 -0800 (PST) From: Rikard Falkeborn To: "David S. Miller" , Jakub Kicinski Cc: Alex Elder , Kalle Valo , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, Rikard Falkeborn Subject: [PATCH net-next 1/2] soc: qcom: ipa: Constify static qmi structs Date: Mon, 23 Nov 2020 00:40:30 +0100 Message-Id: <20201122234031.33432-2-rikard.falkeborn@gmail.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201122234031.33432-1-rikard.falkeborn@gmail.com> References: <20201122234031.33432-1-rikard.falkeborn@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org These are only used as input arguments to qmi_handle_init() which accepts const pointers to both qmi_ops and qmi_msg_handler. Make them const to allow the compiler to put them in read-only memory. Signed-off-by: Rikard Falkeborn Acked-by: Alex Elder --- drivers/net/ipa/ipa_qmi.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ipa/ipa_qmi.c b/drivers/net/ipa/ipa_qmi.c index 5090f0f923ad..d2c3f273c233 100644 --- a/drivers/net/ipa/ipa_qmi.c +++ b/drivers/net/ipa/ipa_qmi.c @@ -168,7 +168,7 @@ static void ipa_server_bye(struct qmi_handle *qmi, unsigned int node) ipa_qmi->indication_sent = false; } -static struct qmi_ops ipa_server_ops = { +static const struct qmi_ops ipa_server_ops = { .bye = ipa_server_bye, }; @@ -234,7 +234,7 @@ static void ipa_server_driver_init_complete(struct qmi_handle *qmi, } /* The server handles two request message types sent by the modem. */ -static struct qmi_msg_handler ipa_server_msg_handlers[] = { +static const struct qmi_msg_handler ipa_server_msg_handlers[] = { { .type = QMI_REQUEST, .msg_id = IPA_QMI_INDICATION_REGISTER, @@ -261,7 +261,7 @@ static void ipa_client_init_driver(struct qmi_handle *qmi, } /* The client handles one response message type sent by the modem. */ -static struct qmi_msg_handler ipa_client_msg_handlers[] = { +static const struct qmi_msg_handler ipa_client_msg_handlers[] = { { .type = QMI_RESPONSE, .msg_id = IPA_QMI_INIT_DRIVER, @@ -463,7 +463,7 @@ ipa_client_new_server(struct qmi_handle *qmi, struct qmi_service *svc) return 0; } -static struct qmi_ops ipa_client_ops = { +static const struct qmi_ops ipa_client_ops = { .new_server = ipa_client_new_server, }; From patchwork Sun Nov 22 23:40:31 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rikard Falkeborn X-Patchwork-Id: 1404573 Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=DKuZomgn; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4CfRcx5b6hz9sTL for ; Mon, 23 Nov 2020 10:41:21 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726897AbgKVXkl (ORCPT ); Sun, 22 Nov 2020 18:40:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50764 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726847AbgKVXkj (ORCPT ); Sun, 22 Nov 2020 18:40:39 -0500 Received: from mail-lj1-x243.google.com (mail-lj1-x243.google.com [IPv6:2a00:1450:4864:20::243]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 781A9C0613CF; Sun, 22 Nov 2020 15:40:39 -0800 (PST) Received: by mail-lj1-x243.google.com with SMTP id o24so16084198ljj.6; Sun, 22 Nov 2020 15:40:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=0I/omSkEt2kL2zxUSqvevYzdi5z/5TNsUg1IEtpD0CE=; b=DKuZomgnkoLU2GG4VHWfesxnoXdhPdwVl90ZKO+qyGry86oBwaJql10KjzRnYkny0l C6MbcwRWZ4hnxqB7qD+eVqoqdFKGwUz+H+VSv4XwFXTA+jJZSwEO3jEtOeRZoS5NhgA1 RoZAhRBLLSUr3y35JoTYVJEbyGzPj2jWB5k9NWRiFVp31qWbQX0/qp9+MRuYI0Nm61aM lOQey5F2owxBWpGMC3Xa+7dQK/uWSR8GhJzxmdrIqvVSpnMtfRUrlYUYQi9GsC54cZM2 LsVIuVKHjEnHISc+HxkBpEiaBUnQtbzmUdD1ENw/8Ou4byr9OieYwfawzrl3ffvPhIep 2VQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=0I/omSkEt2kL2zxUSqvevYzdi5z/5TNsUg1IEtpD0CE=; b=jxWDFjRD2fefRljaDhPKeiwkteYKufN6DU2N11psjBWWkSNyJJ1ySD0pRtS4rNTCyw ivjk0tKpUhrW+dVXm8KOYjb0pU/1aEIxC/X8eBKxsMrPPLN5tM3OsI0ccj7xhpMz1+zR +eEHn+/b9XW/0NITA5zUcbA7uVtqSstJOekt8jJdrZox76IzKE3Q7+safFzZDr6CqhgQ 8P+go8PS5CCduTnZ9XYaoZmg4DkLF8m5YdsjF9QpEMtSkggirKkeeCw09LR/4YKuc+KA C37bUoqCBbfq/5sBjj3S5mlN9rzftKxpnv3XPkfVwIo1QaF+3sTqO7rzetckyTArZZFq RNnQ== X-Gm-Message-State: AOAM530MpmSQ/C+GJzfNnzOkOw1DM6IsV5ZFp71wke7iejEmSWfDHDBs SNWEpnaeceycy3oO3wdr3C8= X-Google-Smtp-Source: ABdhPJwHUkthoL13lFCHBkamhHxvBZWczt+cLQqPZqRUnct4ZOagib13KsARh4yd05qedbXsfe7BBQ== X-Received: by 2002:a2e:9b07:: with SMTP id u7mr10985426lji.219.1606088438005; Sun, 22 Nov 2020 15:40:38 -0800 (PST) Received: from localhost.localdomain (h-158-174-22-6.NA.cust.bahnhof.se. [158.174.22.6]) by smtp.gmail.com with ESMTPSA id q13sm1178173lfk.147.2020.11.22.15.40.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 22 Nov 2020 15:40:37 -0800 (PST) From: Rikard Falkeborn To: "David S. Miller" , Jakub Kicinski Cc: Alex Elder , Kalle Valo , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, Rikard Falkeborn Subject: [PATCH net-next 2/2] ath10k: Constify static qmi structs Date: Mon, 23 Nov 2020 00:40:31 +0100 Message-Id: <20201122234031.33432-3-rikard.falkeborn@gmail.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201122234031.33432-1-rikard.falkeborn@gmail.com> References: <20201122234031.33432-1-rikard.falkeborn@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org qmi_msg_handler[] and ath10k_qmi_ops are only used as input arguments to qmi_handle_init() which accepts const pointers to both qmi_ops and qmi_msg_handler. Make them const to allow the compiler to put them in read-only memory. Signed-off-by: Rikard Falkeborn --- drivers/net/wireless/ath/ath10k/qmi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/qmi.c b/drivers/net/wireless/ath/ath10k/qmi.c index ae6b1f402adf..07e478f9a808 100644 --- a/drivers/net/wireless/ath/ath10k/qmi.c +++ b/drivers/net/wireless/ath/ath10k/qmi.c @@ -917,7 +917,7 @@ static void ath10k_qmi_msa_ready_ind(struct qmi_handle *qmi_hdl, ath10k_qmi_driver_event_post(qmi, ATH10K_QMI_EVENT_MSA_READY_IND, NULL); } -static struct qmi_msg_handler qmi_msg_handler[] = { +static const struct qmi_msg_handler qmi_msg_handler[] = { { .type = QMI_INDICATION, .msg_id = QMI_WLFW_FW_READY_IND_V01, @@ -981,7 +981,7 @@ static void ath10k_qmi_del_server(struct qmi_handle *qmi_hdl, NULL); } -static struct qmi_ops ath10k_qmi_ops = { +static const struct qmi_ops ath10k_qmi_ops = { .new_server = ath10k_qmi_new_server, .del_server = ath10k_qmi_del_server, };