From patchwork Thu Nov 19 08:38:20 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Uros Bizjak X-Patchwork-Id: 1402798 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=sourceware.org; envelope-from=gcc-patches-bounces@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gcc.gnu.org Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.a=rsa-sha256 header.s=default header.b=WHqjCeFC; dkim-atps=neutral Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4CcCkn2bfqz9sT6 for ; Thu, 19 Nov 2020 19:38:39 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7AA923987C1C; Thu, 19 Nov 2020 08:38:34 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7AA923987C1C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1605775114; bh=osB9ANDjxPGJ0EiKYendfXS3sSzgjTNpV6pgguFdNKc=; h=Date:Subject:To:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=WHqjCeFCgFORmQLyTzNtvG80xuZ1BMIlJUfa/sybBMTcBu+7RI1sbwhIpsJBV5S3f NjREZ0O+G5NLTr6zyXgqcfbGxM+W6eSA5aDLRvR1vmfUplzLJBpcno8OBKbcKLA84u b0JNU6huIwywwvNadr3MfWIfYN4kq9zSyggOjFWM= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-qt1-x82f.google.com (mail-qt1-x82f.google.com [IPv6:2607:f8b0:4864:20::82f]) by sourceware.org (Postfix) with ESMTPS id 054DD386EC25 for ; Thu, 19 Nov 2020 08:38:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 054DD386EC25 Received: by mail-qt1-x82f.google.com with SMTP id t5so3793740qtp.2 for ; Thu, 19 Nov 2020 00:38:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=osB9ANDjxPGJ0EiKYendfXS3sSzgjTNpV6pgguFdNKc=; b=PSLFfCROs2Qx23237WqcYY9uvptfbgPCrE8FThwAN5yhK3NaBrJmY2pHFFX9MTRLbF YyVcGonagb0/Nwfenf2Id8VY3iFqcXw+EfHv0f3yCiYi0Xw9C4DYqDjid/hJY3Ttt+SW 0zBlRoZm4UTfcPD1xqwmg9TIwBzLF2CmiPLAoo0vSNbQdcu9PlDXfzcaeDn1kpMxW+X5 Mdu5dZGoNoetdLeK2ZPOOBKbTlHXWWv93OfnVENgwmI63Yx7twF4gHxgf4bgeXM+UUzg snZ/4QPOWP0mITUtGB9rGFFlxnH6mSR3rngxaUFR7ZP4pkYBJDZdau3tc6NzME9XrziC I9fg== X-Gm-Message-State: AOAM5303iR24SXwbCbvJdPTskx5ZyiaC8fa2lD+bbK9uQeSWJN8KrUOk RhiQi5Q5RRevR9FrnF5GeCoL4hPP625mBxHyibNxVWC83hGTQw== X-Google-Smtp-Source: ABdhPJwYtROpte5erttLUIOOYlvkmr/eqTp59McjmicIKFx0vMN4kB8k+jb1luaBTKkSFcjrgzrIjmTwgi/zKUnG+u4= X-Received: by 2002:ac8:7559:: with SMTP id b25mr9500035qtr.51.1605775111305; Thu, 19 Nov 2020 00:38:31 -0800 (PST) MIME-Version: 1.0 Date: Thu, 19 Nov 2020 09:38:20 +0100 Message-ID: Subject: [PATCH] i386: Disable *2_i387_1 for TARGET_SSE_MATH modes [PR97787] To: "gcc-patches@gcc.gnu.org" X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Uros Bizjak via Gcc-patches From: Uros Bizjak Reply-To: Uros Bizjak Errors-To: gcc-patches-bounces@gcc.gnu.org Sender: "Gcc-patches" This pattern interferes with *2_1 when TARGET_SSE_MATH modes are active. Combine pass is able to remove (use) RTXes and transforms *2_1 to *2_i387_1 where SSE alternatives are not available. 2020-11-19 Uroš Bizjak gcc/ PR target/97887 * config/i386/i386.md (*2_i387_1): Disable for TARGET_SSE_MATH modes. gcc/testsuite/ PR target/97887 * gcc.target/i386/pr97887.c: New test. Bootstrapped and regression tested on x86_64-linux-gnu {,-m32}. Pushed to mainline and gcc-10. Uros. diff --git a/gcc/config/i386/i386.md b/gcc/config/i386/i386.md index 52e306de00a..29935014772 100644 --- a/gcc/config/i386/i386.md +++ b/gcc/config/i386/i386.md @@ -10258,7 +10258,7 @@ (absneg:X87MODEF (match_operand:X87MODEF 1 "register_operand" "0,0"))) (clobber (reg:CC FLAGS_REG))] - "TARGET_80387" + "TARGET_80387 && !(SSE_FLOAT_MODE_P (mode) && TARGET_SSE_MATH)" "#") (define_split diff --git a/gcc/testsuite/gcc.target/i386/pr97887.c b/gcc/testsuite/gcc.target/i386/pr97887.c new file mode 100644 index 00000000000..b457f054bed --- /dev/null +++ b/gcc/testsuite/gcc.target/i386/pr97887.c @@ -0,0 +1,15 @@ +/* PR target/97887 */ +/* { dg-do compile } */ +/* { dg-options "-O2 -msse2 -mfpmath=sse" } */ + +float f (float a) +{ + return -a / a; +} + +double d (double a) +{ + return -a / a; +} + +/* { dg-final { scan-assembler-not "fchs" } } */