From patchwork Tue Nov 17 21:33:50 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 1401873 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=C9uIKj1z; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4CbK4x43lfz9s1l for ; Wed, 18 Nov 2020 08:36:17 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727919AbgKQVf4 (ORCPT ); Tue, 17 Nov 2020 16:35:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51826 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726136AbgKQVf4 (ORCPT ); Tue, 17 Nov 2020 16:35:56 -0500 Received: from mail-lj1-x243.google.com (mail-lj1-x243.google.com [IPv6:2a00:1450:4864:20::243]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 44F37C0613CF for ; Tue, 17 Nov 2020 13:35:56 -0800 (PST) Received: by mail-lj1-x243.google.com with SMTP id l10so26000486lji.4 for ; Tue, 17 Nov 2020 13:35:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=+EuZNr8yakXz6HzcHbLLveOlk4w2RFRzhA28nxSA3b8=; b=C9uIKj1zZJ920qameQpof+I2WV0sQKt8Fs+Iq57Ia6693H/l6Txp3cq28x8o2nBUPh KXTHyyy80vcnYIbhKRgMn0c1RLUZV1NXlB9UbOJ9N8kQl5bkmrZrqa+hjwFxDCBiuX07 R9J7xDmoH7gkZprhRNpMg5fmoPZ6HaYoEPeveq8Y13TWK7VYIMLFw6GUUSd1WBGwSVEj n1DR92e3KDgdmK9Jjl5F9M3TASNbymlJd1sHDayB2U2ZuF9Xm7kF9P2CELqH4a9jR7fq xV25L5M5PMeU3R+Lp1DeUZVJqDT7KPnN69yB3qTFwkPTbEyo8Wymo9wk3DkpleYvTbbo xr7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=+EuZNr8yakXz6HzcHbLLveOlk4w2RFRzhA28nxSA3b8=; b=kTHBZ1LyiJuzaO39UKevCTqrBMT4ziHGyXxCi3xLCG3J5wVzbpErIGeEvCb5T0mfu3 SyiDT2sB7fzr7QZ462TEfZa9m8u6rduoVO6Sj0G2J0gNjeKKaeHjDPqa5LfVx7+ty1mi R5JNFlVuGvRg+MoP2iOEhcH2PQFCKzK84r5kKuFCWrAW1EZzEnCliOYStmB0Dp9dxCKa ik3X/sCQn8taFfnuEqcKhgDdlwgM2S3amB9jakzTPEsgjxnPTGVw5f+6tBt/hLTxIo+9 py3rGL+7/0ALEJ70tYRO1JgjeNxqE9nH1bOUjeRRCrcNGPJ8YHpm0uxfbNItJ+c/zKau yemQ== X-Gm-Message-State: AOAM532gVMNU7UVhBm8Fbj99gdeIRxHE/az/K03fnDqf+cG0HddOrlzs LLhzd4/VKZVwG1H034p7uU8P1xhM8spWPozV X-Google-Smtp-Source: ABdhPJzCoB2MNpAhIibXw+Yq8LvmM91jJFbl1BkwCZWmEp6qdjyW+b32B7rDU77hMvZ/eQjFBAD/0A== X-Received: by 2002:a2e:2a86:: with SMTP id q128mr2652231ljq.158.1605648954579; Tue, 17 Nov 2020 13:35:54 -0800 (PST) Received: from localhost.localdomain (c-92d7225c.014-348-6c756e10.bbcust.telenor.se. [92.34.215.146]) by smtp.gmail.com with ESMTPSA id c9sm3301534lfd.98.2020.11.17.13.35.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Nov 2020 13:35:53 -0800 (PST) From: Linus Walleij To: linux-gpio@vger.kernel.org Cc: Bartosz Golaszewski , Linus Walleij , Yash Shah , "Wesley W . Terpstra" , Marc Zyngier Subject: [PATCH 1/2 v1] gpio: sifive: Set affinity callback to parent Date: Tue, 17 Nov 2020 22:33:50 +0100 Message-Id: <20201117213351.249668-1-linus.walleij@linaro.org> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org This assigns the .irq_set_affinity to the parent callback. I assume the sifive GPIO can be used in systems with SMP. I used the pattern making the hirerarchy tolerant for missing parent as in Marc's earlier patches. Cc: Yash Shah Cc: Wesley W. Terpstra Suggested-by: Marc Zyngier Signed-off-by: Linus Walleij --- ChangeLog RFT->v1: - Make the affinity setting call return -EINVAL if there is no parent. - Real patch because now we believe in this --- drivers/gpio/gpio-sifive.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/drivers/gpio/gpio-sifive.c b/drivers/gpio/gpio-sifive.c index c54dd08f2cbf..485820e4488c 100644 --- a/drivers/gpio/gpio-sifive.c +++ b/drivers/gpio/gpio-sifive.c @@ -128,6 +128,16 @@ static void sifive_gpio_irq_eoi(struct irq_data *d) irq_chip_eoi_parent(d); } +static int sifive_gpio_irq_set_affinity(struct irq_data *data, + const struct cpumask *dest, + bool force) +{ + if (data->parent_data) + return irq_chip_set_affinity_parent(data, dest, force); + + return -EINVAL; +} + static struct irq_chip sifive_gpio_irqchip = { .name = "sifive-gpio", .irq_set_type = sifive_gpio_irq_set_type, @@ -136,6 +146,7 @@ static struct irq_chip sifive_gpio_irqchip = { .irq_enable = sifive_gpio_irq_enable, .irq_disable = sifive_gpio_irq_disable, .irq_eoi = sifive_gpio_irq_eoi, + .irq_set_affinity = sifive_gpio_irq_set_affinity, }; static int sifive_gpio_child_to_parent_hwirq(struct gpio_chip *gc, From patchwork Tue Nov 17 21:33:51 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 1401874 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=fyNObB9r; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4CbK4y1ngFz9sRR for ; Wed, 18 Nov 2020 08:36:18 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728193AbgKQVgL (ORCPT ); Tue, 17 Nov 2020 16:36:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51872 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728160AbgKQVgL (ORCPT ); Tue, 17 Nov 2020 16:36:11 -0500 Received: from mail-lj1-x243.google.com (mail-lj1-x243.google.com [IPv6:2a00:1450:4864:20::243]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A234FC0613CF for ; Tue, 17 Nov 2020 13:36:10 -0800 (PST) Received: by mail-lj1-x243.google.com with SMTP id 142so12373291ljj.10 for ; Tue, 17 Nov 2020 13:36:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=QjVQoOTt3shsLqnsVnpkhic6+UrAPp0sadOUVrw9MEU=; b=fyNObB9rsiCq9KEHbVjCu2oUn2zFdNQH/YLWiUiSow/yuJDPFtC82vAU0WbX1Lij5R N5rJu9jqJFbVy5/sSRVKvRUcFVNjXb27MmM/UL/nAHomjKYDUxUnGEmto7r75ILKF9gz iKK7rCYcE9nbi5spdKNF21EItfdDW5ZAWURwTuFH84ld81xJb46oVVsydi/ADh+yfL66 uVt7eCYb2kuJ6wzOGuSp8s00CWbn2rmbfjg9fCURMzEWRX1XvC4zxtc6WDCyD6Lpf7RB du7qlzytnS9BAXiHIGUP/qk0LIkP/gG7qm2Xlx9N+PJX0IYBRkbk1Q/OWOX37xq1Nw/k aJeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=QjVQoOTt3shsLqnsVnpkhic6+UrAPp0sadOUVrw9MEU=; b=HWKKWXrDMk4C6vzjZ6MaCaqtojiBDN9DOVx5KF74LqeqG/jVv7X5+HMx/0XMAYKOPR iw31nlJDAGoOWW47Dnf8XXLRFbxUoo8OK6iGvNoaPjRuWsOtEXznKnNq8sF+RhvuPAVd cdPmSxfx2jlGj9CuwoK8BKhgIAaFxPuoKlhPtL3kH4Aq9Dpq2XrD1akE0F8Tk+hmzwAu wao38rXU9XzAtrTtqm6NaUrJHyeIr8za7fVdWukY/IMrsErx7ymQsbZTe0ArJAm9hg0d gZCbJI6oPHQvGxQdfDuTOoF+7xff8eQlSqCL/gYsoY41daOgDNbogsdnryvaHvfxaruv oRWg== X-Gm-Message-State: AOAM533lz2CGt++eaKBrgMmQJACaq0Y3404xdAVB1iDhivVCaPM0ZuN2 fSMY0f54PXp3YGczPf0Y9ocdfk1D03z/fqzm X-Google-Smtp-Source: ABdhPJw2Zx5kmRl9ou16dYnotpqkruuPoRwJnRI0RfoqkAzlmCilxeQl73JmtcLUqvcprVRST7dQQQ== X-Received: by 2002:a2e:bc1a:: with SMTP id b26mr2674103ljf.359.1605648968952; Tue, 17 Nov 2020 13:36:08 -0800 (PST) Received: from localhost.localdomain (c-92d7225c.014-348-6c756e10.bbcust.telenor.se. [92.34.215.146]) by smtp.gmail.com with ESMTPSA id c9sm3301534lfd.98.2020.11.17.13.36.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Nov 2020 13:36:08 -0800 (PST) From: Linus Walleij To: linux-gpio@vger.kernel.org Cc: Bartosz Golaszewski , Linus Walleij , Thierry Reding , Vidya Sagar , Marc Zyngier Subject: [PATCH 2/2 v1] gpio: tegra186: Set affinity callback to parent Date: Tue, 17 Nov 2020 22:33:51 +0100 Message-Id: <20201117213351.249668-2-linus.walleij@linaro.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201117213351.249668-1-linus.walleij@linaro.org> References: <20201117213351.249668-1-linus.walleij@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org This assigns the .irq_set_affinity to the parent callback. I assume the Tegra186 is an SMP system so this would be beneficial. I used the pattern making the hirerarchy tolerant for missing parent as in Marc's earlier patch. Cc: Thierry Reding Cc: Vidya Sagar Suggested-by: Marc Zyngier Signed-off-by: Linus Walleij --- ChangeLog RFT->v1: - Make the affinity setting call return -EINVAL if there is no parent. - Real patch because now we believe in this --- drivers/gpio/gpio-tegra186.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/drivers/gpio/gpio-tegra186.c b/drivers/gpio/gpio-tegra186.c index 9500074b1f1b..286e0b1f46e4 100644 --- a/drivers/gpio/gpio-tegra186.c +++ b/drivers/gpio/gpio-tegra186.c @@ -444,6 +444,16 @@ static int tegra186_irq_set_wake(struct irq_data *data, unsigned int on) return 0; } +static int tegra186_irq_set_affinity(struct irq_data *data, + const struct cpumask *dest, + bool force) +{ + if (data->parent_data) + return irq_chip_set_affinity_parent(data, dest, force); + + return -EINVAL; +} + static void tegra186_gpio_irq(struct irq_desc *desc) { struct tegra_gpio *gpio = irq_desc_get_handler_data(desc); @@ -690,6 +700,7 @@ static int tegra186_gpio_probe(struct platform_device *pdev) gpio->intc.irq_unmask = tegra186_irq_unmask; gpio->intc.irq_set_type = tegra186_irq_set_type; gpio->intc.irq_set_wake = tegra186_irq_set_wake; + gpio->intc.irq_set_affinity = tegra186_irq_set_affinity; irq = &gpio->gpio.irq; irq->chip = &gpio->intc;