From patchwork Thu Jan 4 10:51:17 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 855550 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="lWgCUq3d"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3zC4WL49w6z9s7s for ; Thu, 4 Jan 2018 21:57:18 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:References:To:From:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pV2F8CZihZK+Ws8aWoyWnjqx5jLHf62yWvu8KFbhJfA=; b=lWgCUq3d18ncex /C0pb2YiYnlRQraVIfCigDG6/8P+mUtuxBkdzFLTcjgePInkbzD+EJs0WJ/G/nuGGRqyv9ejdcEOr DoKwZ4NmRGEn3qCND7PtHhQIkX2AUV6mEDSeXufQ6H8MgCcZqCogppPljD18lNWGeGwo7qLqw7DZW 088OnHlS6B/kFMlDRO1llFodvrnai8udL11y/ql4YeYyuUsIoJ2iX0RPgnByhfBomqqGPKQoEbeOs gEZBxMCxjhnMyNPcnDGMSutayPQ+TqRtcq6pk8cFolaKPPm+So8Mjf959JzBvHjvLq/cYIi7IQaCc r2QQW5TrPAUl9JZ9fmpA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.89 #1 (Red Hat Linux)) id 1eX3Cz-0000dM-SR; Thu, 04 Jan 2018 10:57:13 +0000 Received: from mout.web.de ([212.227.17.12]) by bombadil.infradead.org with esmtps (Exim 4.89 #1 (Red Hat Linux)) id 1eX3Cw-0000c7-OK for linux-mtd@lists.infradead.org; Thu, 04 Jan 2018 10:57:12 +0000 Received: from [192.168.1.3] ([78.48.111.36]) by smtp.web.de (mrweb103 [213.165.67.124]) with ESMTPSA (Nemesis) id 0MPHKO-1ebSy600bQ-004R70; Thu, 04 Jan 2018 11:51:18 +0100 Subject: [PATCH 1/2] mtd/maps/sun_uflash: Delete an error message for a failed memory allocation in uflash_devinit() From: SF Markus Elfring To: linux-mtd@lists.infradead.org, Boris Brezillon , Brian Norris , Cyrille Pitchen , David Woodhouse , Marek Vasut , Richard Weinberger , Rob Herring References: <30c07f5a-578c-0e53-b80f-675fb24e6223@users.sourceforge.net> Message-ID: <7417f52d-ddba-e8f8-0014-31bc787213db@users.sourceforge.net> Date: Thu, 4 Jan 2018 11:51:17 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <30c07f5a-578c-0e53-b80f-675fb24e6223@users.sourceforge.net> Content-Language: en-GB X-Provags-ID: V03:K0:Fz1xCbCtCjVrWqV6R0w9pmoewI/L0O3PbNiJi0zDHnO+lzku1lk XG1TpUiBw8k96Mc3aj580GBtUCo+F/N6wP50PK8tL5/x2qKMUgHXhcgUJPfKcfGslo6xNDV CEdAyteFgWYbndcyuHv9jh+K/xxLdHXLNRfj+QC+tgepyPq9U4J30XYGx8yWRzrEqDZB5ZF qZaqwUkGDpNf56GtQc/HA== X-UI-Out-Filterresults: notjunk:1; V01:K0:xQ8Wbec3qOk=:FvhBAeJqXCz2ZAyGXj8uEU PCQUh4NXlsbchnvMl4boI2U/y1CqTPFmT9M9eJMU9pglpNt37D6zEKKweWwnfr0Iss+29cElQ MtouperV9IVapoitrfvLPN3XUCgjG0WX5MKYLYXcc44PwtApzH29IEw/amiwLqxM/mEYl5rDL vgM3Hq76mXH0GWpfeW8cgWqFrIdAyA/ZQbY9fUqdFPQn7vdg4Z0OzeJ5eb6rpesyOpXU4pyWi uSC0kJz9c5sqY1tv5F0oob7w/pwP0kBrvNONXBHdaufGVkLKUrvrDb2aCEuHrwXXAGo8xMUaQ VkeyC1H5PYdqiIRwP/7+LUza2wIJk6UJCnIe+FiFHvWeOx67i4FIiEBpCho2mlmjoVLVxp+1w CkRlIplHPD3zJUQ2sKVXfXVZQN1g1T6N+tqrF70jIITezDtxS2RfaG6pH7maha0MlZn6IPt6o lYC1maXqErtlZX0Ocw9XCek58r2rsF4AEMz981ErcGZ/hX9JMPgr5ZaUgDj4nx+O4EUp4aBzB ClJDKA8WLD0AsyvG607GJu+plQ/yvpvhwwCZaiHGGcYIyPK02FDE6byQNlMAi3XwtqjMAGJJL Fg3jrbr6Bgj3i/JJ8Ib1BinSoDRUzF5BOEXHys5/G737Q8BkGzEhHGTFEHN47PTsQbc5l4IlJ SI/J0S2um3AI1M9gKTrcrpPGgRjN3dOYQ5iuKHerKb6lHxkir+ZJffsCIslK2FUX4+OkdkUI2 cyj0qPYWqs87EI8/n0tOwnTdrtMz0N4GBWXXemuyIcByl3PxD0pb79BE8VHiUyUVu2+CLIdk6 QEv/C7QCG1fsbWfocCd2gNoEqwDSrdyknAD7fs+/WmLacfJ4QY= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180104_025711_134951_A53A72CA X-CRM114-Status: UNSURE ( 8.29 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -2.6 (--) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-2.6 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [212.227.17.12 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [212.227.17.12 listed in wl.mailspike.net] -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-janitors@vger.kernel.org, LKML Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org From: Markus Elfring Date: Thu, 4 Jan 2018 10:20:14 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/mtd/maps/sun_uflash.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/mtd/maps/sun_uflash.c b/drivers/mtd/maps/sun_uflash.c index 1e73bba6e286..80a253cc72e2 100644 --- a/drivers/mtd/maps/sun_uflash.c +++ b/drivers/mtd/maps/sun_uflash.c @@ -62,10 +62,8 @@ int uflash_devinit(struct platform_device *op, struct device_node *dp) } up = kzalloc(sizeof(struct uflash_dev), GFP_KERNEL); - if (!up) { - printk(KERN_ERR PFX "Cannot allocate struct uflash_dev\n"); + if (!up) return -ENOMEM; - } /* copy defaults and tweak parameters */ memcpy(&up->map, &uflash_map_templ, sizeof(uflash_map_templ)); From patchwork Thu Jan 4 10:52:27 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 855548 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="XPwEM3eQ"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3zC4QY6xHlz9t32 for ; Thu, 4 Jan 2018 21:53:05 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:References:To:From:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/XGeyF5sexOs6IK3Rv52xFBtSpa/bMjkBdOXo2yXIOo=; b=XPwEM3eQjeJPAG z1Iv/VNVa6EXblWM9nBEJs5eZnA4qTlj2Tjwd9hb/uswb2fg2RrtuJpacCHrqsoYhGbh0FjlQXf2e lu+2LFceL1q70ZSk3i5e8iDxNKVtezYiF1bHa6NfIOM8v8FGosAiOiB0UkmKe4w1A7vDd/byzSnd/ E3eQnGVRoC0QZBCEs/l6yl8dbgLQ5i3BD4AfB3KCGqOfBvhBa0Z0zAONl9n1wwRg8VePn3GfVJ7zR zYExKMu+HHQNF++iJ83DNVKp7plvs6ZvJ6dYTbCcwUpaqpqZFlevtLSjzhkMuR5SZgd6wVtb6Jo2N B3gWzysZ0at++N2dAiWA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.89 #1 (Red Hat Linux)) id 1eX38n-0005zg-35; Thu, 04 Jan 2018 10:52:53 +0000 Received: from mout.web.de ([212.227.17.12]) by bombadil.infradead.org with esmtps (Exim 4.89 #1 (Red Hat Linux)) id 1eX38j-0005xt-Qa for linux-mtd@lists.infradead.org; Thu, 04 Jan 2018 10:52:51 +0000 Received: from [192.168.1.3] ([78.48.111.36]) by smtp.web.de (mrweb101 [213.165.67.124]) with ESMTPSA (Nemesis) id 0LzsKN-1f1pMM0zzv-014yfD; Thu, 04 Jan 2018 11:52:29 +0100 Subject: [PATCH 2/2] mtd/maps/sun_uflash: Improve a size determination in uflash_devinit() From: SF Markus Elfring To: linux-mtd@lists.infradead.org, Boris Brezillon , Brian Norris , Cyrille Pitchen , David Woodhouse , Marek Vasut , Richard Weinberger , Rob Herring References: <30c07f5a-578c-0e53-b80f-675fb24e6223@users.sourceforge.net> Message-ID: <1c70e16b-f34c-d655-fdd4-67730f17a680@users.sourceforge.net> Date: Thu, 4 Jan 2018 11:52:27 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <30c07f5a-578c-0e53-b80f-675fb24e6223@users.sourceforge.net> Content-Language: en-GB X-Provags-ID: V03:K0:cRJLLQTf26lQwrZ/jb9y1sLsAYjojdyNI3dqQgTfBU4WIHsdlI0 xxT0yuBUXSt3afV8lCKCWC/sQ4V0NwwNA6qiNOpgEPycOOsObFUaGr/y3al+o1Zii6SBGVR td+FiIMa+zqL2YN/HjS0sci9I4+PJOJKd83wAcEiFq8xqUql2PwTn7UFnsVxjfMbvIj7H1I Yid4hcqwFo/xA5UImlhzA== X-UI-Out-Filterresults: notjunk:1; V01:K0:6ACPkgTiwaU=:liLrCGY1KEGNezlw/NRg4E CnSvrpFwCm8NRtdO9Y0p/gV1W4pxGz9XWwQNgA86WBbrdyMgQ5F+BYnhhKDmiey1Vwcnzh+9U ygA6s4OQagNLo1vS0KIE5FEM0suNKOVGz5nMbj6ArUHVAVKErhopn97QGau5rfxWbgtiifd4i NfJ2PhA5y/+3se9sAJ7plJWOcOHWxGPOlSc43g9mzLW4kG6wNQ3Z7Gc/bGkdf0vH18QoVKKO+ NiUezGxZbtBWWOhdBoPJ7/l5iQa1W0qiBFTYcB96IzDUHpbubqQxlCcTO1DYAfJsiwQKIk83n BqfsKQJIpwkF1+lA9jZtQ16Ji9UOUWolSkU7XHjOBfXTIwXc+E8fhbi3Dhhcgf8k6zjPsIfUC y65aedPaRJhxUorP1PDX7ahz7VOqqYg14htFyCxFovMb1SXqceF6fYjp/zvyel15+MbCEiu7X axC11m7lVsPbr4jbLv8svIIb8v/6/lqMk0bc/DUK+FO7IurbanZdBu3+iXxFpIBTYlDsrGLXQ MqvBBqoiRtKgqIybGJGMsSe+2Ag12YeLSvPwyFClSqxyNYB6zJ7StNeFVgU5coeIRtX3x2+wp TcolyFYAuZqNLvmmoP9mLRb4JYhge03ekT8wAt4Ehh/BZGN9aghY1kquE+IAf6q6cnMFi4QZg Hvdp7/YnpvwlkLvS96oEB9xsG+J46LfBS471ISQgtCXqsJsfyH9HWNf20p5mR4WO6Nmo2mopa NVYWegEAxIeu27UR3tqjWay9Wsc6kIVnrB3SMbKpsU3Bw7DFBDkw0lFy1I+SLtvrqNjKdV3HL CrnVhd8aIot8AzLwkMtxDO1OolG3XCfRHEZVB2YKNTeMAFyhG0= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180104_025250_222572_F83FD269 X-CRM114-Status: UNSURE ( 8.87 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -2.6 (--) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-2.6 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [212.227.17.12 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [212.227.17.12 listed in wl.mailspike.net] -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-janitors@vger.kernel.org, LKML Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org From: Markus Elfring Date: Thu, 4 Jan 2018 11:38:28 +0100 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/mtd/maps/sun_uflash.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mtd/maps/sun_uflash.c b/drivers/mtd/maps/sun_uflash.c index 80a253cc72e2..16a4f16a2680 100644 --- a/drivers/mtd/maps/sun_uflash.c +++ b/drivers/mtd/maps/sun_uflash.c @@ -61,7 +61,7 @@ int uflash_devinit(struct platform_device *op, struct device_node *dp) return -ENODEV; } - up = kzalloc(sizeof(struct uflash_dev), GFP_KERNEL); + up = kzalloc(sizeof(*up), GFP_KERNEL); if (!up) return -ENOMEM;