From patchwork Tue Nov 3 09:32:35 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Santosh Sivaraj X-Patchwork-Id: 1392743 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4CQPkb4zl7z9sSs for ; Tue, 3 Nov 2020 20:34:31 +1100 (AEDT) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=fossix.org Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=fossix-org.20150623.gappssmtp.com header.i=@fossix-org.20150623.gappssmtp.com header.a=rsa-sha256 header.s=20150623 header.b=T5pOlxf8; dkim-atps=neutral Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4CQPkb48zyzDqTg for ; Tue, 3 Nov 2020 20:34:31 +1100 (AEDT) X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=fossix.org (client-ip=2607:f8b0:4864:20::442; helo=mail-pf1-x442.google.com; envelope-from=santosh@fossix.org; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=fossix.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=fossix-org.20150623.gappssmtp.com header.i=@fossix-org.20150623.gappssmtp.com header.a=rsa-sha256 header.s=20150623 header.b=T5pOlxf8; dkim-atps=neutral Received: from mail-pf1-x442.google.com (mail-pf1-x442.google.com [IPv6:2607:f8b0:4864:20::442]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4CQPhq5gylzDqLW for ; Tue, 3 Nov 2020 20:32:55 +1100 (AEDT) Received: by mail-pf1-x442.google.com with SMTP id y14so13662677pfp.13 for ; Tue, 03 Nov 2020 01:32:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fossix-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=bXPiKnajprsVmoagr8lc4F80WvhfqnnWb0E5r9CyaTA=; b=T5pOlxf8VV1zzfEju8qFL0DQ4EgCEIfPJz8yMuOXt9szWzNyKhE3E7pCm9Z+QU9CmQ nFrDtg7EldsI+XtcSwwtrCnMy2PqYorfKH7J31UgniG2rjwnNWjcnLc6uVdBJdxsxsoU vE/JNiNwI72jpR/PfnREef8qfnb/YPJj/H4Mhz0hrhMa+s7R3UzhhVoATGKGImB+hfZf vJB9T46VmRkQyPI5Dvtxp8xkOVwKj96e1WYcF9kvLK2nU6ol8WdoGfdDU8IHvSXXa7s+ l+vQ+h0j0cZAxTv6mCAnYz5y+8WayoQQIJ+8zbVpb9CODqZgIxt+fV7VxCv+38oV9fKV 3JvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=bXPiKnajprsVmoagr8lc4F80WvhfqnnWb0E5r9CyaTA=; b=PSuN40TWNx4WBUbHtZXjrEJRqkFJyoTF/0fT/wVwG5zQlBpbuuYPvQGYTFpMr2sIvR ZrxZB4pn+EoL5KZg/6ZN9AiEBxMTXPda6lErDcvsYB033SaTwAIeML0mWWLfDz8KK7gt I2sPsigTIXwwD2yvpToBaUJj+rh2EXxctUc0ltVcLtVyBik+8G4yj3csG/IdKAJ72MgV jISoZy77AuTocEHSidBG93WhLssW9r2Cxm0Vf9W6YwJPMgiaCK2gH31T42r0ELi4wDbd wLbAO6Bmfas8XGpRvhQZuQVl7/emnUBkz+TaUg0xH/2GQFJhsGPzOUScdb+lFoIaLUkS dwKA== X-Gm-Message-State: AOAM530Pe0+fLDbyllvAikotUzG+c33Z7Mg39s1gxXGMDZANZI/1U1mI 8JE3N7YXHgu03iijTjihSgJO7A== X-Google-Smtp-Source: ABdhPJxFlhZATRI9DgOKBEyXjdfT2Eg14GrNTRW8hc1WOeEvBSg28bBtiktlPKw2bfrHQ9h0nZhDOA== X-Received: by 2002:a65:688b:: with SMTP id e11mr6790464pgt.175.1604395972269; Tue, 03 Nov 2020 01:32:52 -0800 (PST) Received: from santosiv.in.ibm.com.com ([103.21.79.4]) by smtp.gmail.com with ESMTPSA id 194sm4441193pfz.142.2020.11.03.01.32.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Nov 2020 01:32:51 -0800 (PST) From: Santosh Sivaraj To: Linux Kernel , Michael Ellerman , linuxppc-dev Subject: [RESEND PATCH] kernel/watchdog: Fix watchdog_allowed_mask not used warning Date: Tue, 3 Nov 2020 15:02:35 +0530 Message-Id: <20201103093235.655665-1-santosh@fossix.org> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: pmladek@suse.com, Santosh Sivaraj , bala24@linux.ibm.com Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" Define watchdog_allowed_mask only when SOFTLOCKUP_DETECTOR is enabled. Signed-off-by: Santosh Sivaraj --- Original patch is here: https://lore.kernel.org/lkml/20190807014417.9418-1-santosh@fossix.org/ A similar patch was also sent by Balamuruhan and reviewed by Petr. https://lkml.org/lkml/2020/8/20/1030 kernel/watchdog.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/watchdog.c b/kernel/watchdog.c index 5abb5b22ad13..71109065bd8e 100644 --- a/kernel/watchdog.c +++ b/kernel/watchdog.c @@ -44,8 +44,6 @@ int __read_mostly soft_watchdog_user_enabled = 1; int __read_mostly watchdog_thresh = 10; static int __read_mostly nmi_watchdog_available; -static struct cpumask watchdog_allowed_mask __read_mostly; - struct cpumask watchdog_cpumask __read_mostly; unsigned long *watchdog_cpumask_bits = cpumask_bits(&watchdog_cpumask); @@ -162,6 +160,8 @@ static void lockup_detector_update_enable(void) int __read_mostly sysctl_softlockup_all_cpu_backtrace; #endif +static struct cpumask watchdog_allowed_mask __read_mostly; + /* Global variables, exported for sysctl */ unsigned int __read_mostly softlockup_panic = CONFIG_BOOTPARAM_SOFTLOCKUP_PANIC_VALUE;