From patchwork Wed Jan 3 14:23:14 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Rini X-Patchwork-Id: 855042 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 3zBY7f6mjqz9s75 for ; Thu, 4 Jan 2018 01:23:26 +1100 (AEDT) Received: by lists.denx.de (Postfix, from userid 105) id 9FAA1C21DA3; Wed, 3 Jan 2018 14:23:24 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id BE9CAC21C2B; Wed, 3 Jan 2018 14:23:21 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 08E1DC21C2B; Wed, 3 Jan 2018 14:23:19 +0000 (UTC) Received: from mail-yb0-f193.google.com (mail-yb0-f193.google.com [209.85.213.193]) by lists.denx.de (Postfix) with ESMTPS id 3F9C5C21C29 for ; Wed, 3 Jan 2018 14:23:19 +0000 (UTC) Received: by mail-yb0-f193.google.com with SMTP id a82so635245ybg.1 for ; Wed, 03 Jan 2018 06:23:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=glHJ+y8fARm6EsUiur8NXubnrCWGqPmyaxLvn4DgkXc=; b=qDE5n6dGijL6Mlp9fU5rBcFQp2VEWHMkAx+mpKlgwVokH68M4Q5ar/vMnzmUQylS/l aM2WHHHL6ohmMawXvOj66nZJ3ZJ3EPNauHlK4H1GEaVV3oZY5n2KOPsqLGdVpYMFvGDH 2SSd4U2DzNLf5fSjb9j9RMZSAHFB2dyk7YtEFjGDfX5xTXgN/rDK/MHeH3HAnEns/Ulj 6lXb/793HLaydR36O5NYhIjFJdj+fpXICW2fSWb1+zCs423SHTMG1m4xamAkD/HXDziU ZTV0fnhslYG+0E5alnJVwYu+KiHn+RnkZFF749fntL4MXUC6mBb2B7KQj0DdwkeXRlYK 0Uxw== X-Gm-Message-State: AKGB3mLFoJpbM+sxW9pSqVsR2KGsE9t7UFpoEvjdiw2pGIzlMEeb0hox ojXEFgW47hYF5AlVDEfmL6Ia X-Google-Smtp-Source: ACJfBouFEILQdUTD5FPmobq4gpp9hSOfdBhV/fZJbwnMap8GmuEKRvFcKe7oYpO2SL2M+XlCDNpL/Q== X-Received: by 10.37.217.3 with SMTP id q3mr1462673ybg.523.1514989397887; Wed, 03 Jan 2018 06:23:17 -0800 (PST) Received: from localhost.localdomain (cpe-65-184-142-68.ec.res.rr.com. [65.184.142.68]) by smtp.gmail.com with ESMTPSA id i207sm420186ywe.38.2018.01.03.06.23.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 03 Jan 2018 06:23:17 -0800 (PST) From: Tom Rini To: u-boot@lists.denx.de Date: Wed, 3 Jan 2018 09:23:14 -0500 Message-Id: <1514989394-24442-1-git-send-email-trini@konsulko.com> X-Mailer: git-send-email 2.7.4 Subject: [U-Boot] [PATCH] GPIO: pca953x: Rework to not include commands in SPL X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" The command portion of the GPIO driver can only be used in full SPL so re-work to guard the command related portions and mark it as static. Cc: Bin Meng Cc: Simon Glass Cc: Philipp Tomsich Signed-off-by: Tom Rini Reviewed-by: Simon Glass --- drivers/gpio/pca953x.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpio/pca953x.c b/drivers/gpio/pca953x.c index d1c1ae141125..10a105df94ab 100644 --- a/drivers/gpio/pca953x.c +++ b/drivers/gpio/pca953x.c @@ -142,7 +142,7 @@ int pca953x_get_val(uint8_t chip) return (int)val; } -#ifdef CONFIG_CMD_PCA953X +#if defined(CONFIG_CMD_PCA953X) && !defined(CONFIG_SPL_BUILD) /* * Display pca953x information */ @@ -193,7 +193,7 @@ static int pca953x_info(uint8_t chip) return 0; } -cmd_tbl_t cmd_pca953x[] = { +static cmd_tbl_t cmd_pca953x[] = { U_BOOT_CMD_MKENT(device, 3, 0, (void *)PCA953X_CMD_DEVICE, "", ""), U_BOOT_CMD_MKENT(output, 4, 0, (void *)PCA953X_CMD_OUTPUT, "", ""), U_BOOT_CMD_MKENT(input, 3, 0, (void *)PCA953X_CMD_INPUT, "", ""), @@ -201,7 +201,7 @@ cmd_tbl_t cmd_pca953x[] = { U_BOOT_CMD_MKENT(info, 2, 0, (void *)PCA953X_CMD_INFO, "", ""), }; -int do_pca953x(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) +static int do_pca953x(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) { static uint8_t chip = CONFIG_SYS_I2C_PCA953X_ADDR; int ret = CMD_RET_USAGE, val;