From patchwork Thu Oct 29 14:25:42 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: chaihaoyu X-Patchwork-Id: 1390191 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=huawei.com Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4CMT813tcrz9sS8 for ; Fri, 30 Oct 2020 01:57:53 +1100 (AEDT) Received: from localhost ([::1]:37824 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kY9N8-00006y-Rp for incoming@patchwork.ozlabs.org; Thu, 29 Oct 2020 10:57:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51618) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kY8sN-0001la-Hc for qemu-devel@nongnu.org; Thu, 29 Oct 2020 10:26:05 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:2425) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kY8sK-0005tw-JH for qemu-devel@nongnu.org; Thu, 29 Oct 2020 10:26:03 -0400 Received: from DGGEMS407-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4CMSR55RKMzLrCm; Thu, 29 Oct 2020 22:25:53 +0800 (CST) Received: from [10.108.235.54] (10.108.235.54) by DGGEMS407-HUB.china.huawei.com (10.3.19.207) with Microsoft SMTP Server id 14.3.487.0; Thu, 29 Oct 2020 22:25:42 +0800 From: chaihaoyu Subject: [PATCH] spaces are required in some places To: Message-ID: <34e5417e-f81d-e399-ae2c-0f27467a5f43@huawei.com> Date: Thu, 29 Oct 2020 22:25:42 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 X-Originating-IP: [10.108.235.54] X-CFilter-Loop: Reflected Received-SPF: pass client-ip=45.249.212.191; envelope-from=chaihaoyu1@huawei.com; helo=szxga05-in.huawei.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/29 08:11:09 X-ACL-Warn: Detected OS = Linux 3.1-3.10 [fuzzy] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Thu, 29 Oct 2020 10:57:05 -0400 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex.chen@huawei.com, hunongda@huawei.com, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Date: Thu, 29 Oct 2020 22:01:33 +0800 signed-off-by: Haoyu Chai Reported-by: Euler Robot While reading softmmu related code, I found some style problems. Some spaces are required in softmmu/memory.c --- softmmu/memory.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) -- diff --git a/softmmu/memory.c b/softmmu/memory.c index ee4a6bc168..550cffe8f6 100644 --- a/softmmu/memory.c +++ b/softmmu/memory.c @@ -158,7 +158,7 @@ enum ListenerDirection { Forward, Reverse }; MemoryRegionSection mrs = section_from_flat_range(fr, \ address_space_to_flatview(as)); \ MEMORY_LISTENER_CALL(as, callback, dir, &mrs, ##_args); \ - } while(0) + } while (0) struct CoalescedMemoryRange { AddrRange addr; @@ -329,7 +329,7 @@ static void flatview_simplify(FlatView *view) while (i < view->nr) { j = i + 1; while (j < view->nr - && can_merge(&view->ranges[j-1], &view->ranges[j])) { + && can_merge(&view->ranges[j - 1], &view->ranges[j])) { int128_addto(&view->ranges[i].addr.size, view->ranges[j].addr.size); ++j; } @@ -834,8 +834,8 @@ static void address_space_update_ioeventfds(AddressSpace *as) ioeventfds = g_realloc(ioeventfds, ioeventfd_max * sizeof(*ioeventfds)); } - ioeventfds[ioeventfd_nb-1] = fr->mr->ioeventfds[i]; - ioeventfds[ioeventfd_nb-1].addr = tmp; + ioeventfds[ioeventfd_nb - 1] = fr->mr->ioeventfds[i]; + ioeventfds[ioeventfd_nb - 1].addr = tmp; } } } @@ -2343,8 +2343,8 @@ void memory_region_add_eventfd(MemoryRegion *mr, ++mr->ioeventfd_nb; mr->ioeventfds = g_realloc(mr->ioeventfds, sizeof(*mr->ioeventfds) * mr->ioeventfd_nb); - memmove(&mr->ioeventfds[i+1], &mr->ioeventfds[i], - sizeof(*mr->ioeventfds) * (mr->ioeventfd_nb-1 - i)); + memmove(&mr->ioeventfds[i + 1], &mr->ioeventfds[i], + sizeof(*mr->ioeventfds) * (mr->ioeventfd_nb - 1 - i)); mr->ioeventfds[i] = mrfd; ioeventfd_update_pending |= mr->enabled; memory_region_transaction_commit(); @@ -2376,11 +2376,11 @@ void memory_region_del_eventfd(MemoryRegion *mr, } } assert(i != mr->ioeventfd_nb); - memmove(&mr->ioeventfds[i], &mr->ioeventfds[i+1], - sizeof(*mr->ioeventfds) * (mr->ioeventfd_nb - (i+1))); + memmove(&mr->ioeventfds[i], &mr->ioeventfds[i + 1], + sizeof(*mr->ioeventfds) * (mr->ioeventfd_nb - (i + 1))); --mr->ioeventfd_nb; mr->ioeventfds = g_realloc(mr->ioeventfds, - sizeof(*mr->ioeventfds)*mr->ioeventfd_nb + 1); + sizeof(*mr->ioeventfds) * mr->ioeventfd_nb + 1); ioeventfd_update_pending |= mr->enabled; memory_region_transaction_commit(); }