From patchwork Wed Jan 3 06:19:46 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julia Lawall X-Patchwork-Id: 854890 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3zBLPd6R8Wz9sBZ for ; Wed, 3 Jan 2018 17:19:49 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751442AbeACGTs (ORCPT ); Wed, 3 Jan 2018 01:19:48 -0500 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:42933 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751344AbeACGTs (ORCPT ); Wed, 3 Jan 2018 01:19:48 -0500 X-IronPort-AV: E=Sophos;i="5.45,500,1508796000"; d="scan'208";a="307464255" Received: from abo-202-111-68.mrs.modulonet.fr (HELO [192.168.0.15]) ([85.68.111.202]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Jan 2018 07:19:46 +0100 Date: Wed, 3 Jan 2018 07:19:46 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: Linus Walleij cc: linux-gpio@vger.kernel.org, kbuild-all@01.org Subject: [PATCH] regulator: lp8788-ldo: fix odd_ptr_err.cocci warnings Message-ID: User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org From: Fengguang Wu PTR_ERR should normally access the value just tested by IS_ERR Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci Fixes: 460e9d2590fe ("regulator: lp8788-ldo: Pass descriptor instead of GPIO number") Signed-off-by: Fengguang Wu Signed-off-by: Julia Lawall --- Semantic patch information: There can be false positives in the patch case, where it is the call to IS_ERR that is wrong. lp8788-ldo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- a/drivers/regulator/lp8788-ldo.c +++ b/drivers/regulator/lp8788-ldo.c @@ -507,7 +507,7 @@ static int lp8788_config_ldo_enable_mode enable_id, GPIOD_OUT_HIGH); if (IS_ERR(ldo->ena_gpiod)) - return PTR_ERR(ldo->ena->gpiod); + return PTR_ERR(ldo->ena_gpiod); /* if no GPIO for ldo pin, then set default enable mode */ if (!ldo->ena_gpiod)