From patchwork Tue Oct 27 23:26:55 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Badel X-Patchwork-Id: 1389079 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=eaton.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=Eaton.onmicrosoft.com header.i=@Eaton.onmicrosoft.com header.a=rsa-sha256 header.s=selector1-Eaton-onmicrosoft-com header.b=psBQFS4M; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4CLWSH6zl5z9sVZ for ; Wed, 28 Oct 2020 12:38:39 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725859AbgJ1BiT (ORCPT ); Tue, 27 Oct 2020 21:38:19 -0400 Received: from mail2.eaton.com ([192.104.67.3]:10500 "EHLO loutcimsva02.etn.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1833000AbgJ0X1E (ORCPT ); Tue, 27 Oct 2020 19:27:04 -0400 Received: from loutcimsva02.etn.com (loutcimsva02.etn.com [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 21F38F817F; Tue, 27 Oct 2020 19:26:58 -0400 (EDT) Received: from loutcimsva02.etn.com (loutcimsva02.etn.com [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0A2AFF8167; Tue, 27 Oct 2020 19:26:58 -0400 (EDT) Received: from SIMTCSGWY04.napa.ad.etn.com (simtcsgwy04.napa.ad.etn.com [151.110.126.121]) by loutcimsva02.etn.com (Postfix) with ESMTPS; Tue, 27 Oct 2020 19:26:57 -0400 (EDT) Received: from LOUTCSHUB04.napa.ad.etn.com (151.110.40.77) by SIMTCSGWY04.napa.ad.etn.com (151.110.126.121) with Microsoft SMTP Server (TLS) id 14.3.468.0; Tue, 27 Oct 2020 19:26:57 -0400 Received: from USSTCSEXHET01.NAPA.AD.ETN.COM (151.110.240.153) by LOUTCSHUB04.napa.ad.etn.com (151.110.40.77) with Microsoft SMTP Server (TLS) id 14.3.468.0; Tue, 27 Oct 2020 19:26:56 -0400 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.43) by hybridmail.eaton.com (151.110.240.153) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1591.10; Tue, 27 Oct 2020 19:26:36 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JPshk5Yhv9S/5u7jDLk874KIFWccOPAjt0rvIjxzyiYT1LDNyVJq9LRqg48PGwRPGpzzUY3/Hl6pXETSWpmJcvJ1DehAaDQiJ9xprHnkToBv1hhqFa8THHqH7tauLseZvIYWU5oDYD8HU5R4jFwIBVdFVICLgtT/KKaLsjOJy2M8wtkHS/Cmx0hhLEnJHl605UcD3t4blLTqBj7h/oFeRloZLWKUJngaMDLfRtwe/JN5HVTxTT4uf5DHT0q404ygSZzVNvcuviwJWLNA+b20F7MN3beuGr7KJ0YB30mcp4alHyqcDBrw6qc2wtS3AUZrqBdSWlyBAZeMOQhGWAIoZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=d9XAMYLbd7vO1yvGWcqNnTUG0nTD6pY5TEE/U38B4vQ=; b=buyxYuxgH0GBLathsqxgDw/JrFN+/ejB+jSF1D7jwj9HjYln19285vpJjM66K0TZ1ScZNK/TLoEyC4F3JgELRUdK4Z0dGgdDjXDV6NjE8TgubEbQi8t4GsI8CozsJWSc0yOE2/sEtw9PWoqLPXDeQtLCGHyotZ8SgRKR5hr0ofvZ5gQeZ/SAyy8eMNwVlkrOdiX1ZEQPvX98AVPmqbG1Ud7uU7LzoFLrx80kgQd2eGssJj35GcsQPEw76zZfXqpkIL/wWvR/5mhdOA02Y0aa4odQGf8nFAdnfG+PYwaoW0sUTvV/Af4aKVQAvDQZsCBOTX7Nu+A+UB70IcQtTC2Cug== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=eaton.com; dmarc=pass action=none header.from=eaton.com; dkim=pass header.d=eaton.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Eaton.onmicrosoft.com; s=selector1-Eaton-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=d9XAMYLbd7vO1yvGWcqNnTUG0nTD6pY5TEE/U38B4vQ=; b=psBQFS4Mww5GU8UodsXxNBahA7+c96cUQ3Yo1CunTqswXBXmS+feJMYC0kzCH/BwrZ6wzKd/EOJ1RIVTsYYh2f1nbXuSJThPATW+Jl91jVJGNgCpqJRiLesXI6HoDUlqf2neX1Tz5veZd2dB7InSYm5O9R5SPkhZOmjd8YhzSeM= Received: from CY4PR1701MB1878.namprd17.prod.outlook.com (2603:10b6:910:6d::13) by CY4PR17MB1942.namprd17.prod.outlook.com (2603:10b6:903:94::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3477.22; Tue, 27 Oct 2020 23:26:55 +0000 Received: from CY4PR1701MB1878.namprd17.prod.outlook.com ([fe80::a5a5:a48b:7577:6b45]) by CY4PR1701MB1878.namprd17.prod.outlook.com ([fe80::a5a5:a48b:7577:6b45%6]) with mapi id 15.20.3477.028; Tue, 27 Oct 2020 23:26:55 +0000 From: "Badel, Laurent" To: "davem@davemloft.net" , "m.felsch@pengutronix.de" , "fugang.duan@nxp.com" , "kuba@kernel.org" , "andrew@lunn.ch" , Heiner Kallweit , "linux@armlinux.org.uk" , "p.zabel@pengutronix.de" , "lgirdwood@gmail.com" , "broonie@kernel.org" , "robh+dt@kernel.org" , "richard.leitner@skidata.com" , "netdev@vger.kernel.org" , "devicetree@vger.kernel.org" , "f.fainelli@gmail.com" CC: "Quette, Arnaud" Subject: [PATCH net 1/4] net:phy:smsc: enable PHY_RST_AFTER_CLK_EN if ref clock is not set Thread-Topic: [PATCH net 1/4] net:phy:smsc: enable PHY_RST_AFTER_CLK_EN if ref clock is not set Thread-Index: AdasuKId7Rcgsqy5TdKHTeqpGTl6ug== Date: Tue, 27 Oct 2020 23:26:55 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: davemloft.net; dkim=none (message not signed) header.d=none;davemloft.net; dmarc=none action=none header.from=eaton.com; x-originating-ip: [89.217.230.232] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 61fe2121-f03b-47e8-3ea5-08d87acfcac6 x-ms-traffictypediagnostic: CY4PR17MB1942: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Ps7lz1h7xuvNaSPaJhPw3df2Ahvx3quI86Pyi3rTABucn6miKc8ICjN5s9sr+yX2XLvr3UGBaXjcrSjeRtIta9d1SAkQoqDd/niWmOMSK+GqAHdTYBGsIOgiFKQyLGk7BaVbs2OHC6aU+EJU4y/UjwUWDz5GVcl2y5jW9UAZtAeSx569YIrpQY/zHBaMrWivHU2tK5k5a4TYYOaJl1taeAdnyS/kBeqh4AgRvoYKnEKhXlWGG3LXiUXNMha6eBxL3E9Ku0B8Hkw5srJrNwOo0CHGiprvwoFGECCYxeRbrAXMCpjKpbxS1T1wLlW9z29m1Jg14PikU0hx7OLjaGnVuoSX2HTEA3IEMUlCUdazCiZQfOOHKCUjPo8OD5+MrYTy x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CY4PR1701MB1878.namprd17.prod.outlook.com;PTR:;CAT:NONE;SFS:(376002)(39860400002)(136003)(366004)(396003)(346002)(6506007)(8676002)(8936002)(107886003)(9686003)(2906002)(86362001)(4326008)(64756008)(66946007)(33656002)(478600001)(52536014)(66476007)(76116006)(66556008)(5660300002)(66446008)(71200400001)(316002)(186003)(26005)(110136005)(7696005)(55016002)(83380400001)(7416002)(921003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: DjD4Go6xJc86b1eBUM3cheCVRMqFe5cUXHfsxFuIZOKBStbqWMvjTFjcnHV+drnT8JamDvQtPB4muxQ6HtwYlcy0IG0UJbTVguEkn9eBo9hd1OB5jeppitaFtFOUYRChcGIqycWQjXYdUwZk47Ju5GnLT71/LcoYfYY+BmuZGdHWCQxyDq7xeXvbh2TUW+d6TZ7u0TkKeSByx8xF3h6h4c5Yb7aYOJD8YHRh4Db4sUCOqHhfzE6cWhumd/vkxUlpYfOKTw/2phK6Oi0689YEfB7L5k0k6AxLe/hmHuP27yywp7rAGV2Swf8y5wWFvZIZiD347xgpOoKurub9gHsQtZrf058/I1Q5Mo4PqUknxSUiVdG3mek0Pjj+2QoI+7EBggDdyNXRB5zo8M/0+MAeEapvSmtFwMvLa/AhVAYvlBSJsoWSoCZLm5yxX5Wp7x1/A6FqhxPICSm2SNjQYxykzUzdApX/5xNFCUfqLpyntXhTKzBrIveaR8mNaHlNokiiowFz/hVybe64LG4KeZbknlRdjbRnQkjjamYfk1UIEbQd5KICGUWyFxj6u+umCF3RHB0OSxny8YrVQb8UBmBUa2Soj82w/6lpPz7yNeWel1qSjZ03EaW05PIKQb4fDBVKbZsnJ2cg+9J+znSF7CUM7g== MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR1701MB1878.namprd17.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 61fe2121-f03b-47e8-3ea5-08d87acfcac6 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Oct 2020 23:26:55.0634 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: d6525c95-b906-431a-b926-e9b51ba43cc4 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: SbW0FisJ3eWvER4fqF1vGnK8sdLVXpTW7MF21hoeEcGQOIW/QhM8WfoF1PgwPcYWcjuPcn/RqWMwgmvDfneuDg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR17MB1942 X-TM-SNTS-SMTP: A6DFE5C5683E1DC8C8BE5E01C24FF83A4F4C6733C0CD068BDAF6975985C411752002:8 X-OriginatorOrg: eaton.com X-EXCLAIMER-MD-CONFIG: 96b59d02-bc1a-4a40-8c96-611cac62bce9 X-TM-AS-GCONF: 00 X-TM-AS-Product-Ver: IMSVA-9.1.0.1988-8.6.0.1013-25752.003 X-TM-AS-Result: No-0.689-10.0-31-10 X-imss-scan-details: No-0.689-10.0-31-10 X-TMASE-Version: IMSVA-9.1.0.1988-8.6.1013-25752.003 X-TMASE-Result: 10-0.689300-10.000000 X-TMASE-MatchedRID: e7Ukgmbx2cyYizZS4XBb35VRzPxemJL0APiR4btCEeYd0WOKRkwsh9Sh vIchwjOu/ojs7zY2kdlk5NRCsylb+a91xPCrfpdC/ccgt/EtX/3zDFXwlHc2qIdfRwNmJj4N224 ueXqtKLvI49L/4WyKckk+8jV4IoVX0bQcZcDDFnw/ApMPW/xhXkyQ5fRSh265VWQnHKxp38huNR GoPKGToay1D/w95rX+sGfwDYJyJijlRxm3A2wKugtuKBGekqUpUfEQFBqv0mdDC7Q2i0S4itOJG GkIdSc4DsO2o1mDrpjoLQRNyVnczutNRF3pWfw8qNl2PpZjORaZqPu8XQH2ta3w6jnqiSeEqaWl lv2uQLQb+NnrrnzwGgZXX8DI70XVFwVtTn8Pj+qqUcpaEPPs/JWBOSsMjKAbwL6SxPpr1/I= X-TMASE-SNAP-Result: 1.821001.0001-0-1-12:0,22:0,33:0,34:0-0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Subject: [PATCH net 1/4] net:phy:smsc: enable PHY_RST_AFTER_CLK_EN if ref clock is not set Description: for compatibility, restore PHY_RST_AFTER_CLK_EN flag for LAN8720, but clear it if the driver successfully retrieves a reference to the ref clk. This ensures compatibility for systems that rely on the PHY reset workaround, but fail to update their DT with the 'clocks' property for SMSC PHY. Signed-off-by: Laurent Badel Fixes: d65af21842f8 ("net: phy: smsc: LAN8710/20: remove PHY_RST_AFTER_CLK_EN flag") --- drivers/net/phy/smsc.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/phy/smsc.c b/drivers/net/phy/smsc.c index ec97669be5c2..321ed2a89045 100644 --- a/drivers/net/phy/smsc.c +++ b/drivers/net/phy/smsc.c @@ -294,6 +294,9 @@ static int smsc_phy_probe(struct phy_device *phydev) if (ret) return ret; + if (priv->refclk) + phydev->drv->flags &= ~PHY_RST_AFTER_CLK_EN; + return 0; } @@ -397,7 +400,7 @@ static struct phy_driver smsc_phy_driver[] = { .name = "SMSC LAN8710/LAN8720", /* PHY_BASIC_FEATURES */ - + .flags = PHY_RST_AFTER_CLK_EN, .probe = smsc_phy_probe, .remove = smsc_phy_remove, From patchwork Tue Oct 27 23:27:42 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Badel X-Patchwork-Id: 1389080 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=eaton.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=Eaton.onmicrosoft.com header.i=@Eaton.onmicrosoft.com header.a=rsa-sha256 header.s=selector1-Eaton-onmicrosoft-com header.b=d8NNz+b/; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4CLWSK6tyWz9sVX for ; Wed, 28 Oct 2020 12:38:41 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725889AbgJ1BiU (ORCPT ); Tue, 27 Oct 2020 21:38:20 -0400 Received: from mail.eaton.com ([192.104.67.6]:10400 "EHLO simtcimsva03.etn.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1833002AbgJ0X1r (ORCPT ); Tue, 27 Oct 2020 19:27:47 -0400 Received: from simtcimsva03.etn.com (simtcimsva03.etn.com [127.0.0.1]) by IMSVA (Postfix) with ESMTP id DD94BA4106; Tue, 27 Oct 2020 19:27:46 -0400 (EDT) Received: from simtcimsva03.etn.com (simtcimsva03.etn.com [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5E212A40CE; Tue, 27 Oct 2020 19:27:45 -0400 (EDT) Received: from SIMTCSGWY02.napa.ad.etn.com (simtcsgwy02.napa.ad.etn.com [151.110.126.185]) by simtcimsva03.etn.com (Postfix) with ESMTPS; Tue, 27 Oct 2020 19:27:45 -0400 (EDT) Received: from SIMTCSHUB05.napa.ad.etn.com (151.110.40.178) by SIMTCSGWY02.napa.ad.etn.com (151.110.126.185) with Microsoft SMTP Server (TLS) id 14.3.468.0; Tue, 27 Oct 2020 19:27:44 -0400 Received: from USLTCSEXHET01.NAPA.AD.ETN.COM (151.110.240.151) by SIMTCSHUB05.napa.ad.etn.com (151.110.40.178) with Microsoft SMTP Server (TLS) id 14.3.468.0; Tue, 27 Oct 2020 19:27:44 -0400 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.101) by hybridmail.eaton.com (151.110.240.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1591.10; Tue, 27 Oct 2020 19:26:52 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IVbBhls0xx59IJTjk/zvJjRtUxv0Qdlka/wNpyFLQbO/TTA0Nfl704CuMv5GkhAb52j4cKLgbsLoc547DP92pBwB/iys0OwtljD/Srj9s7PT/bXT9E13oIvIMkmYjoWpWJW88K/hdoDeq29/4vihVzuB0EaFj1nXzMHzoUTomF2URB664o3GzaDI5Db8v7F7ozyTZoEsEGgANCZyyTHWiFM2tif7G0JHNArP9KqJ46LGdR+6hLN/z13lsaeGdvd5qyxC3D8Q/TYyjHPv7tMRZ9Dz5EOBehGvngbfD1O5SJgX2A6b613m5slK0biluFDIysoqaIUBHk0uC+DewR8RCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=S4DQSMFVvoR/okb6ikmo155KaSLww2SJUaU8fwOzShs=; b=GaSmz9kGkjuXDaUGlFz9UzrEyQe1/0EDEajlG61bXoKQua8KaOEwmMfKgn/DqFuO4v7l6Zyqv/R0l+lNgcRqUP1Tb8T3fKVN13QSRnb+Tnfhbp8nNb0Orse4HSDKRamkhGzbIwJ24lvb9DGZXY8WQ3tTiNgBRJDeylfUCiDxdp5D2c9RFa47eZG8t+oJPjI/1/zyeu822S8Ro1TvwjUTNBdcXH/ci4mbS0sdLqI0njJzDMM1hWeo7MS0eXkgp2NFJaWIU0KBwW1FVGAiEMRLvpf15xbiw/5sOB0HzorRk13N/Gi5T4GbS3La7F0e7D6SPzpGrnhGLnjnSQwoI9/V4g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=eaton.com; dmarc=pass action=none header.from=eaton.com; dkim=pass header.d=eaton.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Eaton.onmicrosoft.com; s=selector1-Eaton-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=S4DQSMFVvoR/okb6ikmo155KaSLww2SJUaU8fwOzShs=; b=d8NNz+b/eCvrO3sOfDmR4gyuE9oqpyvv/db5KnUChlOEs38Tf/bd69IZBaDPefp0jdJqw3NOHQw6h9oCGU15i/W1Kwkg+A6VJzSL9tbn8Tarws3nqWwc4mkOZ35OEbT0NfxB4Yf+WbybFbdrmYK0g9BshXT/jgb/rMMltVJtK8c= Received: from CY4PR1701MB1878.namprd17.prod.outlook.com (2603:10b6:910:6d::13) by CY4PR17MB1942.namprd17.prod.outlook.com (2603:10b6:903:94::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3477.22; Tue, 27 Oct 2020 23:27:43 +0000 Received: from CY4PR1701MB1878.namprd17.prod.outlook.com ([fe80::a5a5:a48b:7577:6b45]) by CY4PR1701MB1878.namprd17.prod.outlook.com ([fe80::a5a5:a48b:7577:6b45%6]) with mapi id 15.20.3477.028; Tue, 27 Oct 2020 23:27:43 +0000 From: "Badel, Laurent" To: "davem@davemloft.net" , "m.felsch@pengutronix.de" , "fugang.duan@nxp.com" , "kuba@kernel.org" , "andrew@lunn.ch" , Heiner Kallweit , "linux@armlinux.org.uk" , "p.zabel@pengutronix.de" , "lgirdwood@gmail.com" , "broonie@kernel.org" , "robh+dt@kernel.org" , "richard.leitner@skidata.com" , "netdev@vger.kernel.org" , "devicetree@vger.kernel.org" , "f.fainelli@gmail.com" CC: "Quette, Arnaud" Subject: [PATCH net 2/4] net:phy:smsc: expand documentation of clocks property Thread-Topic: [PATCH net 2/4] net:phy:smsc: expand documentation of clocks property Thread-Index: AdasuMLQwu8gTK1hTbi5zinJMHAWoA== Date: Tue, 27 Oct 2020 23:27:42 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: davemloft.net; dkim=none (message not signed) header.d=none;davemloft.net; dmarc=none action=none header.from=eaton.com; x-originating-ip: [89.217.230.232] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 67dd3967-7ccb-4155-f4c2-08d87acfe778 x-ms-traffictypediagnostic: CY4PR17MB1942: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: GAk70o7bBdFmGI51ef+W6VxdYPhHCzqazj88SL4nzb+YBYJahEXxG04h0jv5WVbHQoWxFiCu3L9c+BXiswvA9xOPcUIdoV6b0DiFr5wSkE7fLkkPXhs7BbIN908glDfA4HHMSgSyAVTHcNUzk4LZuxd8nnUd8xuvg062493V5iYxrnII6MA45lC58OrlCgMLTn+e1OSKLgbWnLT4HL9pyuMkKM6L2bY/GpflfkEuNyKUYz7uguIqDFtlPbbkka1R24sHsupLpqc/vdta0zaOqxBK7jWpNMI3LkbdPwqHGYX1LCiYZOk0WsLV3mJpkAFeIdOAgdvUvftsOoXfvkITxaFI5Y6G1p2HkztYbaQ/CjQHz0tTA5xpeg4FrkSeZvBs x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CY4PR1701MB1878.namprd17.prod.outlook.com;PTR:;CAT:NONE;SFS:(376002)(39860400002)(136003)(366004)(396003)(346002)(6506007)(8676002)(8936002)(107886003)(9686003)(2906002)(86362001)(4326008)(64756008)(66946007)(33656002)(478600001)(52536014)(66476007)(76116006)(66556008)(5660300002)(66446008)(71200400001)(316002)(186003)(26005)(110136005)(7696005)(55016002)(83380400001)(7416002)(921003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: a4Fl9SYDe5vNXlIUWBaFgBo34LguwjCVTQH1pERH1FSssQhqkujJvupnWz3N5xPRVfu54FV6bx4Qqr6bjAg9OCW+OK0KMHQhQX6XtFxXYQCbuEovIPuwvTKF6m5Hv2H9MIooRomJRn38LCCEzxbF2lyKy8lIiXhVllHlV/dldRlZO4WSiNMqzX+t+lXdEqBiSkIiWjSooN5ERCtIAAL83GFUQmKtWRklZvXBd0jDPh2h6srAHqQWw1jpbjX4LLCuW79s+ZXWiuuoVz4SiStJgSRYjsk4SsBqdET8NjH6PMEeOrRjVn1ANtVYqCApvDUmQ7zpMso5npdZ0o+ePi87NI51k8C2W4bktz+x1C5BbGXqb1nvnyZbcmYe8ED/Zw1I87B579LlEIwvTAZikLSCUmVgRUC9GEdfGA2MULHEQEA2xoe+6xiolI8ll087OVMnZd1188H076wW3PBPEa4ySaUAw3pPvGHx8n0AdfQ5kn+hgEw8FVeJaRMeOf73kQwV5t3C77LQTu7s1v3uWLmFKuiwOJLQeXlNkcjPi+8OasyN2GupSo2/tal9tkotOsmfEgBJeOBxa60u3iVvf8ToRpSh/IJ0SyFScVlMoMNYAz41LMnJd3/wesErHQa3LzKQSoUhNPaQQBd9ShqEOJpC3Q== MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR1701MB1878.namprd17.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 67dd3967-7ccb-4155-f4c2-08d87acfe778 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Oct 2020 23:27:42.1473 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: d6525c95-b906-431a-b926-e9b51ba43cc4 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: zfxuwSi5kUuzDY7tyXV++Zmrn513o/ZYTeEuVLfCEC0eWMhaZgr+gnY0V12bFrTf5tG8fpmMw0cgiEKtxlw+xQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR17MB1942 X-TM-SNTS-SMTP: CF3281C303C61BD91F07B0E59FA5EC96A0DD9A634DC07BA0A6691FCF37FE3EEC2002:8 X-OriginatorOrg: eaton.com X-EXCLAIMER-MD-CONFIG: 96b59d02-bc1a-4a40-8c96-611cac62bce9 X-TM-AS-GCONF: 00 X-TM-AS-Product-Ver: IMSVA-9.1.0.1988-8.6.0.1013-25752.003 X-TM-AS-Result: No-0.623-10.0-31-10 X-imss-scan-details: No-0.623-10.0-31-10 X-TMASE-Version: IMSVA-9.1.0.1988-8.6.1013-25752.003 X-TMASE-Result: 10-0.622700-10.000000 X-TMASE-MatchedRID: e7Ukgmbx2cyYizZS4XBb35VRzPxemJL0APiR4btCEeYd0WOKRkwshyOq wscTp19+hcO8dxqn/sHKHBviWj0QRueYMko8W4p+SMFvyr5L84KWODD/yzpvdwdkFovAReUoilv Ab18i4hNRPtPOBofUBuIzP61JwVnOTLYGH8Cfo/Z/OBWacv+iVe3+MRAXdfV+QXAiEiGnHpMequ hyYtGyCGoxicOqF8/WsGfwDYJyJijlRxm3A2wKugtuKBGekqUpm+MB6kaZ2g7Ozz5Czo7K5yDKN ajSZD1ZUuHFQfPC1j9MqkIC6RTdc6APzvpM+0eLkAunsgPH2yPKK2F36qCo4YljK7Pk9krBgXtz 1s9/uyYb+NnrrnzwGgZXX8DI70XVFwVtTn8Pj+qqUcpaEPPs/ID1CQ7wlvFu X-TMASE-SNAP-Result: 1.821001.0001-0-1-12:0,22:0,33:0,34:0-0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Subject: [PATCH net 2/4] net:phy:smsc: expand documentation of clocks property Description: The ref clock is managed differently when added to the DT entry for SMSC PHY. Thus, specify this more clearly in the documentation. Signed-off-by: Laurent Badel Acked-by: Rob Herring --- Documentation/devicetree/bindings/net/smsc-lan87xx.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/net/smsc-lan87xx.txt b/Documentation/devicetree/bindings/net/smsc-lan87xx.txt index a8d0dc9a8c0e..43f4763f0d3d 100644 --- a/Documentation/devicetree/bindings/net/smsc-lan87xx.txt +++ b/Documentation/devicetree/bindings/net/smsc-lan87xx.txt @@ -7,7 +7,8 @@ Optional properties: - clocks: The clock used as phy reference clock and is connected to phy - pin XTAL1/CLKIN. + pin XTAL1/CLKIN. If set, the clock will be managed by the PHY + driver and remain enabled for the lifetime of the driver. - smsc,disable-energy-detect: If set, do not enable energy detect mode for the SMSC phy. From patchwork Tue Oct 27 23:28:45 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Badel X-Patchwork-Id: 1389090 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=eaton.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=Eaton.onmicrosoft.com header.i=@Eaton.onmicrosoft.com header.a=rsa-sha256 header.s=selector1-Eaton-onmicrosoft-com header.b=3B2MwBf4; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4CLWgr1wXFz9sVM for ; Wed, 28 Oct 2020 12:48:40 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725910AbgJ1BiV (ORCPT ); Tue, 27 Oct 2020 21:38:21 -0400 Received: from mail.eaton.com ([192.104.67.6]:10600 "EHLO loutcimsva01.etn.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1833008AbgJ0X2t (ORCPT ); Tue, 27 Oct 2020 19:28:49 -0400 Received: from loutcimsva01.etn.com (loutcimsva01.etn.com [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C75E29608E; Tue, 27 Oct 2020 19:28:47 -0400 (EDT) Received: from loutcimsva01.etn.com (loutcimsva01.etn.com [127.0.0.1]) by IMSVA (Postfix) with ESMTP id AF54B96084; Tue, 27 Oct 2020 19:28:47 -0400 (EDT) Received: from SIMTCSGWY02.napa.ad.etn.com (simtcsgwy02.napa.ad.etn.com [151.110.126.185]) by loutcimsva01.etn.com (Postfix) with ESMTPS; Tue, 27 Oct 2020 19:28:47 -0400 (EDT) Received: from SIMTCSHUB01.napa.ad.etn.com (151.110.40.174) by SIMTCSGWY02.napa.ad.etn.com (151.110.126.185) with Microsoft SMTP Server (TLS) id 14.3.468.0; Tue, 27 Oct 2020 19:28:47 -0400 Received: from USSTCSEXHET02.NAPA.AD.ETN.COM (151.110.240.154) by SIMTCSHUB01.napa.ad.etn.com (151.110.40.174) with Microsoft SMTP Server (TLS) id 14.3.468.0; Tue, 27 Oct 2020 19:28:47 -0400 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.103) by hybridmail.eaton.com (151.110.240.154) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1591.10; Tue, 27 Oct 2020 19:28:17 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Bor1IhHiNL50i+elNe5G5+VhI3JwwT7ZTEhnCnQyxZ57OdFHa8w7qnFw7zUka1zZgjuJ21AIFIR3bT8M095jkEUKqhwYWSKyBVZwD/BgtUKhxtgM/Ru+IaF8G0qaekubB25SAxCdon8aHHFzZk+Xi0ALv8HiybX0/vWJrf4I2RaLaefPPuQy3mqEgefmSq02R9xbJuj21mpOecJ9qsQJzliyaBV8QE5JEEGV+7681pwV+ahN7OOsVI3V/WPjdJ9Q/HaKMbU7hSAq8Yvlh+in7xDjJtxCLt6ZUfxUeHtK6gAyGiNejpt1S1Uc4YQ3Yi+uS2vhcvbPAbamfro2iMy7zg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2xF17dwkllGT/Mtu6hQ4o/wuju3UzJy4IBAmrdxPPt4=; b=g58WMkoOE2Uh3ZTCkTdwPrM4eLd8phmUoPrnOWBzrAstaXaDp8XQmVIVomHNO8lqH3I9GVd0hVcNTKUlo1Ykx7GlMFq68a5+A8U5M1FmnqQPprzDubd9Z3wr/CuKXEeX7BBYzU2gp8ezQjlj1qpMRaT0YZtfhJTOra5+21baN5CEnZVZIiZZUZzvnxkyPvwJ89ib8llGMoa88kprlaj0sCH02sAvmZUHZwxwnFB4Wy1xlPcMzZpUMquaeyhZlox29ATuiZD05b/vLzeQdiHJrDaUJhIFxCGJn0PH/szWlo3b+qXU9p4/pUf0lNDjOTL83ZVVNCn0HZbh/YuYHwwLTA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=eaton.com; dmarc=pass action=none header.from=eaton.com; dkim=pass header.d=eaton.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Eaton.onmicrosoft.com; s=selector1-Eaton-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2xF17dwkllGT/Mtu6hQ4o/wuju3UzJy4IBAmrdxPPt4=; b=3B2MwBf4wI3qYaZJyG/fyxX7+Es8Hnv6+bB4ONtw//PnzTMZexa7wa7lKdxQJ5S4sYl/DpAn3yQFGNWBce2CZ6kPwWlOdqNmHkT0bxokcGN4r9AuTLJuTZ6uQA0Z0Zkxioa5JdXuJsbE48N7+rnnNQwfp75A+gQRVSDyLImklkU= Received: from CY4PR1701MB1878.namprd17.prod.outlook.com (2603:10b6:910:6d::13) by CY4PR17MB1942.namprd17.prod.outlook.com (2603:10b6:903:94::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3477.22; Tue, 27 Oct 2020 23:28:45 +0000 Received: from CY4PR1701MB1878.namprd17.prod.outlook.com ([fe80::a5a5:a48b:7577:6b45]) by CY4PR1701MB1878.namprd17.prod.outlook.com ([fe80::a5a5:a48b:7577:6b45%6]) with mapi id 15.20.3477.028; Tue, 27 Oct 2020 23:28:45 +0000 From: "Badel, Laurent" To: "davem@davemloft.net" , "m.felsch@pengutronix.de" , "fugang.duan@nxp.com" , "kuba@kernel.org" , "andrew@lunn.ch" , Heiner Kallweit , "linux@armlinux.org.uk" , "p.zabel@pengutronix.de" , "lgirdwood@gmail.com" , "broonie@kernel.org" , "robh+dt@kernel.org" , "richard.leitner@skidata.com" , "netdev@vger.kernel.org" , "devicetree@vger.kernel.org" , "f.fainelli@gmail.com" CC: "Quette, Arnaud" Subject: [PATCH net 3/4] net:phy: add phy_device_reset_status() support Thread-Topic: [PATCH net 3/4] net:phy: add phy_device_reset_status() support Thread-Index: AdasuOiSt1LtmTDZRYe4uOkfybAg5g== Date: Tue, 27 Oct 2020 23:28:45 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: davemloft.net; dkim=none (message not signed) header.d=none;davemloft.net; dmarc=none action=none header.from=eaton.com; x-originating-ip: [89.217.230.232] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3043eff9-c6de-4008-3eb8-08d87ad00cbb x-ms-traffictypediagnostic: CY4PR17MB1942: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2733; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: vWX5ryOb3l0zqtvBNm1c/9mMstyXUZ3A56+xkuKur/jSZL81tXTjeVkZ8DbHu9V8FouCDHUjCuZPHWRelNdAAfX5JD5xOA1n1nLDYNALoFN2Efts+T0xCas1ZFsMuu7HS1Qkc7pbALP14wTNfHsFJP29XNgl9qYxtqXxOwu8PQkQ+Y2/GjIzd2/uLKGaTuw2pyaoE+Wui9ddZoFnloYdiwOkHJkMwv6bIFcDOcS3+4WBcqav8Bqw/a5H1HjFxHHSj2visKTA41shJwbmmz8cZHFHT+OqnTSmeAWnkpbTDdXFz4v5f6/WT9Yqj+Nd9Uir6FNPZOYVx1OiDbAPRL5iQNyq9guikWwAzT7hilNnKwUYRkiojJMPvsAUXBLxcXvT x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CY4PR1701MB1878.namprd17.prod.outlook.com;PTR:;CAT:NONE;SFS:(376002)(39860400002)(136003)(366004)(396003)(346002)(6506007)(8676002)(8936002)(107886003)(9686003)(2906002)(86362001)(4326008)(64756008)(66946007)(33656002)(478600001)(52536014)(66476007)(76116006)(66556008)(5660300002)(66446008)(71200400001)(316002)(186003)(26005)(110136005)(7696005)(55016002)(7416002)(921003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: niuFLwkeDnFt+8T6PXrO6YlfjVV8VzUAXS2wDT3YtRIM90dqavzTgh08CrEhGTVghIehN37V7zD+nSApsDCZGBa967XcNvUz63ERMzVSZGlwjnjxirHjVv2W/JehB7vhGJyZLmRtGBA2GstRBYH9NiNPISZnbDfPrhVqgplmasfmHfsCRkqE6nRyvQ77Yu+kL0GC10bqOKYjYdQzgQGBSnMO6/+MkmKPTG9JzkvWwCT+dQivbWtvh2SxCbcKMLTxR8N/nj8SfaECB1q4FD2Q85jB27jw9Ddtlb5EJiBHt08WVA9ppZCfXFriOtAdC0Z+MYo99HddeuUY8SNtvza2IUxaamxlGqv00+FCY/LOzEMMqeNOgR2PQ8Nc1TeRTwCvJSjVeK1OBbihkaOtC2MAgq4WFtdchPgse5KB3Hjdkb98NJrqqbqXTQ8i5UiNYA6ZGht300LV+U8wPzWbwgQL6QnTpxHZnXOOZpwsT1ZRi+Gs44r4UQEiQHbUHQziMNP4IZ53ZagVV6Mt/DMbHlu5G800Pf/5z4jpUnj7e8wdiR4pmi29F2RFQf3yFbYHJh1TBhjkGl5Y7A1gsm9abzOsJDdeMhrroT+1lrHVPNzRxTsQ9TGyZ4V+1du3R+HgD6GsOczguNJ5qGYnpn9w6RJkNg== MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR1701MB1878.namprd17.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3043eff9-c6de-4008-3eb8-08d87ad00cbb X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Oct 2020 23:28:45.6690 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: d6525c95-b906-431a-b926-e9b51ba43cc4 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 1NAvu84SxBuXepveAzBXO/23Exh1V3IjYjq+/mqbPrjG6Y0zgF7EYqaf/URjbwcYa0WKk1KEsZ0tYRG4IM9apA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR17MB1942 X-TM-SNTS-SMTP: 01680F9E10CBCEEDA1E8B9F07AE6C20FE2694DF2975BCF9EDA2C7A1164F06DD02002:8 X-OriginatorOrg: eaton.com X-EXCLAIMER-MD-CONFIG: 96b59d02-bc1a-4a40-8c96-611cac62bce9 X-TM-AS-GCONF: 00 X-TM-AS-Product-Ver: IMSVA-9.1.0.1988-8.6.0.1013-25752.003 X-TM-AS-Result: No--0.002-10.0-31-10 X-imss-scan-details: No--0.002-10.0-31-10 X-TMASE-Version: IMSVA-9.1.0.1988-8.6.1013-25752.003 X-TMASE-Result: 10--0.002000-10.000000 X-TMASE-MatchedRID: FPI5UUlJimYLKp8CjzhvwI4uBIdoKfjuGbJMFqqIm9z5+tteD5RzhWdC uMvHMJPkRS3ViuUTjLV8q/y2sEd/cxqiBXdxPfouUfqR39ZbIlV6i696PjRPiGOMyb1Ixq8Vcij MZrr2iZ2t2gtuWr1Lmnq/3tVeyVFpcsoJIwqzxXeVyEX4i+SWUzFcf92WG8u/HWtVZN0asTjSJJ cbp1Y+W5kHZe8cKrzGlPyKFBMd+6EA7bU4vrpHXJ4CIKY/Hg3A3QfwsVk0UbsIoUKaF27lxUKz0 sNazEatRhpU7Wv03uoDNFBOFpTnHAW6ZO6oUvn8cmK/NoJiuXqaXDYKW5+Xos4oWmjb3qqd36F+ vn+817by0hjwIReQdC6/7KD1s/Je3FO0vr0KV10Sx+ezCQyTIh3gfQXsasLHnqg/VrSZEiM= X-TMASE-SNAP-Result: 1.821001.0001-0-1-12:0,22:0,33:0,34:0-0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Subject: [PATCH net 3/4] net:phy: add phy_device_reset_status() support Description: add support to query the status of the reset line of an MDIO device. Signed-off-by: Laurent Badel --- drivers/net/phy/mdio_device.c | 18 ++++++++++++++++++ include/linux/mdio.h | 1 + include/linux/phy.h | 5 +++++ 3 files changed, 24 insertions(+) diff --git a/drivers/net/phy/mdio_device.c b/drivers/net/phy/mdio_device.c index 0837319a52d7..4909feb57027 100644 --- a/drivers/net/phy/mdio_device.c +++ b/drivers/net/phy/mdio_device.c @@ -136,6 +136,24 @@ void mdio_device_reset(struct mdio_device *mdiodev, int value) } EXPORT_SYMBOL(mdio_device_reset); +/** + * mdio_device_reset_status - returns the reset status of an MDIO device + * + * Returns >0 if the reset line is asserted, 0 if it is not asserted + and <0 on error. + */ +int mdio_device_reset_status(struct mdio_device *mdiodev) +{ + if (mdiodev->reset_gpio) + return gpiod_get_value_cansleep(mdiodev->reset_gpio); + + if (mdiodev->reset_ctrl) + return reset_control_status(mdiodev->reset_ctrl); + + return -EOPNOTSUPP; +} +EXPORT_SYMBOL(mdio_device_reset_status); + /** * mdio_probe - probe an MDIO device * @dev: device to probe diff --git a/include/linux/mdio.h b/include/linux/mdio.h index dbd69b3d170b..179c5bdd90e8 100644 --- a/include/linux/mdio.h +++ b/include/linux/mdio.h @@ -92,6 +92,7 @@ struct mdio_device *mdio_device_create(struct mii_bus *bus, int addr); int mdio_device_register(struct mdio_device *mdiodev); void mdio_device_remove(struct mdio_device *mdiodev); void mdio_device_reset(struct mdio_device *mdiodev, int value); +int mdio_device_reset_status(struct mdio_device *mdiodev); int mdio_driver_register(struct mdio_driver *drv); void mdio_driver_unregister(struct mdio_driver *drv); int mdio_device_bus_match(struct device *dev, struct device_driver *drv); diff --git a/include/linux/phy.h b/include/linux/phy.h index eb3cb1a98b45..e12b90db9852 100644 --- a/include/linux/phy.h +++ b/include/linux/phy.h @@ -1461,6 +1461,11 @@ static inline void phy_device_reset(struct phy_device *phydev, int value) mdio_device_reset(&phydev->mdio, value); } +static inline int phy_device_reset_status(struct phy_device *phydev) +{ + return mdio_device_reset_status(&phydev->mdio); +} + #define phydev_err(_phydev, format, args...) \ dev_err(&_phydev->mdio.dev, format, ##args) From patchwork Tue Oct 27 23:29:42 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Badel X-Patchwork-Id: 1389089 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=eaton.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=Eaton.onmicrosoft.com header.i=@Eaton.onmicrosoft.com header.a=rsa-sha256 header.s=selector1-Eaton-onmicrosoft-com header.b=VxCwxAoL; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4CLWgf5g0qz9sVS for ; Wed, 28 Oct 2020 12:48:30 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725940AbgJ1BiW (ORCPT ); Tue, 27 Oct 2020 21:38:22 -0400 Received: from mail.eaton.com ([192.104.67.6]:10601 "EHLO simtcimsva03.etn.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1833010AbgJ0X3p (ORCPT ); Tue, 27 Oct 2020 19:29:45 -0400 Received: from simtcimsva03.etn.com (simtcimsva03.etn.com [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E497EA4128; Tue, 27 Oct 2020 19:29:44 -0400 (EDT) Received: from simtcimsva03.etn.com (simtcimsva03.etn.com [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D6997A4126; Tue, 27 Oct 2020 19:29:44 -0400 (EDT) Received: from LOUTCSGWY04.napa.ad.etn.com (loutcsgwy04.napa.ad.etn.com [151.110.126.21]) by simtcimsva03.etn.com (Postfix) with ESMTPS; Tue, 27 Oct 2020 19:29:44 -0400 (EDT) Received: from USSTCSHYB02.napa.ad.etn.com (151.110.40.172) by LOUTCSGWY04.napa.ad.etn.com (151.110.126.21) with Microsoft SMTP Server (TLS) id 14.3.468.0; Tue, 27 Oct 2020 19:29:44 -0400 Received: from USSTCSEXHET02.NAPA.AD.ETN.COM (151.110.240.154) by USSTCSHYB02.napa.ad.etn.com (151.110.40.172) with Microsoft SMTP Server (TLS) id 14.3.468.0; Tue, 27 Oct 2020 19:29:44 -0400 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.46) by hybridmail.eaton.com (151.110.240.154) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1591.10; Tue, 27 Oct 2020 19:29:15 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CYfqraKMFv8OEl0FrO55zq4KyEb+mLE9T0uKdXVklc3TZV9fnG6m0nqZEajGAZVKK64bfMRzHcuuCd1ljBY556Egd7yPfGGSUpprn+KZ/HGZljuE4p4OxzQZvlI6YOAa0HNJGAd5UwGyurTFKm/aQUITB+XLDqDW/pckengYqTXRoH5BFTaW+cuhVF0sml0cpGTwenpsqIKfHxQar1Q+yY7E6kNRMJZP/6pYr+4jaLPNjk9Q0V3Zbk2+7bHy8pOHim0UqVunuiydkLU8Q2l4L+MirnNAa0Fes7lwoY0/jxDTEJ0JK97nzaBNhm6t1GTmv56mFW+PvIUt2KSnI/L2Jg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=R3O2CLcE3xK6RFlgP2CUKze4E2Xi6wiVspst8zrUrms=; b=cux/uvzPfDlOCXLDTzZYnt3/nFSFaT3LnqAZix9xDCD4ULsVwX3ILgUBJJoyYfAo9SJAvtBH6nVoTvsWhtbtsFkOW1Gm2gnhmMpmgn+SYi9gALLnakUYFhmdb2FyX2mKjl4+FbnQgXGNSA3yLq9ZLlkKfOTbioZizsXnJ3UZU3LnAsXlPZHwCvZ90gwtr1uj6YuFMAL/h5pPhuDEW9MVC2dfGOA617AKKtO/SniLebV5f8HPMX8HcZbir5hk/IVvup8CezZstDapcUDE7IGrmyP32+l7+I1ZC4MYDszRS9yJu+hWJ/d+Kt2F9uV7KN5ID7kCedxjl5s1pL87q9Oa+w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=eaton.com; dmarc=pass action=none header.from=eaton.com; dkim=pass header.d=eaton.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Eaton.onmicrosoft.com; s=selector1-Eaton-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=R3O2CLcE3xK6RFlgP2CUKze4E2Xi6wiVspst8zrUrms=; b=VxCwxAoLBhArqN1LKqONPdTPBksxqBLvWISZ28v4Q/xcDHBu7pazx7LP5IXadttMwHdGvL9l7WPLLKWnAf6e2bWmZTEI7qRtmNOZYhevY7dWxA+4p95diEHjLRkCgPywj8zqFCQDT9JS3X/CdjO3mk63j+XCa6Vtf25CUmpVa0o= Received: from CY4PR1701MB1878.namprd17.prod.outlook.com (2603:10b6:910:6d::13) by CY4PR17MB1942.namprd17.prod.outlook.com (2603:10b6:903:94::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3477.22; Tue, 27 Oct 2020 23:29:42 +0000 Received: from CY4PR1701MB1878.namprd17.prod.outlook.com ([fe80::a5a5:a48b:7577:6b45]) by CY4PR1701MB1878.namprd17.prod.outlook.com ([fe80::a5a5:a48b:7577:6b45%6]) with mapi id 15.20.3477.028; Tue, 27 Oct 2020 23:29:42 +0000 From: "Badel, Laurent" To: "davem@davemloft.net" , "m.felsch@pengutronix.de" , "fugang.duan@nxp.com" , "kuba@kernel.org" , "andrew@lunn.ch" , Heiner Kallweit , "linux@armlinux.org.uk" , "p.zabel@pengutronix.de" , "lgirdwood@gmail.com" , "broonie@kernel.org" , "robh+dt@kernel.org" , "richard.leitner@skidata.com" , "netdev@vger.kernel.org" , "devicetree@vger.kernel.org" , "f.fainelli@gmail.com" CC: "Quette, Arnaud" Subject: [PATCH 4/4] net:phy: fix phy_reset_after_clk_enable() Thread-Topic: [PATCH 4/4] net:phy: fix phy_reset_after_clk_enable() Thread-Index: AdasuQkOukfiBTpdRwSD+B+Lawlh0Q== Date: Tue, 27 Oct 2020 23:29:42 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: davemloft.net; dkim=none (message not signed) header.d=none;davemloft.net; dmarc=none action=none header.from=eaton.com; x-originating-ip: [89.217.230.232] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 080c9694-12fb-4159-26fc-08d87ad02eba x-ms-traffictypediagnostic: CY4PR17MB1942: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: e7nFdnVw0d2RuTfcjDeXr85b5mh5KSJ4VpP/gh8CbHWyKKp1yY0g46EW3QTuBPIRmYX419aMZ2qYFib/xL+3yI3wGNm8SX4cHKGJ2ckqaYU7lwSFNrj1Jzpwp6dkJ/0XfUxgHBGj7vN3sxyGI/CCGZ6s9Vp1gi2KHi/UCBmFOXYYkyuk8fd3ktJK6SqIRdGlX8ZcZZoULyBcRdrewcXuAmYKXa/dAQTLylCO+p/k3TF78K7jDjTYZLTsPCv/bLOTl3gQlQoJGbXod8gRgQaNsCbW9PsQYLh14fQBIpop0tCGW/4dyXLZ5BVwhg6IZeYsiMdT23E0n6FLecg3vAJfWW8lTLieCfma/d7TV3LyDYdwqVAW+aiIxXM3Eo+JeMZ6 x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CY4PR1701MB1878.namprd17.prod.outlook.com;PTR:;CAT:NONE;SFS:(376002)(39860400002)(136003)(366004)(396003)(346002)(6506007)(8676002)(8936002)(107886003)(9686003)(2906002)(86362001)(4326008)(64756008)(66946007)(33656002)(478600001)(52536014)(66476007)(76116006)(66556008)(5660300002)(66446008)(71200400001)(316002)(186003)(26005)(110136005)(7696005)(55016002)(83380400001)(7416002)(921003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: TdztZJtOTNgd5tHiQ4JFAqY3YsBr1uoL+W+36C0FL16qNHdXPBTRX+v84oFir8ip/NDNvvc6GlBYeeG+LoZA7oEfSP8HiDsMv5VQOkND2inbv3G67qUnBixREAme11Z2ZnWc60raE/mCOleNpVmb7EPhE9Rewy66DFICJYtVqnCP1T5Hz8g8R4zUWxvConNS7DfdaY3KhI5F+YLFiU5JTCTB30CfUmGFMtfyBhmqEToaal8cGYYPd//9iy1dAiG/OjPSngBQz/lfc+XLmOYWtKMVvIgSuwBHyZdvYYKRAq97TJvcLIxMYGAV2c0YIq46rvPBmnJ1gBD3SanbrUDauWK/vUDSwPsPDHqFA6XnsXcCyCX7OWZmUzdvdTEkxLhhIeNFZfps0K8tUkUaIu+NsQMJjO809yhLDhUXh7K1k7TcS7ltDx45AIA4D8C2x7bNUxD01skzed3U/AfEjWWIhwV5KnC6mu6h0EHOikQfsMRHxjawYcAxcZPKD5bqNCn4Eepd0uo5VyjwdAfw1xfWh4d2RIzorTUVwclLQDpL0aauEFbdoQ6yhHjuOfne8QdyvSWTWOM9NTs1qp8+f1yNG2ZOR2msmo08ocYBxRad/YAcWSYYPUObrUXpxGZzp1TweE4zzewbyQBzCbyCmIkhFQ== MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR1701MB1878.namprd17.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 080c9694-12fb-4159-26fc-08d87ad02eba X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Oct 2020 23:29:42.7903 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: d6525c95-b906-431a-b926-e9b51ba43cc4 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: RXeuFQDozkSb+/O+Pz6h6l6SfL48nLFY2kS3tBNX/bG/do70UDJ9el00RhvfsaD+m/3PMP6RWpWeXp4D/uXpmw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR17MB1942 X-TM-SNTS-SMTP: 289FF318D6D2C0E72DDC84C4BF19B98D7AB02B8D2BD3F335519A2FEAD889CDBA2002:8 X-OriginatorOrg: eaton.com X-EXCLAIMER-MD-CONFIG: 96b59d02-bc1a-4a40-8c96-611cac62bce9 X-TM-AS-GCONF: 00 X-TM-AS-Product-Ver: IMSVA-9.1.0.1988-8.6.0.1013-25752.003 X-TM-AS-Result: No--1.462-10.0-31-10 X-imss-scan-details: No--1.462-10.0-31-10 X-TMASE-Version: IMSVA-9.1.0.1988-8.6.1013-25752.003 X-TMASE-Result: 10--1.461600-10.000000 X-TMASE-MatchedRID: VIUqeHku7VWYizZS4XBb35VRzPxemJL0APiR4btCEeYd0WOKRkwsh4JV W4oTDi/+9Xs2dZbNGMQvaz8LO7iprs66BgIQlQw1KrDHzH6zmUVDfut2Lc1Yh46/j5xrRs7TbBU Wr0rJkZaAm9VaUn5RP3iCTLyLchkE9rqf24A6kyuKYdYQLbymTUtc8DbogbSE31GU/N5W5BAwL8 r97br5Dfm0VF/d5QzVPUUtABYMZ11AjTccdWiAVc36paW7ZnFoVaIFkbBGkf56pt1oU+C/pPsYG dcqzBoA5TZfzvOelefkwjHXXC/4I8ZW5ai5WKly6aDim3tCWcLL/GO+jGolvn47BUdXTX5TP0ny Gx5fRCrA0HChDTm8BPIlq2CU017g75M+3u/5d1OqKgBXRKikvBZhzFlLECqlp5DFxO/tuzWUSSJ PERKCCG1G0sdA2yd47FHW4PQA8ke6rLuaBPjT2g== X-TMASE-SNAP-Result: 1.821001.0001-0-1-12:0,22:0,33:0,34:0-0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Subject: [PATCH 4/4] net:phy: fix phy_reset_after_clk_enable() Description: Resetting PHY chip during operation has the effect of reverting all configuration registers to default. Therefore, fully re-configure the PHY after a reset. Also, avoid resetting the PHY if the reset is already asserted, as this would deassert the reset which might be unexpected for the entity that previously asserted it. Signed-off-by: Laurent Badel --- drivers/net/phy/phy_device.c | 22 ++++++++++++++++++---- 1 file changed, 18 insertions(+), 4 deletions(-) -- 2.17.1 ----------------------------- Eaton Industries Manufacturing GmbH ~ Registered place of business: Route de la Longeraie 7, 1110, Morges, Switzerland ----------------------------- diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c index 5dab6be6fc38..85678b1600c0 100644 --- a/drivers/net/phy/phy_device.c +++ b/drivers/net/phy/phy_device.c @@ -1801,7 +1801,7 @@ int phy_loopback(struct phy_device *phydev, bool enable) EXPORT_SYMBOL(phy_loopback); /** - * phy_reset_after_clk_enable - perform a PHY reset if needed + * phy_reset_after_clk_enable - perform a PHY reset if needed and reconfigure * @phydev: target phy_device struct * * Description: Some PHYs are known to need a reset after their refclk was @@ -1811,15 +1811,29 @@ EXPORT_SYMBOL(phy_loopback); */ int phy_reset_after_clk_enable(struct phy_device *phydev) { + int ret; + if (!phydev || !phydev->drv) return -ENODEV; - if (phydev->drv->flags & PHY_RST_AFTER_CLK_EN) { + if ((phydev->drv->flags & PHY_RST_AFTER_CLK_EN) && + !phy_device_reset_status(phydev)) { + phy_device_reset(phydev, 1); - phy_device_reset(phydev, 0); + /* phy_init_hw will bring the phy out of reset + * and run its config_init method. + */ + ret = phy_init_hw(phydev); + if (ret < 0) + return ret; + + /* re-configure interrupts if needed */ + if (phydev->interrupts == PHY_INTERRUPT_ENABLED) { + phy_free_interrupt(phydev); + phy_request_interrupt(phydev); + } return 1; } - return 0; } EXPORT_SYMBOL(phy_reset_after_clk_enable);