From patchwork Tue Oct 27 09:22:20 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierre-Marie de Rodat X-Patchwork-Id: 1388357 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=sourceware.org; envelope-from=gcc-patches-bounces@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=adacore.com Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4CL5p02SV7z9sSs for ; Tue, 27 Oct 2020 20:22:27 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 30EE13897026; Tue, 27 Oct 2020 09:22:23 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from rock.gnat.com (rock.gnat.com [205.232.38.15]) by sourceware.org (Postfix) with ESMTP id ACC2E3858D37 for ; Tue, 27 Oct 2020 09:22:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org ACC2E3858D37 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=derodat@adacore.com Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 81C5B11712B; Tue, 27 Oct 2020 05:22:20 -0400 (EDT) X-Virus-Scanned: Debian amavisd-new at gnat.com Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id ihmfEtQDRbLr; Tue, 27 Oct 2020 05:22:20 -0400 (EDT) Received: from tron.gnat.com (tron.gnat.com [205.232.38.10]) by rock.gnat.com (Postfix) with ESMTP id 6C6541170F9; Tue, 27 Oct 2020 05:22:20 -0400 (EDT) Received: by tron.gnat.com (Postfix, from userid 4862) id 6B842125; Tue, 27 Oct 2020 05:22:20 -0400 (EDT) Date: Tue, 27 Oct 2020 05:22:20 -0400 From: Pierre-Marie de Rodat To: gcc-patches@gcc.gnu.org Subject: [Ada] Warnings on g-spogwa.adb Message-ID: <20201027092220.GA33731@adacore.com> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Status: No, score=-10.5 required=5.0 tests=BAYES_00, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Arnaud Charlet Errors-To: gcc-patches-bounces@gcc.gnu.org Sender: "Gcc-patches" This unit added recently generate legitimate warnings which were not caught because this file had not been added to Makefile.rtl. Tested on x86_64-pc-linux-gnu, committed on trunk gcc/ada/ * Makefile.rtl (GNATRTL_NONTASKING_OBJS): Add g-spogwa object. * libgnat/g-spogwa.adb: Fix style errors. diff --git a/gcc/ada/Makefile.rtl b/gcc/ada/Makefile.rtl --- a/gcc/ada/Makefile.rtl +++ b/gcc/ada/Makefile.rtl @@ -483,6 +483,7 @@ GNATRTL_NONTASKING_OBJS= \ g-speche$(objext) \ g-spipat$(objext) \ g-spitbo$(objext) \ + g-spogwa$(objext) \ g-sptabo$(objext) \ g-sptain$(objext) \ g-sptavs$(objext) \ diff --git a/gcc/ada/libgnat/g-spogwa.adb b/gcc/ada/libgnat/g-spogwa.adb --- a/gcc/ada/libgnat/g-spogwa.adb +++ b/gcc/ada/libgnat/g-spogwa.adb @@ -36,8 +36,6 @@ procedure GNAT.Sockets.Poll.G_Wait is use Interfaces; - use type C.int; - function C_Select (Nfds : C.int; readfds : access FD_Set_Type; @@ -65,8 +63,8 @@ begin if Timeout >= 0 then Timeout_A := Timeout_V'Access; - Timeout_V.tv_sec := Thin_Common.time_t (Timeout / 1000); - Timeout_V.tv_usec := Thin_Common.suseconds_t (Timeout rem 1000 * 1000); + Timeout_V.Tv_Sec := Thin_Common.time_t (Timeout / 1000); + Timeout_V.Tv_Usec := Thin_Common.suseconds_t (Timeout rem 1000 * 1000); end if; Reset_Socket_Set (Rfds);