From patchwork Tue Oct 13 12:36:32 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Hartikainen, Sami" X-Patchwork-Id: 1381557 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=googlegroups.com (client-ip=2a00:1450:4864:20::23c; helo=mail-lj1-x23c.google.com; envelope-from=swupdate+bncbaabb3f6s36akgqe3yrppri@googlegroups.com; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=teleste.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=googlegroups.com header.i=@googlegroups.com header.a=rsa-sha256 header.s=20161025 header.b=GCktO4+x; dkim-atps=neutral Received: from mail-lj1-x23c.google.com (mail-lj1-x23c.google.com [IPv6:2a00:1450:4864:20::23c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4C9Zn057NDz9sRR for ; Tue, 13 Oct 2020 23:37:05 +1100 (AEDT) Received: by mail-lj1-x23c.google.com with SMTP id f4sf6434481ljn.2 for ; Tue, 13 Oct 2020 05:37:04 -0700 (PDT) ARC-Seal: i=3; a=rsa-sha256; t=1602592620; cv=pass; d=google.com; s=arc-20160816; b=PIlgoq7T2NQq9StiCkhwbSGww7iIMVqLDOPpFq7CAfWQQ9OWE5VF93BidToaTsRcdB OlNML4dD6icZAWX3UBoLRHxo1cOnbO0mrdOtNRQF/oEzrYpk4yMK3BS8g3kWgWhHxtIi vEiFQeQRwxguyi221Rn23kyKlnXHjJzpzDhHO0TzMqXCxoO4ZbZkXGr+rq/ngDztUM8T owPIjQ8UkTk7fhzebBS568imyXiQX7Ei4x7KkSNJ+fvyjivK0uOXkc5ZeOq5lx+NXe6f jl2gDz+KoSnyTV4+H1i5uT4W8f/nleHz0UqkzMOEJ474LTIDo8otzjjobf/CL0eA/jxP iEDw== ARC-Message-Signature: i=3; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:mime-version:message-id:date :subject:cc:to:from:sender:dkim-signature; bh=SQUzJFu9PlUyXn43U8SGlkIdrprErNgvvNnf1ZC449k=; b=t1jHNWXWMX91SHpXHcxlkHNS2XVr3udDYugiCfPe0Xb82Qm47o/NqtLEukM3omP70V BG+6f6XL7LaUqtiRgBLZJ08IloVOcE+lO4qizKYILaJ7zenHP6mS4zkYco5+PfNyM0RO gQhoanEbETT+BeKEdpZKK2pxxqkNWP1srEKowU4j+a/XUnWxwYrTb+3d4UiPvcIUFKaa aNK8ztLkNh6QCKnvrBkFHO1H4tDeanexVT2MbHW9/wb8JHhnk4lv3NW8s7L/E0aEhYWc pjrixUSn3dJf5AU0IgrckQZrATVsxFvI0jv2Ljmc25CtZtc2hXlBQTNeK5cqD/fdRMRM T2hw== ARC-Authentication-Results: i=3; gmr-mx.google.com; dkim=pass header.i=@Teleste.com header.s=selector1 header.b=UwDvB112; arc=pass (i=1 spf=pass spfdomain=teleste.com dmarc=pass fromdomain=teleste.com); spf=pass (google.com: domain of sami.hartikainen@teleste.com designates 40.107.1.63 as permitted sender) smtp.mailfrom=Sami.Hartikainen@teleste.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=teleste.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:mime-version :x-original-sender:x-original-authentication-results:precedence :mailing-list:list-id:list-post:list-help:list-archive :list-subscribe:list-unsubscribe; bh=SQUzJFu9PlUyXn43U8SGlkIdrprErNgvvNnf1ZC449k=; b=GCktO4+xUoJZliLz9vh/881VSokAgTOExBeaoQNVeCW58MBmBK6tmvDpyLmRBBXMjd CaINFxJBbULwngWsT21xQa3a+N2kkpdVUWtJ93mHu3LEGWDbh/n6FXQyRP9/lUmI2TFT NvJVcyamEleH1qK33oHMtt1k1svULL0WII53RIxa3SF0YqsOeIn6S0lE8PODc2txlNmP lksPTghdcSUsxRetUBLau66kWdIITNLdMbPAG1+2SU8Tthbn/iLEn5c4AnDy/V4fY3hk 6Y8pANSG5KFp+4+vbLlERqRBCKjnXYyH6gUe5Mbz+iO0f0qj8Lj+z5+8PrqYMbCWlcdu TxCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=sender:x-gm-message-state:from:to:cc:subject:date:message-id :mime-version:x-original-sender:x-original-authentication-results :precedence:mailing-list:list-id:x-spam-checked-in-group:list-post :list-help:list-archive:list-subscribe:list-unsubscribe; bh=SQUzJFu9PlUyXn43U8SGlkIdrprErNgvvNnf1ZC449k=; b=ccqeqx8fnG/D0yIegfEEgP7xZECE1qmv2i1G/JZp6rEy18lIjetKWp3cER/yRoioqy uOazjj5t6kmMSnlNZxELEnQm/rv8aNE31DgYhlOnRWTbPFLhby/3nIkfXKFr/BBD7hyW 3BeQIF75BNDx+mtGkfP/5I+BG7e7exah0rwak2s48rLHTOGdwrUaRV//mkV7BB+fwVj/ Hbg2MiG3xpXjvykZtc7kdK4BYbkQItNybaSMdrEVuvI6yLFlJYC7Rn/pNvtn8TxT6+J6 Nv0456EIx7qHR9oDrS5GSZHWsd1BUBdiyacJDenzv7Oucq52AI3qnHA60fgWfiurfXZK 4rTg== Sender: swupdate@googlegroups.com X-Gm-Message-State: AOAM532TNAaV91LYSXPbTFfIzZ8gxMcMndon70HJCBfwt9Plk3OcFzwp 0UZhp9G9Tu8F+WhbzdQnd6c= X-Google-Smtp-Source: ABdhPJxdFgO3EoxcdUv3mE+2cJ4W39ntxK00hhcW5Onhc/pIVxjdPXFUiebZXpkqv1QeaCal1fZSgg== X-Received: by 2002:ac2:48bb:: with SMTP id u27mr563003lfg.578.1602592620750; Tue, 13 Oct 2020 05:37:00 -0700 (PDT) X-BeenThere: swupdate@googlegroups.com Received: by 2002:a19:c7c8:: with SMTP id x191ls1082892lff.0.gmail; Tue, 13 Oct 2020 05:36:59 -0700 (PDT) X-Received: by 2002:a05:6512:324e:: with SMTP id c14mr9004395lfr.593.1602592619635; Tue, 13 Oct 2020 05:36:59 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1602592619; cv=pass; d=google.com; s=arc-20160816; b=qa6lJ4INwbwRmetjmv8wrAkzdFJqSjK5drW+V0hjeD6DLNs+xesyyrjPeLoQxinMMw jtNvFBgfzG2lcjSgRVdBH+0z+D0joqopZhPbCfEEYjVRMnehG4HiCZVWma1VNZTO3UXs Ex97MJeqJJXcYaynWaqt3fHFur8Ide4bAxa+qXngnrzgE3UV8sp+FX2BQIMpCkw9Wvau Ib6GDEGe8Lk9mzlXCMoMXgr5/Jx8AE7+ADjeZEcHE4QfWkZn070cvhz7JclJNRub8iiW LxKVr1aYkwuNjyd1oFwbDwsJpCbmQtQ94++B5HW7Iz/zkUyZt6eDfbsxKhwRmvqLhN0L OWzg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:message-id:date:subject:cc:to:from:dkim-signature; bh=OdnNhHJcUttIIjGLotSsdFPJ+u4XU3Fg/pg4NyhTEQA=; b=W1OY/DX1sQ0EZbRhvs8tV5oG5UmzO+6vPc9pQnH056aJt+9z4Bpx8N2s2+M84HCzF1 Ua6D/ZyRWzBurIR4BXWSCJ+uOud0BVjpDpu80qbzpuVoU7rR2nnK6q+PewMbpX91GjO2 CCXhYlJNyR3McRkMERvjHr403Bbe4tgwLpkQmRoZ3USO3+UmcCCsqnXMbJl6BUosvl0a hFsxOTkvPKTnOxDmCpJ/yMCfcG0b/33mJmcHw6tcUqgk1hQgmKkXcIrjAQoFyTT1N759 MaXk/EMF5EfoexbejcvJ9aI0SnLyOVHClfmQUnlTcrWjRPlbxVHKorKBZeqyL84E/UN7 pqHg== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@Teleste.com header.s=selector1 header.b=UwDvB112; arc=pass (i=1 spf=pass spfdomain=teleste.com dmarc=pass fromdomain=teleste.com); spf=pass (google.com: domain of sami.hartikainen@teleste.com designates 40.107.1.63 as permitted sender) smtp.mailfrom=Sami.Hartikainen@teleste.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=teleste.com Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10063.outbound.protection.outlook.com. [40.107.1.63]) by gmr-mx.google.com with ESMTPS id x74si653879lff.12.2020.10.13.05.36.59 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 13 Oct 2020 05:36:59 -0700 (PDT) Received-SPF: pass (google.com: domain of sami.hartikainen@teleste.com designates 40.107.1.63 as permitted sender) client-ip=40.107.1.63; ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=F0QQQ8MnU21WQLoWlykpFu+c+dYr+cF/TgdzHJzXQHTHf8xoIwuPwg9ZWMi+WzI5LgChzo1I46b0oiWJhRG/bRV3R0TH2bAc6qQT/21huAzciyKa7meMo4RtsQJgoA3Xf8PZUvsWBqXo3V9x7LxgoO5D8Yi+GoegodQ15XJlhSItSOmC6gwM1T/bCQ6fA49zDWzbA3jKiAn2jqyA+39kk01OT+v8BNbS2Wozhn2ptd7RigKdYvSXKkHJ78JBQ+iHsGZqUfAy6vok1zrpAYNY3ap+ABfyDPa7R5JMwwOITNxj3q4fMREL4w1aTfHilC4QWKmLFFqKD6U2DeHrMUBg+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OdnNhHJcUttIIjGLotSsdFPJ+u4XU3Fg/pg4NyhTEQA=; b=WjFEqSb9w1UoWft5oSS0lLMybfA0yJg9G7JGoySqKAU5G+tI7/XBT+qXgq5AOmtJN3D0dphrw8MOIZkMHzL0VSeEqwFw9cYrp3x7x3b2i3I8QZN4zt0a4aSGs1broPQYgQw4PmbuF0qzQW09G0EIK54OuNwH34eJRf16619n1z4kiHFpGZy8pQbTMelMwDbYX7zrYB5YW2t06r2V1gKKW8byemcHg8FglFXnVbNTDsPZlZ0BQsF52jrFm6L8qpu+1Uau1LE/570Uvw18CQFRT/noO1+YnTRWuidb4mWa6McNm4pZAoqvIzfESeqcvnpC1dsF4/MvIJo1onTgUUvgEQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 212.213.19.238) smtp.rcpttodomain=googlegroups.com smtp.mailfrom=teleste.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=teleste.com; dkim=none (message not signed); arc=none Received: from AM6P193CA0065.EURP193.PROD.OUTLOOK.COM (2603:10a6:209:8e::42) by AM5P192MB0177.EURP192.PROD.OUTLOOK.COM (2603:10a6:203:80::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3455.23; Tue, 13 Oct 2020 12:36:57 +0000 Received: from VE1EUR03FT057.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:8e:cafe::b4) by AM6P193CA0065.outlook.office365.com (2603:10a6:209:8e::42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3455.23 via Frontend Transport; Tue, 13 Oct 2020 12:36:57 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 212.213.19.238) smtp.mailfrom=teleste.com; googlegroups.com; dkim=none (message not signed) header.d=none;googlegroups.com; dmarc=pass action=none header.from=teleste.com; Received-SPF: Pass (protection.outlook.com: domain of teleste.com designates 212.213.19.238 as permitted sender) receiver=protection.outlook.com; client-ip=212.213.19.238; helo=mail.teleste.com; Received: from mail.teleste.com (212.213.19.238) by VE1EUR03FT057.mail.protection.outlook.com (10.152.19.123) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.20.3455.23 via Frontend Transport; Tue, 13 Oct 2020 12:36:56 +0000 Received: from contrix.teleste.com (10.1.1.162) by mail.teleste.com (10.1.0.45) with Microsoft SMTP Server id 14.3.382.0; Tue, 13 Oct 2020 15:36:55 +0300 Received: by contrix.teleste.com (Postfix, from userid 1001) id 57151252; Tue, 13 Oct 2020 15:37:00 +0300 (EEST) From: Sami Hartikainen To: CC: Sami Hartikainen Subject: [swupdate] [PATCH] libuboot_env_store: fix env double-null termination Date: Tue, 13 Oct 2020 15:36:32 +0300 Message-ID: <20201013123632.12061-1-sami.hartikainen@teleste.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f7d3e4cc-1a55-44c9-4420-08d86f74ac2c X-MS-TrafficTypeDiagnostic: AM5P192MB0177: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2150; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Z3wa/szxF5Hh6xcgUKI4b2wGVzwlUqfo/f9HMERYu6OVBmSgnYUMLl9HtxlXflZ+QhRHnVWSzwte+TAXfYrFkOEfrRXk3CV+yw6zjFpxzsJQLqlgz/ASZQcenL9UlikmiBmP6bAYo9ixXlWgPjuJsnoZ0+NJwr0V6bzLirRRmQwINzK4QE/HtK7lAE+RwPYd1RaDklXVnAnYziy/zxWOpjQx/d9xZhQErLvTykgA3M9Yo6oQYx6iBSd3hc/oPHBpXHAhFXJwuqwN8FXVsU8IKc0gM3DYRN+coCu7/dxurRM3gyBwSuAng31vk8QanEfem14kJ4ekQC7ENJfgqgPugq75tMOcr6iLrcnjr4nVdwi3Ve5f693V3rWfBQn6MwXsxw/PjvF9pEYlGl5Jf+h0G6cgeC0Kw4iVMgY7WfzjEBKRnKJGuMM7q0WHKA1pbtNl X-Forefront-Antispam-Report: CIP:212.213.19.238;CTRY:FI;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.teleste.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(4636009)(396003)(376002)(136003)(39850400004)(346002)(46966005)(36756003)(2616005)(82740400003)(33310700002)(26005)(107886003)(6916009)(82310400003)(356005)(47076004)(5660300002)(81166007)(478600001)(2906002)(6666004)(336012)(426003)(186003)(70586007)(42186006)(1076003)(70206006)(86362001)(44832011)(4326008)(8676002)(6266002)(8936002)(4744005)(316002);DIR:OUT;SFP:1101; X-OriginatorOrg: Teleste.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2020 12:36:56.4348 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f7d3e4cc-1a55-44c9-4420-08d86f74ac2c X-MS-Exchange-CrossTenant-Id: 0a3a6402-5c43-4939-8e53-47a694177b24 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=0a3a6402-5c43-4939-8e53-47a694177b24;Ip=[212.213.19.238];Helo=[mail.teleste.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT057.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5P192MB0177 X-Original-Sender: sami.hartikainen@teleste.com X-Original-Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@Teleste.com header.s=selector1 header.b=UwDvB112; arc=pass (i=1 spf=pass spfdomain=teleste.com dmarc=pass fromdomain=teleste.com); spf=pass (google.com: domain of sami.hartikainen@teleste.com designates 40.107.1.63 as permitted sender) smtp.mailfrom=Sami.Hartikainen@teleste.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=teleste.com Precedence: list Mailing-list: list swupdate@googlegroups.com; contact swupdate+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: swupdate@googlegroups.com X-Google-Group-Id: 605343134186 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , Environment lines are terminated with a single null byte, followed by another null byte to terminate the env itself. Fix termination in case where flags need saving. Signed-off-by: Sami Hartikainen --- src/uboot_env.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/uboot_env.c b/src/uboot_env.c index c9a900f..756a5fb 100644 --- a/src/uboot_env.c +++ b/src/uboot_env.c @@ -898,6 +898,7 @@ int libuboot_env_store(struct uboot_ctx *ctx) first = false; } } + buf++; } *buf++ = '\0';