From patchwork Fri Dec 29 07:06:08 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peng Fan X-Patchwork-Id: 853674 X-Patchwork-Delegate: hs@denx.de Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="T2sGf2PZ"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 3z7J3F6R0mz9ryr for ; Fri, 29 Dec 2017 18:23:20 +1100 (AEDT) Received: by lists.denx.de (Postfix, from userid 105) id 91C19C21DC1; Fri, 29 Dec 2017 07:23:16 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=BAD_ENC_HEADER, RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id BB22CC21C59; Fri, 29 Dec 2017 07:23:13 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 8F338C21C34; Fri, 29 Dec 2017 07:23:12 +0000 (UTC) Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00087.outbound.protection.outlook.com [40.107.0.87]) by lists.denx.de (Postfix) with ESMTPS id EDC84C21C34 for ; Fri, 29 Dec 2017 07:23:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=+0fYqFGecbuaumMmFU/3uFfKRioEqJ+tovLaXets3rQ=; b=T2sGf2PZhfSLOJUlHgjUnspe5TUNgFvr4GSdAMa9QDuXLdQUOPCTi+FCwhG6pMPN9+sSKqFZIGo50C3uOz4YVivy+0Xz4XV3g12ZV/7tVPfO5WylNdQYx0CDGI+0lo83V5cHkXS2Cdn7klyOueA+UbXB2EmDqxDAHPsZ/qm4xTQ= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=peng.fan@nxp.com; Received: from shlinux2.ap.freescale.net (123.151.195.1) by DB6PR04MB3221.eurprd04.prod.outlook.com (2603:10a6:6:6::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.366.8; Fri, 29 Dec 2017 07:23:08 +0000 From: Peng Fan To: hs@denx.de, u-boot@lists.denx.de Date: Fri, 29 Dec 2017 15:06:08 +0800 Message-Id: <1514531168-18923-1-git-send-email-peng.fan@nxp.com> X-Mailer: git-send-email 1.9.1 MIME-Version: 1.0 X-Originating-IP: [123.151.195.1] X-ClientProxiedBy: HK2P15301CA0009.APCP153.PROD.OUTLOOK.COM (2603:1096:202:1::19) To DB6PR04MB3221.eurprd04.prod.outlook.com (2603:10a6:6:6::17) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7bac837d-cf99-4f62-22a7-08d54e8d0408 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(48565401081)(2017052603307)(7153060); SRVR:DB6PR04MB3221; X-Microsoft-Exchange-Diagnostics: 1; DB6PR04MB3221; 3:X9BroKpexORiBjkLH4dDVUU6GYpZdzRrauV8c0mEhVmnU5ZUKJnu7Ci97KcuwAN/LV7eDyiSKLs/VA6dYzmUnu0sWm3vs0druQ9ISHwpw965RUop4iqO/dsMmLDvUm087fHpLvoKaqAUQWtOLQZOXQHdn1RBQyF030SAPyIwkJYYi+059L2EAEJI0FvOK63y9xnmViwB0LWAivfdNUPnLJHxYXcSTKlcVYJCe0js78LCb7oAzVbVRzCUTB6W3TM7; 25:tNtcuaiU+wGtj6Tu3DmiY7qRL4CWL1L55wCmQ3SmC9y1XIdwmjG024uvPmZ+vqB9f8q0Hm3pOVeb8rzJj8g9pToUF/+0T4hIlYMs7fROvGSv9EvZvnICKJKC68ZV9olsSefIW4Tq44tux9m9ufnYRA5PEyPvvZKhynHarWuatKmbsEcVlH+xKFCvATf+qGL9pA6IJKa9RVnqWDa3NJQK0J52lXEmj9ZMnLBTBWc6dLMnlbdkZWxXMdj8yr+zA5QIL2LDemiuUrqkXPxHel0XIFRhxU8zbC6gs+bU/osA6SmDwuKGd2vMC3P3SoSnH4gcuy2dWtsyIiyjfDT10uczHg==; 31:S38zmr270aePQ/+e6VcKXK9YDIpgkRUoGgJ4g9xr8RF+fZHvB5+e+GM3lKtFYdenebVz5eXl+rgq7ePvxgsCRPFc/uDr3EJqa0KkMww//XKR590HnGfseMuhFYx6jA9Ng3cxDR3Hcd4ZWX0GEWTylzmrM+aQNvpz5y/h1wxD5Z/OhqYLlnGt6llL84iwaIKPIzqPCpJjbCYL9g1flcEZBb1h1yxSvVZ0H3tKOUFoUOs= X-MS-TrafficTypeDiagnostic: DB6PR04MB3221: X-Microsoft-Exchange-Diagnostics: 1; DB6PR04MB3221; 20:BusZsQPgSJme49Vso/oex8uvsX1tzFvbCQtNoxr+S68Q9x/sPVVcmfWL37i+flPufHf1fPAc25V+bsXv1gHX7+GLMLoXP/5dADOTa2uprOAqDSLphhML9WOzMx+yUQT0cDw3hvxGfQzcvigrxsWHb9tVsSTCCRDqec7E9JL7gpnAjOEwtowmVgwhJc+s8dsOmnq/W/uHy4WyeCiMuiIQNSOoy7KEhwev+FVxeI6dM4dO6CkEZoGAkmO0a3H2OhyaiTcNSXOXLvOlylAdWTTzxrtrjynU8yh6tNKLXBYxe0Wl3es23rc+azbrjft4hjnqXwnrFbFvf2TANCBCiv59wZoa4iB9KY6DGDKd7RvjSq/sKDm6a65KDs0uecY6+DGW++QQ+UhtvVxgcijfoPTPZjZa9iGHeb6wJ3uKmrQ3oPg32mR4eTwen8U9kC8vqrUegF17h+mjSDS7kL6Ub//iGZ3eqV2Fd7zvYfmfqzjPK4mJAQXLM2D86p8Pej9OM9On; 4:eaiQW4dtIRZUHihVZzHqFnKA21tlydYlr3Mjxv4nScMV/tJRiCb1DJx9RTOblQeesEKDE/off9dnV0q/ME+eeaH1mPGOGxk0Tt1SBp6BcVgAsOWQ2o1yVfiJxTkrpiRLXXQeaCfIrSsSoukT2yWVKt8SkNkJg4lrClPyzFQLwf7eXrjrCSD8Z4uWn8yblpVM0z4JMF/N9PF2zIgOa8Sqvr7M6pMs6Hh6PnZ5brTq1hIKjtw8ccO4C/nfEVPyLJf5vdjz+16ViQLBaN1y3DMCLhjrFskJeMi/vRQdMsp5GTuKa3qCHuAx5kv+N+SmI9CU X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040470)(2401047)(5005006)(8121501046)(10201501046)(3002001)(3231023)(944501075)(93006095)(93001095)(6055026)(6041268)(20161123560045)(20161123562045)(20161123564045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:DB6PR04MB3221; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:DB6PR04MB3221; X-Forefront-PRVS: 0536638EAC X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39860400002)(366004)(39380400002)(396003)(346002)(376002)(189003)(199004)(4326008)(50226002)(8936002)(81166006)(25786009)(68736007)(39060400002)(51416003)(3846002)(52116002)(6116002)(36756003)(305945005)(7736002)(81156014)(8676002)(105586002)(106356001)(54906003)(53936002)(86362001)(66066001)(2906002)(6486002)(5660300001)(50466002)(16586007)(6512007)(316002)(97736004)(478600001)(386003)(47776003)(16526018)(59450400001)(6506007)(48376002); DIR:OUT; SFP:1101; SCL:1; SRVR:DB6PR04MB3221; H:shlinux2.ap.freescale.net; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DB6PR04MB3221; 23:luXK+0APIBWlGbU/WIo2rlLl8cPDR0+ZznPf6yEyO?= 1CmiTq+v3x3I9tiOJG+V+j8GjJSwEjnY/GosjrVfhZ0IcXb+1i7MVjfeC/RGXHrxNC97MS7JrwGMzu4NyW7TQuJU8QOPJNXgrHo4rLZLzyh9HDebxiCxEeG/dk5nWM+G2H/lgIsyCzWpT2DAKd/3uOWolxSPtExiO1owu2D38qjORtdUd1y9Hh7TyWFaCjJx1UutUh9HeVka9SDODbCai+65xogxw4jNU6c0UkOaBpBxmAWi9/nQ25n4Yqiq52FBO9mKvJRfLRDB9Gnh5hHSqPrhDgNVw7aMXfklCEStHNDoV2kOlCjYSQrP074/wezG9pBC4sZeIFyeHZguNy76Nv5/wy9s28wQcVKL7+gxKMKloxCH5q4QJFisLUeq6x5oespylmQOl4RsuUCgv31CSV9zUF1a33D/mYnL+erSH/6uqtDzX87T7yurUNqJ0ryICHWv1FoNTjtEzANHeNzPDvJsg40456FMppnHNEUH3odxZlMcTTbmxEcXMKSbft0kBOEcy9Gk/Wz+ktlbPthXbjygpjWaDqgnRzI9A3SBohrZM6aWuNasHorGN7b3oWQckdJfBiNKSc1OFb2EYCOYLsdrAuFx5WKDHAj5WNoF9TysQkpKDJhqEM+/pCf0nHPuuAO7aXd9mUSM3fghPGAkEPuB0a0ltUI54cI+AR8wlrHpqHuX3tArphdALZfTLvCh7qL1f4i7upJlPy4cl+dNmHR9qCZmLq/yc6F92LC/BcoXjiiB3a3h1dUF6Y3VWOwc9c0b1cclTPGXvM8H5M1OZ1/tnKYUwlXE3QiFJGOQkCgqS5ti8nI7DMbi1X/wufmg0/j3VCz34MVJaT1CyT2jhdPfv4VHlyFxJSgqe3ynTuLJ8tQeYQHi+T2xqWMF5fOjU+XicOF99klqsXOsjWgZPmWEQz7Lvwt13rj7viKoH1zBUHgXSAUTgz8+sJySj7iHd2TX0asEyHMsPlsccKtmjnVeA++XtQu0zC5GPTWp8m2iIZkqYAmgv2Lsfp5TlZQKmQ= X-Microsoft-Exchange-Diagnostics: 1; DB6PR04MB3221; 6:GkCX9zFoP0aQfZAfoxno0TLlstBkEnp9M4e48ysAejGWiALKXYgFMX6CUjQBFXXkENzCgdgQec4VkGk10pANUkhEc9LRDVmGL2AjoaEtNezSKItE1NJzQtNi3JHFqKRErsGu/cG8K+a8vrYn6KOHIINDeTmfGJcwmRFqmIo2tD2VjPQTKrANiTk8m2zrSgwwuk5fGnKtBgs2uZl6w/btl56iGEgF+SAQJHEmfEtcIGg3CwgoEFNO7U3EgRI5JdCo30f+szfrcJpGCIIqRTwN+JzCNArI1GOQIc4aNUwZe241o88a3UmsQNQ/AT9TZopKrCfKyLm9S2hQ2pjoten4WQWHTlJSlowLpqTErFnbqGE=; 5:NI52Iz5II0ICYEC0tOKKVn64X742l3NRtEGxiaZcEb27NjBlayMD+OWny5rPw87AyIgBKQic3Q+C7cJ70jj0DfiKR2EWNXOS5RFJ19QWgt07eqCyhpDeo4oEdqPD9BkdU6pyVHusifFviqNMAjri4x3wPGa4yUg+GT352YnWCR8=; 24:PBAghXkooZ/7A02yskKXiUBzAU62+DMdR5I08vAL0nnqmirB3+LKdEFD4jSsMaGtjfQMdbNNq9iEUHAkpoDuGSXsCWOZuRTj2dlN81Pa2cc=; 7:bae+OAkU30NPjzpzX7JmJohCmuyDPw1yUvoZc2aZu3PtSZeFWmdfrtZcHFWeRAjOuLswfKZ4L9wMZJdqNcGHWgz0hEfYV6JjJkggGCXQlp1Li1pyYLdbX3+5hszMxu6IviqOYr9D2yKuUs3ANCva23eT/x3ioUOSRKyuVHh/1Tg83iKvhs4X0dblSAsBrPJlzGzQvOlILg/WAC8gBJxgF5fOev8/xhN548Q+0+vK6GTI6WwJxe/M2HXSRX/8NAjt SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Dec 2017 07:23:08.7008 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7bac837d-cf99-4f62-22a7-08d54e8d0408 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR04MB3221 Subject: [U-Boot] [PATCH] i2c: mxc_i2c: Use or operation X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" The operation should be OR, not BIT OR. Signed-off-by: Peng Fan Cc: Heiko Schocher Cc: Stefano Babic --- drivers/i2c/mxc_i2c.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/i2c/mxc_i2c.c b/drivers/i2c/mxc_i2c.c index 205274e..79228c2 100644 --- a/drivers/i2c/mxc_i2c.c +++ b/drivers/i2c/mxc_i2c.c @@ -784,9 +784,9 @@ static int mxc_i2c_probe(struct udevice *bus) ret2 = gpio_request_by_name_nodev(offset_to_ofnode(node), "sda-gpios", 0, &i2c_bus->sda_gpio, GPIOD_IS_OUT); - if (!dm_gpio_is_valid(&i2c_bus->sda_gpio) | - !dm_gpio_is_valid(&i2c_bus->scl_gpio) | - ret | ret2) { + if (!dm_gpio_is_valid(&i2c_bus->sda_gpio) || + !dm_gpio_is_valid(&i2c_bus->scl_gpio) || + ret || ret2) { dev_err(dev, "i2c bus %d at %lu, fail to request scl/sda gpio\n", bus->seq, i2c_bus->base); return -EINVAL; }