From patchwork Mon Sep 21 10:31:29 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrea Corallo X-Patchwork-Id: 1368212 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=sourceware.org; envelope-from=gcc-patches-bounces@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=armh.onmicrosoft.com header.i=@armh.onmicrosoft.com header.a=rsa-sha256 header.s=selector2-armh-onmicrosoft-com header.b=jW6jpaGg; dkim=pass (1024-bit key) header.d=armh.onmicrosoft.com header.i=@armh.onmicrosoft.com header.a=rsa-sha256 header.s=selector2-armh-onmicrosoft-com header.b=jW6jpaGg; dkim-atps=neutral Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4Bw12l6gDFz9sVX for ; Mon, 21 Sep 2020 20:31:55 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id F21DD3857021; Mon, 21 Sep 2020 10:31:52 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2075.outbound.protection.outlook.com [40.107.22.75]) by sourceware.org (Postfix) with ESMTPS id 2A8893857C54 for ; Mon, 21 Sep 2020 10:31:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 2A8893857C54 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=Andrea.Corallo@arm.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dlWGKa+J+3q4saoXbkiYj1I/K2EBwK+d3oDTU52vFtI=; b=jW6jpaGg73z0UEW7e/dUBffpghF1Qnak7SstbkbSv6VxrYOyWrQOaXTI46PQodQWDyJBjOr3YHq/klVGggX8BITMGfb7PuL2Q6aIMFj/uewsRR30IrssOqqmmCRVWrtkyIHh4JdxHK7/BiQ96ExRXcOTTKzp0Pmm3vnJZ/piMEo= Received: from DB6P195CA0019.EURP195.PROD.OUTLOOK.COM (2603:10a6:4:cb::29) by VI1PR0802MB2447.eurprd08.prod.outlook.com (2603:10a6:800:af::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.19; Mon, 21 Sep 2020 10:31:46 +0000 Received: from DB5EUR03FT059.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:cb:cafe::82) by DB6P195CA0019.outlook.office365.com (2603:10a6:4:cb::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.13 via Frontend Transport; Mon, 21 Sep 2020 10:31:46 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; gcc.gnu.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;gcc.gnu.org; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT059.mail.protection.outlook.com (10.152.21.175) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.15 via Frontend Transport; Mon, 21 Sep 2020 10:31:46 +0000 Received: ("Tessian outbound 195a290eb161:v64"); Mon, 21 Sep 2020 10:31:46 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 9426bc3728ada3aa X-CR-MTA-TID: 64aa7808 Received: from 31aed731cab7.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id AB11E7F9-D224-4E6C-9A4B-E19012F6F145.1; Mon, 21 Sep 2020 10:31:40 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 31aed731cab7.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 21 Sep 2020 10:31:40 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TuXcxixO5KKZ9MyU6VIYe3AeMmkPK1bxxMp82M3cYv4mH9szNhbhnjk2NX5kbZqM7jT2tK1LH4tO7ok0/rkXpOFG4Ud3c46VUb1fpfxFtrExz1M1Dvj4lK0yuLBzxTP0ZTjlc9MSEIt4oiCJUXm+qRcWxyNDUCizeNVEoXesQhbxTT3xogqHnmrvs0m2mAA9uOBvhQfBZc8vsp+YJqY+MBNVhOasHcNZcq6wZS8Ipulld3r9nzAZx3RRe6Z3diwauihhZe+CkTc1PrmZC082BsKH7FPAw1ZAe1NtF7B3eWp3Kq0vLfNudaPwzUzgylhEK+IVNFgvNqYFsLut408iNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dlWGKa+J+3q4saoXbkiYj1I/K2EBwK+d3oDTU52vFtI=; b=VYw6K1MArQxDcNfbbp3ZojCpa8XzouQI3argdE+nQFxSv35F0kaqvQuGD1GTXEDTtYHESRLErtN9rxhh/DrYST52KgNjhOdlsVpwk+8uFn6+/6gfwZ0v9DkFUrf7sVoQ6DxJym5lGCs1RgtBalENMbPduM1vGWbzPngRF13XLncb4g0kY4b4kXS6a55oKOs9wapeF8i4EOcTg5aqwBQJ7Kke4J67c2nc9tYtGfB6xo3PRMQzp8RV3M1DEbZ2sqkopKhMmZD9DtGtgQZXf4YkmakDBdass4QgOmPUi3eZy2jmRngixKtiSqUmXlGoLDyALa5T9jDKasL+xXU1I25b/w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dlWGKa+J+3q4saoXbkiYj1I/K2EBwK+d3oDTU52vFtI=; b=jW6jpaGg73z0UEW7e/dUBffpghF1Qnak7SstbkbSv6VxrYOyWrQOaXTI46PQodQWDyJBjOr3YHq/klVGggX8BITMGfb7PuL2Q6aIMFj/uewsRR30IrssOqqmmCRVWrtkyIHh4JdxHK7/BiQ96ExRXcOTTKzp0Pmm3vnJZ/piMEo= Authentication-Results-Original: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; Received: from AM6PR08MB4900.eurprd08.prod.outlook.com (2603:10a6:20b:cc::10) by AM7PR08MB5509.eurprd08.prod.outlook.com (2603:10a6:20b:10c::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.15; Mon, 21 Sep 2020 10:31:39 +0000 Received: from AM6PR08MB4900.eurprd08.prod.outlook.com ([fe80::b96e:941c:e829:3903]) by AM6PR08MB4900.eurprd08.prod.outlook.com ([fe80::b96e:941c:e829:3903%3]) with mapi id 15.20.3391.024; Mon, 21 Sep 2020 10:31:39 +0000 From: Andrea Corallo To: gcc-patches@gcc.gnu.org Subject: [PATCH] aarch64: Do not alter value on a force_reg returned rtx expanding __jcvt Date: Mon, 21 Sep 2020 12:31:29 +0200 Message-ID: X-ClientProxiedBy: CWLP123CA0018.GBRP123.PROD.OUTLOOK.COM (2603:10a6:401:56::30) To AM6PR08MB4900.eurprd08.prod.outlook.com (2603:10a6:20b:cc::10) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from e112547 (217.140.99.251) by CWLP123CA0018.GBRP123.PROD.OUTLOOK.COM (2603:10a6:401:56::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.13 via Frontend Transport; Mon, 21 Sep 2020 10:31:38 +0000 X-Originating-IP: [217.140.99.251] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 9285484a-aa45-4bed-cd0b-08d85e198abb X-MS-TrafficTypeDiagnostic: AM7PR08MB5509:|VI1PR0802MB2447: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:8273;OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: ZtkOXDTUd166bMSwvmQZPT1CJQ4mNlmdlnYFQSEKg0C59TUul5w1I47zAytMQe8EyRHGq0498P6Z9WJxdRpjPFRGRqG2rXDJT6nNIxZFqh2hLM7Gvx8STZDDBDbCQyUydBkJrcbit/C5SUJ9tMiTm/kUtCrpFyebuIpcZfZLL0+RF+fkqxiQ24FE9DOIKp23t0AiXyQxCr/BeC8OFvt5CwohfTLYa1Ab8djEwFFuRC3ZCNhIHHFsvzPX/WQEqnNAvD7BFKsXOghTCmD7pNXFmm09M/va59BuKGVvx/ShcJQQs4kuSKWqX8Gku3MVW2dv X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM6PR08MB4900.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(136003)(396003)(39860400002)(376002)(346002)(26005)(33964004)(52116002)(86362001)(6496006)(478600001)(16526019)(186003)(66476007)(66946007)(66616009)(36756003)(2906002)(316002)(235185007)(6666004)(5660300002)(2616005)(6916009)(956004)(66556008)(8936002)(8676002)(4326008)(6486002)(44832011); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: lTr9I0NQfGsUMIsCZkcuzjpACLeJ7biaZrsDe4OFXM4oveYFT3lhqOgJEy0DcXSYVFvtycM4YaDI8/TqHJEUYEgeXH3hrcVElyfQ2GLNGGa/wNm2obn1CEpXnOIrK1nnrMlKoGjge6wGOAWXZR+8G98qJg3ATpKCEl0oEs+0C7SirQuiQmZFTQqs1JhM36hByjvAqOyj1kdBt6lJzyY/Cmz9U378M+i5t4OYG+aIKWwSIQiuWJ6+Waad7DIOnf5oDBb0v2FEF7hYpl5gXU10SmOdWWX1TowWiyNUNJ847XqrBxVfHWsZU7uwYlrEZHw0xmu8VFdFc+iTcAEIDY4lAxedsCr/YvLdjLNX+W4Jj/bSRpmHp61PQpRJL8O/9SU4C/+qRBvmCWer6YcOvNM5c96/2ISqwUQbAjI80+cyPhMdQBH7yAgwNHP7ooE7QgIPqorlKfgb+kjQhoVlJ3bQhZQBeglHvnSWdewh92DIyDdUCnQ6xEvMC27ITrSFKbkxMAFk75yC+2qK9ZY+wfdEVTmwmNrUkqqN7yW6xKScSkvs14ByvGxfim+rDqdNKxc/q9iE5o/ScRhc+Vw0BiwzHUMwNUfKEWOyrVkclGQjFshI0wN5iGKQCnLbG/o1Qx5p2JT+kfhmyKQkk2tyLbgGEQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5509 Original-Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT059.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: a8e5acee-f87e-4922-b9df-08d85e19864b X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nNPRIugRo4+gmIDsLNVnLd6FZDlc5v9XoRGvN2imGKvI7Pecrf1v+fIB02UwERQ1y1KmlMROgBiRHc6oXoaH4RaKe+ZLOCpQF7dAGIUF7obx6naHdlw2LDFTwy7/0eid6RPdTYheUT37rS/y9qv1+o8Y8PN/oCi/1/X8JBqcy3URs8CYCjuKglkffcTLzbsiIEcD5OziqyeNt7mhcZJZ0OuzLB9FapKnTbj+G9sEx/IKx45zoyS0GFpk16g8D9Clmn8j2J/1VxVov3uMiEkjzMl3ssQK9/jV6aqTXypNep/IKRkocyLNPpN0ELKxm3JNBmKunOHABFB1D16XcV9+RMgXwaCAhwnS0eJJsUPQXPyK7ki3IUvUYDV8n922Ea771+hwOoHNhXa2tO1c6tJh0/sx8DRUxJq0HmybFq8xBedssH3azBGjLA4E3KyXid+N X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(396003)(346002)(136003)(376002)(39860400002)(46966005)(82310400003)(478600001)(2906002)(6666004)(4326008)(86362001)(6916009)(36756003)(81166007)(47076004)(956004)(2616005)(8936002)(16526019)(186003)(8676002)(356005)(44832011)(70586007)(70206006)(66616009)(336012)(26005)(82740400003)(6496006)(33964004)(235185007)(5660300002)(6486002)(316002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Sep 2020 10:31:46.7592 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9285484a-aa45-4bed-cd0b-08d85e198abb X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT059.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0802MB2447 X-Spam-Status: No, score=-14.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, MSGID_FROM_MTA_HEADER, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nd@arm.com, richard.earnshaw@arm.com Errors-To: gcc-patches-bounces@gcc.gnu.org Sender: "Gcc-patches" Hi all, From the `force_reg` description comment I see the returned register should not be modified, thus IIUC should not be used as a GEN_FCN target. Assuming my interpretation is correct this fix this case inside `aarch64_general_expand_builtin` while expanding expanding the `__jcvt` intrinsic. If is not the case please discard. Regtested and bootsraped on aarch64-linux-gnu. Andrea From 403ad66b8f9c108d7f38b406ed1afcb603b7e25f Mon Sep 17 00:00:00 2001 From: Andrea Corallo Date: Thu, 17 Sep 2020 17:17:52 +0100 Subject: [PATCH] aarch64: Do not alter value on a force_reg returned rtx expanding __jcvt 2020-09-17 Andrea Corallo * config/aarch64/aarch64-builtins.c (aarch64_general_expand_builtin): Use expand machinery not to alter the value of an rtx returned by force_reg. --- gcc/config/aarch64/aarch64-builtins.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/gcc/config/aarch64/aarch64-builtins.c b/gcc/config/aarch64/aarch64-builtins.c index 4f33dd936c7..b787719cf5e 100644 --- a/gcc/config/aarch64/aarch64-builtins.c +++ b/gcc/config/aarch64/aarch64-builtins.c @@ -2128,14 +2128,14 @@ aarch64_general_expand_builtin (unsigned int fcode, tree exp, rtx target, return target; case AARCH64_JSCVT: - arg0 = CALL_EXPR_ARG (exp, 0); - op0 = force_reg (DFmode, expand_normal (arg0)); - if (!target) - target = gen_reg_rtx (SImode); - else - target = force_reg (SImode, target); - emit_insn (GEN_FCN (CODE_FOR_aarch64_fjcvtzs) (target, op0)); - return target; + { + expand_operand ops[2]; + create_output_operand (&ops[0], target, SImode); + op0 = expand_normal (CALL_EXPR_ARG (exp, 0)); + create_input_operand (&ops[1], op0, DFmode); + expand_insn (CODE_FOR_aarch64_fjcvtzs, 2, ops); + return ops[0].value; + } case AARCH64_SIMD_BUILTIN_FCMLA_LANEQ0_V2SF: case AARCH64_SIMD_BUILTIN_FCMLA_LANEQ90_V2SF: