From patchwork Mon Sep 14 13:37:36 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicolas Chauvet X-Patchwork-Id: 1363588 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-tegra-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=ep8bB0LC; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4BqnY71rL0z9sTp for ; Mon, 14 Sep 2020 23:40:11 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726751AbgINNjw (ORCPT ); Mon, 14 Sep 2020 09:39:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58066 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726752AbgINNhq (ORCPT ); Mon, 14 Sep 2020 09:37:46 -0400 Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2279DC06178A for ; Mon, 14 Sep 2020 06:37:45 -0700 (PDT) Received: by mail-wm1-x32f.google.com with SMTP id z9so91018wmk.1 for ; Mon, 14 Sep 2020 06:37:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=nQZJ7yPVXRTTpaaOFiG+mf5v7oE6uXQPB9nQE0+9z00=; b=ep8bB0LCLxravy9N9omrB/Pi27Qr45UR/ES5/M+EAEhY+VpqNop5WWFulBd4EHVBiT OM1mXELjPcB5Lt+EUwMNJt8sy1pSY8sW8pjwIyC0pCnsmF/IZbZjKQEgksieO1lhqA7Z eL0A+d9rOsyay7LPP+JIG+SD7CB9PaHUe6PbPdpt4+f1w3VwNrVqXQ5sEGx51FlIeRJZ aQJODir/43Mz8XPUgfvQefimyt0pHrBLMUi6GzAA9pH6SYcrl0sr17BVxu1lzcNgiSWr g8FT+kP55kmqwOCoBJEpbloUKFyqmyvd4fLGtiQDbny/QaxK5ZmIF1r9dBP/oKzRMaIV Ob4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=nQZJ7yPVXRTTpaaOFiG+mf5v7oE6uXQPB9nQE0+9z00=; b=oNj1D58EABLAY4bw6nsnKuUKCXPNUaVJoHp/GEjwT4EQm74hDDNnWBsyNXqaD5HEXC SccN9bwHUDbFRq1/5Id3pM80EfZLWV/dhVY7VfDn2rjdlwN4eX9O8KGPBbYz87NuR2WT 60U5Hoay6Jgn1/hmha9Pb4PePvL0TBxe0YMCpO+UBujullKECfxlMrQ4xKWuc6l6POu3 RdzseEmFvp+pZewjNkYpNFuLEBidj0njhYDcM2nIi2+2WGuY8FyhtWGvRc/6AjvXTLo5 kkhOvzellwTqAu5kl4uNj0Ib7T5JZ++IgFbGKMp3LbUBVVGIQQ5U4FDi4Ecufxbn9oGf ZNnA== X-Gm-Message-State: AOAM531Y3boQt+fkkQYaW3mopK0CqXMaXn48mcmJbBQoo7U2faGXiDhH ngLRoXRv1xQ56+lDQM5kGIvNd07Vrzk= X-Google-Smtp-Source: ABdhPJzG7WYvork9Tes+VlPuNvwihHvcl8sTJrwXiV8/ppE0sStVQdkf17Btzd/hAjb0zEMqtvhefA== X-Received: by 2002:a7b:cd06:: with SMTP id f6mr15826385wmj.66.1600090662772; Mon, 14 Sep 2020 06:37:42 -0700 (PDT) Received: from arrakis.kwizart.net (lfbn-nic-1-212-171.w2-15.abo.wanadoo.fr. [2.15.59.171]) by smtp.gmail.com with ESMTPSA id a11sm18532488wmm.18.2020.09.14.06.37.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Sep 2020 06:37:42 -0700 (PDT) From: Nicolas Chauvet To: Thierry Reding , Jonathan Hunter Cc: linux-tegra@vger.kernel.org, Nicolas Chauvet Subject: [PATCH 1/4] ARM: tegra: Add missing gpu-throt-level to tegra124 soctherm Date: Mon, 14 Sep 2020 15:37:36 +0200 Message-Id: <20200914133739.60020-2-kwizart@gmail.com> X-Mailer: git-send-email 2.25.4 In-Reply-To: <20200914133739.60020-1-kwizart@gmail.com> References: <20200914133739.60020-1-kwizart@gmail.com> MIME-Version: 1.0 Sender: linux-tegra-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org On jetson-tk1 the following message can be seen: tegra_soctherm 700e2000.thermal-sensor: throttle-cfg: heavy: no throt prop or invalid prop This patch will fix the invalid prop issue according to the binding. Signed-off-by: Nicolas Chauvet --- arch/arm/boot/dts/tegra124.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/tegra124.dtsi b/arch/arm/boot/dts/tegra124.dtsi index 64f488ba1e72..a0fa5821a232 100644 --- a/arch/arm/boot/dts/tegra124.dtsi +++ b/arch/arm/boot/dts/tegra124.dtsi @@ -910,6 +910,7 @@ throttle-cfgs { throttle_heavy: heavy { nvidia,priority = <100>; nvidia,cpu-throt-percent = <85>; + nvidia,gpu-throt-level = ; #cooling-cells = <2>; }; From patchwork Mon Sep 14 13:37:37 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicolas Chauvet X-Patchwork-Id: 1363587 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-tegra-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=qsB3JFiI; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4BqnWx0HgWz9sTS for ; Mon, 14 Sep 2020 23:39:09 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726683AbgINNiz (ORCPT ); Mon, 14 Sep 2020 09:38:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58072 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726770AbgINNht (ORCPT ); Mon, 14 Sep 2020 09:37:49 -0400 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5EF3CC06178B for ; Mon, 14 Sep 2020 06:37:49 -0700 (PDT) Received: by mail-wm1-x344.google.com with SMTP id d4so42776wmd.5 for ; Mon, 14 Sep 2020 06:37:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=IQU/5no96PfQVnDWZvRJxAMbJR8IojKL6s+SB7SMMPA=; b=qsB3JFiIIoFf7VC8hVaXdeCovxGLCxGQg1BEyDwsmkE3arg1wdOseM/lHAUg/8AHKr XYsHwN83c2aRlXOYPOL1VTUiBthFV/G7Bu3am4WoDdh/5H5IuS5dVZzlIpr2ljgkAUgR mKf5Sg58OsROwQK0upk9kXy0Z2I48SyXsOTTDJPeDAjEu3TcxOzGla5TIEZjKtS1fIRR HxCVYGkuFtDY25bAHum/TNJA3SsdDvyAS0yCBfJJVhXsj7qo3dzVOKQX8b9yvCC/Iiz4 mPLkRvqZRCIALSiWch28L3aJ7C1m7TKwSdPL1+OlwiW+FOfvezFMt8DDKwS/F9aXDhNz PZfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=IQU/5no96PfQVnDWZvRJxAMbJR8IojKL6s+SB7SMMPA=; b=f2TZvSMOwjF5iJ02tKMjivYaN1iWiqcWA+r26BqpCNDPrLu97gsyu2gd8qCWn3ntZI lXXdDQG4kh/wJEBoSVGDyZ6zCeRedUzBrfyR6Xl7ui86TbGHlJevgqrgaSIjJV8SGKrh fd1X4zc7GUawaqgURy7tZutuRPeXvk05UfULk7FQhDhlmIIH1i6BI+0PuNyu1is5egM/ 2zwp1EDSO9qdRthLqJ28ygf6MOWgrMssz6LOx0morcuS6sLHgWwcejvtpMYCA1zkL74j fXVimbCZl9hEI/TYHPwRJOTpgL90JofFxE5TgpyAOAjHb5967SBe2iBJJo4j8/Or0S0S jKoQ== X-Gm-Message-State: AOAM532Ax7QGmUfaj7tKeAK0N8eym7vquoaIdc1PslpFQC4Y+cOZp83x SXgANReK6r+QxTlmx79osmc= X-Google-Smtp-Source: ABdhPJxUEX0WLu+PFr4OTIX+EKQA+38Lw22k6baJmQmrmSYGblVP/nmpkKauqOZfWY5MlD/zipYzXQ== X-Received: by 2002:a1c:2cc2:: with SMTP id s185mr3385229wms.77.1600090668150; Mon, 14 Sep 2020 06:37:48 -0700 (PDT) Received: from arrakis.kwizart.net (lfbn-nic-1-212-171.w2-15.abo.wanadoo.fr. [2.15.59.171]) by smtp.gmail.com with ESMTPSA id a11sm18532488wmm.18.2020.09.14.06.37.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Sep 2020 06:37:43 -0700 (PDT) From: Nicolas Chauvet To: Thierry Reding , Jonathan Hunter Cc: linux-tegra@vger.kernel.org, Nicolas Chauvet Subject: [PATCH 2/4] ARM: tegra: Add missing hot temperatures to tegra124 thermal-zones Date: Mon, 14 Sep 2020 15:37:37 +0200 Message-Id: <20200914133739.60020-3-kwizart@gmail.com> X-Mailer: git-send-email 2.25.4 In-Reply-To: <20200914133739.60020-1-kwizart@gmail.com> References: <20200914133739.60020-1-kwizart@gmail.com> MIME-Version: 1.0 Sender: linux-tegra-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org According to dmesg, thermal-zones for mem and cpu are missing hot temperatures properties. throttrip: pll: missing hot temperature ... throttrip: mem: missing hot temperature ... Adding them will clear the messages. Signed-off-by: Nicolas Chauvet --- arch/arm/boot/dts/tegra124.dtsi | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/arch/arm/boot/dts/tegra124.dtsi b/arch/arm/boot/dts/tegra124.dtsi index a0fa5821a232..c71d597ace01 100644 --- a/arch/arm/boot/dts/tegra124.dtsi +++ b/arch/arm/boot/dts/tegra124.dtsi @@ -1248,6 +1248,11 @@ mem-shutdown-trip { hysteresis = <0>; type = "critical"; }; + mem-throttle-trip { + temperature = <99000>; + hysteresis = <1000>; + type = "hot"; + }; }; cooling-maps { @@ -1299,6 +1304,11 @@ pllx-shutdown-trip { hysteresis = <0>; type = "critical"; }; + pllx-throttle-trip { + temperature = <99000>; + hysteresis = <1000>; + type = "hot"; + }; }; cooling-maps { From patchwork Mon Sep 14 13:37:38 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicolas Chauvet X-Patchwork-Id: 1363585 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-tegra-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=vFq1f6SK; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4BqnWY2Qf8z9sTM for ; Mon, 14 Sep 2020 23:38:49 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726477AbgINNil (ORCPT ); Mon, 14 Sep 2020 09:38:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58080 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726772AbgINNhw (ORCPT ); Mon, 14 Sep 2020 09:37:52 -0400 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 45B3CC06178C for ; Mon, 14 Sep 2020 06:37:51 -0700 (PDT) Received: by mail-wr1-x443.google.com with SMTP id j2so18787097wrx.7 for ; Mon, 14 Sep 2020 06:37:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=JiAbE/SJFaiXXWha+UZiz5ngLuS7vuLVdaMJTivRPyQ=; b=vFq1f6SKOxtpuKxNma+7ZA9kDXv2zGVkGU9v9NUmImjiKTQeM/2i3e0oTmeVt/DY6w tgv1Cx56ozRP1TV9Gzlxb12Mpwf6bVRCXJLQQ3zah/nXpAILn+H/HklrAZtRC1zNOSXT hZcDsubA6BWg8/Oef67y/vmHzS3XmbgaY7QSBMu01oBGi5jH5l8gpDkRwETb4VTVXjha q2UlYokEpJtwGYhuKm3a6uqsnwRNvKcsTpr24JoHW8MYjWbnMHicviAIBXfdWJpTu9ZR 5jmJs3VbdGAmNmGqYTMsr4eJhd4Is+6XVh4O9Ab3gDtftBYU7SKDZol7RNTOsA9e9AT5 kqOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=JiAbE/SJFaiXXWha+UZiz5ngLuS7vuLVdaMJTivRPyQ=; b=BONTVJaCXB0d0DKYN5uMuBR6otZXYkBk1cujhF0GMLZgIsFyKX1x/CdZx6NEShgOOJ JLTu++Bry1/HlObDBnxweLa8hNB5W0oI1KWIZnAovwl6rYr6pnrUyJNOpKCt/OOhCOED osw/feG8p9uLvnCRR5oJ3WURK6QprLw+zbL0wN8+b7a/1tX1oJphCD3See9jKxZVHipr oCX7ZCQd5kW2jpao2XqmKWEktbPsb3GohEadXx0JoCLm4tmHQ2lopuYMO+PquktSPbxU /ihXE9oQsqwc/5D4mwS6jJCuhsGYwAJv8W5CaS5QXn9DbVvxSnJ2CGRbWJCuuY9Belkl h/jg== X-Gm-Message-State: AOAM53288ufkYp9VQCDdmq6xPYWYtGzNWkEZUm4nBnougvSWPb0dUKYm 6i5/GWD+JweA/LyMGsqsjSQ= X-Google-Smtp-Source: ABdhPJw87PMqYf884sc9nCWQvnZpNiQyODT4J/UycBGllM2p5oMrTfGriEh/cMu4n58JpyTmFfW65w== X-Received: by 2002:adf:f3c6:: with SMTP id g6mr17355339wrp.340.1600090669198; Mon, 14 Sep 2020 06:37:49 -0700 (PDT) Received: from arrakis.kwizart.net (lfbn-nic-1-212-171.w2-15.abo.wanadoo.fr. [2.15.59.171]) by smtp.gmail.com with ESMTPSA id a11sm18532488wmm.18.2020.09.14.06.37.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Sep 2020 06:37:48 -0700 (PDT) From: Nicolas Chauvet To: Thierry Reding , Jonathan Hunter Cc: linux-tegra@vger.kernel.org, Nicolas Chauvet Subject: [PATCH 3/4] arm64: tegra: Add missing hot temperatures to tegra132 thermal-zones Date: Mon, 14 Sep 2020 15:37:38 +0200 Message-Id: <20200914133739.60020-4-kwizart@gmail.com> X-Mailer: git-send-email 2.25.4 In-Reply-To: <20200914133739.60020-1-kwizart@gmail.com> References: <20200914133739.60020-1-kwizart@gmail.com> MIME-Version: 1.0 Sender: linux-tegra-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org According to dmesg, thermal-zones for mem and cpu are missing hot temperatures properties. throttrip: pll: missing hot temperature ... throttrip: mem: missing hot temperature ... Adding them will clear the messages. Signed-off-by: Nicolas Chauvet --- arch/arm64/boot/dts/nvidia/tegra132.dtsi | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/arch/arm64/boot/dts/nvidia/tegra132.dtsi b/arch/arm64/boot/dts/nvidia/tegra132.dtsi index e40281510c0c..cd913e59ba26 100644 --- a/arch/arm64/boot/dts/nvidia/tegra132.dtsi +++ b/arch/arm64/boot/dts/nvidia/tegra132.dtsi @@ -925,6 +925,11 @@ mem_shutdown_trip { hysteresis = <1000>; type = "critical"; }; + mem_throttle_trip { + temperature = <99000>; + hysteresis = <1000>; + type = "hot"; + }; }; cooling-maps { @@ -975,6 +980,11 @@ pllx_shutdown_trip { hysteresis = <1000>; type = "critical"; }; + pllx_throttle_trip { + temperature = <99000>; + hysteresis = <1000>; + type = "hot"; + }; }; cooling-maps { From patchwork Mon Sep 14 13:37:39 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicolas Chauvet X-Patchwork-Id: 1363586 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-tegra-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=MGzE+KCl; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4BqnWj0dP9z9sTM for ; Mon, 14 Sep 2020 23:38:57 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726667AbgINNiy (ORCPT ); Mon, 14 Sep 2020 09:38:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58086 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726774AbgINNhw (ORCPT ); Mon, 14 Sep 2020 09:37:52 -0400 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 422FEC061351; Mon, 14 Sep 2020 06:37:52 -0700 (PDT) Received: by mail-wr1-x443.google.com with SMTP id c18so18757936wrm.9; Mon, 14 Sep 2020 06:37:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=07LfpwukpmTeG70upPXM1ceHmoutqYVR0coB+0ggDoI=; b=MGzE+KCln2rDlWU1eor1MDlnrGu6r4T9HJnQcZfGGdYlBsSLzOuOKiZmi/RtTeCWsh PMFpPh35W8yjk3tKQsF4ZvlYO3/Ozbc26pqBrCXTqP6QTscaqsPQ+jor9OAiqd3P8T21 3pMl9gPdP7rXbspX1NNpdGWMDUlsC//0sGdmtcPgEsYf/GpbHoPbDDHikmh9BZAEU4ki EoIZlp6JLAQfC0+ueN8Xv6qnLS5WFOJYj1wzSyzPHkGdN7WPIPDhg2GcW2jttgGr2Xfh 3vaFf8L1Js5VoKx0WLJoIQ7f1OyOwm2JNPU8wcJcIJNLmo/y5ui4b8HSGEuRc6XZopIk w2JA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=07LfpwukpmTeG70upPXM1ceHmoutqYVR0coB+0ggDoI=; b=forROESNbABpZQBdRKnXP97WJU0T6KeQ6pi10CSLjYRXluwyoI0/lKhrE8nv+qU3vH jJZ+xMps5GT9slUeDkPSfeH+yNxV0aZLWp8H4QfdahXbNSdiy2hQ0mow+l5160CZJ+Or 33SugaN4qR1KiIp3/QAJhfWpEiZudJyZkZ4NLbbJHxmGxbL1Mr4Qz4HUIYyca6hbmicq mTV9ADhME1w/HReYlRBTXXs1u6YACzBOYbsf4s3kAD6v6XTcJZFAs1xyEWDb6/+Qc9eT zkqSE98lQAOuiPIPxcqMFOj4QruLjpsQuiAHgMRj8S8JkAJVNRrSyIxjjk7bzT3NWI+d qEpw== X-Gm-Message-State: AOAM533JiGlO09n75PK8B1wUtnXqEe/Et/48K1B2s/5RZJeEsvs3U/mo Z4KyUxBYTh3rHM2hMAdTVoA= X-Google-Smtp-Source: ABdhPJwOX30ps/KDJqJPmeNlxoDcQHCf41blysDKip2XcAupmMDfIO/EoCW16fLZhFmxwma2jVaUNw== X-Received: by 2002:adf:8b1d:: with SMTP id n29mr15420779wra.383.1600090671007; Mon, 14 Sep 2020 06:37:51 -0700 (PDT) Received: from arrakis.kwizart.net (lfbn-nic-1-212-171.w2-15.abo.wanadoo.fr. [2.15.59.171]) by smtp.gmail.com with ESMTPSA id a11sm18532488wmm.18.2020.09.14.06.37.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Sep 2020 06:37:50 -0700 (PDT) From: Nicolas Chauvet To: Thierry Reding , Jonathan Hunter Cc: linux-tegra@vger.kernel.org, Nicolas Chauvet , stable@vger.kernel.org Subject: [PATCH 4/4] ARM: tegra: Avoid setting edp_irq when not relevant Date: Mon, 14 Sep 2020 15:37:39 +0200 Message-Id: <20200914133739.60020-5-kwizart@gmail.com> X-Mailer: git-send-email 2.25.4 In-Reply-To: <20200914133739.60020-1-kwizart@gmail.com> References: <20200914133739.60020-1-kwizart@gmail.com> MIME-Version: 1.0 Sender: linux-tegra-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org According to the binding, the edp_irq is not available on tegra124/132 This commit moves the initialization of tegra->edp_irq after the introduced SoCs condition. This will have the following effects: - soctherm_interrupts_init will not return prematurely with unfinished thermal_irq initialization on tegra124 and tegra132 - edp_irq initialization will be bypassed when not relevant As a result, this will clear the following error when loading the driver: kernel: tegra_soctherm 700e2000.thermal-sensor: IRQ index 1 not found Fixes: 4a04beb1bf2e (thermal: tegra: add support for EDP IRQ) Cc: stable@vger.kernel.org Signed-off-by: Nicolas Chauvet --- drivers/thermal/tegra/soctherm.c | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/drivers/thermal/tegra/soctherm.c b/drivers/thermal/tegra/soctherm.c index 66e0639da4bf..0a7dc988f25f 100644 --- a/drivers/thermal/tegra/soctherm.c +++ b/drivers/thermal/tegra/soctherm.c @@ -2025,12 +2025,6 @@ static int soctherm_interrupts_init(struct platform_device *pdev, return 0; } - tegra->edp_irq = platform_get_irq(pdev, 1); - if (tegra->edp_irq < 0) { - dev_dbg(&pdev->dev, "get 'edp_irq' failed.\n"); - return 0; - } - ret = devm_request_threaded_irq(&pdev->dev, tegra->thermal_irq, soctherm_thermal_isr, @@ -2043,6 +2037,17 @@ static int soctherm_interrupts_init(struct platform_device *pdev, return ret; } + /* None of the tegra124 and tegra132 SoCs have edp_irq */ + if (of_machine_is_compatible("nvidia,tegra124") || + of_machine_is_compatible("nvidia,tegra132")) + return 0; + + tegra->edp_irq = platform_get_irq(pdev, 1); + if (tegra->edp_irq < 0) { + dev_dbg(&pdev->dev, "get 'edp_irq' failed.\n"); + return 0; + } + ret = devm_request_threaded_irq(&pdev->dev, tegra->edp_irq, soctherm_edp_isr,