From patchwork Fri Sep 11 04:05:26 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kaixi Fan X-Patchwork-Id: 1362228 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=140.211.166.136; helo=silver.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=bytedance-com.20150623.gappssmtp.com header.i=@bytedance-com.20150623.gappssmtp.com header.a=rsa-sha256 header.s=20150623 header.b=AMo/Ovam; dkim-atps=neutral Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4Bnhxk4Mdcz9sTS for ; Fri, 11 Sep 2020 14:05:45 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id D65542E1F1; Fri, 11 Sep 2020 04:05:41 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mj4wfEXb6XLC; Fri, 11 Sep 2020 04:05:37 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by silver.osuosl.org (Postfix) with ESMTP id 8DD97207A2; Fri, 11 Sep 2020 04:05:37 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 51543C088B; Fri, 11 Sep 2020 04:05:37 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 08AE1C0052 for ; Fri, 11 Sep 2020 04:05:35 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id E0CD987770 for ; Fri, 11 Sep 2020 04:05:34 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ceJuN1Yn4mgQ for ; Fri, 11 Sep 2020 04:05:33 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from mail-pj1-f67.google.com (mail-pj1-f67.google.com [209.85.216.67]) by hemlock.osuosl.org (Postfix) with ESMTPS id A4B6087750 for ; Fri, 11 Sep 2020 04:05:33 +0000 (UTC) Received: by mail-pj1-f67.google.com with SMTP id mm21so1066745pjb.4 for ; Thu, 10 Sep 2020 21:05:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=snUIgDNmT92uqdlRJvReVTz2vOm2sMCJ1XvZo2LpD4k=; b=AMo/Ovam+8AoH7/Na8Kcw2+SxCDraP3qKvs//Dzc1HHWz42eEwsG8ZqUZo4dAWonyy 30GbzcJvZNhHvh6CpTWpokyUhUf5EEnnhM7pNAB+CANyyAeKw/AA3pp2ml7BwuKv6E7a mHwred/6PnTqz8IImoMDmABVDUvlh6JrKW7gfbBR/iNnZAlZJoCIb2hEVcBC5sZ8A4pW Cw/xDqXVtJX9ifHpTnKeAVc+RRTEvxJZLet1CMoBAAnwnDrJxRqnDrS8rP3zc1Kju3jZ SFWydqZ9Iuap//YJupLrKVRvV4OVdMsR/bqc5rnBjA3+ZxuiatDlcFgYvRF9R3pfITfS RvoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=snUIgDNmT92uqdlRJvReVTz2vOm2sMCJ1XvZo2LpD4k=; b=lPGPjezr9NUaaK/+u60pnFSpkq7+ZbslWn+SyChe+rP6H007ooEs1YFIzHKFohdNzz pZw54+czaN62V64lcauTK9FyhUcKbBbFk6Je/+210L4e4H08zTJVC/HHmxyFb1Zx9arV a7meA8E7N/ydqihO7Ro1g+zZ5ndw5/P3sw1CAC/l44COnJgm1U52UxQgoZfVjM5HEvAO Up2qXhgl6iaEsqxeTdOrXvFJPozCY1Lcm6C5iPNTRVzT4M1WqRDvXsaMhE3Iag2BHldQ zeKGbuOKns43XjS6cP3EXfVeTQeYEFyRdGRoZcHmab+nyls3RWijuEJxizntgyOt8ZyU u42Q== X-Gm-Message-State: AOAM533yV8dIDPxq35Xy8dpyAyZoT5+wYz6LD9yf5qwRgDWBiuxZwuMR ygwVvbmQmG/tHEb0wcNOGMynKiFUVzkS1fbwA1Y= X-Google-Smtp-Source: ABdhPJzltOLdvY45EYDrl9KhcnMillauC+jfRNXj5G4zgGhf1RN0YnTXaO8NyOiNvk6irrBGNgL1yg== X-Received: by 2002:a17:90b:816:: with SMTP id bk22mr471969pjb.66.1599797133171; Thu, 10 Sep 2020 21:05:33 -0700 (PDT) Received: from MacBook-Pro-3.local.net ([103.136.221.68]) by smtp.gmail.com with ESMTPSA id q20sm458974pgi.70.2020.09.10.21.05.31 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 10 Sep 2020 21:05:32 -0700 (PDT) From: fankaixi.li@bytedance.com To: dev@openvswitch.org, aconole@redhat.com Date: Fri, 11 Sep 2020 12:05:26 +0800 Message-Id: <20200911040526.27884-1-fankaixi.li@bytedance.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) MIME-Version: 1.0 Subject: [ovs-dev] [PATCH] ofproto-dpif: remove checking setting nd_ext field X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" From: "fankaixi.li" In order to support openflow rule which setting nd_ext fields in openflow tables, we should remove setting nd_ext fields when constructing rule. The ofproto would translate it into userspace actions when handling upcalls. Signed-off-by: fankaixi.li Signed-off-by: fankaixi.li > --- This is effectively trying to revert: --- ofproto/ofproto-dpif.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c index 4f0638f23..f4c37f43d 100644 --- a/ofproto/ofproto-dpif.c +++ b/ofproto/ofproto-dpif.c @@ -4637,14 +4637,6 @@ check_actions(const struct ofproto_dpif *ofproto, "ct original direction tuple"); return OFPERR_NXBAC_CT_DATAPATH_SUPPORT; } - } else if (!support->nd_ext && ofpact->type == OFPACT_SET_FIELD) { - const struct mf_field *dst = ofpact_get_mf_dst(ofpact); - - if (dst->id == MFF_ND_RESERVED || dst->id == MFF_ND_OPTIONS_TYPE) { - report_unsupported_act("set field", - "setting IPv6 ND Extensions fields"); - return OFPERR_OFPBAC_BAD_SET_ARGUMENT; - } } }