From patchwork Thu Sep 10 10:04:06 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kleber Sacilotto de Souza X-Patchwork-Id: 1361399 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=canonical.com Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4BnF064wfcz9sTX; Thu, 10 Sep 2020 20:06:14 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1kGJSz-0006Ys-5n; Thu, 10 Sep 2020 10:06:09 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1kGJSx-0006Yl-6o for kernel-team@lists.ubuntu.com; Thu, 10 Sep 2020 10:06:07 +0000 Received: from mail-ej1-f70.google.com ([209.85.218.70]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1kGJR4-0006Jx-Sc for kernel-team@lists.ubuntu.com; Thu, 10 Sep 2020 10:04:10 +0000 Received: by mail-ej1-f70.google.com with SMTP id rs9so2494943ejb.17 for ; Thu, 10 Sep 2020 03:04:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=qOggEHMNvQD0AuJpg+v5sUxAB3rFWf/GjLQUekR8wkw=; b=LqNJLtdCS1uJDEote75Cnob8RjAXwb/f1wtvyQ/GaEZM+MqiFS82jAQImPcfbE4IEd 3tMusJIBURGONl8qr5ceNsyddekpYb1aXydKa5wi5ZFMKDaaZP6G8fVbWhZCuARHl4oB Qa0YIdbBUfmISmNOQahjqYXHoWCejrsCtWUqil/TDX10RVRU7ODY7t7pnPUUNkyPeP/B AFAU6YTh6aFrfRHDExFw03UHfWzo/Fsrj6eovqQ0NBF62uCGe//rIwC7xhdiyvInahty 13t/Ibx0QNxyPmttWEb6Rbyq70pneKG4ev4xLg6hOvygf9pVX4xmdIbu6PvW9Lmlbgob DS1Q== X-Gm-Message-State: AOAM533z0W9/XuXfdnlEMYA3BUGrUejT8xM5QTUTuhVxDqnqiDqKPASd xDLIj0SLFwUiv5sR5uIgTxrvugGXgaAnoX1ydeb5zdlTd0jjVTTSHOnEiDOCXGm5fWwmuzvFPOc Lo/5iR9AgQLM+ssxm+zcaasES+/25vDZ3Qj2sInFypA== X-Received: by 2002:a17:906:e4f:: with SMTP id q15mr8409778eji.155.1599732250334; Thu, 10 Sep 2020 03:04:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw5dEoZyomLoI7BOtUtCK2ZOMW5CXLmYLdKNWrk6PiasrBzQctJ5DySe2BvgENlSggszWXq7g== X-Received: by 2002:a17:906:e4f:: with SMTP id q15mr8409762eji.155.1599732250159; Thu, 10 Sep 2020 03:04:10 -0700 (PDT) Received: from localhost.localdomain ([2a02:8109:98c0:1604:84da:ab80:90a2:805]) by smtp.gmail.com with ESMTPSA id e16sm6289760ejk.68.2020.09.10.03.04.09 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Sep 2020 03:04:09 -0700 (PDT) From: Kleber Sacilotto de Souza To: kernel-team@lists.ubuntu.com Subject: [PATCH 1/1] UBUNTU: SAUCE: Revert "mm/slub: fix a memory leak in sysfs_slab_add()" Date: Thu, 10 Sep 2020 12:04:06 +0200 Message-Id: <20200910100406.758051-2-kleber.souza@canonical.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200910100406.758051-1-kleber.souza@canonical.com> References: <20200910100406.758051-1-kleber.souza@canonical.com> MIME-Version: 1.0 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" BugLink: https://bugs.launchpad.net/bugs/1895109 This reverts commit 8d392dd31bd9205986b442528014c6eec3851491 (commit dde3c6b72a16c2db826f54b2d49bdea26c3534a2 upstream). It has been found that linux 5.4.0-45 introduced a regression that is causing oops when starting LVM snapshots (LP #1894780). A fix for this issue hasn't been found yet, but reverting dde3c6b72a16 "mm/slub: fix a memory leak in sysfs_slab_add()" at least doesn't crash one of the affected systems anymore. Signed-off-by: Kleber Sacilotto de Souza Acked-by: Thadeu Lima de Souza Cascardo Acked-by: Andy Whitcroft --- mm/slub.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/mm/slub.c b/mm/slub.c index 709e31002504..434e4c6aca80 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -5804,10 +5804,8 @@ static int sysfs_slab_add(struct kmem_cache *s) s->kobj.kset = kset; err = kobject_init_and_add(&s->kobj, &slab_ktype, NULL, "%s", name); - if (err) { - kobject_put(&s->kobj); + if (err) goto out; - } err = sysfs_create_group(&s->kobj, &slab_attr_group); if (err)