From patchwork Wed Sep 9 10:04:14 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Barker X-Patchwork-Id: 1360521 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.a=rsa-sha256 header.s=google header.b=boqs782B; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4Bmd0s0thtz9sTd for ; Wed, 9 Sep 2020 20:04:45 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728015AbgIIKEo (ORCPT ); Wed, 9 Sep 2020 06:04:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53398 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726060AbgIIKEf (ORCPT ); Wed, 9 Sep 2020 06:04:35 -0400 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6F02BC061755 for ; Wed, 9 Sep 2020 03:04:35 -0700 (PDT) Received: by mail-wm1-x344.google.com with SMTP id y15so1753200wmi.0 for ; Wed, 09 Sep 2020 03:04:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=GwN0+i/cI/n/+0mqzm/sKQPMpFX4gdPhYIC5uk3bMbQ=; b=boqs782B2W+C5l6qBV381hB/DTlNglszD1gTKGL5qNNp2eEM8I2dRcEOBQq90bZJRM GAvUYHNAibM2oWAPWSzZYJC1Or5MRZqhOezyQXteQvSoD2quJTkK/EgQBVAz0j3lWMpy zdMLJYUuyLGEg8pjez6mKMMFtQH7zvNFrWUf4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=GwN0+i/cI/n/+0mqzm/sKQPMpFX4gdPhYIC5uk3bMbQ=; b=d+7cFuQiOWzb9M/HH9jpC55vF7l2H3bN3Shh5DvUx9x2iv2AekmQOlK8qFm0ZXscfr Gm/YJPRl+Q3Vp7OsrfniDtDh0Yb6bQepgB+wfFWq4YX5XW/i2ZBf5MMXcxWwx9Vc93c3 x5Z5cuszFbE1ig7BtF5slDXiMhE6m2dLu/4YmukV146NGAcmIH06bAx6rxEskOKXtVR6 m6kUIB2PlhInCHPqSI4MLoHDglw6qT7MfuL5bptNxaItAPPTxC0hNUBqy7KMlN0ZfxOd w+MKPN7qGkieMY56wmXLvcXG9Dw0KtvZhKdpGopYdgUblrxHbUhUGCOEFKhPvWp6nk3/ swlg== X-Gm-Message-State: AOAM533zRiYJbgAXqn7Cw98+E56rgw76jM1HPt0KJcMK6hpRqP/O9xMy scKtVsocLXdq8F7E/4hA/mEM3w== X-Google-Smtp-Source: ABdhPJxRg3eSGd/mkl5lmr8frJ6I4Rdr+h739do/YtaV3JyH4Mz2h4mMjHbszBUgUoPv0gQMACrafg== X-Received: by 2002:a7b:c404:: with SMTP id k4mr2247339wmi.168.1599645874087; Wed, 09 Sep 2020 03:04:34 -0700 (PDT) Received: from ar2.home.b5net.uk ([213.48.11.149]) by smtp.gmail.com with ESMTPSA id l16sm3828237wrb.70.2020.09.09.03.04.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Sep 2020 03:04:33 -0700 (PDT) From: Paul Barker To: Woojung Huh , Microchip Linux Driver Support , Andrew Lunn , Vivien Didelot , Florian Fainelli , "David S . Miller" Cc: Paul Barker , netdev@vger.kernel.org Subject: [PATCH v3 1/4] net: dsa: microchip: Make switch detection more informative Date: Wed, 9 Sep 2020 11:04:14 +0100 Message-Id: <20200909100417.380011-2-pbarker@konsulko.com> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200909100417.380011-1-pbarker@konsulko.com> References: <20200909100417.380011-1-pbarker@konsulko.com> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org To make switch detection more informative print the result of the ksz9477/ksz9893 compatibility check. With debug output enabled also print the contents of the Chip ID registers as a 40-bit hex string. As this detection is the first communication with the switch performed by the driver, making it easy to see any errors here will help identify issues with SPI data corruption or reset sequencing. Signed-off-by: Paul Barker Reviewed-by: Florian Fainelli --- drivers/net/dsa/microchip/ksz9477.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/dsa/microchip/ksz9477.c b/drivers/net/dsa/microchip/ksz9477.c index 3cb22d149813..df5ecd0261fa 100644 --- a/drivers/net/dsa/microchip/ksz9477.c +++ b/drivers/net/dsa/microchip/ksz9477.c @@ -1426,10 +1426,12 @@ static int ksz9477_switch_detect(struct ksz_device *dev) /* Default capability is gigabit capable. */ dev->features = GBIT_SUPPORT; + dev_dbg(dev->dev, "Switch detect: ID=%08x%02x\n", id32, data8); id_hi = (u8)(id32 >> 16); id_lo = (u8)(id32 >> 8); if ((id_lo & 0xf) == 3) { /* Chip is from KSZ9893 design. */ + dev_info(dev->dev, "Found KSZ9893\n"); dev->features |= IS_9893; /* Chip does not support gigabit. */ @@ -1438,6 +1440,7 @@ static int ksz9477_switch_detect(struct ksz_device *dev) dev->mib_port_cnt = 3; dev->phy_port_cnt = 2; } else { + dev_info(dev->dev, "Found KSZ9477 or compatible\n"); /* Chip uses new XMII register definitions. */ dev->features |= NEW_XMII; From patchwork Wed Sep 9 10:04:15 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Barker X-Patchwork-Id: 1360524 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.a=rsa-sha256 header.s=google header.b=UHT9gTAg; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4Bmd1236VGz9sTd for ; Wed, 9 Sep 2020 20:04:54 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728617AbgIIKEv (ORCPT ); Wed, 9 Sep 2020 06:04:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53406 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726738AbgIIKEg (ORCPT ); Wed, 9 Sep 2020 06:04:36 -0400 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 519E4C061573 for ; Wed, 9 Sep 2020 03:04:36 -0700 (PDT) Received: by mail-wr1-x443.google.com with SMTP id s12so2248580wrw.11 for ; Wed, 09 Sep 2020 03:04:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=bST50jPUwwDbLj27TviEZuypDFBCzjiM5n9VtcnbuZM=; b=UHT9gTAgpBxTv3X6pgQVeGk+imoZE95jfZsjtisjtSpTfnVQoNE41s3zQUMjkG68HG YXu5brpRIMCOOJNGHZ9aF2xfjR8P+TMrhAmWzD9BWpnmA9jfgdktLtTvo+dWm81fImGv l2AdpwnNK1ecOpbRuOt02/qOe69SLhfvTByTI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=bST50jPUwwDbLj27TviEZuypDFBCzjiM5n9VtcnbuZM=; b=r5h8w7kT/zH41EIXfrR7wLYsKDNP5qrdpqvu3Wm89At+c32zCwOc0b2CZV7XbHumIw 0y18MwPi0Lhk+/s8BZ74LzYNINkEx5FXzOfBas9TF762DWNQwBVWoL4arqaSb4xMsxWa Zd5GKJekKnB8NlCiFqkQdzZ6nd7aDAB5sq4kYPhGNNSrTLV+wMBm8PZmR891+GRgiJL/ Jn1lGLGsD5OafHoygyBeDyXVDVHkFFReTqnDU0XkoP2ReZNxb0K8626o5DSDBfMo88D1 ZL0ZUg8qtW6WSByIFEW+mr/utiL4OTlwJ7soTNkmQCIJ456JncnqkPYg2KkfcrqqSpDZ 46CQ== X-Gm-Message-State: AOAM532rpkBkWe5V1vBq/GkzAI4UnY9YyjY/bVHXaBfnTozewjPhbYlJ EX1KIr5PXMbzrYXVE7P+XoeZ+g== X-Google-Smtp-Source: ABdhPJys3pAB4tPYiZdEm8+rygJLQR60Yww4bsCJ7vS0G5oCcUokF7jYzM423STnuq8saYzv5p1fpg== X-Received: by 2002:adf:f0c3:: with SMTP id x3mr2968847wro.163.1599645875045; Wed, 09 Sep 2020 03:04:35 -0700 (PDT) Received: from ar2.home.b5net.uk ([213.48.11.149]) by smtp.gmail.com with ESMTPSA id l16sm3828237wrb.70.2020.09.09.03.04.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Sep 2020 03:04:34 -0700 (PDT) From: Paul Barker To: Woojung Huh , Microchip Linux Driver Support , Andrew Lunn , Vivien Didelot , Florian Fainelli , "David S . Miller" Cc: Paul Barker , netdev@vger.kernel.org Subject: [PATCH v3 2/4] net: dsa: microchip: Improve phy mode message Date: Wed, 9 Sep 2020 11:04:15 +0100 Message-Id: <20200909100417.380011-3-pbarker@konsulko.com> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200909100417.380011-1-pbarker@konsulko.com> References: <20200909100417.380011-1-pbarker@konsulko.com> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Always print the selected phy mode for the CPU port when using the ksz9477 driver. If the phy mode was changed, also print the previous mode to aid in debugging. To make the message more clear, prefix it with the port number which it applies to and improve the language a little. Signed-off-by: Paul Barker Reviewed-by: Florian Fainelli --- drivers/net/dsa/microchip/ksz9477.c | 20 +++++++++++++++----- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/drivers/net/dsa/microchip/ksz9477.c b/drivers/net/dsa/microchip/ksz9477.c index df5ecd0261fa..d9030820f406 100644 --- a/drivers/net/dsa/microchip/ksz9477.c +++ b/drivers/net/dsa/microchip/ksz9477.c @@ -1265,6 +1265,8 @@ static void ksz9477_config_cpu_port(struct dsa_switch *ds) for (i = 0; i < dev->port_cnt; i++) { if (dsa_is_cpu_port(ds, i) && (dev->cpu_ports & (1 << i))) { phy_interface_t interface; + const char *prev_msg; + const char *prev_mode; dev->cpu_port = i; dev->host_mask = (1 << dev->cpu_port); @@ -1277,11 +1279,19 @@ static void ksz9477_config_cpu_port(struct dsa_switch *ds) interface = ksz9477_get_interface(dev, i); if (!dev->interface) dev->interface = interface; - if (interface && interface != dev->interface) - dev_info(dev->dev, - "use %s instead of %s\n", - phy_modes(dev->interface), - phy_modes(interface)); + if (interface && interface != dev->interface) { + prev_msg = " instead of "; + prev_mode = phy_modes(interface); + } else { + prev_msg = ""; + prev_mode = ""; + } + dev_info(dev->dev, + "Port%d: using phy mode %s%s%s\n", + i, + phy_modes(dev->interface), + prev_msg, + prev_mode); /* enable cpu port */ ksz9477_port_setup(dev, i, true); From patchwork Wed Sep 9 10:04:16 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Barker X-Patchwork-Id: 1360522 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.a=rsa-sha256 header.s=google header.b=pzRtUs8d; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4Bmd0w2tyVz9sTd for ; Wed, 9 Sep 2020 20:04:48 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728297AbgIIKEq (ORCPT ); Wed, 9 Sep 2020 06:04:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53408 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726489AbgIIKEh (ORCPT ); Wed, 9 Sep 2020 06:04:37 -0400 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 38B98C061756 for ; Wed, 9 Sep 2020 03:04:37 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id c18so2252654wrm.9 for ; Wed, 09 Sep 2020 03:04:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=LGeU/vJL/f5HgWZfciM0jx6EU8z61LOkoh55rEs730Y=; b=pzRtUs8dWCx81NUeyb7kC2n1uGn/AwO0KBl3W+XCiucnIgQ/NNHmBeXyQIgNhnrYmJ ZkbjD0NuvbSSsIB18vRzBJ90O25PWv9SPlOwuT8smcdpvwmL9NvaZiCx7Hb/t6B8yZuv H45QNweUvdkz1BGDa4yt+0TUcyIknszbK8//M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=LGeU/vJL/f5HgWZfciM0jx6EU8z61LOkoh55rEs730Y=; b=hs0pC+Pcic+O/Xf1/P0Arp7sIoL7Q3D/L69wWIdUViClytwkiyYRCfFkKY3oUDFcuj VpY/gmxuzkisNTCqjZ7rpb3scXfk6zB96sfVcl71zpKkfcZPry15+dFXeRmqL0ULYAcn sF3/pbXRKW4n6MGu7qdZolAfufnB0F7Q5pQ1GnRHWQw88nfYlUhfHeqKQWY/60az3Wht sHfD7DsE3odpcQI1lcKNh+8vBhZ4rc3mSrrkvo2wxFQNdnAPFeYiJdvHG9Thf6OUSeJ1 NWS1CgQbav4/dvIT1W1gtBx8OJDaXZl6PBl7FuuGivUoZTGCtBwi6Ate+WP/OPYSztjU 32sw== X-Gm-Message-State: AOAM5309eezwlBSQALTUodRhEoYvg579caCC1eUGXIX1G7nPHBqGcgkJ PftFdWmcX/npU7WAiXHwC0+/tw== X-Google-Smtp-Source: ABdhPJwV7e5Tu7XexdXj8FFpbwPXswSxL1UrIH6lpUoRdjTUZJmw4zY4SXwosMwlHgq4mzWirnX2yw== X-Received: by 2002:a05:6000:1ce:: with SMTP id t14mr2861161wrx.195.1599645875961; Wed, 09 Sep 2020 03:04:35 -0700 (PDT) Received: from ar2.home.b5net.uk ([213.48.11.149]) by smtp.gmail.com with ESMTPSA id l16sm3828237wrb.70.2020.09.09.03.04.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Sep 2020 03:04:35 -0700 (PDT) From: Paul Barker To: Woojung Huh , Microchip Linux Driver Support , Andrew Lunn , Vivien Didelot , Florian Fainelli , "David S . Miller" Cc: Paul Barker , netdev@vger.kernel.org Subject: [PATCH v3 3/4] net: dsa: microchip: Disable RGMII in-band status on KSZ9893 Date: Wed, 9 Sep 2020 11:04:16 +0100 Message-Id: <20200909100417.380011-4-pbarker@konsulko.com> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200909100417.380011-1-pbarker@konsulko.com> References: <20200909100417.380011-1-pbarker@konsulko.com> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org We can't assume that the link partner supports the in-band status reporting which is enabled by default on the KSZ9893 when using RGMII for the upstream port. Signed-off-by: Paul Barker Reviewed-by: Andrew Lunn Reviewed-by: Florian Fainelli --- drivers/net/dsa/microchip/ksz9477.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/dsa/microchip/ksz9477.c b/drivers/net/dsa/microchip/ksz9477.c index d9030820f406..b62dd64470a8 100644 --- a/drivers/net/dsa/microchip/ksz9477.c +++ b/drivers/net/dsa/microchip/ksz9477.c @@ -1235,6 +1235,9 @@ static void ksz9477_port_setup(struct ksz_device *dev, int port, bool cpu_port) if (dev->interface == PHY_INTERFACE_MODE_RGMII_ID || dev->interface == PHY_INTERFACE_MODE_RGMII_TXID) data8 |= PORT_RGMII_ID_EG_ENABLE; + /* On KSZ9893, disable RGMII in-band status support */ + if (dev->features & IS_9893) + data8 &= ~PORT_MII_MAC_MODE; p->phydev.speed = SPEED_1000; break; } From patchwork Wed Sep 9 10:04:17 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Barker X-Patchwork-Id: 1360523 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.a=rsa-sha256 header.s=google header.b=EsiWTg2D; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4Bmd0x3tM0z9sTg for ; Wed, 9 Sep 2020 20:04:49 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728360AbgIIKEs (ORCPT ); Wed, 9 Sep 2020 06:04:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53414 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726399AbgIIKEi (ORCPT ); Wed, 9 Sep 2020 06:04:38 -0400 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2A7F9C061755 for ; Wed, 9 Sep 2020 03:04:38 -0700 (PDT) Received: by mail-wr1-x441.google.com with SMTP id c18so2252701wrm.9 for ; Wed, 09 Sep 2020 03:04:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=pRUN7p1qzh/z0sF2kkFkWXZEvmC67k/rtM33VZEr1RY=; b=EsiWTg2DgucOy7ksi0tfoaZP/MIDdLVdJK6TrCTZfdujWCAm0vtNaoQsxNyys0HHjk UN/wZNC1fFhLtMWN+LqYZLyzaHHa7QBPfVqxj0zSMTOqwF4DSYX5WDXnEPP2otEm4VgA +IKEqwFdqSbPfJrSTn/N4fMX11qScykaIqZig= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=pRUN7p1qzh/z0sF2kkFkWXZEvmC67k/rtM33VZEr1RY=; b=dPZlpcaOn5fxpofMjKluvkenic6RPMb4hZKYUk6o63Na1MwFDC/J9iWQSTO6Supy6g doSYyjZKtQnNtpOKyMp5lF/7jBakenwXFlz/zzHynkMF9gjlk8qCezgOr6ap7LNueWcK NojvAcfA4JgCigfsF14KlyHYGjgp7i8QKoWMH5ZQGvOrmjc0+UiINk/G8ubyUlBtKFBS GaHoYnl6uXMnYMr5mn6gtKooiGaza4YtCyLU2cV6xihMroS33oGutIkE1FEJX/71QWCP VB8Ctmg6nwczg4YbNDk9rUmsUOyVLG/306rrD1HJa4lLkMy41pohcqCEbPGzt19KL9Qs H7cw== X-Gm-Message-State: AOAM533m3ITvj9ZMAoqdM+oonvvtqOqyI0V1UNFhJM/ykn1AsJUwbpqi RnsbKZAUTnTzQBw199b3etpOqA== X-Google-Smtp-Source: ABdhPJzswvZt4mmoAPxtvxnzDKiIP+BRMmg7AkmT1c0NdWDTfK22qJv1fOUxhe0V0WqcmqSOfNvRqg== X-Received: by 2002:a5d:60cc:: with SMTP id x12mr3132553wrt.84.1599645876890; Wed, 09 Sep 2020 03:04:36 -0700 (PDT) Received: from ar2.home.b5net.uk ([213.48.11.149]) by smtp.gmail.com with ESMTPSA id l16sm3828237wrb.70.2020.09.09.03.04.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Sep 2020 03:04:36 -0700 (PDT) From: Paul Barker To: Woojung Huh , Microchip Linux Driver Support , Andrew Lunn , Vivien Didelot , Florian Fainelli , "David S . Miller" Cc: Paul Barker , netdev@vger.kernel.org Subject: [PATCH v3 4/4] net: dsa: microchip: Implement recommended reset timing Date: Wed, 9 Sep 2020 11:04:17 +0100 Message-Id: <20200909100417.380011-5-pbarker@konsulko.com> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200909100417.380011-1-pbarker@konsulko.com> References: <20200909100417.380011-1-pbarker@konsulko.com> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The datasheet for the ksz9893 and ksz9477 switches recommend waiting at least 100us after the de-assertion of reset before trying to program the device through any interface. Also switch the existing msleep() call to usleep_range() as recommended in Documentation/timers/timers-howto.rst. The 2ms range used here is somewhat arbitrary, as long as the reset is asserted for at least 10ms we should be ok. Signed-off-by: Paul Barker Reviewed-by: Florian Fainelli --- drivers/net/dsa/microchip/ksz_common.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/dsa/microchip/ksz_common.c b/drivers/net/dsa/microchip/ksz_common.c index 8d53b12d40a8..a31738662d95 100644 --- a/drivers/net/dsa/microchip/ksz_common.c +++ b/drivers/net/dsa/microchip/ksz_common.c @@ -400,8 +400,9 @@ int ksz_switch_register(struct ksz_device *dev, if (dev->reset_gpio) { gpiod_set_value_cansleep(dev->reset_gpio, 1); - mdelay(10); + usleep_range(10000, 12000); gpiod_set_value_cansleep(dev->reset_gpio, 0); + usleep_range(100, 1000); } mutex_init(&dev->dev_mutex);