From patchwork Mon Sep 7 16:15:01 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrea Corallo X-Patchwork-Id: 1359039 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=sourceware.org; envelope-from=gcc-patches-bounces@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=armh.onmicrosoft.com header.i=@armh.onmicrosoft.com header.a=rsa-sha256 header.s=selector2-armh-onmicrosoft-com header.b=HcpR4KuS; dkim=pass (1024-bit key) header.d=armh.onmicrosoft.com header.i=@armh.onmicrosoft.com header.a=rsa-sha256 header.s=selector2-armh-onmicrosoft-com header.b=HcpR4KuS; dkim-atps=neutral Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4BlYKR4hHDz9sRK for ; Tue, 8 Sep 2020 02:15:23 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7746C393C86E; Mon, 7 Sep 2020 16:15:19 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2075.outbound.protection.outlook.com [40.107.22.75]) by sourceware.org (Postfix) with ESMTPS id C6B913894C18 for ; Mon, 7 Sep 2020 16:15:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org C6B913894C18 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=Andrea.Corallo@arm.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IZMREE0OBNNxmYw/woiECKFRNWC2NFhdmiMABfDoPkI=; b=HcpR4KuS+ISrYvdx9J5TRg8Yc47s2xTd2sA+RXUtZWC/m52AyFw9g5MVq+qAGzgQK6hw0z1RJUyarUMlHPRGseuS12jB2BUvtQuyAbiG1LR9bi7Cj9VPl7ptQ2rsMw7Th2wxCyBBhNmkkmDS66xq4HpakWoxGXG6rtQ39y1z4gM= Received: from AM6P191CA0038.EURP191.PROD.OUTLOOK.COM (2603:10a6:209:7f::15) by VI1PR08MB3821.eurprd08.prod.outlook.com (2603:10a6:803:b7::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3348.15; Mon, 7 Sep 2020 16:15:14 +0000 Received: from AM5EUR03FT043.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:7f:cafe::5a) by AM6P191CA0038.outlook.office365.com (2603:10a6:209:7f::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3348.15 via Frontend Transport; Mon, 7 Sep 2020 16:15:14 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; gcc.gnu.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;gcc.gnu.org; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT043.mail.protection.outlook.com (10.152.17.43) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3348.16 via Frontend Transport; Mon, 7 Sep 2020 16:15:14 +0000 Received: ("Tessian outbound 7161e0c2a082:v64"); Mon, 07 Sep 2020 16:15:14 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 8c78c00e11f12d2b X-CR-MTA-TID: 64aa7808 Received: from 63e48c51c760.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 096C88ED-1C42-4662-A0B7-6DB02BD14D10.1; Mon, 07 Sep 2020 16:15:07 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 63e48c51c760.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 07 Sep 2020 16:15:07 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bQGUYwXm5JQHPUcIFd1f9gX+v6sANbsAkhECq8rWBiqTvSovpplL/lNpcY9f/5dOVvc1bPPe4TwtK/KaOUdKyngnK7lINf13zrO871o6GWC2Ez44hCI5XmVLMtQMdyzgNwpnyhpofXZBydQIrgusijNFXD24ROntdynLtgyxjS7kOLdNKqVFkwU+pDGsjAbAycrdbQQCXad1E5/K19hrmtmMumT1exuzKBBiirIKq9dEKJvjxHtrLYMJ1nAjUcSKK5Z1CBl6qUhTJc82N6gQOi7M6F/NBGxLMyamTKruFZ9isvbPdgfPyx7TP3/t3NRCSF44YfHXTRsvoa3tEIyVwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IZMREE0OBNNxmYw/woiECKFRNWC2NFhdmiMABfDoPkI=; b=Ie4qlVhLiHEK+LdGr6sqHYh4XT+LgjaWqCdu1G71zT0lBzO2eYS+jNJvmbRPrpAVyX0V+bbqro09ZYfewyZPUjuJis6GDWINyvBnLxPLHTYLHa1Pkhmlcza+ohyY1Er/8pZPfFAP2IiM+5viUdX0lK4+xfdPzsB1lHL3hEjKZUT27/1E1TAJJvwB8m95Y0kChJ81XXBSQtA7bs8vu66/H6q1Y3AKAip3zunvBaUbH6b2T35YtR7lakTbQ2tC6yeqDQu6OIZf+JhBWrhLOnCZkD8b3O0RvnCjrkUioeexNS+xTOMItChXQizBMiiq6TbFOAWcHOhm2pZ3VM/pR8P6kw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IZMREE0OBNNxmYw/woiECKFRNWC2NFhdmiMABfDoPkI=; b=HcpR4KuS+ISrYvdx9J5TRg8Yc47s2xTd2sA+RXUtZWC/m52AyFw9g5MVq+qAGzgQK6hw0z1RJUyarUMlHPRGseuS12jB2BUvtQuyAbiG1LR9bi7Cj9VPl7ptQ2rsMw7Th2wxCyBBhNmkkmDS66xq4HpakWoxGXG6rtQ39y1z4gM= Authentication-Results-Original: linux.ibm.com; dkim=none (message not signed) header.d=none; linux.ibm.com; dmarc=none action=none header.from=arm.com; Received: from AM6PR08MB4900.eurprd08.prod.outlook.com (2603:10a6:20b:cc::10) by AM6PR08MB5157.eurprd08.prod.outlook.com (2603:10a6:20b:e8::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3348.16; Mon, 7 Sep 2020 16:15:04 +0000 Received: from AM6PR08MB4900.eurprd08.prod.outlook.com ([fe80::d070:f136:4090:9ed3]) by AM6PR08MB4900.eurprd08.prod.outlook.com ([fe80::d070:f136:4090:9ed3%5]) with mapi id 15.20.3348.019; Mon, 7 Sep 2020 16:15:04 +0000 From: Andrea Corallo To: richard.sandiford@arm.com Subject: [PATCH] vec: Revert "dead code removal in tree-vect-loop.c" and add a comment. References: Date: Mon, 07 Sep 2020 18:15:01 +0200 In-Reply-To: (Richard Sandiford's message of "Mon, 07 Sep 2020 12:16:45 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) X-ClientProxiedBy: LO2P265CA0419.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a0::23) To AM6PR08MB4900.eurprd08.prod.outlook.com (2603:10a6:20b:cc::10) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from e112547 (217.140.99.251) by LO2P265CA0419.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a0::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3348.15 via Frontend Transport; Mon, 7 Sep 2020 16:15:03 +0000 X-Originating-IP: [217.140.99.251] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: dd847f69-8e66-41dc-4da2-08d8534933fa X-MS-TrafficTypeDiagnostic: AM6PR08MB5157:|VI1PR08MB3821: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:9508;OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: vE23Q9/xe3SvcV0fL5Okvx/3QmEzOfrAUk8os+8rCGGaeIqvZZ9J/+a9PJGCR2ybbLM28mhapmiDpllDOdFDL+RqOpUNl0QZfbWBRdFAKHMGHWFxxXQdDGy4QGMlk1fbyeAlCgFE0k0HqKx82HeS2F29z6hmYuqpPqtUVTOupUtcMUpC6SUN2p18X9JVLVcUuAdHqf7/Hr4U4xmrgd0E9OSlwA9txn78whqA4x43sSyLw5G6gi1OguoScues5nCFxN0hJvW4eGHBa6CA2ew9O05YL1KC0dqKyqy9M8WY661pRycOg4eU76jmeUwenm6R X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM6PR08MB4900.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(136003)(376002)(366004)(396003)(346002)(66476007)(66946007)(37006003)(26005)(8676002)(8936002)(86362001)(4326008)(34206002)(16526019)(6486002)(186003)(564344004)(44832011)(2616005)(66616009)(5660300002)(66556008)(36756003)(235185007)(478600001)(52116002)(6636002)(2906002)(33964004)(956004)(316002)(6496006); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: reEcp+ZOtYKGBRvnjy2xPVSUGs2s06ROkS/1eZN6Rgjq4dXVg4n6dwzAd/jqcWb/dTFYE8BTdjrKl229Jm/HyOVEmc/fwI9uYCzGE+83PYMipO2kTcuP52KAD1zh6nSGoBU3RDezuYDGL+sxXeWd/TS6NuydECcxOCqjYMF3DaXCsyPfELu9fQIDS7aSjeDKih86ZYnRhrCTQLhxNz6KWe1BJPSLzb686Df3VZE/kszCvZjGYOF4EaTO5HdFzxjqO/RZOOWhanbOK11w41/P4Dir6IJCNkoRAQrRHqh8gozQ9llejXPJqMRDdgdzMfoedZGUz0tSWM7HV3vtAk7M4r/dT6Pfup/50vIC64mD9zimVyHdfW3hFJwHyCBNaGb9FRXSOmUKJkvBU6OmvXPkeDeZstJ6rN9rjcngvuGf/W52aDb7wboOZ0mrQX883AmVdaREpdaQIjnVBxpU13QZYM2wCbtR/gpQ9wGhxZSLYA/Y0katQKUNXZrFPGQZ3OYsgMRH1NWh/L42ubh2Z7ukiY2CbqDPIGISGI7xxo60bMv00nmPhPLSKtSne+1OrbcA+Sf4NHoUJgBQ8pKy2kLGrK80kp2k4M6ZA8o/czznMU9i4eRWXvdWMZ/oSl+JTuyx4S8HF3EiJ1q9bmcq8/FO7Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB5157 Original-Authentication-Results: linux.ibm.com; dkim=none (message not signed) header.d=none; linux.ibm.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT043.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 845e8629-47de-43f7-279f-08d853492e1a X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6jw1VmaBFdDWIhFT4P4ey5qADNV98xyHef7ifqx/inX04YfwBxbc/Q4Lq1s7x5fvEVYjbdwwY1tMLbgkfZUwHHQoopamZqMnQot73Cs5Skz5Z2+qVpMTj/F7ajRONzcJyZA0XwDJCLuKVz89+IL62GnWMgx0bh1P++z+VxNpp/D6UYAljJoyX2jlVHGJLsVuxBSEdCbzITS7Q3PzX04JIBWay5O1kaRePnJlRaV6ifdCVS9k7+QSbaHkuGAcv9LYv4hdiuMWYK0R30qijr0ATI5gdTR9pbLjxgzea5z5BWEtIGE5IBsWbWBKQY4fjR0IXXPG47T4mA+8dX5uEPGNU/ki89Mu1NG64HTENuexy6yQgzHNDQEE/KGJjDax4lKJo6XjRApCo18/jPMWt8wybA== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(396003)(346002)(376002)(39860400002)(136003)(46966005)(478600001)(26005)(6486002)(186003)(8676002)(16526019)(6496006)(4326008)(316002)(8936002)(336012)(86362001)(956004)(33964004)(2906002)(36906005)(2616005)(70586007)(66616009)(70206006)(36756003)(44832011)(235185007)(5660300002)(82310400003)(82740400003)(37006003)(34206002)(6636002)(564344004)(356005)(81166007)(47076004); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2020 16:15:14.2086 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: dd847f69-8e66-41dc-4da2-08d8534933fa X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT043.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3821 X-Spam-Status: No, score=-14.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, MSGID_FROM_MTA_HEADER, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: rguenther@suse.de, nd@arm.com, gcc-patches@gcc.gnu.org, ook@ucw.cz Errors-To: gcc-patches-bounces@gcc.gnu.org Sender: "Gcc-patches" Hi Richard, this reverts the discussed patch and adds what was suggested as a comment. Apologies for the inconvenience, okay for trunk? Thanks Andrea From 84dfa2d461692f445f45b3c3498f9bedba5c3848 Mon Sep 17 00:00:00 2001 From: Andrea Corallo Date: Mon, 7 Sep 2020 13:45:47 +0100 Subject: [PATCH] vec: Revert "dead code removal in tree-vect-loop.c" and add a comment. gcc/ChangeLog 2020-09-07 Andrea Corallo * tree-vect-loop.c (vect_estimate_min_profitable_iters): Revert dead-code removal introduced by 09fa6acd8d9 + add a comment to clarify. --- gcc/tree-vect-loop.c | 17 +++++++++++++---- 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/gcc/tree-vect-loop.c b/gcc/tree-vect-loop.c index 9a82573604b..5ba4e594df9 100644 --- a/gcc/tree-vect-loop.c +++ b/gcc/tree-vect-loop.c @@ -4103,6 +4103,8 @@ vect_estimate_min_profitable_iters (loop_vec_info loop_vinfo, if (vec_outside_cost <= 0) min_profitable_estimate = 0; + /* ??? This "else if" arm is written to handle all cases; see below for + what we would do for !LOOP_VINFO_USING_PARTIAL_VECTORS_P. */ else if (LOOP_VINFO_USING_PARTIAL_VECTORS_P (loop_vinfo)) { /* This is a repeat of the code above, but with + SOC rather @@ -4115,10 +4117,17 @@ vect_estimate_min_profitable_iters (loop_vec_info loop_vinfo, if (outside_overhead > 0) min_vec_niters = outside_overhead / saving_per_viter + 1; - int threshold = (vec_inside_cost * min_vec_niters - + vec_outside_cost - + scalar_outside_cost); - min_profitable_estimate = threshold / scalar_single_iter_cost + 1; + if (LOOP_VINFO_USING_PARTIAL_VECTORS_P (loop_vinfo)) + { + int threshold = (vec_inside_cost * min_vec_niters + + vec_outside_cost + + scalar_outside_cost); + min_profitable_estimate = threshold / scalar_single_iter_cost + 1; + } + else + min_profitable_estimate = (min_vec_niters * assumed_vf + + peel_iters_prologue + + peel_iters_epilogue); } else {