From patchwork Tue Sep 1 18:02:13 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Robertson X-Patchwork-Id: 1355496 X-Patchwork-Delegate: daniel.schwierzeck@googlemail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=simiatec.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=NETORGFT1948989.onmicrosoft.com header.i=@NETORGFT1948989.onmicrosoft.com header.a=rsa-sha256 header.s=selector2-NETORGFT1948989-onmicrosoft-com header.b=mQpqub/1; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4Bh81B5n3vz9sSJ for ; Wed, 2 Sep 2020 13:04:30 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C260082272; Wed, 2 Sep 2020 05:04:26 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=simiatec.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=NETORGFT1948989.onmicrosoft.com header.i=@NETORGFT1948989.onmicrosoft.com header.b="mQpqub/1"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id B505082286; Tue, 1 Sep 2020 20:02:25 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-0.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,FORGED_SPF_HELO,SPF_HELO_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2070e.outbound.protection.outlook.com [IPv6:2a01:111:f400:7d00::70e]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 2A7AE821FF for ; Tue, 1 Sep 2020 20:02:23 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=simiatec.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=john.robertson@simiatec.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bL0M7seBKg1D73m0dX2ykahooZY9guksA3I0YKQwmTOgIyaQF++r6j8hWoGwrBmFruhxLdzJC/+uejpJGLAk1U3TT1MYrY036y2iQRRE5BwYBuwoTuqtq7ZXKni0N6yBBnPgG8gi32ahUYkvDr4JoJco75CD6o9uE/VpxX2yqW611omOWHkJaqGoqSs59QsscnDlQnBVhCi1Kd7y5LgqwlAZhGi0ePBiSb4v/MFtCOIiGEvrRBuF1uXE2qwdm6Magi5OhI+Sl5kasojxbbX7zcGRiw6Do2hS7R8SgQxnEpoyM7glxqDI0FbN7JkCTFDOul2RRRA+kBBRMgNX8S8Uvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=szuVT4skHuylFmLgGKyq32HDwHyf+MIPitx75ZyP98s=; b=VjeaJWwV36lI4mw/DunahIeFsLU9L3AHB/k8fD5Ov+Nd9hlWk/4HqCXO5egKLrZQTrbCcWBOE4GHppKg89W7kJ8RORhBYYBhSIUq9zUZr1hgMU5VzuQVWi9SLgTBp/TNwkfFqnnF5DQgYtDPn4qJLJsOToRUXpPsJqnML92PgQJ5qqvL1NF/+AdRhPjrG0/pnCPz8S4ly9Hk8fxlQomfqljUXENvWsNwmeFiibu12p7xFeHVlrLn6eSrWio2XmIKsGJoMNKuF9ZwrHX+b/6wiNfbJQc+j4AEQIfAxslXitl19MCQCvPr0eeGwe6tYXGdMXnRIhX5wzZeC1ynhCmCMQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=simiatec.com; dmarc=pass action=none header.from=simiatec.com; dkim=pass header.d=simiatec.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NETORGFT1948989.onmicrosoft.com; s=selector2-NETORGFT1948989-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=szuVT4skHuylFmLgGKyq32HDwHyf+MIPitx75ZyP98s=; b=mQpqub/1W0zoZlUWaVL+aEa7RglJgXlTTUQqiqSe3JerpBtxJaX18AdloG802XbyijrrDjSIXwL46GsFaBtocVHgrLA87F8eOlpa10wBMAh1jEhXgDPnhibxqTlU5tyCzGSgNZ9hjRb58Qq122X5AbKoSbMcMszZWfSW4l6reQc= Received: from DB6P190MB0134.EURP190.PROD.OUTLOOK.COM (2603:10a6:4:89::15) by DB6P190MB0312.EURP190.PROD.OUTLOOK.COM (2603:10a6:6:34::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3326.24; Tue, 1 Sep 2020 18:02:14 +0000 Received: from DB6P190MB0134.EURP190.PROD.OUTLOOK.COM ([fe80::d094:fa5d:652d:6ea6]) by DB6P190MB0134.EURP190.PROD.OUTLOOK.COM ([fe80::d094:fa5d:652d:6ea6%10]) with mapi id 15.20.3326.025; Tue, 1 Sep 2020 18:02:14 +0000 From: John Robertson To: "u-boot@lists.denx.de" CC: Daniel Schwierzeck Subject: [PATCH v2 1/2] mips: dts: Fix PIC32MZDA GPIO register definitions Thread-Topic: [PATCH v2 1/2] mips: dts: Fix PIC32MZDA GPIO register definitions Thread-Index: AdaAiL6v06J1P41eTt+h/vs+M50ogg== Date: Tue, 1 Sep 2020 18:02:13 +0000 Message-ID: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: lists.denx.de; dkim=none (message not signed) header.d=none; lists.denx.de; dmarc=none action=none header.from=simiatec.com; x-originating-ip: [2.120.150.60] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: fec7a85e-bef9-4469-e51e-08d84ea127fb x-ms-traffictypediagnostic: DB6P190MB0312: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: QrrAYg0/odLWOaI6iPefYJqheE6c/GZ5wCzqNliwZvXXhP4XG+Qp/FIGCTjCkB7NxRvfAPyh5tOCoLiNurr+HxYelfNHTQ2oSK5H6TsOr7aeESLsk5g5i/Th7dpFGzoyx5KEX3N73SE6E5Gyu/JbIkr0Eqb5GkeQFSKl32YLpCwieT9sIjbKWy0TI1JjQPHukAOcPNewNpE4xpygbC6HWzV7+rbNX1EwbIPRE5kh5K2QpE52xbx4rG1fpHpixax2MGh9poW92TdYRmtcyhli4ib09zQwwHVYN/b6DxnKxARw1W4c3f3dMDVCwqHKOxZp x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB6P190MB0134.EURP190.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(136003)(376002)(366004)(396003)(346002)(39830400003)(7696005)(4326008)(8936002)(8676002)(33656002)(26005)(2906002)(186003)(9686003)(316002)(55016002)(478600001)(76116006)(6916009)(66446008)(6506007)(66946007)(66556008)(64756008)(66476007)(52536014)(5660300002)(44832011)(86362001)(83380400001)(71200400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: qTopeU2gou34t+d7KIf2kB1kfXqDO2iBreDskM6SHQRSPwHGqjGdtg6uz81oygFB8jAVJdtQu+wEGEQX/1Ko7a0/Xy6UTQj75K6NvbRWPF0XkrqxkPUs5dDUiSZqhR9jdO+fl4olW68UlQ3ozex0/escSZXWBIEGauHaboirABR8Ndf92T5SRnnE3HkJ/wWUPYJUQNyF5A2Sr5OyJ7oUOKAG/ZhSPM0TAS0lqctoTvqmAz0yyy/62XFLExY8+n5DF/IlGmTcqq+vQ9wSiKtskq/Yv8QQxc5ltI2JCZByNTrSfF7z8O4d+q8vyYV/7Gz4GyeYHg4FSju6d4PIO1XAmaLvBMl8w3ZMP883URGNSopGe9MHrYTTOeNSHrg2WNnCnefuKzUpIdG3KPFhoMWP5ULmZHU2Y0xJ9UfTXIWyKyYddfgbBuSAAeoAjvvm9wt9Hk/S9aHE3S96urD/b7HRcA3vUjTUfgmLKGYZvwl6KTEsKBGbG6m8TyhMy/vDFewzA4/zWwaH19p+uXa7pI+27q10LSPzjaYX8AEaSZRsnQ8iQ8HqYKlVG9Vhwk+180V0IT/ysw7EVHJOHIksRHZffDsvUJPbpQG3+L1VtjXW3S33tHvOxGlUMNyVAC6d+T3yqZmuqdqFcqFBUBkNupCztg== x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-OriginatorOrg: simiatec.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DB6P190MB0134.EURP190.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: fec7a85e-bef9-4469-e51e-08d84ea127fb X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Sep 2020 18:02:13.9626 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 59a41530-c14c-4f73-ab40-30dfc975dc4a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: w3TRU9HU/OZj7Uh430EY5VcCRnqQ69E/0gokQcKofMB1Pjyyi24w0D7ZIl441IcthC8nynUKhKRzAtmg+2EushlR3iRMt0V2xhJnYtSxCik= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6P190MB0312 X-Mailman-Approved-At: Wed, 02 Sep 2020 05:04:25 +0200 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.3 at phobos.denx.de X-Virus-Status: Clean GPIO state cannot be changed via the device tree (e.g. with gpio-hog) or using the 'gpio' command from the console. The root cause is a discrepancy between the driver and the device tree: the driver code expects an absolute I/O address in the property, while the device tree defines the address relative to a declaration in the parent pinctrl node. Changing the device tree to fix a driver issue would normally be wrong, however: - I have run the first version of U-Boot in which this driver appears (v2016.03) and the same problem exists, so this is not a regression; - There is no code that references a parent device tree node that might suggest the intent of the author was to parse the DT as it exists now; - The equivalent Linux PIC32 GPIO driver also uses absolute addresses for the GPIO property. This change brings the U-Boot DT more into line with Linux. Additionally, the data sheet (Microchip ref. 60001361H) shows that the register set to control a GPIO bank spans 0xE0 bytes, but the device tree specified size is only 0x48 bytes. Signed-off-by: John Robertson --- Changes in v2 - Split patch - Document change more fully arch/mips/dts/pic32mzda.dtsi | 45 ++++++++++++++++++------------------ 1 file changed, 22 insertions(+), 23 deletions(-) diff --git a/arch/mips/dts/pic32mzda.dtsi b/arch/mips/dts/pic32mzda.dtsi index 4c8b7a9a0b..8f9b4cc50e 100644 --- a/arch/mips/dts/pic32mzda.dtsi +++ b/arch/mips/dts/pic32mzda.dtsi @@ -69,6 +69,8 @@ }; pinctrl: pinctrl@1f801400 { + #address-cells = <1>; + #size-cells = <1>; compatible = "microchip,pic32mzda-pinctrl"; reg = <0x1f801400 0x100>, /* in */ <0x1f801500 0x200>, /* out */ @@ -76,75 +78,72 @@ reg-names = "ppsin","ppsout","port"; status = "disabled"; - ranges = <0 0x1f860000 0xa00>; - #address-cells = <1>; - #size-cells = <1>; - gpioA: gpio0@0 { + gpioA: gpio0@1f860000 { compatible = "microchip,pic32mzda-gpio"; - reg = <0x000 0x48>; + reg = <0x1f860000 0xe0>; gpio-controller; #gpio-cells = <2>; }; - gpioB: gpio1@100 { + gpioB: gpio1@1f860100 { compatible = "microchip,pic32mzda-gpio"; - reg = <0x100 0x48>; + reg = <0x1f860100 0xe0>; gpio-controller; #gpio-cells = <2>; }; - gpioC: gpio2@200 { + gpioC: gpio2@1f860200 { compatible = "microchip,pic32mzda-gpio"; - reg = <0x200 0x48>; + reg = <0x1f860200 0xe0>; gpio-controller; #gpio-cells = <2>; }; - gpioD: gpio3@300 { + gpioD: gpio3@1f860300 { compatible = "microchip,pic32mzda-gpio"; - reg = <0x300 0x48>; + reg = <0x1f860300 0xe0>; gpio-controller; #gpio-cells = <2>; }; - gpioE: gpio4@400 { + gpioE: gpio4@1f860400 { compatible = "microchip,pic32mzda-gpio"; - reg = <0x400 0x48>; + reg = <0x1f860400 0xe0>; gpio-controller; #gpio-cells = <2>; }; - gpioF: gpio5@500 { + gpioF: gpio5@1f860500 { compatible = "microchip,pic32mzda-gpio"; - reg = <0x500 0x48>; + reg = <0x1f860500 0xe0>; gpio-controller; #gpio-cells = <2>; }; - gpioG: gpio6@600 { + gpioG: gpio6@1f860600 { compatible = "microchip,pic32mzda-gpio"; - reg = <0x600 0x48>; + reg = <0x1f860600 0xe0>; gpio-controller; #gpio-cells = <2>; }; - gpioH: gpio7@700 { + gpioH: gpio7@1f860700 { compatible = "microchip,pic32mzda-gpio"; - reg = <0x700 0x48>; + reg = <0x1f860700 0xe0>; gpio-controller; #gpio-cells = <2>; }; - gpioJ: gpio8@800 { + gpioJ: gpio8@1f860800 { compatible = "microchip,pic32mzda-gpio"; - reg = <0x800 0x48>; + reg = <0x1f860800 0xe0>; gpio-controller; #gpio-cells = <2>; }; - gpioK: gpio9@900 { + gpioK: gpio9@1f860900 { compatible = "microchip,pic32mzda-gpio"; - reg = <0x900 0x48>; + reg = <0x1f860900 0xe0>; gpio-controller; #gpio-cells = <2>; }; From patchwork Tue Sep 1 18:02:20 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Robertson X-Patchwork-Id: 1355497 X-Patchwork-Delegate: daniel.schwierzeck@googlemail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=simiatec.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=NETORGFT1948989.onmicrosoft.com header.i=@NETORGFT1948989.onmicrosoft.com header.a=rsa-sha256 header.s=selector2-NETORGFT1948989-onmicrosoft-com header.b=QonFxDXf; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4Bh81T1tZDz9sSJ for ; Wed, 2 Sep 2020 13:04:45 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 014878228A; Wed, 2 Sep 2020 05:04:28 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=simiatec.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=NETORGFT1948989.onmicrosoft.com header.i=@NETORGFT1948989.onmicrosoft.com header.b="QonFxDXf"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id CED048225E; Tue, 1 Sep 2020 20:02:25 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-0.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,FORGED_SPF_HELO,SPF_HELO_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2070e.outbound.protection.outlook.com [IPv6:2a01:111:f400:7d00::70e]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 6EFB58221F for ; Tue, 1 Sep 2020 20:02:23 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=simiatec.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=john.robertson@simiatec.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NxBOCIC0+w594I+rw1V4zSB75wXjC4jb3m9DOACSa2E0E/oF/9aNxhB0ZGmJEo7EDS983k1g1HmmWgSLR4cX2xuxPOAg6G2gVHxheML1FGgMpzJ2qkNVDKqJ6CFPPgY+6TxelNZZ4v8nDYnJBLbMODt+XYxO9fEp0Kfek3KQ3S9T2/W4Zn6GAnuEABhVXfOuPDyNWDdJTQDtJ7vP78E2e6NwH9cbgi8F3l+5R+xlBGpWJKg0nw7KyBsUPioYm893ptOm/f5sBFz/tHaHK1LioDrPl3LenHSqyC2Sgz2WLAIvQpBP5wHIdecFCoQQHcxrwOCogi/NLLpV6lcDg6+IVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CkuGdlTA9iz5UAvePvzIH9VAhimNTBZdYRLqaDZA9hg=; b=LqnSN8n9Bmd3xsy80eWZ/W+vI0kWyqfnJD1YuNk9Yde7Fvp5Kbp3lR9BbOiXIkOEAfkpwiHWSNx0RrAcb2v3UDnjoKQV77RUpHhIdCvxOOj11c1z7dokf+QVJQ/UbwWs2mwRlAgpyhsVLR0l1dR2FsxN+zRalWZsoQlSJBB7/6hGi0/SMNnjb/iRp5iv9lqZpwsxO47vxnNq4Tf8rGtQudx0fCtOjbB/cGQxj584uV7s9C6PWXb8MwaDMHkD8ZOnT4QZWBBX7N7+Ft1bQM97ZcKlc+PQBAKsWpMEdmjIg3K9wdwDKkCh074P/g9zuylEeSL4K/fO4mC2JS3EnFxEBw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=simiatec.com; dmarc=pass action=none header.from=simiatec.com; dkim=pass header.d=simiatec.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NETORGFT1948989.onmicrosoft.com; s=selector2-NETORGFT1948989-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CkuGdlTA9iz5UAvePvzIH9VAhimNTBZdYRLqaDZA9hg=; b=QonFxDXf+Z2Vl4650OSFSp/JnCw+FVEgbb0g25EmbvKmhBMqRfl1hc2Zv+PjvmcVE9k+M9fYbI4rhbdXUb7biSr8UxToI1rBFqcMJBd4v0tEXN7gnTUENjmmFn22tk4n+okLYlMs4CcAeb9Nb4+wNbSlzWeHSc8+wFRG3AxDqK0= Received: from DB6P190MB0134.EURP190.PROD.OUTLOOK.COM (2603:10a6:4:89::15) by DB6P190MB0312.EURP190.PROD.OUTLOOK.COM (2603:10a6:6:34::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3326.24; Tue, 1 Sep 2020 18:02:20 +0000 Received: from DB6P190MB0134.EURP190.PROD.OUTLOOK.COM ([fe80::d094:fa5d:652d:6ea6]) by DB6P190MB0134.EURP190.PROD.OUTLOOK.COM ([fe80::d094:fa5d:652d:6ea6%10]) with mapi id 15.20.3326.025; Tue, 1 Sep 2020 18:02:20 +0000 From: John Robertson To: "u-boot@lists.denx.de" CC: Daniel Schwierzeck Subject: [PATCH v2 2/2] mips: dts: Fix PIC32MZDA GPIO register definitions Thread-Topic: [PATCH v2 2/2] mips: dts: Fix PIC32MZDA GPIO register definitions Thread-Index: AdaAiT0dWoCNTWSURHSnPqyNWHnOmg== Date: Tue, 1 Sep 2020 18:02:20 +0000 Message-ID: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: lists.denx.de; dkim=none (message not signed) header.d=none; lists.denx.de; dmarc=none action=none header.from=simiatec.com; x-originating-ip: [2.120.150.60] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 87fdebd5-0619-4d19-6331-08d84ea12bec x-ms-traffictypediagnostic: DB6P190MB0312: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ozesN0I9YF5yj34DwhxNLOB0D6IUZQw6DpOUFUhx5dfDqIWmlNKDsDivyhqUt+LHo9b0WmtWIS+Nx8ZD0v4KdqhE+V5tWO8pdLWu1nDjfNhVCIOzBd0AZYdjNeiyJDScc5pIKDT2DE8xMS1lWwd1V1Nz5LRIFj6GCoE/K0+K7MmRQESB+C7DKz+GFYcKUrn1oXXUdrEsLeoocdZe4P5wNE8dFvcmyeYHrtI5lPFsjWuOXCaulvY/IDNrt6JiPsvpo3bmQkGtfSILhyuDnWPAJ0oRXeZFd8MTMwTjzJR6w8Mr+G1fsMtS4TNMHXhfrJEWW+6BVfhXOryMUTBRAWHv7w== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB6P190MB0134.EURP190.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(136003)(376002)(366004)(396003)(346002)(39830400003)(7696005)(4326008)(8936002)(8676002)(33656002)(26005)(2906002)(186003)(9686003)(316002)(55016002)(478600001)(76116006)(6916009)(66446008)(6506007)(66946007)(66556008)(64756008)(66476007)(52536014)(5660300002)(44832011)(86362001)(83380400001)(71200400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: 6bzHnEIf27Nvcc/sV1ZvV8Q4ZulecLt7QARgi8a+fNTcLUVASgWXnb6Uk8SHTwFvkeNw1FAnuISQQAYuxyCOtNQIZRdPfe4ODFNPuegjPz7ut1rqBSnID7PPQ4qPOPkWofxK3EsWD1YxQgkV1MqB0bA1KlEZrvSPQmpZ4TVqWc+6T3isjDDJdgwBxhFEvXLN2UCMDBpiR+kWzJAjaka6TSlhPMNG2ICVhfYzXCq7ya4pMnJdLmd/DukAI573OC68gsTP4Mh9zGEsZRaxHH/74yz4NnQR+qxhdYzFLGENTZGmbnHRkv6AD4tyUrf4SgesDL4WsPsHD/lrtWHoRxXaA8ddv8PX0f2ZnmqLttvrn7IY4WXAI3/jK67qe9eeUKeQqH+m3qRAU8R2N3lYt1BLn5uC4C18i5P1e87wxDlnB7eEhzaBa0rHT0arBIXpTSmJFsW8PnwRN7jOHY13tcuVyRkUPqDkVgHSgu4YltN9pvBbLe3ungsMA/UI4+mKYTtef0dqSPCKAztJbSfRmgf1y+tvCiD+CJN7kfwR36obwKa/ytvszX8B4EVsrQgKJWBrrrWkvjKOkarfw+3i3CT6wQtOn9eFUfdBKhOY5obmEwVkPitZwkZvdCtuUQIrV7Z08nMDbgo0Hfvkhgas1atPaA== x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-OriginatorOrg: simiatec.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DB6P190MB0134.EURP190.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 87fdebd5-0619-4d19-6331-08d84ea12bec X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Sep 2020 18:02:20.5518 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 59a41530-c14c-4f73-ab40-30dfc975dc4a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: qELzTnXsNj31xNBWZQIq2MOe1I/Hz4CwZpBQVYtRp3IG7tDUSMUv3ISt2JmcIl0i2w5GECCPb1p4ZKOeB07/sx8ngLybxJzPhp49+VYwW6I= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6P190MB0312 X-Mailman-Approved-At: Wed, 02 Sep 2020 05:04:25 +0200 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.3 at phobos.denx.de X-Virus-Status: Clean The GPIO bank name for banks J and K are not correct when using the 'gpio' command from the console. The driver derives the bank name from the device tree instance string by using the instance value and adding 'A': gpio0@xxaddrxx is Bank A, gpio1@yyaddryy is Bank B and so on. On the PIC32, there is no Bank I so instances 8 and 9 need to be incremented as a minimum change. An alternative (less opaque) implementation would be to use a bank-name property instead but this would require modifying the driver code too. Signed-off-by: John Robertson --- arch/mips/dts/pic32mzda.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/mips/dts/pic32mzda.dtsi b/arch/mips/dts/pic32mzda.dtsi index 8f9b4cc50e..2c2b7293d8 100644 --- a/arch/mips/dts/pic32mzda.dtsi +++ b/arch/mips/dts/pic32mzda.dtsi @@ -134,14 +134,14 @@ #gpio-cells = <2>; }; - gpioJ: gpio8@1f860800 { + gpioJ: gpio9@1f860800 { compatible = "microchip,pic32mzda-gpio"; reg = <0x1f860800 0xe0>; gpio-controller; #gpio-cells = <2>; }; - gpioK: gpio9@1f860900 { + gpioK: gpio10@1f860900 { compatible = "microchip,pic32mzda-gpio"; reg = <0x1f860900 0xe0>; gpio-controller;