From patchwork Tue Sep 1 14:09:11 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 1355029 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=vivier.eu Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4Bgprb3wHrz9sVg for ; Wed, 2 Sep 2020 00:10:55 +1000 (AEST) Received: from localhost ([::1]:59222 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kD6zt-0005mE-Bx for incoming@patchwork.ozlabs.org; Tue, 01 Sep 2020 10:10:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54942) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD6z8-0004wJ-Uh; Tue, 01 Sep 2020 10:10:06 -0400 Received: from mout.kundenserver.de ([212.227.126.134]:47137) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD6z7-0003iU-2X; Tue, 01 Sep 2020 10:10:06 -0400 Received: from localhost.localdomain ([82.252.135.186]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MxDgm-1kWyHV1E6q-00xeVR; Tue, 01 Sep 2020 16:09:57 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 01/44] hw/register: Document register_init_block @memory_size Date: Tue, 1 Sep 2020 16:09:11 +0200 Message-Id: <20200901140954.889743-2-laurent@vivier.eu> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200901140954.889743-1-laurent@vivier.eu> References: <20200901140954.889743-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:AtQWgzq0ULfuYw8lMJO5JadrGF34UW+j2cK9bu/8HqhC3eM58Gk 5pcnO+cF7UjlhF9ze424xMSNZP+QogMBEPfTCYDtvwIFe6GuehGTcAAwZMQPh65bDqI8WBm U51OQnJMnR/+M+VHXMTbCvZCrK2pYpq+gGp0dE3F4gP0WC/TuNhgWL1UWoAZ5HAJe7yPyQG ObRSj9A257fVGfN5kLTJA== X-UI-Out-Filterresults: notjunk:1;V03:K0:nudx0/aGK1M=:Krqh1IHc0oKBDF0jryp0dH BJ3tJGqwpzZXapQbf4uzPKN62LkZzHecrVFqBh46hg/x71M+5tbDF8CtauLZ3wrny1cU3G0kB RCUdKRnz0Kc45KNf8kcyXxrqUp7rH5u22zTXxt6nNW/3iG9xCM8KWEzVldw/8MzY8gxm0zVh6 Cbc8T09pm2coNffUnBQQotQiuI3IyPMjw6+6x75JytMmww4uP01ZKwh/EolrDTs2hn3hMAN7t T1IhAKqQbJFZkRdGOQ+YJKxAH4tpeN86QW+g0/6l/Jg8A9uWLBPlSpCVSbIl8R7t5xbrTbceh GcDHpsZQVPMTqIyOTFUlVDW3+YGolB4BCYEiy77BMkt+8y50UY9LEUqUgkXbqcdPBBnTkP4QB CAYHpTQt9EIepEbGr0vhS1gYzVvN83YtLrYSqrv7twLalDo48BjQd/oxoxyBaRkzfYvImI+Wb HIVwldW3JjWeAXMeo8LNC4+FiNr18vpyDDsQVmyn2+EOmagIHeDRiOgMMSUtaPwF6tPRN8zIl R0G55pIa6XFU7PWTlk16ynbqGZkHSU2menokAfbHkWN+sv7cIOjbH6Ptij9aJlZx0pvs/oSqG UGX4iMOC3IXjP9af6yzHyqHwVT+30kTyBEFPB9EcWmtmeSSnyL3RqTEVpMx+plY+ZrGWoSknz QlvXvFpzWG19EbQdbfK79DrAZh9wsbzzBKpSfhiLaRHFgA7a9PaHNVU02PUup0ZmhpNcBvXb3 qXcoetKJDplZBgO6c1cPRl+PSRH3mkyvU5kB8XsRpuRQKEsdI5TwYwSsyiNNBBXRi0QyA/gn2 5Bea1WQY6X+Mux2IO1t25Afhsciu9QC0a1aEra3ZmNroazOWTpS7qycsX8k0laPtbF/XrLU Received-SPF: none client-ip=212.227.126.134; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/01 10:10:03 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Alistair Francis , Laurent Vivier , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Philippe Mathieu-Daudé Document the 'memory_size' argument of register_init_block(). Fixes: a74229597e ("register: Add block initialise helper") Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Reviewed-by: Laurent Vivier Message-Id: <20200707062308.4531-1-f4bug@amsat.org> Signed-off-by: Laurent Vivier --- include/hw/register.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/hw/register.h b/include/hw/register.h index 5d2c565ae02e..fdac5e69b545 100644 --- a/include/hw/register.h +++ b/include/hw/register.h @@ -181,6 +181,7 @@ uint64_t register_read_memory(void *opaque, hwaddr addr, unsigned size); * @data: Array to use for register data, must already be allocated * @ops: Memory region ops to access registers. * @debug enabled: turn on/off verbose debug information + * @memory_size: Size of the memory region * returns: A structure containing all of the registers and an initialized * memory region (r_array->mem) the caller should add to a container. */ From patchwork Tue Sep 1 14:09:12 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 1355049 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=vivier.eu Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4Bgq0G1nTKz9sVf for ; Wed, 2 Sep 2020 00:17:33 +1000 (AEST) Received: from localhost ([::1]:36202 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kD76I-0003DF-SQ for incoming@patchwork.ozlabs.org; Tue, 01 Sep 2020 10:17:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55296) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD6zM-0005Wo-Od; Tue, 01 Sep 2020 10:10:20 -0400 Received: from mout.kundenserver.de ([212.227.126.130]:57591) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD6zH-0003oG-DA; Tue, 01 Sep 2020 10:10:20 -0400 Received: from localhost.localdomain ([82.252.135.186]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MCKO2-1kLORI2ayQ-009N6N; Tue, 01 Sep 2020 16:09:58 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 02/44] target/arm/kvm: Remove superfluous break Date: Tue, 1 Sep 2020 16:09:12 +0200 Message-Id: <20200901140954.889743-3-laurent@vivier.eu> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200901140954.889743-1-laurent@vivier.eu> References: <20200901140954.889743-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:F0TpCvtnRA9SHKBw7Olb3gWaYAHJBjSIK780eap44uZXKk+wDi3 TdPVdfQdMD6Sh2IUdNtTAV6990MRO8msMTwK/MZOew6q+PX/L80+lHK4RYzC+AvMQavhD3O 99wJsMEnA+aoouiW+0ruI01HzUV47leT1QVDxPLdFKsb813MJjPae5lrhpYF1pJLqETamUL p2rDrqu2z5wdnp67ShhnQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:WSNz6tpE9yg=:wFk62DoJrKqasw67S4CXm3 wZDfYZA4UlBtYP2aLE+gy14F4Yp5CpsgCzkWmR3jFSwsZnjFp5YTvNE5lgHIGNnnLCoaUxOtj M9CGa93cvs2SF/biIerdrweIkQa/WNwNM5fVWjfO62gweH7fbAc5vXnHE5+Zl4Bfy13Pk8ZrB lhFJrYMLJ6UjmL38RYq8zczDIKYpXNaivsGwFgBTYAF+zBrjiEHE7ZiS8jIB8BPz13kiIXhKg 1dNrTbmKojeXL4Q92ygPxHw1s0D4P1x2MlOnATWvW73Mv2dSTjc0GWPHTAz/phK23T82SR+En v6xbqLirch/RIrIkIoiKZspoI2bWSghrAcZizrhKH4BHr7PxfAsr6Ezui3HbZYGUl1I7myP84 E5DL+45hTgMf+pLLAg3OzgTcrEyy3P29OmG25b5isn1a/3duyyALb5/vxOqZO97XhWRyR9CVX /yZknDlsIvNjUPNXIzVDAWLgyg2/2vNJnX21d8CQW+C4lYIt4HL9TuJCZcCp5ujW4BvE1vJg+ rwavfATUpyor5ihQ0iLNQ/1dms6Aiqpy7k8ckt2nhfEWysbdBy2RbhmcbL26EVvNZAcddmUXt XNGIyrTvLkzutWD0XMjIr56vU/IHYzC/8WE4F/gUij2GoqXuvHDmNZJv8F4m8n8bAJ7qfVX6b tPurIw1g2GVSJi/xzy5agJum6oQrV5MIbg0dGrD9++lSDMZ4cLDyK2PlaNMgj30JAciWfwNTP 6J+Ig0DMt9yiDEwzILrU4uxcnC7OSFrV6vayxhEMs69eU1fHPDLTVXCDnMOpth5SF579tsXPU t/rWrDr2A9PH39+uuN2BnYzdc9KErRhC3IbGMBaUc5yMIKYMUe09EhWr4kuc68MSnI2Torp Received-SPF: none client-ip=212.227.126.130; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/01 10:10:08 X-ACL-Warn: Detected OS = Linux 3.11 and newer X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Yi Wang , Thomas Huth , qemu-trivial@nongnu.org, Laurent Vivier , =?utf-8?q?Phil?= =?utf-8?q?ippe_Mathieu-Daud=C3=A9?= , Liao Pingfang Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Liao Pingfang Remove superfluous break. Signed-off-by: Liao Pingfang Signed-off-by: Yi Wang Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Message-Id: <1594630986-36148-1-git-send-email-wang.yi59@zte.com.cn> Signed-off-by: Laurent Vivier --- target/arm/kvm64.c | 1 - 1 file changed, 1 deletion(-) diff --git a/target/arm/kvm64.c b/target/arm/kvm64.c index 116923790550..ef1e96028500 100644 --- a/target/arm/kvm64.c +++ b/target/arm/kvm64.c @@ -330,7 +330,6 @@ int kvm_arch_remove_hw_breakpoint(target_ulong addr, switch (type) { case GDB_BREAKPOINT_HW: return delete_hw_breakpoint(addr); - break; case GDB_WATCHPOINT_READ: case GDB_WATCHPOINT_WRITE: case GDB_WATCHPOINT_ACCESS: From patchwork Tue Sep 1 14:09:14 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 1355038 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=vivier.eu Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4BgpwC6SpGz9sTN for ; Wed, 2 Sep 2020 00:14:03 +1000 (AEST) Received: from localhost ([::1]:46268 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kD72v-00048n-Fl for incoming@patchwork.ozlabs.org; Tue, 01 Sep 2020 10:14:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55146) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD6zI-0005Jg-0P; Tue, 01 Sep 2020 10:10:16 -0400 Received: from mout.kundenserver.de ([212.227.126.187]:54917) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD6zD-0003lB-NF; Tue, 01 Sep 2020 10:10:15 -0400 Received: from localhost.localdomain ([82.252.135.186]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.167]) with ESMTPSA (Nemesis) id 1Mf0Je-1ko5QT4B2I-00gX3v; Tue, 01 Sep 2020 16:10:00 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 04/44] scsi: Remove superfluous breaks Date: Tue, 1 Sep 2020 16:09:14 +0200 Message-Id: <20200901140954.889743-5-laurent@vivier.eu> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200901140954.889743-1-laurent@vivier.eu> References: <20200901140954.889743-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:HzRXYpiCsJmFhJLmVx9r5xwCiEBP4G5Vuu71TcsfpxASRr3Mg4d aNQpvBU/2hWBekRmpiEmkkTbpCPF4Sf1s7PsiHofcFxyPIRSJRPPaQcLNPyeFq0Dl02DXjn 4Jto+Ld5cqj3NSrxTXeBUCjuUMRpeTdbCUzsCuwnTH5v8VXNJQk9Iizm4ZrAET0a3XSycmu ySaqib1Cn8na8umEx/Ypg== X-UI-Out-Filterresults: notjunk:1;V03:K0:7Ypi5pdDBr8=:A36Z2u8XPqSZFNVnpgpyLr VymfU3lEb7oQMTPbvbpgTxwf5bz7lFr0QuaHArnnWtymtxDZsoFzGFNRhBMjMsy67tVGUSh4a wchO7QVtOiVrGy0F7L6Ixyw7i5FL1eUdXiNx7hy0TsxjBrozK5+GkoY4AYVCkcYcIYKOJqnvS usjwjz9GlgC9pRZRRXaXoQCST+pXAwTBCrdhO3cLHKufhaT2uC9jN2MBq+MnCB9OOZ8DSsZ91 cs+labawHeFC0xlfSQCk3zOsdxvRFQLGD4e+2JuNRJ+ObuCQh1t4ezEfbgYe0m8VWPzZPlqJb VcHlefApzOSpgupVYCW7B5bIa3ISQiQ4nuQvBRTWgs5x7bi6oCgDzZ6IScvYwkj3R2EwqQgZx 1BKX6ZiLp5xo566HqEeeB2qFpq6XOMmmowHo+tRBcwXhjAWipUdKSOgXbXWHRF6YZUDqhY9EW awFKQGCJeg0+6wQbMBljmR/9lrz0YSBDIrZIP8gLPy1MVnDbmOUfOgscy58GHsSPDweER+hPv ONaCXTof2mKdpd12ethQeDACpQqKwVN4E7/A4zA4m+qXSC22ouqhv7vIfmLts3XWBqnNgXVYI NJyKFUSI/A10B2poi7zYRO35O8RVMbPTZafzoULfgqQoP7+w2EVnMdSruBS+cVrt7Jz9o8caj f98kJFhPJRJZf8R5U0orPVNH7mer1HJnzvx8T1PLqRVPAcdusW09dyM90zp9lNpwhuFGMhLlA Ax+htbzHQIJQxuk0EVdba7f2u/+LTWZMNEKfDaRSuX550pw9VU2gBHLxjXq2zxXDrdbbaMlYE LTYsR1oJEWOeC1uwzWqD8crXB1N1psCJ9FmrJDF+6o1VBow193S0bRhj8L60SUvn5T5JymT Received-SPF: none client-ip=212.227.126.187; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/01 10:09:57 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Yi Wang , Thomas Huth , qemu-trivial@nongnu.org, Laurent Vivier , =?utf-8?q?Phil?= =?utf-8?q?ippe_Mathieu-Daud=C3=A9?= , Liao Pingfang Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Liao Pingfang Remove superfluous breaks, as there is a "return" before them. Signed-off-by: Liao Pingfang Signed-off-by: Yi Wang Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Message-Id: <1594631062-36341-1-git-send-email-wang.yi59@zte.com.cn> Signed-off-by: Laurent Vivier --- scsi/utils.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/scsi/utils.c b/scsi/utils.c index c50e81fdb87f..b37c28301489 100644 --- a/scsi/utils.c +++ b/scsi/utils.c @@ -32,17 +32,13 @@ uint32_t scsi_cdb_xfer(uint8_t *buf) switch (buf[0] >> 5) { case 0: return buf[4]; - break; case 1: case 2: return lduw_be_p(&buf[7]); - break; case 4: return ldl_be_p(&buf[10]) & 0xffffffffULL; - break; case 5: return ldl_be_p(&buf[6]) & 0xffffffffULL; - break; default: return -1; } From patchwork Tue Sep 1 14:09:15 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 1355060 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=vivier.eu Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4Bgq5n19zpz9sVS for ; Wed, 2 Sep 2020 00:22:21 +1000 (AEST) Received: from localhost ([::1]:32880 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kD7Ax-0005A7-10 for incoming@patchwork.ozlabs.org; Tue, 01 Sep 2020 10:22:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55384) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD6zP-0005dD-4m; Tue, 01 Sep 2020 10:10:23 -0400 Received: from mout.kundenserver.de ([212.227.126.187]:38033) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD6zK-0003qW-43; Tue, 01 Sep 2020 10:10:22 -0400 Received: from localhost.localdomain ([82.252.135.186]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MVeDs-1k3Apo3JLQ-00RaTR; Tue, 01 Sep 2020 16:10:00 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 05/44] vnc: Remove the superfluous break Date: Tue, 1 Sep 2020 16:09:15 +0200 Message-Id: <20200901140954.889743-6-laurent@vivier.eu> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200901140954.889743-1-laurent@vivier.eu> References: <20200901140954.889743-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:Pdv3G5Oqe3F2hu2/7gXBOoL5WAz0XamQawEsYgcNF5YJP/+Ca2e uOh/8pgWD95l4+aXRbKkcS2L8wlzNnsLkCqOQeXPQPezwSpu4Fbx1AgRX+3PDidXqnLTjz1 /o8JqoRu+huLR2afrbh8O9XGvEjdXRTWwQGM2oSLGfKdTN40dy1hRjGpsuIJka2ncQaQcFF yTeU3ySy+s0gU/0nxSI1A== X-UI-Out-Filterresults: notjunk:1;V03:K0:NBEvsUduZJk=:wiYh741gjlNi3HyZ5q/vZX tKaY8C/UQgnh7K67xFxkgIYsuxcOFkLirpNbGpKiJZierlUpL2V7QGuUsuS0IjcgsnCSoHzDK 6kd0XGKB7VVNDXsjlOMjTnJd4Phdaw/V/CwBd9CtCa09gojNJP6CJ85fU5lpoG8LWfJm1qSyG xedyQA2PGl16zp1QtQ+Dc+vdbi5hUanQwpESSWcE2BRLTNyL41PnLjKaO8eEVk0fmRUq5qdtj K6TDAfW+pJ72N5zDdqcuE4WnJl579jBWTyHwCoUleZ4Xo2QaJE9DbODCdFGWI3enB9FuRwQYF Y8TBLKqDgceLBgdH+e03TiZLvdTYZTECrJBcgomVUYX3soCTnauwmVSkf7w8ZSs6j0OqLWT1K Ym0vpEZfkFa8avOFq/cEcu6QmBpLpzHSfivy74zWeYZxrNNoF1oWByF7sUu4NzUz+U9TYrtSg +JMu4Qy8rF9uwFhst9e2JH4Pa7ET37oGMxRFu/+Cy55qRi/DqrqCkBbjhju0C1GOrXkZbjKyV iPA1eMMHOFBA7DJ+x+Vk6lkVcAgbkG0YIfTznUGw852ROmLehJMcZIAPWoPZor+rWlh8N2Ra+ cw44jaFID4795kyL/rgkiJ1Vt7fmovn1wme34yTKYzBOk4KLPAKRtf1SMXkDwuvaryqKizC/d qcXFtja/xcYUOxYHUrmXf/6uVPUaBz3K6LQ033doMwm4ZAQSJD9KXZGtJPT4ml/fZHs59d9oc J72D41vKp3k3NzStFsB7eXP+iVBcpj2E0ImfgfeIxYrTj92x5iqWWkr8B9pBmKYHQudovRnX0 RqXZQsTTRjmMA/RZLrbUR4hhzFmob3Czp2yxvYPK2so7fkLA/wjiWEk512hmeJzIzrl9Mlw Received-SPF: none client-ip=212.227.126.187; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/01 10:09:57 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Yi Wang , Thomas Huth , Juan Quintela , qemu-trivial@nongnu.org, Laurent Vivier , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Liao Pingfang Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Liao Pingfang Remove the superfluous break, as there is a "return" before. Signed-off-by: Liao Pingfang a Signed-off-by: Yi Wang Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Reviewed-by: Juan Quintela Message-Id: <1594631086-36509-1-git-send-email-wang.yi59@zte.com.cn> Signed-off-by: Laurent Vivier --- ui/vnc-enc-tight.c | 1 - 1 file changed, 1 deletion(-) diff --git a/ui/vnc-enc-tight.c b/ui/vnc-enc-tight.c index 1e0851826a84..cebd35841a92 100644 --- a/ui/vnc-enc-tight.c +++ b/ui/vnc-enc-tight.c @@ -1125,7 +1125,6 @@ static int send_palette_rect(VncState *vs, int x, int y, } default: return -1; /* No palette for 8bits colors */ - break; } bytes = w * h; vs->tight->tight.offset = bytes; From patchwork Tue Sep 1 14:09:16 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 1355064 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=vivier.eu Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4Bgq7N04lyz9sTH for ; Wed, 2 Sep 2020 00:23:44 +1000 (AEST) Received: from localhost ([::1]:41232 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kD7CH-0000Kt-Vf for incoming@patchwork.ozlabs.org; Tue, 01 Sep 2020 10:23:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55394) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD6zP-0005e5-GA; Tue, 01 Sep 2020 10:10:23 -0400 Received: from mout.kundenserver.de ([212.227.126.134]:57709) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD6zJ-0003q8-HW; Tue, 01 Sep 2020 10:10:23 -0400 Received: from localhost.localdomain ([82.252.135.186]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MdNTs-1kmRnl1vAu-00ZOSj; Tue, 01 Sep 2020 16:10:01 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 06/44] block/vmdk: Remove superfluous breaks Date: Tue, 1 Sep 2020 16:09:16 +0200 Message-Id: <20200901140954.889743-7-laurent@vivier.eu> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200901140954.889743-1-laurent@vivier.eu> References: <20200901140954.889743-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:9wtfzMg5h42L8zLIZ5MY4d1StIUcSwuyoMS1KXY1qPL9bKgHQGG gcqTAG2jl9PCl4Mpscv2LUEL0i6o7f6BZY5Rggc4E8ibppLpuV4+C8JUqAXtsGdKrGRhfhj L8ghfwYhgNZrKY8Hx1GJf+MNNZg5vZINf9+Z7wyNuAnH3xMNorSDdz5KDf5RWqH+q0TRMQx 6VAH8GdbXM0EQtmkz/RKQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:JXSwrQqWkOQ=:yHcjmdYNlpacSrQivakCb3 l5Qf7W9ACAeCuhz+HMkeqeEp5yanC8ON3NJPAzA6qK7T+J09/uoKd1fYdJ6HejeKxYkgZp8qE +Xx94VxW3HkmKIL2980elyRkDzmkLz+twpXNbm2W/hZ0MFL3k2qhAsVs162mto7XuOITG3vHz 1uEmtFW+LZXBlKuliPbPiQjFPdonnIE+T+fNUP77sWJlwHgVbJykBga4DrI0lKKgZ+UNYe9r7 AwOaSGU0vwHt1pX7hGjlY9p7pkYXgw36jzAmLGLczfwVI5M/2kuqSolT3nfpbNDXbX1O/N9gn OqGWaAjrszW/ly7ou4XFcp+7jY9ilVI+vvP4pBK9u3cxUvpKZ4fwqhnUs9uLvy5+F61ICJzvb /yzIyLRE8RDYM0CBfM+t1twM+RM9at+Ud/CEyCMiEDFhptkDsU3bNUW9XhtnTPLFmIDt65/N+ ESBZLAXJ+7msJe3g6bmKrNBYPUCsco9V16ldu/pGftgSEUS8Uk8jChqKZkqhG6/Bbi2GQ1329 pd/HZzOE62Q7gmZkjk8WJg1HA2h67xySQeQ66fZW9G7ysTJi+L9Z0elgKMK9eItdOcC8LaUbX AuyARP8EVKpkjEznq7oi7ujGjufE/vV1uj0HvKKn05Yj8pnqAukqYZHeOl9xvcEHiMm8UgNVC G7bIXwoc+dmZF+MAlaHyaeLfvXpBM/pixBR900Ml8G83aMNqDIWJ8h5qImlUDSaTnW7Bzi9wP B99jaCyA1xtoiMD5Pxew/1g9wD117zqwAoJDyHnIoLZ1XHIx3GJUkUM4SyN5X1+ypxpaJh83O FnYDp10aL4VOD9swMuafrmQY5Df+/TDoP0VFLRrP8/jBFAHXaRg1X6EAsdOsdS6QlMjGuEM Received-SPF: none client-ip=212.227.126.134; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/01 10:10:03 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Yi Wang , Thomas Huth , qemu-trivial@nongnu.org, Laurent Vivier , =?utf-8?q?Phil?= =?utf-8?q?ippe_Mathieu-Daud=C3=A9?= , Liao Pingfang Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Liao Pingfang Remove superfluous breaks, as there is a "return" before them. Signed-off-by: Liao Pingfang Signed-off-by: Yi Wang Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Message-Id: <1594631107-36574-1-git-send-email-wang.yi59@zte.com.cn> Signed-off-by: Laurent Vivier --- block/vmdk.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c index bf9df5ce92ed..d90855446af4 100644 --- a/block/vmdk.c +++ b/block/vmdk.c @@ -1053,14 +1053,11 @@ static int vmdk_open_sparse(BlockDriverState *bs, BdrvChild *file, int flags, switch (magic) { case VMDK3_MAGIC: return vmdk_open_vmfs_sparse(bs, file, flags, errp); - break; case VMDK4_MAGIC: return vmdk_open_vmdk4(bs, file, flags, options, errp); - break; default: error_setg(errp, "Image not in VMDK format"); return -EINVAL; - break; } } From patchwork Tue Sep 1 14:09:17 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 1355055 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=vivier.eu Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4Bgq4C62XXz9sVd for ; Wed, 2 Sep 2020 00:20:59 +1000 (AEST) Received: from localhost ([::1]:52822 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kD79d-0001ev-LS for incoming@patchwork.ozlabs.org; Tue, 01 Sep 2020 10:20:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55354) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD6zO-0005b4-CX; Tue, 01 Sep 2020 10:10:22 -0400 Received: from mout.kundenserver.de ([212.227.126.187]:33775) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD6zI-0003pi-Vv; Tue, 01 Sep 2020 10:10:22 -0400 Received: from localhost.localdomain ([82.252.135.186]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.167]) with ESMTPSA (Nemesis) id 1N95mR-1kgcFZ0Ycx-0167sw; Tue, 01 Sep 2020 16:10:02 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 07/44] hw: Remove superfluous breaks Date: Tue, 1 Sep 2020 16:09:17 +0200 Message-Id: <20200901140954.889743-8-laurent@vivier.eu> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200901140954.889743-1-laurent@vivier.eu> References: <20200901140954.889743-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:t63RMrUKsw4I4AGu9+476NG7a2x8lGtHq+oLVzOVu54VVLPzXN4 ezRzqPNE/qX1prkyJhz5IvL9aJT6ydIwRGxWXUUA61k+6HfUH+YESfSdtsFWCZdjXl5mxAc 9j+6dSkSj7I/LtTkJCRnNavpUig+1Kuz6qnSuJs0C8gXjJQuXNwhy0yvepLpAOsdJw3Ufa6 bWKtd+Wt5V8UwQQLOdseQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:RH8Cs9s60wc=:xlG43TXzRqsPVIghZnAQTB zKfAYdG22YUcMotdjCy2fD36pYTi5F270WOC8wlz4f4R6r4eLscfkPzHIeCjXUSVi/ksaY/En wuV2IluQCCFqoIHTzFdWY1D4d9GvwoNxFyDsQU+Xagc7nT55pruaLC3ap+Fi4dnjia58lRIpj QlJ4/Je3j6pIWPnsdoVljHzI2i075fHKBsDDkHI6OVihSFDTha7o2CumeH2k61ondse0sF2YP 2gCYM3H1nXeumitCgCkxibKkY2szmr+tQrFDc0uRoRyh7TR36oB1tWn0Rf07BAXtXOHnAnQTK ad8EmGTz0DmRL9ZGumP4s5ZPmBHwHDE30690TtsZLl/zZT8rjsHWyCQTJvbJv/37YBh6s4xdk EO/dMmfMpVVTnbCYIBKTJflA19tEnaJ30YSZkW6jXCBdpPYpO1EzsM+7VHCurhEIiE4DTkjj/ Zbm2v3li6fn8UB3ZtDIjMxUKjPxt/bhbQIFliBD3kpQPDA/2Ar1c71h0Ff5ulwIUxLXtlYYOC o6Dw/04TQ/Pjqw5mdmy5AjkqEJDIuv61TutNfQFvROegj/MCmUJ6ig7cFa5LLgOWC8aBhOABx 2Y5wVLO63vfI6KO7u03z3cHmjLfmyZ0QXQelGW5WejUvXRkmtrGUfBZ0BxFGl7Sv938L9Jwl2 gPpABBCrj85XpbPhJr+HIEymqolZLm3botswqhIf0XE4ZDwtw07Wbcm4AaGN2XVqRj8eyNW1v I6v7FbrbMzphP8tPpcEwYSEFS01ban1GE1HCrFq9RNvlr3MtuQVdIC7/EL+En2/fiu54JN34k /EWJik36TUmhFAjka5lIh9CTLbtbxiXt2GylWIQaW+TvFfWg1FPaksSqsG0vwNSmK6wy0Ee Received-SPF: none client-ip=212.227.126.187; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/01 10:09:57 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Yi Wang , Thomas Huth , qemu-trivial@nongnu.org, Laurent Vivier , =?utf-8?q?Phil?= =?utf-8?q?ippe_Mathieu-Daud=C3=A9?= , Liao Pingfang Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Liao Pingfang Remove superfluous breaks, as there is a "return" before them. Signed-off-by: Liao Pingfang Signed-off-by: Yi Wang Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Message-Id: <1594631126-36631-1-git-send-email-wang.yi59@zte.com.cn> Signed-off-by: Laurent Vivier --- hw/block/pflash_cfi01.c | 1 - hw/display/cirrus_vga.c | 1 - hw/display/qxl-logger.c | 2 -- hw/gpio/max7310.c | 3 --- hw/i386/intel_iommu.c | 1 - hw/input/pxa2xx_keypad.c | 10 ---------- hw/intc/armv7m_nvic.c | 1 - hw/net/lan9118.c | 2 -- hw/usb/ccid-card-emulated.c | 1 - 9 files changed, 22 deletions(-) diff --git a/hw/block/pflash_cfi01.c b/hw/block/pflash_cfi01.c index 8ab1d66310b4..f0fcd63f84e8 100644 --- a/hw/block/pflash_cfi01.c +++ b/hw/block/pflash_cfi01.c @@ -213,7 +213,6 @@ static uint32_t pflash_devid_query(PFlashCFI01 *pfl, hwaddr offset) default: trace_pflash_device_info(offset); return 0; - break; } /* Replicate responses for each device in bank. */ if (pfl->device_width < pfl->bank_width) { diff --git a/hw/display/cirrus_vga.c b/hw/display/cirrus_vga.c index 212d6f5e6145..02d9ed0bd465 100644 --- a/hw/display/cirrus_vga.c +++ b/hw/display/cirrus_vga.c @@ -1637,7 +1637,6 @@ static int cirrus_vga_read_cr(CirrusVGAState * s, unsigned reg_index) return s->vga.cr[s->vga.cr_index]; case 0x26: // Attribute Controller Index Readback (R) return s->vga.ar_index & 0x3f; - break; default: qemu_log_mask(LOG_GUEST_ERROR, "cirrus: inport cr_index 0x%02x\n", reg_index); diff --git a/hw/display/qxl-logger.c b/hw/display/qxl-logger.c index 2ec6d8fa3d6c..c15175bce322 100644 --- a/hw/display/qxl-logger.c +++ b/hw/display/qxl-logger.c @@ -161,7 +161,6 @@ static int qxl_log_cmd_draw(PCIQXLDevice *qxl, QXLDrawable *draw, int group_id) switch (draw->type) { case QXL_DRAW_COPY: return qxl_log_cmd_draw_copy(qxl, &draw->u.copy, group_id); - break; } return 0; } @@ -180,7 +179,6 @@ static int qxl_log_cmd_draw_compat(PCIQXLDevice *qxl, QXLCompatDrawable *draw, switch (draw->type) { case QXL_DRAW_COPY: return qxl_log_cmd_draw_copy(qxl, &draw->u.copy, group_id); - break; } return 0; } diff --git a/hw/gpio/max7310.c b/hw/gpio/max7310.c index bebb4030d276..4f78774dc8f2 100644 --- a/hw/gpio/max7310.c +++ b/hw/gpio/max7310.c @@ -51,11 +51,9 @@ static uint8_t max7310_rx(I2CSlave *i2c) switch (s->command) { case 0x00: /* Input port */ return s->level ^ s->polarity; - break; case 0x01: /* Output port */ return s->level & ~s->direction; - break; case 0x02: /* Polarity inversion */ return s->polarity; @@ -65,7 +63,6 @@ static uint8_t max7310_rx(I2CSlave *i2c) case 0x04: /* Timeout */ return s->status; - break; case 0xff: /* Reserved */ return 0xff; diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c index 5284bb68b6e4..0d7c4303b4bc 100644 --- a/hw/i386/intel_iommu.c +++ b/hw/i386/intel_iommu.c @@ -3168,7 +3168,6 @@ static int vtd_irte_get(IntelIOMMUState *iommu, uint16_t index, index, entry->irte.sid_vtype); /* Take this as verification failure. */ return -VTD_FR_IR_SID_ERR; - break; } } diff --git a/hw/input/pxa2xx_keypad.c b/hw/input/pxa2xx_keypad.c index 62aa6f6b15a0..7f2f739fb335 100644 --- a/hw/input/pxa2xx_keypad.c +++ b/hw/input/pxa2xx_keypad.c @@ -192,10 +192,8 @@ static uint64_t pxa2xx_keypad_read(void *opaque, hwaddr offset, s->kpc &= ~(KPC_DI); qemu_irq_lower(s->irq); return tmp; - break; case KPDK: return s->kpdk; - break; case KPREC: tmp = s->kprec; if(tmp & KPREC_OF1) @@ -207,31 +205,23 @@ static uint64_t pxa2xx_keypad_read(void *opaque, hwaddr offset, if(tmp & KPREC_UF0) s->kprec &= ~(KPREC_UF0); return tmp; - break; case KPMK: tmp = s->kpmk; if(tmp & KPMK_MKP) s->kpmk &= ~(KPMK_MKP); return tmp; - break; case KPAS: return s->kpas; - break; case KPASMKP0: return s->kpasmkp[0]; - break; case KPASMKP1: return s->kpasmkp[1]; - break; case KPASMKP2: return s->kpasmkp[2]; - break; case KPASMKP3: return s->kpasmkp[3]; - break; case KPKDI: return s->kpkdi; - break; default: qemu_log_mask(LOG_GUEST_ERROR, "%s: Bad read offset 0x%"HWADDR_PRIx"\n", diff --git a/hw/intc/armv7m_nvic.c b/hw/intc/armv7m_nvic.c index 277a98b87b91..7876c1ba07ec 100644 --- a/hw/intc/armv7m_nvic.c +++ b/hw/intc/armv7m_nvic.c @@ -1290,7 +1290,6 @@ static uint32_t nvic_readl(NVICState *s, uint32_t offset, MemTxAttrs attrs) case 0xd90: /* MPU_TYPE */ /* Unified MPU; if the MPU is not present this value is zero */ return cpu->pmsav7_dregion << 8; - break; case 0xd94: /* MPU_CTRL */ return cpu->env.v7m.mpu_ctrl[attrs.secure]; case 0xd98: /* MPU_RNR */ diff --git a/hw/net/lan9118.c b/hw/net/lan9118.c index 8e2a432179cb..e35f00fb9fea 100644 --- a/hw/net/lan9118.c +++ b/hw/net/lan9118.c @@ -931,10 +931,8 @@ static uint32_t do_mac_read(lan9118_state *s, int reg) | (s->conf.macaddr.a[2] << 16) | (s->conf.macaddr.a[3] << 24); case MAC_HASHH: return s->mac_hashh; - break; case MAC_HASHL: return s->mac_hashl; - break; case MAC_MII_ACC: return s->mac_mii_acc; case MAC_MII_DATA: diff --git a/hw/usb/ccid-card-emulated.c b/hw/usb/ccid-card-emulated.c index 7d6105ef34d5..0f1afd66be1c 100644 --- a/hw/usb/ccid-card-emulated.c +++ b/hw/usb/ccid-card-emulated.c @@ -350,7 +350,6 @@ static void *event_thread(void *arg) case VEVENT_LAST: /* quit */ vevent_delete(event); return NULL; - break; default: break; } From patchwork Tue Sep 1 14:09:18 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 1355046 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=vivier.eu Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4BgpzV65Bnz9sVS for ; Wed, 2 Sep 2020 00:16:54 +1000 (AEST) Received: from localhost ([::1]:33638 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kD75f-0002BM-MX for incoming@patchwork.ozlabs.org; Tue, 01 Sep 2020 10:16:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55208) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD6zJ-0005Ok-TX; Tue, 01 Sep 2020 10:10:17 -0400 Received: from mout.kundenserver.de ([212.227.126.130]:47201) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD6zE-0003lu-C5; Tue, 01 Sep 2020 10:10:17 -0400 Received: from localhost.localdomain ([82.252.135.186]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MGQaz-1kNJB93WBh-00GmgK; Tue, 01 Sep 2020 16:10:03 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 08/44] target/sh4: Remove superfluous breaks Date: Tue, 1 Sep 2020 16:09:18 +0200 Message-Id: <20200901140954.889743-9-laurent@vivier.eu> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200901140954.889743-1-laurent@vivier.eu> References: <20200901140954.889743-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:Mcik9TkeaKMGYqCdcFrXhfx40gE1qlW7PBlZrqP4zLUPcyVZChD 13lly84avryWHAnP6r2HXf23Vj9QwmaZwbXjcdLujdMtBEOONUNeOv1mfGXO6Xaujy7S+Yp V1wBXrgbndhh0Tr95doz0VYWZku5zv9v17j3+3HEyiWGHB1uHkfRc2VA0E7q5llY/qYDjH+ WJCfPtfftNBNch+mjBRYg== X-UI-Out-Filterresults: notjunk:1;V03:K0:Kb4Txv76HBI=:fO/W8IRpcaTuf6XW8+J3wI u0wuLJYEWvURKE1Xa+Pf66/A9b+NQ0tCbMtoSkR8yP9qwstunYkw9SaEHi7mj5wyuBtoftExF tD6bTBoSEanWiahEXYMk4X2MaxbeHK0VmjL59hPjqAAN6m4V6gXVHSeeMzCucE5D5lJDwUjn0 dBR2qcvETPfEWeB3IdnAnO/QR8jnoobe624jnfGCfsWb/+M0TADuI03XUgMAZ9718pG+39QrI XDmw9T+vH0ZC+asYfpUT3X/0i7UnCeiBAVMrHM+WQOHYWGkICWDA4oafXGFqAHrARGMO7uY+I HBddrBHguFlYqZUewWOo3btcMaB1HhfQM4D89cRs/F5m5FHsg222r7GbXZ3TIlrbt/U3JtTCC 3UtFJDyVNVfxXrOz9HSstVAuCqfJHhj90n1GjgoNDMYJ7BQGSEexk18km5OIXjUu2UNmyo/DB Rs5V8+G10MJS+F6x4LAlqGqRs6dJB6AloOpHaY2CEysDN2qe7lP0whSfh9ItVp52PO2Y8zB09 55L+fhhAwqG97LxGsOuHbuvM6+0drTZhXv8l7v3+ruqkqBlXHMFACZi195UHSemEBJSQBDBCX S9m/P3wYXAecPXzrwIDutBPtCo+JeafrkSNyVyyCex33pqFpQLm4IFVRs/Tk+qXl+aPWHkDid rAov4aLWwEIeYgx8e4lRL9Jy0S6SFspE0M1fl3/fQ/SW4sVOOwTZLvdh2yaosHd+W9y44p9Qb B8ITVVL/89IRvPYgRfg8/59jaAY8PzAdQY5nuolL4dem0R0uYTvoOmkuucTr1igoyWwxTtfvA NYplVdTEkoyk9cYS2uu2JK44nt91C8ewqJgoy1yn3QiG23bsfUUtEJMhtcCvm8GM8Qh8SUD Received-SPF: none client-ip=212.227.126.130; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/01 10:10:08 X-ACL-Warn: Detected OS = Linux 3.11 and newer X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Yi Wang , Thomas Huth , qemu-trivial@nongnu.org, Laurent Vivier , =?utf-8?q?Phil?= =?utf-8?q?ippe_Mathieu-Daud=C3=A9?= , Liao Pingfang Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Liao Pingfang Remove superfluous breaks, as there is a "return" before them. Signed-off-by: Liao Pingfang Signed-off-by: Yi Wang Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Message-Id: <1594631142-36745-1-git-send-email-wang.yi59@zte.com.cn> Signed-off-by: Laurent Vivier --- target/sh4/translate.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/target/sh4/translate.c b/target/sh4/translate.c index 6192d83e8c66..60c863d9e1b0 100644 --- a/target/sh4/translate.c +++ b/target/sh4/translate.c @@ -1542,7 +1542,6 @@ static void _decode_opc(DisasContext * ctx) tcg_gen_qemu_ld_i32(REG(0), REG(B11_8), ctx->memidx, MO_TEUL | MO_UNALN); return; - break; case 0x40e9: /* movua.l @Rm+,R0 */ CHECK_SH4A /* Load non-boundary-aligned data */ @@ -1550,7 +1549,6 @@ static void _decode_opc(DisasContext * ctx) MO_TEUL | MO_UNALN); tcg_gen_addi_i32(REG(B11_8), REG(B11_8), 4); return; - break; case 0x0029: /* movt Rn */ tcg_gen_mov_i32(REG(B11_8), cpu_sr_t); return; @@ -1638,7 +1636,6 @@ static void _decode_opc(DisasContext * ctx) CHECK_SH4A tcg_gen_mb(TCG_MO_ALL | TCG_BAR_SC); return; - break; case 0x4024: /* rotcl Rn */ { TCGv tmp = tcg_temp_new(); From patchwork Tue Sep 1 14:09:19 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 1355068 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=vivier.eu Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4Bgq8x5bGPz9sR4 for ; Wed, 2 Sep 2020 00:25:05 +1000 (AEST) Received: from localhost ([::1]:49666 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kD7Db-0003nz-Nr for incoming@patchwork.ozlabs.org; Tue, 01 Sep 2020 10:25:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55440) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD6zQ-0005iK-Q7; Tue, 01 Sep 2020 10:10:24 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:54469) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD6zN-0003uZ-VA; Tue, 01 Sep 2020 10:10:24 -0400 Received: from localhost.localdomain ([82.252.135.186]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MirfI-1kpj3P28pg-00es6T; Tue, 01 Sep 2020 16:10:03 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 09/44] target/cris: Remove superfluous breaks Date: Tue, 1 Sep 2020 16:09:19 +0200 Message-Id: <20200901140954.889743-10-laurent@vivier.eu> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200901140954.889743-1-laurent@vivier.eu> References: <20200901140954.889743-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:XPGk1ppX/yIcmerFfjdQ8YEXT48yPdytcScu35k7J4MP4OtT53r eWf/sK8GFUOSw71FV2s7xmY/QBP0WSp8FGJPSmdKB/4jRSwLdWTZBdYpmyCYnmqrMBhzhcE QXiOk1SQ4cckOUe5h/eRktxlLA116LEaTibX7B7yVkQbkybzftKYJJCqofwwQHaFfnjEH0f knnYmomER83ZRAOLx841w== X-UI-Out-Filterresults: notjunk:1;V03:K0:2yHF8nSWOIs=:sBPsy+AaCj1nt0Aou7cjxw C2Q4pP+qftH+i6TNfTN3BLrfAGeXchsK+bqY92ENQiZw/Q93SJhRPvIB542m8FZnhTa3lp0lO 00fhUj94INR2WytAflneLLgz0Rs9JfEzpIKNeGpAa2qTdemZY5AA+4taa1WqnMsnfKpnDJl7a rbsrafxfnf4Jhec0T2l28W+2UJcd6ZZ0rlyZpqjDv9lKYgERcFHGmpDvJRe/c4wr51FDurLXI o8m0zPuaXmr4YDXPFRly/2xWxaEgW7foRvpPDXd0RUzBy3M1Keft4ET9TyrwWROFNY1AxTqcO iQaGoOfNeQpSez9V0nIYNg2Utz8x7KvixO5zy6F3ZcyC+N1xf8HEtPs2DPOm0Xv6fUGpD6QFo ooY+pYkXU1De1nGQStb0/h7LXlgi/B0bLDXDw36yyC2ChNJBY5TgtZXWrr6AMESg9RiKQJQNM ofe9joVixHz/RcgvcmIpTY+iJLCTKzzic8Xvk+xjWwtfCbCx71F4eD8b4l4lDhXyaL/pLzGE2 nZvfn5m5+XpMa3YQM9Z9P5SMGXm6FUektosEN7KxHgCmhvvXQfzrFVCvw87tNDgANNVkf4Rqu Lz07MreGe5gxSrmMvOJtr3qrLgewM8pnDR1C4nzUwunD+X8n45/JL7Dxs2qGLpKSxa3S5HeIh YtOQ+p7cSOBkcIWCTsXXJum2XfNpkb0sI9R92Xh8krt6UvMriDq0AIdeQFjoqTKcqAe8KFKVi erNHLtuf29tWwc1eggXnvVdLwnGEqlzT9YqJhl0u7gi4zwoxcX3brkgQ+BisYdgbpCBN8PsOO qsEtORnC7zBeFYpVHcXeRqPkgQUCn22Qzj9wLqGq20umRDOmgAD+DwDV3vdAtrRvjGdLCMo Received-SPF: none client-ip=212.227.126.131; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/01 10:10:10 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Yi Wang , Thomas Huth , qemu-trivial@nongnu.org, Laurent Vivier , =?utf-8?q?Phil?= =?utf-8?q?ippe_Mathieu-Daud=C3=A9?= , Liao Pingfang Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Liao Pingfang Remove superfluous breaks, as there is a "return" before them. Signed-off-by: Liao Pingfang Signed-off-by: Yi Wang Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Message-Id: <1594631150-36801-1-git-send-email-wang.yi59@zte.com.cn> Signed-off-by: Laurent Vivier --- target/cris/translate.c | 7 +++---- target/cris/translate_v10.c.inc | 2 -- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/target/cris/translate.c b/target/cris/translate.c index ee5e359c7788..c312e6f8a65f 100644 --- a/target/cris/translate.c +++ b/target/cris/translate.c @@ -1178,12 +1178,11 @@ static inline void t_gen_zext(TCGv d, TCGv s, int size) static char memsize_char(int size) { switch (size) { - case 1: return 'b'; break; - case 2: return 'w'; break; - case 4: return 'd'; break; + case 1: return 'b'; + case 2: return 'w'; + case 4: return 'd'; default: return 'x'; - break; } } #endif diff --git a/target/cris/translate_v10.c.inc b/target/cris/translate_v10.c.inc index ae34a0d1a3d8..7f38fd215eae 100644 --- a/target/cris/translate_v10.c.inc +++ b/target/cris/translate_v10.c.inc @@ -1026,10 +1026,8 @@ static unsigned int dec10_ind(CPUCRISState *env, DisasContext *dc) switch (dc->opcode) { case CRISV10_IND_MOVE_M_R: return dec10_ind_move_m_r(env, dc, size); - break; case CRISV10_IND_MOVE_R_M: return dec10_ind_move_r_m(dc, size); - break; case CRISV10_IND_CMP: LOG_DIS("cmp size=%d op=%d %d\n", size, dc->src, dc->dst); cris_cc_mask(dc, CC_MASK_NZVC); From patchwork Tue Sep 1 14:09:20 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 1355031 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=vivier.eu Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4Bgpsd1T5Xz9sVS for ; Wed, 2 Sep 2020 00:11:49 +1000 (AEST) Received: from localhost ([::1]:36626 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kD70k-00005V-34 for incoming@patchwork.ozlabs.org; Tue, 01 Sep 2020 10:11:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55034) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD6zD-00059N-Vy; Tue, 01 Sep 2020 10:10:12 -0400 Received: from mout.kundenserver.de ([212.227.126.133]:48519) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD6zB-0003jX-No; Tue, 01 Sep 2020 10:10:11 -0400 Received: from localhost.localdomain ([82.252.135.186]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MDyoW-1kKqD20scO-009v45; Tue, 01 Sep 2020 16:10:04 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 10/44] hw/net/can: Add missing fallthrough statements Date: Tue, 1 Sep 2020 16:09:20 +0200 Message-Id: <20200901140954.889743-11-laurent@vivier.eu> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200901140954.889743-1-laurent@vivier.eu> References: <20200901140954.889743-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:Qk5yQPmKbbO7HwvQeldik4qKCsyrNhYWxrCrS/d4CqHmAsss2Vb n9dnQNfjpo3HVf2Rxt4+y2AN1IARSzKHy8HyKRJo2ATaWybAFctnhQ7Tk1+RWoGORq4W4vx KFa5buDCrRGLbQbVKtQJsF5arXWDEuPlRxzmB1tGAQqo6uafaQdRUAi334n5rHCkBntRI4h a6JVMjtX4iLfQEMiLi6BA== X-UI-Out-Filterresults: notjunk:1;V03:K0:Ajmau5jBnbs=:rRm6FdeXu0AwOqRCrpT1oK sK9ueK9+1jUbfm/r9j5ZejbKUpkH8+QB1HEiVJIx2TzZs3kDjF9BBm70ql5kkX5fPSBu2vj7Y JOf9kVwLBKS4xJdobnUylh3VELDo3KhAU3KBkLTqZbl8SLC9m2SKpPI6WBqdHMwhbmqCxdFkN XQMKX/5aWjik6Y4GvEkSCHVmF1HiQb1ekpzSK+Ou8U1WkhVIE8xiwiAGhBAFdYgMk8eCVKyXz uwD65HD8kmZHYZO45a9WvVQBj5IeMWFlw+u2KRkww1iw4B0HYqMsYJLP6HYgeGORzvnEZVxsV pDgGN5dhqRYA8Q3BfaiVioTW0TWB+obGj8V/mibUS/z7eRMFQ6zHrQmfQem0zwbAQlk/VNgHZ njTi3xfuGMzOR/6/qWPX4ZQ8ZABxol0bVkD4a9WkL4dJ8Xvkgxxz8WohkIvF4rD4rBC7bV2zu MSlfBzNQM6FN3AUqBPD7noIqIdvSM/CcOf0iNZaNkReLs8hExiEo6F+7xRX0dyGFC5bec8jV5 vkw3VooX1g4TXe1zRf1MqN3WAxNJFJzB0q6GlNIab7poqOphjbvrD6KEMRQ1MaTWJ13sORPtV /aMB7XtEKnQ9CV28Eu328DVGylbXJnVC5+TfznPEtxmHIaecJqBUaLxRIv8jPvK61aLsHOhKv ggmYkk04agU7/SHKfRayhxmKCfybJ1q+S81WmdTge7rmi890mbMJd0+8+Jd6a6SF31ayjgAxE fVHgqfmsGyx/3St/UJo6cws5i/vm4m/PZzWH4mprcn1yi0KYZWuI4GJUJmnxJ/JViAGAO3oh0 bSCrIp6lYY3+KuGemEnCtbq/zI+OKaeurrtqztGg6QMDd65QklQIlDPE1FCsDTmH4KI9TAa Received-SPF: none client-ip=212.227.126.133; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/01 10:10:07 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Thomas Huth , Laurent Vivier , Pavel Pisa Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Thomas Huth Add fallthrough annotations to be able to compile the code without warnings when using -Wimplicit-fallthrough in our CFLAGS. Looking at the code, it seems like the fallthrough is indeed intended here, so the comments should be appropriate. Signed-off-by: Thomas Huth Reviewed-by: Laurent Vivier Reviewed-by: Pavel Pisa Message-Id: <20200630075520.29825-1-thuth@redhat.com> Signed-off-by: Laurent Vivier --- hw/net/can/can_sja1000.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/net/can/can_sja1000.c b/hw/net/can/can_sja1000.c index ea915a023a51..299932998a6f 100644 --- a/hw/net/can/can_sja1000.c +++ b/hw/net/can/can_sja1000.c @@ -523,6 +523,7 @@ void can_sja_mem_write(CanSJA1000State *s, hwaddr addr, uint64_t val, break; case 16: /* RX frame information addr16-28. */ s->status_pel |= (1 << 5); /* Set transmit status. */ + /* fallthrough */ case 17 ... 28: if (s->mode & 0x01) { /* Reset mode */ if (addr < 24) { @@ -620,6 +621,7 @@ void can_sja_mem_write(CanSJA1000State *s, hwaddr addr, uint64_t val, break; case 10: s->status_bas |= (1 << 5); /* Set transmit status. */ + /* fallthrough */ case 11 ... 19: if ((s->control & 0x01) == 0) { /* Operation mode */ s->tx_buff[addr - 10] = val; /* Store to TX buffer directly. */ From patchwork Tue Sep 1 14:09:21 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 1355047 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=vivier.eu Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4Bgpzk500kz9sTK for ; Wed, 2 Sep 2020 00:17:06 +1000 (AEST) Received: from localhost ([::1]:34928 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kD75s-0002hd-Hh for incoming@patchwork.ozlabs.org; Tue, 01 Sep 2020 10:17:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55156) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD6zI-0005Kk-DY; Tue, 01 Sep 2020 10:10:16 -0400 Received: from mout.kundenserver.de ([212.227.126.130]:57293) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD6zC-0003kH-Ej; Tue, 01 Sep 2020 10:10:15 -0400 Received: from localhost.localdomain ([82.252.135.186]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MF39M-1kO8Wa3wcq-00FPlt; Tue, 01 Sep 2020 16:10:05 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 11/44] hw/i386/kvm/ioapic.c: fix typo in error message Date: Tue, 1 Sep 2020 16:09:21 +0200 Message-Id: <20200901140954.889743-12-laurent@vivier.eu> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200901140954.889743-1-laurent@vivier.eu> References: <20200901140954.889743-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:8zzF2KBG2U8YkswJX4xybFx0/NJ8yL9YrgzOOzQ6QIWlM//DCjD YhJRN20gS/SmybesOw3JPHnJ2hp4c/QL+aUDoP7jrHJV/1gCT77+dFfYdLtOyCUqs2QPsEY IARA2i/1ZSzgU4zckYrulNgAfBKO/Ot3Uvj8ZqRumBjXwYjmFS9ycIC8yplkNCB+2WmKoEP 5XmEjeQ/vq1HePDrQN/Fg== X-UI-Out-Filterresults: notjunk:1;V03:K0:mNv9wNw5Zps=:8zz29vuzW58qf+YH7/w7IT aZ4REfq5OnRcYGd4dSN/MCuYyQ/QGQtqPk3iM+kbLHL7pZxQr8jJOOoAqTtzelTwtg+lwmAkX dw3S1z0dUKLYIGPFPnezd/cQwhhyBrCQgzYmGoQC5xzJpGLY3MBOX5Ui4CJkpXMkX5XOCHUFC ChL73jk+FErtcfEmRsnD19aZsg+LHjfWoLSVkBo767HbjU6oLshmhmxjgiEGy9tPJHbyABs/7 O7h7ULQjuwSjpcDcOnVcCtyK3fWBhwS0lkLvJCKubExu5Fw7+Ee4gJdvLn9+HAZ+H72p3R0Ds czTzfzc9BFc483HOxqw8Yqu8ss4fu4UyyOtpZLfmQQ0iSl91n0M29eDPWwS6fGsMFACZiK7QR CzqK/Y7mrmrEKrw7C9+5e1grWrbBOXQvsSJyth6+X+9taMnmPKn0Cg08eLqi568ji+xQrq66L SqZNgZl4DYwh1JL5wSaJII4BRAp5jZseD1VcdGq0KT4pmrpJfEdIQ2U9uT8nU320dCpghmEi1 Cl239yNndcDUHS0p8xw9lWFX6eG3rIoXu/MIW3lqpNXWemyiDlwogF4jkmAmQ93nv2HIC21aN vEF2BeMTupGBdquQgdJqzJ1yxp+6wEe8GccAmpiIdmpQWaWEvV9HIauNjviNO3e5zwANncAJG Fpzpgv1MLg5fDWA/cHU0OXENxfqEegY0bjlK0vCh6ZrxgrorMteAwIGkBWXmTZS/TF5Xidd2y iSYmghZ8nZXayxR2mEaJcAWfFucDJ3/BkNyyqPxi5K/+eAJ+NxslkMn1C1pgslQeXWg8LU7tw 3tmEVHD1WrrUfPXT7EtudnRr9YSttZAWKPyiBF3Y4qr8YahDTQCpu6EbUnFwG5VFTfReVNm Received-SPF: none client-ip=212.227.126.130; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/01 10:10:08 X-ACL-Warn: Detected OS = Linux 3.11 and newer X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Li Qiang , Laurent Vivier , Kenta Ishiguro , =?utf-8?q?Philippe_Mathieu-Da?= =?utf-8?q?ud=C3=A9?= , Stefano Garzarella Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Kenta Ishiguro Fix a typo in an error message for KVM_SET_IRQCHIP ioctl: "KVM_GET_IRQCHIP" should be "KVM_SET_IRQCHIP". Fixes: a39c1d47ac ("kvm: x86: Add user space part for in-kernel IOAPIC") Signed-off-by: Kenta Ishiguro Reviewed-by: Stefano Garzarella Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Li Qiang Message-Id: <20200717123514.15406-1-kentaishiguro@slowstart.org> Signed-off-by: Laurent Vivier --- hw/i386/kvm/ioapic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i386/kvm/ioapic.c b/hw/i386/kvm/ioapic.c index 4ba8e472510d..c5528df942a2 100644 --- a/hw/i386/kvm/ioapic.c +++ b/hw/i386/kvm/ioapic.c @@ -97,7 +97,7 @@ static void kvm_ioapic_put(IOAPICCommonState *s) ret = kvm_vm_ioctl(kvm_state, KVM_SET_IRQCHIP, &chip); if (ret < 0) { - fprintf(stderr, "KVM_GET_IRQCHIP failed: %s\n", strerror(ret)); + fprintf(stderr, "KVM_SET_IRQCHIP failed: %s\n", strerror(ret)); abort(); } } From patchwork Tue Sep 1 14:09:22 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 1355039 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=vivier.eu Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4BgpwH1TpJz9sVb for ; Wed, 2 Sep 2020 00:14:07 +1000 (AEST) Received: from localhost ([::1]:46518 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kD72z-0004Eo-0G for incoming@patchwork.ozlabs.org; Tue, 01 Sep 2020 10:14:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55102) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD6zH-0005HP-5K; Tue, 01 Sep 2020 10:10:15 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:37343) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD6zD-0003l6-Mw; Tue, 01 Sep 2020 10:10:14 -0400 Received: from localhost.localdomain ([82.252.135.186]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.167]) with ESMTPSA (Nemesis) id 1M7auL-1kETUO2Mij-0081Fw; Tue, 01 Sep 2020 16:10:05 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 12/44] hw/isa/isa-superio: Fix IDE controller realization Date: Tue, 1 Sep 2020 16:09:22 +0200 Message-Id: <20200901140954.889743-13-laurent@vivier.eu> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200901140954.889743-1-laurent@vivier.eu> References: <20200901140954.889743-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:xbZu9qGgfijSoHkTjzR/3GFFaiU2ozU8OfWqHkB/F82rpNxfY3r 8btq3ZvjhH58kl0ahDfKx/7gF9mv5RwFxXe5vAIMrC9wvvP1Rxpg3M+avnBfQ3sHNvhUmBH ynrydryGHd4HpsrIdkTGAN/HHEz3UZ8wS9x+gqEtesVVZfR02oMpsRHsBsOdaijJikq37FY 3mZToT7lDRqBJPfTiR/mg== X-UI-Out-Filterresults: notjunk:1;V03:K0:3+WNcWVgOzk=:bzePoUoElpVzHn3vxvadwl bJ46a7KYnhU/F8nek9T/W1JfdIqp4IVt8/XOUrtfIPtgD2U4HnInfAXHAa6n2B+j2BuPiZ64X 5daLrV6igaJvZ/rLAYqSx4/w0HqV/JarxNec0Vk48RnejktzXXuqAYWWWhB4BL8vONu3kHGcc jY5HBTeOHzRiwQrKXCnonoJlXkvM0In02ZwhwE3QihMBxz/G9hMVAHoHUrm87UCKPmtNC3zT8 zGLO6jSIcMHOQQdQjM+G/tCMO+3D2vCk7YUNq7nun9Dc9GR065P5fndHgB8srypKQ6tnk63Bz NM5GWXvMNicljm9aad2wVIz1Zz8yzJ94t7ewQ4r472y5xYP4vIWpudskg5uM5DP0xi4oHTzIB uhmwMpKJL7BDlxWO2ZPY1FYmjkhoBp/EdlIST5d9x6GNQFQ5O8Hj4grHJBQSPBP0kT83Q4sTn JJYpyOLbVBPtS/TTJjJtR/qWbdmAmxaddGKrn8BSLilv67gjGjlO28oTh31KRxRtEnf19Rquj YvsIxgkhuAzEdf/cknB49KHmIyCT+AtSS+4aJ08hSZ+gPU9YjDFBKWrIX84fSCxs5hIiTGdsP BPElEqye59YY5a2fhLno07gXhpF0RkZrlosJybRBAWy08fhEiZs/p5EAYWZ+O87xpFz2o/lIj OOyN2H1Q6YBCJHmnkYe9UGK4AHAllq3rrD122yBNxl9AtcQknvAKILIFs99yBmG3kqkH4W4+v jHPvL8XazWVk2VMhux84PLEVzSRvMAuqXHBUqseusUZAyqlc+rtJE8y8lqqWxjEqheIN8/+Je HEM56Cr5hNn0byzP5l9vvvX3UpC9swrgUVFjegq+Yx2Wb8+0XdcgJ+EGT6UmHAW4+NPG2gG Received-SPF: none client-ip=212.227.126.131; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/01 10:10:10 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Markus Armbruster , Paolo Bonzini , Laurent Vivier , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Philippe Mathieu-Daudé When realizing a Super I/O with IDE controller [*], we get: qom/object.c:1684: object_property_try_add_child: Assertion `!child->parent' failed. Aborted (core dumped) This is because the device is already realized when we try to add the QOM property to the parent. Fix by realizing *after* adding the QOM relationship. [*] Set ISASuperIOClass::ide.count = N with N not zero (no such thing currently exists; the bug is latent) Fixes: e508430619 ("hw/isa/superio: Make the components QOM children") Reviewed-by: Markus Armbruster Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Paolo Bonzini Message-Id: <20200721124516.9602-1-f4bug@amsat.org> Signed-off-by: Laurent Vivier --- hw/isa/isa-superio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/isa/isa-superio.c b/hw/isa/isa-superio.c index e2e47d8fd99a..179c1856956b 100644 --- a/hw/isa/isa-superio.c +++ b/hw/isa/isa-superio.c @@ -158,8 +158,8 @@ static void isa_superio_realize(DeviceState *dev, Error **errp) if (k->ide.get_irq) { qdev_prop_set_uint32(d, "irq", k->ide.get_irq(sio, 0)); } - isa_realize_and_unref(isa, bus, &error_fatal); object_property_add_child(OBJECT(sio), "isa-ide", OBJECT(isa)); + isa_realize_and_unref(isa, bus, &error_fatal); sio->ide = isa; trace_superio_create_ide(0, k->ide.get_iobase ? From patchwork Tue Sep 1 14:09:23 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 1355041 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=vivier.eu Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4Bgpwb0Zvvz9sVb for ; Wed, 2 Sep 2020 00:14:23 +1000 (AEST) Received: from localhost ([::1]:48234 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kD73E-0004uk-SJ for incoming@patchwork.ozlabs.org; Tue, 01 Sep 2020 10:14:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55090) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD6zG-0005FU-FA; Tue, 01 Sep 2020 10:10:14 -0400 Received: from mout.kundenserver.de ([212.227.126.133]:49511) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD6zD-0003kv-Ck; Tue, 01 Sep 2020 10:10:14 -0400 Received: from localhost.localdomain ([82.252.135.186]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MyseA-1kYbuO0Vko-00vzY7; Tue, 01 Sep 2020 16:10:06 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 13/44] stubs/cmos: Use correct include Date: Tue, 1 Sep 2020 16:09:23 +0200 Message-Id: <20200901140954.889743-14-laurent@vivier.eu> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200901140954.889743-1-laurent@vivier.eu> References: <20200901140954.889743-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:dS20v3gw2u2mvJ4hZkS/ZTB7063+qvvt1jXg6HhuBk2JPnF3+RB 8sjbueW+jPeuKyTAVWgpNloTrtJ1ocBy7hKQjczZt44JafwLl/l8pLoXu/cseaa8N0SGZAF K6naJDOMnj3Pb/4CmOZsslC+UYKt/Tc2224O/bOa3kK7khbd7jlZF4IEIyfwYW2I7AVr0MY Y1zoE/w5/j/9iFUWv1zyA== X-UI-Out-Filterresults: notjunk:1;V03:K0:wYgD4GoZcuU=:9zM3pFHSZ7J6EkcLFwQnQj NlL1BiPLP8tBj3m2QYeh8tnr+tmiBoJvt456nmBnojNOcJsA8PSZ7voTk7ohvC/hRWcAyg2sK OnKwzVHmkXQHqUOChdbRHU8D4IOdEYZInhyRj4bFqoM/MtSE91gICtfUHIrqA9wIsVho1RcpT WitmRXET3IVDQAXptC+LXi9jXH/tcqGTHM24QzJmKrRyBFB8JhGYKhpz+jhM2rgOipkSwaI5m iCAq+4ZwCKe3eA7qbFVLsFUJq9dSEZeVFk3r+VugwnLM3pxyyt3Y5kvTyJ7eW/xZ2fR8k43R7 vAbT7h2ESHWn5hRZ8Zop1wOEmWuK0oihOP+Eon/4tSpKkukkzh7y39pgltN0XJSwaqkDfVJAs Irt78zkeu+zNW7Y14950Zp3ErzyfUeahy2SqFhKQgNBg2/78IgXsFneEgxmBS5lWKYNKtsI0I /5yynxqxq4aEF8lQMd8zuVWtW+JCIvWwk0yTcG9m/2eGrdNzCMcts13DQYY3JSUhghtMd0xVz iWbw/+8h+b/V5nh5pflFLHrS3yhxEPQX57RgbCBDM3wWamaa8T2F7/vZ4bOrF4Xf4D17kIN/X 08VdC7T069L8NJY9p6n0pLHsLsjc1FPnATEHL5B+slS7E7WSuK24ijNYogoy5Hxo7ssFcGhR9 PvrX4KPpv7AEqj5pNGHEBITAzcv2dZJWag3xzfrxhqSj31tfHuOYSLoTHXoFfWFFnUq3YyJ5i TLrOULmHxtTjb51goLrSOzdvo+e+MHy7c+z9LKmZ0e8+t1T5cnhXAsNDaCz2yFRQ/CnvGBsml JvtbiwqU2S3wjVFFYrcJ3+JOmn5mxSU0R43dCpq85zeksCy40HNhoXirUmXhK75WIGGMtbl Received-SPF: none client-ip=212.227.126.133; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/01 10:10:07 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, John Snow , Laurent Vivier , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Philippe Mathieu-Daudé cmos_get_fd_drive_type() is declared in "hw/block/fdc.h". This currently works because "hw/i386/pc.h" happens to include it. Simplify including the correct header. Fixes: 2055dbc1c9 ("acpi: move aml builder code for floppy device") Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: John Snow Message-Id: <20200724084315.1606-1-f4bug@amsat.org> Signed-off-by: Laurent Vivier --- stubs/cmos.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/stubs/cmos.c b/stubs/cmos.c index 416cbe4055ff..3fdbae2c69e8 100644 --- a/stubs/cmos.c +++ b/stubs/cmos.c @@ -1,5 +1,5 @@ #include "qemu/osdep.h" -#include "hw/i386/pc.h" +#include "hw/block/fdc.h" int cmos_get_fd_drive_type(FloppyDriveType fd0) { From patchwork Tue Sep 1 14:09:24 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 1355050 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=vivier.eu Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4Bgq1D75HZz9sTK for ; Wed, 2 Sep 2020 00:18:24 +1000 (AEST) Received: from localhost ([::1]:40354 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kD778-0004sA-Rq for incoming@patchwork.ozlabs.org; Tue, 01 Sep 2020 10:18:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55314) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD6zN-0005Xv-6u; Tue, 01 Sep 2020 10:10:21 -0400 Received: from mout.kundenserver.de ([212.227.126.133]:48255) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD6zH-0003ov-Vw; Tue, 01 Sep 2020 10:10:20 -0400 Received: from localhost.localdomain ([82.252.135.186]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MJm8H-1jtWrf3TKL-00KD1Y; Tue, 01 Sep 2020 16:10:07 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 14/44] qemu-options.hx: Fix typo for netdev documentation Date: Tue, 1 Sep 2020 16:09:24 +0200 Message-Id: <20200901140954.889743-15-laurent@vivier.eu> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200901140954.889743-1-laurent@vivier.eu> References: <20200901140954.889743-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:LZ4UW4gukykKXwMApcvpEihZ/4Hd1xk4TMb5v2qEjF9n2FKeik3 psiWqZ3UvV1dO5spmBGc8mai8x7oEmHNHsvlhpGLa6YHegtE2p87FCZYQf578FxjlReHjEO sVwjuZyTIjBbI8rpqkeZjqIizpq4/iha8vzQvBKcHeqB+oecQL9z+r/fKt2NJREfOmqn4+6 0jGh/BRU0rW6uymL7TnXQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:ESYrRRrAvTk=:kiZilTFRpgu8PApf+h+9vh 1hHQoesjxIxD6whd8hIGBO06jk13bfMbSofcaXbyOULbXaWPkFGb/y/6aQhQ3XQxR/Nw8yMyy JCKkqiRs7OmELy7KgPrlljH9+xB++G1Cb22zdnyPm0mifYPPIgCw8ZsWY7Xfz8vKgIHxly1Th i3/hOsYDJBJbWzjDUI1PgyvTHp9GGR8HJn9TZmBbkyGRvyCALVZ+RF2RK/1c+G2b+Wq+ffgfh cdqX3ykPVjcHbhwvgV8f94X4XPsCMh32GWHMdx3Nd1HA5djHYvZ3oEGqRQ2oh8ybG7LHlwTWm Dj9aTpponveMvoUJ6JD+vCwPnDmuRGbPviOwPH+Wx49GfmKkM5kiQfW7F620vOBmTrf0ZK9O4 Z+tDMKrgyvh2izn2BzQdntcCotrjzZ+Wdp7JWG5w4qEcYyYDrWMip1mPEcbXEsN9HoumUcYw/ BpomhLo+fT9Zrxny/g3wpFD1hu9eq4LIUH0E3GKBlqq1UCw0zYxES/4EmSNSYNeV7fwAxUq5w 8T8i7mZeoXLgle+l2PhQsggrmT+3WPedoiPzIzLHOA3baTkuq3Kw0CYGN5rPM4egcxLZdNdZV x3Ez+4NnVhPv8urOLDc8sdaoeqhiy+sM1ku9bHD75WrxQvViuYJGtTdW850kcHe0XLfypczwZ cO0DdT7h33JYNUSLT0eSU2YSnRGpja35jw0r4Vh03sDdkgIeQxSwMrkO99ZSp9jp+lfrl8AHi Vo9Ki4ReImQlXEkeRSgkBQYFaOMTrXiyLP1dkhFmMIuj4duNs8PG+A3JC1WG8o/u6rVl+0kOY 7T224tzp/1bH0T++RFv6tK1NXWbLC5X2cn366pLoQZ3QyMBotdN3WsmcRqf1Eb4HSXbwNlQ Received-SPF: none client-ip=212.227.126.133; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/01 10:10:07 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , Tianjia Zhang , "Michael S . Tsirkin" , qemu-trivial@nongnu.org, Li Qiang , Laurent Vivier Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Tianjia Zhang This patch fixes the netdev document description typo in qemu-option.hx. Signed-off-by: Tianjia Zhang Reviewed-by: Thomas Huth Reviewed-by: Li Qiang Reviewed-by: Michael S. Tsirkin Message-Id: <20200727045925.29375-1-tianjia.zhang@linux.alibaba.com> Signed-off-by: Laurent Vivier --- qemu-options.hx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-options.hx b/qemu-options.hx index 30019c4eca2f..b0f020594eab 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -2684,7 +2684,7 @@ SRST disable script execution. If running QEMU as an unprivileged user, use the network helper - helper to configure the TAP interface and attach it to the bridge. + to configure the TAP interface and attach it to the bridge. The default network helper executable is ``/path/to/qemu-bridge-helper`` and the default bridge device is ``br0``. From patchwork Tue Sep 1 14:09:25 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 1355033 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=vivier.eu Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4BgptK59dQz9sVf for ; Wed, 2 Sep 2020 00:12:25 +1000 (AEST) Received: from localhost ([::1]:39314 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kD71L-0001Dr-9O for incoming@patchwork.ozlabs.org; Tue, 01 Sep 2020 10:12:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55172) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD6zI-0005Lm-QO; Tue, 01 Sep 2020 10:10:16 -0400 Received: from mout.kundenserver.de ([212.227.126.187]:53173) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD6zD-0003lF-Tx; Tue, 01 Sep 2020 10:10:16 -0400 Received: from localhost.localdomain ([82.252.135.186]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.167]) with ESMTPSA (Nemesis) id 1M9Wqa-1kGOEd1kgu-005XLt; Tue, 01 Sep 2020 16:10:07 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 15/44] hw/core/sysbus: Fix a typo Date: Tue, 1 Sep 2020 16:09:25 +0200 Message-Id: <20200901140954.889743-16-laurent@vivier.eu> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200901140954.889743-1-laurent@vivier.eu> References: <20200901140954.889743-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:uhyHOkyzsjzby5kCiitKF4XT9zu/Cc96r8PYtPu9NQ2Vh4xWozs s9lRP4Pc7s3Z97xI47D/Np/4qFafcZesz+Bu6W8+VPWUuQ8ocQjN8DtdvW6NjMFSm30pyHl Lg/luf94xS3Bltht6sd4Qp+0B4w/D/eblVmyGmSNoYALXvSHN4mA6DCPK5wC8nvOZYP+0OI sItrwJputbOMNTej5yiPA== X-UI-Out-Filterresults: notjunk:1;V03:K0:mPBbFZdFeMg=:dB8Rw/qhuw9Gqo+IfKeGHj dWr/lccKEjHfeJd3aiyJT0hSBNBcNh2Y2G9SAsN5yeSWYewfuf1EzEKqe3+ELl9hDnS8NxWq5 DY7evRozaVwIc+ZlWVf29IWJfdLYKf4s8LmaZKd+LBvkvvswidXEsQC4nc0wCurYF0N+lUpmz QqtLhB7WQIu20GtoE9nbLnKPnJHqXEkB/vM9qUmwHv/MRsi7p0bhCfwMnba07OYa5EFJehUr1 MPTuYCNbDWemRmklnV/QNXekdur/d0kq1hQuS94B46OeZXxC/9ezwqzltSQRywugw/3d/w73L Dt6K21bHeaX/lQ4VGdrpmQfHyR5pnXEie2SVIzvFsn3eCbTPNumDwzv9OX4UWMyYf4gRR7c8T VxqDQDuNa80em39gWKkjBCTDGCCxEipBo1duL5hWnqQJDb3y6Fumun9nCZFyozZw6fhA8pe8o XFmG9f39sF1CCic0hosSiTIQQlIv883VlaM+CN/nrv+PxnTYmZ3ZVcQ3lHAqDlDDwWSHI0v6q R9DHEwMudIzUmscEZPkdI+IgKxg+56I55Opnofe7j1onGwohIzxRn2TNw0n30Ef6QLJkV/CWp jleKgMIyDoBV3sch7Y6KRw7QFoFpK1eFYHSof46n7AZPMmbLrkX0+XRMO4V/8EE9YcMmzDjAT PHFuDzeoQ8lQneHHr7lS9uJElY8N7RdY5WP4+ictWkTLx2lvIesEmiLM/BdW7HiMTlTtavTpD M0Je4sd7BVpmkH52OwJbpOGVnZPu8OztwSI1+DoWAq6Wo7aYPTE5cfGg3TiQr4SC2sjvI3HcU DvILhXnR5ZPNv03FsN/KGR0tossJUKynVFsw8cNcvHbNsL2QQi8UEhmQm77kyDu5veE+942 Received-SPF: none client-ip=212.227.126.187; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/01 10:09:57 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Richard Henderson , Laurent Vivier , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20200806130945.21629-2-f4bug@amsat.org> Signed-off-by: Laurent Vivier --- hw/core/sysbus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/core/sysbus.c b/hw/core/sysbus.c index 70239b7e7d09..77ab351ce1a8 100644 --- a/hw/core/sysbus.c +++ b/hw/core/sysbus.c @@ -64,7 +64,7 @@ void foreach_dynamic_sysbus_device(FindSysbusDeviceFunc *func, void *opaque) .opaque = opaque, }; - /* Loop through all sysbus devices that were spawened outside the machine */ + /* Loop through all sysbus devices that were spawned outside the machine */ container = container_get(qdev_get_machine(), "/peripheral"); find_sysbus_device(container, &find); container = container_get(qdev_get_machine(), "/peripheral-anon"); From patchwork Tue Sep 1 14:09:26 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 1355042 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=vivier.eu Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4Bgpxj327Lz9sTK for ; Wed, 2 Sep 2020 00:15:21 +1000 (AEST) Received: from localhost ([::1]:54690 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kD74B-0007Y6-9r for incoming@patchwork.ozlabs.org; Tue, 01 Sep 2020 10:15:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55166) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD6zI-0005LE-Ih; Tue, 01 Sep 2020 10:10:16 -0400 Received: from mout.kundenserver.de ([212.227.126.130]:45563) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD6zD-0003l8-Nd; Tue, 01 Sep 2020 10:10:16 -0400 Received: from localhost.localdomain ([82.252.135.186]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.167]) with ESMTPSA (Nemesis) id 1Mbj3e-1kibFR45Es-00dFHH; Tue, 01 Sep 2020 16:10:08 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 16/44] hw/core/sysbus: Assert memory region index is in range Date: Tue, 1 Sep 2020 16:09:26 +0200 Message-Id: <20200901140954.889743-17-laurent@vivier.eu> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200901140954.889743-1-laurent@vivier.eu> References: <20200901140954.889743-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:149LN1V/RMSGZ8p3pJ/g9b9ZhYU537JP7fHyZGEDMZOFqj9ZGZ/ NctFfN+D2CtKOCvqfsb6x+/jGSsSsf15zaFQMH8Z0NY+clSRG0h2Q6+c/3hwpeTBMf6LjB3 +6VWnccFR5Han2e3XSF7Id6ODDD51ax+YPSa/pdHysfXLKqq+dKOX7D9LVv9RPMPuf3p9vz afSR0JEFsYxlENbZwx9UA== X-UI-Out-Filterresults: notjunk:1;V03:K0:duVrdT9jwb4=:rbpIf78QnKAO72HMFuhKyw ELHTYNbCZRDaj+GOgZXTvf2WM68/E8Ji6ZfOb9CkeiTIXTacOROXFnCbS1lM8J7W20m+T2X9e FLIrBqy5o7Sb7duxutPZ5eeL6NCQQG4HII+zifxLwK6iJSHyneMF+1CfKtcBTMyNNik9rDnGo sabj52V0Eg4QXf7c5RFVw1u8g5q77bThUWn93lRtX8wxDq6o+iAutV1lw/9l9o6F5foVD0ZDn 45N30B3mV3p8f219MbHXww4o+T9n7xtiDq0s/qi55ssMweCJSe2ebgVN6bAEb7SxKLEssZF0J 6f5PG6x9oTJZcPxmGuE4Lz6eS8VcSsMqFFfgGKdScV42RkqLA7tUqPeCoYbfYyfYUQtRWEA68 hfNmaLOse7bpmWE9jXt/puQZXf1PPxJIS4PdLb52lFS5uuTLFV9L8Nw7KEyxDAGArPPPxqbEQ ak4bPLlLITQoWpHTZykM5yQN6zrTyiLHpDwCGEOqNLH2AQjw8bQWSp1fc29xWPUcIyZeqoygv gHWNsgBaeXh/Wr3QQp0diR8Snc56fhLv9iS6u95XgjXTTH9z7QgusyA2FB3NUQmoofPJxrdXJ j2EKPcrJT5u1l+p5G8ZUsdo39IGvXgXtwQblonuXpvuIZUaDFBB3Ia/IvKlYLbcOLrId0nc9V kgU8gCoKP3YHifc0yMuDrtJMdMvcl5u47R3UdlyTlr44SphMA9jEiCx8w/X3vO8dXJMnEYkxE xZeoKPKCi3KNw1xGxxujUwW5eb2lATxHLH87dRxye3YuzEGH/KdY49qMQ9aO4J5Q6EOxGC4dW jktD3AfNHtRx9CTX2Pj2vclUYDHElx/i3Z91rhVt4uAeqBdWs9YncUoNjUygXOJSfPtEPHO Received-SPF: none client-ip=212.227.126.130; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/01 10:10:08 X-ACL-Warn: Detected OS = Linux 3.11 and newer X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Richard Henderson , Laurent Vivier , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Philippe Mathieu-Daudé Devices incorrectly modelled might use invalid index while calling sysbus_mmio_get_region(), leading to OOB access. Help developers by asserting the index is in range. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20200806130945.21629-3-f4bug@amsat.org> Signed-off-by: Laurent Vivier --- hw/core/sysbus.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/core/sysbus.c b/hw/core/sysbus.c index 77ab351ce1a8..294f90b7deef 100644 --- a/hw/core/sysbus.c +++ b/hw/core/sysbus.c @@ -199,6 +199,7 @@ void sysbus_init_mmio(SysBusDevice *dev, MemoryRegion *memory) MemoryRegion *sysbus_mmio_get_region(SysBusDevice *dev, int n) { + assert(n >= 0 && n < QDEV_MAX_MMIO); return dev->mmio[n].memory; } From patchwork Tue Sep 1 14:09:27 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 1355052 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=vivier.eu Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4Bgq2F1k72z9sTN for ; Wed, 2 Sep 2020 00:19:17 +1000 (AEST) Received: from localhost ([::1]:45678 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kD77y-00076c-GH for incoming@patchwork.ozlabs.org; Tue, 01 Sep 2020 10:19:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55280) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD6zM-0005V6-5C; Tue, 01 Sep 2020 10:10:20 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:41591) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD6zH-0003np-4x; Tue, 01 Sep 2020 10:10:19 -0400 Received: from localhost.localdomain ([82.252.135.186]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MplPh-1kwe1l2Won-00q7Qu; Tue, 01 Sep 2020 16:10:08 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 17/44] Revert "mailmap: Update philmd email address" Date: Tue, 1 Sep 2020 16:09:27 +0200 Message-Id: <20200901140954.889743-18-laurent@vivier.eu> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200901140954.889743-1-laurent@vivier.eu> References: <20200901140954.889743-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:ChtALlJkZgJpiF96Cn17CCN5tia8WPa0gmyMFO9vzh2KNErH/3p 1MWld+uKMHrIzYVOqrquGvgScUiCphJcVEUEN1ed8XjHDNoYpteyKh3UTDeQFQhdX7HD8kJ O2u4eBI+JASfBmNnL+mWqflMsnSIuf7EB1pMDXo5WwKwORZpXFiGEeB067wnSmlFSUMwa0y IE3UEB9IBiMqrJsaGIjew== X-UI-Out-Filterresults: notjunk:1;V03:K0:hyd1NQj9Bdk=:evSdRF+5+e+oaDyNbJ4FPJ z8dEhxaPiSPs8Bwb8llDbJzL7F5FseE9L2OMUKBvo8J/4rFA2d7uS73x3tO1MWgYaMr2Fxf/w aZAMUjbnj9I1P1hcnExjhfn3TZjkra0oHN7HHcV+REC7iOximSq52s9D52jnxTum62tZTp0U0 /lnk/iJAT2E81i8guN8Wwirko+UIkMQkt2N4vAQEIpLqVb2THINDsR3K57/clT3wg3zBICR6c okk327mZD69DOUfsXGFMwuQbPmc5NMssVvkWStr5/Wyw5gomJxsAxR/gYVYWffoayELB7Wl+j BpynW1LRe2F1bDnF9XFcwOd+GlgJL+tPybwUO6GuujmYg18xysSQBPeh2TKzOaZR+J0DXmsNr golo44nfkUWZH9IvKwiaVwHk8UBgpBzIOkjEDraycfozj/J6PEuqw/ZQ4QtjO/HszIURq4Ahg inDIk4NVLcAkbFrLuPHNVtZ3qDxaZlcoWg4E4p0OfAxy0QMDbmPViA41W3Hvdr/vOIEc/V8Vz qoiObjCJf1CO+NkNylVUeviKcZr2XRw2DVK7eJoE5fTS5TOC3LQCli0Z+odzcJlFQi3YYXoXP bcK65h6dAVEl92kVmP07RYMX62uEJcYL0BFsqQD+UylhR4Cs6WAGqkh4IAX1C06UCOTgHrmqi FXQI4QIX/3s0psujJoX9lF0DWoxKMYaoJVWa2Xcn2wt/IVj9jtiQ6O13ROm+06MyRmbqIPCUO MofVTzX5Uhf+oTNErwuhBNyAZZku270+kelRhMD+Pw6ddEnqM3laKN0JH82WLbcCxlBX6VrnS Vh1u/ZbtyfAyLNzCiCf32Y83ymi5JXHcT2TBVm4Mb4kTEHCuW1ytMN3KNRW4Otie7HzAB0S Received-SPF: none client-ip=212.227.126.131; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/01 10:10:10 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Laurent Vivier , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Philippe Mathieu-Daudé This mailmap entry does not work as I expected. I am receiving emails related to my hobbyist contributions in my work mailbox and I get distracted :) Remove the entry to keep things separated. This reverts commit 289371239153b24cb7bd96b6948c6b40b4627a9b. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20200806135832.2319-1-philmd@redhat.com> Signed-off-by: Laurent Vivier --- .mailmap | 1 - 1 file changed, 1 deletion(-) diff --git a/.mailmap b/.mailmap index 81c2ce09370c..2d97a14af3c6 100644 --- a/.mailmap +++ b/.mailmap @@ -54,7 +54,6 @@ Radoslaw Biernacki Paul Burton Paul Burton Paul Burton -Philippe Mathieu-Daudé Stefan Brankovic Yongbok Kim From patchwork Tue Sep 1 14:09:28 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 1355040 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=vivier.eu Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4BgpwS5zdQz9sVT for ; Wed, 2 Sep 2020 00:14:16 +1000 (AEST) Received: from localhost ([::1]:47676 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kD738-0004hL-Oa for incoming@patchwork.ozlabs.org; Tue, 01 Sep 2020 10:14:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55250) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD6zK-0005Ra-Vq; Tue, 01 Sep 2020 10:10:19 -0400 Received: from mout.kundenserver.de ([212.227.126.135]:60169) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD6zF-0003mn-Ri; Tue, 01 Sep 2020 10:10:18 -0400 Received: from localhost.localdomain ([82.252.135.186]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MN5W9-1jucEO0eqD-00J61w; Tue, 01 Sep 2020 16:10:09 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 18/44] docs: Fix broken links Date: Tue, 1 Sep 2020 16:09:28 +0200 Message-Id: <20200901140954.889743-19-laurent@vivier.eu> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200901140954.889743-1-laurent@vivier.eu> References: <20200901140954.889743-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:+vZfMsL2aeP5mDvhJCgG1EfxnPH9cPYAmsuNrE9+KP2my/6K2fO FmuOAtwmmGS8nxABOv1RxMy7Sx9h/AP6vqtX97xiwTLzWyA8nQRu8+MuPcjlZYGzM6Zr2dm VkbUmn1zPiEA71qspNIWwsLj8BKYvZbiFdKJXYAwa9MDVfcgCOiW66frgDhd1PK52AiYxu9 uWBnU1z5gCPahU3p3zr/A== X-UI-Out-Filterresults: notjunk:1;V03:K0:VUFn8QefwbM=:/koVAmFzYVRyvHSS6/a05G IpmJov7MDilOR1BOV9KAO33wXzfm5brFXptu4tqLJ7ZJlvpYPmjPzzqdEeIUrDKLXn8stDZKO Gdoqu8gUf+wWjVDj1vDnre9h1Vio9AjVb3N4PIhE9SXe9QKeFQJ4PcSQSbp6LCbq4KgAd1Kw7 1BxSiYvT9Y1EyruZMHPElJbpBxW4v5XHGHeJdzzjESWomYxgvtnRK2FD76U06iNYpNebv4l6X 9U24t2v+T0nzIP5KDqHghksYSeP9j4fTtmA0nAvprqAhHgo0m9TJVkUntGSAYVngGcvh6DVay AbzQ8F8GkND7Q8gnXfPsSgi6dAeKs7IqZWjx92n5CISQvrI7kDkmWhHeAYpco2x0rakAmEl6F JrsAVyxG7D9kFfC023wTZlV/z0EbJlpigoX9h5Nb74k70fHlE5/7HzhbFHaWkFKEbctuBWbaw J2zeTiBYjSX/TPlNJwVEW78nUlDZtM5veg9gwlIbhV0tht44XDlCkk4Vn4gsLQFXxOTOCLx5Q tA7MDS6EhMW0BLceVVE5EKPnOFXwQ3vE1jQuWYOSVzmcJpOdq8ncp3kP/ivABhLZ7csh/kYMf Q84sAFJIW/Y7eZXcLpeomKbAht89LrmPjjm142BIvVz6BNh5o/wRTCUmqHWvTvG/cWwioBuZu SRFN5LLfV/4qzlPC1fWDqOEpjrHLYf61KVMRkIWUkfw9mjd5eip+VtjRcCyxn6Sa6TWRER/C/ FAoK6AMMGdqajpnsgGgkTdEECvdjfXluOMuH7xRvCFoDOy85bEksXseSdp9FiBKNVqLIatLGA BKpcfcb8pCQ1VQULIXrUGHS7FU5a+T099j3tbPHQm3Yoyt7arUJrGI2sdO6T9us6J/vDKjl Received-SPF: none client-ip=212.227.126.135; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/01 10:10:07 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Laurent Vivier , Han Han Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Han Han Signed-off-by: Han Han Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20200807101736.3544506-1-hhan@redhat.com> Signed-off-by: Laurent Vivier --- docs/amd-memory-encryption.txt | 4 ++-- docs/pvrdma.txt | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/amd-memory-encryption.txt b/docs/amd-memory-encryption.txt index 43bf3ee6a5a9..80b8eb00e980 100644 --- a/docs/amd-memory-encryption.txt +++ b/docs/amd-memory-encryption.txt @@ -95,10 +95,10 @@ References ----------------- AMD Memory Encryption whitepaper: -http://amd-dev.wpengine.netdna-cdn.com/wordpress/media/2013/12/AMD_Memory_Encryption_Whitepaper_v7-Public.pdf +https://developer.amd.com/wordpress/media/2013/12/AMD_Memory_Encryption_Whitepaper_v7-Public.pdf Secure Encrypted Virtualization Key Management: -[1] http://support.amd.com/TechDocs/55766_SEV-KM API_Specification.pdf +[1] http://developer.amd.com/wordpress/media/2017/11/55766_SEV-KM-API_Specification.pdf KVM Forum slides: http://www.linux-kvm.org/images/7/74/02x08A-Thomas_Lendacky-AMDs_Virtualizatoin_Memory_Encryption_Technology.pdf diff --git a/docs/pvrdma.txt b/docs/pvrdma.txt index 0f0dd8a7e562..5c122fe81813 100644 --- a/docs/pvrdma.txt +++ b/docs/pvrdma.txt @@ -18,7 +18,7 @@ over-commit and, even if not implemented yet, migration support will be possible with some HW assistance. A project presentation accompany this document: -- http://events.linuxfoundation.org/sites/events/files/slides/lpc-2017-pvrdma-marcel-apfelbaum-yuval-shaia.pdf +- https://blog.linuxplumbersconf.org/2017/ocw/system/presentations/4730/original/lpc-2017-pvrdma-marcel-apfelbaum-yuval-shaia.pdf From patchwork Tue Sep 1 14:09:29 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 1355051 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=vivier.eu Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4Bgq1m3d29z9sW1 for ; Wed, 2 Sep 2020 00:18:52 +1000 (AEST) Received: from localhost ([::1]:43224 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kD77a-000693-CT for incoming@patchwork.ozlabs.org; Tue, 01 Sep 2020 10:18:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55258) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD6zL-0005S8-81; Tue, 01 Sep 2020 10:10:19 -0400 Received: from mout.kundenserver.de ([212.227.126.135]:35911) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD6zH-0003nk-2p; Tue, 01 Sep 2020 10:10:18 -0400 Received: from localhost.localdomain ([82.252.135.186]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MlwBf-1kv0OQ3GUt-00iypq; Tue, 01 Sep 2020 16:10:09 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 19/44] .mailmap: Update Paul Burton email address Date: Tue, 1 Sep 2020 16:09:29 +0200 Message-Id: <20200901140954.889743-20-laurent@vivier.eu> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200901140954.889743-1-laurent@vivier.eu> References: <20200901140954.889743-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:g8Ho16oUxUbOqmfmigPDkiytVMUWXcCfrpPunxSV76MaDLvpp+S sRFosgigpHiyzxSd93VOHWobCOuk+WEI+hzz0HAzrEDVVUfi7js1r3OTXynH9/pt5c5fnV6 a14TDsFfisVo6VhXBZoTxnBMtUjvceH+etwGQh6rXEuJzxSq+ojyX5NauXXFXrfBcNtbFLr 4MnGH7J4Y7IrLm14zWuQQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:QNr4C/M9WYU=:ouBpm/ttmPOKg0yBmeS+Tg zmCzi5FZBWCoe5+sDhGurxz10RxViJHHJY0XI8Sg4kz2Je3xHZosuUwIVcQuJv7lnPizwXX+4 C+QgreV8Izj6V9yLVkcfW+iDiVhOPMsUsKgLarHNq8vHP178EAfAjA8D2HrjBn+i4zH9E19IM wpLBf649Lxk1MWU+kEDnyO49gDUarrkOxSH3QUkRBvpqIypaC86MMKE+rErspg3lItefUdxDo jSwHabuB3u48zdo/kjAX+v/eGkJGiICqnFXjrgV0f+nmMUEf4utWOognOo5Gb5/5dw8WmjaB7 lsdKIWS5cEuPQA7f+XRV01tIEEb+1tfj1Hdx5/JkwPhqWRgDTDXbyE13kFeYWvag2ZubN3r7o /kNU2LjmHblfTUCzHzRxjAN3bE/mYLp07oJQi5/QbqZR5o8a+nsSuRd93THyLobOuy8zIIX6p Ncp6zN9YBui9zE9sgW6Xv271kpevtev6IgkO03yO9liUbcsj0T56/NRhOFRrpZXKcB6+G7prP EsdNkwcLsCcoS2pNjeVFLiEXfRqs/hDGwQRn9ELjX7AzwOs2hfMPElXODmOJfnvB9kvV9kIgZ FBd+o/prOqsfDGsN6G0Rtf21yuZeJoaBHmSZZ1yfA9/fStJZxWJFhHZknbegUbAf8Lzfdtxi9 RoUVnWDDsU8zAyRRi/u2Tkb8WCCIOa6dlr0TQru/8KZKmj0yXLQPnBYEyrQcXD7+wABDzdzs5 CkC9ALrzkyr8LWv1cIcD2paReV+xgjaA87cjIv1pS7SOsElvBcBynxLAc44gxoQzJxgGtRtkT TO1holQX2nwSWVyEWmHyudjm7/xjM3uLiLh34cTxV35mSBpGr5S7xsJJxBzJ09c6FjAq8ji Received-SPF: none client-ip=212.227.126.135; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/01 10:10:07 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Paolo Bonzini , Laurent Vivier , Paul Burton , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Philippe Mathieu-Daudé Following the Linux kernel equivalent patch posted on linux-mips@vger.kernel.org [*], update Paul Burton email address to avoid emails bouncing. [*] 'MAINTAINERS: Use @kernel.org address for Paul Burton' https://lore.kernel.org/patchwork/patch/1140341/ Cc: Paul Burton Suggested-by: Paolo Bonzini Signed-off-by: Philippe Mathieu-Daudé Acked-by: Paul Burton Message-Id: <20200707022544.24925-1-f4bug@amsat.org> Signed-off-by: Laurent Vivier --- .mailmap | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/.mailmap b/.mailmap index 2d97a14af3c6..4f40d1cc6e1b 100644 --- a/.mailmap +++ b/.mailmap @@ -51,9 +51,10 @@ Frederic Konrad James Hogan Leif Lindholm Radoslaw Biernacki -Paul Burton -Paul Burton -Paul Burton +Paul Burton +Paul Burton +Paul Burton +Paul Burton Stefan Brankovic Yongbok Kim From patchwork Tue Sep 1 14:09:30 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 1355043 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=vivier.eu Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4Bgpxy2Bfyz9sR4 for ; Wed, 2 Sep 2020 00:15:34 +1000 (AEST) Received: from localhost ([::1]:56050 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kD74O-00085Z-1o for incoming@patchwork.ozlabs.org; Tue, 01 Sep 2020 10:15:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55290) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD6zM-0005W2-FI; Tue, 01 Sep 2020 10:10:20 -0400 Received: from mout.kundenserver.de ([212.227.126.130]:58905) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD6zH-0003ob-PW; Tue, 01 Sep 2020 10:10:20 -0400 Received: from localhost.localdomain ([82.252.135.186]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.167]) with ESMTPSA (Nemesis) id 1N6bsM-1ke9Gu2gpC-0183pD; Tue, 01 Sep 2020 16:10:10 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 20/44] hw/i2c: Fix typo in description Date: Tue, 1 Sep 2020 16:09:30 +0200 Message-Id: <20200901140954.889743-21-laurent@vivier.eu> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200901140954.889743-1-laurent@vivier.eu> References: <20200901140954.889743-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:hYVfATmajBOJ5pMHRvVK/fipsf1zG1zZ/XtU8JI2X9WJq7CHULQ mYpzqLoNZg1PKspU1/YvMNHLNUepZjpGzSJiD0hrP146o8ZxLfgpehL7byyIXDpMty138zb 4T8zQCmMiuVkwUL52kM4W/Orl02L8SgxEB3cRCXYjIR13Mf3lPdfJ00oPD6XrwbS/RtkhfJ CMnUXt6aYIMx9wCNhy12A== X-UI-Out-Filterresults: notjunk:1;V03:K0:kN98XEpLlwo=:O68hlzn1Ic//0t/WUETcAS MahSO1PzRNOppKyucS8r4QyONTGGbFqxwk6VVUIU/NreYfaTa/P2H0eH96Chsb/NMwAxQn18Y fD1PevIfY8Kd43/ZNWjhl6QjbQwJijM5YBZTzFdypNpiatGoa3rVcOzFMugb7us+QoFp6ymLz tnl7miZFmTs+JdJtdNtn8P4tZuFO2rlrt2xSdmbG6AqOPIiIj/zFmG/K412ZhLGWQ/Vsz+SYn CR6SiH3q/y40YLJ4jvp8OceyQ3lCLFlzTe0+j1TvjTl/3b+MKUYXWOlT2lqrjmUI4kmvGIoZZ 5TWeccS7G3ixE/VE/X/vZsY7eiq10zDO61JM0aPoKyE0nG+ifPgTFZjBIUwWIStAVvySOEudr Ypja26DcqQs8zbMurFI8U0KOXz0SAA6yLUTpHiea5N58gIYuSsRFvoQkhjHZhcjTtWT3u+QyV HbNzmRAth8G8pJstV0ZaY8BUzHVcowP2FWNRO4EpUIfv9Vwn4+r7MBMB9lachyHQ5HKutiRZC ShxNeRccIGKbuLNKB6dW5uFjl4/Bqc6h4NtBD9gnkqpD5P0aseMvWaw0c4DOPXBxYG4DQowjF in1HyyjEUMYKWmDpt0ECfliPHdfzll8Azmy8syP7pfv9J1lWNsK60UWuze1GZ6F5+g211zcc7 bZUt+nukyzm6U75b/YvBYfhiKJ8iMyPGxWOZtJyAE+I+MqTCj1krZJchpWmidU9LOvEqpocy0 Pb/B8TvH+pWmh112rYZuzEteD5HzgUFYb96QWe97lH8gl6r85bfcvITN0+Gfv3u7XBUxjCBAd JHoyxQN0+l/7zgJCwQRiAxwgkZ27zzFKOivHVMspJlXX9nYeU6/AclT1v8vBxDpY9EJvO7E Received-SPF: none client-ip=212.227.126.130; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/01 10:10:08 X-ACL-Warn: Detected OS = Linux 3.11 and newer X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Corey Minyard , Peter Maydell , qemu-trivial@nongnu.org, Li Qiang , Laurent Vivier , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Philippe Mathieu-Daudé Remove the second 'and' introduced in commit 73d5f22ecb ("hw/i2c: Document the I2C qdev helpers"). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Corey Minyard Reviewed-by: Li Qiang Reviewed-by: Peter Maydell Message-Id: <20200811151643.21293-2-philmd@redhat.com> Signed-off-by: Laurent Vivier --- include/hw/i2c/i2c.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/hw/i2c/i2c.h b/include/hw/i2c/i2c.h index a9c030a51233..f57808851e22 100644 --- a/include/hw/i2c/i2c.h +++ b/include/hw/i2c/i2c.h @@ -102,7 +102,7 @@ I2CSlave *i2c_slave_new(const char *name, uint8_t addr); I2CSlave *i2c_slave_create_simple(I2CBus *bus, const char *name, uint8_t addr); /** - * Realize and and drop a reference an I2C slave device + * Realize and drop a reference an I2C slave device * @dev: I2C slave device to realize * @bus: I2C bus to put it on * @addr: I2C address of the slave on the bus From patchwork Tue Sep 1 14:09:31 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 1355054 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=vivier.eu Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4Bgq3X4jFFz9sTN for ; Wed, 2 Sep 2020 00:20:24 +1000 (AEST) Received: from localhost ([::1]:51074 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kD794-0000sf-IX for incoming@patchwork.ozlabs.org; Tue, 01 Sep 2020 10:20:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55418) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD6zQ-0005fU-2R; Tue, 01 Sep 2020 10:10:24 -0400 Received: from mout.kundenserver.de ([212.227.126.130]:46097) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD6zN-0003uU-Qy; Tue, 01 Sep 2020 10:10:23 -0400 Received: from localhost.localdomain ([82.252.135.186]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MGQaz-1kNJD416sP-00GmgK; Tue, 01 Sep 2020 16:10:11 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 21/44] util/qemu-timer: Fix typo in description Date: Tue, 1 Sep 2020 16:09:31 +0200 Message-Id: <20200901140954.889743-22-laurent@vivier.eu> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200901140954.889743-1-laurent@vivier.eu> References: <20200901140954.889743-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:fBZk9ez3vhEgDKEwBIi+DZi3OhQueHvRjUMJcSzEeEqICWTwBLL VaRxBQkmEKu5bJ6M31IZM8JvJGlUQME5tsjp7C22vrYi7AWu/X6YnPFxN7S8bnv5BtgTlmB hiEljrKb9YAEeA91ura+6HZON2aC3XcYDgh6c6gFXTxs9PLHpkTft+/EIcJTN8GsViSJfrH B76QvdpFkltiXKzNs0I2A== X-UI-Out-Filterresults: notjunk:1;V03:K0:i43uraF2Yhk=:zvcwRIBjL3uFBNQTqxTsfG Mm8ifcRhrfOKRXjWTUWxlyiqxyuLNsC0STxyY+RUM7+cNC1KaNHy64mvVVwGV8TLtMTHPrAuX M4Zg2SZzU3wfeKvQnQaqnm8/gF/93wDODu9R1EFvRDWWYKl4RcpKWdlhgpH4KIeY5eAt7++8e eGJr4JbHWhVc/J6qA5MkGCJd6VTAfJQdUzPAATv8L7EXgO6d00PrCg8yjru4/Ofz7vmMItPNQ uBhAcYxXXVW8fenUW9kaXsjW/mkTXEgNVH5hgt432nJmZIFAc07DwCz9N9US64eRToWiVZcwW rfIpB64q/DReR7yHiaj/V1guH/jCbyJnliOHUcoxOC2OJwrC7RO6u/oMZYkIpD6FLE4bFkrbj gTlwFGbQo+jkRhj6BU+IEm2EbKOOf40/aknqmBQmFCemcEPNrn0+HnwcSnQlZ487ZGoIiVbuS 2BgGvZB5lXrF5yr2fy9H2GRkzGQ1sK7isfoLYaihJhC/jI3YBIonEFw5rNwpNtoJvPFeihLKP OAjj/Dathm81qmhXTuGJN1RNcA1hhXKiZplp6zerQxLZTW3IDyprIE/jlcpw4NLfPLX9xiLI+ 3obtBNZP+gAL2A5mZbQ36Jwu//RC/sGd+MiS7OtA4EhXM7aVek2Ga7zHoIH9ngbbZAwPC1tPp ftqAkslWKeHbfb/ZYRApdQwMTouMqpfKQo8BMzXBK5RHh9OqOaO4mifyhJmnq9s7Bl8Zftb6+ 9B4ZhtJZTm42xGb2+f5L0ea4vs4VkLQCxL8KOidNkvTw8YcuRkPy7ftNW0Lj1+04BVyEeRTpZ 1ezb0EkkFf6VOhnnOfmjkmY1EHbet+Ct1lYuvGBn9n93jBkUzlwKKzREC5aInr4Nk0P+6rg Received-SPF: none client-ip=212.227.126.130; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/01 10:10:08 X-ACL-Warn: Detected OS = Linux 3.11 and newer X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Li Qiang , =?utf-8?q?Philippe?= =?utf-8?q?_Mathieu-Daud=C3=A9?= , Laurent Vivier , Peter Maydell Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Philippe Mathieu-Daudé Remove the second 'and' introduced in commit e81f86790f ("qemu-timer: avoid checkpoints for virtual clock timers in external subsystems"). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Li Qiang Reviewed-by: Peter Maydell Message-Id: <20200811151643.21293-3-philmd@redhat.com> Signed-off-by: Laurent Vivier --- util/qemu-timer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/qemu-timer.c b/util/qemu-timer.c index f62b4feecdb0..878d80fd5e5e 100644 --- a/util/qemu-timer.c +++ b/util/qemu-timer.c @@ -530,7 +530,7 @@ bool timerlist_run_timers(QEMUTimerList *timer_list) } /* - * Extract expired timers from active timers list and and process them. + * Extract expired timers from active timers list and process them. * * In rr mode we need "filtered" checkpointing for virtual clock. The * checkpoint must be recorded/replayed before processing any non-EXTERNAL timer, From patchwork Tue Sep 1 14:09:32 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 1355063 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=vivier.eu Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4Bgq6j3N1Lz9sTH for ; Wed, 2 Sep 2020 00:23:09 +1000 (AEST) Received: from localhost ([::1]:38134 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kD7Bj-0007US-Ek for incoming@patchwork.ozlabs.org; Tue, 01 Sep 2020 10:23:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55488) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD6zS-0005ns-Nv; Tue, 01 Sep 2020 10:10:26 -0400 Received: from mout.kundenserver.de ([212.227.126.187]:44715) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD6zJ-0003qF-Sf; Tue, 01 Sep 2020 10:10:26 -0400 Received: from localhost.localdomain ([82.252.135.186]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.167]) with ESMTPSA (Nemesis) id 1M5wTr-1kF1jc3fVD-007TIE; Tue, 01 Sep 2020 16:10:12 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 22/44] util/vfio-helpers: Fix typo in description Date: Tue, 1 Sep 2020 16:09:32 +0200 Message-Id: <20200901140954.889743-23-laurent@vivier.eu> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200901140954.889743-1-laurent@vivier.eu> References: <20200901140954.889743-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:fvs2r8nQPYulppaFIXhHwCIGgOisL/qy2m9RS/M+1rJ4NyO43gZ nh0UWjyY88OttrEvUyHl2EQ80u6NM/TQiS3NrUwLIqOwEKEQbQhPGNKt4wKkBAiOA0tHSej 8c2okxweiXjg9n4vITh65IwjVjxE92CHS2BA+qRWFcs3G4JBWIQdjSwtA/2nCSNGBPlxuTe GTF6SurCL6mZc+Ia+Jfvg== X-UI-Out-Filterresults: notjunk:1;V03:K0:1Lg0SCjDYZQ=:MDPmLqx/8Ug5OmS7PPs/Lh kmAjbJUcuQPGnv84pxg3lw5Br7pyaokw0lRUH+kG5SLLSnldAC3JwjQv4dfeb0/yTqJNh0nBG t7zhotU0KXtxR5cXrmJTP4fhWjPwLaYnes41NeOuex8qUlukWqwIXlv9NDdJdektd55B59ECh Y6Mc6TDc7y7b9nszXFQNNOjXQQ72+DsjoJwB4ane6jxG1/cEVDUCTyYXoPiiPZbnUwEZR1nXI KbbHLWFSeiJC7fXdGHQVU0m4sOTXwKBhoPxYxECKXq1sUhOcbSpG2qtggUrrekUXTn+CbrL0C fGvOUI7ksDRE4YMuEsVz8wKRLTuGzkQV1hsAsuiY0BS03QfpbqFefytWfQKtPtB8bu0SCLkkk jwIkd33uKpuLgaH7lmKLx5otBznPJdlpm6Pt/tND6P3S/v5RbbNHZdacL/JQ6wE3kzLdlJAZ8 yz4sFyCMUBTpgCawas5Zs3dn1MhaIV6+LA/iZ8sEhBsc05vC+qc5OgMLOpyH90WIKE1ko3xO8 E/K58+4/jCoQoiPYYRU6vX+2+WKvmIPtA2dReREgtEL58WT3fSIn5Mqql5PvGSVLG8OZi1r3A RP3WvGUaP9jXC4QL8Zw15fl0Y0a01G+sFqbrI88UnzXM7XJNwqCM2SRr/mq+q8m3leMve87NF SPnmLJgs62b7O3qOUtcuolag41rTwCJzxGPEWeosNqq2onGi77/OYFn16wmxq711BLnnPNWCP gQxvobjS1alYY91kZlsK5po4Ihwt8UacTfj8/EJBv/ayLswxCyNPPABONQNd/YYl/Hf3Tjw05 1NkcdV6dzSED/Wd68BAjq54iHfLezmVj8hvfiyfsVAcXp32BL08Eupw3WZySG9GzpnyuRc5 Received-SPF: none client-ip=212.227.126.187; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/01 10:09:57 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Li Qiang , =?utf-8?q?Philippe?= =?utf-8?q?_Mathieu-Daud=C3=A9?= , Laurent Vivier , Peter Maydell Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Philippe Mathieu-Daudé Remove the second 'and' introduced in commit 418026ca43 ("util: Introduce vfio helpers"). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Li Qiang Reviewed-by: Peter Maydell Message-Id: <20200811151643.21293-4-philmd@redhat.com> Signed-off-by: Laurent Vivier --- util/vfio-helpers.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/util/vfio-helpers.c b/util/vfio-helpers.c index e399e330e26a..583bdfb36fc2 100644 --- a/util/vfio-helpers.c +++ b/util/vfio-helpers.c @@ -173,7 +173,7 @@ void qemu_vfio_pci_unmap_bar(QEMUVFIOState *s, int index, void *bar, } /** - * Initialize device IRQ with @irq_type and and register an event notifier. + * Initialize device IRQ with @irq_type and register an event notifier. */ int qemu_vfio_pci_init_irq(QEMUVFIOState *s, EventNotifier *e, int irq_type, Error **errp) @@ -505,7 +505,7 @@ static IOVAMapping *qemu_vfio_find_mapping(QEMUVFIOState *s, void *host, } /** - * Allocate IOVA and and create a new mapping record and insert it in @s. + * Allocate IOVA and create a new mapping record and insert it in @s. */ static IOVAMapping *qemu_vfio_add_mapping(QEMUVFIOState *s, void *host, size_t size, From patchwork Tue Sep 1 14:09:33 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 1355045 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=vivier.eu Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4Bgpyk61NHz9sR4 for ; Wed, 2 Sep 2020 00:16:14 +1000 (AEST) Received: from localhost ([::1]:58154 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kD752-0000Ye-My for incoming@patchwork.ozlabs.org; Tue, 01 Sep 2020 10:16:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55300) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD6zN-0005XK-2D; Tue, 01 Sep 2020 10:10:21 -0400 Received: from mout.kundenserver.de ([212.227.126.133]:50337) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD6zI-0003pH-CR; Tue, 01 Sep 2020 10:10:20 -0400 Received: from localhost.localdomain ([82.252.135.186]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MsI0I-1kS2JC1y3e-00tol5; Tue, 01 Sep 2020 16:10:12 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 23/44] mailmap: Add entry for Greg Kurz Date: Tue, 1 Sep 2020 16:09:33 +0200 Message-Id: <20200901140954.889743-24-laurent@vivier.eu> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200901140954.889743-1-laurent@vivier.eu> References: <20200901140954.889743-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:Uf3LfJJZDIbdPHC+99ooHTXKK3JKZlzUCmccAqEpHi3gy7BrFvl szmj6Uetx/LWQ9sQnjqPUZqZ2V22fyWUvy3TMJmp5Qt6aYDe0qHBl4UUxw1tF0drw5l0ieU Weo+AEy3cOkfGaOqB8mmGCQbQVZPNTYF+hkxKKOifs32C1FsMmybpXGHOIOUZaciL/jaVMn CQ4u9g7q/F3Vab3BGSorg== X-UI-Out-Filterresults: notjunk:1;V03:K0:dagzQnkpn9I=:Nw5biJ7jPuP1i8Hw0UqDqi YxGHcsr97lk/B/wDMVI+Np9HtAt1RaYmxZBfQ2sTOnT/WPZDyqJjhN3fQtOVTf0d0hOm1UUL1 p6wk+PqYO6cx8veId92DqKckg+lolhy22SQUlrT3ux6kYU5mSHiFFTyEpkoVH1zS9yMovEEOX gwcLerDIpQJrN/3CVm1thxxpVDsuj3S42ZlbivYt9dWYG7CXiJchybndnU/SHqT1mR6Awv1+4 AktDUBtB6dhbe8kf7mtuVjeGlYnKy8Lgu8zfDHwVx5qUHyKdf8ySDADDzbnlL9BJyudWLM1h7 G8V3ftJu9vh2rtqCDKsJ8CPTVMn+IV23b1oHu0WJP/XQcQ7tUK0UfGZRrNaLrpgyls7OsSuPO nJQJOs9jfjDG3WZDViBt7ACLBLOsPi38hhTByh9GgKjKGEKo4t/Ji6tFAM4sLP/3isuanUmse /KUkUwYniGeSRFllPPLuPWC3dv20e47wucCGeEJEcNYHWjtty/OoRjRyAIFC15Sb6goV3OVXF 79rNNiTPNbDvYbbfjZWw8fYibjOf1+UF5YFtMu3hZQHWpKKJ5XOHZmnLWeOR69db5wgZkzsiX RSXgNok02+Vt+ectpUdyPPPuw0meeULPzvExRpVRvPXlfeMrbfzo2m0T+vtob50fYzpx5W5qF j516YHo/JSvB78QwkkJAY3S6VF6eZvRyYkvJ2347H1/7Kk7FC3GmVmLXGnoitNyIatBaqo+ud Gn9EPJtAVyzLNZ1bEzw4qYBhexe+HYmg46Bqc4JhEkl/YMOobVaVYPij3bxPVuQ4aLwZS6t5T cTaRm5g5O7oSFlDvPFBB2/QTn2OlYM/NHnWCeO5Dch48zmF1ox85n3ZipPkbHbQxmdl2KY+ Received-SPF: none client-ip=212.227.126.133; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/01 10:10:07 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Laurent Vivier , Greg Kurz Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Greg Kurz I had stopped using gkurz@linux.vnet.ibm.com a while back already but this email address was shutdown last June when I quit IBM. It's about time to map it to groug@kaod.org. Signed-off-by: Greg Kurz Reviewed-by: Philippe Mathieu-Daudé Message-Id: <159724665142.75339.817685642171828648.stgit@bahia.lan> Signed-off-by: Laurent Vivier --- .mailmap | 1 + 1 file changed, 1 insertion(+) diff --git a/.mailmap b/.mailmap index 4f40d1cc6e1b..b914c9e290e0 100644 --- a/.mailmap +++ b/.mailmap @@ -48,6 +48,7 @@ Alexander Graf Anthony Liguori Anthony Liguori Filip Bozuta Frederic Konrad +Greg Kurz James Hogan Leif Lindholm Radoslaw Biernacki From patchwork Tue Sep 1 14:09:34 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 1355056 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=vivier.eu Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4Bgq4h230Dz9sVd for ; Wed, 2 Sep 2020 00:21:24 +1000 (AEST) Received: from localhost ([::1]:55062 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kD7A2-0002ei-56 for incoming@patchwork.ozlabs.org; Tue, 01 Sep 2020 10:21:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55364) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD6zO-0005bm-Jy; Tue, 01 Sep 2020 10:10:22 -0400 Received: from mout.kundenserver.de ([212.227.126.187]:34691) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD6zJ-0003q1-D6; Tue, 01 Sep 2020 10:10:22 -0400 Received: from localhost.localdomain ([82.252.135.186]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MO9qz-1jxuYe0rxx-00Oajk; Tue, 01 Sep 2020 16:10:13 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 24/44] docs/system/target-avr: Improve the AVR docs and add to MAINTAINERS Date: Tue, 1 Sep 2020 16:09:34 +0200 Message-Id: <20200901140954.889743-25-laurent@vivier.eu> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200901140954.889743-1-laurent@vivier.eu> References: <20200901140954.889743-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:ZE42EJ6lYk1XVAUwqnV+LgGkzDrF5g9Ly3o1vyWJimPTCjldwak iJHMQZrCkahow97Y6AyWM+yiRPLBlYDynHsFP/w6/VPH1brAdXBU+I0luWw2Qo+61V63VE/ MTpDNbc11aydduTmcmZZiHfEdf1uLltgX+n2xH47ju7q8S2FjLnP553wlZW2g0KSKl7L1Lq v3nAsVgSTR/RNh3+EfGqg== X-UI-Out-Filterresults: notjunk:1;V03:K0:8Jck6vwPhoE=:aV8pTtyIC3Fjp9TYUWZ8up Whet0dcX+K+smqDbdey9NOSvOvNy3XFBiTjrhNhcAetJ2KVYkQZkgagjnYRphEK3J8MYo6gmu ZpLd3xLyAfg+rqpaBVRoz1lxLaFuJFpeUycp/czE4emRwQqgvOI2c/SuxdkAI3j48APZA50aS DlIE8VLVA7RZilP3W6PYeQh6wu7KNCOLMRCuKvXhQY617oiHk9wkmcD+qDF3j6dXBHWAso9Ef 44TA3xgIIOfmui9yaiwlMwM2vDwz5LZzmhwfUqpryjsDO/aUnOqZRix/Nm7W2EJ1bbHCloMDm V+VA7jj/tLEos56UkIaeYnlJWXIBYKCXhfrOR3fMUUsIIzP2BztHA7/D94RkDdZAhdqrokxjW zVpT5eZynuRTRuXo7DnkBhkJPdmKhhBeF16Ln83ekbn5G34Q6fCyNjWlf6kNKpTJx5akUofED I5sP7BEQNlLGuRlox+FoN96pN75YlUco6wMvKC3OLbmHegqKIVPPAWgmZgg3EOQYJo5iwxSj/ So+R0pW9ZRR1g70zYWx9saP2v2TnhgnGhITXnmiaWgFJ7G/dCBnpKNEOw0aF/h/9oboYezcJK Hpziw9NabLWCTw1e7YggoTZK1O4xScshuLulabfgQlyVF3AIgC34wJpPvC4qm+y6EOvP38+Ji yzh3W9RyuaQn5Ux9Gb/doU4ZJ47Q4Vb/GmCElMcXEh38g80fQOzdyqEnnCm5g9yr4L+czLoa3 attttfAYF/cnvFIfxIiq1vBFbW0P/9rgQ0i5q4BwK5iXgdJkZUEUNHr2PLi0XPyU6FjzQ3/PL x02rEhbqb9Q/s7r9x8z3DbCkjoO/4ycJskAsYmTT8KAxuTC0NPHC+qVHwX3ibqJyHvOl8yQ Received-SPF: none client-ip=212.227.126.187; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/01 10:09:57 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Thomas Huth , Richard Henderson , Laurent Vivier , Michael Rolnik Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Thomas Huth The examples look nicer when using "::" code blocks. Also mention that "-d in_asm" only outputs instructions that have not been translated by the JIT layer yet. And while we're at it, also add the AVR doc file to the MAINTAINERS file. Signed-off-by: Thomas Huth Reviewed-by: Richard Henderson Reviewed-by: Michael Rolnik Message-Id: <20200812155304.18016-1-huth@tuxfamily.org> Signed-off-by: Laurent Vivier --- MAINTAINERS | 1 + docs/system/target-avr.rst | 47 +++++++++++++++++++++++--------------- 2 files changed, 30 insertions(+), 18 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 5a22c8be4296..b5ba553ee01a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -171,6 +171,7 @@ AVR TCG CPUs M: Michael Rolnik R: Sarah Harris S: Maintained +F: docs/system/target-avr.rst F: gdb-xml/avr-cpu.xml F: target/avr/ F: tests/acceptance/machine_avr6.py diff --git a/docs/system/target-avr.rst b/docs/system/target-avr.rst index dc99afc895d0..eb5c513cce09 100644 --- a/docs/system/target-avr.rst +++ b/docs/system/target-avr.rst @@ -17,21 +17,32 @@ https://github.com/seharris/qemu-avr-tests/blob/master/free-rtos/Demo/AVR_ATMega Following are examples of possible usages, assuming demo.elf is compiled for AVR cpu - - Continuous non interrupted execution: - ``qemu-system-avr -machine mega2560 -bios demo.elf`` - - - Continuous non interrupted execution with serial output into telnet window: - ``qemu-system-avr -machine mega2560 -bios demo.elf -serial - tcp::5678,server,nowait -nographic`` - and then in another shell - ``telnet localhost 5678`` - - - Debugging wit GDB debugger: - ``qemu-system-avr -machine mega2560 -bios demo.elf -s -S`` - and then in another shell - ``avr-gdb demo.elf`` - and then within GDB shell - ``target remote :1234`` - - - Print out executed instructions: - ``qemu-system-avr -machine mega2560 -bios demo.elf -d in_asm`` +- Continuous non interrupted execution:: + + qemu-system-avr -machine mega2560 -bios demo.elf + +- Continuous non interrupted execution with serial output into telnet window:: + + qemu-system-avr -M mega2560 -bios demo.elf -nographic \ + -serial tcp::5678,server,nowait + + and then in another shell:: + + telnet localhost 5678 + +- Debugging wit GDB debugger:: + + qemu-system-avr -machine mega2560 -bios demo.elf -s -S + + and then in another shell:: + + avr-gdb demo.elf + + and then within GDB shell:: + + target remote :1234 + +- Print out executed instructions (that have not been translated by the JIT + compiler yet):: + + qemu-system-avr -machine mega2560 -bios demo.elf -d in_asm From patchwork Tue Sep 1 14:09:35 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 1355066 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=vivier.eu Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4Bgq7m0pBsz9sTK for ; Wed, 2 Sep 2020 00:24:04 +1000 (AEST) Received: from localhost ([::1]:43486 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kD7Cc-0001IX-0n for incoming@patchwork.ozlabs.org; Tue, 01 Sep 2020 10:24:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55474) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD6zS-0005mA-8o; Tue, 01 Sep 2020 10:10:26 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:37339) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD6zO-0003wY-Od; Tue, 01 Sep 2020 10:10:25 -0400 Received: from localhost.localdomain ([82.252.135.186]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MoNy4-1kxTNF3wSW-00okWT; Tue, 01 Sep 2020 16:10:14 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 25/44] hw/ide/core: Trivial typo fix Date: Tue, 1 Sep 2020 16:09:35 +0200 Message-Id: <20200901140954.889743-26-laurent@vivier.eu> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200901140954.889743-1-laurent@vivier.eu> References: <20200901140954.889743-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:Pyw0ZMEU7SgQFHutlITOWvz+cr+9whX18HAoSlliGteLCv9PN8T kbvHU2RKMwLZPzhmEOwgSOnOHU6yk11YBWl2nIo3al5XL5Y6FsBdZyc658kIsPxZDYGWJsS R2j8kZcjBul7QUZDUSEX171jbO2/M5+ccFx4CA1TGmBEhq9XgEl3FUebAO5LL78005OGONG qy2XHqpzgqC0DvzBKqngA== X-UI-Out-Filterresults: notjunk:1;V03:K0:oMPzd5tmRqc=:lByhKLSp9ibkziAngfx7Cp CJ7cJsOaPyLZZyB+fhYAU9MoVcV0Tsr60IMyl8wgjrAK/mvuTfgt8znOfVKw19lf7c3L8Kl/Z HUwFQdxKnd7ZC3od4nQWoELw8WV4gAdXdT7aomkotP23LFhO0oTzXErQysLvC3uuTDJbYw4nI VPz9Oq2xI0p8dt0smOehiwD/iuzUYMTF47zBLu3enH9qJZxfLsUM7ly+vxu0OZs4ftX9iYhXw 5Fog0/YQtt3TvATmdARBA3bBTfjNsRERDDertulSDQC6qKknB+1BdkMmzdojBLwYknMkTuESe NOJsTjhaDUi7B7g3CkWxv/OIQQj2rYbYRPxgPGjVOT3nhu3eA4VCF8fXkzMRl+SuBt/ntIKRp lbJ0eKcnqg1gN3xYpQBeZnJv1MCdF+OORbILg9hp47souZygH1D29kp/yd5D93rfcl289ZdAl TjFVWl3b2I4QCyG7v8xOYvZBfQI7cJZkpIwXz3a4QS21NdaYWOt6mRpnqwty2KJLlC7+Sifrs FffHTXGjH76881GSSm3uvZmga/gHsfRBkXgkfeOhNuFldNOwJcA+AuaLkgV7Hsi+bfGZgmcB7 oVLIiF/iLGJ02eqPKXaprUJrsB79y9lDx3S+IQGz5yUmBhS99bMT02AG+0GuqmjxNNHjY/ioN WR8fB4B+PWxK9fpoGm1JogAkEe0SOOO3Wo1lp9ixv3BKWSCM5SpkgoKZo8EKwc6eewciBwZ3X UutV8ulSs3T51Ag8J57PNBw2Pc93z8VEmLEjudZXYS3WyLPZIXZ+yw+cHJhs3QQX2FbeDv3S5 qElKGz6ZlYHS7Lm3Tf95ujoI0k/QxCB05BxJLRQ8WfRRu4YfnSm03AZgwpfE1fmb8DmdA+a Received-SPF: none client-ip=212.227.126.131; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/01 10:10:10 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , qemu-trivial@nongnu.org, Li Qiang , Richard Henderson , Laurent Vivier , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Stefano Garzarella Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Kevin Wolf Reviewed-by: Li Qiang Reviewed-by: Richard Henderson Reviewed-by: Stefano Garzarella Message-Id: <20200814082841.27000-3-f4bug@amsat.org> Signed-off-by: Laurent Vivier --- hw/ide/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ide/core.c b/hw/ide/core.c index d997a78e47fe..f76f7e5234bc 100644 --- a/hw/ide/core.c +++ b/hw/ide/core.c @@ -709,7 +709,7 @@ void ide_cancel_dma_sync(IDEState *s) /* * We can't cancel Scatter Gather DMA in the middle of the * operation or a partial (not full) DMA transfer would reach - * the storage so we wait for completion instead (we beahve + * the storage so we wait for completion instead (we behave * like if the DMA was completed by the time the guest trying * to cancel dma with bmdma_cmd_writeb with BM_CMD_START not * set). From patchwork Tue Sep 1 14:09:36 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 1355057 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=vivier.eu Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4Bgq4r1zMbz9sVk for ; Wed, 2 Sep 2020 00:21:32 +1000 (AEST) Received: from localhost ([::1]:56086 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kD7AA-00035p-52 for incoming@patchwork.ozlabs.org; Tue, 01 Sep 2020 10:21:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55432) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD6zQ-0005hX-IS; Tue, 01 Sep 2020 10:10:24 -0400 Received: from mout.kundenserver.de ([212.227.126.135]:52125) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD6zN-0003uX-Un; Tue, 01 Sep 2020 10:10:24 -0400 Received: from localhost.localdomain ([82.252.135.186]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MYvTs-1k8f0I2cWe-00UsG5; Tue, 01 Sep 2020 16:10:14 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 26/44] hw/ide/ahci: Replace magic '512' value by BDRV_SECTOR_SIZE Date: Tue, 1 Sep 2020 16:09:36 +0200 Message-Id: <20200901140954.889743-27-laurent@vivier.eu> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200901140954.889743-1-laurent@vivier.eu> References: <20200901140954.889743-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:xxDhq+TV0IfhP9YC17vf1ffp70QmhzJ+LSLjKKD9ZRHGqPWKsWI dfMp6LQG9bu0HuMAOhgCjrfL4jmvrzdVCMHJCKzHMrTMO8pTnrj0JUXGDPhqy9RjENZYxDk ZeqE0vMA+F9m07Q7KsL1ucznABmEKRh3aBMiRuLFOzEjexUZQCJaH95fnYrNdju4X0N+bqu ml90btsCLsq6qiwbXix/w== X-UI-Out-Filterresults: notjunk:1;V03:K0:D8jVz6yqPOU=:xLlTOrRID3d6tMfvRLF1Mp M7hjRbUmlidApPd0IsDWxMTLXVM1V8yTNCkMIZh9mUa3yLQPpK7T8zbEoUWvGMJN5H8NO5XCN CInWGHTtdKkKGeV9dCT8grtgUPLntUJuPCttFshMnLjgPOH0UqL7UvTVXca9GWb4na2+s0ANl rH5PV23JuqZSkCIcxhcHR3CD42/GHyzUb+dKdMFVXkBIJWS6Y01OB+9n7MhpT0pmKc3ICetvn rSzQac05LCNWWxdawI0uJtQBeMjTVSmkM5sdaQi8Bo37OepCT2llLZVLqfr0wW6XUyE1sy+v/ byj5SxvFZOYX9bPF3LhmfYWK9+VMv62e3MW0xfKToZMFRVgkbZ+aZl1i0sv2OSxejO51fcQjY FKddVNk1MLTNRz8Wh4cfXC0yTxExLqYSbG9t14XeoGnDfx53dc0Kph4m3Fl4BjB5N51A+zAw1 1e983eLJBN2ORK4UQVMqKCwj4q/+XWwRrxZVdkp2iR/AdQ+b7hXeCY2ZC5iIBgIx6k+T/3zSu Fvrq/96h/cYNpzuiJV8N/8Ovdhdp4YYEZtDOIGGagXsQuMkOROIvdkl0mHlKwfF2mc8xijNRb BnKu7JiOE5OENTWSiNHHPAy7k7RNDLf4Aj9+PLdowls3PZMyeDckmBI2lg7ZbU0IMCsF+zkUu ssOaLBYXD2cnXa2LwS+xqQCk9QGsupLJEikydcjCufwJ0zkoGjhb5JOkKK4UzNbZobPQRt1ES 5eLDYu21KGZMdqjcq3rzeZ5Us6QrHVbDgy0/s8qPQkClJqlEjGjniD4LD3Z/cVZzRCkcXee1m xgZeNSXjowMALY5VkOXiXqVMydB4KVX1ZAeZfCmN7oUThp/afhMt8VqLdiYN4q92jeYInAy Received-SPF: none client-ip=212.227.126.135; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/01 10:10:07 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Li Qiang , Richard Henderson , Laurent Vivier , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Stefano Garzarella Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Philippe Mathieu-Daudé Use self-explicit definitions instead of magic '512' value. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Li Qiang Reviewed-by: Richard Henderson Reviewed-by: Stefano Garzarella Message-Id: <20200814082841.27000-5-f4bug@amsat.org> Signed-off-by: Laurent Vivier --- hw/ide/ahci.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c index 009120f88b78..b696c6291a38 100644 --- a/hw/ide/ahci.c +++ b/hw/ide/ahci.c @@ -1151,7 +1151,7 @@ static void process_ncq_command(AHCIState *s, int port, uint8_t *cmd_fis, if (!ncq_tfs->sector_count) { ncq_tfs->sector_count = 0x10000; } - size = ncq_tfs->sector_count * 512; + size = ncq_tfs->sector_count * BDRV_SECTOR_SIZE; ahci_populate_sglist(ad, &ncq_tfs->sglist, ncq_tfs->cmdh, size, 0); if (ncq_tfs->sglist.size < size) { @@ -1703,7 +1703,8 @@ static int ahci_state_post_load(void *opaque, int version_id) return -1; } ahci_populate_sglist(ncq_tfs->drive, &ncq_tfs->sglist, - ncq_tfs->cmdh, ncq_tfs->sector_count * 512, + ncq_tfs->cmdh, + ncq_tfs->sector_count * BDRV_SECTOR_SIZE, 0); if (ncq_tfs->sector_count != ncq_tfs->sglist.size >> 9) { return -1; From patchwork Tue Sep 1 14:09:37 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 1355059 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=vivier.eu Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4Bgq5h01Hkz9sTH for ; Wed, 2 Sep 2020 00:22:15 +1000 (AEST) Received: from localhost ([::1]:60536 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kD7Ar-0004vJ-FC for incoming@patchwork.ozlabs.org; Tue, 01 Sep 2020 10:22:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55466) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD6zS-0005lO-17; Tue, 01 Sep 2020 10:10:26 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:34003) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD6zO-0003vM-9z; Tue, 01 Sep 2020 10:10:25 -0400 Received: from localhost.localdomain ([82.252.135.186]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MF39M-1kO8YZ1I88-00FPlt; Tue, 01 Sep 2020 16:10:15 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 27/44] hw/ide/atapi: Replace magic '512' value by BDRV_SECTOR_SIZE Date: Tue, 1 Sep 2020 16:09:37 +0200 Message-Id: <20200901140954.889743-28-laurent@vivier.eu> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200901140954.889743-1-laurent@vivier.eu> References: <20200901140954.889743-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:XxvDiAfEEf/04NBgoBcF9pZo4GWfl/h/H5eA0RtNc1GoJBaRxzA 7a9L0pf3xltRzut/4I+nLUEaJWFqpMvKfrOeDM9I3xERbD43UbkrUA+9p8hBPwXlyArULK1 CXzApjMmspuv/hmZwE9HWixkBa0meLnVX/A4V/jz2fb6SceC86ExY8ufbQPWnC76aCxbkAh WUsHLH/egpmzl9uyynddg== X-UI-Out-Filterresults: notjunk:1;V03:K0:0j5L6IFBVXQ=:YWRmFRVEYEl7NwFBvgwZ1N zvL1EzYmCwBE3cQcgxjRRWGUkAn/zT9b480225Dn7QoLaWOZzaiuNjr7r20X0Jvll/vMAPLNF OsMIlYBe6H5cR87DnZ/UP9OkF+HYLozgPSE3TWiChI2hsjWZehXbrFFiAB10wjmN0ldbXAtsx po0/k4V3Ix58G9Qtlj9HRgbEnhaK+DxOxSD2Sl029CW+04PyLMtv19P5dKwBVPAHVncn55cm2 a2Rq3zClLO5LDeDtgkboMfJTTZkXr1GhpwzbYfirbEeOov3gwJ2R30BbSGIJsf7fZRwiCMp/R sEMHu4YgujNHRRWEaZoaS3fVAb4OdZUoCEbmZ6QGHanAY7SrJXDHZ7gt2feuXWUv3x0B+D2QU 0Ui1GHmCXFeIRcNH2bOF+Oly2niUMmEQNss2KVsuuJ/GcQ1kgiVFJ6G4TQuGqqVjOXtiQH7JF m+fIfvvXYV9tyq/4yygp0tMledU2QKZDHIHj6t0X8FYmGuFjN1tpAUlLCxvOsoMx+9h0v663v em5i36dE/z+3bhich2E9j0QA9NurAsGznT5kTJGkBVGA1xEX9fNuIC10WLUKseNs0evqf1Zfe W2Dt6Llncn1OSQ0S2Wn5m3crZbgUg4uDwF8jvUsdUJcEYxHYFPKSGzUaqglEEwpyrlwQ0lHFc F5xQ54UzUq0VQ0jmmt/LT4s3QIdmtJey1FEcB5gBquhz+CAwYxkLynTQ2VG91Tto68/77QXQZ RYwwsAfZlD3HzaDrIKdrcm2M+nebtiGKKrbiUqahq5TYEzLVhqMMg6wdMQAe6gecSR2VQDeYi KYWuECHweCBd7bOzY3tSfV0SJ0cod7/ZE5/btHURtriSyFysd4VTIQmmKUXFtxlpHo16cN+ Received-SPF: none client-ip=212.227.126.131; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/01 10:10:10 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Li Qiang , Richard Henderson , Laurent Vivier , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Stefano Garzarella Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Philippe Mathieu-Daudé Use self-explicit definitions instead of magic '512' value. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Li Qiang Reviewed-by: Richard Henderson Reviewed-by: Stefano Garzarella Message-Id: <20200814082841.27000-6-f4bug@amsat.org> Signed-off-by: Laurent Vivier --- hw/ide/atapi.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/ide/atapi.c b/hw/ide/atapi.c index 17a9d635d842..14a2b0bb2f8a 100644 --- a/hw/ide/atapi.c +++ b/hw/ide/atapi.c @@ -824,9 +824,9 @@ static void cmd_get_configuration(IDEState *s, uint8_t *buf) * * Only a problem if the feature/profiles grow. */ - if (max_len > 512) { + if (max_len > BDRV_SECTOR_SIZE) { /* XXX: assume 1 sector */ - max_len = 512; + max_len = BDRV_SECTOR_SIZE; } memset(buf, 0, max_len); @@ -1186,8 +1186,8 @@ static void cmd_read_dvd_structure(IDEState *s, uint8_t* buf) } } - memset(buf, 0, max_len > IDE_DMA_BUF_SECTORS * 512 + 4 ? - IDE_DMA_BUF_SECTORS * 512 + 4 : max_len); + memset(buf, 0, max_len > IDE_DMA_BUF_SECTORS * BDRV_SECTOR_SIZE + 4 ? + IDE_DMA_BUF_SECTORS * BDRV_SECTOR_SIZE + 4 : max_len); switch (format) { case 0x00 ... 0x7f: From patchwork Tue Sep 1 14:09:38 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 1355062 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=vivier.eu Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4Bgq675p9Dz9sR4 for ; Wed, 2 Sep 2020 00:22:39 +1000 (AEST) Received: from localhost ([::1]:35038 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kD7BF-00064j-Ne for incoming@patchwork.ozlabs.org; Tue, 01 Sep 2020 10:22:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55452) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD6zR-0005jW-9W; Tue, 01 Sep 2020 10:10:25 -0400 Received: from mout.kundenserver.de ([212.227.126.134]:57419) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD6zO-0003ut-3A; Tue, 01 Sep 2020 10:10:24 -0400 Received: from localhost.localdomain ([82.252.135.186]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MuluN-1kUVHQ4BVr-00rsoo; Tue, 01 Sep 2020 16:10:16 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 28/44] hw/ide/pci: Replace magic '512' value by BDRV_SECTOR_SIZE Date: Tue, 1 Sep 2020 16:09:38 +0200 Message-Id: <20200901140954.889743-29-laurent@vivier.eu> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200901140954.889743-1-laurent@vivier.eu> References: <20200901140954.889743-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:bTgl6P/Ee+6znIidnx6ahoDV8qX8jOCR51ZVN3cq8jLGLm1bL/4 2Q6GsgZd1K+bSzlc1wt0bdU0Ek8ieKjHBRyxkwu9YvLE2HyyzOvyo12c0hRQnFdr0GBEqLL IDxikjRmln9enzwX2Yi7yhuDvEmZefmv7nsRBkiR2grkNFkMUHekX7sXZRgSKL87y19j3E/ VOPkDffIJIlHnp72Iln+A== X-UI-Out-Filterresults: notjunk:1;V03:K0:tg9Os5e/Y28=:hkidTrcs+hBv1EBwiT3E8G 0Ncaz796ymjoBOrgk5r/H2B77OBq40wdquxm0a7QGA15t+ZJyR2qVpHR9PAzq8EJ4ZtOJYiuq +Nyb/7uHyj9htE7o7t3/eU8r74/C9dNTw11hVohkSNUndih00cvbJ64Go+XoQBr30/vdaFm48 xjsR94QgVTEtBwHrqy/E+4uRWfr3qQ7MvEq1rMlpDFG0P8oPBjlZVd92sUX/JgClfzihUu2zP I06fEHO3KJixOI9KDoDZcIQlZCwOrOFsIjXAkbsMUL0RtKb4f9oIVRtlvCApVGhoSSQwjH+33 wQbCriH9bKA2v9WBMeP8WEjpU03yeT0ORTEL6vJXsflLGh2DFKMXXrOozg1OaZZDCCyD83oEB 8Qjtp+cvfTxz5VsicEOxFn1v/z3bKAW+0fRmZpNaSMBo4PUdfiAsHf2xJBR/YiW3EjOusrpO7 Leb5PxUwQTCRo+KAfwtlLlVfFftsdpuLyu/5sVuDh3hRlEXcWgE4Yb2Id/D9o1ndhYtjP+BlE zOpMwQeFeg7RbsuTZonDLPsJdtuReVxq4N2h9b8hm4PZLX89dhlU/oMJJycvCIE74AHESXEtq JsEPQqZQoh4mgUNgsByNW7rBfWsKOz5cjr1tYoOt+D0m185Vcs8qD+g5FLEnuOdf08yOYZo8o WfBmRaEZy0+iZV+SaHup4344TR2F4/vzZ7OBcyH+Ox3wp/rhNWWOP6ZeOhPb/qcsVGesaZxjA K6zgD/GfR26ounsHeHx9uDJyGioDnGgRmCdAlFEFXV6qKOs1VvSofN0rwO+eXaxuSVoTzZb9Q niizjZdMwWgIl/WCnJa+IU1OufAf2vnXA1BkIbdLZPlDhh2oeYMQLCOLBB38tbqa8TNCJDt Received-SPF: none client-ip=212.227.126.134; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/01 10:10:03 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Li Qiang , Richard Henderson , Laurent Vivier , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Stefano Garzarella Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Philippe Mathieu-Daudé Use self-explicit definitions instead of magic '512' value. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Li Qiang Reviewed-by: Richard Henderson Reviewed-by: Stefano Garzarella Message-Id: <20200814082841.27000-7-f4bug@amsat.org> Signed-off-by: Laurent Vivier --- hw/ide/pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ide/pci.c b/hw/ide/pci.c index 5e85c4ad17e0..b50091b615cb 100644 --- a/hw/ide/pci.c +++ b/hw/ide/pci.c @@ -138,7 +138,7 @@ static int32_t bmdma_prepare_buf(const IDEDMA *dma, int32_t limit) int l, len; pci_dma_sglist_init(&s->sg, pci_dev, - s->nsector / (BMDMA_PAGE_SIZE / 512) + 1); + s->nsector / (BMDMA_PAGE_SIZE / BDRV_SECTOR_SIZE) + 1); s->io_buffer_size = 0; for(;;) { if (bm->cur_prd_len == 0) { From patchwork Tue Sep 1 14:09:39 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 1355065 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=vivier.eu Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4Bgq7S39NKz9sR4 for ; Wed, 2 Sep 2020 00:23:48 +1000 (AEST) Received: from localhost ([::1]:41606 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kD7CM-0000VM-98 for incoming@patchwork.ozlabs.org; Tue, 01 Sep 2020 10:23:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55494) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD6zT-0005qr-EP; Tue, 01 Sep 2020 10:10:27 -0400 Received: from mout.kundenserver.de ([212.227.126.133]:49971) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD6zP-0003x6-GM; Tue, 01 Sep 2020 10:10:27 -0400 Received: from localhost.localdomain ([82.252.135.186]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MfpGL-1koumX3uO1-00gG4y; Tue, 01 Sep 2020 16:10:17 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 29/44] hw/scsi/scsi-disk: Replace magic '512' value by BDRV_SECTOR_SIZE Date: Tue, 1 Sep 2020 16:09:39 +0200 Message-Id: <20200901140954.889743-30-laurent@vivier.eu> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200901140954.889743-1-laurent@vivier.eu> References: <20200901140954.889743-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:VctxRDI2bXcWpd7d+kSybLSYQKi5P11DeTolnm84WZvO9ipCXIG q8rHw5sjxHrQ3pRrmWcW7sEl4y9h0NWZDc/vbg/dFbk6Z2lSj2sse9qsfzl7Op8a2UIi4Bk iy5igbitoNEZVNooHvZVr12Ds3nzhCTRMZS8wusmRQyVMv51KpnCkktjkNjQFgD4Ce3S5i7 /UWRfA7gXAKp9By1LKdCA== X-UI-Out-Filterresults: notjunk:1;V03:K0:MBro4QvSGxM=:G7OACUmsFn20ySSwNc81Dq wC9JSngnU8yax+/2gq8DEBHxrjSj1L3torXUC3nYw4tLsI/M6K9ZRlQll6UGa1HGpnT30ihax PCaaABxsgt4a9xC8lGzbpKgp/qNvNUfiIguLwLGBIPPjRCvLPwQrzBIjgQVjnf30WFCaQf/+0 Apzk9jfv779TLt+4Iasj59SDJqWbycFNjIftavy1tDAE8Pl+XOcVVUx511CEDeWduuhvDKU6m JwxByksbm3L30mXriCtIPRAvUFyiYfe5tjA7ljARsvK3p7RkFdu5ZChp7EzH8UdTOp5WQEDoo 79DCQp/LTelYDVSXmjGUreZJtR+451Lty1Is74GNREauccqvDLfUa4ftTbDgnh5BLZ3sQCX2/ /QKDPHLN1SzpGqXhFNFkHjGV0oIWTNgv5XwlGvUh3ynOHaysPe8TzKRWA6eci+szmy+r56aVQ 88cNmzc/Mi8gQn1FDPdNg6zRUVZBodVdTazeTzovmoVgSlou4oED3YRlb2wY3MsGWzmI1OgL6 K7YMQIsohXXeICgeaX6+4HVw8MZByzQ2d4NCmh8yOWh/I+KyRBlLzsqHVurTEXUk4vd//lACp f8fXp2TFFcz3odoMhDeBEUMJkFwmt8rHX69BA7+SqSgzY+6j1ZeJqBdaAOliHu6N5z0p7GxiZ iZkow1OG7kqhVIJtHioQ/a4KRKq+Qa9d2+8dd3egeGd5d3WbhBllqERlvaHDULWVnpsadbHmX FN1UFRrx33LvV8P4jAYMSddwcgvgDUIFe+9hiJwx/6/4pid0zAz+mqFQebhzsrJAMl1sX4hv0 kKzTDx3YtzpX5F3Rvvk3bRRxElAe6mDBLYfc1bZYUk9lbOscKiUxQ/KF+HdW4UReHcTUcIW Received-SPF: none client-ip=212.227.126.133; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/01 10:10:07 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , qemu-trivial@nongnu.org, Li Qiang , Richard Henderson , Laurent Vivier , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Stefano Garzarella Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Philippe Mathieu-Daudé Use self-explicit definitions instead of magic '512' value. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Kevin Wolf Reviewed-by: Li Qiang Reviewed-by: Richard Henderson Reviewed-by: Stefano Garzarella Message-Id: <20200814082841.27000-8-f4bug@amsat.org> Signed-off-by: Laurent Vivier --- hw/scsi/scsi-disk.c | 44 +++++++++++++++++++++++--------------------- 1 file changed, 23 insertions(+), 21 deletions(-) diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c index 8ce68a9dd64a..7612035a4e4b 100644 --- a/hw/scsi/scsi-disk.c +++ b/hw/scsi/scsi-disk.c @@ -71,7 +71,7 @@ typedef struct SCSIDiskClass { typedef struct SCSIDiskReq { SCSIRequest req; - /* Both sector and sector_count are in terms of qemu 512 byte blocks. */ + /* Both sector and sector_count are in terms of BDRV_SECTOR_SIZE bytes. */ uint64_t sector; uint32_t sector_count; uint32_t buflen; @@ -141,7 +141,7 @@ static void scsi_init_iovec(SCSIDiskReq *r, size_t size) r->buflen = size; r->iov.iov_base = blk_blockalign(s->qdev.conf.blk, r->buflen); } - r->iov.iov_len = MIN(r->sector_count * 512, r->buflen); + r->iov.iov_len = MIN(r->sector_count * BDRV_SECTOR_SIZE, r->buflen); qemu_iovec_init_external(&r->qiov, &r->iov, 1); } @@ -311,7 +311,7 @@ static void scsi_read_complete_noio(SCSIDiskReq *r, int ret) goto done; } - n = r->qiov.size / 512; + n = r->qiov.size / BDRV_SECTOR_SIZE; r->sector += n; r->sector_count -= n; scsi_req_data(&r->req, r->qiov.size); @@ -505,7 +505,7 @@ static void scsi_write_complete_noio(SCSIDiskReq *r, int ret) goto done; } - n = r->qiov.size / 512; + n = r->qiov.size / BDRV_SECTOR_SIZE; r->sector += n; r->sector_count -= n; if (r->sector_count == 0) { @@ -1284,7 +1284,7 @@ static int scsi_disk_emulate_mode_sense(SCSIDiskReq *r, uint8_t *outbuf) } else { /* MODE_SENSE_10 */ outbuf[7] = 8; /* Block descriptor length */ } - nb_sectors /= (s->qdev.blocksize / 512); + nb_sectors /= (s->qdev.blocksize / BDRV_SECTOR_SIZE); if (nb_sectors > 0xffffff) { nb_sectors = 0; } @@ -1342,7 +1342,7 @@ static int scsi_disk_emulate_read_toc(SCSIRequest *req, uint8_t *outbuf) start_track = req->cmd.buf[6]; blk_get_geometry(s->qdev.conf.blk, &nb_sectors); trace_scsi_disk_emulate_read_toc(start_track, format, msf >> 1); - nb_sectors /= s->qdev.blocksize / 512; + nb_sectors /= s->qdev.blocksize / BDRV_SECTOR_SIZE; switch (format) { case 0: toclen = cdrom_read_toc(nb_sectors, outbuf, msf, start_track); @@ -1738,9 +1738,10 @@ static void scsi_write_same_complete(void *opaque, int ret) block_acct_done(blk_get_stats(s->qdev.conf.blk), &r->acct); - data->nb_sectors -= data->iov.iov_len / 512; - data->sector += data->iov.iov_len / 512; - data->iov.iov_len = MIN(data->nb_sectors * 512, data->iov.iov_len); + data->nb_sectors -= data->iov.iov_len / BDRV_SECTOR_SIZE; + data->sector += data->iov.iov_len / BDRV_SECTOR_SIZE; + data->iov.iov_len = MIN(data->nb_sectors * BDRV_SECTOR_SIZE, + data->iov.iov_len); if (data->iov.iov_len) { block_acct_start(blk_get_stats(s->qdev.conf.blk), &r->acct, data->iov.iov_len, BLOCK_ACCT_WRITE); @@ -1805,9 +1806,10 @@ static void scsi_disk_emulate_write_same(SCSIDiskReq *r, uint8_t *inbuf) data = g_new0(WriteSameCBData, 1); data->r = r; - data->sector = r->req.cmd.lba * (s->qdev.blocksize / 512); - data->nb_sectors = nb_sectors * (s->qdev.blocksize / 512); - data->iov.iov_len = MIN(data->nb_sectors * 512, SCSI_WRITE_SAME_MAX); + data->sector = r->req.cmd.lba * (s->qdev.blocksize / BDRV_SECTOR_SIZE); + data->nb_sectors = nb_sectors * (s->qdev.blocksize / BDRV_SECTOR_SIZE); + data->iov.iov_len = MIN(data->nb_sectors * BDRV_SECTOR_SIZE, + SCSI_WRITE_SAME_MAX); data->iov.iov_base = buf = blk_blockalign(s->qdev.conf.blk, data->iov.iov_len); qemu_iovec_init_external(&data->qiov, &data->iov, 1); @@ -1980,7 +1982,7 @@ static int32_t scsi_disk_emulate_command(SCSIRequest *req, uint8_t *buf) if ((req->cmd.buf[8] & 1) == 0 && req->cmd.lba) { goto illegal_request; } - nb_sectors /= s->qdev.blocksize / 512; + nb_sectors /= s->qdev.blocksize / BDRV_SECTOR_SIZE; /* Returned value is the address of the last sector. */ nb_sectors--; /* Remember the new size for read/write sanity checking. */ @@ -2049,7 +2051,7 @@ static int32_t scsi_disk_emulate_command(SCSIRequest *req, uint8_t *buf) if ((req->cmd.buf[14] & 1) == 0 && req->cmd.lba) { goto illegal_request; } - nb_sectors /= s->qdev.blocksize / 512; + nb_sectors /= s->qdev.blocksize / BDRV_SECTOR_SIZE; /* Returned value is the address of the last sector. */ nb_sectors--; /* Remember the new size for read/write sanity checking. */ @@ -2180,8 +2182,8 @@ static int32_t scsi_disk_dma_command(SCSIRequest *req, uint8_t *buf) if (!check_lba_range(s, r->req.cmd.lba, len)) { goto illegal_lba; } - r->sector = r->req.cmd.lba * (s->qdev.blocksize / 512); - r->sector_count = len * (s->qdev.blocksize / 512); + r->sector = r->req.cmd.lba * (s->qdev.blocksize / BDRV_SECTOR_SIZE); + r->sector_count = len * (s->qdev.blocksize / BDRV_SECTOR_SIZE); break; case WRITE_6: case WRITE_10: @@ -2211,8 +2213,8 @@ static int32_t scsi_disk_dma_command(SCSIRequest *req, uint8_t *buf) if (!check_lba_range(s, r->req.cmd.lba, len)) { goto illegal_lba; } - r->sector = r->req.cmd.lba * (s->qdev.blocksize / 512); - r->sector_count = len * (s->qdev.blocksize / 512); + r->sector = r->req.cmd.lba * (s->qdev.blocksize / BDRV_SECTOR_SIZE); + r->sector_count = len * (s->qdev.blocksize / BDRV_SECTOR_SIZE); break; default: abort(); @@ -2229,9 +2231,9 @@ static int32_t scsi_disk_dma_command(SCSIRequest *req, uint8_t *buf) } assert(r->iov.iov_len == 0); if (r->req.cmd.mode == SCSI_XFER_TO_DEV) { - return -r->sector_count * 512; + return -r->sector_count * BDRV_SECTOR_SIZE; } else { - return r->sector_count * 512; + return r->sector_count * BDRV_SECTOR_SIZE; } } @@ -2243,7 +2245,7 @@ static void scsi_disk_reset(DeviceState *dev) scsi_device_purge_requests(&s->qdev, SENSE_CODE(RESET)); blk_get_geometry(s->qdev.conf.blk, &nb_sectors); - nb_sectors /= s->qdev.blocksize / 512; + nb_sectors /= s->qdev.blocksize / BDRV_SECTOR_SIZE; if (nb_sectors) { nb_sectors--; } From patchwork Tue Sep 1 14:09:40 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 1355073 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=vivier.eu Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4BgqF00zbPz9sR4 for ; Wed, 2 Sep 2020 00:28:36 +1000 (AEST) Received: from localhost ([::1]:36992 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kD7Gz-00021h-VJ for incoming@patchwork.ozlabs.org; Tue, 01 Sep 2020 10:28:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55496) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD6zT-0005rV-K3; Tue, 01 Sep 2020 10:10:27 -0400 Received: from mout.kundenserver.de ([212.227.126.135]:49385) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD6zR-0003yK-Pm; Tue, 01 Sep 2020 10:10:27 -0400 Received: from localhost.localdomain ([82.252.135.186]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.167]) with ESMTPSA (Nemesis) id 1Mv2tE-1kUmOf3Bi4-00r3s5; Tue, 01 Sep 2020 16:10:17 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 30/44] hw/net/xilinx_axienet: Remove unused code Date: Tue, 1 Sep 2020 16:09:40 +0200 Message-Id: <20200901140954.889743-31-laurent@vivier.eu> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200901140954.889743-1-laurent@vivier.eu> References: <20200901140954.889743-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:n+vFiyHYyYBQqQfH6cYkSjR6+cxuqFt5Hp+vTdtSzSMNljrGceV 3i8MU/Kt/Ke/8vIGr3QSRDFuJ8dBVdaLuAJFGrsFSoQJE2b4YeGdWlchQQRnvcfIUbqgqh1 uzmYh1/F1FqSIvlHOjnRSmzx5vVEoleHAOo+RN8fD5LemhsGY/VgOKD9KKXbdPWIIV2/E4O xfBgMQqvvE4c5fs8578qw== X-UI-Out-Filterresults: notjunk:1;V03:K0:ieP0z49afpw=:+o2uGUoye/c2L4x+d/FpJt UekgvLNw73+PzFQtQp6K5yBgxLlmqTJvF6bwv7bCbywF6R/3AlMyrva+nnpr8pw4NqJ7dvdmO mgpbVnubL8l0hx94FSwsTOwu/+6FmUutSBQGRfRCZEGhSsUuu4hac3cmOz3j5jtrzBMNrt/HT RRFrsnY8wrfxC0R+mzpD160h2OR49bEK5LMh+jyuLtkgazPgMHiYxWtuNKdzPjqv7PGKOqKSI uJTokeLr6u7UOWJzICQvGWOLwDHZcZ5/ZIh2DOkpdqnO7K9dhcST99Dv4Q7H00dDxtalAtNlr qqmmLI/R4yUY2wRMldxiX7iVhBpDKFiTdQdl0yMAq2N+1gW3d3f85xBMo8tk39nD9pMKWyuMi 8oojV3MrDw7B//ZsXHFCUMl6ZL0KlrqXO09P3BMhPIhY9gtiZLF8vIZcyom6TjOqf9/X+Oq1A NPrUu2bDUZFFl2HbUurIl41CMWzQsK9PD6xcmktldgqygQsbv9qskL9qnK62Tv6xVmhhThVGz TJV8UHulJbwjlhwg955IuU3QgJ2hPkTZ2yGNmvDFv0c5B7GR7uSM4GehDpbaSPduN9gCbz6+o PeAHrAhsv4kElOOYp952hnVWZT9TOyGxPTR1FOMsnY+QgjqdprAcpJp0Q3ukYhftQMT3Yr/B+ 5D14l+Jz8C+6Hu5KnTcavxml2Mr1ko4gCoQZh6y++pmPJzMLmNsh2IhRJ8A88LF/3tAbXqiWp DH1FOpwxkRew0r7l2z72Basbowa69rb4dZLo2lwwfGh2rtMuKNBIuBDvC2Q5XSAYaI5tyyHBB bw4DUdfupS+zf0UT4B0MQ6YEdpoXJMl3vyW2jmunnuUIrDzwgRNP1sowIN69K880DPoMEIb Received-SPF: none client-ip=212.227.126.135; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/01 10:10:07 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, "Edgar E . Iglesias" , Alistair Francis , Laurent Vivier , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Philippe Mathieu-Daudé Most of the MDIOBus fields are unused. The ADVERTISE_10HALF definition is unused. Remove unused code. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Reviewed-by: Edgar E. Iglesias Message-Id: <20200814133007.16850-1-f4bug@amsat.org> Signed-off-by: Laurent Vivier --- hw/net/xilinx_axienet.c | 23 ----------------------- 1 file changed, 23 deletions(-) diff --git a/hw/net/xilinx_axienet.c b/hw/net/xilinx_axienet.c index 1e48eb70c9cc..2e89f236b4ab 100644 --- a/hw/net/xilinx_axienet.c +++ b/hw/net/xilinx_axienet.c @@ -54,7 +54,6 @@ TYPE_XILINX_AXI_ENET_CONTROL_STREAM) /* Advertisement control register. */ -#define ADVERTISE_10HALF 0x0020 /* Try for 10mbps half-duplex */ #define ADVERTISE_10FULL 0x0040 /* Try for 10mbps full-duplex */ #define ADVERTISE_100HALF 0x0080 /* Try for 100mbps half-duplex */ #define ADVERTISE_100FULL 0x0100 /* Try for 100mbps full-duplex */ @@ -169,28 +168,6 @@ tdk_init(struct PHY *phy) } struct MDIOBus { - /* bus. */ - int mdc; - int mdio; - - /* decoder. */ - enum { - PREAMBLE, - SOF, - OPC, - ADDR, - REQ, - TURNAROUND, - DATA - } state; - unsigned int drive; - - unsigned int cnt; - unsigned int addr; - unsigned int opc; - unsigned int req; - unsigned int data; - struct PHY *devs[32]; }; From patchwork Tue Sep 1 14:09:41 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 1355070 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=vivier.eu Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4Bgq9V4pbmz9sTH for ; Wed, 2 Sep 2020 00:25:34 +1000 (AEST) Received: from localhost ([::1]:51882 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kD7E4-0004jG-H6 for incoming@patchwork.ozlabs.org; Tue, 01 Sep 2020 10:25:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55498) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD6zT-0005t4-W2; Tue, 01 Sep 2020 10:10:28 -0400 Received: from mout.kundenserver.de ([212.227.126.130]:35029) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD6zP-0003wz-Do; Tue, 01 Sep 2020 10:10:27 -0400 Received: from localhost.localdomain ([82.252.135.186]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MfpGL-1koumZ1XwH-00gG4y; Tue, 01 Sep 2020 16:10:18 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 31/44] util/vfio-helpers: Unify trace-events size format Date: Tue, 1 Sep 2020 16:09:41 +0200 Message-Id: <20200901140954.889743-32-laurent@vivier.eu> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200901140954.889743-1-laurent@vivier.eu> References: <20200901140954.889743-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:XuDq3Ce03C4SUF81OPoY07f5QjJcTQ80clUd/CiCZW6dkdn9M1t t28F1yue3em7V5+lwnmMaaP/8vvLgaGnvgL0xQK/GQRa4X5BSUNtaBDVAX5Nlfu1XL70b6a Id7K2XjkYY2OBPjWLv/Kn17yPO/FKQ8VWD1M7qVZDeeP18NpkycAoqzp3KKFtIi4duIDuZa k99g0rwplU2ylAk3xg6hQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:zV4iK8yvxQA=:7Bv9M84nlan6nC8ZVf8vzP aXztW8fTMT++TnPBcl7qUle3ptDAzn7xQp5rHhgDVO0jK+NfRCmFqBBcgKEkChchepqRcvl0d OM43ixiO/+T3GpRB+aZFHAXHru9O8MRWzDYpJ64CdpBZ5SLjINldpBLBWE+l/kYi8ZhBUdaLx 8mKBnYP0AhVXVDV/UwrZTwGCWsooNRRozPmoORNkTr4/bcs9cMHYeq2M1IqF2a0aQl2XkIYVH vp82kAgz41GieCZFcC2QDkenTenjSVMwbkBIIM6eedXXNlHR/fYTLr5MaLWgtUB20C+XUwnJm spDQQvcGfPAxD094SzwYyooIYJwl73Upk7SF4ebvBuBVHT4ztKysNWjr+0tBZDTCSnoJ5j6fb nHC1F4eIJTuQUCW001SG16JmVHGMcEECaZ7eyqsJbsZQKUjGMAgyYE/+m+SmQxQo8JJA6N507 xZ+wQZra+G8VRXWvj3JlKn9j5GLlqNmu/x+Km9Pwo6hhK16+vqJo//RbkNEp4MIDHNM4AKQ1q qt6HrejWPCXMhbX6bFa3LrQ5MEoDyzVnnZVckWJeX+QVCIofYHyxmGh4RHOlhels3uYd0NixT CbVyC6d5iG1Fu8hOjUoDuVdxRoN56CigHTrxicSbo/dQDryg5fjClUBfsmTOXhJL2as3MRt8X JiKnKw427ZnT9D/5yM6RTJnE924gOmZqkArgksv13PhCm+yMTM6Ax8LWTvYpxv/T3FrnuqqMg 1wo6GqhhfScSiaP9KzgkuDn91Lp5rlCmz5C/afMMWAs9aooNQTuuIE120N9uyLrwInVSe7lZ9 N384fUfFSx+lLatYzdSqo3eQcuXfkgmRdlGE8Ik5DY4fjkSHwK2+pp18jlHML8mOlTBcFKa Received-SPF: none client-ip=212.227.126.130; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/01 10:10:08 X-ACL-Warn: Detected OS = Linux 3.11 and newer X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Li Qiang , Cornelia Huck , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Laurent Vivier Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Philippe Mathieu-Daudé Some 'qemu_vfio_*' trace events sizes are displayed using decimal notation, other using hexadecimal notation: qemu_vfio_ram_block_added s 0xaaaaf2448d90 host 0xffff5bc00000 size 0x4000000 qemu_vfio_dma_map s 0xaaaaf2448d90 host 0xffff5bc00000 size 67108864 temporary 0 iova (nil) qemu_vfio_find_mapping s 0xaaaaf2448d90 host 0xffff5bc00000 qemu_vfio_new_mapping s 0xaaaaf2448d90 host 0xffff5bc00000 size 67108864 index 4 iova 0x114000 qemu_vfio_do_mapping s 0xaaaaf2448d90 host 0xffff5bc00000 size 67108864 iova 0x114000 As it is hard to follow, unify using hexadecimal for all sizes: qemu_vfio_ram_block_added s 0xaaaaf1c60d90 host 0xffff2bc00000 size 0x4000000 qemu_vfio_dma_map s 0xaaaaf1c60d90 host 0xffff2bc00000 size 0x4000000 temporary 0 iova (nil) qemu_vfio_find_mapping s 0xaaaaf1c60d90 host 0xffff2bc00000 qemu_vfio_new_mapping s 0xaaaaf1c60d90 host 0xffff2bc00000 size 0x4000000 index 4 iova 0x114000 qemu_vfio_do_mapping s 0xaaaaf1c60d90 host 0xffff2bc00000 size 0x4000000 iova 0x114000 Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Cornelia Huck Reviewed-by: Li Qiang Message-Id: <20200820171006.1140228-1-philmd@redhat.com> Signed-off-by: Laurent Vivier --- util/trace-events | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/util/trace-events b/util/trace-events index 0ce42822eba9..d9a0b4f8c63a 100644 --- a/util/trace-events +++ b/util/trace-events @@ -79,7 +79,7 @@ qemu_vfio_dma_reset_temporary(void *s) "s %p" qemu_vfio_ram_block_added(void *s, void *p, size_t size) "s %p host %p size 0x%zx" qemu_vfio_ram_block_removed(void *s, void *p, size_t size) "s %p host %p size 0x%zx" qemu_vfio_find_mapping(void *s, void *p) "s %p host %p" -qemu_vfio_new_mapping(void *s, void *host, size_t size, int index, uint64_t iova) "s %p host %p size %zu index %d iova 0x%"PRIx64 -qemu_vfio_do_mapping(void *s, void *host, size_t size, uint64_t iova) "s %p host %p size %zu iova 0x%"PRIx64 -qemu_vfio_dma_map(void *s, void *host, size_t size, bool temporary, uint64_t *iova) "s %p host %p size %zu temporary %d iova %p" +qemu_vfio_new_mapping(void *s, void *host, size_t size, int index, uint64_t iova) "s %p host %p size 0x%zx index %d iova 0x%"PRIx64 +qemu_vfio_do_mapping(void *s, void *host, size_t size, uint64_t iova) "s %p host %p size 0x%zx iova 0x%"PRIx64 +qemu_vfio_dma_map(void *s, void *host, size_t size, bool temporary, uint64_t *iova) "s %p host %p size 0x%zx temporary %d iova %p" qemu_vfio_dma_unmap(void *s, void *host) "s %p host %p" From patchwork Tue Sep 1 14:09:42 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 1355053 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=vivier.eu Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4Bgq2w4JWFz9sVS for ; Wed, 2 Sep 2020 00:19:52 +1000 (AEST) Received: from localhost ([::1]:47776 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kD78Y-0007x5-BT for incoming@patchwork.ozlabs.org; Tue, 01 Sep 2020 10:19:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55410) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD6zP-0005fA-TX; Tue, 01 Sep 2020 10:10:23 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:44969) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD6zN-0003uP-Op; Tue, 01 Sep 2020 10:10:23 -0400 Received: from localhost.localdomain ([82.252.135.186]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MEVBa-1kNaK03rti-00Fxjj; Tue, 01 Sep 2020 16:10:19 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 32/44] linux-user: Add strace support for printing OFD fcntl operations Date: Tue, 1 Sep 2020 16:09:42 +0200 Message-Id: <20200901140954.889743-33-laurent@vivier.eu> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200901140954.889743-1-laurent@vivier.eu> References: <20200901140954.889743-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:o3ur6JqCZo4qSN9nasD1Ujj6N0dcSAJWVFOYwBK7k0Z2J5rk7FK l/XuWxcgHOQT2gicVeubPtUNGwnDjVdUur2Ru2Tc05FnW2djSsz/9I+YUMR8X6Sy/UV5P6P qp6eHNNgEO3c4dFsuvSqrjseJrcYJZQt4EX3V6CsCmzqlnrhc8WOj8glrL3kK08Ao4SsWDX gax1A0f3X9dkFHK5D0jyg== X-UI-Out-Filterresults: notjunk:1;V03:K0:Qu1gcnBW3yM=:c2k70dmoJ8wgiwGMUehr7I BnlfXaPy+eB0InYKHm1GOOk7420F5TwO+v5dw7rupS6rsxCqUwmPp029OL0T/aJd14AlQr+/g oqa/QowMsUJgpUkcUWfN1L4PoJAiU7LFC4LBDeqexCCM128k+n6LV2v+r4GcZFbBH0+362oGV zS1wtfiRs4Q7fqhaS3r8ZhI/KHSSTPw6faWpswr3hp56TmyiQgt7+h/OwMVTFb+r1eAlbt1uL XccFO8EKtJzT1U8KzkocG8IRki3U09lsRpfXoQv08UMD8IiOHdH5W0ZBNfbr6lB0k2+XGlE3N 6NULtDovtOmsKXWQZbc/ciVbpNiyrWi6LpkodN0pH093AvAhdX0cnLrs+1579xJG0DffINm2Z Bh6poE1cFd/R8XYDp7hXIHm/rDbKjl47WkIZs3++RkGxksL8JXxCvab8nGd/aG+BKgRcX2LiS U10OmD9kgJuXM55NxitUiUnTcqrmbpnGnsoMkYUm06DHvhgTBG01AZ4axYtcj8pM+J0E4PdMf 8MMs++aH7ZN6jTck53e+K1vHE7E1XksBX67MH+yiyX3Ba8tcZ3qOiTNEu+LtPGXEpIeYXeQ1F aLIx7TYxYgoHAYbjXazL42UcvrDer/OqGygzn+yRcs1lNChBPbIK1YKPPm8Ervz5a3keFlsBy 3kn5nroVloIS9F0W/MYnjxSHvCTsmyvWBVDWVrBQZ7BmngJKG5flu/3kOPXXcvMDjPng3P58+ ARLDpTrBczOEYwuCjf2Vyf6uUkiCd6/Gp4zPy/sviBfqRTchV6lT9gPVUvllSNhPfy6CqR7Cy L5rykaFLhu9RCnjW/8KZ+DIhdU/V00vH15Qi5xWt643rVK6sursTq/p2vO9TP6E/cKbR/6M Received-SPF: none client-ip=212.227.126.131; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/01 10:10:10 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Mike Gelfand , Laurent Vivier Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Mike Gelfand Signed-off-by: Mike Gelfand Reviewed-by: Laurent Vivier Message-Id: <20200830092242.31506-1-mikedld@mikedld.com> Signed-off-by: Laurent Vivier --- linux-user/strace.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/linux-user/strace.c b/linux-user/strace.c index 4f77b0cf76eb..11fea14fba2e 100644 --- a/linux-user/strace.c +++ b/linux-user/strace.c @@ -2056,6 +2056,18 @@ print_fcntl(void *cpu_env, const struct syscallname *name, print_pointer(arg2, 1); break; #endif + case TARGET_F_OFD_GETLK: + qemu_log("F_OFD_GETLK,"); + print_pointer(arg2, 1); + break; + case TARGET_F_OFD_SETLK: + qemu_log("F_OFD_SETLK,"); + print_pointer(arg2, 1); + break; + case TARGET_F_OFD_SETLKW: + qemu_log("F_OFD_SETLKW,"); + print_pointer(arg2, 1); + break; case TARGET_F_SETLEASE: qemu_log("F_SETLEASE,"); print_raw_param(TARGET_ABI_FMT_ld, arg2, 0); From patchwork Tue Sep 1 14:09:43 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 1355078 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=vivier.eu Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4BgqHv1BFfz9sR4 for ; Wed, 2 Sep 2020 00:31:06 +1000 (AEST) Received: from localhost ([::1]:49642 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kD7JP-0007Jx-Vo for incoming@patchwork.ozlabs.org; Tue, 01 Sep 2020 10:31:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55616) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD6zZ-00068F-B5; Tue, 01 Sep 2020 10:10:33 -0400 Received: from mout.kundenserver.de ([212.227.126.133]:50851) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD6zW-0003zy-UZ; Tue, 01 Sep 2020 10:10:32 -0400 Received: from localhost.localdomain ([82.252.135.186]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MNbtD-1jxMK82hqd-00P8ha; Tue, 01 Sep 2020 16:10:19 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 33/44] hw/arm/virt-acpi-build:Remove dead assignment in build_madt() Date: Tue, 1 Sep 2020 16:09:43 +0200 Message-Id: <20200901140954.889743-34-laurent@vivier.eu> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200901140954.889743-1-laurent@vivier.eu> References: <20200901140954.889743-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:oQPZDAL/Uc7IBntevT0HPBD1FgetWCj+mEEhbF4GaLWE73Ma14e YC5dcrZibK7QRywuVad+oaVSniXSvdILlwhqDM6cl1LMGL+r2AHrVf9GJL1wy7Bp5JIeXyu yVcEvn8uute6p59xF3hDcdo4AODoMqYDTeSu5t4xilrl95u/a32Lk4FzFbiVmPnddfdyqxv VGvzQGj/K+PRP8eDDKn2g== X-UI-Out-Filterresults: notjunk:1;V03:K0:AwjkbcbUPc4=:MMEFqkK3+JnoHhEcHFlzpK yNFJWPYv/ZizOOGcrntedaJoa2ZwJ5lfYvtg4+aDAhdJLj0pEvuWqc9JUNfAbVhiaUHIyLXst xout0blgGI177XH3FucHTd+Jg4bh9tkIhflMYfQR8NHAvwJhE5NPhVThz4poRTXeTzLPt2y53 UueksoYujOeEyFBI8/GFvBx/2880ggFo6AYXvBIw/33P/ws8LathJrs/2E9LmNjIj00O/LM0d 8IAzk9YWEjOZea+Z+z2oYyjdYnJKwvL413uUHS9Aa9TRQN+t+7+2l8CLpWK2UhyCIM5ncKwbu nWi9fbVEkBOLPFS4wzbOrrhHVCrkPbu4iMz/XnTwDWjNXV+WebRg9tc5YzLoOu6ev/AQI3O2e sTN9Q6oNeQ1EFkHmB2X3lAgTZQsQkO2liWTqt8om7vTro9V4/8DAVK+l4hDayGzCltMtMjKlE MAJB6HNBbBN68LVw9ryEQGV6pWOVwcOu7udqgbhH+7biDiIRQpphDjopu91x1FgkvtPybQ85f TW7lRIoHaOdTZ4d0W4nEOe2ftls5w08bDrvKgzNHSmbKGFUHpIh6Kywlu0PmOBusQmEYcK2NV PM+4oF5vFgKG5duQvsYniE/1IUMIM2EGjX0B0nVsMrvgocTqdSq5rBqYadCpJaQo8x0iHxNtf mDU7DiWuNWZfjU03Rq3ZE7146h9W+2Bj200IbXzH9OOsVGzasbwlReesuwOFTZ2zY8+z8No43 e4eWUactkOlJQT7yg5L+EqDuVlNVtL1c6FxMEJLoSmMDCKyZsGpUZNJH2cHohawhgZ7IqTJsj m+DgmbrRnH9Lv352kYZQBF9GxGI9KsF1GFVoPEOKevWA2jjgU1rbkB8gJgfI9ddUuB+N/Hl Received-SPF: none client-ip=212.227.126.133; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/01 10:10:07 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Michael S . Tsirkin" , qemu-trivial@nongnu.org, Euler Robot , Li Qiang , Laurent Vivier , Igor Mammedov , Chen Qun Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Chen Qun Clang static code analyzer show warning: hw/arm/virt-acpi-build.c:641:5: warning: Value stored to 'madt' is never read madt = acpi_data_push(table_data, sizeof *madt); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Reported-by: Euler Robot Signed-off-by: Chen Qun Reviewed-by: Igor Mammedov Reviewed-by: Li Qiang Reviewed-by: Michael S. Tsirkin Message-Id: <20200827110311.164316-2-kuhn.chenqun@huawei.com> Signed-off-by: Laurent Vivier --- hw/arm/virt-acpi-build.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c index 0a482ff6f734..9efd7a388150 100644 --- a/hw/arm/virt-acpi-build.c +++ b/hw/arm/virt-acpi-build.c @@ -633,12 +633,11 @@ build_madt(GArray *table_data, BIOSLinker *linker, VirtMachineState *vms) int madt_start = table_data->len; const MemMapEntry *memmap = vms->memmap; const int *irqmap = vms->irqmap; - AcpiMultipleApicTable *madt; AcpiMadtGenericDistributor *gicd; AcpiMadtGenericMsiFrame *gic_msi; int i; - madt = acpi_data_push(table_data, sizeof *madt); + acpi_data_push(table_data, sizeof(AcpiMultipleApicTable)); gicd = acpi_data_push(table_data, sizeof *gicd); gicd->type = ACPI_APIC_GENERIC_DISTRIBUTOR; From patchwork Tue Sep 1 14:09:44 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 1355067 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=vivier.eu Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4Bgq8Q4HPzz9sR4 for ; Wed, 2 Sep 2020 00:24:38 +1000 (AEST) Received: from localhost ([::1]:47668 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kD7DA-0002xW-7U for incoming@patchwork.ozlabs.org; Tue, 01 Sep 2020 10:24:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55532) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD6zW-0005zg-KR; Tue, 01 Sep 2020 10:10:30 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:34829) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD6zU-0003z9-MP; Tue, 01 Sep 2020 10:10:30 -0400 Received: from localhost.localdomain ([82.252.135.186]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MXY2Z-1k55ZD1aOd-00Z03W; Tue, 01 Sep 2020 16:10:20 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 34/44] hw/arm/omap1:Remove redundant statement in omap_clkdsp_read() Date: Tue, 1 Sep 2020 16:09:44 +0200 Message-Id: <20200901140954.889743-35-laurent@vivier.eu> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200901140954.889743-1-laurent@vivier.eu> References: <20200901140954.889743-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:MRDOMqanYQOUngXE/hWOxXm+U7mswvnyvT8rtz9CyUxC1N2ozry KfjHahMaJgHAyX5J6SrY5ItcL0K9bDEBJRN4fwbwGav5t0/TJxkb0k25YxFX7rtOSWI6m/9 PkgiZ9Up9AKkJWG/xd0yR31MHsEMR3pXZ+L4rTaN0ElPJHhYI2IRIP6IlrZRr/mEK8A9XFj ibTiV8CUvO+CzegyGQdHA== X-UI-Out-Filterresults: notjunk:1;V03:K0:fLx71k1tseU=:p6PnZOAwUO/dqWc5UmRyxV TBo7N6Oq5VAOUDLFslM4001DNVLaATdWZmcdizFTWhBQdaUfN4H2ZWWEzDJ3GhjD0ku2y41Gk 9JjEnXUJ3hzGdz5Jkw+1SpNKSRFQ9uDD4A+wMmCtdZ4XjmEXvlQFHWH52w7Mqk35DyCrcWXlD dDBJYjd1HLLTcgqRZa7spswoXkaYHZGeEkbwkweKTwtMX/7fLUi4ZPCn2sOXnDP1IUpRXN7sg E67z8J0liIeKAiy+8H7f/a1wzl26hxBkypNqP6pXm1nCx5n3yU1GHmy7nkOcZzi7YJ5Nl/B6l LgpR1tSE+/pgmarhTrUVI+KJ/UX3sgduNjBJHmIot2Rq7JwaR20cl3kRlFz1y0/M1GhoGm/fE DIKEvUrLKDZpszFchyaRXCWmY2VfQ6Jr0c5b5FRlb7tSVOFzTAzqloYZe5pvzvIh26+WxFfDW 9EmWOF+D6fgwsvqAJIHnroIyUK4roCcb4gZxIZb4vNZfWPH7TJYUaZ9wHBdNjs5y5eQv1CTAa /tEEhlaj0auWxXSevkgblIhdswwJps92QxEFg2zmmcV/sz1X253e1ZIZ3tm5jzdnhBre5vivF 7d1yt0UHH2QVNivbD55CpOtnP2cuYqQd60mlkwA6F7Ibh8q2VwrUjixdJdQjIHKFQMS1F0LcX blJlnl79uDEFSpf8+SczWrx6+cH9bgTvO62QvZRz7xL2glE5U1DYqoTYhS5UhaNMbLJKdubzI oA44A+aN3Dxgh0/pUiGlXmhcQdBs6PPx7fh+K80y35dWa4/GjuQ6qZkN7G1Fx+f7kZ+lRr/v4 4C6hcOPqMJBoJo8POaU9C+YR3jnZCRYkKkkHRPyhhbYSp2PNWTh9jNoAUNd8qWD9T38eIqY Received-SPF: none client-ip=212.227.126.131; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/01 10:10:10 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , qemu-trivial@nongnu.org, Li Qiang , Laurent Vivier , Euler Robot , Chen Qun Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Chen Qun Clang static code analyzer show warning: hw/arm/omap1.c:1760:15: warning: Value stored to 'cpu' during its initialization is never read CPUState *cpu = CPU(s->cpu); ^~~ ~~~~~~~~~~~ Reported-by: Euler Robot Signed-off-by: Chen Qun Reviewed-by: Peter Maydell Reviewed-by: Li Qiang Message-Id: <20200827110311.164316-3-kuhn.chenqun@huawei.com> Signed-off-by: Laurent Vivier --- hw/arm/omap1.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/arm/omap1.c b/hw/arm/omap1.c index 6ba0df6b6d09..02c0f66431b9 100644 --- a/hw/arm/omap1.c +++ b/hw/arm/omap1.c @@ -1774,7 +1774,6 @@ static uint64_t omap_clkdsp_read(void *opaque, hwaddr addr, return s->clkm.dsp_rstct2; case 0x18: /* DSP_SYSST */ - cpu = CPU(s->cpu); return (s->clkm.clocking_scheme << 11) | s->clkm.cold_start | (cpu->halted << 6); /* Quite useless... */ } From patchwork Tue Sep 1 14:09:45 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 1355074 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=vivier.eu Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4BgqFZ3vwhz9sR4 for ; Wed, 2 Sep 2020 00:29:06 +1000 (AEST) Received: from localhost ([::1]:40638 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kD7HU-0003XB-EJ for incoming@patchwork.ozlabs.org; Tue, 01 Sep 2020 10:29:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55576) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD6zX-000645-Vs; Tue, 01 Sep 2020 10:10:32 -0400 Received: from mout.kundenserver.de ([212.227.126.187]:53745) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD6zV-0003zS-QH; Tue, 01 Sep 2020 10:10:31 -0400 Received: from localhost.localdomain ([82.252.135.186]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MDQqk-1kKI030IWU-00AT1v; Tue, 01 Sep 2020 16:10:21 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 35/44] target/arm/translate-a64:Remove dead assignment in handle_scalar_simd_shli() Date: Tue, 1 Sep 2020 16:09:45 +0200 Message-Id: <20200901140954.889743-36-laurent@vivier.eu> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200901140954.889743-1-laurent@vivier.eu> References: <20200901140954.889743-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:7MytmcQlZbd0x7aW2n0tHP/lWDilC+4WyjdtE03XZV3dMl9gCsZ tid0ho/0Rf9qrqda7CX6DNS501cq7GAz5hr1Zgx2+2CXIj9XvqJoSNA+3ypl/lKgG7rTwG1 g7Id7vtrHF/6fSodLQ1CsEsZ+8N2+FlZ4AvmEGOTib5ml55ebxl6wUr12gyirZjEeaKmjPH 76j2kBTAynlNNOs0IgX/Q== X-UI-Out-Filterresults: notjunk:1;V03:K0:D4SzP2V09+Y=:fnfFRWUCmK17meChl6FvaY T1KcPuDeEGrPeQEFpIBHHQo07agKz84T87KDYRFTbFap4N8dtl90B3+KjiXqFSelhvSE2qhXs lIyipI2swjin96Wq/Xdow+mgic95mPzarA6QX1FYES0aAfN+C6pTWrR+6W0pdUyRcE+etJ87K +hgT0qH6Wbsec/gdI0ul8ydJLqG4FpJRFTP/zqExuO9nsd0c8QuEO/puvOm3jMMiNSGavXqIG 8/Z+1pMKD+Azv9iOp/0GV8rDzd2TcauUSN+hCQ8n4TZ/zhdD1rDiaHXvhdYc9ImZNADN8iIi/ pOXMY61j4rJNgLzLr1YnjWeb1Smc5bhoB/axBbg+/hiq5eem1hRrU4vEfTPdgHc+chx0AjXfM 9EAR5ODihDQUwNINZYdDJcPj04l/RRMnrq07MRGeh4pgQyp9hHK0M12St72+usb/5+ousNY9b /AeL5rBGtpyeXO0wVLBOu9VxnhekIRXQ53Thj8WUSwedo6CqODZ48p6YrfJT7RO5xjRAymbot X6hTaCayI7OrdUCHk83hp72vGLaAdLXAWpJSe4Rhx6jo+8xxecLOgg6yjaHMEsALIhwMMKz9u lzGUs93nxEYQao+gWH+ObIlD2I5u1r7ZLQ15m+QMdZJ4x2qANVJb2KtKssrFe1YLZ+rAtmAvm pCNYsv+q+HhPMUgbz/e1D+ZJG6exB7fEALaazSls8mU0rHsnno8qhgCXivtKkAdM1iXmV7mRZ 4iIELbGKNsQz/aNeNz1UP7OfvawPvN669Br7Icy9Lf+UDVRF4VuuYPif5xiJ4SLYVhYlCbbVc AUvguDxHYgiTNdzg9hM7FQyokLDrinq6AatWKG+43y3a0m0FGumNFdXId+pDszfml1n+GfP Received-SPF: none client-ip=212.227.126.187; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/01 10:09:57 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Chen Qun , Peter Maydell , Laurent Vivier , Euler Robot Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Chen Qun Clang static code analyzer show warning: target/arm/translate-a64.c:8635:14: warning: Value stored to 'tcg_rn' during its initialization is never read TCGv_i64 tcg_rn = new_tmp_a64(s); ^~~~~~ ~~~~~~~~~~~~~~ target/arm/translate-a64.c:8636:14: warning: Value stored to 'tcg_rd' during its initialization is never read TCGv_i64 tcg_rd = new_tmp_a64(s); ^~~~~~ ~~~~~~~~~~~~~~ Reported-by: Euler Robot Signed-off-by: Chen Qun Reviewed-by: Peter Maydell Message-Id: <20200827110311.164316-4-kuhn.chenqun@huawei.com> Signed-off-by: Laurent Vivier --- target/arm/translate-a64.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index 4ba6918b6063..1fc3b2273207 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/translate-a64.c @@ -8631,8 +8631,8 @@ static void handle_scalar_simd_shli(DisasContext *s, bool insert, int size = 32 - clz32(immh) - 1; int immhb = immh << 3 | immb; int shift = immhb - (8 << size); - TCGv_i64 tcg_rn = new_tmp_a64(s); - TCGv_i64 tcg_rd = new_tmp_a64(s); + TCGv_i64 tcg_rn; + TCGv_i64 tcg_rd; if (!extract32(immh, 3, 1)) { unallocated_encoding(s); From patchwork Tue Sep 1 14:09:46 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 1355072 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=vivier.eu Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4BgqD22h2wz9sR4 for ; Wed, 2 Sep 2020 00:27:46 +1000 (AEST) Received: from localhost ([::1]:60302 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kD7GC-0008Io-6W for incoming@patchwork.ozlabs.org; Tue, 01 Sep 2020 10:27:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55580) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD6zY-00064g-3x; Tue, 01 Sep 2020 10:10:32 -0400 Received: from mout.kundenserver.de ([212.227.126.187]:55081) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD6zV-0003zV-U9; Tue, 01 Sep 2020 10:10:31 -0400 Received: from localhost.localdomain ([82.252.135.186]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MzQbw-1kZA7R313g-00vRaH; Tue, 01 Sep 2020 16:10:21 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 36/44] target/arm/translate-a64:Remove redundant statement in disas_simd_two_reg_misc_fp16() Date: Tue, 1 Sep 2020 16:09:46 +0200 Message-Id: <20200901140954.889743-37-laurent@vivier.eu> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200901140954.889743-1-laurent@vivier.eu> References: <20200901140954.889743-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:Se1aBbOJhO0bgrfhpYnwe20MluVmTL6jT+pVjZM/pAm3vTbgo+j ILqCMotw5/eAM/jbR/NH+F2+1tNZTdCshjUbZk/wDqAF7WN6lN23f0TbjAq6mxnoPRA4Qn1 jbRpqn1baoaOyi6ODweAlaMJULAugd4AuURr+nVJZHMgm7WroS5er1Grke6GZXvm0L7Qsmw EV+dYhUDhKJvA3m1R8GYw== X-UI-Out-Filterresults: notjunk:1;V03:K0:1B2d3lJ4w/A=:C6vvJh6M68fBAqFZ09tqA4 6cUbZejz9V/IM7TlK/ngg0xZrM1G6Ov898oEX6LntS90J112++ZvGCMwWTZ0CFOVT8G+jJ8f0 ScNcohjHS95I8jVsi4tAhc/Kz7Wcf9LqAW91EY5//KJA4gSWushdTcaTzgbZu/GL1b3xbJdrX ZSUgUOWB6lAg01PHqJKN2mr3RfCiRRVrHCqbpUGzGuP5QplllbZx3ALOJo8FYjlcNdm+ue4Kq ylAWreaITwCVHciCwrEt6CUV9yfQelb20bhOoYB/sf4kohKaNvwqrUB2KjlT0rnTY1Nj0OS6r o2GRhVW05nM8BKF2RAVjHcoPRIb8hufNeQYlpsVwmThyWjHJyUhoAyS/fTiVUS1FMcTF+wUkM fsBtHjBKzxnNAShpPnXym57RRgrimRJ3vQgiHIiwVY8Wnj+Vxsp2UOf6SablEyTA1g8VLhpKc gdic/1WzNS8sB3977BCwremVAyGrld/1fYaZaY25uYKHixGIqb57Dh2jN3cb48244q0yDeyTS 2lJYL4m1UlhxpoiM8zfuM9szI97ra5vBEh8oPMv9SeBm8g371931FH3zTgOxigD75VJYhZplb Ryd5ocH7svGkXjHIBrRk5UoKMSNBH400WLaRBJStQw3L5uDbNUQFDrS2+yn7+31uJYEc9Xjsv uGkEjCP5WEAE/ig8Ct91eRU4ysocRmdYeOisvKNo194y00AS039g5joOV8SOyWCKO0V5V1mpQ myU/guO7X7pW02oC9g0Mkd52hH68P9ighpvOTCT7PfLIX0A504mxbsEKpsLwIJrrSfWosnym3 8Y6TNUO6DQ2l2yF6ylwgu/1shNskK7mFdhZ+0z6yeGE3L8glyynP2xyfmMY5jTAu/dqPZnS Received-SPF: none client-ip=212.227.126.187; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/01 10:09:57 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Chen Qun , Peter Maydell , Laurent Vivier , Euler Robot Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Chen Qun Clang static code analyzer show warning: target/arm/translate-a64.c:13007:5: warning: Value stored to 'rd' is never read rd = extract32(insn, 0, 5); ^ ~~~~~~~~~~~~~~~~~~~~~ target/arm/translate-a64.c:13008:5: warning: Value stored to 'rn' is never read rn = extract32(insn, 5, 5); ^ ~~~~~~~~~~~~~~~~~~~~~ Reported-by: Euler Robot Signed-off-by: Chen Qun Reviewed-by: Peter Maydell Message-Id: <20200827110311.164316-5-kuhn.chenqun@huawei.com> Signed-off-by: Laurent Vivier --- target/arm/translate-a64.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index 1fc3b2273207..71888083417d 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/translate-a64.c @@ -13014,9 +13014,6 @@ static void disas_simd_two_reg_misc_fp16(DisasContext *s, uint32_t insn) fpop = deposit32(opcode, 5, 1, a); fpop = deposit32(fpop, 6, 1, u); - rd = extract32(insn, 0, 5); - rn = extract32(insn, 5, 5); - switch (fpop) { case 0x1d: /* SCVTF */ case 0x5d: /* UCVTF */ From patchwork Tue Sep 1 14:09:47 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 1355075 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=vivier.eu Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4BgqFp1Fc2z9sR4 for ; Wed, 2 Sep 2020 00:29:17 +1000 (AEST) Received: from localhost ([::1]:41866 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kD7Hf-00041O-Qx for incoming@patchwork.ozlabs.org; Tue, 01 Sep 2020 10:29:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55652) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD6zb-0006E5-8d; Tue, 01 Sep 2020 10:10:35 -0400 Received: from mout.kundenserver.de ([212.227.126.133]:50439) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD6zY-00040g-Ql; Tue, 01 Sep 2020 10:10:34 -0400 Received: from localhost.localdomain ([82.252.135.186]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.167]) with ESMTPSA (Nemesis) id 1Myb8P-1kW8uZ1oGz-00z1Ps; Tue, 01 Sep 2020 16:10:22 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 37/44] hw/virtio/vhost-user:Remove dead assignment in scrub_shadow_regions() Date: Tue, 1 Sep 2020 16:09:47 +0200 Message-Id: <20200901140954.889743-38-laurent@vivier.eu> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200901140954.889743-1-laurent@vivier.eu> References: <20200901140954.889743-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:fHDxDkU2JPw6dE9t8b8F4PHzV3yVfSYjKGTRPDjQRQXzP3eP3q1 WJqL2BVmt4/vKoOR2m9opkFLV7ABY3bCRoUH/325/cJ01t/vCv8veEEbtda31L4uB5Tu80p vlml08qkt4TTWO3VxU3nfJlE3KIK3krSdQvP5DOECNW/kforhCr82Ydyu94Cah+RIQLDj1y 2evz4eJ+1VWs4aOLmUr6w== X-UI-Out-Filterresults: notjunk:1;V03:K0:4iRK4LVdoss=:fkLmCagZ7QsGJ3gLJPVOQq yd68jVHacc/qgGAi4sIt+yupdyoSpGff3KeLGoemt3KZBOGW+iVtx5OBPKl2CQF6yD44g5mZn M2DMcR6NRrJr07+bg6LneIRRNBqzNA87zKFc4Fwej/vJYf8OQPU55gyEFWioAoSUDFsdRC7i6 Rzy3cJcq3gCUedXgPYgQSGe4TSXfV8i6KT84VbG7G64hTekGbn7vwfR3FbMhZWFXZDAOwHjAG GzE1CeaKaie3KbIu/kJBQS7pTaNhSmJ4fuffgHw5nB8W/HUaFglEi97CrhUqmGiGL4yKNNUO8 UicZz5EWK0WbkqJSYcp1K6UFTdqeb4WQYrxxP3l7xN0ssjSTtqnxtN2BWULT5arU+ed5bBUrg JfJBoYZhHE+U+8I+/s3CK6FOJ2SKq9Ujba3VGoFpBmL+h1OY906W0kIXp3CWscmeMV+P+/AS2 /81aViOfFw6HdZHW0YdwK1VO922gouRQ4Yh0ZLGsUlFJsXtUymC0ko8jLUNa2uyHmN14VmjWu MqD5YZSMPPiLReAO1N2/d5SeB1XPQX3Ub2wKInJarWOYMraFi3lCqabqtqpei40lti31pqzc4 0OSlTVvrPvFOIbtSTNNcsvbwdp0e8T26NqQKr1m6wsJdYfvlyhte0Uso+vE5PoMeHGbqVCDe3 LaCJjofukIxSQrT1D8dp1X41PBtTVmCKyetwVNPZiJhOk2JwD/8tWfgovuB638rOT6Lcb0EoB dLHI+Hp62o+ktIg9t4MuUQ3Fhw9p6EXFiSn4TtAZH9auLjC85i8z2DxciSxuU+I59zx3ics18 7GhBDiTDCzoToimCUiWENMiAfotPzCCZnItZEbEC6kl0F4eT7jTxAE5uoRilnfHNRIVN3ha Received-SPF: none client-ip=212.227.126.133; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/01 10:10:07 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Michael S . Tsirkin" , qemu-trivial@nongnu.org, Laurent Vivier , Raphael Norwitz , Euler Robot , Chen Qun Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Chen Qun Clang static code analyzer show warning: hw/virtio/vhost-user.c:606:9: warning: Value stored to 'mr' is never read mr = vhost_user_get_mr_data(reg->userspace_addr, &offset, &fd); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Reported-by: Euler Robot Signed-off-by: Chen Qun Reviewed-by: Raphael Norwitz Reviewed-by: Michael S. Tsirkin Message-Id: <20200827110311.164316-6-kuhn.chenqun@huawei.com> Signed-off-by: Laurent Vivier --- hw/virtio/vhost-user.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c index d7e24237625f..9c5b4f7fbcda 100644 --- a/hw/virtio/vhost-user.c +++ b/hw/virtio/vhost-user.c @@ -603,7 +603,7 @@ static void scrub_shadow_regions(struct vhost_dev *dev, */ for (i = 0; i < dev->mem->nregions; i++) { reg = &dev->mem->regions[i]; - mr = vhost_user_get_mr_data(reg->userspace_addr, &offset, &fd); + vhost_user_get_mr_data(reg->userspace_addr, &offset, &fd); if (fd > 0) { ++fd_num; } From patchwork Tue Sep 1 14:09:48 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 1355082 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=vivier.eu Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4BgqMG50jGz9sR4 for ; Wed, 2 Sep 2020 00:34:02 +1000 (AEST) Received: from localhost ([::1]:34706 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kD7MG-0004eS-M2 for incoming@patchwork.ozlabs.org; Tue, 01 Sep 2020 10:34:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55634) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD6zZ-0006A5-SJ; Tue, 01 Sep 2020 10:10:33 -0400 Received: from mout.kundenserver.de ([212.227.126.133]:45153) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD6zX-00040M-U7; Tue, 01 Sep 2020 10:10:33 -0400 Received: from localhost.localdomain ([82.252.135.186]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MkpjD-1kri4W0g07-00mHgY; Tue, 01 Sep 2020 16:10:23 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 38/44] hw/net/virtio-net:Remove redundant statement in virtio_net_rsc_tcp_ctrl_check() Date: Tue, 1 Sep 2020 16:09:48 +0200 Message-Id: <20200901140954.889743-39-laurent@vivier.eu> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200901140954.889743-1-laurent@vivier.eu> References: <20200901140954.889743-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:GpwwH3w0iP+ROO0G5v0szD4r3uVxpbrANqTycm0vX5WOZteZR3r ciwv50BXPB9l7ItFtSRftIs+M9qgzDkVcIUcRCpizwoic0icTL6Fs+/Zzhef8uZAW5YMSTt R1ZnnwiEetUbXiGDW2cUNbPd73JKz3TNB4hIWDPink4N/9XoVKU7kGp/neZFRRHnLqWZNmD 7/1kms6yn2aaVRdKMKMfA== X-UI-Out-Filterresults: notjunk:1;V03:K0:6fEAJAzPqzQ=:0OBQLBVFGA5XJ6QPnY4gJC P+9g17uUb8xDTIbnGnwqtSObAk1xH15tRQey3XRciM6FONoobxqilr6w/ahfOR2mV6D0YB+lK HWLz2otoNARPeQg64tJfOMm+QpXxCTrGeHM58AuNolHAq4wluQWEV/HnwVvsR4k6mjqgzHC81 sIIe4c5hC+LIWbh7W2fZ3HYpVD/gjXoWxcrHf+2E/fJmtBvVNQBxgHj9+rMsLDav5rJZuDf7c k4Cad1DYQqMilqDe0mqkQGdxlB95Kh6pg8j8VgKFbX1PeB+zXMaMO9wlmrm+euQpbjSTFwW6B YaF0u/N2HQEU4BHSBaoSHrFdD5S6Y91ZJ3O/NsdNuC1kXhj2UZeaZKop7Xr93x8NRtSBXqPEV nIGph7TisjnHoSkxZCVDQNdF/v6ELB9uxiIn9UefKnMQQGUz49oHT/Bpb9+o6akuds6QOZT0n KABrzmP5mIAMrV/wtFWLTevKp11afo/p/4+1n1i69w8fLrU7Lypi5PaFuRkB9ngpiZZfFN/To rUvpCVNM54OW8POY1aBc505m4lVYO2cD3TZN+hLplElPzIF0t220UMG9S6ndkKz4sLTyvizze XvcXcBhTEgqdW5p2UDN2NL+40i8JxePAmc4DYitSA/vbYz0rIJ26QOt9s/A4Qv6oJ9idfxm0L wJkFeBCBKVHYvOER4T1PcL/ymfZmMIYjv/yg3nUL5j25gpanCohBMLVR8LuV/0sbbyVMJWNps yPXGL0fRiXQ0n4/wbpkhCKfH+kBmXPfn41ZMc1ogAKdE+7GyLoy/hHIF0OJRvGa7m5EwALOrE 5G58ksT68kLjhSD9jD0kcP++/UEedoPz5IrgrPZjf0qTfQC5R0+TIhf2kGwTgkF7XyvOnnQ Received-SPF: none client-ip=212.227.126.133; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/01 10:10:07 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Michael S . Tsirkin" , qemu-trivial@nongnu.org, Li Qiang , Laurent Vivier , Euler Robot , Chen Qun , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Chen Qun Clang static code analyzer show warning: hw/net/virtio-net.c:2077:5: warning: Value stored to 'tcp_flag' is never read tcp_flag &= VIRTIO_NET_TCP_FLAG; ^ ~~~~~~~~~~~~~~~~~~~ The 'VIRTIO_NET_TCP_FLAG' is '0x3F'. The last ‘tcp_flag’ assignment statement is the same as that of the first two statements. Reported-by: Euler Robot Signed-off-by: Chen Qun Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Li Qiang Reviewed-by: Michael S. Tsirkin Message-Id: <20200827110311.164316-7-kuhn.chenqun@huawei.com> Signed-off-by: Laurent Vivier --- hw/net/virtio-net.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index a1fe9e928533..cb0d27084c10 100644 --- a/hw/net/virtio-net.c +++ b/hw/net/virtio-net.c @@ -2075,7 +2075,6 @@ static int virtio_net_rsc_tcp_ctrl_check(VirtioNetRscChain *chain, tcp_flag = htons(tcp->th_offset_flags); tcp_hdr = (tcp_flag & VIRTIO_NET_TCP_HDR_LENGTH) >> 10; tcp_flag &= VIRTIO_NET_TCP_FLAG; - tcp_flag = htons(tcp->th_offset_flags) & 0x3F; if (tcp_flag & TH_SYN) { chain->stat.tcp_syn++; return RSC_BYPASS; From patchwork Tue Sep 1 14:09:49 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 1355079 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=vivier.eu Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4BgqKB2TNXz9sR4 for ; Wed, 2 Sep 2020 00:32:14 +1000 (AEST) Received: from localhost ([::1]:54686 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kD7KW-000154-1k for incoming@patchwork.ozlabs.org; Tue, 01 Sep 2020 10:32:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55640) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD6za-0006B3-8A; Tue, 01 Sep 2020 10:10:34 -0400 Received: from mout.kundenserver.de ([212.227.126.130]:39751) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD6zY-00040U-CR; Tue, 01 Sep 2020 10:10:33 -0400 Received: from localhost.localdomain ([82.252.135.186]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MWAaw-1k5uuj3tyk-00Xd95; Tue, 01 Sep 2020 16:10:24 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 39/44] vfio/platform: Remove dead assignment in vfio_intp_interrupt() Date: Tue, 1 Sep 2020 16:09:49 +0200 Message-Id: <20200901140954.889743-40-laurent@vivier.eu> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200901140954.889743-1-laurent@vivier.eu> References: <20200901140954.889743-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:lsDR0dEHCtExKSd9N3oIN428thZ82nBF4fKg8HBPzQNzaeOTCIY 7Bs0o+KvIhLj5toScUInS9nf7Aez3cWSEI6dPi2r4HpR68D28Zq1zXbCn8jhFFkKFKVX2iP NWuGBRINpnAdiONWZf/i/dj7KkcoZ/LHchSm6y1vAcdg9gMI/Ufc1hHRjLu042SOEx0l60E SPjxYrZqSM0+GkZRpyhtQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:Jdfz80TC3Hk=:UQy0koX5hT1Lb8VX/HsC5e kqORgrLW6dYbqBg8lvU9dChVvVnfVrLYrIiE3BGp/m+5DJk7e6+pqWUldwOvAeMPnjhZ1nBRa T1w6mF+tB0B2ytkPys5Gs5aIDnSJChFDxj7AHV/IjgDMHgKDoRWaBOOdtlNgEDfa3k27tMtdi 2VUdySM1x6u84yYuHar96QcxUp5kWOhKGspoKDYYC9ZCwl2L9XmTrLq5OduTULz/7askIhs/4 +Z/q1lX6a+2eIPPw7Wb1UzfAPavxdtAcuRVg5qnUxFd2FCtkons/o3tKm/x0gk4U4b+I47poO zTGRqzbk1VqVONaeDj0XpJrOAZzQBMNfEV3X8w148usu59AX8c8ZBrhvsGIkocag7PZGo76lG vpuZIbJh2ssNzMzsrV0neO/IJqIGVUjDq19JdlJL9t3jmWkZ5PlaBY+Ct1tdJ8EHgfArO7C8l LFO51FIUP4c0lYhe4tyv8nkvQ0R0EdjWAK5sMVFPear70M8lqzw4TfczgzoJS2UfGZmwrFaKa uft+a0SucrfSrAkcqIg8GrNv/5O/+se2bQSM98lp7JHdFkmwN72CNtiK/sKEszfSaoHLFXqR0 P3zCub+IRdNdVueXaSzHLVV/xWfcwv5qf4vFsRfo/ixLIZzyctSnXt3gMEAY6+mA2r5ek5l3S moPUpY4d96s6/ZPiKeoxf36c0eUlhWZ5K8BXbjnUsWuGkkWzWgnhnD1CmJ5Vv3Sq2pfX5Vg5S nhAdh3Ku5rk2wEoblZ/pTheJZmzuBTbOmal1B6qNvpWJzunoJKUD6JNxrB8a03I3m4N5L7+gh j+18nEtBL3xh2nady720Pc8CFmDGY1Z6HYmMWMINTZKQfgXkvnvgVoN+yB1i52hienGdyBs Received-SPF: none client-ip=212.227.126.130; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/01 10:10:08 X-ACL-Warn: Detected OS = Linux 3.11 and newer X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Li Qiang , Laurent Vivier , Eric Auger , Stefan Hajnoczi , Euler Robot , Chen Qun Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Chen Qun Clang static code analyzer show warning: hw/vfio/platform.c:239:9: warning: Value stored to 'ret' is never read ret = event_notifier_test_and_clear(intp->interrupt); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Reported-by: Euler Robot Signed-off-by: Chen Qun Reviewed-by: Eric Auger Reviewed-by: Stefan Hajnoczi Reviewed-by: Li Qiang Message-Id: <20200827110311.164316-8-kuhn.chenqun@huawei.com> Signed-off-by: Laurent Vivier --- hw/vfio/platform.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/vfio/platform.c b/hw/vfio/platform.c index ac2cefc9b184..869ed2c39dcd 100644 --- a/hw/vfio/platform.c +++ b/hw/vfio/platform.c @@ -236,7 +236,7 @@ static void vfio_intp_interrupt(VFIOINTp *intp) trace_vfio_intp_interrupt_set_pending(intp->pin); QSIMPLEQ_INSERT_TAIL(&vdev->pending_intp_queue, intp, pqnext); - ret = event_notifier_test_and_clear(intp->interrupt); + event_notifier_test_and_clear(intp->interrupt); return; } From patchwork Tue Sep 1 14:09:50 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 1355083 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=vivier.eu Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4BgqNL3jnWz9sTH for ; Wed, 2 Sep 2020 00:34:58 +1000 (AEST) Received: from localhost ([::1]:39552 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kD7NA-0006mL-Cf for incoming@patchwork.ozlabs.org; Tue, 01 Sep 2020 10:34:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55670) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD6zb-0006Fv-Sw; Tue, 01 Sep 2020 10:10:35 -0400 Received: from mout.kundenserver.de ([212.227.126.130]:49875) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD6zZ-00041C-Qm; Tue, 01 Sep 2020 10:10:35 -0400 Received: from localhost.localdomain ([82.252.135.186]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.167]) with ESMTPSA (Nemesis) id 1N0X4e-1kY3eO2yOa-00wXVp; Tue, 01 Sep 2020 16:10:25 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 40/44] usb/bus: Remove dead assignment in usb_get_fw_dev_path() Date: Tue, 1 Sep 2020 16:09:50 +0200 Message-Id: <20200901140954.889743-41-laurent@vivier.eu> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200901140954.889743-1-laurent@vivier.eu> References: <20200901140954.889743-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:fde0JeXMtmvEuG6BD+FGbBr2ZW7adftAP1LOT4aUDPUX5ab2HO+ RLIoJfCid5/jFRFUEPKiZvqKrA1w7OfiS3b8t3Ii51b4wOehEsxki0FNyywxqr0lp4dTrYS 9mbnfwvWo90EMi359IUOxb2xa16QZgpSRdw5ZQ0bbgdW8NjxjUnn9xO2dLPs9Nh4jR+buXS yJGsJ6gxiTNDzMDmyUu5A== X-UI-Out-Filterresults: notjunk:1;V03:K0:wYIVgo2wF7Y=:DQaAn1e4j/icgNtKwXPzm6 iiaBkeBweCMqVLaQ6+Ba0cl+vZb+UCQhifGw4qo2tKiyQLH0ID5n89O3q0w9ErQECU9mZdeck FSUyea/BtFZDAFgDieulLO5JJKwHPrpXt9RUZKMt2r/oM2QRxZ2oKTqwKPxoDyOmKWxZnjeK4 bQlzSsp1xaLUbTBmX+96mOrzBBnxIc/2tKJ6cTVFb1v689t9p9RQ9dC4XGT7CpE3Np5FDlo5A isnO6ezfPP7+01KGfSW9pD/tRVat1SY2MHynQtJLox5rIv8RA8MLMXNQbG10+CbDLpbihHQ11 syyU+lxUgqlyUmGOI28T0vHZxr+jnfxoJjJlkvXFJ/MArLAm7mP+rYejXeSxCpkgsF2Ua5/RK PCylaQ9oBahzXfvlWyWFPdqcI6J44cjB4jKJtcAUocAYtt1EIr7ncEX9HhruC5Tixl1dCwFVB BwE21wjC7UBmArnIme7+i1uYinLMcEU7afw+lkAVxE49ML/8w66rs+WKu9ehKRA8T8RkGjVyY 7vP4obr5PR0whXGBRDaaKxz6obsHTeqG/ffn0+uxLUo7VOdwuzCqBgCZRFz60qwQhd0P0v0Q8 ljC98uqC0UZVXoPQLM/WhJQHtT8lVx7Lw9//+b/8EItWpbqVRTQjknYK9swSyNa/7Bw+Qz/Uw kYeh5APB75tCFLvNloFQvm9hgq7+gKkD3B5f8R1OJIgifiHpHQehIQTvwvfmWUoE8uAxV5Scj MLkhLA+l2wVZjr6GlXZEOnmnB0jgIl0GP81/P3DlL0r046wfloDq/09uWvlkZaVjuMwN+r2Gc R6aa4XxV4xLQ8kwePcTG16pOtms7lDo4Zogt9MI+ET95XoWf4LmrJSS15r0yXKRqV7hT0L+ Received-SPF: none client-ip=212.227.126.130; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/01 10:10:08 X-ACL-Warn: Detected OS = Linux 3.11 and newer X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Laurent Vivier , Markus Armbruster , Gerd Hoffmann , Euler Robot , Chen Qun Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Chen Qun Clang static code analyzer show warning: qemu/hw/usb/bus.c:615:13: warning: Value stored to 'pos' is never read pos += snprintf(fw_path + pos, fw_len - pos, "%s@%lx", Reported-by: Euler Robot Signed-off-by: Chen Qun Reviewed-by: Markus Armbruster Reviewed-by: Gerd Hoffmann Message-Id: <20200827110311.164316-9-kuhn.chenqun@huawei.com> Signed-off-by: Laurent Vivier --- hw/usb/bus.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/usb/bus.c b/hw/usb/bus.c index b17bda3b29ef..2b1104145157 100644 --- a/hw/usb/bus.c +++ b/hw/usb/bus.c @@ -612,8 +612,8 @@ static char *usb_get_fw_dev_path(DeviceState *qdev) in++; } else { /* the device itself */ - pos += snprintf(fw_path + pos, fw_len - pos, "%s@%lx", - qdev_fw_name(qdev), nr); + snprintf(fw_path + pos, fw_len - pos, "%s@%lx", + qdev_fw_name(qdev), nr); break; } } From patchwork Tue Sep 1 14:09:51 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 1355081 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=vivier.eu Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4BgqLR4YcVz9sVS for ; Wed, 2 Sep 2020 00:33:19 +1000 (AEST) Received: from localhost ([::1]:58654 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kD7LZ-0002nq-5U for incoming@patchwork.ozlabs.org; Tue, 01 Sep 2020 10:33:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55642) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD6za-0006Bx-Jt; Tue, 01 Sep 2020 10:10:34 -0400 Received: from mout.kundenserver.de ([212.227.126.134]:40129) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD6zY-00040c-IA; Tue, 01 Sep 2020 10:10:34 -0400 Received: from localhost.localdomain ([82.252.135.186]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MrhLw-1kyYlR2DMy-00ndWr; Tue, 01 Sep 2020 16:10:25 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 41/44] hw/intc: fix default registers value in exynos4210_combiner_read() Date: Tue, 1 Sep 2020 16:09:51 +0200 Message-Id: <20200901140954.889743-42-laurent@vivier.eu> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200901140954.889743-1-laurent@vivier.eu> References: <20200901140954.889743-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:HV333Pu56tdjA+Fq+Yyh+2C6PRpyef9rXpWQpiOOskLJS+eG3ss yqhpAtMASB4K5xTEX+CsKrUUSR4BxjZqRl9FCk2rZQCr4HIDu8xS/dSCz/oKXL+M2WXSWpC dOfV82UT/Sdu0AeCRKoGCBafMrWSJPc+R/WV7bk59Uxd41ShRQqIhymul3DgPOikNtbdfOK 3jX/0YZNw3SDrpqGQSF3g== X-UI-Out-Filterresults: notjunk:1;V03:K0:ha64hrP9JQs=:iaPbmguc0rMKmiCNFs7rUD svrXyQ1mLix2iXZpT22HNJfA7Vtpg/f+UuEms5LvTC10yV2NayahpvEfx6NZKUozC8uB2ibjN Wj8+pxkwAC/XNqUDBUELiPHbwDb7/k1rL1cs3UXyc89C+vpNhqAumzScpk8kffpDSgU0BAPpZ 0GZ4ImjEQXk+pTZe8p0qrYzAxaIo45fo207pQodN0oaOJkbf8nNivDg4c5b+82p8NgaHNXTuC e1yzRb5ibJFGzWoL8hFLASFOVNR5W0P+zCW2IBRvO9WnZeVAQUs5BBhST7CP4D9eTNj9NU2af eiyTSlTDdg+cu8jrA240nmhIl36KyWjPuzaEwIFYRuOYAeFhpJ4RNaTM0VLDrvWEBayTRP3/7 KIFvycg20M80NwT26fru3rFT08rguN1fCCwbmotCYDSvjgGW2AmyQiIu2Cit8L4/eQk3ZS6GI 4iqSucn+M7JtTupaWfcBPAukJIjkwG5WkAlveV6WK5CTBOaRgLJDhEu+Gg1HeexDoMfbbKGEh hhtD6x6/vbi04xAa9Ro5BWSyFJCkKeEUNL537PQ+7zPz98GmUdW20W4I77qb1B/41rkRq6NCE fl8eyGO+Pt2BHRwFwxiX4oLQ3X6zk5tj1zb1mOeymAQXBT+HCP32ejVcDZYbspAlOZK7eL5ek Fc3wFiTnb889/W3/f68aUeLqtb7m9aoAAxTDsV1ZwSkiLa3MdcP+NAxKOqT8Mu4bbHc7B+s7R fsyt5zrajHjrJxPDVhDjCVIQDnxkBtaMz/DaYokn0q02XOu4vRbmgFoDRNnmv8Zkt0cWaukL9 ogbkf2fv0rrf3q9iZ2MsRZri0O0hbwq4/f/z5iOxPOJtv5GcQ3TxKyqgmBdm7VIGRyBW+l4 Received-SPF: none client-ip=212.227.126.134; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/01 10:10:03 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Chen Qun , Peter Maydell , Laurent Vivier , Euler Robot Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Chen Qun Clang static code analyzer show warning: hw/intc/exynos4210_combiner.c:231:9: warning: Value stored to 'val' is never read val = s->reg_set[offset >> 2]; The default register return value should be return 'val'. Reported-by: Euler Robot Signed-off-by: Chen Qun Reviewed-by: Peter Maydell Message-Id: <20200827110311.164316-10-kuhn.chenqun@huawei.com> Signed-off-by: Laurent Vivier --- hw/intc/exynos4210_combiner.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/intc/exynos4210_combiner.c b/hw/intc/exynos4210_combiner.c index b8561e418037..59dd27fb16e5 100644 --- a/hw/intc/exynos4210_combiner.c +++ b/hw/intc/exynos4210_combiner.c @@ -229,7 +229,6 @@ exynos4210_combiner_read(void *opaque, hwaddr offset, unsigned size) TARGET_FMT_plx "offset\n", offset); } val = s->reg_set[offset >> 2]; - return 0; } return val; } From patchwork Tue Sep 1 14:09:52 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 1355085 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=vivier.eu Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4BgqPc67wFz9sR4 for ; Wed, 2 Sep 2020 00:36:04 +1000 (AEST) Received: from localhost ([::1]:43838 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kD7OE-0000FR-Oj for incoming@patchwork.ozlabs.org; Tue, 01 Sep 2020 10:36:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55678) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD6zc-0006Io-SX; Tue, 01 Sep 2020 10:10:36 -0400 Received: from mout.kundenserver.de ([212.227.126.130]:55425) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD6zb-00041Z-4s; Tue, 01 Sep 2020 10:10:36 -0400 Received: from localhost.localdomain ([82.252.135.186]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MLR5f-1jvASv0q1r-00IY4E; Tue, 01 Sep 2020 16:10:26 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 42/44] hw/display/vga:Remove redundant statement in vga_draw_graphic() Date: Tue, 1 Sep 2020 16:09:52 +0200 Message-Id: <20200901140954.889743-43-laurent@vivier.eu> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200901140954.889743-1-laurent@vivier.eu> References: <20200901140954.889743-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:CpWqSw0iYOifLykI8qXVEfPyPNaZdTJdWWVn3nfPRIrxI8nS2Lu 6AUIIcS9f7U6xRKXU7NLJ8nKrAGS4DDnXYpNMWJuiz2/RcrCicgMvkd84a8sARxVaD5TbFz zyr3/5T0hDNwlvd+CVDAL0pH7Oab+D/ZOV3YZm0RnTNbOV2So9LN3tvMe9Q5tuDtRIOLSuj I2xuOAGwHRZ3K9bhfm5eA== X-UI-Out-Filterresults: notjunk:1;V03:K0:10m+KQOEWnQ=:Ts4yNXi6sW2f9VcwdVRYMQ v12G155yBP1mBRMEU+gMd3rjnbTqpDPPj9RFquSpG1v1SFnitt0BCH35AYDBkeB3Ge24lhVpb O/NnAdgq/FWZClHAVSKf1Vt7BoPgvMigR4qTI0RaUPBqyBmvIFMwCxncEpqvEDRnQoH0VoBgE EBJsyYFxIzQ50EnkhRY4gPMYl9hNur6O0R2MdcP2Lg9M/RK37wreXbpeqE85UZxyLoqvVFag2 BluMxlQQr8hdiMs/f9sCgajIVqxllPWnJaoCYk56ooohs6lxrTMub6PQJ5CGy0yrXvnlBh9Jm yy41a7gAuerwgVsGenZrXxQFqR5LXGqCe10RSxiCxO1aNzZ+Z1mSlwbTSH+lATSbU7kJoLPg2 neIRKDhkiG6VlAPNaGvcscI09anYsdVNOGMlNWlkAFLd2u7KsJWoiUHlUJGNTGkP5HJo/Yda1 G8UKpMZC5V5sZWr3IOYIfDZQsEJOMH1J7dNOcGa+ITadk7AGlqKAwc3TVDvp1QOSb9psYdmLr 2zLcrReZmDyERy6WNXGV9lsjF651Dl2ULlOna2D04iXku8ogUkOG5ixU6ej9+25hDDOU5Jkbm tMA6edB2BHFpR/wsVsFQ44WHLz9m5E4FVgBE4GvAj+otFr8eZLgOi+OVOUno1/06Tb/F9xjHd KMB5xUn/g5oOJHyIZ5W2H+Gjr5evjjbEt/TX3rnloZ6xJJ6SpQ8Xtc7UIgs0p8ARqI8wQeMT6 QHtj85dwwrxhOdFEk5WV7kBwej8WWmXKY+IjwTXwxFQxCPX/UudsSNHbfaeyQJqlK2SkW4hwt 1+QRaTkxak9NoLUCZLSA7NMkP94ztS4131jgRWw6kp6fYGWkQxT7mi7U1AwJAuXcpa3CJVn Received-SPF: none client-ip=212.227.126.130; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/01 10:10:08 X-ACL-Warn: Detected OS = Linux 3.11 and newer X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Li Qiang , Laurent Vivier , Gerd Hoffmann , Euler Robot , Chen Qun Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Chen Qun Clang static code analyzer show warning: hw/display/vga.c:1677:9: warning: Value stored to 'update' is never read update = full_update; ^ ~~~~~~~~~~~ Reported-by: Euler Robot Signed-off-by: Chen Qun Reviewed-by: Gerd Hoffmann Reviewed-by: Li Qiang Message-Id: <20200827110311.164316-11-kuhn.chenqun@huawei.com> Signed-off-by: Laurent Vivier --- hw/display/vga.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/display/vga.c b/hw/display/vga.c index 061fd9ab8f6c..836ad50c7b6d 100644 --- a/hw/display/vga.c +++ b/hw/display/vga.c @@ -1674,7 +1674,6 @@ static void vga_draw_graphic(VGACommonState *s, int full_update) if (!(s->cr[VGA_CRTC_MODE] & 2)) { addr = (addr & ~0x8000) | ((y1 & 2) << 14); } - update = full_update; page0 = addr & s->vbe_size_mask; page1 = (addr + bwidth - 1) & s->vbe_size_mask; if (full_update) { From patchwork Tue Sep 1 14:09:53 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 1355071 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=vivier.eu Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4BgqC51kb0z9sR4 for ; Wed, 2 Sep 2020 00:26:56 +1000 (AEST) Received: from localhost ([::1]:57148 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kD7FO-0006vw-Rq for incoming@patchwork.ozlabs.org; Tue, 01 Sep 2020 10:26:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55590) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD6zY-00065l-HK; Tue, 01 Sep 2020 10:10:32 -0400 Received: from mout.kundenserver.de ([212.227.126.187]:60195) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD6zW-0003zh-Fd; Tue, 01 Sep 2020 10:10:32 -0400 Received: from localhost.localdomain ([82.252.135.186]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.167]) with ESMTPSA (Nemesis) id 1M3UhO-1kCYl63QFG-000bfz; Tue, 01 Sep 2020 16:10:27 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 43/44] main-loop: Fix comment Date: Tue, 1 Sep 2020 16:09:53 +0200 Message-Id: <20200901140954.889743-44-laurent@vivier.eu> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200901140954.889743-1-laurent@vivier.eu> References: <20200901140954.889743-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:4o6sYvUCQ0ApSDMYsDaRZRjFjlLFBTF4rHH7ZGvjZc662nk7M2a b+xdzOQSlA7jZQiQ3VIa+yCMvGUaOdUbjLfTggHDvafoxgbSZDHCvY8eJLDemdYmvcCaDXC dOfJ5wwr/1RylQo+NclfulfGIUG/WOftxvTgOvKzTBGQPkvzHaP6En0km2rwiIjburVJWHV WvWHk3gznKqx3ll3x6WSg== X-UI-Out-Filterresults: notjunk:1;V03:K0:H9mzzYJ0XsI=:QeAI3orvbdrQ0iw8nzXxEF JHq40zQEB/oC+x5FT92VAkchIsxqCpIxN7tCPVupCvSsMrhmgCCJGAL8Wwvfuar4MzK5kYsY9 0ckiKIpQqyYVpzUdUyz2KAR/hov7xmv+32Q4Sp1EDZeYkSZ6HpzZ2XKVTkz8NjKbuqXyovbq6 oxDODCNjvvjnzzyW7WcZxBoslv2EK5tr6M52eRoNLdPeoaOhoJmE1WSgHgE+w5P1eRmaUF/lk 3c0klglQxSGlSb5K33Bp7UAWX0gbZEGBUvBfiWpzBXZlmH5ChN5hoVQZAmSkJeY3dQpW1LG78 d6xxsLhfpNY5xMQ7xYnTCD/PGj3TVvFfMe7EDclBPs2TfC2btMr26kGo0YjwlouVslDPf/xH3 fjCVayRkFlDLp0PByC5P6gYJUUOx9oILEFwoRUfZhlsuPGwEoRZSEduWi8oRnV5bM/7h754j/ njshmXl1O7Q4U6U0/WhCDbLty4+ZLS1KWzidix76sDRnhpjcJjzMG6IcpO4a3AUd1rzutL9J/ L+VoefHGXcoepJH7XUfj2cPMgjIHkn/EGc5b+aCopX5pmdiTpEL7LZPxZjxWAQjD7wu8GMOcI 6Ms/keBAdW7ZrHVe1XEJJqy0NHusff0i0QOQGdjXWX6TTm7huzoa3jWvGPVI1WE62UcfUiKSP RwFGThlCmuWG4ptg5sK8LBU120dbSbTYpES3AdcoaVRulGrtTTnvjrvPukuZmo8GjwopCF7qj KRck312NPaFzBMO7pjPILwergGlTm2oo8q6GkU1UJ7va3rChLjuNIrRimMRzZzMblVnCmJu8H S+IGxkZh9mT9ZbxzVpxE3mUWew8ZCER4KI3vKJ6TXlDnJdOmduETZgUKitsyWLoLbzBLEzJ Received-SPF: none client-ip=212.227.126.187; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/01 10:09:57 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Stefan Weil , Laurent Vivier , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Stefan Weil Signed-off-by: Stefan Weil Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20200827175520.32355-1-sw@weilnetz.de> Signed-off-by: Laurent Vivier --- include/qemu/main-loop.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/qemu/main-loop.h b/include/qemu/main-loop.h index 8e98613656ff..d6892fd2081a 100644 --- a/include/qemu/main-loop.h +++ b/include/qemu/main-loop.h @@ -52,7 +52,7 @@ int qemu_init_main_loop(Error **errp); * repeatedly calls main_loop_wait(false). * * Main loop services include file descriptor callbacks, bottom halves - * and timers (defined in qemu-timer.h). Bottom halves are similar to timers + * and timers (defined in qemu/timer.h). Bottom halves are similar to timers * that execute immediately, but have a lower overhead and scheduling them * is wait-free, thread-safe and signal-safe. * From patchwork Tue Sep 1 14:09:54 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 1355069 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=vivier.eu Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4Bgq9M0Jtqz9sR4 for ; Wed, 2 Sep 2020 00:25:27 +1000 (AEST) Received: from localhost ([::1]:51384 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kD7Dw-0004Wx-Sz for incoming@patchwork.ozlabs.org; Tue, 01 Sep 2020 10:25:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55594) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD6zY-000666-Id; Tue, 01 Sep 2020 10:10:32 -0400 Received: from mout.kundenserver.de ([212.227.126.130]:59677) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD6zW-0003zt-NN; Tue, 01 Sep 2020 10:10:32 -0400 Received: from localhost.localdomain ([82.252.135.186]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.167]) with ESMTPSA (Nemesis) id 1N6bsM-1ke9Gf1l1C-0183pD; Tue, 01 Sep 2020 16:10:27 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 44/44] docs/system: Fix grammar in documentation Date: Tue, 1 Sep 2020 16:09:54 +0200 Message-Id: <20200901140954.889743-45-laurent@vivier.eu> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200901140954.889743-1-laurent@vivier.eu> References: <20200901140954.889743-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:7L1YI38AnTxw8KGs1szZB3nJpEddnBvc3/Yy/tk98nSmivRkKzW NRoBAe7hIrdpBwO+0keWhvVKogCZ+DZgks69Z3HwLyfRsnb24YFwgXtjmnaugxw55T+ehI5 n/g/zyXHbXBMxZdsq02QMeL48tqzottUReKPFoWzikYJP+d/VRoVaXdh8i/D5VVomxykPCM eZfKSgOrJCChuoicfHcpg== X-UI-Out-Filterresults: notjunk:1;V03:K0:TzroLXl3Brg=:lKGWd3nt6vvRvdwA8n39sO NKrZbk0uwYSGDwWnlXnQQkMatoDj0eY7Ulvrfk/3RkqkxaG/qCW8oL9RSl7KuGvJ368FKaBv1 qbW56xSi5dn/z1BZOkHyGpU5KgD9yaR7NH3tnuK1uh1TpnYDIlVCUvcEt0epUWp9cWzTRnp7C MVmg5GpgZF/WTXXiXxV3Hv5kBpTmRRiKPWoudE7vvkXmTf7gjH5QRoh//hLlaxyvySVd6Ynim RhaW2NtUPoQ60FKbvMlQiCIRUMmYomsgZT4KTvrNXfHM2+6QlC3RFky9ICwoWNWvcVH9xMaT3 oNVl6D2R+q8jw9SYSrAfxC6k9TAT5SruQfXmSJ5uwfbqs3YxbHTIQlt0w5kCb+BTKt5CLph4C nonabsvy8PLJN8xHnlF+wJ7COr4t3Mk/lcXn8RG3hvyCrRtpP/LQmzYFVw7h3XGWy+x5LkmsR X2wlsSDMRLpe0FAa/SgsFZp5yC6UGDnGknlykeItkmehHtJW+CoWwYl3AFXjJ4W5O3EUdXxZm po0qD8aCkbMM+VRXxLSuAqtM1UzPouIxxWO96RMxghIUwTXLJYeAleuE+fQvFPfSa5r7PT9J5 rlundj79jXJFLxDEcZwClO4B4qvxLMy9OkJ/olZql9BFiuvmyOjDiZEkSD7J6n3YU8apQnPm3 fXUc1vojz5OTA6IO9tssfNeFTo7ZAYVAgYh7bJq9jQ34CQ6KmoD3/53uuyohqsM376LBIymab Ze2iOl6Azp7mJ7/oxI3iKCUQf9WXOsiw8CwFwq8iH0d5sHFAzUT7o4zq+fUMUijmow1RSBeZh s6paYKCkLi6asfuGxvAO4+4qElJekS/DphaUECOji9PPmj+unI93cITnb/zn/eWT/l1oqi6 Received-SPF: none client-ip=212.227.126.130; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/01 10:10:08 X-ACL-Warn: Detected OS = Linux 3.11 and newer X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Stefan Weil , =?utf-8?q?Philipp?= =?utf-8?q?e_Mathieu-Daud=C3=A9?= , Laurent Vivier , Peter Maydell Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Stefan Weil Signed-off-by: Stefan Weil Reviewed-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20200827173051.31050-1-sw@weilnetz.de> Signed-off-by: Laurent Vivier --- docs/system/build-platforms.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/system/build-platforms.rst b/docs/system/build-platforms.rst index c2b92a96987c..9734eba2f180 100644 --- a/docs/system/build-platforms.rst +++ b/docs/system/build-platforms.rst @@ -57,12 +57,12 @@ macOS ----- The project supports building with the two most recent versions of -macOS, with the current homebrew package set available. +macOS, with the current Homebrew package set available. FreeBSD ------- -The project aims to support the all the versions which are not end of +The project aims to support all versions which are not end of life. NetBSD @@ -75,5 +75,5 @@ new major version is released. OpenBSD ------- -The project aims to support the all the versions which are not end of +The project aims to support all versions which are not end of life.