From patchwork Sun Aug 30 12:49:06 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefano Babic X-Patchwork-Id: 1353939 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=googlegroups.com (client-ip=2a00:1450:4864:20::438; helo=mail-wr1-x438.google.com; envelope-from=swupdate+bncbcxploxj6ikrbtoav35akgqeawekjqi@googlegroups.com; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=googlegroups.com header.i=@googlegroups.com header.a=rsa-sha256 header.s=20161025 header.b=ECiGUemK; dkim-atps=neutral Received: from mail-wr1-x438.google.com (mail-wr1-x438.google.com [IPv6:2a00:1450:4864:20::438]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4BfY7Q20Txz9sSP for ; Sun, 30 Aug 2020 22:49:20 +1000 (AEST) Received: by mail-wr1-x438.google.com with SMTP id 3sf2032640wrm.4 for ; Sun, 30 Aug 2020 05:49:20 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1598791758; cv=pass; d=google.com; s=arc-20160816; b=tQNIqeKlK7IMqWXA/f2FS0QCDp9Ej4LF0ebI0Oe/LLay4Zq+k2N/wo0iWMfRSPpocL pmHZ4S9wOklHqdqfEKwBvQkop/enlC16nXNpjLpQYgTXVBaVqFUKemFtZxZ98wNt1VKe kkko5TTldDlk2xaB6bZa1kWC8PO3lDvFVxnSNBe5PDPJ3K8zt+KPJXw5Ied90lOnX4cp StsFwqNWyJ3hDxcJw35r0uhlvIgMJ/PPko4OlFiieesfuXNixqmPLN6H4mhdyLXEUG9R AjZF1dWFX/Jp2kkEop9JVS37trO3IEjHHpb1j07f8CLwt38XjIOg9/UuLdctghJUTZSq yFpg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:mime-version:message-id:date :subject:cc:to:from:sender:dkim-signature; bh=km9wefpcRO0Gpm1vjfvk6EHNO2jKEoyAb2+kukgVIj0=; b=zS5hmK5gceXlaNGa/PoKtAMbVfDyhY2HjgbIbSNpLdmwgTFF3KzxiOusFUMKl56KW9 dhex12qONKiNN0EwqFrU0U9tIXUxzL/vKdaxfdZj96TKG4cslqZN7oO+10uL/hM+tM6k gekvWC3EFBtkaRpgRAvaU6MUA2ipS+7GODIeY3RwyNgVBdi4L3wdonD6bckRfW7Nxez6 msFAK62gktBxUym/Aix2WXHtjKEPKdV/bQ5KOXd5bKSUkEET4jAOtUMrjBgHEkyLLz3g 4cHVja4Fd43bq/1O2tcFJL0sC0GzkaeDbF+t1WpVj0r/Qo9JLlU0Ijci1VxHA1f6GqhL uSXA== ARC-Authentication-Results: i=2; gmr-mx.google.com; spf=neutral (google.com: 2001:a60:0:28:0:1:25:1 is neither permitted nor denied by best guess record for domain of sbabic@denx.de) smtp.mailfrom=sbabic@denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:mime-version :x-original-sender:x-original-authentication-results:precedence :mailing-list:list-id:list-post:list-help:list-archive :list-subscribe:list-unsubscribe; bh=km9wefpcRO0Gpm1vjfvk6EHNO2jKEoyAb2+kukgVIj0=; b=ECiGUemKfUfFRN6ub1AzPoTRuFN+mK/pKDQ1Ml3ptq9jB81TkD91VwQcS3i/Ef9hTc 97DELkYK3cB7Vm2YHq++0/EFYPKA99PhNX6l7p2Ni8nLBx56KKi8yADcZ0/6n+lkUdqq MhSo1eWUVXCEPIUmpCY2JHIj5e2/na8ZLR3KhcNFkvOuUcFR/eQZmLhjX7/kZkAGlj1O AQDqwGFIDHQ5UFsbnvC5CYzMpKDCwlYu/fCyGz8ix/vBgC3L8zLRtPu7CN3ocSfVLnSW hunW9V9c50wfbhh4ICdELtZcIryalp0pC/pX6wXeycRhCpm8Lg8hFKfuDzzMuT8BWJJx T8pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=sender:x-gm-message-state:from:to:cc:subject:date:message-id :mime-version:x-original-sender:x-original-authentication-results :precedence:mailing-list:list-id:x-spam-checked-in-group:list-post :list-help:list-archive:list-subscribe:list-unsubscribe; bh=km9wefpcRO0Gpm1vjfvk6EHNO2jKEoyAb2+kukgVIj0=; b=YsDN2FWD4h4Fb5WqdvnD9+FPMh5zUSGlg9d+x/5IzB/ZXy65RKaeEdg8lClzsnLNLP z2VGOT+aKUNrcQu05S5XiQ1PauC1C/9LgoqD9+h19h2eWk2gZxJxVuVH5aDBUH5SNSqp d16VGyRyHRpYgU31D/VV83dcvce5J8WHGQ5erVsXCl5dEj1sSC/ch1J250kuC8VDWRY3 c7xl4tLot8vxSY5h+r8sfu23bJ7E7XESIOpAZ1rlKJlL5sonv+sZ10ab9WJuZSdQFsY4 qAl9qNzswGoXndDLdtoPQNB9k9jEbufCw/D6nV9XrMstsNWDerL27jqxwUyWw+50lH6x HapQ== Sender: swupdate@googlegroups.com X-Gm-Message-State: AOAM5326IFra4xVKIzQ9gEmrFD+2RTYXb2KcUu8zg7Y2nozRw5/F9AFo bx6exdGRSbDoAXWvO1wipiw= X-Google-Smtp-Source: ABdhPJyXNBK/a5tTu+aqMQFDJ6Hbcu2C2uFadplxLr4JyaJGpEp9/wRf7f/2lG1DlIIe4xjdwubQrg== X-Received: by 2002:a05:600c:24cc:: with SMTP id 12mr7460246wmu.117.1598791758168; Sun, 30 Aug 2020 05:49:18 -0700 (PDT) X-BeenThere: swupdate@googlegroups.com Received: by 2002:a1c:4c:: with SMTP id 73ls1837375wma.0.canary-gmail; Sun, 30 Aug 2020 05:49:17 -0700 (PDT) X-Received: by 2002:a1c:156:: with SMTP id 83mr6980872wmb.49.1598791757283; Sun, 30 Aug 2020 05:49:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598791757; cv=none; d=google.com; s=arc-20160816; b=qlYaV190wsC0CBDYxLZgc1SM5Hh7gDMrBaZ3GlHrbnIDzLEx4LVy/OrJCV9MrcV1sv yHJXPPKKCw3Lffdk0JQfyw/IEvnKDTqDIUAUsTcbSirOBAp1LINvTJat+WvGZ9u3I0ja 0FHjriUmItArmaDRnO/I2vHgU+STA5D2xR6LXYcD/LpO95IJt4aGKr3np1OANa3UNEAD KrZQBm3Qa1njjJ+EqFfkiL1d8AtH0nLCxj+sae4sC04zn4DSYYw1IEnw5wtolSDPjeF/ LV29ZdBYBO/0ixVcgvVjurE6nAE8GY47N0mAq4MbbJaNMuTWKt1N6G1w6Ujo2RNIiusn ZMag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from; bh=A10hiXyeADlZryiJwL+vXGRrqvQDTIwtxss+fX2XdAM=; b=og2I1i8S908PRfwbnXpINHsT+snM4dN/9/3JtsbYFQcsHqh8GBaYMnFtIkKP76oBBH F4ceiQ3JZ/uDP8rwmXYcAEPwi1ETYmexnD/+EENmpH/jBxIrTsF9vgfm4/7P7hbQ5yAY Mf/ClfPuLTfyNOR9WediSXDQxZrnNUE1DgeIPjgkwPknmmM2LDadmURxajKx6xU9gM30 7qB3+9aDYFJPCnswBkCTG4eyubOfmPHciUZR32W/EdD4F0cv5HUZtllHH0e6qEf/cmZi +4b+/T1Vrw0+kH/ol2Ksr/iEutkSR57B7pTreuQwbggSpL09eaCVJRNYf9SQDyeABsf9 2f+g== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=neutral (google.com: 2001:a60:0:28:0:1:25:1 is neither permitted nor denied by best guess record for domain of sbabic@denx.de) smtp.mailfrom=sbabic@denx.de Received: from mail-out.m-online.net (mail-out.m-online.net. [2001:a60:0:28:0:1:25:1]) by gmr-mx.google.com with ESMTPS id p11si152393wrj.5.2020.08.30.05.49.17 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 30 Aug 2020 05:49:17 -0700 (PDT) Received-SPF: neutral (google.com: 2001:a60:0:28:0:1:25:1 is neither permitted nor denied by best guess record for domain of sbabic@denx.de) client-ip=2001:a60:0:28:0:1:25:1; Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4BfY7J6sFyz1rrKZ; Sun, 30 Aug 2020 14:49:16 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4BfY7J6bRwz1qxtk; Sun, 30 Aug 2020 14:49:16 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id UROX_WQzO-rD; Sun, 30 Aug 2020 14:49:16 +0200 (CEST) Received: from babic.homelinux.org (host-88-217-136-221.customer.m-online.net [88.217.136.221]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPS; Sun, 30 Aug 2020 14:49:16 +0200 (CEST) Received: from localhost (mail.babic.homelinux.org [127.0.0.1]) by babic.homelinux.org (Postfix) with ESMTP id A9D114540D64; Sun, 30 Aug 2020 14:49:15 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at babic.homelinux.org Received: from babic.homelinux.org ([127.0.0.1]) by localhost (mail.babic.homelinux.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dv0AFr0ajsOs; Sun, 30 Aug 2020 14:49:09 +0200 (CEST) Received: from paperino.fritz.box (paperino.fritz.box [192.168.178.64]) by babic.homelinux.org (Postfix) with ESMTP id 8320F45403C9; Sun, 30 Aug 2020 14:49:09 +0200 (CEST) From: Stefano Babic To: swupdate@googlegroups.com Cc: Stefano Babic Subject: [swupdate] [PATCH 1/3] Start network threads before processes Date: Sun, 30 Aug 2020 14:49:06 +0200 Message-Id: <20200830124908.88129-1-sbabic@denx.de> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Original-Sender: sbabic@denx.de X-Original-Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 2001:a60:0:28:0:1:25:1 is neither permitted nor denied by best guess record for domain of sbabic@denx.de) smtp.mailfrom=sbabic@denx.de Precedence: list Mailing-list: list swupdate@googlegroups.com; contact swupdate+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: swupdate@googlegroups.com X-Google-Group-Id: 605343134186 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , Start core network thread before any process to make IPC working when processes are started. Signed-off-by: Stefano Babic --- core/swupdate.c | 99 +++++++++++++++++++++++-------------------------- 1 file changed, 46 insertions(+), 53 deletions(-) diff --git a/core/swupdate.c b/core/swupdate.c index f3d483b..0d610c4 100644 --- a/core/swupdate.c +++ b/core/swupdate.c @@ -924,59 +924,6 @@ int main(int argc, char **argv) memset(&sa, 0, sizeof(sa)); sa.sa_handler = sigchld_handler; sigaction(SIGCHLD, &sa, NULL); - - /* - * If just a check is required, do not - * start background processes and threads - */ - if (!opt_c) { - /* Start embedded web server */ -#if defined(CONFIG_MONGOOSE) - if (opt_w) { - start_subprocess(SOURCE_WEBSERVER, "webserver", - cfgfname, ac, av, - start_mongoose); - freeargs(av); - } -#endif - -#if defined(CONFIG_SURICATTA) - if (opt_u) { - start_subprocess(SOURCE_SURICATTA, "suricatta", - cfgfname, argcount, - argvalues, start_suricatta); - - freeargs(argvalues); - } -#endif - -#ifdef CONFIG_DOWNLOAD - if (opt_d) { - start_subprocess(SOURCE_DOWNLOADER, "download", - cfgfname, dwlac, - dwlav, start_download); - freeargs(dwlav); - } -#endif - - /* - * Start all processes added in the config file - */ - struct extproc *proc; - - LIST_FOREACH(proc, &swcfg.extprocs, next) { - dwlav = splitargs(proc->exec, &dwlac); - - dwlav[dwlac] = NULL; - - start_subprocess_from_file(SOURCE_UNKNOWN, proc->name, - cfgfname, dwlac, - dwlav, dwlav[0]); - - freeargs(dwlav); - } - } - #ifdef CONFIG_UBIATTACH if (strlen(swcfg.globals.mtdblacklist)) mtd_set_ubiblacklist(swcfg.globals.mtdblacklist); @@ -1026,6 +973,52 @@ int main(int argc, char **argv) network_daemon = start_thread(network_initializer, &swcfg); start_thread(progress_bar_thread, NULL); + + /* Start embedded web server */ +#if defined(CONFIG_MONGOOSE) + if (opt_w) { + start_subprocess(SOURCE_WEBSERVER, "webserver", + cfgfname, ac, av, + start_mongoose); + freeargs(av); + } +#endif + +#if defined(CONFIG_SURICATTA) + if (opt_u) { + start_subprocess(SOURCE_SURICATTA, "suricatta", + cfgfname, argcount, + argvalues, start_suricatta); + + freeargs(argvalues); + } +#endif + +#ifdef CONFIG_DOWNLOAD + if (opt_d) { + start_subprocess(SOURCE_DOWNLOADER, "download", + cfgfname, dwlac, + dwlav, start_download); + freeargs(dwlav); + } +#endif + + /* + * Start all processes added in the config file + */ + struct extproc *proc; + + LIST_FOREACH(proc, &swcfg.extprocs, next) { + dwlav = splitargs(proc->exec, &dwlac); + + dwlav[dwlac] = NULL; + + start_subprocess_from_file(SOURCE_UNKNOWN, proc->name, + cfgfname, dwlac, + dwlav, dwlav[0]); + + freeargs(dwlav); + } } if (opt_i) { From patchwork Sun Aug 30 12:49:07 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefano Babic X-Patchwork-Id: 1353938 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=googlegroups.com (client-ip=2a00:1450:4864:20::337; helo=mail-wm1-x337.google.com; envelope-from=swupdate+bncbcxploxj6ikrbtwav35akgqepsbox5q@googlegroups.com; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=googlegroups.com header.i=@googlegroups.com header.a=rsa-sha256 header.s=20161025 header.b=lN5RWGt+; dkim-atps=neutral Received: from mail-wm1-x337.google.com (mail-wm1-x337.google.com [IPv6:2a00:1450:4864:20::337]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4BfY7Q2fypz9sTF for ; Sun, 30 Aug 2020 22:49:22 +1000 (AEST) Received: by mail-wm1-x337.google.com with SMTP id z1sf677871wmk.1 for ; Sun, 30 Aug 2020 05:49:22 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1598791759; cv=pass; d=google.com; s=arc-20160816; b=sugfT2Of/6oedJP0LHBubvH62O4KTZo7BiEqdUc3FlR5Hhh37ONQpeZAsiVffJMC/p ylkbUEaIaRAj4YgV8V+N/qDhZvnFAG1+eP5Fs4DBxuygFWD7NM6Wgn9z0zFqOPCrPwSX XXa9W0n8JVwQb0fFzDRiUffWoO2kE3J+HUXLI8tQ4/LDMmV9PLuoU1TWIsdv4roos0Td ZFHIwxCDKAHWqAMitWC/dXZVuwfkf9nz8KOnCo9kYFYUfUH2dR/Vlemygp/hqjhhd0Rh UZJ4mng4+Szrw3o4ObVSVcSE7h5B0ZrNnd4EcRXqI+JNqINIoIuwIN9Xn0txxwJvxcEp IkWg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:dkim-signature; bh=6xjnO7t+hfLBkVZe/zi1qH9aXkSt96WlTtmlz8FC+Bg=; b=TQ0m3JAy3/5jSTBfZOBSqHN7wJ0G3CrgyReECCQ7nWfqbWNE0RtDYbWH90p3L26MuH I5qOQai0h7ZZ+xZE8W6TRfFZkDHLA4jS5+E6EwXCE4rGVapiAv/Topm9vq0mad0ux/1L +1p7l2RyJh2yXkf8SeDQOvp0SLJESHxAR4C0B5R/o0Dc4vvrH2PCE4/yc+GTkYTh0ECE xvBJUACApR+fdg9Wzme9b+elhhB8ES2IwQO4hqxBbRW8OvbdwDQj+CMCOLUn7qKW0ZVM QLcjXEVW0dfPGoKpmWcBHTSzoiYvEi9UOFRL2kgvMZLtk+io5ONd8YTAvMZrkRuxH7OX 7AxA== ARC-Authentication-Results: i=2; gmr-mx.google.com; spf=neutral (google.com: 2001:a60:0:28:0:1:25:1 is neither permitted nor denied by best guess record for domain of sbabic@denx.de) smtp.mailfrom=sbabic@denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:x-original-sender:x-original-authentication-results :precedence:mailing-list:list-id:list-post:list-help:list-archive :list-subscribe:list-unsubscribe; bh=6xjnO7t+hfLBkVZe/zi1qH9aXkSt96WlTtmlz8FC+Bg=; b=lN5RWGt+MIYwqzjdb2/3L1SZn4PNgBRokGt4t26qG73AfqJ7UFgKsnWnb++67lkIcT aXJ26DdnlxOCjQ3hy0wv403BfPxwiks345b/h/6HoTsKKdAnF6DfC9iLvHKdaNirPMo0 ZsavYBvuH/Jh7wz6EE4gmCoRmclcrHNfe3bkgVFNBTTVoWEoCNjpNIpHAAnPBAlbrgne +VM/0f4VjW+TIT1Sgv9fTLqMMjuRhsIVhyrmvHlVRF/Rjy3IIs9lrypFFRBbBGTjEaQ4 Tb233FI5PiDQ0hTwJMxMAN/+jlRYYvPB73V/igIISVVucGUklH2oUHFKVkzhUHr2uILf FbZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=sender:x-gm-message-state:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :x-spam-checked-in-group:list-post:list-help:list-archive :list-subscribe:list-unsubscribe; bh=6xjnO7t+hfLBkVZe/zi1qH9aXkSt96WlTtmlz8FC+Bg=; b=Jr7sFjGYeG2mvLb+AL5GyEfeh/RIPCM8GHZMG75JH7f/H7me/4ftqv45cBsf7c9H3t BJycdDIg6iINYHaXzqO9n4fWqaf6TUkh6BnN1N3tggJv5M9zuE674f5l9lXnZu4eWUkv 4rT4eZZyTeINNMyVyfztyPM4CN9NdmSS3grJa4EHyDGVWMKNNmbEl1vDvF4L+KCFpyRl His77ToaLq/5wFTT2Ovza4oBoAgnnoQJj29R/d3ZIcsFUdW7vPgX1a/RpRtflRF9iKKh dswivn0HkL5Iw6hEW49Rx8bFVM5S6fRs62mW78Pvr8YLAM2fYhZT6wWSIIppeLUYY7fa 1MGA== Sender: swupdate@googlegroups.com X-Gm-Message-State: AOAM530AV1ABwv/Pn6mV5oZsgAzveiayFMa9h28GYmH7mxpBLRKdq5kQ epLJ7pNxJ+BtgHdp44apemc= X-Google-Smtp-Source: ABdhPJzFx/CNQZqw61ZmEOIZi4ysy6jQDsIxfRMdh9757bwHJlh2pZrk3ez5aTm3qLYb0MNl7FX8Hg== X-Received: by 2002:a05:6000:118e:: with SMTP id g14mr7547144wrx.139.1598791759173; Sun, 30 Aug 2020 05:49:19 -0700 (PDT) X-BeenThere: swupdate@googlegroups.com Received: by 2002:a1c:2049:: with SMTP id g70ls1837483wmg.0.gmail; Sun, 30 Aug 2020 05:49:18 -0700 (PDT) X-Received: by 2002:a1c:3584:: with SMTP id c126mr7344774wma.13.1598791758375; Sun, 30 Aug 2020 05:49:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598791758; cv=none; d=google.com; s=arc-20160816; b=CJ2du4Fekr8gkggeYp2vSkBZIKSU+3JJzQrWmVNXn0yFPfKOSSvQKu/ebQulTptLdN NqNzIJ3iBIy1M6p9XmVmlH4IraWm++PnnCC+n9/9q9yVh7+3XAkUbsMZiXJ6Di0JaDhW vmPfovcRo6TGa/agz4PtBBV9aPzfIDWFTtFZAAMpe4jAwmqLRhPlHS1MZx4hkj91uJ7X W/ISAZ/Nk0+g01CyuvoCDs8A8WUZnn7I5VRDO59phgXQAo4TkLncJ2BNoVJy6SL/5U3i sD1/e4SfzBdEk4R0fDkPfiN+klj0eDxrHtx51SIOkyNZ11XvLUdOcbOGNX+wAs+v9oxF 1/4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from; bh=1qPNPxWgOTCn1X30p7AcihBffEOnTFaBGOqM0+B1O6U=; b=pQ0GKhVNQD+4PnUJcNLdovE95gickZj9fGa/54aJ+DdfAMgkV4RSaN1KHhvrWB0JBg s2jLF7bGLIeEfbMOk7rhbEbB4B8MJ7OV25mgHDqjOxRg7UiFJEQ+Pjkgn16RSQlF8DTL iQ4elbUkImCeHIndMBVNhDRBYxxz3eFUvXExINFICdD/QVitMq1ftuTBobKLq6pewJx9 resh20UofduBjqlXodaatCc9Ha2FUN1tmXGoiQRb1LemFFB6ZX4knwd5e8xdr2bJmiRl fcigx5zBEE0Vxte72DR6T+5941T6uRgDap8UWdIkcPq9PW/QCE9JAc78DM4I6anSy2PG C5/w== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=neutral (google.com: 2001:a60:0:28:0:1:25:1 is neither permitted nor denied by best guess record for domain of sbabic@denx.de) smtp.mailfrom=sbabic@denx.de Received: from mail-out.m-online.net (mail-out.m-online.net. [2001:a60:0:28:0:1:25:1]) by gmr-mx.google.com with ESMTPS id f23si143217wml.3.2020.08.30.05.49.18 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 30 Aug 2020 05:49:18 -0700 (PDT) Received-SPF: neutral (google.com: 2001:a60:0:28:0:1:25:1 is neither permitted nor denied by best guess record for domain of sbabic@denx.de) client-ip=2001:a60:0:28:0:1:25:1; Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4BfY7L0cfBz1rrKZ; Sun, 30 Aug 2020 14:49:18 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4BfY7L0Q9sz1qxtk; Sun, 30 Aug 2020 14:49:18 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id BQk8fP3wYfXc; Sun, 30 Aug 2020 14:49:17 +0200 (CEST) Received: from babic.homelinux.org (host-88-217-136-221.customer.m-online.net [88.217.136.221]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPS; Sun, 30 Aug 2020 14:49:17 +0200 (CEST) Received: from localhost (mail.babic.homelinux.org [127.0.0.1]) by babic.homelinux.org (Postfix) with ESMTP id CDF7745403C9; Sun, 30 Aug 2020 14:49:16 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at babic.homelinux.org Received: from babic.homelinux.org ([IPv6:::1]) by localhost (mail.babic.homelinux.org [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id oLtUDvVmkVsQ; Sun, 30 Aug 2020 14:49:09 +0200 (CEST) Received: from paperino.fritz.box (paperino.fritz.box [192.168.178.64]) by babic.homelinux.org (Postfix) with ESMTP id B271C4540623; Sun, 30 Aug 2020 14:49:09 +0200 (CEST) From: Stefano Babic To: swupdate@googlegroups.com Cc: Stefano Babic Subject: [swupdate] [PATCH 2/3] Make save_state available to coprocesses Date: Sun, 30 Aug 2020 14:49:07 +0200 Message-Id: <20200830124908.88129-2-sbabic@denx.de> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200830124908.88129-1-sbabic@denx.de> References: <20200830124908.88129-1-sbabic@denx.de> MIME-Version: 1.0 X-Original-Sender: sbabic@denx.de X-Original-Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 2001:a60:0:28:0:1:25:1 is neither permitted nor denied by best guess record for domain of sbabic@denx.de) smtp.mailfrom=sbabic@denx.de Precedence: list Mailing-list: list swupdate@googlegroups.com; contact swupdate+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: swupdate@googlegroups.com X-Google-Group-Id: 605343134186 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , The update state sets bootloader variable to track the update state. Due to privilege separations, coprocesses are not automatically allowed to write into the bootloader interface. Create an IPC to let coprocesses like webserver and suricatta to ask the main installer to change the update state. Signed-off-by: Stefano Babic --- core/network_thread.c | 7 +++++++ core/state.c | 22 +++++++++++++++++++++- include/network_ipc.h | 4 +++- 3 files changed, 31 insertions(+), 2 deletions(-) diff --git a/core/network_thread.c b/core/network_thread.c index 41f17e5..7b2d796 100644 --- a/core/network_thread.c +++ b/core/network_thread.c @@ -30,6 +30,7 @@ #include "swupdate.h" #include "pctl.h" #include "generated/autoconf.h" +#include "state.h" #ifdef CONFIG_SYSTEMD #include @@ -213,6 +214,7 @@ void *network_thread (void *data) int pipe; fd_set pipefds; struct timeval tv; + update_state_t value; if (!instp) { TRACE("Fatal error: Network thread aborting..."); @@ -404,6 +406,11 @@ void *network_thread (void *data) if (set_aes_key(msg.data.aeskeymsg.key_ascii, msg.data.aeskeymsg.ivt_ascii)) msg.type = NACK; break; + case SET_UPDATE_STATE: + value = *(update_state_t *)msg.data.msg; + ret = save_state((char *)STATE_KEY, value); + msg.type = (ret == 0) ? ACK : NACK; + break; default: msg.type = NACK; } diff --git a/core/state.c b/core/state.c index 245dfb8..b0d928c 100644 --- a/core/state.c +++ b/core/state.c @@ -12,6 +12,10 @@ #include #include #include +#include +#include +#include +#include "pctl.h" /* * This check is to avoid to corrupt the environment @@ -28,16 +32,32 @@ static server_op_res_t do_save_state(char *key, char* value) { + char c; CHECK_STATE_VAR(key); + if (!value) + return -EINVAL; + c = *value; + if (c < STATE_OK || c > STATE_LAST) + return -EINVAL; return bootloader_env_set(key, value) == 0 ? SERVER_OK : SERVER_EERR; } server_op_res_t save_state(char *key, update_state_t value) { char value_str[2] = {value, '\0'}; - return do_save_state(key, value_str); + ipc_message msg; + if (pid == getpid()) { + memset(&msg, 0, sizeof(msg)); + msg.magic = IPC_MAGIC; + msg.type = SET_UPDATE_STATE; + msg.data.msg[0] = (char)value; + return (ipc_send_cmd(&msg)); + } else { /* Main process */ + return do_save_state(key, value_str); + } } + server_op_res_t save_state_string(char *key, update_state_t value) { return do_save_state(key, get_state_string(value)); diff --git a/include/network_ipc.h b/include/network_ipc.h index 520ae09..16923a9 100644 --- a/include/network_ipc.h +++ b/include/network_ipc.h @@ -33,7 +33,9 @@ typedef enum { POST_UPDATE, SWUPDATE_SUBPROCESS, REQ_INSTALL_DRYRUN, - SET_AES_KEY + SET_AES_KEY, + SET_UPDATE_STATE, /* set bootloader ustate */ + GET_UPDATE_STATE /* return bootloader ustate */ } msgtype; /* From patchwork Sun Aug 30 12:49:08 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefano Babic X-Patchwork-Id: 1353940 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=googlegroups.com (client-ip=2a00:1450:4864:20::139; helo=mail-lf1-x139.google.com; envelope-from=swupdate+bncbcxploxj6ikrbu6av35akgqeayqlday@googlegroups.com; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=googlegroups.com header.i=@googlegroups.com header.a=rsa-sha256 header.s=20161025 header.b=EwyCi1g9; dkim-atps=neutral Received: from mail-lf1-x139.google.com (mail-lf1-x139.google.com [IPv6:2a00:1450:4864:20::139]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4BfY7W5Ntsz9sSP for ; Sun, 30 Aug 2020 22:49:27 +1000 (AEST) Received: by mail-lf1-x139.google.com with SMTP id z77sf1299757lfc.2 for ; Sun, 30 Aug 2020 05:49:27 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1598791764; cv=pass; d=google.com; s=arc-20160816; b=VfNvY5PBed3MDmit7mW9cPhAlH/UTaNK/LE5r9Jrtd+K/KHPjyXbTpXr2zkaVLu3z7 Hw/5Ci3g+AUbAq/FQuYqbTaznmLwHDFr5C96dnphOrLdzAEPt6jQyLzIC66vTzOywrYr tFnajcDChMfbssc/LDTJ4+LjGHvwxK5Vc/iDlNke2eGWTlYL5N1/BiAuIubmqwnfZhmg SlklHYYtVm+sZpx7CjTdFdKhQkjhQtHnLkG/T+s/5yle7EqA0DRSJqu4LGvL/X8W33nt +rBO4y+vVBfmV9uF1CnSE40OkaSkJMrzcOQMfcbZfykGVp1bBalu0J+kUUHH7mBWIXIY 6TIw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:dkim-signature; bh=2K0w1+ht6H3LAzYOp/gio1L02YUwgAgl2WSW/bvbwfk=; b=NqGdBfUNA/28NtHdXFmMTWoOLjFMMvQpg0u16SnSORdgF5PBVbrR1iO2gLDb9pvWgU 3n2rwRF1VwInIUNRv8+2gDvQScn8SaQ0YalCZdEvOtdwJ5xs40qRpJvB0WLrdJR1tnqC CGnV4/5j+wQALq0ufn9eidzHE6tAHkvdh/p7P9Eu4LI4qn8dKtRI77t3FA1RyKSJqWCj TEkvxjUOYV0nPuwNGeGr5VfFDGNl9DxhlPiKriyePdH0y9nEYxGNO0R5ytK8ZzwVqL64 QbTj3OzyURgRx7juMOKAWCDFdxlDH2W6E+AJOw7OzvNxeAjurMLW7Ixsv2FOdtOPCb4q V6rA== ARC-Authentication-Results: i=2; gmr-mx.google.com; spf=neutral (google.com: 2001:a60:0:28:0:1:25:1 is neither permitted nor denied by best guess record for domain of sbabic@denx.de) smtp.mailfrom=sbabic@denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:x-original-sender:x-original-authentication-results :precedence:mailing-list:list-id:list-post:list-help:list-archive :list-subscribe:list-unsubscribe; bh=2K0w1+ht6H3LAzYOp/gio1L02YUwgAgl2WSW/bvbwfk=; b=EwyCi1g9rTEUO4yL9oP38szdS4fUlLJ8gqhtyVqCWZxGBJ/OTWhmtdHbf3m4IY4W/k OjHEt7UCjyGbhNC6b2frsAfjd8/sInTdOzz7t/FnAjQ22XzgL886bhjhPs+1MHQoYIzj bZYWOHzTABPpkdzTUk5b1FVUsEItIT6B/XhnIIWAG11TBw5R/cmKnpqbn+U8vt+AHT5J ohBTLi55CQvwMQoJZxH0fCSVqVsFaqvQfA4stnbMNMnssDu4Krsiw4YMDtTSt0BzbeWw Vu+GTxdPRXVeBVFE816vquVKQ+KYz+ExdODLY3QZcsgFNhK4UZ6xaSXE5rKS8O0IRPgh K+Wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=sender:x-gm-message-state:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :x-spam-checked-in-group:list-post:list-help:list-archive :list-subscribe:list-unsubscribe; bh=2K0w1+ht6H3LAzYOp/gio1L02YUwgAgl2WSW/bvbwfk=; b=JFwpR1qRDBRjuB7shALB1SqTaHXDnhR7Y5h7pWVHjPY5mKdDuzvmXXb64jcoz0yblw QsTGU2hJXYAAGaTmFOV216hHk85crhRTrPOlwRRDIA4MamPbJc8oMCRLeqhwc5VoaqXu QXSJLrOPn8WlKpTfRALt0aERk9RBHtu50MsE/N+Ble95OqvXwCHAuqrwlhsh90FMCUHG E2wcq+WhgmxSipv4JoIR+fMVgPyCWWXGcUY1HpelQtjojrgfcLiUzm9Gl3SSs3lYijdc D9zxFZbUmvUu9JuB5GYsIq2DyTd8KVz5+bQ4rAQ+qJ4iP/XCsg6XsgWvhBqkG0l7ddYi 9/ZA== Sender: swupdate@googlegroups.com X-Gm-Message-State: AOAM533AFVAe+vH7QZEziSPCsxfe1TAAqtBqPZjHz1S3D77eFbq2T6Xj aXrUV2po2EP0Ksf5P463Xi0= X-Google-Smtp-Source: ABdhPJyPVtWkoJ9oRuqU5+fCl+KvNDSbyzRRc2EUUutRuNMCwTtkntAOKCXWKAytZcNnjVjAn6EZaA== X-Received: by 2002:a2e:b8c2:: with SMTP id s2mr3422671ljp.179.1598791764131; Sun, 30 Aug 2020 05:49:24 -0700 (PDT) X-BeenThere: swupdate@googlegroups.com Received: by 2002:ac2:5e33:: with SMTP id o19ls877237lfg.1.gmail; Sun, 30 Aug 2020 05:49:23 -0700 (PDT) X-Received: by 2002:ac2:43d5:: with SMTP id u21mr3431446lfl.135.1598791763138; Sun, 30 Aug 2020 05:49:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598791763; cv=none; d=google.com; s=arc-20160816; b=lrexV/owsrRRyI3uERSYcOrIx9isHoB5eKs6lmlYBxsXxbxDxLma7vHhwNb02x1+hj X0w24wqvQTNsxYRnPc3HaF1OzasvQ1dneU/jL0wQv9fNIi03mi23x06v7f26wGc+Z6vU MWGUzv9yNDTQ/N5z450bCXnxeP3jXzuD5K/NHCk7eCgEVY3QnsG/JvVoCf6jZyrkX+3I Yk+6czQcD/AXdR2Rl7tXQ9ZvA47rquPPoVDVYv1VHHNJoodKylKNCjrGFv+nIQyxjgme CVN1Mybvfwt9FWifUkzQ2JZ8G6le3+kIYJsMJyrh26Hn8NUNf+50GnS3ZG9QUnRmAI3r Mi0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from; bh=lSftmNvY9jSigiONpy7nB4+u5HwxRg/cELHINZ+0Jws=; b=VjvFTlUJH/tXZ9swA9bBnvvmBdpMT8qmW19OkEswVyi1RPS1r+uVWMDadJdUCwnUsc RO7RoPvBIuQ0XcDDyOaQDtztmBXZSzEBpagYS7QehVACJem7b/jETVS1ntsTdWdQFsMk 4I/L5USEYNxhKWV3/nC3uazonBEpMbyNhK2gAQzGrvzzApiZdyYp77HR0btdJu2Ouggn tRBNiEg3PfEuKZeHQAETnh5XjBx8u9r/Qo0uAVZP0PaAXi285N3WRN6R2wiEJsSoKH9P 8cR2+8qcC6gMNCfwuL6XjDXR1JUMTwXUIK9NsiV1vWNsBCX+zedroF2cpUnwOpCoGpPb fhGA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=neutral (google.com: 2001:a60:0:28:0:1:25:1 is neither permitted nor denied by best guess record for domain of sbabic@denx.de) smtp.mailfrom=sbabic@denx.de Received: from mail-out.m-online.net (mail-out.m-online.net. [2001:a60:0:28:0:1:25:1]) by gmr-mx.google.com with ESMTPS id r28si189851lfi.0.2020.08.30.05.49.22 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 30 Aug 2020 05:49:23 -0700 (PDT) Received-SPF: neutral (google.com: 2001:a60:0:28:0:1:25:1 is neither permitted nor denied by best guess record for domain of sbabic@denx.de) client-ip=2001:a60:0:28:0:1:25:1; Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4BfY7Q4526z1rrKb; Sun, 30 Aug 2020 14:49:22 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4BfY7Q3xQ8z1qxtk; Sun, 30 Aug 2020 14:49:22 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id saub9CGVN7v9; Sun, 30 Aug 2020 14:49:21 +0200 (CEST) Received: from babic.homelinux.org (host-88-217-136-221.customer.m-online.net [88.217.136.221]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPS; Sun, 30 Aug 2020 14:49:21 +0200 (CEST) Received: from localhost (mail.babic.homelinux.org [127.0.0.1]) by babic.homelinux.org (Postfix) with ESMTP id 6DED9454060F; Sun, 30 Aug 2020 14:49:21 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at babic.homelinux.org Received: from babic.homelinux.org ([IPv6:::1]) by localhost (mail.babic.homelinux.org [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id vDgeYa1Q9DSO; Sun, 30 Aug 2020 14:49:15 +0200 (CEST) Received: from paperino.fritz.box (paperino.fritz.box [192.168.178.64]) by babic.homelinux.org (Postfix) with ESMTP id D64ED45406B0; Sun, 30 Aug 2020 14:49:09 +0200 (CEST) From: Stefano Babic To: swupdate@googlegroups.com Cc: Stefano Babic Subject: [swupdate] [PATCH 3/3] Save Update State after each update Date: Sun, 30 Aug 2020 14:49:08 +0200 Message-Id: <20200830124908.88129-3-sbabic@denx.de> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200830124908.88129-1-sbabic@denx.de> References: <20200830124908.88129-1-sbabic@denx.de> MIME-Version: 1.0 X-Original-Sender: sbabic@denx.de X-Original-Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 2001:a60:0:28:0:1:25:1 is neither permitted nor denied by best guess record for domain of sbabic@denx.de) smtp.mailfrom=sbabic@denx.de Precedence: list Mailing-list: list swupdate@googlegroups.com; contact swupdate+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: swupdate@googlegroups.com X-Google-Group-Id: 605343134186 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , Just suricatta backend are saving the update state into the bootloader environment. Move this away from suricatta, factorize it and save the update state always after each update. Signed-off-by: Stefano Babic --- core/stream_interface.c | 7 ++++++- suricatta/server_general.c | 9 --------- suricatta/server_hawkbit.c | 6 ------ 3 files changed, 6 insertions(+), 16 deletions(-) diff --git a/core/stream_interface.c b/core/stream_interface.c index 99e5c62..4576057 100644 --- a/core/stream_interface.c +++ b/core/stream_interface.c @@ -556,7 +556,9 @@ void *network_initializer(void *data) } notify(FAILURE, RECOVERY_ERROR, ERRORLEVEL, "Installation failed !"); inst.last_install = FAILURE; - + if (save_state((char *)STATE_KEY, STATE_FAILED) != SERVER_OK) { + ERROR("Cannot persistently store update state."); + } } else { /* * Clear the recovery variable to indicate to bootloader @@ -567,6 +569,9 @@ void *network_initializer(void *data) } notify(SUCCESS, RECOVERY_NO_ERROR, INFOLEVEL, "SWUPDATE successful !"); inst.last_install = SUCCESS; + if (save_state((char *)STATE_KEY, STATE_INSTALLED) != SERVER_OK) { + ERROR("Cannot persistently store update state."); + } } } else { inst.last_install = FAILURE; diff --git a/suricatta/server_general.c b/suricatta/server_general.c index 5d63207..e346295 100644 --- a/suricatta/server_general.c +++ b/suricatta/server_general.c @@ -556,15 +556,6 @@ server_op_res_t server_install_update(void) goto cleanup; } - /* - * Everything fine, set the state to INSTALLED - */ - if ((result = save_state((char *)STATE_KEY, STATE_INSTALLED)) != - SERVER_OK) { - ERROR("Cannot persistently store update state.\n"); - goto cleanup; - } - cleanup: free(channel_data.url); return result; diff --git a/suricatta/server_hawkbit.c b/suricatta/server_hawkbit.c index 29b1ca4..5834e4f 100644 --- a/suricatta/server_hawkbit.c +++ b/suricatta/server_hawkbit.c @@ -1398,12 +1398,6 @@ server_op_res_t server_install_update(void) } } - if ((result = save_state((char *)STATE_KEY, STATE_INSTALLED)) != - SERVER_OK) { - ERROR("Cannot persistently store update state."); - goto cleanup; - } - if (server_send_deployment_reply( server_hawkbit.channel, action_id, json_data_chunk_max, json_data_chunk_count,