From patchwork Thu Aug 20 12:42:48 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thorsten Kukuk X-Patchwork-Id: 1348361 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=sourceware.org (client-ip=8.43.85.97; helo=sourceware.org; envelope-from=libc-alpha-bounces@sourceware.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=suse.de Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4BXPSb6P9gz9sRK for ; Thu, 20 Aug 2020 22:42:55 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8E5663844019; Thu, 20 Aug 2020 12:42:52 +0000 (GMT) X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by sourceware.org (Postfix) with ESMTPS id 67FEC3861830 for ; Thu, 20 Aug 2020 12:42:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 67FEC3861830 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=kukuk@suse.de X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 760EBAF43 for ; Thu, 20 Aug 2020 12:43:15 +0000 (UTC) Date: Thu, 20 Aug 2020 14:42:48 +0200 From: Thorsten Kukuk To: libc-alpha@sourceware.org Subject: [PATCH] nss: remove obsolete code Message-ID: <20200820124248.GA2500@suse.de> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Status: No, score=-9.4 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" Hi, glibc still ships with the /etc/default/nss configuration file and the defines for it, but the code reading and using it got completly removed. So the config file and the defines should be removed, too. Ok to commit? Thorsten From d2b96c651900fec532fd2ecb0d755b4adb458b77 Mon Sep 17 00:00:00 2001 From: Thorsten Kukuk Date: Thu, 20 Aug 2020 14:36:52 +0200 Subject: [PATCH 1/1] Remove obsolete default/nss code All code reading /etc/default/nss and using the internal defines got removed, so the config file should be removed, too. --- nis/libnsl.h | 6 ------ nis/nss | 37 ------------------------------------- 2 files changed, 43 deletions(-) delete mode 100644 nis/nss diff --git a/nis/libnsl.h b/nis/libnsl.h index 64ca262579..d9235ef604 100644 --- a/nis/libnsl.h +++ b/nis/libnsl.h @@ -17,12 +17,6 @@ #include -#define NSS_FLAG_NETID_AUTHORITATIVE 1 -#define NSS_FLAG_SERVICES_AUTHORITATIVE 2 -#define NSS_FLAG_SETENT_BATCH_READ 4 -#define NSS_FLAG_ADJUNCT_AS_SHADOW 8 - - /* Set up everything for a call to __do_niscall3. */ extern nis_error __prepare_niscall (const_nis_name name, directory_obj **dirp, dir_binding *bptrp, unsigned int flags); diff --git a/nis/nss b/nis/nss deleted file mode 100644 index 0ac6774a1f..0000000000 --- a/nis/nss +++ /dev/null @@ -1,37 +0,0 @@ -# /etc/default/nss -# This file can theoretically contain a bunch of customization variables -# for Name Service Switch in the GNU C library. For now there are only -# four variables: -# -# NETID_AUTHORITATIVE -# If set to TRUE, the initgroups() function will accept the information -# from the netid.byname NIS map as authoritative. This can speed up the -# function significantly if the group.byname map is large. The content -# of the netid.byname map is used AS IS. The system administrator has -# to make sure it is correctly generated. -#NETID_AUTHORITATIVE=TRUE -# -# SERVICES_AUTHORITATIVE -# If set to TRUE, the getservbyname{,_r}() function will assume -# services.byservicename NIS map exists and is authoritative, particularly -# that it contains both keys with /proto and without /proto for both -# primary service names and service aliases. The system administrator -# has to make sure it is correctly generated. -#SERVICES_AUTHORITATIVE=TRUE -# -# SETENT_BATCH_READ -# If set to TRUE, various setXXent() functions will read the entire -# database at once and then hand out the requests one by one from -# memory with every getXXent() call. Otherwise each getXXent() call -# might result into a network communication with the server to get -# the next entry. -#SETENT_BATCH_READ=TRUE -# -# ADJUNCT_AS_SHADOW -# If set to TRUE, the passwd routines in the NIS NSS module will not -# use the passwd.adjunct.byname tables to fill in the password data -# in the passwd structure. This is a security problem if the NIS -# server cannot be trusted to send the passwd.adjuct table only to -# privileged clients. Instead the passwd.adjunct.byname table is -# used to synthesize the shadow.byname table if it does not exist. -#ADJUNCT_AS_SHADOW=TRUE -- 2.26.2