From patchwork Mon Aug 17 19:48:21 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marcelo Henrique Cerri X-Patchwork-Id: 1346483 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=canonical.com Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4BVl360XdXz9sTH; Tue, 18 Aug 2020 05:48:33 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1k7l7N-0000J2-99; Mon, 17 Aug 2020 19:48:29 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1k7l7M-0000Iu-8k for kernel-team@lists.ubuntu.com; Mon, 17 Aug 2020 19:48:28 +0000 Received: from mail-qk1-f198.google.com ([209.85.222.198]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1k7l7L-00037c-U9 for kernel-team@lists.ubuntu.com; Mon, 17 Aug 2020 19:48:28 +0000 Received: by mail-qk1-f198.google.com with SMTP id h185so11529455qke.21 for ; Mon, 17 Aug 2020 12:48:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=5EKsbFK7gF0tlaMSRYt9ANC0UidGJhJwLmWzitjmRTY=; b=YFXciHTZVbsy4SRK+sTWfHVNXBVld2LRhBqVWUWdfZ70TR9zk0c+T/mjQAGBN3eYlw s9LsVrftA+lGoXk6Oex7tBLsfIzJJ6s2t4ITou048+GM1/kD9ZKi+y3j0DYkid1c4iYM psHX0wPy8lhDCUfH+VBtbpgF3r6VqIhfJKwT0OQ+CWXMlJP4FBDDG+05/7VKmc2fUkdT IuHMLqHKYRIGEVxEmq75n8ucrUBohtBBpjzcvlaeo1/SlGWf0o6+4RiDFxm7e3HO55PM JNBYG7IwTfQKodL7rqHSEgq5JyOg3u7FufkXhdsqYDNwh1KPJwyVOH0kEShjuXxah8sT 3YrA== X-Gm-Message-State: AOAM530ysYitwTFRGAVSNd0UtaZFrJRPPvpqRIES72gmae/i7hP/sNBo VeX72WUOAlmqmOlx69z4hkb1tYon0Kz7A9g0JJT58LTg+4+A0EmudO86QBRud4UhlcR3n8Z4Ixb RlLmSO8778zP24UbLWPozyh4Z77OQFtwYY/v2xHZ/ X-Received: by 2002:a05:620a:4d9:: with SMTP id 25mr14010912qks.411.1597693706726; Mon, 17 Aug 2020 12:48:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwDX2U/pmPnYz5ZyiL+Lm5maR31ES1xR16c0pmQu3O9MuBe6rJ3qHAwWFWyMHZoxmDxUz2JbQ== X-Received: by 2002:a05:620a:4d9:: with SMTP id 25mr14010887qks.411.1597693706295; Mon, 17 Aug 2020 12:48:26 -0700 (PDT) Received: from valinor.lan ([201.82.186.200]) by smtp.gmail.com with ESMTPSA id f189sm18070347qke.15.2020.08.17.12.48.24 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Aug 2020 12:48:25 -0700 (PDT) From: Marcelo Henrique Cerri To: kernel-team@lists.ubuntu.com Subject: [focal:linux-azure][PATCH v2] Revert "video: hyperv_fb: Fix hibernation for the deferred IO feature" Date: Mon, 17 Aug 2020 16:48:21 -0300 Message-Id: <20200817194821.3393529-1-marcelo.cerri@canonical.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200817192112.3183372-2-marcelo.cerri@canonical.com> References: <20200817192112.3183372-2-marcelo.cerri@canonical.com> MIME-Version: 1.0 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" BugLink: https://bugs.launchpad.net/bugs/1891931 This reverts commit 0a14dbaa0736a6021c02e74d42cf3a7ca5438da6. This commit was included as part of bug #1880032 ([linux-azure] Enable Hibernation on The 18.04 and 20.04 5.4 Kernels), however this change wasn't necessary because the base feature is not present in our 5.4 kernel. The unnecessary commit causes a panic when triggering hibernation in some azure instances. The panic can be reproduced in E and D instances types in azure. And Reverting the commit solves the issue. After the revert hibernation succeeds on instances under high memory utilization, up to 70%, when tested with stress-ng (ie, stress-ng --vm 8 --vm-bytes 50% -t 1d). Signed-off-by: Marcelo Henrique Cerri Acked-by: Thadeu Lima de Souza Cascardo --- drivers/video/fbdev/hyperv_fb.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/video/fbdev/hyperv_fb.c b/drivers/video/fbdev/hyperv_fb.c index 5017b4b20781..fe4731f97df7 100644 --- a/drivers/video/fbdev/hyperv_fb.c +++ b/drivers/video/fbdev/hyperv_fb.c @@ -891,7 +891,6 @@ static int hvfb_suspend(struct hv_device *hdev) fb_set_suspend(info, 1); cancel_delayed_work_sync(&par->dwork); - cancel_delayed_work_sync(&info->deferred_work); par->update_saved = par->update; par->update = false; @@ -925,7 +924,6 @@ static int hvfb_resume(struct hv_device *hdev) par->fb_ready = true; par->update = par->update_saved; - schedule_delayed_work(&info->deferred_work, info->fbdefio->delay); schedule_delayed_work(&par->dwork, HVFB_UPDATE_DELAY); /* 0 means do resume */