From patchwork Wed Aug 5 16:31:42 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heinrich Schuchardt X-Patchwork-Id: 1341289 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=gmx.de Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.a=rsa-sha256 header.s=badeba3b8450 header.b=BqSprXzQ; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4BMHHQ1cp7z9sRK for ; Thu, 6 Aug 2020 02:33:19 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6722181BB4; Wed, 5 Aug 2020 18:33:07 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.b="BqSprXzQ"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 719AC81F22; Wed, 5 Aug 2020 18:33:06 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,FREEMAIL_FROM,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from mout.gmx.net (mout.gmx.net [212.227.15.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 9906981B65 for ; Wed, 5 Aug 2020 18:33:03 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=xypron.glpk@gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1596645182; bh=0iJP/w0wKMO+A4ytVVHa9HVNF6/DX/t04t+1MslzHTM=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date; b=BqSprXzQpetsYQiWRHUDZKoQr8cz4fX/xYsQ+7YCR3BwQUEKd3A+NUux4KfMqStcj QqG7TIxSGvDWH260JlLSmiKd13DssscTyM7vyyKakyV8DSAvYKrp5o3WvcFuJltsl8 C+Rjxu7tZIidJ/b5ciKumstoowrZWPqxI5xh74nM= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from workstation4.fritz.box ([178.202.41.107]) by mail.gmx.com (mrgmx004 [212.227.17.184]) with ESMTPSA (Nemesis) id 1MCbIn-1juJen0XJ5-009iyf; Wed, 05 Aug 2020 18:33:02 +0200 From: Heinrich Schuchardt To: Tom Rini Cc: Sean Anderson , u-boot@lists.denx.de, Heinrich Schuchardt Subject: [PATCH 1/1] test: py: test_shell_run() with CONFIG_HUSH_PARSER=n Date: Wed, 5 Aug 2020 18:31:42 +0200 Message-Id: <20200805163142.45697-1-xypron.glpk@gmx.de> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 X-Provags-ID: V03:K1:nyVuk6Bt1eZa/y20KwGe64GDt5gFfxPS8+eP23fqycRcwtUtxLM ECPoPdNvQ8HkGAmWryA2+0ThPodjEnviO0sfDKRVxgaTq77TxY6S9pFXVGdnq7N05wqN/tm MlX637Qc5uC2HRUPsdWTiuSkZrb+ttnH74LqCIRVYLwP3iX0rhYfgEXDhkTM/yOPjMPG0T1 3l9DwLsOylYN2gB8/XHpw== X-UI-Out-Filterresults: notjunk:1;V03:K0:XHMDk5F3DRs=:MciqutxGL/o9oZXPojNlAm SzJcA8yKBiXRe9jps4atLihrm0HgQQF45H6QHXAy0ySgTRafd1Gc9LTGUe/7SzafZLgsx21jn 3oAC+59isNwAqTl5i2/1qYdLmDgnkL48/lM2wS2uJ2PuPzWrxHBdFlAG6ZWw6JFslSQ9bnc2Q GSMzHljTJXewtIsKvO/GQ4hUqoA7jeeO1s/z7g7sSUokhPW5BObnc5kgVytF5es2qWaJis/df pZG97G1gBn3f1QJNujzisK4NDLZ2U+eSgVtcKJpt/j0xRKBoDLayA8X1ufZ+h4Nc3Zuq/xEuH ujHQsbVN/4OZV0lUG8qtiLpe7E0LmjOmIUNx7SBjBHfO0Kwn9Dy4Wx7ZonLoFRLjhIFA9vPIX h/xUfF/+4OODibVEcdkNDMxnkLAk5mdtLh1MZ8T7VpVeQqXhlwb+0F62ArT+FBJnYCldvQI9L dgwT5iteCFdmQFvo3x9yBVIHREp0bUHqQjLI4CvLvXfNRYPQ5dEZlLvNzSzvZ5DAgjR5/Dp/4 LicqMxxLrVGHgsWB1sC2ROwPEciA6DEC6MvFdUJmfLZg3f26bK6fKa2qsIL39ZjnqSUyX+HFS Z4OSCDJp06utUJKV+toyD20uPxowxdEhTR5YtqagCXc0fbIJdpbZPj7LQDzFzbZ/KamcsUsGS 30Bdl5fo6T5PUkZnln1WVeONZz52iru4aEpd92/LT8DS8L7d/X0RBRB3yJMvEarZUj5qX3Qm/ tZVbrbibDHUmHrSJgVpWCvysCOVzorhJWpQ/Xt2HSNqsDgReHY6DNCnEij3naKE2aAeuIMap+ sWDpI2NQjmW8GbeXUFQBtGr5wtmuNRcxtKes9yWHMI6RkYdJHHSDNmmeyAw/bqj5aBLDpVGWu UtWjLXMKlJV1PDktxbCDe6ILhxwrrDjWYjD7PZVZ4l7yUUQLlpPJiulrvGb0XbskiCh2HD32L OSRKbeiyaOmWQOkvT5VRM7RmL478OJv6xesrspwWUVch37Av7LXq0Il/56eaFPO5V1BVBzH8m Uc/kY+KVwlf3Q4AKA6kSkDp0J1xCUORItIndF9imJj+FU9JQdzXYoAQYyYGQTGeHgz/McR6FQ CnOYGBk3XGJHHn14QzPPMR3XdIAH3PSmUlz8UqoUl63IXdW1NL58hwblzbOSopoogy00hZvXn CzXr81X84PGODRwEgavvuMXbypr2yK8LLLay6bm87RjNZT5T+MzPL6Lu82b6+fCwsRt+bP04I BE7Wty0UU2EboZadBoYSdAewVfqPPyv3L0a/sCA== X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.3 at phobos.denx.de X-Virus-Status: Clean The hush parser not enabled for some boards, e.g. sipeed_maix_bitm_defconfig. With CONFIG_HUSH_PARSER=n a double quotation mark is not interpreted as the beginning of a string. Use a single quotation mark instead. Furthermore without the hush parser variables have to be referenced as ${varname}. Add the missing braces. Reported-by: Sean Anderson Fixes: 8b86c609b860 ("test/py: add test of basic shell functionality") Signed-off-by: Heinrich Schuchardt --- test/py/tests/test_shell_basics.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- 2.27.0 diff --git a/test/py/tests/test_shell_basics.py b/test/py/tests/test_shell_basics.py index f54f7b7425..68a3f892f6 100644 --- a/test/py/tests/test_shell_basics.py +++ b/test/py/tests/test_shell_basics.py @@ -34,11 +34,11 @@ def test_shell_semicolon_three(u_boot_console): def test_shell_run(u_boot_console): """Test the "run" shell command.""" - u_boot_console.run_command('setenv foo "setenv monty 1; setenv python 2"') + u_boot_console.run_command('setenv foo \'setenv monty 1; setenv python 2\'') u_boot_console.run_command('run foo') - response = u_boot_console.run_command('echo $monty') + response = u_boot_console.run_command('echo ${monty}') assert response.strip() == '1' - response = u_boot_console.run_command('echo $python') + response = u_boot_console.run_command('echo ${python}') assert response.strip() == '2' u_boot_console.run_command('setenv foo') u_boot_console.run_command('setenv monty')