From patchwork Fri Jul 31 14:12:32 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Rini X-Patchwork-Id: 1339466 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=konsulko.com Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4BJ8Pj1KsTz9sVQ for ; Sat, 1 Aug 2020 00:12:51 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 97EC081996; Fri, 31 Jul 2020 16:12:42 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 63A35819F0; Fri, 31 Jul 2020 16:12:41 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_MSPIKE_H2, SPF_HELO_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-qk1-f173.google.com (mail-qk1-f173.google.com [209.85.222.173]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 7E77C81817 for ; Fri, 31 Jul 2020 16:12:38 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=tom.rini@gmail.com Received: by mail-qk1-f173.google.com with SMTP id d14so28833538qke.13 for ; Fri, 31 Jul 2020 07:12:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=5w3RyqrW5VEsY+oLqpXsfOBpXjzb0wIOouoT6MEyosA=; b=BPyEPVkuHsIF/1q+0tkWIi+e+6LbSeyMC3K0CXNvckxUSUR2CWkjEP8YDZyiWe8N2c da4URqWdn4DVROF2iJryTdhYwCKyJG8WlOu6a/kkC+RcoJpjxnkYZlgxvaeSLE20zRKx f3eLkNrJ9cSpp1hk6YUBWE9wst/1lDz2M0HM2tbFDFavM3JcNX8odOSgcR5CY0ohFnDr 3HJFbImPcLTKVS36Aq0RaAs/16/60B6ReG/iNU9j4v1CTNC6wXNtLMlCrenZttoRE1NG hvGC86B46Uqfx0OZxLLcDrDcnu0xEQJy6P0f7tVXHlIfNhiyIJrD89t5LqjGPMI+4dOf 04Gw== X-Gm-Message-State: AOAM531iGjXD1FqsU0zjF6fRH62FTtSMyEX/2VBnkYvRlZAOsb0rlxDh HJ6AIx5SvWEf9QyNbzofp/xbRl4= X-Google-Smtp-Source: ABdhPJydvlURgSEH+rsJYXgPwB5KD19qX3omSuF6V7xG81Z0A08h3Kb2OXXFVx4HR/NGnaILJW5O9g== X-Received: by 2002:ae9:e00b:: with SMTP id m11mr2833007qkk.341.1596204756766; Fri, 31 Jul 2020 07:12:36 -0700 (PDT) Received: from bill-the-cat.local (2606-a000-1401-8c61-6d11-204e-d06e-51c6.inf6.spectrum.com. [2606:a000:1401:8c61:6d11:204e:d06e:51c6]) by smtp.gmail.com with ESMTPSA id r6sm6440384qkc.43.2020.07.31.07.12.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jul 2020 07:12:35 -0700 (PDT) From: Tom Rini To: u-boot@lists.denx.de Cc: Heinrich Schuchardt Subject: [PATCH] test: efi_selftest: Do not force serial# setting Date: Fri, 31 Jul 2020 10:12:32 -0400 Message-Id: <20200731141232.618-1-trini@konsulko.com> X-Mailer: git-send-email 2.17.1 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.3 at phobos.denx.de X-Virus-Status: Clean As part of the EFI self test we set and check the serial# variable. However, we should not be forcing this setting. In the case where we are allowed to change the variable it will change, and we will pass the test. In the case where we cannot change it, force may or may not be allowed, depending on further environment restrictions. Drop the -f flag here as we do not need it. Cc: Heinrich Schuchardt Signed-off-by: Tom Rini --- test/py/tests/test_efi_selftest.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/py/tests/test_efi_selftest.py b/test/py/tests/test_efi_selftest.py index 971c9f6053a3..9b520c2070b2 100644 --- a/test/py/tests/test_efi_selftest.py +++ b/test/py/tests/test_efi_selftest.py @@ -36,7 +36,7 @@ def test_efi_selftest_device_tree(u_boot_console): output = u_boot_console.run_command('bootefi selftest') assert '\'device tree\'' in output u_boot_console.run_command(cmd='setenv efi_selftest device tree') - u_boot_console.run_command(cmd='setenv -f serial# Testing DT') + u_boot_console.run_command(cmd='setenv serial# Testing DT') u_boot_console.run_command(cmd='bootefi selftest ${fdtcontroladdr}', wait_for_prompt=False) m = u_boot_console.p.expect(['serial-number: Testing DT', 'U-Boot']) if m != 0: