From patchwork Sun Jul 26 21:08:23 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Yann E. MORIN" X-Patchwork-Id: 1336553 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=busybox.net (client-ip=140.211.166.137; helo=fraxinus.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=free.fr Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=gd2O1kYL; dkim-atps=neutral Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4BFFsc4vchz9sRR for ; Mon, 27 Jul 2020 07:08:36 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 4D2EC854F7; Sun, 26 Jul 2020 21:08:34 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JuByIupbzPyL; Sun, 26 Jul 2020 21:08:32 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by fraxinus.osuosl.org (Postfix) with ESMTP id C3C6B85102; Sun, 26 Jul 2020 21:08:32 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id ACEFC1BF3E8 for ; Sun, 26 Jul 2020 21:08:31 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id A8F4587EB8 for ; Sun, 26 Jul 2020 21:08:31 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id AeN0QkHur0l8 for ; Sun, 26 Jul 2020 21:08:30 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) by hemlock.osuosl.org (Postfix) with ESMTPS id A1E5E88012 for ; Sun, 26 Jul 2020 21:08:30 +0000 (UTC) Received: by mail-wm1-f48.google.com with SMTP id 3so5872603wmi.1 for ; Sun, 26 Jul 2020 14:08:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=yjCSE6WVu4GiAtaVYAMp4OZEFZVyiMTYTPn2LW0jVvs=; b=gd2O1kYLoENXJPQuu12dAzaHsbSTP1lpPXA8IeSy0t+f4yq0eGn18WSM/d1i6VsOpQ mlrpJeEQerwEgMe2NN+jHQI84Ey81g44cwgInLsQXL6nDTKmdp348MMh+WnfRdqgGzT/ BitmMCX52Y+TYJmBohMgiieoJmtwSGyBnAtrSxjmToV0KBdyYnDxfWZ35YW185op4Npy Z0c2KC3SFg486MzgwBKmIHLv3S5OZntZsvNNc6vSQRMP4YKYSd/oiRb3kJhN6vZsP6O9 j5rzaFagt6zIs2gZFKORddslBFK68g4+7qrLWKesQRQgPF3MJm2tKM0f+bwABDGawkgr rMgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=yjCSE6WVu4GiAtaVYAMp4OZEFZVyiMTYTPn2LW0jVvs=; b=W35ypZA6fx2ZAuTq3zGGy1LmGihmoAAA2T5uhc7+zUhKYbWYIsYLkGrn8LWcb5iptu YWe2rXCfxDYV+nnqu3TYWdb1pVyY3bfY3KWd7gyt+3uQaAbqLkkA8grtXPEbawlPAqCK AsIKSxRvydsL9TwC2XcApfFcqfSli1II05npgrU87xe7FhapdAbEzd8LVsetg/rDK4U+ +kpEZ80HdWk8zVVEvwlScfqFw1GngqUcnulL0QHKZNbBgEwxjEu0kypco2Vj01pn0eg9 94Iq2ImGf+iCRJQ2QYVN9QHsCFpsTbr1XGj68UO5CHn2WMx6c/J5Fd++4r6jiLngFI3z hHHQ== X-Gm-Message-State: AOAM5321wVxdABdf32Nbtz3gx9kzg+Q+VRpRhwEC4jf3lAnne0xG3RtP mUOoDOV5tSi+4SsbH2rc0Y+eZ4cL X-Google-Smtp-Source: ABdhPJxzWAzl8yEvAvZf3Oy9/dk++xOqJ8ei9rB5/xp7DggOU19kLhTVFUsXy6k6I1kLBeCnJuPLxw== X-Received: by 2002:a1c:720e:: with SMTP id n14mr18802426wmc.144.1595797708562; Sun, 26 Jul 2020 14:08:28 -0700 (PDT) Received: from scaer.home ([2a01:cb19:8b51:cb00:5d11:901d:4752:98c5]) by smtp.gmail.com with ESMTPSA id r11sm14870318wmh.1.2020.07.26.14.08.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Jul 2020 14:08:27 -0700 (PDT) From: "Yann E. MORIN" To: buildroot@buildroot.org Date: Sun, 26 Jul 2020 23:08:23 +0200 Message-Id: <20200726210823.20922-1-yann.morin.1998@free.fr> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Subject: [Buildroot] [PATCH] package/grpc: needs host gcc >= 4.9 X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Yann E. MORIN" , Adam Duskett Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" On some versions of gcc 4.8, like the one packaged in Ubuntu 14.04 (in extended support until 2022-04). Researching the cause for the bug was non-conclusive, except for: https://github.com/grpc/grpc/issues/19265 which ends with the less than informative "I've settled it." The trails leads to https://github.com/oudalab/co-incidents/issues/29, which leads to https://github.com/protocolbuffers/protobuf/issues/5353. Although the reporter provided a very good initial investigation, with bisection of grpc *and* protobuf, the report has just lingered untouched for almost two years now. One of the remaining commits in the protobuf bisect is this giant hairball: https://github.com/protocolbuffers/protobuf/commit/0400cca3236de1ca Integrated internal changes from Google 282 changed files with 15,223 additions and 14,041 deletions. No surprise the reporter of protobuf!5353 got very frustrated to find such a monster commit to investigate... :-( Another lead brings us similar reports, too: https://github.com/grpc/grpc/issues/22781 which concludes that "I've already fixed this issue. Can you try it on 1.29.1?" But we're already usign 1.30.2, and we still have the issue (so maybe it's a different one...) So, because the issue manifests itself only on an ancient system, Ubuntu 14.04, with a now ancient gcc 4.8, we just make grpc depend on a host gcc >= 4.9. Signed-off-by: Yann E. MORIN Cc: Adam Duskett --- package/collectd/Config.in | 1 + package/grpc/Config.in | 6 ++++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/package/collectd/Config.in b/package/collectd/Config.in index 188be3c0fb..77f088e76d 100644 --- a/package/collectd/Config.in +++ b/package/collectd/Config.in @@ -565,6 +565,7 @@ config BR2_PACKAGE_COLLECTD_GRAPHITE config BR2_PACKAGE_COLLECTD_GRPC bool "grpc" + depends on BR2_HOST_GCC_AT_LEAST_4_9 # grpc depends on BR2_TOOLCHAIN_HAS_SYNC_4 || BR2_TOOLCHAIN_HAS_ATOMIC # grpc depends on BR2_INSTALL_LIBSTDCPP # grpc -> protobuf depends on BR2_PACKAGE_PROTOBUF_ARCH_SUPPORTS # grpc -> protobuf diff --git a/package/grpc/Config.in b/package/grpc/Config.in index 45299888ea..8257f7c8a5 100644 --- a/package/grpc/Config.in +++ b/package/grpc/Config.in @@ -1,5 +1,6 @@ config BR2_PACKAGE_GRPC bool "grpc" + depends on BR2_HOST_GCC_AT_LEAST_4_9 # host-grpc fails to build on some gcc-4.8 versions depends on BR2_INSTALL_LIBSTDCPP depends on BR2_TOOLCHAIN_HAS_THREADS # protobuf depends on BR2_PACKAGE_PROTOBUF_ARCH_SUPPORTS # protobuf @@ -17,8 +18,9 @@ config BR2_PACKAGE_GRPC http://github.com/grpc/grpc -comment "grpc needs a toolchain w/ C++, threads, dynamic library, gcc >= 4.8" +comment "grpc needs a toolchain w/ C++, threads, dynamic library, gcc >= 4.8, host gcc >= 4.9" depends on BR2_TOOLCHAIN_HAS_SYNC_4 || BR2_TOOLCHAIN_HAS_ATOMIC depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS \ - || BR2_STATIC_LIBS || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 + || BR2_STATIC_LIBS || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 \ + || !BR2_HOST_GCC_AT_LEAST_4_9 depends on BR2_PACKAGE_PROTOBUF_ARCH_SUPPORTS