From patchwork Mon Dec 18 12:14:26 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jerzy Grzegorek X-Patchwork-Id: 850023 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=busybox.net (client-ip=140.211.166.137; helo=fraxinus.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="RScU0dBc"; dkim-atps=neutral Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3z0g2Y1mqgz9s83 for ; Mon, 18 Dec 2017 23:14:44 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 20CD98717C; Mon, 18 Dec 2017 12:14:42 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Ln9LJ2_ypnio; Mon, 18 Dec 2017 12:14:40 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by fraxinus.osuosl.org (Postfix) with ESMTP id 8684A8686D; Mon, 18 Dec 2017 12:14:40 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 0DA3E1C2AB3 for ; Mon, 18 Dec 2017 12:14:39 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 09D632F284 for ; Mon, 18 Dec 2017 12:14:39 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gYP9sdjHU3fH for ; Mon, 18 Dec 2017 12:14:38 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-lf0-f67.google.com (mail-lf0-f67.google.com [209.85.215.67]) by silver.osuosl.org (Postfix) with ESMTPS id 8F6E12F257 for ; Mon, 18 Dec 2017 12:14:38 +0000 (UTC) Received: by mail-lf0-f67.google.com with SMTP id f13so17481008lff.12 for ; Mon, 18 Dec 2017 04:14:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=ihjLMx7+r18R2CFj28BeZ8iU/ksyuOM8pBa4sr93/h8=; b=RScU0dBcSVj18+mv1oxYyh5ucw6cituIPmMD4X4uuoMPkFMUt2RLqCaPVDtNqH2wPb 4NmaEGs+vK46KywlR4qs3DmDH2Q4Z2bqddfuoSg5mQdDGEKwc0OcsCWzDVwB2BM62Sv0 N/M6MskBf1C9E1dKAj1rSfj1SiCydUS1oWSZLKeUfot8nTfnFBDEdxey9v1/KffHJUWr pLt5PGsdPzMkZ+cfjXVz6ywVtXoKkzjZLE7XZhXJXVCy/px3mSNX0nOwzdTwHjVI77D8 R5JO3G0L04v9JUaVYWAYFXh/+HjkgAmuH5s1AXEcd/V/zkdpuFToU1ugn852t0AiXhHH jkNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=ihjLMx7+r18R2CFj28BeZ8iU/ksyuOM8pBa4sr93/h8=; b=c79ZjU5KcqbMqUK3BhcMC2XGG8pphIvzNJla+eqz//VhXbxxxst4KgNyJsQi+aWBVD fgyXsqMZvVWf9MlUQHI/7ONiVIb4xcq4o9z+1QUFs2M0NpDMOxv2DR9iWG/72XqsABaS lcuATYOT0yxmJFcZ6iw4OsG4fZcZawfN3XngYsp/6Aqz4gKi/kgfsIEd1PfR5jQ4tVvA Kvqix89SG3gxIgbUn78fOysHn6my8qfugrN8mXhYolsXO7iBKjWeL4rYfEzcFl2+5uTi 6VwrUcxCduaQSu0pXCn1pmAe+wiJpb78zRTG2Dmo5ETKsSquPziyQSVvLqxEuz07bqDQ xxbw== X-Gm-Message-State: AKGB3mLKyKWjwKcDV0aVCPSbOkAWDHhUm5jOenBg/jrzhmCLU0wr/jFe SnFbwtO9ypLJb074iIR8a3y/ew== X-Google-Smtp-Source: ACJfBovTNSthca+noCuiRaokd2BRj6DN7Y0LbsrHZvg03ruLyrZTDrjKm+U4SmEsa1+mLqcawqLbYg== X-Received: by 10.25.16.105 with SMTP id f102mr1973088lfi.133.1513599276655; Mon, 18 Dec 2017 04:14:36 -0800 (PST) Received: from localhost.localdomain (93-181-142-99.internetia.net.pl. [93.181.142.99]) by smtp.gmail.com with ESMTPSA id q142sm2712600lfe.94.2017.12.18.04.14.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 18 Dec 2017 04:14:36 -0800 (PST) From: Jerzy Grzegorek To: buildroot@buildroot.org Date: Mon, 18 Dec 2017 13:14:26 +0100 Message-Id: <1513599266-6954-1-git-send-email-jerzy.m.grzegorek@gmail.com> X-Mailer: git-send-email 1.9.1 Subject: [Buildroot] [PATCH 1/1] utils/checkpackagelib: add function to check of the default package source variable X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.24 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jerzy Grzegorek MIME-Version: 1.0 Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" Signed-off-by: Jerzy Grzegorek --- utils/checkpackagelib/lib_mk.py | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/utils/checkpackagelib/lib_mk.py b/utils/checkpackagelib/lib_mk.py index 817e809..5ae565c 100644 --- a/utils/checkpackagelib/lib_mk.py +++ b/utils/checkpackagelib/lib_mk.py @@ -99,6 +99,25 @@ class PackageHeader(_CheckFunction): text] +class RemoveDefaultPackageSourceVariable(_CheckFunction): + PACKAGE_NAME = re.compile("/([^/]+)\.mk") + + def before(self): + package = self.PACKAGE_NAME.search(self.filename).group(1) + package_upper = package.replace("-", "_").upper() + self.package = package + self.package_upper = package_upper + self.FIND_SOURCE = re.compile( + "^{}_SOURCE\s*=\s*{}-\$\({}_VERSION\)\.tar\.gz" + .format(package_upper, package, package_upper)) + + def check_line(self, lineno, text): + if self.FIND_SOURCE.search(text): + return ["{}:{}: remove default value of _SOURCE variable ({}#writing-rules-mk)" + .format(self.filename, lineno, self.url_to_manual), + text] + + class SpaceBeforeBackslash(_CheckFunction): TAB_OR_MULTIPLE_SPACES_BEFORE_BACKSLASH = re.compile(r"^.*( |\t)\\$")