From patchwork Sun Jul 19 21:02:35 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vineet Gupta X-Patchwork-Id: 1331947 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=sourceware.org (client-ip=8.43.85.97; helo=sourceware.org; envelope-from=libc-alpha-bounces@sourceware.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=sourceware.org Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=epMPnFZX; dkim-atps=neutral Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4B8y4v66gqz9sRf for ; Mon, 20 Jul 2020 07:03:27 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2AABC3858D37; Sun, 19 Jul 2020 21:03:22 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2AABC3858D37 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1595192602; bh=QNkki0tXw2LohtklT8yUE1uIQKiOyGiJ5Cis86Wp+4o=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=epMPnFZXLJVblLOPOEewxTgiAGflsewfw9Ilrnfw8nEecDy+seKklhXqk7kC2X+b6 aLY3ZFOWQc1KESsNVMtU+H2Oq9MTApgSnSJWD2bEXhcCcoJJfEUU2UnUmCL0tAibUd JWbBpxsVNEDEUZq9rZVIFWPhivJDH+T7nCGT1vT0= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from smtprelay-out1.synopsys.com (smtprelay-out1.synopsys.com [149.117.73.133]) by sourceware.org (Postfix) with ESMTPS id 317E23858D35 for ; Sun, 19 Jul 2020 21:03:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 317E23858D35 Received: from mailhost.synopsys.com (sv2-mailhost2.synopsys.com [10.205.2.134]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by smtprelay-out1.synopsys.com (Postfix) with ESMTPS id A7B8D400BF; Sun, 19 Jul 2020 21:03:15 +0000 (UTC) Received: from vineetg-Latitude-7400.internal.synopsys.com (unknown [10.13.183.89]) by mailhost.synopsys.com (Postfix) with ESMTP id 64BB6A009C; Sun, 19 Jul 2020 21:02:49 +0000 (UTC) X-SNPS-Relay: synopsys.com To: libc-alpha@sourceware.org, Carlos O'Donell Subject: [PATCH] Fix tst-libc_dlvsym{, -static} on ARC: don't check _sys_{err, sig}list Date: Sun, 19 Jul 2020 14:02:35 -0700 Message-Id: <20200719210235.21767-1-vgupta@synopsys.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-Spam-Status: No, score=-13.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Vineet Gupta via Libc-alpha From: Vineet Gupta Reply-To: Vineet Gupta Cc: Vineet Gupta , linux-snps-arc@lists.infradead.org Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" These symbols were recently deprecated but the test still checks for them which fails for ARC. Tested with arc-linux-gnuhf -FAIL: elf/tst-libc_dlvsym +PASS: elf/tst-libc_dlvsym -FAIL: elf/tst-libc_dlvsym-static +PASS: elf/tst-libc_dlvsym-static | | $ cat elf/tst-libc_dlvsym-static.out | error: tst-libc_dlvsym.h:103: symbol _sys_errlist not found at any version | caveats: 1. This does reduce test-coverage for existing ports with older versions of glibc where these symbols are valid, but reckon it is not an issue since the symbol is being deprecated anyways 2. IMHO, despite the ABI freeze it should be fine for 2.32 too since it doesn't modify glibc ABI/API in any way, only a test-header is. --- elf/tst-libc_dlvsym.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/elf/tst-libc_dlvsym.h b/elf/tst-libc_dlvsym.h index 6b132dd7c3e4..7eda47207824 100644 --- a/elf/tst-libc_dlvsym.h +++ b/elf/tst-libc_dlvsym.h @@ -117,8 +117,6 @@ compare_vsyms (void) obtain an explicit handle for libc.so. */ void *libc_handle = xdlopen (LIBC_SO, RTLD_LAZY | RTLD_NOLOAD); - compare_vsyms_1 (libc_handle, "_sys_errlist"); - compare_vsyms_1 (libc_handle, "_sys_siglist"); compare_vsyms_1 (libc_handle, "quick_exit"); xdlclose (libc_handle);