From patchwork Sun Jul 19 21:02:35 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vineet Gupta X-Patchwork-Id: 1331946 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2001:8b0:10b:1231::1; helo=merlin.infradead.org; envelope-from=linux-snps-arc-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=synopsys.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=merlin.20170209 header.b=2qro8H8R; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=synopsys.com header.i=@synopsys.com header.a=rsa-sha256 header.s=mail header.b=XlPf0On3; dkim-atps=neutral Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:8b0:10b:1231::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4B8y4s4126z9sR4 for ; Mon, 20 Jul 2020 07:03:25 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=8kOm7IjhJwHUPAwwCMMbJr6wsJRINlZD4XjOMGzn05c=; b=2qro8H8ROkagNYZzCQflrdUVTH nNqgI1ganRgjl+i/W4ZUuWcWfxKroUU/qS41hYVAWqvo28gKTzN6cNETH1QsNTKI487yr48BEBeWp 8Btw8d6hGRphfAnpQIHqCSJobo3uaqEA5RTMED4ZJYp2PyhuEdUTxETBRYetcPvunCAIO/B4OIIFd DfSp01i2aarocoy6+6uc0gquDMLDbXCmMKgZbXBPy9Uy2etnIshE0By2eJZJKZY66z+WFqCQOI3bJ lB2GVlRQWPfqspaaINMjhVPJKkLCi9MUUys309Pg9rXOWGAq0tB5pYw2kwTowOUjGgCRt/HrVk7uP QzeG3eTg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jxGSw-0006yS-6j; Sun, 19 Jul 2020 21:03:22 +0000 Received: from smtprelay-out1.synopsys.com ([149.117.73.133]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jxGSu-0006y0-AN for linux-snps-arc@lists.infradead.org; Sun, 19 Jul 2020 21:03:21 +0000 Received: from mailhost.synopsys.com (sv2-mailhost2.synopsys.com [10.205.2.134]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by smtprelay-out1.synopsys.com (Postfix) with ESMTPS id A7B8D400BF; Sun, 19 Jul 2020 21:03:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=synopsys.com; s=mail; t=1595192596; bh=gKXVshNdqU++k7HaLnrv7KMSPHBjY4gNupti0GCp6B8=; h=From:To:Cc:Subject:Date:From; b=XlPf0On3cBOqk4XmFgOvBECvm6oXnWKMpE6kD7T+lnIs9C2YvYRscZjq9nbKuixNQ c2eqZUswXGswTQWNukvSjZ+EAhkZBsU+EHamTh9qXvck/0te8JaAiZWhJPOZxMuLHU Jwp85mBVCX9zH0+e/29jV3EFbzph0Nm75Dp3bpL/kX2C///CT90qlI4a5/CmO/eE5L AU+Ugq/krhxJoW4NpSeiZ7HbDfl45noHVzVW90hRgXM/YOw+Oz9z99FXsbnKn/8FeA 6UoEtKBGOgzlr1hkMtLKu5GNcjD2xW8Vc7TBVjm/ND8qiEnln/iMZQRuthWfAimXbz KJl6NgHvjERww== Received: from vineetg-Latitude-7400.internal.synopsys.com (unknown [10.13.183.89]) by mailhost.synopsys.com (Postfix) with ESMTP id 64BB6A009C; Sun, 19 Jul 2020 21:02:49 +0000 (UTC) X-SNPS-Relay: synopsys.com From: Vineet Gupta To: libc-alpha@sourceware.org, Carlos O'Donell Subject: [PATCH] Fix tst-libc_dlvsym{, -static} on ARC: don't check _sys_{err, sig}list Date: Sun, 19 Jul 2020 14:02:35 -0700 Message-Id: <20200719210235.21767-1-vgupta@synopsys.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200719_170320_532645_646A0880 X-CRM114-Status: UNSURE ( 8.40 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 RCVD_IN_MSPIKE_H4 RBL: Very Good reputation (+4) [149.117.73.133 listed in wl.mailspike.net] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders X-BeenThere: linux-snps-arc@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on Synopsys ARC Processors List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Vineet Gupta , linux-snps-arc@lists.infradead.org Sender: "linux-snps-arc" Errors-To: linux-snps-arc-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org These symbols were recently deprecated but the test still checks for them which fails for ARC. Tested with arc-linux-gnuhf -FAIL: elf/tst-libc_dlvsym +PASS: elf/tst-libc_dlvsym -FAIL: elf/tst-libc_dlvsym-static +PASS: elf/tst-libc_dlvsym-static | | $ cat elf/tst-libc_dlvsym-static.out | error: tst-libc_dlvsym.h:103: symbol _sys_errlist not found at any version | caveats: 1. This does reduce test-coverage for existing ports with older versions of glibc where these symbols are valid, but reckon it is not an issue since the symbol is being deprecated anyways 2. IMHO, despite the ABI freeze it should be fine for 2.32 too since it doesn't modify glibc ABI/API in any way, only a test-header is. --- elf/tst-libc_dlvsym.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/elf/tst-libc_dlvsym.h b/elf/tst-libc_dlvsym.h index 6b132dd7c3e4..7eda47207824 100644 --- a/elf/tst-libc_dlvsym.h +++ b/elf/tst-libc_dlvsym.h @@ -117,8 +117,6 @@ compare_vsyms (void) obtain an explicit handle for libc.so. */ void *libc_handle = xdlopen (LIBC_SO, RTLD_LAZY | RTLD_NOLOAD); - compare_vsyms_1 (libc_handle, "_sys_errlist"); - compare_vsyms_1 (libc_handle, "_sys_siglist"); compare_vsyms_1 (libc_handle, "quick_exit"); xdlclose (libc_handle);