From patchwork Mon Jun 29 09:47:24 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pragnesh Patel X-Patchwork-Id: 1318801 X-Patchwork-Delegate: van.freenix@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=sifive.com header.i=@sifive.com header.a=rsa-sha256 header.s=selector1 header.b=jols8U3u; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 49wN3p1YdQz9sQx for ; Mon, 29 Jun 2020 19:48:54 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 0E56681FB1; Mon, 29 Jun 2020 11:48:27 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=sifive.com header.i=@sifive.com header.b="jols8U3u"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id C37CB81FAB; Mon, 29 Jun 2020 11:48:15 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FORGED_SPF_HELO,MSGID_FROM_MTA_HEADER, SPF_HELO_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on20617.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe5b::617]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id BD5A881F75 for ; Mon, 29 Jun 2020 11:48:12 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=pragnesh.patel@sifive.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hmHmgktNTqTQURWpSDGcwF2n3IggpX1eIzkLbdG4PIbnKbIXMOBhvGRrsqDY3FR4WzO7Ua3BH/4mfOVs+kCpP6wGVusm5ySZu9ZcRkLHThFaiCr9yL0Putd7+Iv99RsULO0TXBMAZQnx8DDIFUb16INRwyynSdjgeRR6S6u7mbxOsNQijhKxNDA+iR1xrvJgshgA3efOHFYWrQyFD0UWNxaBqWX1lXprmB/CBNIJr3Q6v6HtDAbnidQKuFJcPcOZjaP9IuwxWrWRgvU+Sme2DcSw/aX5r40EaEaSZSWCxh5diU9zx3rzjLTaCb/7o84eHjq4oYHVuvg63fShs0iydw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FIzeiJyyM+jVaXA8HcXstcohPr6gb7ElRm0wNU5eXdI=; b=c5rSXT3fSDQi+VwaIO/W1I5feWEARL4Lp30MRbi/12PwAtlysVFbFQBFCoiqQtxYNz1mWh/ISAaZAn1VrNrWUiRQGU6P17HTkEw1WdOMboe6zUdezsOuUlLvSYz/2EpNQhhZB5+vip+KOnw5MMNDCXA1jCWaeBaUd5BVj+xpByMTnTDHalAc9HTgBQxN9rrmZs9MmlylCCUl3sSKIOIX8OhqNjXcbcY9f/cUFjeC0nJbeUcwNEC4P+jSTC73JIiQG3d2+nn7Hc3htMtc+m08Xe7qa+2FzuYalHT9Z2W3jOJBOabAWgJDrH7E+7eyIJ39JLGsDsim1lM0sZkKpIgAUw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=sifive.com; dmarc=pass action=none header.from=sifive.com; dkim=pass header.d=sifive.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FIzeiJyyM+jVaXA8HcXstcohPr6gb7ElRm0wNU5eXdI=; b=jols8U3udT+jJkNEi35K9Im5mHZYO5o+FP14f1A6ZT0hQPuE/+/cMX1PYI6nOsLhvQGf4Nr61A7roI/yc/ws2uL4n6GzG4aEC8e3sLEnhsZwcq3RiPvUkEmQ9+5XkUrFifgcqSi8RtQz25hhdZ27fY4Ly7u9wmFlETmNeE/wO9k= Authentication-Results: nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=none action=none header.from=sifive.com; Received: from MN2PR13MB2797.namprd13.prod.outlook.com (2603:10b6:208:f2::30) by MN2PR13MB2944.namprd13.prod.outlook.com (2603:10b6:208:13f::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3153.13; Mon, 29 Jun 2020 09:48:02 +0000 Received: from MN2PR13MB2797.namprd13.prod.outlook.com ([fe80::7d39:44e8:5e4f:b8a2]) by MN2PR13MB2797.namprd13.prod.outlook.com ([fe80::7d39:44e8:5e4f:b8a2%6]) with mapi id 15.20.3153.018; Mon, 29 Jun 2020 09:48:02 +0000 From: Pragnesh Patel To: peng.fan@nxp.com Cc: bmeng.cn@gmail.com, paul.walmsley@sifive.com, jagan@amarulasolutions.com, sagar.kadam@sifive.com, u-boot@lists.denx.de, Pragnesh Patel Subject: [PATCH 1/6] mmc: mmc_spi: correct the while condition Date: Mon, 29 Jun 2020 15:17:24 +0530 Message-Id: <20200629094730.10051-2-pragnesh.patel@sifive.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200629094730.10051-1-pragnesh.patel@sifive.com> References: <20200629094730.10051-1-pragnesh.patel@sifive.com> X-ClientProxiedBy: LO2P265CA0437.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:e::17) To MN2PR13MB2797.namprd13.prod.outlook.com (2603:10b6:208:f2::30) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from sachinj2-OptiPlex-7010.open-silicon.com (114.143.65.226) by LO2P265CA0437.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:e::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3131.20 via Frontend Transport; Mon, 29 Jun 2020 09:47:59 +0000 X-Mailer: git-send-email 2.17.1 X-Originating-IP: [114.143.65.226] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 846fc52e-02c4-492e-adba-08d81c118367 X-MS-TrafficTypeDiagnostic: MN2PR13MB2944: X-LD-Processed: 22f88e9d-ae0d-4ed9-b984-cdc9be1529f1,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:576; X-Forefront-PRVS: 044968D9E1 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Uuu+4gTfKw/bdPMPsC+4rjyg4WumzVTqzS1aL6aCRkmUHL/uHmMdSKeoqB0/a2saCc6H76dhibgkKX/OptYBPEXUVByvWLMy+8ZeiH3Pz1Ruzu/yhQZkLnCW3rvmwCnYCVexVRHD/lFxIDz/ZT9HG7lOD1eUNuVmlkNBoJ/QbEKhAONUNnLif6nydCAV4t+E5c49FeN7o1IgJixBNY4/vcSiClfNnB463a0uUELUxe+VgiwPdl+Z4/gvY8qKYA/ELfkSPJBETqS1ug8Y4YtOlJMIcPubJIa8t42KzN7YkNRzKi1KNRcd8EE0vSGS+qBajkH2hVi6JZb1a6szmZvfsg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR13MB2797.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(366004)(376002)(346002)(136003)(396003)(39840400004)(8676002)(478600001)(6916009)(66556008)(66476007)(66946007)(83380400001)(107886003)(956004)(6506007)(8936002)(44832011)(52116002)(2616005)(6486002)(6512007)(186003)(16526019)(1006002)(4326008)(6666004)(2906002)(26005)(1076003)(316002)(86362001)(5660300002)(4744005)(36756003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: 6IeKfWIh1rMAwkTVvw/EgbRlqkIUCjZ3TfetMqWBzVjXSyD3XkhLcdDnPcdyHr7KbdiC0OS8108W+BYASzjvSlSl0Oa6PvXe8GXRyVk+XHZT+4ZX19z9w//Bz6baK/vbx7ekWmZgXUUSIjwqL+hJR2hoPYohfg3gWpobzu1E2ye02gqgZUGR6xdJPabJqw13k5y0obnqCgUArOCBYmep9NQSjI++u3aq/a9RyxkY8ta+yjSKYqweGdAZbY8P+j/xKm+G6l0qVumJpkC3R06g/Hl2qyKVvJ6al8ZlWn+ndgYXgW99HZCykvGCt72NcqHVvl26qtI4PKl5uGqZK+ZEEGnADzrbzSzIqifHlkBrIklsnKDs2qay1W22wXO1rxhHkgYrA+11a36cxeUGPSCnuIaFhmFF5JtGUeB6p5wwQY0FAJpOUhjVqM5Oq1fCf0XP5YfItydEPqW3MbSnLD+pTxidF6UC5rlEOXqFwc028jh0xIk5Ph8hbPcdn/+TdTlr X-OriginatorOrg: sifive.com X-MS-Exchange-CrossTenant-Network-Message-Id: 846fc52e-02c4-492e-adba-08d81c118367 X-MS-Exchange-CrossTenant-AuthSource: MN2PR13MB2797.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jun 2020 09:48:02.0895 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 22f88e9d-ae0d-4ed9-b984-cdc9be1529f1 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: KHKZareujiyajfgo+Y6fMH+3JfypGCNSOFZMMmAdemyDYsl4iNxUcJmJJoOlbPSDvd42CQoxkm9QXq8AuVQubBGq2yu3gV/Inhlznd2taLM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR13MB2944 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.30rc1 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.2 at phobos.denx.de X-Virus-Status: Clean When variable i will become 0, while(i--) loop breaks but variable i will again decrement to -1 because of i-- and that's why below condition "if (!i && (r != resp_match_value)" will never execute, So doing "i--" inside of while() loop solves this problem. Signed-off-by: Pragnesh Patel Reviewed-by: Bin Meng Tested-by: Bin Meng --- drivers/mmc/mmc_spi.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/mmc_spi.c b/drivers/mmc/mmc_spi.c index e76ab54838..86cc932151 100644 --- a/drivers/mmc/mmc_spi.c +++ b/drivers/mmc/mmc_spi.c @@ -105,12 +105,14 @@ static int mmc_spi_sendcmd(struct udevice *dev, if (resp_match) { r = ~resp_match_value; i = CMD_TIMEOUT; - while (i--) { + while (i) { ret = dm_spi_xfer(dev, 1 * 8, NULL, &r, 0); if (ret) return ret; debug(" resp%d=0x%x", rpos, r); rpos++; + i--; + if (r == resp_match_value) break; } From patchwork Mon Jun 29 09:47:25 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pragnesh Patel X-Patchwork-Id: 1318804 X-Patchwork-Delegate: van.freenix@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=sifive.com header.i=@sifive.com header.a=rsa-sha256 header.s=selector1 header.b=hX9Jlhkx; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 49wN535N1sz9sRk for ; Mon, 29 Jun 2020 19:49:59 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id A7A6581FD0; Mon, 29 Jun 2020 11:48:51 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=sifive.com header.i=@sifive.com header.b="hX9Jlhkx"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 53C6181FAF; Mon, 29 Jun 2020 11:48:22 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FORGED_SPF_HELO,MSGID_FROM_MTA_HEADER, SPF_HELO_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on20617.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe5b::617]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 4B08681F77 for ; Mon, 29 Jun 2020 11:48:13 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=pragnesh.patel@sifive.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ogMRScMeHjrHXssKSmB2AXR9SC6DydtGnRvfObbdS6zZWc9+ZYe/haLishDPj5Dc6N9ZB6sQuJDHMTBS20NJ6YAjWpa86Ip2vRPy9Ztz00yAj/ebND2GV0Ua51UmAN2PG8ka9Lr3/CmeWu/HwtXcTDgIXU/Cbi9Umt/4iET/VzeFe7aceEcxb3KoehgZ0o+XLa/8waL6odM9D46IczPkqxdOporcgmHfvYZibad+XyQr76ukj/7xENaIFe0qjNOhavg1s+J96fUF9RvqEMhi/Z5ti1VTfhIbwnFwfQhr4C/4F3O4GDceL87Cf4c5A45AYD5fCqPZKQNuromv+tNlzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eImBm85uIsQKxId8MKMl5+a+lMbdhlYkWeDPJ9GvVkU=; b=IQaEBLc3w+ISrkGrep/YQ/avt9pxzY4NFKCpR/Ez5Lu8ZYXFcwHQ2kOGGYF8KmZQgY6JGer/Du31BEhuaUA3+B29r2nO1LrORFGf68dp+zCs1+FdPcdINAbZA8XUmj6ROO4UBTL+5gDqM1j37+r4vhvifjpo6wAVfPPXkM25rOJ7t7V5jZ2VMOFr7oSHejAOs8gEz+5IWwCLowxUUfLGAsbnUMUd7CJuEDVZNCYW32V30hK7rpzDfVaE0n3tNT95DWk3xYg/CEm6ze493MMwSWsRgx3qfu39tE0/ETLa7IDzKwqLCbZ9rc70DWhUdxD+Vy8kR8R4C2VnB/tth3AHUQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=sifive.com; dmarc=pass action=none header.from=sifive.com; dkim=pass header.d=sifive.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eImBm85uIsQKxId8MKMl5+a+lMbdhlYkWeDPJ9GvVkU=; b=hX9JlhkxRz1iYtN4M9mXecdhd2ui6QnOQmEPj9OKmc77UcYid4q3X401vaCdF6N2lOL7dgRibcBrQOEFodtUuJp5xuECcC1Tis+ViXim3pPLR+KS7t+gD1SDIwiwyCtB0TD+QyS7t+fs4FaGDAA/sgAKQ+q6xiqWLAHAhF2bxTM= Authentication-Results: nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=none action=none header.from=sifive.com; Received: from MN2PR13MB2797.namprd13.prod.outlook.com (2603:10b6:208:f2::30) by MN2PR13MB2944.namprd13.prod.outlook.com (2603:10b6:208:13f::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3153.13; Mon, 29 Jun 2020 09:48:05 +0000 Received: from MN2PR13MB2797.namprd13.prod.outlook.com ([fe80::7d39:44e8:5e4f:b8a2]) by MN2PR13MB2797.namprd13.prod.outlook.com ([fe80::7d39:44e8:5e4f:b8a2%6]) with mapi id 15.20.3153.018; Mon, 29 Jun 2020 09:48:04 +0000 From: Pragnesh Patel To: peng.fan@nxp.com Cc: bmeng.cn@gmail.com, paul.walmsley@sifive.com, jagan@amarulasolutions.com, sagar.kadam@sifive.com, u-boot@lists.denx.de, Pragnesh Patel Subject: [PATCH 2/6] mmc: mmc_spi: generate R1 response for different mmc SPI commands Date: Mon, 29 Jun 2020 15:17:25 +0530 Message-Id: <20200629094730.10051-3-pragnesh.patel@sifive.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200629094730.10051-1-pragnesh.patel@sifive.com> References: <20200629094730.10051-1-pragnesh.patel@sifive.com> X-ClientProxiedBy: LO2P265CA0437.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:e::17) To MN2PR13MB2797.namprd13.prod.outlook.com (2603:10b6:208:f2::30) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from sachinj2-OptiPlex-7010.open-silicon.com (114.143.65.226) by LO2P265CA0437.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:e::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3131.20 via Frontend Transport; Mon, 29 Jun 2020 09:48:02 +0000 X-Mailer: git-send-email 2.17.1 X-Originating-IP: [114.143.65.226] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fa6a65df-e1a1-480d-9a2f-08d81c11850a X-MS-TrafficTypeDiagnostic: MN2PR13MB2944: X-LD-Processed: 22f88e9d-ae0d-4ed9-b984-cdc9be1529f1,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3631; X-Forefront-PRVS: 044968D9E1 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RR7iYRV2W1nasxs/hEbcNftOi62FAZvgB0AzQU4OOEjxKLCV37E1GH3ZvghXmDHzo1vCihyH6mVQSB/HBAPH6lHgn+OfohF5+ZwjfR+uzRHnqXVguVv1n3Odo+n5cmvOlgNr1K5jSTbZYxzZWEsJxdbH7nJywUaNn78fxXpiNX1s7q5WzQLHnER74dH3wjLVi6aB/yfglOc8883PHE2DmSsXyFr48LiBOOrOtYuJM2hW1+uZ2nrRfeO3+rHG+fxKqfSHLb3DQuq591dN/9mpHP2H1RaYEadYUDPmbV/FOjNFlb+GfY/K0Tqw8znmEQWqkbpSaD61m+xmZVYH1XVq8Q== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR13MB2797.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(366004)(376002)(346002)(136003)(396003)(39840400004)(8676002)(478600001)(6916009)(66556008)(66476007)(66946007)(83380400001)(107886003)(956004)(6506007)(8936002)(44832011)(52116002)(2616005)(6486002)(6512007)(186003)(16526019)(1006002)(4326008)(6666004)(2906002)(26005)(1076003)(316002)(86362001)(5660300002)(4744005)(36756003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: zmO6G+tN4cpbvIqtoPdNyc1xD5HplTok/Se2JqtZc5BqN8LqEv3mZBB7aBVW++9IZ0OD/QDApK4aU68gOPVOy5Chz+Ccgyu8Uw2Xl6WD+/hDcHPPUhM7gNtdHjLWxTsJl+weyFGtVYevYoUhvGtJ0+6Ns8IDLjTSXbIpR24W7n9znMCbR3Xr6kPi2s3MKxHceBYYQLqC7GdVg/fBM9jzHBtiNQKV9Ik5TQ6UzTMOHbr2yBDRpOs774V7RioohgvXnHY7W0Pg6LBUKr0qV0rmvXdGc+jRSqz2DBge/p4oF+Cnr+vkYnVZ+Ve3fBQRCQVCGFlYGYSkzil93iIThnfFJxKwykZFO7K+dwwB08oNQ7FE/MhK6nIxgfPD6qc0fDuZezmF0Y46t8Ft0YqUdsYFli51vqTkUdJAspe5dOL4CwlJM8kh4FY2jLgtNRtL6rlyz7aCxGco7m7Kh5SiMzSjat9ZJfVdBn7+scYlQtWvG3AKHrrE1credCRI4qjz4GoC X-OriginatorOrg: sifive.com X-MS-Exchange-CrossTenant-Network-Message-Id: fa6a65df-e1a1-480d-9a2f-08d81c11850a X-MS-Exchange-CrossTenant-AuthSource: MN2PR13MB2797.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jun 2020 09:48:04.8379 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 22f88e9d-ae0d-4ed9-b984-cdc9be1529f1 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: cd541CztyBfl4FowHwWK8rNagpEzjDiUP/Cud9o0mLPEDyqlCnFIx/lmJZEaqeac8VOdG3YsUopOyUy1MsS/DD5zDLvRme8trRLzEdkMp0c= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR13MB2944 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.30rc1 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.2 at phobos.denx.de X-Virus-Status: Clean R1 response is 1 byte long for mmc SPI commands as per the updated physical layer specification version 7.10. So correct the resp and resp_size for existing commands Signed-off-by: Pragnesh Patel Reviewed-by: Bin Meng Tested-by: Bin Meng --- drivers/mmc/mmc_spi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/mmc/mmc_spi.c b/drivers/mmc/mmc_spi.c index 86cc932151..ddfebb6ed6 100644 --- a/drivers/mmc/mmc_spi.c +++ b/drivers/mmc/mmc_spi.c @@ -305,6 +305,8 @@ static int dm_mmc_spi_request(struct udevice *dev, struct mmc_cmd *cmd, case MMC_CMD_READ_MULTIPLE_BLOCK: case MMC_CMD_WRITE_SINGLE_BLOCK: case MMC_CMD_WRITE_MULTIPLE_BLOCK: + resp = &resp8; + resp_size = sizeof(resp8); break; default: resp = &resp8; From patchwork Mon Jun 29 09:47:26 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pragnesh Patel X-Patchwork-Id: 1318803 X-Patchwork-Delegate: van.freenix@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=sifive.com header.i=@sifive.com header.a=rsa-sha256 header.s=selector1 header.b=C/LusNHy; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 49wN4f3Zkbz9sQx for ; Mon, 29 Jun 2020 19:49:38 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 0CD6C81FC7; Mon, 29 Jun 2020 11:48:50 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=sifive.com header.i=@sifive.com header.b="C/LusNHy"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 884DD81FAD; Mon, 29 Jun 2020 11:48:23 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FORGED_SPF_HELO,MSGID_FROM_MTA_HEADER, SPF_HELO_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on20617.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe5b::617]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D307B81F97 for ; Mon, 29 Jun 2020 11:48:13 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=pragnesh.patel@sifive.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FPVpnGATIe1JoK6CAW0FwIqn/g14uSayUtpne3TuilWcpYtZi40WEMF3tMq1VpPa7R4lZCDPqC0gOuGktM1v5qjVemlEdlkXHTnhfcbPAbaqTOs5TL4hIRKt0VCpC8eipIAv1bFs57z4WkuiHJZl5GNroBRrZS0n/84qVdxAQoX/OFZXsJVN8drQDuN2VbwUGD0arpWFhxYGM7cVzJdLOV4kbMb9Zl2JQL+nWMdN3t0NjI8up/DaJkX5hD7i3d0ZXgVkAjZ1A8fthAen2J1kpLNk+jvyrcPjYMq+njicTmVQnTe7HTU5pcWXVsk2dhVZhrMXm1j/dsnvUBtLKWLSew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3Fg1RZhzA4y2ahvQC3Ofj8/wA/ZkoFoL5MAMebqMt/0=; b=U/LkGKMmuj7xjgtA0V0WZNp41iITaZVlv9QkozTbHWCka4bRskah6t/XITs0+QL8cD3RNmBNJT+mYhMg8tYkmDOtWCmlrmNdl6OndEQKnbQT4+CgBNypHn2sfq4P9U2tVp/4kvVeBJmP9CJCHZHOnJh8zLyqsCP/Xfzl3STiD/rm+qwPdPCmd6fm/UtxXeqX/hB/IRpS7J5yprfYjgP5DvMLNub0377JSWDCDX7+bR2K6Ca0rDQMczHtLUw7W7qjQyItAjGQO0BA4BKMGWK5Z/REEzZ5fYlXafFvcMSScpIScqmgaInwqAxXYIvOQ5IRJm0BxkxTEbU9Xpnwrrsz9w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=sifive.com; dmarc=pass action=none header.from=sifive.com; dkim=pass header.d=sifive.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3Fg1RZhzA4y2ahvQC3Ofj8/wA/ZkoFoL5MAMebqMt/0=; b=C/LusNHyE2mrI6DGT9labr2VrB4W1KcFEKHzDdONN+cHeXb5JGAGjRwHdjKfsXOq3tq3ViojAmRUGhKoFG8KbRh0v6U76XEFJPbTC+lM0c+gFLUDnvJJ2sjDGnByC4BLQQMt+2P97jzqpXKf1o2ZgbTr7t7uxn7IwizOj9oZHp4= Authentication-Results: nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=none action=none header.from=sifive.com; Received: from MN2PR13MB2797.namprd13.prod.outlook.com (2603:10b6:208:f2::30) by MN2PR13MB2944.namprd13.prod.outlook.com (2603:10b6:208:13f::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3153.13; Mon, 29 Jun 2020 09:48:07 +0000 Received: from MN2PR13MB2797.namprd13.prod.outlook.com ([fe80::7d39:44e8:5e4f:b8a2]) by MN2PR13MB2797.namprd13.prod.outlook.com ([fe80::7d39:44e8:5e4f:b8a2%6]) with mapi id 15.20.3153.018; Mon, 29 Jun 2020 09:48:07 +0000 From: Pragnesh Patel To: peng.fan@nxp.com Cc: bmeng.cn@gmail.com, paul.walmsley@sifive.com, jagan@amarulasolutions.com, sagar.kadam@sifive.com, u-boot@lists.denx.de, Pragnesh Patel Subject: [PATCH 3/6] mmc: read ssr for SD spi Date: Mon, 29 Jun 2020 15:17:26 +0530 Message-Id: <20200629094730.10051-4-pragnesh.patel@sifive.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200629094730.10051-1-pragnesh.patel@sifive.com> References: <20200629094730.10051-1-pragnesh.patel@sifive.com> X-ClientProxiedBy: LO2P265CA0437.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:e::17) To MN2PR13MB2797.namprd13.prod.outlook.com (2603:10b6:208:f2::30) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from sachinj2-OptiPlex-7010.open-silicon.com (114.143.65.226) by LO2P265CA0437.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:e::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3131.20 via Frontend Transport; Mon, 29 Jun 2020 09:48:05 +0000 X-Mailer: git-send-email 2.17.1 X-Originating-IP: [114.143.65.226] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 08a05f76-6f12-42b5-67ee-08d81c1186b2 X-MS-TrafficTypeDiagnostic: MN2PR13MB2944: X-LD-Processed: 22f88e9d-ae0d-4ed9-b984-cdc9be1529f1,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1417; X-Forefront-PRVS: 044968D9E1 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: k/LqJ2mYA7MPO6SjT/aInIFs3kG+knRt5MWudXZEjap+Ly/p5UewHlepKM6GEnFzqk4O8wgWjpwflZ4XfE+PrBnwRRtCKOWof7MJXSoH88B0qWIDwVa+KY0oG3DxtvB+5q5jrx0z5FbSipnsbT0AvRCNv3RUyzNGYW4jBdvKV13+/G/G4Hi5l7+tkuNGR+tanpSzil7yxxrKfi3SldwRnscS6RN7evNWJj7MQ24OeqXqDT2zNn2Qo29HoJO4QKqNicVFwBaNSFE1CdCnfD00KXDDOxnUyGTnYQi5nOqSpEZL0CSGEGNB+RiZfEUm5ZSsNNVU71hL16LgJnYzE9SCTQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR13MB2797.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(366004)(376002)(346002)(136003)(396003)(39840400004)(8676002)(478600001)(6916009)(66556008)(66476007)(66946007)(83380400001)(107886003)(956004)(6506007)(8936002)(44832011)(52116002)(2616005)(6486002)(6512007)(186003)(16526019)(1006002)(4326008)(6666004)(2906002)(26005)(1076003)(316002)(86362001)(5660300002)(36756003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: 2BeO/l4AeTrthjx7r3DGhXDsupjUdRqaKX6IaQ6FIabxEKzmG84rbE1GEQ3QxwN45ONGOHEqcgJCtkK6jhJPvf+27wHeVYd8EakJpdYbkzBe1YheInDu94hu4fbkMlGuu7ZCWIM06lyzBQdbsqp5sktkYpV3/+1AzUf39b2CA86NvB6yJZbSYrn3sdhZ3Hm9ZMtgN/r/BVNfAAPbLYVGyIyi80ksV3YdV1FD9nJy3FEUCQjE4DaoL2UtOODApmf8BXySrMJFLCQqpo6VFKF2ShoTNLcV88WPnCCr1TalimRAWazZHDN0mgqLGxq7SkhXMl9PqLr5Vp42Nne7b6uNhW0yJRteSSnqdTP+rEydWoYdSYiCbG03H35+7uZyHGjiBrfsA6/NFFmq1MPKbKhTP+EvWoRFBKoYy0FkLFgybzSHvphVJTtKLV1fySEhN5qChzcfBRURedZHSXCqrEn4e1OXR8NEczCTty/uL0bu4Asq4jcJiTf8mV7EEqXX6dIg X-OriginatorOrg: sifive.com X-MS-Exchange-CrossTenant-Network-Message-Id: 08a05f76-6f12-42b5-67ee-08d81c1186b2 X-MS-Exchange-CrossTenant-AuthSource: MN2PR13MB2797.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jun 2020 09:48:07.6613 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 22f88e9d-ae0d-4ed9-b984-cdc9be1529f1 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: RqYzR62Bi5G+DdAB1xTxrNEsjQAM2ATWvtqzLCu95zC484bJLhIdZijowhb72qYYFHEAGZx4Xw0jSM3VmKE/hUkDhGx5pI682Sw5mK1fpsg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR13MB2944 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.30rc1 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.2 at phobos.denx.de X-Virus-Status: Clean The content of ssr is useful only for erase operations. This saves erase time. Signed-off-by: Pragnesh Patel Reviewed-by: Bin Meng Tested-by: Bin Meng --- drivers/mmc/mmc.c | 5 +++++ drivers/mmc/mmc_spi.c | 1 + 2 files changed, 6 insertions(+) diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c index 620bb93064..6b193d6d70 100644 --- a/drivers/mmc/mmc.c +++ b/drivers/mmc/mmc.c @@ -1746,6 +1746,11 @@ static int sd_select_mode_and_width(struct mmc *mmc, uint card_caps) mmc_set_bus_width(mmc, 1); mmc_select_mode(mmc, MMC_LEGACY); mmc_set_clock(mmc, mmc->tran_speed, MMC_CLK_ENABLE); +#if CONFIG_IS_ENABLED(MMC_WRITE) + err = sd_read_ssr(mmc); + if (err) + pr_warn("unable to read ssr\n"); +#endif return 0; } diff --git a/drivers/mmc/mmc_spi.c b/drivers/mmc/mmc_spi.c index ddfebb6ed6..18d36878ef 100644 --- a/drivers/mmc/mmc_spi.c +++ b/drivers/mmc/mmc_spi.c @@ -305,6 +305,7 @@ static int dm_mmc_spi_request(struct udevice *dev, struct mmc_cmd *cmd, case MMC_CMD_READ_MULTIPLE_BLOCK: case MMC_CMD_WRITE_SINGLE_BLOCK: case MMC_CMD_WRITE_MULTIPLE_BLOCK: + case MMC_CMD_APP_CMD: resp = &resp8; resp_size = sizeof(resp8); break; From patchwork Mon Jun 29 09:47:27 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pragnesh Patel X-Patchwork-Id: 1318805 X-Patchwork-Delegate: van.freenix@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=sifive.com header.i=@sifive.com header.a=rsa-sha256 header.s=selector1 header.b=hqBXwSmc; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 49wN5S0z8Cz9sQx for ; Mon, 29 Jun 2020 19:50:20 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 04BB681FD7; Mon, 29 Jun 2020 11:48:54 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=sifive.com header.i=@sifive.com header.b="hqBXwSmc"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 27FED81FBB; Mon, 29 Jun 2020 11:48:29 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MSGID_FROM_MTA_HEADER,T_SPF_HELO_TEMPERROR, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2062e.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe5a::62e]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id B974A81F9A for ; Mon, 29 Jun 2020 11:48:14 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=pragnesh.patel@sifive.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=appZhnvKNwWssM7DmoL/xolhazGGnADGSkRGBbulMN3fZ7X0JZtUSpVvWoUWCwEzs/IJ4L0K7pjkKTh8ePWHPFnVLbUTWWTLFr7BUmDiSuDrnRF8sRdqUQiMAnrWLC0EOtmhWzGx9gEWYeFcWcsHVQyVkogywzmBpg8oK1DkFGs2DxM2blPQmkPcyNViqfizOjIpt3EspGdx9MAnha0Bp6lA8h4YN00EJYWzOtcXmZDQmqmivbh+HdyeruBXUiCeORFdyNS4LpKTuvdeDLzm0GFZYS+5SvT3R8hJURu0/omhVxJ6OvqeBtsRDxMqW+GzVhY7TcmMQlYBL6C+QZTB2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6oKjkraU8NmZYGq6021a1Nkj/9eCOwxV+bQ4Zka/nF8=; b=aKLL+vP6DziTKT1TxTduh+9dwp5FLcxIJjk+RYZ5MzNbVZQfIagwzjweiA6/nEyrF3SlXZZZkWXoNn6C1rModaiNoYkK3Zdl6hkTz7OTa6+2DkhHXiJtOhfNYxURMXAHHas00JdPE2VeJFKcg4oI/qyi/ftC2IRv72BBhQh/Q3DcQCcsnHyC4a1sPhaXpRNnGGpQIcWxwogR5AlqUbsUYUVriOiXKuAatIBvhmWj6LgAIqBA26Kwa5tPV8pgvHD3AP3+Gz8GomtFAVk4eLtzOCpjIEmZPaPSjsupxd0WP5bMp+Frc8GtUJhYhKxlswPTWf1fgrLIkzHJE1k7IqfVKw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=sifive.com; dmarc=pass action=none header.from=sifive.com; dkim=pass header.d=sifive.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6oKjkraU8NmZYGq6021a1Nkj/9eCOwxV+bQ4Zka/nF8=; b=hqBXwSmc+SE4lRGHzQEencb7VP7COAN7fCHxYCybCpnnV738PV8LxmEVLGVm7+6vgngWiIIvcTNyANnWs6dKjmzhO8gDAQE0KD1Z0TTfWr3kqhattBhkXVdlglNIWVyOaIUXM9uR+NPNHp5+pnQl/baqfFAN22If4kZRJBQzAsE= Authentication-Results: nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=none action=none header.from=sifive.com; Received: from MN2PR13MB2797.namprd13.prod.outlook.com (2603:10b6:208:f2::30) by MN2PR13MB4038.namprd13.prod.outlook.com (2603:10b6:208:26a::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3153.14; Mon, 29 Jun 2020 09:48:10 +0000 Received: from MN2PR13MB2797.namprd13.prod.outlook.com ([fe80::7d39:44e8:5e4f:b8a2]) by MN2PR13MB2797.namprd13.prod.outlook.com ([fe80::7d39:44e8:5e4f:b8a2%6]) with mapi id 15.20.3153.018; Mon, 29 Jun 2020 09:48:10 +0000 From: Pragnesh Patel To: peng.fan@nxp.com Cc: bmeng.cn@gmail.com, paul.walmsley@sifive.com, jagan@amarulasolutions.com, sagar.kadam@sifive.com, u-boot@lists.denx.de, Pragnesh Patel Subject: [PATCH 4/6] mmc: mmc_spi: Read R2 response for send status command - CMD13 Date: Mon, 29 Jun 2020 15:17:27 +0530 Message-Id: <20200629094730.10051-5-pragnesh.patel@sifive.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200629094730.10051-1-pragnesh.patel@sifive.com> References: <20200629094730.10051-1-pragnesh.patel@sifive.com> X-ClientProxiedBy: LO2P265CA0437.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:e::17) To MN2PR13MB2797.namprd13.prod.outlook.com (2603:10b6:208:f2::30) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from sachinj2-OptiPlex-7010.open-silicon.com (114.143.65.226) by LO2P265CA0437.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:e::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3131.20 via Frontend Transport; Mon, 29 Jun 2020 09:48:08 +0000 X-Mailer: git-send-email 2.17.1 X-Originating-IP: [114.143.65.226] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 931ff125-973a-4509-2719-08d81c118872 X-MS-TrafficTypeDiagnostic: MN2PR13MB4038: X-LD-Processed: 22f88e9d-ae0d-4ed9-b984-cdc9be1529f1,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:345; X-Forefront-PRVS: 044968D9E1 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: APWLiCkyH+bfaWSpcl7mWB2Bi9ei+1v+vO9mM6nyo0AoaSgsn+8xxhVYK4Q8gcm4kiSJe/YQLlQwGO1veECvhB5k/QCU7Y5VN0JYJFrbXUqDWBl8OnyVrybhTao2Cfu9xhBtu9RJ+SCj2Hvgh9tvluq/ms/nXXE3/vM2PCgcNpRI0Oi1LiOo2w0xgARxA3tM6iSvwkho4JRoMkh9pou4xriC0X5O1wTNNx0wZ40KuxifyzJdcuvAejDBXZfGQn9ekc5mtqSLidmglA7e7I1Pw11bwaTiFyRf1UG0fFnGVJesd/h6DrQnlVMPr70ra0QULpBXNFncEZ9bN6JvU9Cf7Q== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR13MB2797.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(366004)(346002)(136003)(396003)(39840400004)(376002)(956004)(8936002)(44832011)(16526019)(478600001)(316002)(6916009)(26005)(186003)(5660300002)(4326008)(107886003)(6506007)(66556008)(52116002)(2616005)(6486002)(1076003)(2906002)(36756003)(66476007)(8676002)(86362001)(66946007)(6512007)(6666004)(1006002)(83380400001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: XCbYAlpWW9jqmLfYGhpKXjpCLEWlN9jLXYRp85HvH6NlKrs47q+LYPOdYqMBo8Au+hsrfozJ12ST4beehx7i3RGRO2trx23gf4THO2v9p44ZqaOaefAnroJzrAdrWSbZzG4CvF0DRsjPtMO/11vjliv5fBl9Z08zHVDYRp309XWMFfkEw1W5XQhHOFXqujAqFjudgIzmuYd5dUqoJX3lHQ20aSZyha94oYa3NfxK30sbtL85lC/8n4VASUVyR9oPqUkB4pAfO2le0mWGV6yeh2pOcU/zMWSh6OantJrnMEWCLwLbcf+YJwqbcVmho9cujdU1EGv38TwMv2HBIrIsQWTAhayQ42I7gBdOvMOzZm/fBf39VHb6JkYdLRe0Bg/dO1hf+Cgpi5L9/0e7zZoLW8Z97tAMl6BP9olYWv5G1vy0FZkcqOeO9mV+wrdN90aPVVgM/zs/At/C83W0B00rKPiUSpTwr7NpCUxOCvGGGds= X-OriginatorOrg: sifive.com X-MS-Exchange-CrossTenant-Network-Message-Id: 931ff125-973a-4509-2719-08d81c118872 X-MS-Exchange-CrossTenant-AuthSource: MN2PR13MB2797.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jun 2020 09:48:10.6017 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 22f88e9d-ae0d-4ed9-b984-cdc9be1529f1 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: id3iUnfPWfmxGRccN1MYUH8/ijppl+kE8JGebVvRFnYe74qhM9apC86ZXwToumpEJBH8z/cTeF+MuBT0534kl0t51Y5EmP2E3oGLBx02/sc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR13MB4038 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.30rc1 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.2 at phobos.denx.de X-Virus-Status: Clean Send status command (CMD13) will send R1 response under SD mode but R2 response under SPI mode. R2 response is 2 bytes long, so read 2 bytes for mmc SPI mode Signed-off-by: Pragnesh Patel Reviewed-by: Bin Meng Tested-by: Bin Meng --- drivers/mmc/mmc_spi.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/mmc/mmc_spi.c b/drivers/mmc/mmc_spi.c index 18d36878ef..ee56de36ec 100644 --- a/drivers/mmc/mmc_spi.c +++ b/drivers/mmc/mmc_spi.c @@ -266,7 +266,7 @@ static int dm_mmc_spi_request(struct udevice *dev, struct mmc_cmd *cmd, u8 *resp = NULL; u32 resp_size = 0; bool resp_match = false; - u8 resp8 = 0, resp40[5] = { 0 }, resp_match_value = 0; + u8 resp8 = 0, resp16[2] = { 0 }, resp40[5] = { 0 }, resp_match_value = 0; dm_spi_claim_bus(dev); @@ -291,6 +291,9 @@ static int dm_mmc_spi_request(struct udevice *dev, struct mmc_cmd *cmd, resp_size = sizeof(resp40); break; case MMC_CMD_SEND_STATUS: + resp = (u8 *)&resp16[0]; + resp_size = sizeof(resp16); + break; case MMC_CMD_SET_BLOCKLEN: case MMC_CMD_SPI_CRC_ON_OFF: case MMC_CMD_STOP_TRANSMISSION: @@ -335,8 +338,10 @@ static int dm_mmc_spi_request(struct udevice *dev, struct mmc_cmd *cmd, cmd->response[0] |= (uint)resp40[1] << 24; break; case MMC_CMD_SEND_STATUS: - cmd->response[0] = (resp8 & 0xff) ? - MMC_STATUS_ERROR : MMC_STATUS_RDY_FOR_DATA; + if (resp16[0] || resp16[1]) + cmd->response[0] = MMC_STATUS_ERROR; + else + cmd->response[0] = MMC_STATUS_RDY_FOR_DATA; break; case MMC_CMD_SEND_CID: case MMC_CMD_SEND_CSD: From patchwork Mon Jun 29 09:47:28 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pragnesh Patel X-Patchwork-Id: 1318802 X-Patchwork-Delegate: van.freenix@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=sifive.com header.i=@sifive.com header.a=rsa-sha256 header.s=selector1 header.b=jmwaNIES; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 49wN4K21WZz9sQx for ; Mon, 29 Jun 2020 19:49:21 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id AC1EE81FB3; Mon, 29 Jun 2020 11:48:47 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=sifive.com header.i=@sifive.com header.b="jmwaNIES"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 3B85381FAB; Mon, 29 Jun 2020 11:48:23 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FORGED_SPF_HELO,MSGID_FROM_MTA_HEADER, SPF_HELO_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2062e.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe5a::62e]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 75F4A81FAD for ; Mon, 29 Jun 2020 11:48:15 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=pragnesh.patel@sifive.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EAMxW4mJi0fBYplWcVafJ4oaBcKFveADQDMVUPDb/ZvQy9D84Bl93hAhikRxparPRa/9F0qXvrK4SthiS6Rt1lypOcb8c5E4YAfhFJaAZPThWEtTFCkDhF6clUvwsFxvacuzkoDZ83DlNAYjjJDauJGJ/Jw2x2p6vRJIK0A85mxKAhU5EvB2HNQPKnKL4yQ5WiZUx2kVG4TOCPg3qnVUa6a0KF66mv0oUbLMP8cH010SDYi3kmDU4dhjN1OttlmnMYAOMS9UwIQ9mJPK4DfkcUIRs7p9+rNfDNjQdHCkPo6JGUjbrXL4Oj8kEzlJLySYDI/UXE9AiYQFgARHHO3QjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=n5pD/F3vwcVwl0mjlWeAdM5qGy+xGjCPKTxU4mhoWi0=; b=MBikOIviyyM5aToi2/uZxLVWtayl1heVXVh04Bs9An6f0E9d23cUOPLQsMlSX/2re//IREW6TwY8ysc4RT7nRckLuj18O503KlbrJwROdBOYpnmlxKCLvpAaH2RR5PS9zqlCcSDaNOH+u1SL8BLe6DFdHBr9E4/FuRPtb638mY2M28uaQDiQft3wFlxpjoY1jNOOA/6a5hNQ0fFwH2nE5qi1R1cBhqOa8p1Op99k9h8ZvJ2WU2wQYsJUovm6OcGSK1/XCjRupQnNcvExqAVYEvS4NMoO830uEggBMrMTbW6/NMaFFcZFpU9my9mEwkCStcJqzUBLyPv3FBZXlPwW2g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=sifive.com; dmarc=pass action=none header.from=sifive.com; dkim=pass header.d=sifive.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=n5pD/F3vwcVwl0mjlWeAdM5qGy+xGjCPKTxU4mhoWi0=; b=jmwaNIESbjrbml5qEFNr67C+0qEyKAVQ6oBydP9dk4Q6v1NpbaYTDZqyRoWXoWRD/lmrUbaJTOuBKY/VI+WyJjLcdPNmUwquKejDq3Ony+U5NMpTbGl70MNp7b7/oy8n6DFUZcvNpQQeC4OxGPdCyAAXeD8ol+u7i5ATcAg6Y7A= Authentication-Results: nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=none action=none header.from=sifive.com; Received: from MN2PR13MB2797.namprd13.prod.outlook.com (2603:10b6:208:f2::30) by MN2PR13MB4038.namprd13.prod.outlook.com (2603:10b6:208:26a::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3153.14; Mon, 29 Jun 2020 09:48:13 +0000 Received: from MN2PR13MB2797.namprd13.prod.outlook.com ([fe80::7d39:44e8:5e4f:b8a2]) by MN2PR13MB2797.namprd13.prod.outlook.com ([fe80::7d39:44e8:5e4f:b8a2%6]) with mapi id 15.20.3153.018; Mon, 29 Jun 2020 09:48:13 +0000 From: Pragnesh Patel To: peng.fan@nxp.com Cc: bmeng.cn@gmail.com, paul.walmsley@sifive.com, jagan@amarulasolutions.com, sagar.kadam@sifive.com, u-boot@lists.denx.de, Pragnesh Patel Subject: [PATCH 5/6] mmc: mmc_spi: Generate R1 response for erase block start and end address Date: Mon, 29 Jun 2020 15:17:28 +0530 Message-Id: <20200629094730.10051-6-pragnesh.patel@sifive.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200629094730.10051-1-pragnesh.patel@sifive.com> References: <20200629094730.10051-1-pragnesh.patel@sifive.com> X-ClientProxiedBy: LO2P265CA0437.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:e::17) To MN2PR13MB2797.namprd13.prod.outlook.com (2603:10b6:208:f2::30) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from sachinj2-OptiPlex-7010.open-silicon.com (114.143.65.226) by LO2P265CA0437.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:e::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3131.20 via Frontend Transport; Mon, 29 Jun 2020 09:48:11 +0000 X-Mailer: git-send-email 2.17.1 X-Originating-IP: [114.143.65.226] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a0a85435-cc83-4c31-3f11-08d81c118a13 X-MS-TrafficTypeDiagnostic: MN2PR13MB4038: X-LD-Processed: 22f88e9d-ae0d-4ed9-b984-cdc9be1529f1,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1079; X-Forefront-PRVS: 044968D9E1 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 02+gZUEZoPnSm7l846oyvzWV/IoOVlXzHHsKjnVM6LpBxveQRbTryh8SrhHlwxIZvTIOJ6ZSrnbcBMhR86GgrR3meIOZesesTdOcLb+Bie4C+GIiFmeOADvXz9HDp+ORrF4BeQLVbIrd3nTeHf2qvsMPo+NlCFA9z1Q4Fo6VNTgUy2y+YTKTzqf8H1N/t2lEvuDUUVcImQn/aFlq7aww3elNrcu2L6rO856CTKU9Uu0AwMP4O1BJdnVgPg1I9Rzb+BsQKb/KmQI16dmHaBk+ml8puTtlQYDGLc1yo0tPuq2n0QI8djToVlFb7yZ5Sf1Tux94NsrYnfCxfnP17fRnpA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR13MB2797.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(366004)(346002)(136003)(396003)(39840400004)(376002)(956004)(8936002)(44832011)(16526019)(478600001)(316002)(6916009)(26005)(186003)(5660300002)(4744005)(4326008)(107886003)(6506007)(66556008)(52116002)(2616005)(6486002)(1076003)(2906002)(36756003)(66476007)(8676002)(86362001)(66946007)(6512007)(6666004)(1006002)(83380400001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: uRiIlz5veCMFdUwWBD46aKy3mx/XONu555sPnLnT0kOj/29QyDkt+MYdwdrNQFzF/5DnVTZXRwaue9DciqOz1yVeLqAQJ9CDT4kGkMywqIbwTVZzrGicwydxaWV8mKGepljvuVmBYa8gzkdnvSPQscNC0PTolVEiqHXDHi5sztMMWs5hYL07GsGSxy8NLkFRvfLLCnXkRNbju8mbis2hgkJwyg9DfcT0ug9uumqll4XyCgzWs/Vs+bCOw9trxxOhdB8bKWajmpg8fXiSjrpNeJxRI/clftwTxW08aj3RZRzGItPGjTg1VSc3DG7yY0+a2MYLxMYssQzzDamjaoKuw5HnCk+p+/pkDb9DeMy9SdZKh54BxfUk8s3it9AeJKUVmSpDIxaZDfMZ2YwHe8REr2wpb3l4abd1W81QB8sy+Wnzw0GegI/qqom0/deDPkUv/L5CFcLOdv+zPoHjoaol9RQPUkGJf1VtMyGpYtP1SHk= X-OriginatorOrg: sifive.com X-MS-Exchange-CrossTenant-Network-Message-Id: a0a85435-cc83-4c31-3f11-08d81c118a13 X-MS-Exchange-CrossTenant-AuthSource: MN2PR13MB2797.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jun 2020 09:48:13.2392 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 22f88e9d-ae0d-4ed9-b984-cdc9be1529f1 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: y+d2diIl6644SSnQvmYNIzi99/ObdcyUrPZvZrwTUTtP/lq+4ay3gZBgLOKl5z4C2wYgeBFp4J+3PwSyQKbRS8L56CNfF105K0MkDINpNzI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR13MB4038 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.30rc1 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.2 at phobos.denx.de X-Virus-Status: Clean Erase block start address (CMD32) and erase block end address (CMD33) command will generate R1 response for mmc SPI mode. R1 response is 1 byte long for mmc SPI, so assign 1 byte as a response for this commands. Signed-off-by: Pragnesh Patel Reviewed-by: Bin Meng Tested-by: Bin Meng --- drivers/mmc/mmc_spi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/mmc/mmc_spi.c b/drivers/mmc/mmc_spi.c index ee56de36ec..96a41076dc 100644 --- a/drivers/mmc/mmc_spi.c +++ b/drivers/mmc/mmc_spi.c @@ -309,6 +309,8 @@ static int dm_mmc_spi_request(struct udevice *dev, struct mmc_cmd *cmd, case MMC_CMD_WRITE_SINGLE_BLOCK: case MMC_CMD_WRITE_MULTIPLE_BLOCK: case MMC_CMD_APP_CMD: + case SD_CMD_ERASE_WR_BLK_START: + case SD_CMD_ERASE_WR_BLK_END: resp = &resp8; resp_size = sizeof(resp8); break; From patchwork Mon Jun 29 09:47:29 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pragnesh Patel X-Patchwork-Id: 1318806 X-Patchwork-Delegate: van.freenix@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=sifive.com header.i=@sifive.com header.a=rsa-sha256 header.s=selector1 header.b=qMh9c58G; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 49wN5n2T5Bz9sQx for ; Mon, 29 Jun 2020 19:50:37 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6D59A81FE2; Mon, 29 Jun 2020 11:48:56 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=sifive.com header.i=@sifive.com header.b="qMh9c58G"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 0960A81FB9; Mon, 29 Jun 2020 11:48:33 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FORGED_SPF_HELO,MSGID_FROM_MTA_HEADER, SPF_HELO_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2062e.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe5a::62e]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 3E3E881F75 for ; Mon, 29 Jun 2020 11:48:16 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=pragnesh.patel@sifive.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mkuXkF+OhZJS2QTTbCOnxhD0NurJG3sMGo45ncAnuYaFPxTRKQKgRGlGtcLJl/On9ubHiiRUQZkoaF0b19czL4S7LxgXVNRnDKJdR5NJ7269GH+iqRj4ucWWXi9V97xghOnFe+cvxsGPHjmwm7uTtvzGARRE20En5KV8eKvFeo0eqRMrRLsNC/tC5WcXBUnBzBE4DUT6K4xwKoEkFhzuKNGc4QXiJJibnSQI3jQs0dKGy6R+D16+FWbjEckMYeQciRRms1aoEgzDejiQa+wkxcVpzXdGJS+MOiYcmNDmF7ccXHHvI/hTXEflgTHjNkA2qpQVS2OwbiRv0ysWhrfsNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gdSIoIfyjDGTdC41kpuJBlYZ7CTs6NKsTgvfhMTOkGE=; b=dzs3thSxJb3UIpOZNNJK0ncvrKnRgVFOXsgM11wLPkRug+n0eaEhp60Vki4yUYO60WPJA73tquGGc3juwguPD0CWIcvxy2KqVvViqbl618pIdjsPEW+gBORfgRe8aTSuoGInSXZ+asICW+Hyz9eqmZqXTXKUbLSKic2A7PstsCGxG+szEE8zGYTTOlxovYVWcqtmoyEyEsIMo4re000U7Qi/ArfnAwRPUwD5QR/22T+TZGX8M6uZasD7HkPbgJRLdEaS1yZvoBP8rVT1NdGCGGkpwAEMZ8kSqouTCkxYrSUVAhaIeFEfkon12EUY3aNauDI3cE7F6l/6M/89Mzd80w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=sifive.com; dmarc=pass action=none header.from=sifive.com; dkim=pass header.d=sifive.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gdSIoIfyjDGTdC41kpuJBlYZ7CTs6NKsTgvfhMTOkGE=; b=qMh9c58G6BG83oRfbivzKhEfsqLstv5eHVgW6PQFeXt/xBlnmRtT8W0tHwpqjtlIQUhAmzHYXubgSE/KYMP95RX7Iwe68CheCok5+evK5fxugdGzmTTf4+jnZ36D6vHmSMeBY+oJtMkGuu10VvDV6g5guoABqkpY0RkeQuEVs0c= Authentication-Results: nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=none action=none header.from=sifive.com; Received: from MN2PR13MB2797.namprd13.prod.outlook.com (2603:10b6:208:f2::30) by MN2PR13MB4038.namprd13.prod.outlook.com (2603:10b6:208:26a::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3153.14; Mon, 29 Jun 2020 09:48:16 +0000 Received: from MN2PR13MB2797.namprd13.prod.outlook.com ([fe80::7d39:44e8:5e4f:b8a2]) by MN2PR13MB2797.namprd13.prod.outlook.com ([fe80::7d39:44e8:5e4f:b8a2%6]) with mapi id 15.20.3153.018; Mon, 29 Jun 2020 09:48:16 +0000 From: Pragnesh Patel To: peng.fan@nxp.com Cc: bmeng.cn@gmail.com, paul.walmsley@sifive.com, jagan@amarulasolutions.com, sagar.kadam@sifive.com, u-boot@lists.denx.de, Pragnesh Patel Subject: [PATCH 6/6] mmc_spi: generate R1b response for erase and stop transmission command Date: Mon, 29 Jun 2020 15:17:29 +0530 Message-Id: <20200629094730.10051-7-pragnesh.patel@sifive.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200629094730.10051-1-pragnesh.patel@sifive.com> References: <20200629094730.10051-1-pragnesh.patel@sifive.com> X-ClientProxiedBy: LO2P265CA0437.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:e::17) To MN2PR13MB2797.namprd13.prod.outlook.com (2603:10b6:208:f2::30) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from sachinj2-OptiPlex-7010.open-silicon.com (114.143.65.226) by LO2P265CA0437.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:e::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3131.20 via Frontend Transport; Mon, 29 Jun 2020 09:48:13 +0000 X-Mailer: git-send-email 2.17.1 X-Originating-IP: [114.143.65.226] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d8004391-be6e-46e4-cd64-08d81c118ba2 X-MS-TrafficTypeDiagnostic: MN2PR13MB4038: X-LD-Processed: 22f88e9d-ae0d-4ed9-b984-cdc9be1529f1,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:316; X-Forefront-PRVS: 044968D9E1 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xVroFfR1pode2n+KLdL0ufufVzXJIq+Ni4L77WGYWAn+x73dtBC7mwzBd0KG+YAxGlVki9qWMLhISAd0d3+hjY2elMaoGnhNF4VXKlmYAIun/Y2zgRQZCHaIaVD3A6UN25m+c1xKA5Jwuh3FlcdtePHO/wGBH6BolO7ukLYZWv6AhiReh/z210CKJRh1YerZwrXDikI8XWi41bekQ5W1z8ya7xsDMJWU88D94d/1czzLoHQ8d4z79FgNEXLJfzTGktXo3nSIXb6mojlUc7qoHvqXYoF9ByKXhxHKMU/rthnZ4dXM37fUfTMGq5RJdPLg X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR13MB2797.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(366004)(346002)(136003)(396003)(39840400004)(376002)(956004)(8936002)(44832011)(16526019)(478600001)(316002)(6916009)(26005)(186003)(5660300002)(4326008)(107886003)(6506007)(66556008)(52116002)(2616005)(6486002)(1076003)(2906002)(36756003)(66476007)(8676002)(86362001)(66946007)(6512007)(6666004)(1006002)(83380400001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: 4gHNMXUvPdBhyTKZ3XC7GmE+WR0hg5EwZ03Ad9VZoGjlbsspHTFj7PXJu+SR7f4DUm8TRxkOP2FrgtZ5hpzOezr8ppE7/+dQ9ssuEWGhJ0cVtn1qQ7dODGpZ4hjm9hI9I8WvTX8cd8eiE1IleOE5AcOm09RfpKwduDqQ2rtJ+0CwkKiP404cZf8uRCwcnt6e6OUR8TNLxTN6xVtG3UBVAT0hHm/Cho30DyjiRBVRtIzGn7diyBKlRQiKXVF2zJnfozrbrsupycZOmzgSQJyzscy54bBgMRy2NjvmFz7r7sJUPLLy6PBF9mm7h6VOI5WeQWeUPov2+6LEyKHLVPqebQsYbWA9pu2h4G0U3S+IWD9YqVZk9qv1vw1ymepbodnhMrKihAeQfk58uh77/1RWUNiOndeeiHtPqVotGCJ9wUrkZs9u791p0JnziNKYAkhfxQeafqjmL9VyzFPxILWeK/VyfXhv3EyPGDjXG7Zy2+QTwCPNqzDRBBVzkWnxYwXo X-OriginatorOrg: sifive.com X-MS-Exchange-CrossTenant-Network-Message-Id: d8004391-be6e-46e4-cd64-08d81c118ba2 X-MS-Exchange-CrossTenant-AuthSource: MN2PR13MB2797.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jun 2020 09:48:15.9057 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 22f88e9d-ae0d-4ed9-b984-cdc9be1529f1 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: q35d5Ov9geajNMUWCfNy/q3mYYmeQ1XUcbumJnlbEllrDCVkEoCWFT3zqqjcpE+G9K2uNjjCkXXMOvJzrDCCK3a4sHRTfXEq8CBpF3qLBws= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR13MB4038 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.30rc1 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.2 at phobos.denx.de X-Virus-Status: Clean As per the SD physical layer specification version 7.10, erase command (CMD38) and stop transmission command (CMD12) will generate R1b response. R1b = R1 + busy signal A non-zero value after the R1 response indicates card is ready for next command. Signed-off-by: Pragnesh Patel Reviewed-by: Bin Meng Tested-by: Bin Meng --- drivers/mmc/mmc_spi.c | 32 ++++++++++++++++++++++++++++---- 1 file changed, 28 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/mmc_spi.c b/drivers/mmc/mmc_spi.c index 96a41076dc..50fcd32674 100644 --- a/drivers/mmc/mmc_spi.c +++ b/drivers/mmc/mmc_spi.c @@ -59,6 +59,7 @@ #define CMD_TIMEOUT 8 #define READ_TIMEOUT 3000000 /* 1 sec */ #define WRITE_TIMEOUT 3000000 /* 1 sec */ +#define R1B_TIMEOUT 3000000 /* 1 sec */ struct mmc_spi_plat { struct mmc_config cfg; @@ -72,7 +73,7 @@ struct mmc_spi_priv { static int mmc_spi_sendcmd(struct udevice *dev, ushort cmdidx, u32 cmdarg, u32 resp_type, u8 *resp, u32 resp_size, - bool resp_match, u8 resp_match_value) + bool resp_match, u8 resp_match_value, bool r1b) { int i, rpos = 0, ret = 0; u8 cmdo[7], r; @@ -133,6 +134,24 @@ static int mmc_spi_sendcmd(struct udevice *dev, resp[i] = r; } + if (r1b == true) { + i = R1B_TIMEOUT; + while (i) { + ret = dm_spi_xfer(dev, 1 * 8, NULL, &r, 0); + if (ret) + return ret; + + debug(" resp%d=0x%x", rpos, r); + rpos++; + i--; + + if (r) + break; + } + if (!i) + return -ETIMEDOUT; + } + debug("\n"); return 0; @@ -265,7 +284,7 @@ static int dm_mmc_spi_request(struct udevice *dev, struct mmc_cmd *cmd, int i, multi, ret = 0; u8 *resp = NULL; u32 resp_size = 0; - bool resp_match = false; + bool resp_match = false, r1b = false; u8 resp8 = 0, resp16[2] = { 0 }, resp40[5] = { 0 }, resp_match_value = 0; dm_spi_claim_bus(dev); @@ -296,12 +315,17 @@ static int dm_mmc_spi_request(struct udevice *dev, struct mmc_cmd *cmd, break; case MMC_CMD_SET_BLOCKLEN: case MMC_CMD_SPI_CRC_ON_OFF: - case MMC_CMD_STOP_TRANSMISSION: resp = &resp8; resp_size = sizeof(resp8); resp_match = true; resp_match_value = 0x0; break; + case MMC_CMD_STOP_TRANSMISSION: + case MMC_CMD_ERASE: + resp = &resp8; + resp_size = sizeof(resp8); + r1b = true; + break; case MMC_CMD_SEND_CSD: case MMC_CMD_SEND_CID: case MMC_CMD_READ_SINGLE_BLOCK: @@ -323,7 +347,7 @@ static int dm_mmc_spi_request(struct udevice *dev, struct mmc_cmd *cmd, }; ret = mmc_spi_sendcmd(dev, cmd->cmdidx, cmd->cmdarg, cmd->resp_type, - resp, resp_size, resp_match, resp_match_value); + resp, resp_size, resp_match, resp_match_value, r1b); if (ret) goto done;