From patchwork Fri Jun 26 12:39:18 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sagar Shrikant Kadam X-Patchwork-Id: 1317624 X-Patchwork-Delegate: uboot@andestech.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=sifive.com header.i=@sifive.com header.a=rsa-sha256 header.s=selector1 header.b=Q4ew8xJl; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 49tc146QV0z9sPF for ; Fri, 26 Jun 2020 22:40:24 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 893B1813A9; Fri, 26 Jun 2020 14:40:00 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=sifive.com header.i=@sifive.com header.b="Q4ew8xJl"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 037E2812FF; Fri, 26 Jun 2020 14:39:54 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FORGED_SPF_HELO,MSGID_FROM_MTA_HEADER, SPF_HELO_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on20608.outbound.protection.outlook.com [IPv6:2a01:111:f400:7eaa::608]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id EAA2280437 for ; Fri, 26 Jun 2020 14:39:45 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sagar.kadam@sifive.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ijF2bkO9jO/JOfiK8BfL1pKLhJT8l5y+wyG6LkQJER08EWkm2Tw4Vza63XcLgrMkgCS3v+fFQpXNt4a+pMIb0rhnFbuJcy09tGm6kX3xz0xuStfHreKd1TzgHV9kYrxNRQBb/LJfF+7dELzZF06/lSGhaFeh8CFBbtxfuJ4h8dECPSMR3GIiTM003SYNUmcCTV5ryLO2jG3WoGS1GXPowvMuZOH00z5Zuyobg2lqjmzcKc/I7UwI3vpwRB2fNLR10PFuSS9Mxk9mguX8DAkMSoTW3FFGpeMPESnBon+eXeuyiLitY9y8jjjchQcS8ZO0FZTSHgpHk1whCVKiKbiY5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=f6jPohK0ZPCTL/GYncI58x3GOKU0X7MPUa+0x5tD0Iw=; b=Qtq3rUqtt/y1Z/wh4I+6vSeKCwBnkSaoeschq2ZMA6MKsvz4nws01piKGrgW47JTNRPiKwhSQBj5SBYvsfHbH6B820HaHdygySSBxG6gTKb/f8B+cbdAhNxg8lMnTLF4WWc4hVe5LVkn5H3JRDid1S3usZXUIHBeReqF9OUi71ZcTJpl6Ld3NMRZACfgfB7rTEqGOYb7OyaPz9e7xG1vTJ+VJb0r/o7liut+NpLDSNf8gsH/KDmNBcdsSW4svnUbM4XtDc20MJuM+F1iXb4fFIqmBXB8FwnOz0E9ORocaEbLE4+8eHVFVRdCfavRz4bYka5DHkqPpMn1cHLy3JVLTw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=sifive.com; dmarc=pass action=none header.from=sifive.com; dkim=pass header.d=sifive.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=f6jPohK0ZPCTL/GYncI58x3GOKU0X7MPUa+0x5tD0Iw=; b=Q4ew8xJlg7KatLwF9ysOiaZNwHg2fV5Jr6lmPjuzwPFfDBxFwa8uHhdXi3uJ4DN34nw+tjQNUhCULb7Ib/pZV/7KowmENut4OXHZW4wf0tYau/wlpb3DvpqglgeEPF/10C/g6g0o5mTIPkH7xCB3E9vQl8lJnUiuJgGFpJaqzYI= Authentication-Results: lists.denx.de; dkim=none (message not signed) header.d=none;lists.denx.de; dmarc=none action=none header.from=sifive.com; Received: from BN8PR13MB2611.namprd13.prod.outlook.com (2603:10b6:408:81::17) by BN6PR13MB1651.namprd13.prod.outlook.com (2603:10b6:404:142::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3153.10; Fri, 26 Jun 2020 12:39:34 +0000 Received: from BN8PR13MB2611.namprd13.prod.outlook.com ([fe80::c1d9:f4ee:80ab:de83]) by BN8PR13MB2611.namprd13.prod.outlook.com ([fe80::c1d9:f4ee:80ab:de83%6]) with mapi id 15.20.3153.010; Fri, 26 Jun 2020 12:39:33 +0000 From: Sagar Shrikant Kadam To: u-boot@lists.denx.de Cc: rick@andestech.com, bin.meng@windriver.com, jagan@amarulasolutions.com, pragnesh.patel@sifive.com, anup.patel@wdc.com, sjg@chromium.org, ye.li@nxp.com, peng.fan@nxp.com, seanga2@gmail.com, Sagar Shrikant Kadam Subject: [PATCH v6 1/4] riscv: dts: hifive-unleashed-a00: add cpu aliases Date: Fri, 26 Jun 2020 05:39:18 -0700 Message-Id: <1593175161-26278-2-git-send-email-sagar.kadam@sifive.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1593175161-26278-1-git-send-email-sagar.kadam@sifive.com> References: <1593175161-26278-1-git-send-email-sagar.kadam@sifive.com> X-ClientProxiedBy: BY3PR05CA0027.namprd05.prod.outlook.com (2603:10b6:a03:254::32) To BN8PR13MB2611.namprd13.prod.outlook.com (2603:10b6:408:81::17) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from gamma07.internal.sifive.com (64.62.193.194) by BY3PR05CA0027.namprd05.prod.outlook.com (2603:10b6:a03:254::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.20.3131.12 via Frontend Transport; Fri, 26 Jun 2020 12:39:32 +0000 X-Mailer: git-send-email 2.7.4 X-Originating-IP: [64.62.193.194] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b439cd36-6c87-4f1d-bfb5-08d819cdfa85 X-MS-TrafficTypeDiagnostic: BN6PR13MB1651: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3968; X-Forefront-PRVS: 0446F0FCE1 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Sm7A3XXicGZtp0QAID2Sc2psBgqQoGwYhI/ODK/06O5OmSkn3lYhXt9AXri1Kh/rk3stc6LYC77/SES/CMSFp3BYLtTD35IAH3YPa4TboYe6Imbpl6f+hxhNc1h4SIPcCkknynHskAqZgD6PFB7RQUVNmh5ta+uPe13Lxl2qEVbivGhvlXt0BaSgqV8YegWW2/MCHR3o9Cs/Lj4xJDEGHm4nXhpWRQwBK6m/O24A3G+asCu1/E3JSEQt3qgEvJJSNVrlsnMg2Dv6Wh2usq7L70Nd8/IQD/Vfo15YIoICcswSW2m9HlBhbvCmL1o73cbUtwHjoU6jpFQtBgA9nI1/Rw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN8PR13MB2611.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(346002)(396003)(136003)(39850400004)(366004)(376002)(478600001)(6666004)(186003)(16526019)(5660300002)(107886003)(36756003)(6486002)(66946007)(316002)(86362001)(4326008)(8936002)(6916009)(52116002)(956004)(26005)(7696005)(8676002)(66556008)(2616005)(66476007)(2906002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: WxEegA4H7f9r9Ab5y9iL3K6yPsQBXBQv++PDS86isFwN5+n7wkuLcZAW9h0a/PTdHJ1YOfYrSYX7oGX7Ua7I6yUtEx+yRBxIjhhiWIqV+rQPbf4GFRgttPniz8xNOEWh6SXCqKWId6AYlVKvvAqdyGa97hXtebKCiO1HwM/4ZjGcMMqIEG6b6+3ebWXfccXFSw47GRk73V3XMygqVwgUUN7H8tSFg5q62c7bywl759YQ8rn/TqV60IE/CNaGDBFIYhh7r1yp+hbhzIcAbFZrpDiOF3ngRW8hNMj0FADajAOgL9fYMZ7TV9byxtNvOZiwlrryBjgvWDMuddvmf+rd7jkNRgBhJokiF2534W32cyhLSpwqLNcsyP4WAt1XFpuUNgg1kUkAxCKHPEfM7Yn6IdGMfaEQ1pnIfBvUFcq55OdepPP8bo0PJu1sX1TPf1oRariFsFtnIQ/Aa9V+quOeiE6c3bYPj+pBQD6EWUvz8pARZQ/niqXvnV9mjSy2M8B+ X-OriginatorOrg: sifive.com X-MS-Exchange-CrossTenant-Network-Message-Id: b439cd36-6c87-4f1d-bfb5-08d819cdfa85 X-MS-Exchange-CrossTenant-AuthSource: BN8PR13MB2611.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jun 2020 12:39:33.8342 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 22f88e9d-ae0d-4ed9-b984-cdc9be1529f1 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: a9V5YTf3Nb9vZfgd+VPJwuGeoLw0VUU9M8QfAK6kYoMEslsRhVDaP1BxH/bLwwe08U4+KW6UvJ3+eyGnY03rgQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR13MB1651 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.30rc1 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.2 at phobos.denx.de X-Virus-Status: Clean Add cpu aliases to U-Boot specific dtsi for hifive-unleashed. Without aliases we see that the CPU device sequence numbers are set randomly and the cpu list/detail command will show it as follows: => cpu list 1: cpu@1 rv64imafdc 2: cpu@2 rv64imafdc 3: cpu@3 rv64imafdc 0: cpu@4 rv64imafdc Seems like CPU probing with dm-model also relies on aliases as observed in case spi. The fu540-c000-u-boot.dtsi has cpu nodes and so adding corresponding aliases we can ensure that cpu devices are assigned proper sequence as follows: => cpu list 1: cpu@1 rv64imafdc 2: cpu@2 rv64imafdc 3: cpu@3 rv64imafdc 4: cpu@4 rv64imafdc Signed-off-by: Sagar Shrikant Kadam Reviewed-by: Pragnesh Patel Reviewed-by: Bin Meng --- arch/riscv/dts/hifive-unleashed-a00-u-boot.dtsi | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/arch/riscv/dts/hifive-unleashed-a00-u-boot.dtsi b/arch/riscv/dts/hifive-unleashed-a00-u-boot.dtsi index 3038064..e037150 100644 --- a/arch/riscv/dts/hifive-unleashed-a00-u-boot.dtsi +++ b/arch/riscv/dts/hifive-unleashed-a00-u-boot.dtsi @@ -8,6 +8,10 @@ / { aliases { + cpu1 = &cpu1; + cpu2 = &cpu2; + cpu3 = &cpu3; + cpu4 = &cpu4; spi0 = &qspi0; spi2 = &qspi2; }; From patchwork Fri Jun 26 12:39:19 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sagar Shrikant Kadam X-Patchwork-Id: 1317625 X-Patchwork-Delegate: uboot@andestech.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=sifive.com header.i=@sifive.com header.a=rsa-sha256 header.s=selector1 header.b=Xx57QoUT; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 49tc1Q4q7Xz9sRN for ; Fri, 26 Jun 2020 22:40:42 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 34F898179D; Fri, 26 Jun 2020 14:40:09 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=sifive.com header.i=@sifive.com header.b="Xx57QoUT"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 45A6380390; Fri, 26 Jun 2020 14:39:58 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FORGED_SPF_HELO,MSGID_FROM_MTA_HEADER, SPF_HELO_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on20608.outbound.protection.outlook.com [IPv6:2a01:111:f400:7eaa::608]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 43AB380390 for ; Fri, 26 Jun 2020 14:39:50 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sagar.kadam@sifive.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=M75L2Gin9b2XL0nfnkGtcKUgudCa9XAKG2LeQo4IHTEMk81s9KUaY5T6Pfs7ebMN//kNj6ifeoLWvSxkcwiPGWQArDIor5hUHzzZk5+2duLFWItkjTVCAzKK+C189cWV+qFNZM0uaVMBj4BK3qVREccoTj+1xNUN0Awz5yaUEjYDjabTQzVxqvgUiHlSOamiZDr34H79O3GmfUqhzH5Uj13WjgS3EzSPvOjPuqgDIpNk/T4rvHNt4PIAEuUGXjlB0k/cdXDsP1C4xj/cosHIEqu1wZrc3Ae1QzJgm3Y5ebv1Oya2LfSbvV5KnfKWFmyNa6bGst74d+X1Zl5g/A7Wzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=woIvGn4AL6ZDqJaADSNbBp1v1dcAuMA3sOsud9AXni8=; b=fWpnCoywg5bI8CQelPladsejd633pm6DF49AMjq5vrIE0JhLHZzTgE4nKpCVKaLf6Jtd3+0j+SfFZ5to42uEoTXepGvnWaXQcn5zd4W9Q7kLO/KKS46c4Bn+ZEdktnoAOot4W1leFQ4YoNryqmWMDyj86UvigthN+zLwSpon/qTw0TXn9fM9KBA5qne79L8NYP7FWdztZyP9UHb9qpt3KhWMcKn4+BMUwcbTocm2pnwAQqj1g1CA6YTA/riHoRt0+WNqrVXHrtZ7juLukoYyBN042GDVMWFCYw1qS/AtlebhIebi8To4nJNQLYndFWBwJe3Opaka/TrdhEaFpvh+5A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=sifive.com; dmarc=pass action=none header.from=sifive.com; dkim=pass header.d=sifive.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=woIvGn4AL6ZDqJaADSNbBp1v1dcAuMA3sOsud9AXni8=; b=Xx57QoUTBN72Nw9CCliz2D/v1KIMiF7auwuCozjZPXvbA1iqXZ/MbMRHlf0Sm9CPefHf1nnXjcy3H37e5mmwaBRFKZDN0cW2nOgmibSUM2KeIaPqN9kWswDty6bQvSvFReBv0z3QWFwOOPXv54xnakP7qlXbGjW17D+nK/poLe8= Authentication-Results: lists.denx.de; dkim=none (message not signed) header.d=none;lists.denx.de; dmarc=none action=none header.from=sifive.com; Received: from BN8PR13MB2611.namprd13.prod.outlook.com (2603:10b6:408:81::17) by BN6PR13MB1651.namprd13.prod.outlook.com (2603:10b6:404:142::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3153.10; Fri, 26 Jun 2020 12:39:36 +0000 Received: from BN8PR13MB2611.namprd13.prod.outlook.com ([fe80::c1d9:f4ee:80ab:de83]) by BN8PR13MB2611.namprd13.prod.outlook.com ([fe80::c1d9:f4ee:80ab:de83%6]) with mapi id 15.20.3153.010; Fri, 26 Jun 2020 12:39:36 +0000 From: Sagar Shrikant Kadam To: u-boot@lists.denx.de Cc: rick@andestech.com, bin.meng@windriver.com, jagan@amarulasolutions.com, pragnesh.patel@sifive.com, anup.patel@wdc.com, sjg@chromium.org, ye.li@nxp.com, peng.fan@nxp.com, seanga2@gmail.com, Sagar Shrikant Kadam Subject: [PATCH v6 2/4] uclass: cpu: fix to display proper CPU features Date: Fri, 26 Jun 2020 05:39:19 -0700 Message-Id: <1593175161-26278-3-git-send-email-sagar.kadam@sifive.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1593175161-26278-1-git-send-email-sagar.kadam@sifive.com> References: <1593175161-26278-1-git-send-email-sagar.kadam@sifive.com> X-ClientProxiedBy: BY3PR05CA0027.namprd05.prod.outlook.com (2603:10b6:a03:254::32) To BN8PR13MB2611.namprd13.prod.outlook.com (2603:10b6:408:81::17) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from gamma07.internal.sifive.com (64.62.193.194) by BY3PR05CA0027.namprd05.prod.outlook.com (2603:10b6:a03:254::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.20.3131.12 via Frontend Transport; Fri, 26 Jun 2020 12:39:35 +0000 X-Mailer: git-send-email 2.7.4 X-Originating-IP: [64.62.193.194] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d76a5cc6-c783-4f58-c6e2-08d819cdfc13 X-MS-TrafficTypeDiagnostic: BN6PR13MB1651: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6790; X-Forefront-PRVS: 0446F0FCE1 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KN6BHYumINb7FSSXrXXhUYp6CxMjvcQpMN8S4mWCVPFTjSyrOQA0w7895yiTYaqmyaQm7QOwTeYWN4QKhmI2Xzi2gNP2pqy2kAp5F00uJcXBLd5wPBW3C6L0w8F9OHUCPU583EYdRGlfalxLC59AcDVPZ5XHzo9m8SaTdJOAedULuW5KeAB6ofJNB7gQi8YtaDXz3aPLNwCQs6sW7FnaeTmI/RK6WKBAeCCY0zQ0jhEkBprN+ACFdl4GVrBqj/7jAuwHFCcLMBYbOFxlTwH3FchQXR/npWGbpskYbsPdU2YLHktZ8NJ+HiqIvPBJnFQzxHF3/67KdwiP/GtjljoaDQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN8PR13MB2611.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(346002)(396003)(136003)(39850400004)(366004)(376002)(478600001)(6666004)(186003)(16526019)(5660300002)(107886003)(36756003)(6486002)(66946007)(316002)(86362001)(4326008)(8936002)(6916009)(52116002)(956004)(26005)(7696005)(8676002)(66556008)(2616005)(66476007)(2906002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: 092bP4h68F5n4FwnBuzdRzhn/mZP+S0kGMuDxwQSbMVuJmVg8phirV5lFPJuKr3R4Tn0G2cgcEMc7gf9s8VOJdMViV907Erbov+g3LEIRLiSMhc653z+dy4YNiiiMnUPHtEzwgLf9L6N/qy5OQBCxVz5dziE5u26gTu7t8VTfA8Fkt6AKsFo54SYSwFVr+tIf6cZXzJYeYWvOT2ccfuy0Q1zlL71PJytDzZ4zoWMUELUhXNZN5MUxE/9e/YtWkQzIeiAerBveFHjzLzn/3nEyRDI3lQVDfeWDXAe2cdfO0Nd64fGLwIumE1BD8o5dQCctAOzy2iharJjvnf+YlURkZIPctCDZmIwt+UqMUXccHp1bIlmKfOQjvwztGzuD2RnQYqOQgNULFG2dx39JjS6zKhBXV0we+l27mZsx0MMQkRUAjbTlEjZnNAzeOWLyjEnyh2pCeb17GIovq0BmBSRsrtH0GUwzyEUCce2nhUQwlBYdEe37yNahABRald8XUqG X-OriginatorOrg: sifive.com X-MS-Exchange-CrossTenant-Network-Message-Id: d76a5cc6-c783-4f58-c6e2-08d819cdfc13 X-MS-Exchange-CrossTenant-AuthSource: BN8PR13MB2611.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jun 2020 12:39:36.4247 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 22f88e9d-ae0d-4ed9-b984-cdc9be1529f1 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: d0Y3SiRB3VYvn3X/Or36tc7ZPcSH6PeIExaL6HHGNBAc87KihfoL13BaOs69Ly7n1xcpcO3arwL2aHVgl6rIDw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR13MB1651 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.30rc1 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.2 at phobos.denx.de X-Virus-Status: Clean The cmd "cpu detail" fetches uninitialized cpu feature information and thus displays wrong / inconsitent details as below. For eg: FU540-C000 doesn't have any microcode, yet the cmd display's it. => cpu detail 1: cpu@1 rv64imafdc ID = 1, freq = 999.100 MHz: L1 cache, MMU, Microcode, Device ID Microcode version 0x0 Device ID 0x0 2: cpu@2 rv64imafdc ID = 2, freq = 999.100 MHz: L1 cache, MMU, Microcode, Device ID Microcode version 0x0 Device ID 0x0 3: cpu@3 rv64imafdc ID = 3, freq = 999.100 MHz: L1 cache, MMU, Microcode, Device ID Microcode version 0x0 Device ID 0x0 4: cpu@4 rv64imafdc ID = 4, freq = 999.100 MHz: L1 cache, MMU, Microcode, Device ID Microcode version 0x0 Device ID 0x0 The L1 cache or MMU entry seen above is also displayed inconsistently. So initialize cpu information to zero into cpu-uclass itself so that similar issues can be avoided for other CPU drivers. We now see correct features as: => cpu detail 1: cpu@1 rv64imafdc ID = 1, freq = 999.100 MHz 2: cpu@2 rv64imafdc ID = 2, freq = 999.100 MHz 3: cpu@3 rv64imafdc ID = 3, freq = 999.100 MHz 4: cpu@4 rv64imafdc ID = 4, freq = 999.100 MHz Signed-off-by: Sagar Shrikant Kadam Reviewed-by: Pragnesh Patel Reviewed-by: Bin Meng --- drivers/cpu/cpu-uclass.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/cpu/cpu-uclass.c b/drivers/cpu/cpu-uclass.c index 7418c26..9f4a8fd 100644 --- a/drivers/cpu/cpu-uclass.c +++ b/drivers/cpu/cpu-uclass.c @@ -83,6 +83,9 @@ int cpu_get_info(struct udevice *dev, struct cpu_info *info) { struct cpu_ops *ops = cpu_get_ops(dev); + /* Init cpu_info to 0 */ + memset(info, 0, sizeof(struct cpu_info)); + if (!ops->get_info) return -ENOSYS; From patchwork Fri Jun 26 12:39:20 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sagar Shrikant Kadam X-Patchwork-Id: 1317626 X-Patchwork-Delegate: uboot@andestech.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=sifive.com header.i=@sifive.com header.a=rsa-sha256 header.s=selector1 header.b=LAzwKbUJ; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 49tc1v6vsNz9sRN for ; Fri, 26 Jun 2020 22:41:07 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C5C1F801B2; Fri, 26 Jun 2020 14:40:29 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=sifive.com header.i=@sifive.com header.b="LAzwKbUJ"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 4517C81718; Fri, 26 Jun 2020 14:40:08 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-1.3 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,KHOP_HELO_FCRDNS,MSGID_FROM_MTA_HEADER, T_SPF_HELO_TEMPERROR,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on20608.outbound.protection.outlook.com [IPv6:2a01:111:f400:7eaa::608]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D209681009 for ; Fri, 26 Jun 2020 14:39:51 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sagar.kadam@sifive.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JqjcGXx1/hB5KZ4x++6LrClYVQM3miYa4rvwMl3yZXKuKICWDQ9lQWq1Qk+DCWPB8U0Gjjh/Al9kGdt453K9Ir9CDuj4ArYw3nsoUV9BASbSeHdR6Mg/bgxFbkjjPOlTBla9z7pX5yHx3Ef/tWXNVW5oXPVGbN0LqbcS5kEGfbDQGz+SaaeOu3bpRjQOoo9OTIQmEDACj6gYdZGM1oshgn+CIG/bvq7/KPW7/nhNyCJZHE9lp6iLQjBInAd0Hg2NEf3Xv6c+E77+DApYtOE5PTtXR1REAsTbXu6JuPzlP+AxS3vMgfEt2emIgMoE2nYmiTSrP6foORJ+l5rc75Hsyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cdoF3vv69T0dQk5WfqO/I1lYbvDOwC+62lPvWPdfZTE=; b=k/PssMTZ4aCCvfwopUbEP3zRuRme5tXyOg1wsIzwmBVw+YFsMBs01aqTAnJPrjHy8+MW1tCWnNBW8w/JQHcW8jjKNN4+4uDHlHzrT1dxRWceJYdpuQbiysto0OrnXzWwGaVg8q0GzJ+Z7q6F+CzrwninGDUMp0eKkrxX9DbKZ56/i1YvWZEFheN6SbeKg5wSqzYp9CEZl0nfbsxMUvB4RIZ2eVS6H1LZJNPG4/tQW54mQqAFcTWDlao9PbGzpovM/mTRHOlGUrKQMFctOhM+9nv1wLZkBQyaaNTgrMwRz92tEN8Ru6I0iE6xDzu/X8QpOhcD17fk7hX+G6UlqfRiVg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=sifive.com; dmarc=pass action=none header.from=sifive.com; dkim=pass header.d=sifive.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cdoF3vv69T0dQk5WfqO/I1lYbvDOwC+62lPvWPdfZTE=; b=LAzwKbUJcZyb+8/qC+e4WRGRF6Cd7cygUB8EvTYbx+FrdHgcPvu8nIf42t6yp85dcbHJJBXA1O6g6MEF2v9J+c5HxJAfHtwFeB+IdFVpx+aZSvEZV+ULEAQQvRTyR5CxccVBnL+NbGxs3ZyqJSo4NtFzWsf8bf4C845qx/7S86I= Authentication-Results: lists.denx.de; dkim=none (message not signed) header.d=none;lists.denx.de; dmarc=none action=none header.from=sifive.com; Received: from BN8PR13MB2611.namprd13.prod.outlook.com (2603:10b6:408:81::17) by BN6PR13MB1651.namprd13.prod.outlook.com (2603:10b6:404:142::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3153.10; Fri, 26 Jun 2020 12:39:39 +0000 Received: from BN8PR13MB2611.namprd13.prod.outlook.com ([fe80::c1d9:f4ee:80ab:de83]) by BN8PR13MB2611.namprd13.prod.outlook.com ([fe80::c1d9:f4ee:80ab:de83%6]) with mapi id 15.20.3153.010; Fri, 26 Jun 2020 12:39:39 +0000 From: Sagar Shrikant Kadam To: u-boot@lists.denx.de Cc: rick@andestech.com, bin.meng@windriver.com, jagan@amarulasolutions.com, pragnesh.patel@sifive.com, anup.patel@wdc.com, sjg@chromium.org, ye.li@nxp.com, peng.fan@nxp.com, seanga2@gmail.com, Sagar Shrikant Kadam Subject: [PATCH v6 3/4] riscv: cpu: correctly handle the setting of CPU_FEAT_MMU bit Date: Fri, 26 Jun 2020 05:39:20 -0700 Message-Id: <1593175161-26278-4-git-send-email-sagar.kadam@sifive.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1593175161-26278-1-git-send-email-sagar.kadam@sifive.com> References: <1593175161-26278-1-git-send-email-sagar.kadam@sifive.com> X-ClientProxiedBy: BY3PR05CA0027.namprd05.prod.outlook.com (2603:10b6:a03:254::32) To BN8PR13MB2611.namprd13.prod.outlook.com (2603:10b6:408:81::17) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from gamma07.internal.sifive.com (64.62.193.194) by BY3PR05CA0027.namprd05.prod.outlook.com (2603:10b6:a03:254::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.20.3131.12 via Frontend Transport; Fri, 26 Jun 2020 12:39:37 +0000 X-Mailer: git-send-email 2.7.4 X-Originating-IP: [64.62.193.194] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: bd6c8b09-32f0-4d96-39a9-08d819cdfdaf X-MS-TrafficTypeDiagnostic: BN6PR13MB1651: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-Forefront-PRVS: 0446F0FCE1 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ANTJ4mcLqI0F3utMe3CEsy6rUYBSf1TCH34R4jfRpVZTo8jJ8gYI6dzmVBogYUXjSXexPp/zfJmk0un6vbPJgeKCRHRgfAHalG12S0s1MrvCY5GWJx/AtlUF4GCsuIDSL4ufJ45G7UvYLlmpF10Jenuf9fiNEnXSDO3AZhId7j4q8X0ps1Ndov+TxdbovywCrSNpEXkmMVaZTDV2ZspGXr9RtZ4VqB6r2fdfvRyALWsmqL9U8Wwxnu9ypsXRlfa0KWtLQOTX9J3iRSGT4AI2RKjZmUnmwUpHE7jRd2szRgJuau+rSm9fCKMugSNMKZ2mobOo2WPMgyfkvJY1dUMs7w== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN8PR13MB2611.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(346002)(396003)(136003)(39850400004)(366004)(376002)(478600001)(6666004)(186003)(16526019)(5660300002)(107886003)(36756003)(83380400001)(6486002)(66946007)(316002)(86362001)(4326008)(8936002)(6916009)(52116002)(956004)(26005)(7696005)(8676002)(66556008)(2616005)(66476007)(2906002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: A4jgwX1aFQp73rTxLqgCxPBpesFCKANjyjdPbBwG4H+qcVDXY/iS0Od0qolo0VDzeTN96O8/29JFzv7/mlvjSs5JxgQQ+SxagvC0gmw0FfZNfYwpguHjLEGPo8PLnIx+socCzq0Tqxw5dW9tfWxdbb0zGhRGojjkBKvi/AUeIjesVMhY/ixoU1JcSzKwNRKaKTAS8JcQPhvEaK7R0V+209IfEk3eCswStoOrcMwkLqJg1A81OUKFSlbzXdv+OrU+oHvmTIPITh6CZPq7ExV+gp+TGPnJGm53xXPnNZ8IrP0mhE7XLnmYoBgK+SlBcvIfa1I4B9HAPkjmQ98KMCpCCyBjHy5D+xD/ASIKq4da4Q2imc36lU2RKYqWCAMduAHZPFetS8NPPnZGJLXMCuuRA9h81y1SExR4/jANp0GIo2cW49Mx6jRvNHH3fFB3M2B/+DhOHLKFTdpdne4yBiHQXnaY3vMMa5JzMosbiV7G/hI= X-OriginatorOrg: sifive.com X-MS-Exchange-CrossTenant-Network-Message-Id: bd6c8b09-32f0-4d96-39a9-08d819cdfdaf X-MS-Exchange-CrossTenant-AuthSource: BN8PR13MB2611.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jun 2020 12:39:39.0872 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 22f88e9d-ae0d-4ed9-b984-cdc9be1529f1 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: v8nY5FBbrom4BDXKCpEZbLT4g8PUYvYIZiEEKc7j6RN+4F3xB3HdJZhIhFnKjt7MEvk3SCq7LuS+1odtGwZ64A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR13MB1651 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.30rc1 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.2 at phobos.denx.de X-Virus-Status: Clean The conditional check to read "mmu-type" from the device tree is not rightly handled due to which the cpu feature doesn't include CPU_FEAT_MMU even if it's corresponding entry is present in the device tree. The initialization of cpu features is now taken care in cpu-uclass driver, so no need to zero out cpu_freq in riscv_cpu driver and can be removed. Signed-off-by: Sagar Shrikant Kadam Reviewed-by: Pragnesh Patel Reviewed-by: Bin Meng --- drivers/cpu/riscv_cpu.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/cpu/riscv_cpu.c b/drivers/cpu/riscv_cpu.c index 76b0489..112690f 100644 --- a/drivers/cpu/riscv_cpu.c +++ b/drivers/cpu/riscv_cpu.c @@ -36,9 +36,6 @@ static int riscv_cpu_get_info(struct udevice *dev, struct cpu_info *info) struct clk clk; const char *mmu; - /* Zero out the frequency, in case sizeof(ulong) != sizeof(u32) */ - info->cpu_freq = 0; - /* First try getting the frequency from the assigned clock */ ret = clk_get_by_index(dev, 0, &clk); if (!ret) { @@ -52,7 +49,7 @@ static int riscv_cpu_get_info(struct udevice *dev, struct cpu_info *info) dev_read_u32(dev, "clock-frequency", (u32 *)&info->cpu_freq); mmu = dev_read_string(dev, "mmu-type"); - if (!mmu) + if (mmu) info->features |= BIT(CPU_FEAT_MMU); return 0; From patchwork Fri Jun 26 12:39:21 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sagar Shrikant Kadam X-Patchwork-Id: 1317627 X-Patchwork-Delegate: uboot@andestech.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=sifive.com header.i=@sifive.com header.a=rsa-sha256 header.s=selector1 header.b=LBxnYgke; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 49tc292136z9sPF for ; Fri, 26 Jun 2020 22:41:21 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 0649B8168B; Fri, 26 Jun 2020 14:40:40 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=sifive.com header.i=@sifive.com header.b="LBxnYgke"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 69B338179F; Fri, 26 Jun 2020 14:40:09 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-1.3 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,KHOP_HELO_FCRDNS,MSGID_FROM_MTA_HEADER, T_SPF_HELO_TEMPERROR,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on20608.outbound.protection.outlook.com [IPv6:2a01:111:f400:7eaa::608]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 681CB81015 for ; Fri, 26 Jun 2020 14:39:52 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sagar.kadam@sifive.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=S0DcA9AY2feleGiKxCEz1davEyzJ2xykZ5rHN29w3vmquNo7ewfgiDRIlTC3/qFyy1oswc0ZVNfmkkAxvbynrrSt9WoOZ/nHSmnOwvEZdkD+O3dYO6uTtXhHROVw6qZ87ZGt/xpXfz1uGQo2Tz9HgYBCjSrumzB1CoDFIWBbFzbcy6dhGUcWGJeQLjQjlojbpgdFjUoqrgs+zywI6ywGmJEgZxWinijqP8/4W6qm6tZtpjR4eh2gatz0KwGwo7Fr8BA1MYkSyb2YTP0IPMUl8wZCZ26+kBi/WFM4KmA8qxuEk9FqOX40m++SpOOYVgH1M6duJp6FeLFE0DngjtL5Ww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8WTwYwyR8cYD81JXyRGWDd/6ZBl5/FrYJ/7JBo2yovc=; b=k6D8wamV8nGIbjkhX0yBzoYzv8QidALklWku0kMyVTqBqYx/YXg/qsTP4z1do7kTyEbuOTOrE3pBVDy8hAVLsXXmL5lLMqbVWeHpQ+FGyD48G4W4Buv5xopUIczRJs5ESozBXbNciMPy0lPPrJu3KfChODDEx7z8lX+9dGu34JGIPuSv6jx/gqcs1xw5kewVyGOob1tvsa+FT7C5eCD40Vxo5dlCKe5xgOOd33MinT9fcA8S4ZVbvFsfC6ybAWR/7/p5Ah6YcTpQ4VNDZgLFqy/vf8u+57zbEG3WSdJ9GBcJzlo32MEDtrphrpmCih7gJAiuVOe2LEaGowntWtdjnw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=sifive.com; dmarc=pass action=none header.from=sifive.com; dkim=pass header.d=sifive.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8WTwYwyR8cYD81JXyRGWDd/6ZBl5/FrYJ/7JBo2yovc=; b=LBxnYgkeSohTtOiLOBi0gaEk9YIvJmXYekBcjjMlSSWhgh/dKG1Nwe6CLpmQOy8SISwNk6X2AjIoMoeE/uqu4TdprhorucXByKQ11NT1S8zHCQ4YQ9FMNPz3mrdb6/Alqw4P9Fd/xzytcTOerPf+SOzV4zSAUAFR2Hgh0FRbZoY= Authentication-Results: lists.denx.de; dkim=none (message not signed) header.d=none;lists.denx.de; dmarc=none action=none header.from=sifive.com; Received: from BN8PR13MB2611.namprd13.prod.outlook.com (2603:10b6:408:81::17) by BN6PR13MB1651.namprd13.prod.outlook.com (2603:10b6:404:142::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3153.10; Fri, 26 Jun 2020 12:39:41 +0000 Received: from BN8PR13MB2611.namprd13.prod.outlook.com ([fe80::c1d9:f4ee:80ab:de83]) by BN8PR13MB2611.namprd13.prod.outlook.com ([fe80::c1d9:f4ee:80ab:de83%6]) with mapi id 15.20.3153.010; Fri, 26 Jun 2020 12:39:41 +0000 From: Sagar Shrikant Kadam To: u-boot@lists.denx.de Cc: rick@andestech.com, bin.meng@windriver.com, jagan@amarulasolutions.com, pragnesh.patel@sifive.com, anup.patel@wdc.com, sjg@chromium.org, ye.li@nxp.com, peng.fan@nxp.com, seanga2@gmail.com, Sagar Shrikant Kadam Subject: [PATCH v6 4/4] riscv: cpu: check and append L1 cache to cpu features Date: Fri, 26 Jun 2020 05:39:21 -0700 Message-Id: <1593175161-26278-5-git-send-email-sagar.kadam@sifive.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1593175161-26278-1-git-send-email-sagar.kadam@sifive.com> References: <1593175161-26278-1-git-send-email-sagar.kadam@sifive.com> X-ClientProxiedBy: BY3PR05CA0027.namprd05.prod.outlook.com (2603:10b6:a03:254::32) To BN8PR13MB2611.namprd13.prod.outlook.com (2603:10b6:408:81::17) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from gamma07.internal.sifive.com (64.62.193.194) by BY3PR05CA0027.namprd05.prod.outlook.com (2603:10b6:a03:254::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.20.3131.12 via Frontend Transport; Fri, 26 Jun 2020 12:39:40 +0000 X-Mailer: git-send-email 2.7.4 X-Originating-IP: [64.62.193.194] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 258b54a0-3290-4832-2190-08d819cdff4b X-MS-TrafficTypeDiagnostic: BN6PR13MB1651: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2399; X-Forefront-PRVS: 0446F0FCE1 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VYGZSX9lTQBfXA8iGClA+UBI99KWUQCZmSYje2HlGYkbFMuImhedwmOYjaK3PzneYKPIHD8RJTMZF+SzPRHnfrbKU01ySXEBb0fMV2YdBetp1kk71/Rb2y+52sAbWRjJHb+tbbD8GWjF3GYZKlYgvULAF+K0g2WrIpihmYH6ycD2ZQ9w4yaGtDSJ+7wOryUU/ra1xFBJaFcz4RlYHlUJ8tX+fX8a9WaeWXojz1fiJqTgTJ/Zc3kT+Z7iTxBVekhLfKkGrvw99b0Ue/bXJlUqx9M2L3OXJb0o4iXqSbHw4KOl9/Y0eR6CYmpJzyTlWjNwvQZxOIhXthsRkWBjwh9COw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN8PR13MB2611.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(346002)(396003)(136003)(39850400004)(366004)(376002)(478600001)(6666004)(186003)(16526019)(5660300002)(107886003)(36756003)(83380400001)(6486002)(66946007)(316002)(86362001)(4326008)(8936002)(6916009)(52116002)(956004)(26005)(7696005)(8676002)(66556008)(2616005)(66476007)(2906002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: sPCCkDMwjIoc0JA/MiW2ldh236zOMheN77xUfkzsvpg12vnb2nB4WR3v76hBI5GFtH3bOypizJDyg5Yu6Eo0ROMqRKqHTStU7qjMeEKLU3nsif94y8FsSFK7YaNTDUcBAILIXvUV9LmX5+MDTV0XRVEQs//Gumwqw8aJNBx9iAkG5enbstdycj/VZZg/UYjH+8Y8Vm6kD9vc96Zvq9PxV2W9FMHTqr9Yzda3eBC1owWSUFOpeGc88U3POx9PNMJ1pkigW9nF29GyH7kKDBrn2zge4bkN56sK7JmRvee9KfJ90H/dOAVx3ujMhzVVk7zc58nEOsYMF7upuY7KhKnLF0M1j5H9EqEeIwrJgi+fQiLxEDAp449g+hC27Uow7q3yHlGtpro3w9C5loj8/5ygcfA5rQlX/tSo2J9/4tcc87xln6jft7d3abmFg+PM8fsJ8vIbN5tvD25q3lCwy5xmNsVrWT1C8lcyY+x6J1vAKYc= X-OriginatorOrg: sifive.com X-MS-Exchange-CrossTenant-Network-Message-Id: 258b54a0-3290-4832-2190-08d819cdff4b X-MS-Exchange-CrossTenant-AuthSource: BN8PR13MB2611.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jun 2020 12:39:41.7797 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 22f88e9d-ae0d-4ed9-b984-cdc9be1529f1 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: zEk9i+ogrCKKRElJ62Dulg8X6dFDp2hGa1r9A2UB+yjO2zY7cQmIHsPCdbrCKZopo4icjS6K0Ur09J1R787noA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR13MB1651 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.30rc1 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.2 at phobos.denx.de X-Virus-Status: Clean All cpu cores within FU540-C000 having split I/D caches. Set the L1 cache feature bit using the i-cache-size or d-cache-size as one of the property from device tree indicating that L1 cache is present on the cpu core. => cpu detail 1: cpu@1 rv64imafdc ID = 1, freq = 999.100 MHz: L1 cache, MMU 2: cpu@2 rv64imafdc ID = 2, freq = 999.100 MHz: L1 cache, MMU 3: cpu@3 rv64imafdc ID = 3, freq = 999.100 MHz: L1 cache, MMU 4: cpu@4 rv64imafdc ID = 4, freq = 999.100 MHz: L1 cache, MMU Signed-off-by: Sagar Shrikant Kadam Reviewed-by: Pragnesh Patel Reviewed-by: Bin Meng --- drivers/cpu/riscv_cpu.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/drivers/cpu/riscv_cpu.c b/drivers/cpu/riscv_cpu.c index 112690f..100fe55 100644 --- a/drivers/cpu/riscv_cpu.c +++ b/drivers/cpu/riscv_cpu.c @@ -35,6 +35,8 @@ static int riscv_cpu_get_info(struct udevice *dev, struct cpu_info *info) int ret; struct clk clk; const char *mmu; + u32 i_cache_size; + u32 d_cache_size; /* First try getting the frequency from the assigned clock */ ret = clk_get_by_index(dev, 0, &clk); @@ -52,6 +54,16 @@ static int riscv_cpu_get_info(struct udevice *dev, struct cpu_info *info) if (mmu) info->features |= BIT(CPU_FEAT_MMU); + /* check if I cache is present */ + ret = dev_read_u32(dev, "i-cache-size", &i_cache_size); + if (ret) + /* if not found check if d-cache is present */ + ret = dev_read_u32(dev, "d-cache-size", &d_cache_size); + + /* if either I or D cache is present set L1 cache feature */ + if (!ret) + info->features |= BIT(CPU_FEAT_L1_CACHE); + return 0; }