From patchwork Mon Jun 22 20:43:27 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luca Ceresoli X-Patchwork-Id: 1314735 Return-Path: X-Original-To: incoming-dt@patchwork.ozlabs.org Delivered-To: patchwork-incoming-dt@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=devicetree-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=lucaceresoli.net Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 49rLwt6Pr5z9sT8 for ; Tue, 23 Jun 2020 06:43:58 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728799AbgFVUnu (ORCPT ); Mon, 22 Jun 2020 16:43:50 -0400 Received: from hostingweb31-40.netsons.net ([89.40.174.40]:54005 "EHLO hostingweb31-40.netsons.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728707AbgFVUnu (ORCPT ); Mon, 22 Jun 2020 16:43:50 -0400 Received: from [37.163.98.205] (port=42634 helo=melee.dev.aim) by hostingweb31.netsons.net with esmtpa (Exim 4.93) (envelope-from ) id 1jnTI8-00062o-UH; Mon, 22 Jun 2020 22:43:45 +0200 From: Luca Ceresoli To: Liam Girdwood , Mark Brown Cc: Luca Ceresoli , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Lee Jones , Rob Herring , Keerthy , Axel Lin Subject: [PATCH v3 2/4] dt-bindings: mfd: lp87565: convert to yaml Date: Mon, 22 Jun 2020 22:43:27 +0200 Message-Id: <20200622204329.11147-3-luca@lucaceresoli.net> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200622204329.11147-1-luca@lucaceresoli.net> References: <20200622204329.11147-1-luca@lucaceresoli.net> MIME-Version: 1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - hostingweb31.netsons.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lucaceresoli.net X-Get-Message-Sender-Via: hostingweb31.netsons.net: authenticated_id: luca+lucaceresoli.net/only user confirmed/virtual account not confirmed X-Authenticated-Sender: hostingweb31.netsons.net: luca@lucaceresoli.net X-Source: X-Source-Args: X-Source-Dir: Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org The definition of "xxx-in-supply" was generic, thus define in detail the possible cases for each chip variant. Also document that the only possible I2C slave address is 0x60 as per the datasheet and fix the second example accordingly. Signed-off-by: Luca Ceresoli --- Changes in v3: - fix yaml errors Changes in v2: - this patch replaces patch "regulator: lp87565: dt: remove duplicated section" in RFC,v1 (Rob Herring) - use capital letters consistently (Lee Jones) - replace "regulator" -> "mfd" in subject line (Lee Jones) - replace "dt:" suffix with "dt-bindings:" prefix in subject line --- .../devicetree/bindings/mfd/lp87565.txt | 79 ---------- .../devicetree/bindings/mfd/ti,lp875xx.yaml | 142 ++++++++++++++++++ 2 files changed, 142 insertions(+), 79 deletions(-) delete mode 100644 Documentation/devicetree/bindings/mfd/lp87565.txt create mode 100644 Documentation/devicetree/bindings/mfd/ti,lp875xx.yaml diff --git a/Documentation/devicetree/bindings/mfd/lp87565.txt b/Documentation/devicetree/bindings/mfd/lp87565.txt deleted file mode 100644 index 41671e0dc26b..000000000000 --- a/Documentation/devicetree/bindings/mfd/lp87565.txt +++ /dev/null @@ -1,79 +0,0 @@ -TI LP87565 PMIC MFD driver - -Required properties: - - compatible: "ti,lp87565", "ti,lp87565-q1" - - reg: I2C slave address. - - gpio-controller: Marks the device node as a GPIO Controller. - - #gpio-cells: Should be two. The first cell is the pin number and - the second cell is used to specify flags. - See ../gpio/gpio.txt for more information. - - xxx-in-supply: Phandle to parent supply node of each regulator - populated under regulators node. xxx should match - the supply_name populated in driver. -Example: - -lp87565_pmic: pmic@60 { - compatible = "ti,lp87565-q1"; - reg = <0x60>; - gpio-controller; - #gpio-cells = <2>; - - buck10-in-supply = <&vsys_3v3>; - buck23-in-supply = <&vsys_3v3>; - - regulators: regulators { - buck10_reg: buck10 { - /* VDD_MPU */ - regulator-name = "buck10"; - regulator-min-microvolt = <850000>; - regulator-max-microvolt = <1250000>; - regulator-always-on; - regulator-boot-on; - }; - - buck23_reg: buck23 { - /* VDD_GPU */ - regulator-name = "buck23"; - regulator-min-microvolt = <850000>; - regulator-max-microvolt = <1250000>; - regulator-boot-on; - regulator-always-on; - }; - }; -}; - -TI LP87561 PMIC: - -This is a single output 4-phase regulator configuration - -Required properties: - - compatible: "ti,lp87561-q1" - - reg: I2C slave address. - - gpio-controller: Marks the device node as a GPIO Controller. - - #gpio-cells: Should be two. The first cell is the pin number and - the second cell is used to specify flags. - See ../gpio/gpio.txt for more information. - - xxx-in-supply: Phandle to parent supply node of each regulator - populated under regulators node. xxx should match - the supply_name populated in driver. -Example: - -lp87561_pmic: pmic@62 { - compatible = "ti,lp87561-q1"; - reg = <0x62>; - gpio-controller; - #gpio-cells = <2>; - - buck3210-in-supply = <&vsys_3v3>; - - regulators: regulators { - buck3210_reg: buck3210 { - /* VDD_CORE */ - regulator-name = "buck3210"; - regulator-min-microvolt = <800000>; - regulator-max-microvolt = <800000>; - regulator-always-on; - regulator-boot-on; - }; - }; -}; diff --git a/Documentation/devicetree/bindings/mfd/ti,lp875xx.yaml b/Documentation/devicetree/bindings/mfd/ti,lp875xx.yaml new file mode 100644 index 000000000000..2da703918d6a --- /dev/null +++ b/Documentation/devicetree/bindings/mfd/ti,lp875xx.yaml @@ -0,0 +1,142 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/mfd/ti,lp875xx.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: TI LP875xx PMIC MFD driver + +maintainers: + - Keerthy + +properties: + compatible: + oneOf: + - const: ti,lp87565 + - const: ti,lp87565-q1 + - const: ti,lp87561-q1 + + reg: + description: I2C slave address + const: 0x60 + + gpio-controller: true + + '#gpio-cells': + description: + The first cell is the pin number. + The second cell is is used to specify flags. + See ../gpio/gpio.txt for more information. + const: 2 + +required: + - compatible + - reg + - gpio-controller + - '#gpio-cells' + +allOf: + - if: + properties: + compatible: + contains: + enum: + - ti,lp87565 + - ti,lp87565-q1 + then: + properties: + buck10-in-supply: + description: + Phandle to parent supply node for BUCK0 and BUCK1 converters. + + buck23-in-supply: + description: + Phandle to parent supply node for BUCK2 and BUCK3 converters. + + required: + - buck10-in-supply + - buck23-in-supply + + - if: + properties: + compatible: + contains: + enum: + - ti,lp87561-q1 + then: + properties: + buck3210-in-supply: + description: + Phandle to parent supply node for all the four BUCK converters. + + required: + - buck3210-in-supply + +examples: + - | + /* TI LP87565-Q1 PMIC (dual 2-phase output configuration) */ + i2c@0 { + reg = <0x0 0x100>; + #address-cells = <1>; + #size-cells = <0>; + + pmic@60 { + compatible = "ti,lp87565-q1"; + reg = <0x60>; + gpio-controller; + #gpio-cells = <2>; + + buck10-in-supply = <&vsys_3v3>; + buck23-in-supply = <&vsys_3v3>; + + regulators { + buck10_reg: buck10 { + /* VDD_MPU */ + regulator-name = "buck10"; + regulator-min-microvolt = <850000>; + regulator-max-microvolt = <1250000>; + regulator-always-on; + regulator-boot-on; + }; + + buck23_reg: buck23 { + /* VDD_GPU */ + regulator-name = "buck23"; + regulator-min-microvolt = <850000>; + regulator-max-microvolt = <1250000>; + regulator-boot-on; + regulator-always-on; + }; + }; + }; + }; + + - | + /* TI LP87561 PMIC (single 4-phase output configuration) */ + i2c@0 { + reg = <0x0 0x100>; + #address-cells = <1>; + #size-cells = <0>; + + pmic@60 { + compatible = "ti,lp87561-q1"; + reg = <0x60>; + gpio-controller; + #gpio-cells = <2>; + + buck3210-in-supply = <&vsys_3v3>; + + regulators { + buck3210_reg: buck3210 { + /* VDD_CORE */ + regulator-name = "buck3210"; + regulator-min-microvolt = <800000>; + regulator-max-microvolt = <800000>; + regulator-always-on; + regulator-boot-on; + }; + }; + }; + }; + +... From patchwork Mon Jun 22 20:43:28 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luca Ceresoli X-Patchwork-Id: 1314736 Return-Path: X-Original-To: incoming-dt@patchwork.ozlabs.org Delivered-To: patchwork-incoming-dt@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=devicetree-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=lucaceresoli.net Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 49rLwy6Cv5z9sSy for ; Tue, 23 Jun 2020 06:44:02 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728311AbgFVUn6 (ORCPT ); Mon, 22 Jun 2020 16:43:58 -0400 Received: from hostingweb31-40.netsons.net ([89.40.174.40]:41776 "EHLO hostingweb31-40.netsons.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728787AbgFVUnu (ORCPT ); Mon, 22 Jun 2020 16:43:50 -0400 Received: from [37.163.98.205] (port=42634 helo=melee.dev.aim) by hostingweb31.netsons.net with esmtpa (Exim 4.93) (envelope-from ) id 1jnTI9-00062o-Ut; Mon, 22 Jun 2020 22:43:46 +0200 From: Luca Ceresoli To: Liam Girdwood , Mark Brown Cc: Luca Ceresoli , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Lee Jones , Rob Herring , Keerthy , Axel Lin Subject: [PATCH v3 3/4] dt-bindings: mfd: lp87565: add LP87524-Q1 variant Date: Mon, 22 Jun 2020 22:43:28 +0200 Message-Id: <20200622204329.11147-4-luca@lucaceresoli.net> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200622204329.11147-1-luca@lucaceresoli.net> References: <20200622204329.11147-1-luca@lucaceresoli.net> MIME-Version: 1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - hostingweb31.netsons.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lucaceresoli.net X-Get-Message-Sender-Via: hostingweb31.netsons.net: authenticated_id: luca+lucaceresoli.net/only user confirmed/virtual account not confirmed X-Authenticated-Sender: hostingweb31.netsons.net: luca@lucaceresoli.net X-Source: X-Source-Args: X-Source-Dir: Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Add the LP87524-Q1 to the LP87565 bindings document along with an example. Signed-off-by: Luca Ceresoli --- Changes in v3: - fix yaml errors Changes in v2: - RFC,v1 was based on the txt file, rewrite for yaml - use uppercase consistently in model names (Lee Jones) - replace "regulator" -> "mfd" in subject line (Lee Jones) - replace "dt:" suffix with "dt-bindings:" prefix in subject line --- .../devicetree/bindings/mfd/ti,lp875xx.yaml | 83 +++++++++++++++++++ 1 file changed, 83 insertions(+) diff --git a/Documentation/devicetree/bindings/mfd/ti,lp875xx.yaml b/Documentation/devicetree/bindings/mfd/ti,lp875xx.yaml index 2da703918d6a..e6fdf61e89a8 100644 --- a/Documentation/devicetree/bindings/mfd/ti,lp875xx.yaml +++ b/Documentation/devicetree/bindings/mfd/ti,lp875xx.yaml @@ -15,6 +15,7 @@ properties: - const: ti,lp87565 - const: ti,lp87565-q1 - const: ti,lp87561-q1 + - const: ti,lp87524-q1 reg: description: I2C slave address @@ -72,6 +73,36 @@ allOf: required: - buck3210-in-supply + - if: + properties: + compatible: + contains: + enum: + - ti,lp87524-q1 + then: + properties: + buck0-in-supply: + description: + Phandle to parent supply node for the BUCK0 converter. + + buck1-in-supply: + description: + Phandle to parent supply node for the BUCK1 converter. + + buck2-in-supply: + description: + Phandle to parent supply node for the BUCK2 converter. + + buck3-in-supply: + description: + Phandle to parent supply node for the BUCK3 converter. + + required: + - buck0-in-supply + - buck1-in-supply + - buck2-in-supply + - buck3-in-supply + examples: - | /* TI LP87565-Q1 PMIC (dual 2-phase output configuration) */ @@ -139,4 +170,56 @@ examples: }; }; + - | + /* TI LP87524-Q1 PMIC (four 1-phase output configuration) */ + i2c@0 { + reg = <0x0 0x100>; + #address-cells = <1>; + #size-cells = <0>; + + pmic@60 { + compatible = "ti,lp87524-q1"; + reg = <0x60>; + gpio-controller; + #gpio-cells = <2>; + + buck0-in-supply = <&vdd_5v0>; + buck1-in-supply = <&vdd_5v0>; + buck2-in-supply = <&vdd_5v0>; + buck3-in-supply = <&vdd_5v0>; + + regulators { + buck0_reg: buck0 { + regulator-name = "buck0"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + regulator-always-on; + }; + + buck1_reg: buck1 { + regulator-name = "buck1"; + regulator-min-microvolt = <1350000>; + regulator-max-microvolt = <1350000>; + regulator-always-on; + }; + + buck2_reg: buck2 { + regulator-name = "buck2"; + regulator-min-microvolt = <950000>; + regulator-max-microvolt = <950000>; + regulator-always-on; + }; + + buck3_reg: buck3 { + regulator-name = "buck3"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + regulator-always-on; + }; + }; + }; + }; + + + ...