From patchwork Mon Jun 22 01:25:26 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chengguang Xu X-Patchwork-Id: 1314036 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ext4-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=mykernel.net Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=mykernel.net header.i=cgxu519@mykernel.net header.a=rsa-sha256 header.s=zohomail header.b=Es1T5Ito; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 49qsDb1qdfz9sRf for ; Mon, 22 Jun 2020 11:25:51 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730990AbgFVBZt (ORCPT ); Sun, 21 Jun 2020 21:25:49 -0400 Received: from sender2-op-o12.zoho.com.cn ([163.53.93.243]:17134 "EHLO sender2-op-o12.zoho.com.cn" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726603AbgFVBZt (ORCPT ); Sun, 21 Jun 2020 21:25:49 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1592789142; cv=none; d=zoho.com.cn; s=zohoarc; b=nAgALmoUAJXr/CoFtaujNpAHMNvhaptM2+TPW0E79cRP6vyWilUu992sWWoB2Z+L1tLTSaBzzXPngheeN5jZt5zmV3zvL9n/RC5zhsrcRUlSf7av6fbJwcosbRmzzmkAP7MlEc0UE2YVTNPKnqmJ4exXWv+iZA/w7uPVjhDB7yU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com.cn; s=zohoarc; t=1592789142; h=Cc:Date:From:Message-ID:Subject:To; bh=b43/ZsLyB1cGwYIJQZDZaDv/9N8+3bn4PgmRq2R7HeA=; b=W8nAjn01yV3HGqtADQnFJVaFPXkpsspZAdIMfdIb6sPn1hu1F8rIruS4/XN0DwSyZr8oQd2jBTeYSP7JK1lkHSBx28XX83cr3Y9SToy8U9OkLF09H6Y0Nnwl3WWms+2LAXjxEXRC3L2ax6kV0BLCn2OjjtTQqjTdZOSUDStNXWc= ARC-Authentication-Results: i=1; mx.zoho.com.cn; dkim=pass header.i=mykernel.net; spf=pass smtp.mailfrom=cgxu519@mykernel.net; dmarc=pass header.from= header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1592789142; s=zohomail; d=mykernel.net; i=cgxu519@mykernel.net; h=From:To:Cc:Subject:Date:Message-Id; bh=b43/ZsLyB1cGwYIJQZDZaDv/9N8+3bn4PgmRq2R7HeA=; b=Es1T5ItoHbgrcj9Ya3Qi3PprGY7Y0IVbM5ErX2Pfk66Wo7fDwNA28ymYgs4GI+Gp m6joG0Ldl+p0fVFejOKP7zfc6zTDm6u0YFzRrwFMAkXWhJFDd42iJZvT55hFCBCfLu0 ziIsqzCFNBGQMj89KZgmRJsEdRZrbilSsRUKybWU= Received: from localhost.localdomain (113.87.88.87 [113.87.88.87]) by mx.zoho.com.cn with SMTPS id 1592789140551601.152588810136; Mon, 22 Jun 2020 09:25:40 +0800 (CST) From: Chengguang Xu To: jack@suse.com Cc: linux-ext4@vger.kernel.org, Chengguang Xu Subject: [PATCH] ext2: delay discarding block reservation Date: Mon, 22 Jun 2020 09:25:26 +0800 Message-Id: <20200622012526.4688-1-cgxu519@mykernel.net> X-Mailer: git-send-email 2.17.2 X-ZohoCNMailClient: External Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org Currently block reservation will be discard when a write mode file structure is released. It is not efficent for concurrent writing, so change to discard block reservation when last writer release file structure. Signed-off-by: Chengguang Xu --- fs/ext2/file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ext2/file.c b/fs/ext2/file.c index 60378ddf1424..28eaf429138b 100644 --- a/fs/ext2/file.c +++ b/fs/ext2/file.c @@ -139,7 +139,7 @@ static int ext2_file_mmap(struct file *file, struct vm_area_struct *vma) */ static int ext2_release_file (struct inode * inode, struct file * filp) { - if (filp->f_mode & FMODE_WRITE) { + if ((filp->f_mode & FMODE_WRITE) && (atomic_read(&inode->i_writecount) == 1)) { mutex_lock(&EXT2_I(inode)->truncate_mutex); ext2_discard_reservation(inode); mutex_unlock(&EXT2_I(inode)->truncate_mutex);