From patchwork Thu Jun 11 19:44:58 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "H.J. Lu" X-Patchwork-Id: 1307703 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=sourceware.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=sourceware.org; envelope-from=libc-alpha-bounces@sourceware.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=sourceware.org Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=Q37s1irk; dkim-atps=neutral Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 49jZ8564CSz9sRK for ; Fri, 12 Jun 2020 05:45:09 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E9C403898527; Thu, 11 Jun 2020 19:45:03 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E9C403898527 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1591904704; bh=Rc4jLJ9ncCIGpV+FyFodHl1TPcL+h/O+N6Aahd3aSsQ=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=Q37s1irkjCw6aleWw8sBqbvSUPLDeM1mHvVi7hnbysypbQlY2TYFcVj+1OBUXs9sW HJSEY9Ooh4q1iJGbcMsh1ewyOtijHw+ZWr2Pe9/QvgeRtJUvKUiJLPKybGNPG4S5jv ajZOJ1iYvs8UkODniIt8NLVgFyokpJ5g754eRR4A= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-pg1-x543.google.com (mail-pg1-x543.google.com [IPv6:2607:f8b0:4864:20::543]) by sourceware.org (Postfix) with ESMTPS id 3C968386F442 for ; Thu, 11 Jun 2020 19:45:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 3C968386F442 Received: by mail-pg1-x543.google.com with SMTP id w20so2966764pga.6 for ; Thu, 11 Jun 2020 12:45:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=Rc4jLJ9ncCIGpV+FyFodHl1TPcL+h/O+N6Aahd3aSsQ=; b=qMBheqg19u78rV01TThqyTEFrZNXeQpU0mDTmxX75wcLP/SLOjRvjxoloUKNih3Cfu /Vam15zyGif5row+ZSbVp66c0J3+0bzqwZbKyybgyQ92y3mS9L8XQO9XeD3Au8sBAssU mWX8fAHoBrlhlEz1aHv9TBwBTCqaK5aFZNfs2luiHZWWqQsL4wxoAaRzk1nkHL6cB4mO phW8VoQGHl1Zd7/a1N1iQZZBDnbdISNLQywPyJ1+OtoEhmKfiRhSzb+FYWCsBO0AUvBk qBZvghsuGgJYEUallIP+kwLacXtaCcCgW3roFrqlfPJtjS2P/cLiXcEPP2StcHxVYFEu FUrg== X-Gm-Message-State: AOAM530NxSsPXHNLCRCt0sOoWBKoUM4oPqe1QTt+RECpGnjH8E/huDAg bZvOIiP1B/HHtkkXQf3TUS19g15s X-Google-Smtp-Source: ABdhPJyUvg+OTgnV/c1VmFYVJL5hzaBKLI3+lG+UTvc8Tnzp3mvWDpSWM9ydQiDiBmlmRkfrIh2kzw== X-Received: by 2002:aa7:9d9a:: with SMTP id f26mr8327657pfq.229.1591904700092; Thu, 11 Jun 2020 12:45:00 -0700 (PDT) Received: from gnu-cfl-2.localdomain (c-69-181-90-243.hsd1.ca.comcast.net. [69.181.90.243]) by smtp.gmail.com with ESMTPSA id s11sm3722823pfh.204.2020.06.11.12.44.59 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Jun 2020 12:44:59 -0700 (PDT) Received: from gnu-cfl-2.localdomain (localhost [IPv6:::1]) by gnu-cfl-2.localdomain (Postfix) with ESMTP id B0DFC1A014D for ; Thu, 11 Jun 2020 12:44:58 -0700 (PDT) To: libc-alpha@sourceware.org Subject: [PATCH] x86_64: Use %xmmN with vpxor to clear a vector register Date: Thu, 11 Jun 2020 12:44:58 -0700 Message-Id: <20200611194458.216184-1-hjl.tools@gmail.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 X-Spam-Status: No, score=-13.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: "H.J. Lu via Libc-alpha" From: "H.J. Lu" Reply-To: "H.J. Lu" Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" Since "vpxor %xmmN, %xmmN, %xmmN" clears the whole vector register, use %xmmN, instead of %ymmN, with vpxor to clear a vector register. --- sysdeps/x86_64/multiarch/strcmp-avx2.S | 4 ++-- sysdeps/x86_64/multiarch/strrchr-avx2.S | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/sysdeps/x86_64/multiarch/strcmp-avx2.S b/sysdeps/x86_64/multiarch/strcmp-avx2.S index 48d03a9f46..5f88a68262 100644 --- a/sysdeps/x86_64/multiarch/strcmp-avx2.S +++ b/sysdeps/x86_64/multiarch/strcmp-avx2.S @@ -91,8 +91,8 @@ ENTRY (STRCMP) # endif movl %edi, %eax xorl %edx, %edx - /* Make %ymm7 all zeros in this function. */ - vpxor %ymm7, %ymm7, %ymm7 + /* Make %xmm7 (%ymm7) all zeros in this function. */ + vpxor %xmm7, %xmm7, %xmm7 orl %esi, %eax andl $(PAGE_SIZE - 1), %eax cmpl $(PAGE_SIZE - (VEC_SIZE * 4)), %eax diff --git a/sysdeps/x86_64/multiarch/strrchr-avx2.S b/sysdeps/x86_64/multiarch/strrchr-avx2.S index 23077b4c45..146bdd51d0 100644 --- a/sysdeps/x86_64/multiarch/strrchr-avx2.S +++ b/sysdeps/x86_64/multiarch/strrchr-avx2.S @@ -44,7 +44,7 @@ ENTRY (STRRCHR) movl %edi, %ecx /* Broadcast CHAR to YMM4. */ VPBROADCAST %xmm4, %ymm4 - vpxor %ymm0, %ymm0, %ymm0 + vpxor %xmm0, %xmm0, %xmm0 /* Check if we may cross page boundary with one vector load. */ andl $(2 * VEC_SIZE - 1), %ecx