From patchwork Wed Jun 10 09:33:26 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "R. Diez" X-Patchwork-Id: 1306684 X-Patchwork-Delegate: mail@aparcar.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.openwrt.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=lists.openwrt.org Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20170209 header.b=K3nmWK6q; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 49hhdg6P19z9sRh for ; Wed, 10 Jun 2020 19:34:15 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Subject: List-Help:Reply-To:List-Archive:List-Unsubscribe:List-Subscribe:Cc:From: List-Post:List-Id:Message-ID:MIME-Version:References:Date:To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: List-Owner; bh=n3ra6pUiPMcZpydnO2tyeluuvc+LKvgFt3sTebJEpXk=; b=K3nmWK6qrJOwYK n4yfKzZL96TY7qOWTpfAhoc5zv/tGcgCbW3RtMpW0XwFM63Xij5sSk5mAmhEokSHWqzuNgkO2aMnF vRMNcQlIuN9n0Am2OyKoc40Pu2Gum1NcAsINFBfSyk14O2xeDd6ypJUvuOVWb4IEQtGrh451GdvUy 4hC2XvmM2ramyVvVhBrYAUfLz8p9XtLmhLZnkrcXS2M3tuyi/ITp41WlFz/mKcFoZf+oJChmMBuZP nKgpLRCBfKRKQYFsa9ShJoZO0tKFm9wdiFsZgwj5KeuulGj/ZuYzcJ3HpM1QrIsVJ0R3aDRhiE+lx Poib8Yu1DM5AZ7wRyt+w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jix7P-0002bg-Ia; Wed, 10 Jun 2020 09:33:59 +0000 To: openwrt-devel@lists.openwrt.org Date: Wed, 10 Jun 2020 11:33:26 +0200 References: <20200610093326.18897-1-rdiezmail-openwrt.ref@yahoo.com> MIME-Version: 1.0 Message-ID: List-Id: List-Post: X-Patchwork-Original-From: "R. Diez via openwrt-devel" From: "R. Diez" Precedence: list Cc: "R. Diez" X-Mailman-Version: 2.1.29 X-BeenThere: openwrt-devel@lists.openwrt.org List-Subscribe: , List-Unsubscribe: , List-Archive: Reply-To: "R. Diez" List-Help: Subject: [OpenWrt-Devel] [PATCH] build: IS_TTY is now set according to GNU Make's MAKE_TERMOUT Sender: "openwrt-devel" Errors-To: openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org The sender domain has a DMARC Reject/Quarantine policy which disallows sending mailing list messages using the original "From" header. To mitigate this problem, the original message has been wrapped automatically by the mailing list software. Fixes: FS#2086 The logic for IS_TTY was broken, because it was testing stdin instead of stdout. MAKE_TERMOUT was introduced in GNU Make version 4.1 (05 Oct 2014), so it should be available everywhere nowadays. Signed-off-by: R. Diez --- include/toplevel.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/toplevel.mk b/include/toplevel.mk index 5cf93ce7ef..a9c503db61 100644 --- a/include/toplevel.mk +++ b/include/toplevel.mk @@ -8,7 +8,7 @@ PREP_MK= OPENWRT_BUILD= QUIET=0 -export IS_TTY=$(shell tty -s && echo 1 || echo 0) +export IS_TTY=$(if $(MAKE_TERMOUT),1,0) include $(TOPDIR)/include/verbose.mk