From patchwork Mon Dec 11 19:59:53 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin Ian King X-Patchwork-Id: 847203 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=fwts-devel-bounces@lists.ubuntu.com; receiver=) Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) by ozlabs.org (Postfix) with ESMTP id 3ywYlj0bP8z9sP9; Tue, 12 Dec 2017 07:02:40 +1100 (AEDT) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1eOUHf-0000Vm-Pg; Mon, 11 Dec 2017 20:02:39 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.86_2) (envelope-from ) id 1eOUHf-0000Ve-01 for fwts-devel@lists.ubuntu.com; Mon, 11 Dec 2017 20:02:39 +0000 Received: from 1.general.cking.uk.vpn ([10.172.193.212] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.76) (envelope-from ) id 1eOUF0-0005rD-83; Mon, 11 Dec 2017 19:59:54 +0000 From: Colin King To: fwts-devel@lists.ubuntu.com Subject: [PATCH] trival: make read only const strings static Date: Mon, 11 Dec 2017 19:59:53 +0000 Message-Id: <20171211195953.13209-1-colin.king@canonical.com> X-Mailer: git-send-email 2.14.1 MIME-Version: 1.0 X-BeenThere: fwts-devel@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Firmware Test Suite Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: fwts-devel-bounces@lists.ubuntu.com Sender: "fwts-devel" From: Colin Ian King This saves populating the strings on the stack at run time. Signed-off-by: Colin Ian King Acked-by: Alex Hung Acked-by: Ivan Hu --- src/lib/src/fwts_firmware.c | 2 +- src/sbbr/rsdp/rsdp.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/lib/src/fwts_firmware.c b/src/lib/src/fwts_firmware.c index 611ce8f8..bdb65258 100644 --- a/src/lib/src/fwts_firmware.c +++ b/src/lib/src/fwts_firmware.c @@ -89,7 +89,7 @@ int fwts_firmware_features(void) const char *fwts_firmware_feature_string(const fwts_firmware_feature features) { const int n = FWTS_ARRAY_LEN(feature_names); - const char sep[] = ", "; + static const char sep[] = ", "; static char str[60]; size_t len; char *p; diff --git a/src/sbbr/rsdp/rsdp.c b/src/sbbr/rsdp/rsdp.c index 57b95b17..c0589416 100644 --- a/src/sbbr/rsdp/rsdp.c +++ b/src/sbbr/rsdp/rsdp.c @@ -69,7 +69,7 @@ static int rsdp_sbbr_test1(fwts_framework *fw) * 0 to 19, including the checksum field. These bytes must sum to * zero. */ - const char RSDP_SIGNATURE[] = {'R', 'S', 'D', ' ', 'P', 'T', 'R', ' '}; + static const char RSDP_SIGNATURE[] = {'R', 'S', 'D', ' ', 'P', 'T', 'R', ' '}; bool signature_pass = false; bool checksum_pass = false; bool rsdp_revision_pass = false;