From patchwork Sun May 17 09:05:28 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabrice Fontaine X-Patchwork-Id: 1292084 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=busybox.net (client-ip=140.211.166.136; helo=silver.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=uWUI/XIS; dkim-atps=neutral Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 49Px6J4cLFz9sT6 for ; Sun, 17 May 2020 19:04:24 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id E46AF203DE; Sun, 17 May 2020 09:04:16 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gi2we1dqKYgj; Sun, 17 May 2020 09:04:14 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by silver.osuosl.org (Postfix) with ESMTP id ED9D3203C8; Sun, 17 May 2020 09:04:13 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id E28B71BF2EB for ; Sun, 17 May 2020 09:04:12 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id DCFD487E45 for ; Sun, 17 May 2020 09:04:12 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gz7uUx9TePnI for ; Sun, 17 May 2020 09:04:10 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by whitealder.osuosl.org (Postfix) with ESMTPS id AF1D387E2B for ; Sun, 17 May 2020 09:04:09 +0000 (UTC) Received: by mail-wr1-f66.google.com with SMTP id l11so8294370wru.0 for ; Sun, 17 May 2020 02:04:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=L2/Ym2s64/vJExTPn0MPHFiL97mSe+eDiUPwGEeiia0=; b=uWUI/XISoqpa0kXfgw7vL0xWAr2VDINoXCwMIS8sOJNiRFDDdyj2JycahoLsTiLj3F 1CVoK0sTfLZkBRVL4gmaUu8sFu5F2iej6vJ1f3s1TjQagSMIPac60ntdqxhZ4/L2+bd1 5/LhPk08kxIsiDENi1KyuLGNbh4DukejPKbozFZocyFgO/WTuwMCDyMs4mGSA1PV5Pn0 NUeWoipshPCEImqRLueUcUGLXMdhCECryYlrRM894xzDY7KbyW2epYaAPKyXQweeuplU XozfRC+3AUHZNJTVFl2GfvDoQNSWzQH2D9aeNF5TkcTuCDhEUQbN07MT/pz40FcLsVqJ hRmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=L2/Ym2s64/vJExTPn0MPHFiL97mSe+eDiUPwGEeiia0=; b=IWcGEIORKIpSEfr8bhbxCWVRg2YL2TEuptUm1RqH1WhPCUyyHWqmy7Yb0wtEPNTA/j bQILdhkT8MpAfjS8E+zFBGItznEKqoiL7Z1IISqFNWxRFXyrt5JdokLkH884gnlvpA7w xYv/KxgQRX/scUnXesE+G3jzW0vIruIkZWrgKFwR3mDTiAwcpJW6rirExvXPl9Y4ude4 g3wGYOzDDeOFVM8tpt2hKgy+TkNtRg15blryLdevgYByYQqbutWK1QePmyuKmbZ7CMGB qUjyqsKO7F7DQt21cLk1A3u0WY17R9mEjYc1f0pgJ9mSRp/q1WGNgICNV9E4rSL4Ew+r ONcg== X-Gm-Message-State: AOAM532PkazpQT3TjHuqXES1Tyjp/uh5ztEN4dO4p9OXkF8IhSaRzbSA NxQGJ4u/+e36AkbJYqGf9K7N/9RQ X-Google-Smtp-Source: ABdhPJyO0kZotjSBsgQF186feKFnxCJ0+UmwcImhr4KSCYhuwScsuNhbWc7pBGr+JaJ1bT2GFu3vyQ== X-Received: by 2002:adf:9010:: with SMTP id h16mr11641975wrh.412.1589706247733; Sun, 17 May 2020 02:04:07 -0700 (PDT) Received: from kali.home (lfbn-ren-1-2144-158.w92-167.abo.wanadoo.fr. [92.167.223.158]) by smtp.gmail.com with ESMTPSA id b18sm10942105wrn.82.2020.05.17.02.04.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 May 2020 02:04:06 -0700 (PDT) From: Fabrice Fontaine To: buildroot@buildroot.org Date: Sun, 17 May 2020 11:05:28 +0200 Message-Id: <20200517090528.1724124-1-fontaine.fabrice@gmail.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Subject: [Buildroot] [PATCH 1/1] package/usb_modeswitch: fix parallel install X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fabrice Fontaine Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" Extract from bug report: "In usb_modeswitch Makefile dispatcher-script, dispatcher-dynlink and dispatcher-statlink are .PHONY targets. The result is that sources are compiled also when install targets are called. USB_MODESWITCH_INSTALL_TARGET_CMDS calls $(MAKE) which is a call to parallel make eg. make -j9. So the install phase can install empty usb_modeswitch binary (happened once) if the compiler have just cleared the binary and install command installs it before compiler writes the binary. USB_MODESWITCH_INSTALL_TARGET_CMDS should call $(MAKE1)." Instead of disabling parellel install, use install-common target instead of install-{dyn,stat}link targets. Indeed, the dynamic or static usb_modeswitch_dispatcher binary will be built by all-with-{dyn,stat}link-dispatcher targets, there is no need to rebuild it during the install step Fixes: - https://bugs.buildroot.org/show_bug.cgi?id=12911 Signed-off-by: Fabrice Fontaine --- package/usb_modeswitch/usb_modeswitch.mk | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/package/usb_modeswitch/usb_modeswitch.mk b/package/usb_modeswitch/usb_modeswitch.mk index 7e9ed422b6..064e1960b0 100644 --- a/package/usb_modeswitch/usb_modeswitch.mk +++ b/package/usb_modeswitch/usb_modeswitch.mk @@ -17,12 +17,11 @@ USB_MODESWITCH_BUILD_TARGETS = all USB_MODESWITCH_INSTALL_TARGETS = install-script else USB_MODESWITCH_DEPENDENCIES += jimtcl +USB_MODESWITCH_INSTALL_TARGETS = install-common ifeq ($(BR2_STATIC_LIBS),y) USB_MODESWITCH_BUILD_TARGETS = all-with-statlink-dispatcher -USB_MODESWITCH_INSTALL_TARGETS = install-statlink else USB_MODESWITCH_BUILD_TARGETS = all-with-dynlink-dispatcher -USB_MODESWITCH_INSTALL_TARGETS = install-dynlink endif endif