From patchwork Sat May 9 04:35:38 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luis Chamberlain X-Patchwork-Id: 1286532 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 49JvYn52R3z9sSc for ; Sat, 9 May 2020 14:37:17 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728355AbgEIEgF (ORCPT ); Sat, 9 May 2020 00:36:05 -0400 Received: from mail-pg1-f195.google.com ([209.85.215.195]:33239 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726120AbgEIEgE (ORCPT ); Sat, 9 May 2020 00:36:04 -0400 Received: by mail-pg1-f195.google.com with SMTP id a4so1871853pgc.0; Fri, 08 May 2020 21:36:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=cBDEUQMC+fxVo+rJgGTTJoIY6zpQy1pm40eE67u+Uqg=; b=PqTNg7ruGWk3ai1A4d7SqhsimzRkgpjhLulF3FMPBT2EsRC6e/t7UzmS2oPAVr+7A6 jnMA6t7AgURJHyIiReVAnsv7kwzWZs2ItzPGU5FyZjaAMXTk32ucUhJJwSbaAqQ/+lhT YGS91gb1FNfTTZBZeC28JSyG0uQf1rTjhzv8i5RiJdeF2A/CczcWpexrySdLfIFs7BY+ 5NPkHHTkl4hmHWNt4/u6frJsBJAGLd20fJu/c7ONeUcD16YPeJCHSG2+BQZmOgiFuXbi 9Y+/iNS/z1OfkgVAfvOmhr/Z0LlKxvfVl7Tjw71qDXQoMgjO6JABP5SKPovEi2dGuz8k /klw== X-Gm-Message-State: AGi0PuYXf/J4IwfLwWkJJuqdd9hbY6KfP7y3BDdSvQdjbSbs6P7cZsRm eti+HyxjYKTQ/kzYSFYDd+c= X-Google-Smtp-Source: APiQypJjvjDWOMPqgykaQj7RJnenYgarjSOjuLsWtrHeyobTh/wPyLwuHtwWcWuICsu5VeQKOL8DbA== X-Received: by 2002:a62:75d1:: with SMTP id q200mr6142351pfc.238.1588998963744; Fri, 08 May 2020 21:36:03 -0700 (PDT) Received: from 42.do-not-panic.com (42.do-not-panic.com. [157.230.128.187]) by smtp.gmail.com with ESMTPSA id o99sm3682368pjo.8.2020.05.08.21.36.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 May 2020 21:36:01 -0700 (PDT) Received: by 42.do-not-panic.com (Postfix, from userid 1000) id B4C334063E; Sat, 9 May 2020 04:36:00 +0000 (UTC) From: Luis Chamberlain To: jeyu@kernel.org Cc: akpm@linux-foundation.org, arnd@arndb.de, rostedt@goodmis.org, mingo@redhat.com, aquini@redhat.com, cai@lca.pw, dyoung@redhat.com, bhe@redhat.com, peterz@infradead.org, tglx@linutronix.de, gpiccoli@canonical.com, pmladek@suse.com, tiwai@suse.de, schlad@suse.de, andriy.shevchenko@linux.intel.com, keescook@chromium.org, daniel.vetter@ffwll.ch, will@kernel.org, mchehab+samsung@kernel.org, kvalo@codeaurora.org, davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Luis Chamberlain Subject: [PATCH 01/15] taint: add module firmware crash taint support Date: Sat, 9 May 2020 04:35:38 +0000 Message-Id: <20200509043552.8745-2-mcgrof@kernel.org> X-Mailer: git-send-email 2.23.0.rc1 In-Reply-To: <20200509043552.8745-1-mcgrof@kernel.org> References: <20200509043552.8745-1-mcgrof@kernel.org> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Device driver firmware can crash, and sometimes, this can leave your system in a state which makes the device or subsystem completely useless. Detecting this by inspecting /proc/sys/kernel/tainted instead of scraping some magical words from the kernel log, which is driver specific, is much easier. So instead provide a helper which lets drivers annotate this. Once this happens, scrapers can easily look for modules taint flags for a firmware crash. This will taint both the kernel and respective calling module. The new helper module_firmware_crashed() uses LOCKDEP_STILL_OK as this fact should in no way shape or form affect lockdep. This taint is device driver specific. Signed-off-by: Luis Chamberlain --- include/linux/kernel.h | 3 ++- include/linux/module.h | 13 +++++++++++++ include/trace/events/module.h | 3 ++- kernel/module.c | 5 +++-- kernel/panic.c | 1 + 5 files changed, 21 insertions(+), 4 deletions(-) diff --git a/include/linux/kernel.h b/include/linux/kernel.h index 04a5885cec1b..19e1541c82c7 100644 --- a/include/linux/kernel.h +++ b/include/linux/kernel.h @@ -601,7 +601,8 @@ extern enum system_states { #define TAINT_LIVEPATCH 15 #define TAINT_AUX 16 #define TAINT_RANDSTRUCT 17 -#define TAINT_FLAGS_COUNT 18 +#define TAINT_FIRMWARE_CRASH 18 +#define TAINT_FLAGS_COUNT 19 struct taint_flag { char c_true; /* character printed when tainted */ diff --git a/include/linux/module.h b/include/linux/module.h index 2c2e988bcf10..221200078180 100644 --- a/include/linux/module.h +++ b/include/linux/module.h @@ -697,6 +697,14 @@ static inline bool is_livepatch_module(struct module *mod) bool is_module_sig_enforced(void); void set_module_sig_enforced(void); +void add_taint_module(struct module *mod, unsigned flag, + enum lockdep_ok lockdep_ok); + +static inline void module_firmware_crashed(void) +{ + add_taint_module(THIS_MODULE, TAINT_FIRMWARE_CRASH, LOCKDEP_STILL_OK); +} + #else /* !CONFIG_MODULES... */ static inline struct module *__module_address(unsigned long addr) @@ -844,6 +852,11 @@ void *dereference_module_function_descriptor(struct module *mod, void *ptr) return ptr; } +static inline void module_firmware_crashed(void) +{ + add_taint(TAINT_FIRMWARE_CRASH, LOCKDEP_STILL_OK); +} + #endif /* CONFIG_MODULES */ #ifdef CONFIG_SYSFS diff --git a/include/trace/events/module.h b/include/trace/events/module.h index 097485c73c01..b749ea25affd 100644 --- a/include/trace/events/module.h +++ b/include/trace/events/module.h @@ -26,7 +26,8 @@ struct module; { (1UL << TAINT_OOT_MODULE), "O" }, \ { (1UL << TAINT_FORCED_MODULE), "F" }, \ { (1UL << TAINT_CRAP), "C" }, \ - { (1UL << TAINT_UNSIGNED_MODULE), "E" }) + { (1UL << TAINT_UNSIGNED_MODULE), "E" }, \ + { (1UL << TAINT_FIRMWARE_CRASH), "Q" }) TRACE_EVENT(module_load, diff --git a/kernel/module.c b/kernel/module.c index 80faaf2116dd..f98e8c25c6b4 100644 --- a/kernel/module.c +++ b/kernel/module.c @@ -325,12 +325,13 @@ static inline int strong_try_module_get(struct module *mod) return -ENOENT; } -static inline void add_taint_module(struct module *mod, unsigned flag, - enum lockdep_ok lockdep_ok) +void add_taint_module(struct module *mod, unsigned flag, + enum lockdep_ok lockdep_ok) { add_taint(flag, lockdep_ok); set_bit(flag, &mod->taints); } +EXPORT_SYMBOL_GPL(add_taint_module); /* * A thread that wants to hold a reference to a module only while it diff --git a/kernel/panic.c b/kernel/panic.c index ec6d7d788ce7..504fb926947e 100644 --- a/kernel/panic.c +++ b/kernel/panic.c @@ -384,6 +384,7 @@ const struct taint_flag taint_flags[TAINT_FLAGS_COUNT] = { [ TAINT_LIVEPATCH ] = { 'K', ' ', true }, [ TAINT_AUX ] = { 'X', ' ', true }, [ TAINT_RANDSTRUCT ] = { 'T', ' ', true }, + [ TAINT_FIRMWARE_CRASH ] = { 'Q', ' ', true }, }; /** From patchwork Sat May 9 04:35:39 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luis Chamberlain X-Patchwork-Id: 1286519 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 49JvXb4Nq6z9sSt for ; Sat, 9 May 2020 14:36:15 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728662AbgEIEgG (ORCPT ); Sat, 9 May 2020 00:36:06 -0400 Received: from mail-pl1-f193.google.com ([209.85.214.193]:32789 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725795AbgEIEgF (ORCPT ); Sat, 9 May 2020 00:36:05 -0400 Received: by mail-pl1-f193.google.com with SMTP id t7so1642694plr.0; Fri, 08 May 2020 21:36:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=VkP6GWOio7qtVGJiV0OeaEyHuFiaIWKPQxya3i5GDSA=; b=l82iai2dqocs6iEfllINJe0nVEKcCUXwdS5lX4Pjfx0k+/tUN1vHDaBoNrCYxWa2un 94Ph1y67DrIxZDdfUDpHbIqhkWC0yuJ4gpRFGUQl7bFjmHviAh0MB3BPxPTWn+jLUXmg v9W/gZd9Bcy4v7jQUjhQgQRw/KAyx9qYUthUMMmsSB8Vh/ghiACFRPKopHRtbiP8ByHQ PQML9RjuEViYNSrHEv1zl7QXZNwpTQ5z7no6baNrndLk2vEz/3nv/xSqE282n9+UmWcG rcXwxK5TfpKL9ayLxMG25cKRIJmdssADrz3N94OMmrQ9vmic9Hyw7US7d2J/AVG2OwEG Kdfw== X-Gm-Message-State: AGi0Pub8O12eCz0m5xeyuajFUw33pAntvzncej+WQzEJF6toWCq1DVR+ iXFUgOOGU1Q4gcDqxk0oh6s= X-Google-Smtp-Source: APiQypIXyBqaBXyxzVqzZQbND5CCRopwmyiq2AWa34I4lmbuikMQ9/1Jk5F5GGDOQHUv7bOBuauRqA== X-Received: by 2002:a17:90a:3b42:: with SMTP id t2mr9742401pjf.11.1588998964576; Fri, 08 May 2020 21:36:04 -0700 (PDT) Received: from 42.do-not-panic.com (42.do-not-panic.com. [157.230.128.187]) by smtp.gmail.com with ESMTPSA id 138sm3331874pfz.31.2020.05.08.21.36.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 May 2020 21:36:01 -0700 (PDT) Received: by 42.do-not-panic.com (Postfix, from userid 1000) id C70A841405; Sat, 9 May 2020 04:36:00 +0000 (UTC) From: Luis Chamberlain To: jeyu@kernel.org Cc: akpm@linux-foundation.org, arnd@arndb.de, rostedt@goodmis.org, mingo@redhat.com, aquini@redhat.com, cai@lca.pw, dyoung@redhat.com, bhe@redhat.com, peterz@infradead.org, tglx@linutronix.de, gpiccoli@canonical.com, pmladek@suse.com, tiwai@suse.de, schlad@suse.de, andriy.shevchenko@linux.intel.com, keescook@chromium.org, daniel.vetter@ffwll.ch, will@kernel.org, mchehab+samsung@kernel.org, kvalo@codeaurora.org, davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Luis Chamberlain , "Michael S. Tsirkin" , Shannon Nelson , Jakub Kicinski , Heiner Kallweit Subject: [PATCH 02/15] ethernet/839: use new module_firmware_crashed() Date: Sat, 9 May 2020 04:35:39 +0000 Message-Id: <20200509043552.8745-3-mcgrof@kernel.org> X-Mailer: git-send-email 2.23.0.rc1 In-Reply-To: <20200509043552.8745-1-mcgrof@kernel.org> References: <20200509043552.8745-1-mcgrof@kernel.org> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This makes use of the new module_firmware_crashed() to help annotate when firmware for device drivers crash. When firmware crashes devices can sometimes become unresponsive, and recovery sometimes requires a driver unload / reload and in the worst cases a reboot. Using a taint flag allows us to annotate when this happens clearly. Cc: "Michael S. Tsirkin" Cc: Shannon Nelson Cc: Jakub Kicinski Cc: Heiner Kallweit Signed-off-by: Luis Chamberlain --- drivers/net/ethernet/8390/axnet_cs.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/8390/axnet_cs.c b/drivers/net/ethernet/8390/axnet_cs.c index aeae7966a082..8ad0200db8e9 100644 --- a/drivers/net/ethernet/8390/axnet_cs.c +++ b/drivers/net/ethernet/8390/axnet_cs.c @@ -1358,9 +1358,11 @@ static void ei_receive(struct net_device *dev) */ if ((netif_msg_rx_err(ei_local)) && this_frame != ei_local->current_page && - (this_frame != 0x0 || rxing_page != 0xFF)) + (this_frame != 0x0 || rxing_page != 0xFF)) { + module_firmware_crashed(); netdev_err(dev, "mismatched read page pointers %2x vs %2x\n", this_frame, ei_local->current_page); + } if (this_frame == rxing_page) /* Read all the frames? */ break; /* Done for now */ From patchwork Sat May 9 04:35:40 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luis Chamberlain X-Patchwork-Id: 1286520 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 49JvXb71NVz9sSw for ; Sat, 9 May 2020 14:36:15 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728759AbgEIEgJ (ORCPT ); Sat, 9 May 2020 00:36:09 -0400 Received: from mail-pl1-f193.google.com ([209.85.214.193]:37745 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728697AbgEIEgI (ORCPT ); Sat, 9 May 2020 00:36:08 -0400 Received: by mail-pl1-f193.google.com with SMTP id x10so1634669plr.4; Fri, 08 May 2020 21:36:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=520DVozYcI1durffcC1g+bgC7qwaN6rEN099XCz3lNk=; b=ErLBxndXJV/denra0tDJsPiqL7DCh62lu4YZkMmO7wtaJ6MKbMwYqjPYHG29GLBXEm 0RY5cJLk1EmsMKBQe4TBzI705u78YZebiV4VHcG4JC0S8VmjY26zWJRaWkAF0aRXTrcm Lyu25nbQ709R3mH+gUTfb+UcqOnf/kkxW1MjUG+ni4gtQqZOJ3Mxf3tjzeSlAYQOxHVZ jCB6JhhQ4NhVebch6odmUZoWeOgmuNak/QOaIP8hK3KGyPwXbDzqMc6EnMvTrOG04pwx jhfxAeHR8v4YWN6jHVzfPaNAx4pmT5tbnaRrvhJVvn4C1Mpmw6l+Oaz7mbB5rp2OmZea 68mQ== X-Gm-Message-State: AGi0PuZcLklntKBzGvIhQC5xJDZqQvpY842XTdy16plJOLpOsLCD/cTA CmG0DBGox/F6PU/Zej7OnWg= X-Google-Smtp-Source: APiQypLhNxOZ9zSqwOivW1DuzLpv7GJhIJCq/zviwyHl3767b25FTJ1w7h//Pokrb8pRSaOfFnbSnw== X-Received: by 2002:a17:902:7203:: with SMTP id ba3mr5308169plb.202.1588998967262; Fri, 08 May 2020 21:36:07 -0700 (PDT) Received: from 42.do-not-panic.com (42.do-not-panic.com. [157.230.128.187]) by smtp.gmail.com with ESMTPSA id l1sm678301pgj.48.2020.05.08.21.36.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 May 2020 21:36:01 -0700 (PDT) Received: by 42.do-not-panic.com (Postfix, from userid 1000) id D829841D00; Sat, 9 May 2020 04:36:00 +0000 (UTC) From: Luis Chamberlain To: jeyu@kernel.org Cc: akpm@linux-foundation.org, arnd@arndb.de, rostedt@goodmis.org, mingo@redhat.com, aquini@redhat.com, cai@lca.pw, dyoung@redhat.com, bhe@redhat.com, peterz@infradead.org, tglx@linutronix.de, gpiccoli@canonical.com, pmladek@suse.com, tiwai@suse.de, schlad@suse.de, andriy.shevchenko@linux.intel.com, keescook@chromium.org, daniel.vetter@ffwll.ch, will@kernel.org, mchehab+samsung@kernel.org, kvalo@codeaurora.org, davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Luis Chamberlain , Ariel Elior , Sudarsana Kalluru , GR-everest-linux-l2@marvell.com Subject: [PATCH 03/15] bnx2x: use new module_firmware_crashed() Date: Sat, 9 May 2020 04:35:40 +0000 Message-Id: <20200509043552.8745-4-mcgrof@kernel.org> X-Mailer: git-send-email 2.23.0.rc1 In-Reply-To: <20200509043552.8745-1-mcgrof@kernel.org> References: <20200509043552.8745-1-mcgrof@kernel.org> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This makes use of the new module_firmware_crashed() to help annotate when firmware for device drivers crash. When firmware crashes devices can sometimes become unresponsive, and recovery sometimes requires a driver unload / reload and in the worst cases a reboot. Using a taint flag allows us to annotate when this happens clearly. Cc: Ariel Elior Cc: Sudarsana Kalluru CC: GR-everest-linux-l2@marvell.com Signed-off-by: Luis Chamberlain --- drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c index db5107e7937c..c38b8c9c8af0 100644 --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c @@ -909,6 +909,7 @@ void bnx2x_panic_dump(struct bnx2x *bp, bool disable_int) bp->eth_stats.unrecoverable_error++; DP(BNX2X_MSG_STATS, "stats_state - DISABLED\n"); + module_firmware_crashed(); BNX2X_ERR("begin crash dump -----------------\n"); /* Indices */ From patchwork Sat May 9 04:35:41 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luis Chamberlain X-Patchwork-Id: 1286531 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 49JvYj3jsSz9sSc for ; Sat, 9 May 2020 14:37:13 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728737AbgEIEgJ (ORCPT ); Sat, 9 May 2020 00:36:09 -0400 Received: from mail-pj1-f67.google.com ([209.85.216.67]:55093 "EHLO mail-pj1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728681AbgEIEgI (ORCPT ); Sat, 9 May 2020 00:36:08 -0400 Received: by mail-pj1-f67.google.com with SMTP id y6so5221022pjc.4; Fri, 08 May 2020 21:36:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=QJXnP62KLztaJdrV69YlA0+UUHz93O9d1I2NYSRHz+Q=; b=tbS1EfFIyZcCzJujI8tIg9FF2RZ73FXHNCsKckDenoyW9of7sID1TcNeD8099Uo1th 7HGNeyCrF4OXEvhbZlCFOq7Ro9jxUgGodglVZoP8bSc6vtWq57B4SCeSBwuzv6yUZCi7 D1eCzJW8GbVRNx1szSkXT60ARCskOq89eU12FXcUQhjqB0HC0MydesCb5WpTTuO8BpKr Sicza5F8kLqsH3UJe9IYLZoCcebbpYgHpGeLHpVtW6tpfysrAccS4HmF4bnnHTp7Md/q FDAIlYv5GlZWNsFH7G3PnY8e8LJDxyJ5V5Ie4Ck4GzkiwWgvbzS6aco2IA2P2E5NR+/o IzlA== X-Gm-Message-State: AGi0PuYbYnLJFARC7TctpGsOoZ/sI5pypGKOnZvtYCW7H/9CS+V5YlfG rW5QmvmDqqMLN7lHzPSgSAU= X-Google-Smtp-Source: APiQypJphI7aZtPAxu0REWRaFUCZ5/wgOk5Z6Tw6ri2tWqa9HyhgVhQ/qZ4KCgzlvcw+F2p6JthR1w== X-Received: by 2002:a17:902:347:: with SMTP id 65mr5615196pld.21.1588998966510; Fri, 08 May 2020 21:36:06 -0700 (PDT) Received: from 42.do-not-panic.com (42.do-not-panic.com. [157.230.128.187]) by smtp.gmail.com with ESMTPSA id j23sm3622135pjz.13.2020.05.08.21.36.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 May 2020 21:36:01 -0700 (PDT) Received: by 42.do-not-panic.com (Postfix, from userid 1000) id E8A5F41D67; Sat, 9 May 2020 04:36:00 +0000 (UTC) From: Luis Chamberlain To: jeyu@kernel.org Cc: akpm@linux-foundation.org, arnd@arndb.de, rostedt@goodmis.org, mingo@redhat.com, aquini@redhat.com, cai@lca.pw, dyoung@redhat.com, bhe@redhat.com, peterz@infradead.org, tglx@linutronix.de, gpiccoli@canonical.com, pmladek@suse.com, tiwai@suse.de, schlad@suse.de, andriy.shevchenko@linux.intel.com, keescook@chromium.org, daniel.vetter@ffwll.ch, will@kernel.org, mchehab+samsung@kernel.org, kvalo@codeaurora.org, davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Luis Chamberlain , Michael Chan Subject: [PATCH 04/15] bnxt: use new module_firmware_crashed() Date: Sat, 9 May 2020 04:35:41 +0000 Message-Id: <20200509043552.8745-5-mcgrof@kernel.org> X-Mailer: git-send-email 2.23.0.rc1 In-Reply-To: <20200509043552.8745-1-mcgrof@kernel.org> References: <20200509043552.8745-1-mcgrof@kernel.org> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This makes use of the new module_firmware_crashed() to help annotate when firmware for device drivers crash. When firmware crashes devices can sometimes become unresponsive, and recovery sometimes requires a driver unload / reload and in the worst cases a reboot. Using a taint flag allows us to annotate when this happens clearly. Cc: Michael Chan Signed-off-by: Luis Chamberlain --- drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c index dd0c3f227009..5ba1bd0734e9 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c @@ -3503,6 +3503,7 @@ static int bnxt_get_dump_data(struct net_device *dev, struct ethtool_dump *dump, dump->flag = bp->dump_flag; if (dump->flag == BNXT_DUMP_CRASH) { + module_firmware_crashed(); #ifdef CONFIG_TEE_BNXT_FW return tee_bnxt_copy_coredump(buf, 0, dump->len); #endif From patchwork Sat May 9 04:35:42 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luis Chamberlain X-Patchwork-Id: 1286530 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 49JvYZ2ZnDz9sSd for ; Sat, 9 May 2020 14:37:06 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728958AbgEIEhD (ORCPT ); Sat, 9 May 2020 00:37:03 -0400 Received: from mail-pl1-f193.google.com ([209.85.214.193]:46055 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728697AbgEIEgL (ORCPT ); Sat, 9 May 2020 00:36:11 -0400 Received: by mail-pl1-f193.google.com with SMTP id u22so1621274plq.12; Fri, 08 May 2020 21:36:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=0bWWkdX4avF5y+Fhcxc52f0/U6sSEQKpeXYMzsUl/gM=; b=onXWjDsDQ19lnrgOgOm5DLJS6aoEtH60+/dhY2ApBekN6ZRgP0lrtC7tf1Vk2pb7IC vrAgN0B5SRejjc5+KS6i7E5J2Jm2MsykaLC3fYFhucReObh3rTlzaGXCwlWxmqXYALxU b276kqNUd8mOYW2I+nNl/Cqz5GC3VLreOID8DsnoC47sRA640xonaibDS1GwnvZlNmSt w89UOyA71lmgUA6Ht09ywj7BaBhIt9+JpV5qkhSueUjH4LRiXeuqrcnc62fagsOPMoRK ipXzVFoofKuwvePeUV+KUaO5XfFNUfSANHaFFBtnRinfwxvcp9pVQKcXD/C/KV2w02EQ sSuQ== X-Gm-Message-State: AGi0PuY4Nndv18yAdAkH2bFHOSNuT4+6C/ZRhiqUrE/RrTCjCOjn8BY+ RH0AuiuNEianTRjxin3Xi6M= X-Google-Smtp-Source: APiQypLfcLbjKv3FFJ4oeocXRf/+RZKgJAG79optjMrdsbZJP3A/Peyt4yONdPGEF4hTmXY+eOThTA== X-Received: by 2002:a17:902:7b86:: with SMTP id w6mr5516716pll.292.1588998970940; Fri, 08 May 2020 21:36:10 -0700 (PDT) Received: from 42.do-not-panic.com (42.do-not-panic.com. [157.230.128.187]) by smtp.gmail.com with ESMTPSA id f76sm3229588pfa.167.2020.05.08.21.36.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 May 2020 21:36:07 -0700 (PDT) Received: by 42.do-not-panic.com (Postfix, from userid 1000) id 063AB41D95; Sat, 9 May 2020 04:36:01 +0000 (UTC) From: Luis Chamberlain To: jeyu@kernel.org Cc: akpm@linux-foundation.org, arnd@arndb.de, rostedt@goodmis.org, mingo@redhat.com, aquini@redhat.com, cai@lca.pw, dyoung@redhat.com, bhe@redhat.com, peterz@infradead.org, tglx@linutronix.de, gpiccoli@canonical.com, pmladek@suse.com, tiwai@suse.de, schlad@suse.de, andriy.shevchenko@linux.intel.com, keescook@chromium.org, daniel.vetter@ffwll.ch, will@kernel.org, mchehab+samsung@kernel.org, kvalo@codeaurora.org, davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Luis Chamberlain , Rasesh Mody , Sudarsana Kalluru , GR-Linux-NIC-Dev@marvell.com Subject: [PATCH 05/15] bna: use new module_firmware_crashed() Date: Sat, 9 May 2020 04:35:42 +0000 Message-Id: <20200509043552.8745-6-mcgrof@kernel.org> X-Mailer: git-send-email 2.23.0.rc1 In-Reply-To: <20200509043552.8745-1-mcgrof@kernel.org> References: <20200509043552.8745-1-mcgrof@kernel.org> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This makes use of the new module_firmware_crashed() to help annotate when firmware for device drivers crash. When firmware crashes devices can sometimes become unresponsive, and recovery sometimes requires a driver unload / reload and in the worst cases a reboot. Using a taint flag allows us to annotate when this happens clearly. Cc: Rasesh Mody Cc: Sudarsana Kalluru Cc: GR-Linux-NIC-Dev@marvell.com Signed-off-by: Luis Chamberlain --- drivers/net/ethernet/brocade/bna/bfa_ioc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/brocade/bna/bfa_ioc.c b/drivers/net/ethernet/brocade/bna/bfa_ioc.c index e17bfc87da90..b3f44a912574 100644 --- a/drivers/net/ethernet/brocade/bna/bfa_ioc.c +++ b/drivers/net/ethernet/brocade/bna/bfa_ioc.c @@ -927,6 +927,7 @@ bfa_iocpf_sm_disabled(struct bfa_iocpf *iocpf, enum iocpf_event event) static void bfa_iocpf_sm_initfail_sync_entry(struct bfa_iocpf *iocpf) { + module_firmware_crashed(); bfa_nw_ioc_debug_save_ftrc(iocpf->ioc); bfa_ioc_hw_sem_get(iocpf->ioc); } From patchwork Sat May 9 04:35:43 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luis Chamberlain X-Patchwork-Id: 1286521 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 49JvXd0jPKz9sSw for ; Sat, 9 May 2020 14:36:17 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728810AbgEIEgN (ORCPT ); Sat, 9 May 2020 00:36:13 -0400 Received: from mail-pj1-f67.google.com ([209.85.216.67]:33450 "EHLO mail-pj1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728777AbgEIEgK (ORCPT ); Sat, 9 May 2020 00:36:10 -0400 Received: by mail-pj1-f67.google.com with SMTP id 7so5932064pjo.0; Fri, 08 May 2020 21:36:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=MiQNjcOpznNHJIwN/vJ7Wo/YnTDk8aSjxv7fQy7u2y8=; b=lj3luMkOFKQ6cvW2o87kLMdzWKSobF8LVSQeZVveeXbFlTssYOBB+JZ36k9wEupdLR A+OWE/27n04f6grfjCSPXlciSaM+d7uaX9OfsCJv++NQwcUmyKjDowopkWpM5EUOXHWx YnAX5052oHQ+rpTO2+KKyIYBRxJ/IFPo1JZNI0RqlRSQPD0AcBOXsqzf+aebqNwnhmBC 1Vz4V7L4P7W0mlf2kdfmBBKbVLmEeUcdZRLi3GqcWEo30Xoa2PwTTS0/LW3gtLIc1miX qv0WqwOEDshnfvceeZF4Ft35Q36C8K56dd8EMGyPK9SE5ngT/V+EUA6Tmd2vz5KubXtw WruA== X-Gm-Message-State: AGi0PuYbi8N6nakOQ4M+NPvFvWQObbOyyid1GqcR8Llp/gx9oLbUkKY4 ULceZOm0h0VPjiqhnWRjpI8= X-Google-Smtp-Source: APiQypLiur3keFVKRwB2MQgmwWD89BCGfVHpMjRj2wvjmigHkcG0FJgVA9QEo1AVCFJZLcU3k/L7gg== X-Received: by 2002:a17:90a:2450:: with SMTP id h74mr9662376pje.57.1588998970163; Fri, 08 May 2020 21:36:10 -0700 (PDT) Received: from 42.do-not-panic.com (42.do-not-panic.com. [157.230.128.187]) by smtp.gmail.com with ESMTPSA id p24sm3281813pff.92.2020.05.08.21.36.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 May 2020 21:36:07 -0700 (PDT) Received: by 42.do-not-panic.com (Postfix, from userid 1000) id 1208142000; Sat, 9 May 2020 04:36:01 +0000 (UTC) From: Luis Chamberlain To: jeyu@kernel.org Cc: akpm@linux-foundation.org, arnd@arndb.de, rostedt@goodmis.org, mingo@redhat.com, aquini@redhat.com, cai@lca.pw, dyoung@redhat.com, bhe@redhat.com, peterz@infradead.org, tglx@linutronix.de, gpiccoli@canonical.com, pmladek@suse.com, tiwai@suse.de, schlad@suse.de, andriy.shevchenko@linux.intel.com, keescook@chromium.org, daniel.vetter@ffwll.ch, will@kernel.org, mchehab+samsung@kernel.org, kvalo@codeaurora.org, davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Luis Chamberlain , Derek Chickles , Satanand Burla , Felix Manlunas Subject: [PATCH 06/15] liquidio: use new module_firmware_crashed() Date: Sat, 9 May 2020 04:35:43 +0000 Message-Id: <20200509043552.8745-7-mcgrof@kernel.org> X-Mailer: git-send-email 2.23.0.rc1 In-Reply-To: <20200509043552.8745-1-mcgrof@kernel.org> References: <20200509043552.8745-1-mcgrof@kernel.org> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This makes use of the new module_firmware_crashed() to help annotate when firmware for device drivers crash. When firmware crashes devices can sometimes become unresponsive, and recovery sometimes requires a driver unload / reload and in the worst cases a reboot. Using a taint flag allows us to annotate when this happens clearly. Cc: Derek Chickles Cc: Satanand Burla Cc: Felix Manlunas Signed-off-by: Luis Chamberlain --- drivers/net/ethernet/cavium/liquidio/lio_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/cavium/liquidio/lio_main.c b/drivers/net/ethernet/cavium/liquidio/lio_main.c index 66d31c018c7e..f18085262982 100644 --- a/drivers/net/ethernet/cavium/liquidio/lio_main.c +++ b/drivers/net/ethernet/cavium/liquidio/lio_main.c @@ -801,6 +801,7 @@ static int liquidio_watchdog(void *param) continue; WRITE_ONCE(oct->cores_crashed, true); + module_firmware_crashed(); other_oct = get_other_octeon_device(oct); if (other_oct) WRITE_ONCE(other_oct->cores_crashed, true); From patchwork Sat May 9 04:35:44 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luis Chamberlain X-Patchwork-Id: 1286529 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 49JvYT2hyFz9sSt for ; Sat, 9 May 2020 14:37:01 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728945AbgEIEg6 (ORCPT ); Sat, 9 May 2020 00:36:58 -0400 Received: from mail-pj1-f65.google.com ([209.85.216.65]:33924 "EHLO mail-pj1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728789AbgEIEgM (ORCPT ); Sat, 9 May 2020 00:36:12 -0400 Received: by mail-pj1-f65.google.com with SMTP id h12so5932031pjz.1; Fri, 08 May 2020 21:36:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=R8OF7M46D8C3jXOaoBlaMReTLKc3NpL8x+JXeBlXDQg=; b=nvcAwBwQZEc1lhm0aTUd7bqmWD0Ukv1tpbmzlUqeSyXpTDA+DZvi+93KaJ9E/NevpC 5TKMOECAxCbY6REFmzfjSMlemCek0BDCl2RFzzNEkCK4jOEYlM5p8ypzLF4EYMsYaNmx CxwjhmEB4Sp6a4BRn8Z2Yu8z0jMVj3/FjzDq+v/FfLsxlGMre0AHHMfEFv4ZKfXorMs/ pDCFgfZusTAFA5vhzjPACurJMs5t7Y2w7aBDGJ/Pj5lEvNpxUlSrEADrhFSo2QFSyrtG cFqAre0aHMEHqoTWVzHjynCj2Vcwyn8gJs852bApLN/kn/gS+soLCFyLDxunT7whWaPl M6PQ== X-Gm-Message-State: AGi0PuaLZVEv3BxSaTUVVKhbikTTSi1jInjMbCp87xE3HDzOJoIA+XOM 2SB4QkbABAnjSrEmk8Yosf0= X-Google-Smtp-Source: APiQypJSSjbk0NmFTzHRNzIfQCloTXWW0xkAQE1qPeAZ/jpIIOTv5jKkbRXhFpIU2ohllZvSDW+DGw== X-Received: by 2002:a17:902:eb4b:: with SMTP id i11mr5451742pli.19.1588998971874; Fri, 08 May 2020 21:36:11 -0700 (PDT) Received: from 42.do-not-panic.com (42.do-not-panic.com. [157.230.128.187]) by smtp.gmail.com with ESMTPSA id l15sm3565848pjk.56.2020.05.08.21.36.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 May 2020 21:36:07 -0700 (PDT) Received: by 42.do-not-panic.com (Postfix, from userid 1000) id 1D69742079; Sat, 9 May 2020 04:36:01 +0000 (UTC) From: Luis Chamberlain To: jeyu@kernel.org Cc: akpm@linux-foundation.org, arnd@arndb.de, rostedt@goodmis.org, mingo@redhat.com, aquini@redhat.com, cai@lca.pw, dyoung@redhat.com, bhe@redhat.com, peterz@infradead.org, tglx@linutronix.de, gpiccoli@canonical.com, pmladek@suse.com, tiwai@suse.de, schlad@suse.de, andriy.shevchenko@linux.intel.com, keescook@chromium.org, daniel.vetter@ffwll.ch, will@kernel.org, mchehab+samsung@kernel.org, kvalo@codeaurora.org, davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Luis Chamberlain , Vishal Kulkarni Subject: [PATCH 07/15] cxgb4: use new module_firmware_crashed() Date: Sat, 9 May 2020 04:35:44 +0000 Message-Id: <20200509043552.8745-8-mcgrof@kernel.org> X-Mailer: git-send-email 2.23.0.rc1 In-Reply-To: <20200509043552.8745-1-mcgrof@kernel.org> References: <20200509043552.8745-1-mcgrof@kernel.org> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This makes use of the new module_firmware_crashed() to help annotate when firmware for device drivers crash. When firmware crashes devices can sometimes become unresponsive, and recovery sometimes requires a driver unload / reload and in the worst cases a reboot. Using a taint flag allows us to annotate when this happens clearly. Cc: Vishal Kulkarni Signed-off-by: Luis Chamberlain --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c index a70018f067aa..c67fc86c0e42 100644 --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c +++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c @@ -3646,6 +3646,7 @@ void t4_fatal_err(struct adapter *adap) * could be exposed to the adapter. RDMA MWs for example... */ t4_shutdown_adapter(adap); + module_firmware_crashed(); for_each_port(adap, port) { struct net_device *dev = adap->port[port]; From patchwork Sat May 9 04:35:45 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luis Chamberlain X-Patchwork-Id: 1286527 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 49JvYG5qxmz9sSw for ; Sat, 9 May 2020 14:36:50 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728827AbgEIEgR (ORCPT ); Sat, 9 May 2020 00:36:17 -0400 Received: from mail-pl1-f193.google.com ([209.85.214.193]:44575 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728777AbgEIEgO (ORCPT ); Sat, 9 May 2020 00:36:14 -0400 Received: by mail-pl1-f193.google.com with SMTP id b8so1623735plm.11; Fri, 08 May 2020 21:36:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=fkqGWbH5fd6+qOPQE43ttfsUeppV/4L6Bb1ZIdoGWrc=; b=LgvH0QhjjtSDFBKQMOf2MHLZU9gUPc38L1hXb1X5WdNcyKGv+zVdXq4g9y580nFnS7 v0MUQiVP4ATVFg0Su4sjyaKccjliCkHa9uHwPn9VFzs5hMbOTmAGAn2EsUiLoo/aZlNL 9p6Tq6p7T9t43ACDBj+MV2kWQVZDWl6NlXLgODfz1IX9WowbPKeD5spegMdfrDlfRa3V nV0OjXdgBCoEUkZ28x6Z5lZFIbHDiMPJKXhX4YY+6EZgjEXskn4tKpGV9yYOefkB4gzJ Ynea54WsLRenhCxsGqWYOadfGmiBOolXFf7efCf/WXJ3eoZc2cV9/H7HJ9ZQkIlco8uQ yGfw== X-Gm-Message-State: AGi0Pub+hkMRazY5OJfdtnRlQsTLIWGB7eoWZbDM9tRb1BtrGFxDgWh2 LOJnpzCF6D0M59WEH6RFlz0= X-Google-Smtp-Source: APiQypKD38soKAjfYzfpYHiIwmAGTj5kZFhFb+SpFc0hytV+W/MnQnW4pBqhpHlyApNAA3BYg/UBVw== X-Received: by 2002:a17:90a:2401:: with SMTP id h1mr9201853pje.1.1588998973439; Fri, 08 May 2020 21:36:13 -0700 (PDT) Received: from 42.do-not-panic.com (42.do-not-panic.com. [157.230.128.187]) by smtp.gmail.com with ESMTPSA id p8sm3736106pjd.10.2020.05.08.21.36.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 May 2020 21:36:07 -0700 (PDT) Received: by 42.do-not-panic.com (Postfix, from userid 1000) id 28AB74223D; Sat, 9 May 2020 04:36:01 +0000 (UTC) From: Luis Chamberlain To: jeyu@kernel.org Cc: akpm@linux-foundation.org, arnd@arndb.de, rostedt@goodmis.org, mingo@redhat.com, aquini@redhat.com, cai@lca.pw, dyoung@redhat.com, bhe@redhat.com, peterz@infradead.org, tglx@linutronix.de, gpiccoli@canonical.com, pmladek@suse.com, tiwai@suse.de, schlad@suse.de, andriy.shevchenko@linux.intel.com, keescook@chromium.org, daniel.vetter@ffwll.ch, will@kernel.org, mchehab+samsung@kernel.org, kvalo@codeaurora.org, davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Luis Chamberlain , Douglas Miller Subject: [PATCH 08/15] ehea: use new module_firmware_crashed() Date: Sat, 9 May 2020 04:35:45 +0000 Message-Id: <20200509043552.8745-9-mcgrof@kernel.org> X-Mailer: git-send-email 2.23.0.rc1 In-Reply-To: <20200509043552.8745-1-mcgrof@kernel.org> References: <20200509043552.8745-1-mcgrof@kernel.org> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This makes use of the new module_firmware_crashed() to help annotate when firmware for device drivers crash. When firmware crashes devices can sometimes become unresponsive, and recovery sometimes requires a driver unload / reload and in the worst cases a reboot. Using a taint flag allows us to annotate when this happens clearly. Cc: Douglas Miller Signed-off-by: Luis Chamberlain --- drivers/net/ethernet/ibm/ehea/ehea_main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/ibm/ehea/ehea_main.c b/drivers/net/ethernet/ibm/ehea/ehea_main.c index 0273fb7a9d01..6ae35067003f 100644 --- a/drivers/net/ethernet/ibm/ehea/ehea_main.c +++ b/drivers/net/ethernet/ibm/ehea/ehea_main.c @@ -3285,6 +3285,8 @@ static void ehea_crash_handler(void) { int i; + module_firmware_crashed(); + if (ehea_fw_handles.arr) for (i = 0; i < ehea_fw_handles.num_entries; i++) ehea_h_free_resource(ehea_fw_handles.arr[i].adh, From patchwork Sat May 9 04:35:46 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luis Chamberlain X-Patchwork-Id: 1286522 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 49JvXh0bfQz9sSc for ; Sat, 9 May 2020 14:36:20 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728845AbgEIEgS (ORCPT ); Sat, 9 May 2020 00:36:18 -0400 Received: from mail-pj1-f66.google.com ([209.85.216.66]:55657 "EHLO mail-pj1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728811AbgEIEgQ (ORCPT ); Sat, 9 May 2020 00:36:16 -0400 Received: by mail-pj1-f66.google.com with SMTP id k7so229117pjs.5; Fri, 08 May 2020 21:36:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=k0XUPR8gTRBaK/zVNrQDrzctO9dsoRkXZA68QpWb+cw=; b=hJ0h2BDp55l7fsTlVfnT9HPmIM8rGMSS2nIYaU6P5Xz/m4ewUhNIT2dernZJNy2ulm UJueO0sAGESaVpd+TKmt6ziykKlHrgGW/wRflARfQF093mDTFWGg4xVf6jPlLCdrtKN/ VgEnOQZSEJRS7wTGGFTeQbcW9sGu91vc+eQBKFV19JEU1zd/MW9E3wQDdpUVs1yviBSU VFAWF74ajS4jdeG3WagsBf56lTT2XGTktTFtZHXSzn9cVd8JQGV/GzRY8XvoDP0aHWwB Jmb7e1RbUule8TUmeNQIJpUomFA4Kb+ePi9YAzmiQP2X627izT2GtlD7AAPGnW9ZDUoT RMJQ== X-Gm-Message-State: AGi0PuYOhFrYUlLMLALcR8Mhj8upw071mYQfGQTIENMJGvC4+gyURe+e 97XW1UXrgPHCw0FV9KpA10s= X-Google-Smtp-Source: APiQypIpLPKRngDi2nwKB/l9ruVNOfAboQdFftzYLEjRsOGUFsV5rsG+XovjkSD/u+zzSn9mOCV65w== X-Received: by 2002:a17:90a:498a:: with SMTP id d10mr10105139pjh.194.1588998974401; Fri, 08 May 2020 21:36:14 -0700 (PDT) Received: from 42.do-not-panic.com (42.do-not-panic.com. [157.230.128.187]) by smtp.gmail.com with ESMTPSA id 1sm3248272pff.151.2020.05.08.21.36.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 May 2020 21:36:07 -0700 (PDT) Received: by 42.do-not-panic.com (Postfix, from userid 1000) id 34880422E5; Sat, 9 May 2020 04:36:01 +0000 (UTC) From: Luis Chamberlain To: jeyu@kernel.org Cc: akpm@linux-foundation.org, arnd@arndb.de, rostedt@goodmis.org, mingo@redhat.com, aquini@redhat.com, cai@lca.pw, dyoung@redhat.com, bhe@redhat.com, peterz@infradead.org, tglx@linutronix.de, gpiccoli@canonical.com, pmladek@suse.com, tiwai@suse.de, schlad@suse.de, andriy.shevchenko@linux.intel.com, keescook@chromium.org, daniel.vetter@ffwll.ch, will@kernel.org, mchehab+samsung@kernel.org, kvalo@codeaurora.org, davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Luis Chamberlain , Ariel Elior , GR-everest-linux-l2@marvell.com Subject: [PATCH 09/15] qed: use new module_firmware_crashed() Date: Sat, 9 May 2020 04:35:46 +0000 Message-Id: <20200509043552.8745-10-mcgrof@kernel.org> X-Mailer: git-send-email 2.23.0.rc1 In-Reply-To: <20200509043552.8745-1-mcgrof@kernel.org> References: <20200509043552.8745-1-mcgrof@kernel.org> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This makes use of the new module_firmware_crashed() to help annotate when firmware for device drivers crash. When firmware crashes devices can sometimes become unresponsive, and recovery sometimes requires a driver unload / reload and in the worst cases a reboot. Using a taint flag allows us to annotate when this happens clearly. Cc: Ariel Elior Cc: GR-everest-linux-l2@marvell.com Signed-off-by: Luis Chamberlain --- drivers/net/ethernet/qlogic/qed/qed_debug.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/qlogic/qed/qed_debug.c b/drivers/net/ethernet/qlogic/qed/qed_debug.c index f4eebaabb6d0..9cc6287b889b 100644 --- a/drivers/net/ethernet/qlogic/qed/qed_debug.c +++ b/drivers/net/ethernet/qlogic/qed/qed_debug.c @@ -7854,6 +7854,7 @@ int qed_dbg_all_data(struct qed_dev *cdev, void *buffer) REGDUMP_HEADER_SIZE, &feature_size); if (!rc) { + module_firmware_crashed(); *(u32 *)((u8 *)buffer + offset) = qed_calc_regdump_header(cdev, PROTECTION_OVERRIDE, cur_engine, @@ -7869,6 +7870,7 @@ int qed_dbg_all_data(struct qed_dev *cdev, void *buffer) rc = qed_dbg_fw_asserts(cdev, (u8 *)buffer + offset + REGDUMP_HEADER_SIZE, &feature_size); if (!rc) { + module_firmware_crashed(); *(u32 *)((u8 *)buffer + offset) = qed_calc_regdump_header(cdev, FW_ASSERTS, cur_engine, feature_size, @@ -7906,6 +7908,7 @@ int qed_dbg_all_data(struct qed_dev *cdev, void *buffer) rc = qed_dbg_grc(cdev, (u8 *)buffer + offset + REGDUMP_HEADER_SIZE, &feature_size); if (!rc) { + module_firmware_crashed(); *(u32 *)((u8 *)buffer + offset) = qed_calc_regdump_header(cdev, GRC_DUMP, cur_engine, From patchwork Sat May 9 04:35:47 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luis Chamberlain X-Patchwork-Id: 1286528 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 49JvYL56K5z9sSw for ; Sat, 9 May 2020 14:36:54 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728932AbgEIEgv (ORCPT ); Sat, 9 May 2020 00:36:51 -0400 Received: from mail-pf1-f193.google.com ([209.85.210.193]:33126 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728817AbgEIEgR (ORCPT ); Sat, 9 May 2020 00:36:17 -0400 Received: by mail-pf1-f193.google.com with SMTP id x77so2064725pfc.0; Fri, 08 May 2020 21:36:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=6nV8PMylqoFPDUoYFmy1R2d+sPYm3cn1hK2t9F4BUt8=; b=Al0rNm92TXFjSiIFvJIeTtAlfdJZtazQ9V5vFaLzkrTWcbCWNzMCV3xWR8gzpJRTtl NEaO3UK6caLkbxCep9aN9FiNAaGho3TYOauTsKCOR9R7VB+t2ea+ettH7jYpg78nuvms AGyJ9vKJfwyj9aGh7zV7MU16IJ8fGpV0esaaVbRmjyFaB1C7cUnsG2TKFKOevB8QwQq3 EPqYYSSuX+qOoyrsWjcH2obVy+8Cz1SPlH6a1kHd0Sbf3Shi52TKxEYKQYsVhvqnvb8r 5IIQKF4U6JVOc65gFQDavrtnoKgEv7NiGt3VFt7YF6AUCi7D+TrhAAhP3W3HcLHdV+Cp VBVQ== X-Gm-Message-State: AGi0PuaZrvUuOJwS/HokYR34C7lElu0Z2xpUAMw05U+JNKEnmIzDQWvw RlbM1s9h2ClHzffn+YzfhHY= X-Google-Smtp-Source: APiQypKuG4kUhajeiVgN6J0AzzPbQ1GumNkGw3hrb/Pw+IiX28oIrHhxd4xUHRvYtWchrnwtXqLRiw== X-Received: by 2002:a62:2582:: with SMTP id l124mr77401pfl.308.1588998975368; Fri, 08 May 2020 21:36:15 -0700 (PDT) Received: from 42.do-not-panic.com (42.do-not-panic.com. [157.230.128.187]) by smtp.gmail.com with ESMTPSA id o140sm592530pfd.176.2020.05.08.21.36.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 May 2020 21:36:07 -0700 (PDT) Received: by 42.do-not-panic.com (Postfix, from userid 1000) id 3F16642309; Sat, 9 May 2020 04:36:01 +0000 (UTC) From: Luis Chamberlain To: jeyu@kernel.org Cc: akpm@linux-foundation.org, arnd@arndb.de, rostedt@goodmis.org, mingo@redhat.com, aquini@redhat.com, cai@lca.pw, dyoung@redhat.com, bhe@redhat.com, peterz@infradead.org, tglx@linutronix.de, gpiccoli@canonical.com, pmladek@suse.com, tiwai@suse.de, schlad@suse.de, andriy.shevchenko@linux.intel.com, keescook@chromium.org, daniel.vetter@ffwll.ch, will@kernel.org, mchehab+samsung@kernel.org, kvalo@codeaurora.org, davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Luis Chamberlain , Alex Elder Subject: [PATCH 10/15] soc: qcom: ipa: use new module_firmware_crashed() Date: Sat, 9 May 2020 04:35:47 +0000 Message-Id: <20200509043552.8745-11-mcgrof@kernel.org> X-Mailer: git-send-email 2.23.0.rc1 In-Reply-To: <20200509043552.8745-1-mcgrof@kernel.org> References: <20200509043552.8745-1-mcgrof@kernel.org> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This makes use of the new module_firmware_crashed() to help annotate when firmware for device drivers crash. When firmware crashes devices can sometimes become unresponsive, and recovery sometimes requires a driver unload / reload and in the worst cases a reboot. Using a taint flag allows us to annotate when this happens clearly. Cc: Alex Elder Signed-off-by: Luis Chamberlain --- drivers/net/ipa/ipa_modem.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ipa/ipa_modem.c b/drivers/net/ipa/ipa_modem.c index ed10818dd99f..1790b87446ed 100644 --- a/drivers/net/ipa/ipa_modem.c +++ b/drivers/net/ipa/ipa_modem.c @@ -285,6 +285,7 @@ static void ipa_modem_crashed(struct ipa *ipa) struct device *dev = &ipa->pdev->dev; int ret; + module_firmware_crashed(); ipa_endpoint_modem_pause_all(ipa, true); ipa_endpoint_modem_hol_block_clear_all(ipa); From patchwork Sat May 9 04:35:48 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luis Chamberlain X-Patchwork-Id: 1286525 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 49JvY42ThSz9sT0 for ; Sat, 9 May 2020 14:36:40 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728903AbgEIEgh (ORCPT ); Sat, 9 May 2020 00:36:37 -0400 Received: from mail-pj1-f67.google.com ([209.85.216.67]:37786 "EHLO mail-pj1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728837AbgEIEgS (ORCPT ); Sat, 9 May 2020 00:36:18 -0400 Received: by mail-pj1-f67.google.com with SMTP id a7so5212352pju.2; Fri, 08 May 2020 21:36:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=d9Crehj1GSqNkWIBx6oBRWEIaOhUeDUKthtt6ioogWY=; b=iSgZ8VMUNNC1vroyE9p1khznIlmX9vwLXbbgnX/9ozZLBrD80Q+i0uYt5Hy8mMC47w oQ/NSF5/CMuVv7HZWvuoEjO9e8DTWVZI9ShhoSOrCBjVmActPlq1jf+bDrsX4Ac51yFW L3QMNpyJi4AWBLmLmOjml/XkrZ/j6YEg6v7bIBcAExuqwxglZGqHeK9hF2BjKrGZE+b5 Q65UwqdlszmJpzBTEqbzsYS8+FtncJu85zVQOUKu7/hmxkOQFLSAdrWtAXS2N7UBGfMI 0eaE3BXZ9NjK0M4nLhh9Ge8R4FtCyQoqNRnzkUy8Nfh9P/mT06x1TLdSuhxVnqj7e2PG Phvg== X-Gm-Message-State: AGi0PuaMrL8ryUsniBCP4a1A4NU3gu4TugicBKqonCCUHypVAvq91lbp hqmOQw33gHgpVVX+wy2XBO4= X-Google-Smtp-Source: APiQypIU4o32j8RS8tQB2eiEqmJBzdWhDYA6pQVk2wb8WK8zzJKAF2L1MoxxJEX40cb2k4hlTVBl6w== X-Received: by 2002:a17:902:b945:: with SMTP id h5mr5552788pls.224.1588998978020; Fri, 08 May 2020 21:36:18 -0700 (PDT) Received: from 42.do-not-panic.com (42.do-not-panic.com. [157.230.128.187]) by smtp.gmail.com with ESMTPSA id o17sm2598387pgv.83.2020.05.08.21.36.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 May 2020 21:36:15 -0700 (PDT) Received: by 42.do-not-panic.com (Postfix, from userid 1000) id 4B2314230A; Sat, 9 May 2020 04:36:01 +0000 (UTC) From: Luis Chamberlain To: jeyu@kernel.org Cc: akpm@linux-foundation.org, arnd@arndb.de, rostedt@goodmis.org, mingo@redhat.com, aquini@redhat.com, cai@lca.pw, dyoung@redhat.com, bhe@redhat.com, peterz@infradead.org, tglx@linutronix.de, gpiccoli@canonical.com, pmladek@suse.com, tiwai@suse.de, schlad@suse.de, andriy.shevchenko@linux.intel.com, keescook@chromium.org, daniel.vetter@ffwll.ch, will@kernel.org, mchehab+samsung@kernel.org, kvalo@codeaurora.org, davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Luis Chamberlain , linux-wimax@intel.com, Inaky Perez-Gonzalez Subject: [PATCH 11/15] wimax/i2400m: use new module_firmware_crashed() Date: Sat, 9 May 2020 04:35:48 +0000 Message-Id: <20200509043552.8745-12-mcgrof@kernel.org> X-Mailer: git-send-email 2.23.0.rc1 In-Reply-To: <20200509043552.8745-1-mcgrof@kernel.org> References: <20200509043552.8745-1-mcgrof@kernel.org> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This makes use of the new module_firmware_crashed() to help annotate when firmware for device drivers crash. When firmware crashes devices can sometimes become unresponsive, and recovery sometimes requires a driver unload / reload and in the worst cases a reboot. Using a taint flag allows us to annotate when this happens clearly. Cc: linux-wimax@intel.com Cc: Inaky Perez-Gonzalez Signed-off-by: Luis Chamberlain --- drivers/net/wimax/i2400m/rx.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wimax/i2400m/rx.c b/drivers/net/wimax/i2400m/rx.c index c9fb619a9e01..307a62ca183f 100644 --- a/drivers/net/wimax/i2400m/rx.c +++ b/drivers/net/wimax/i2400m/rx.c @@ -712,6 +712,7 @@ void __i2400m_roq_queue(struct i2400m *i2400m, struct i2400m_roq *roq, dev_err(dev, "SW BUG? failed to insert packet\n"); dev_err(dev, "ERX: roq %p [ws %u] skb %p nsn %d sn %u\n", roq, roq->ws, skb, nsn, roq_data->sn); + module_firmware_crashed(); skb_queue_walk(&roq->queue, skb_itr) { roq_data_itr = (struct i2400m_roq_data *) &skb_itr->cb; nsn_itr = __i2400m_roq_nsn(roq, roq_data_itr->sn); From patchwork Sat May 9 04:35:49 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luis Chamberlain X-Patchwork-Id: 1286535 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 49Jvld71Yyz9sSd for ; Sat, 9 May 2020 14:45:49 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726980AbgEIEpp (ORCPT ); Sat, 9 May 2020 00:45:45 -0400 Received: from mail-pj1-f68.google.com ([209.85.216.68]:52441 "EHLO mail-pj1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725795AbgEIEpp (ORCPT ); Sat, 9 May 2020 00:45:45 -0400 Received: by mail-pj1-f68.google.com with SMTP id a5so5227716pjh.2; Fri, 08 May 2020 21:45:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=npAHADQxLDEpywMh/GQmSV8cKhjaz9uo2pCJ37X1d7Q=; b=kYhjC2EBjfqXoUxy/zTQ4+eiC42XU2VTyClMoza3b5B+lwSLp/pHM7DMgZ1a1KiBIa WoK2xvFhVw2P+QNluVDvFW9Ht35ULTfrM7U9xn2QM+htptM3Wh94p0hO99VdZQ3sjLvI p++9H47Rq0EhVMgiZhbQmDRxfIxnVHH9xYP9ML/S1pItRwX7KG0Obs2xRIUeQwzUzE5f 3gGj+m3KvZ5cDQhiYUi5f0GhfMRamsIlvh43A3TBki6sMkAry6BOyixXXv79zx59dAcv iRczBExRBCPiseIjKSm/c0vXMIDUhkT3hVYjEwUxBbUX9HdADoOcOBDk/RKnbs41ZnmR zR/w== X-Gm-Message-State: AGi0Pub57GCEKRc6UK0BEzENjDcSZ8p65ZiUhNUJpzXJfYK7snH3Tskd k/Z3rxJ2biXi2joFlE2fD9E= X-Google-Smtp-Source: APiQypLw6+nO2U4QWAJVDVbU2UVUQLz4x2Pd3twtzhhiEU7+VFbAvujZRZehlC9onWqGj3VvwxWp/A== X-Received: by 2002:a17:902:ff09:: with SMTP id f9mr5748286plj.236.1588999542861; Fri, 08 May 2020 21:45:42 -0700 (PDT) Received: from 42.do-not-panic.com (42.do-not-panic.com. [157.230.128.187]) by smtp.gmail.com with ESMTPSA id h13sm2547498pgm.69.2020.05.08.21.45.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 May 2020 21:45:41 -0700 (PDT) Received: by 42.do-not-panic.com (Postfix, from userid 1000) id 54DB142337; Sat, 9 May 2020 04:36:01 +0000 (UTC) From: Luis Chamberlain To: jeyu@kernel.org Cc: akpm@linux-foundation.org, arnd@arndb.de, rostedt@goodmis.org, mingo@redhat.com, aquini@redhat.com, cai@lca.pw, dyoung@redhat.com, bhe@redhat.com, peterz@infradead.org, tglx@linutronix.de, gpiccoli@canonical.com, pmladek@suse.com, tiwai@suse.de, schlad@suse.de, andriy.shevchenko@linux.intel.com, keescook@chromium.org, daniel.vetter@ffwll.ch, will@kernel.org, mchehab+samsung@kernel.org, kvalo@codeaurora.org, davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Luis Chamberlain , linux-wireless@vger.kernel.org, ath10k@lists.infradead.org Subject: [PATCH 12/15] ath10k: use new module_firmware_crashed() Date: Sat, 9 May 2020 04:35:49 +0000 Message-Id: <20200509043552.8745-13-mcgrof@kernel.org> X-Mailer: git-send-email 2.23.0.rc1 In-Reply-To: <20200509043552.8745-1-mcgrof@kernel.org> References: <20200509043552.8745-1-mcgrof@kernel.org> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This makes use of the new module_firmware_crashed() to help annotate when firmware for device drivers crash. When firmware crashes devices can sometimes become unresponsive, and recovery sometimes requires a driver unload / reload and in the worst cases a reboot. Using a taint flag allows us to annotate when this happens clearly. Cc: linux-wireless@vger.kernel.org Cc: ath10k@lists.infradead.org Cc: Kalle Valo Signed-off-by: Luis Chamberlain --- drivers/net/wireless/ath/ath10k/pci.c | 2 ++ drivers/net/wireless/ath/ath10k/sdio.c | 2 ++ drivers/net/wireless/ath/ath10k/snoc.c | 1 + 3 files changed, 5 insertions(+) diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath/ath10k/pci.c index 1d941d53fdc9..6bd0f3b518b9 100644 --- a/drivers/net/wireless/ath/ath10k/pci.c +++ b/drivers/net/wireless/ath/ath10k/pci.c @@ -1767,6 +1767,7 @@ static void ath10k_pci_fw_dump_work(struct work_struct *work) scnprintf(guid, sizeof(guid), "n/a"); ath10k_err(ar, "firmware crashed! (guid %s)\n", guid); + module_firmware_crashed(); ath10k_print_driver_info(ar); ath10k_pci_dump_registers(ar, crash_data); ath10k_ce_dump_registers(ar, crash_data); @@ -2837,6 +2838,7 @@ static int ath10k_pci_hif_power_up(struct ath10k *ar, if (ret) { if (ath10k_pci_has_fw_crashed(ar)) { ath10k_warn(ar, "firmware crashed during chip reset\n"); + module_firmware_crashed(); ath10k_pci_fw_crashed_clear(ar); ath10k_pci_fw_crashed_dump(ar); } diff --git a/drivers/net/wireless/ath/ath10k/sdio.c b/drivers/net/wireless/ath/ath10k/sdio.c index e2aff2254a40..d34ad289380f 100644 --- a/drivers/net/wireless/ath/ath10k/sdio.c +++ b/drivers/net/wireless/ath/ath10k/sdio.c @@ -794,6 +794,7 @@ static int ath10k_sdio_mbox_proc_dbg_intr(struct ath10k *ar) /* TODO: Add firmware crash handling */ ath10k_warn(ar, "firmware crashed\n"); + module_firmware_crashed(); /* read counter to clear the interrupt, the debug error interrupt is * counter 0. @@ -915,6 +916,7 @@ static int ath10k_sdio_mbox_proc_cpu_intr(struct ath10k *ar) if (cpu_int_status & MBOX_CPU_STATUS_ENABLE_ASSERT_MASK) { ath10k_err(ar, "firmware crashed!\n"); queue_work(ar->workqueue, &ar->restart_work); + module_firmware_crashed(); } return ret; } diff --git a/drivers/net/wireless/ath/ath10k/snoc.c b/drivers/net/wireless/ath/ath10k/snoc.c index 354d49b1cd45..7cfc123c345c 100644 --- a/drivers/net/wireless/ath/ath10k/snoc.c +++ b/drivers/net/wireless/ath/ath10k/snoc.c @@ -1451,6 +1451,7 @@ void ath10k_snoc_fw_crashed_dump(struct ath10k *ar) scnprintf(guid, sizeof(guid), "n/a"); ath10k_err(ar, "firmware crashed! (guid %s)\n", guid); + module_firmware_crashed(); ath10k_print_driver_info(ar); ath10k_msa_dump_memory(ar, crash_data); mutex_unlock(&ar->dump_mutex); From patchwork Sat May 9 04:35:50 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luis Chamberlain X-Patchwork-Id: 1286526 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 49JvYC0nqNz9sSw for ; Sat, 9 May 2020 14:36:47 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728922AbgEIEgo (ORCPT ); Sat, 9 May 2020 00:36:44 -0400 Received: from mail-pg1-f194.google.com ([209.85.215.194]:36822 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728829AbgEIEgR (ORCPT ); Sat, 9 May 2020 00:36:17 -0400 Received: by mail-pg1-f194.google.com with SMTP id d22so1864357pgk.3; Fri, 08 May 2020 21:36:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=myNCixB4Wt/Dj4YEDmqFhw0GwtgJlBYyFB3jPG3Nx54=; b=S/AmHP6+zrcaIXvIcu7pyIQgx6ANOJ4aHgaR4hZ8EKZ3YDfJhubIGPg2k4206PMW++ Fz1MmA+v8xW//HRr/rQhyDtSDCeiUbPkNKBFEAv7jFzZ2BE9lyEseDG71cKf0CBIs7mf 4P5aOVfsgSZMdwlKH5c0SozwySebE+l89mF6k5+eAne0HprByyqPmsTxsjGP/JDlD58X 1vUnaWHPqs2jeaUcsP79w9xu8bDlLc2h/xQDC/Vf4FtmeUBSWR3K/ocg8YvmSvcCRUpy bpe7rT+qbzDxXoCJa64BqiHzUuonF8vmkbxBjWTKHubdcN6E+llC8aruHk4Wb/ivZENF BBkA== X-Gm-Message-State: AGi0PuZGKyFBfZjTIfWWNF58W9Lv/wOpqeaKAVTCvYBymtSjke9iLiGY 4ih7KoAd0Ud2hD2cSeUdJtVZaZ5xbvvW2g== X-Google-Smtp-Source: APiQypLM8elFsSmsIb97VrDyhu+XcSDHVdS0mODbH0OjwWueTY6Rt/ao0SdaeJu6GXa/+IQBQp9rMg== X-Received: by 2002:a63:1820:: with SMTP id y32mr4836345pgl.182.1588998977066; Fri, 08 May 2020 21:36:17 -0700 (PDT) Received: from 42.do-not-panic.com (42.do-not-panic.com. [157.230.128.187]) by smtp.gmail.com with ESMTPSA id h6sm3719180pje.37.2020.05.08.21.36.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 May 2020 21:36:15 -0700 (PDT) Received: by 42.do-not-panic.com (Postfix, from userid 1000) id 5F7E742340; Sat, 9 May 2020 04:36:01 +0000 (UTC) From: Luis Chamberlain To: jeyu@kernel.org Cc: akpm@linux-foundation.org, arnd@arndb.de, rostedt@goodmis.org, mingo@redhat.com, aquini@redhat.com, cai@lca.pw, dyoung@redhat.com, bhe@redhat.com, peterz@infradead.org, tglx@linutronix.de, gpiccoli@canonical.com, pmladek@suse.com, tiwai@suse.de, schlad@suse.de, andriy.shevchenko@linux.intel.com, keescook@chromium.org, daniel.vetter@ffwll.ch, will@kernel.org, mchehab+samsung@kernel.org, kvalo@codeaurora.org, davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Luis Chamberlain , linux-wireless@vger.kernel.org, ath10k@lists.infradead.org Subject: [PATCH 13/15] ath6kl: use new module_firmware_crashed() Date: Sat, 9 May 2020 04:35:50 +0000 Message-Id: <20200509043552.8745-14-mcgrof@kernel.org> X-Mailer: git-send-email 2.23.0.rc1 In-Reply-To: <20200509043552.8745-1-mcgrof@kernel.org> References: <20200509043552.8745-1-mcgrof@kernel.org> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This makes use of the new module_firmware_crashed() to help annotate when firmware for device drivers crash. When firmware crashes devices can sometimes become unresponsive, and recovery sometimes requires a driver unload / reload and in the worst cases a reboot. Using a taint flag allows us to annotate when this happens clearly. Cc: linux-wireless@vger.kernel.org Cc: ath10k@lists.infradead.org Cc: Kalle Valo Signed-off-by: Luis Chamberlain --- drivers/net/wireless/ath/ath6kl/hif.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/ath/ath6kl/hif.c b/drivers/net/wireless/ath/ath6kl/hif.c index d1942537ea10..cfd838607544 100644 --- a/drivers/net/wireless/ath/ath6kl/hif.c +++ b/drivers/net/wireless/ath/ath6kl/hif.c @@ -120,6 +120,7 @@ static int ath6kl_hif_proc_dbg_intr(struct ath6kl_device *dev) int ret; ath6kl_warn("firmware crashed\n"); + module_firmware_crashed(); /* * read counter to clear the interrupt, the debug error interrupt is From patchwork Sat May 9 04:35:51 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Luis Chamberlain X-Patchwork-Id: 1286524 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 49JvXs5cPJz9sSg for ; Sat, 9 May 2020 14:36:29 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728887AbgEIEg2 (ORCPT ); Sat, 9 May 2020 00:36:28 -0400 Received: from mail-pj1-f66.google.com ([209.85.216.66]:53153 "EHLO mail-pj1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728852AbgEIEgV (ORCPT ); Sat, 9 May 2020 00:36:21 -0400 Received: by mail-pj1-f66.google.com with SMTP id a5so5222430pjh.2; Fri, 08 May 2020 21:36:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=7qq8CjFpGo8CsnGjybDf2MvNxEFQWkR0c2M9w7bQbfM=; b=XwKUKBbP35FmqQ3Ugi0gHKS86zf+FQUKbBIwofqqjb6PBPikVJcfGpeYB06mEbXnib DQkD+dXiY024LW9+cJ6wfxlmDMY/QbUN+QC2JuPKlxd1e1J9zErHf8MEkaQP5yv+p2Rc qdCfaTH6I0VHMrfZhS5dL69wKYWsKJQaQSe20Tp4es88uWJJMvGBtLmcVFo76g7cYJrg PTJ2ddtC/lacLBX1AiGd0y3T0/OiWhedEv0E2J6R2W63lysY3tRZhxI/B+BaEFEoVAa+ tOWNLCKu0CFKS1pgv8AQpD+NU9PRjhKHfF08hkBz4x1MWRa567Q7fcnzo0gspyg4uVZp 90Pg== X-Gm-Message-State: AGi0PuYUWgPOfirt2JIN3SWLNNozbJcUkuSUO2T2R8F0jqao91r+HxTb 8Kw4Yho6E/Te/6G895b7yaE= X-Google-Smtp-Source: APiQypLjmRNDTEznZjzA3S9166t5JFNaclA+EPQ0OH8e1pQEJSa/LM2UXqofDkr98aCEqoNdflNEOg== X-Received: by 2002:a17:90a:d0c3:: with SMTP id y3mr9417112pjw.25.1588998980730; Fri, 08 May 2020 21:36:20 -0700 (PDT) Received: from 42.do-not-panic.com (42.do-not-panic.com. [157.230.128.187]) by smtp.gmail.com with ESMTPSA id z28sm3318243pfr.3.2020.05.08.21.36.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 May 2020 21:36:15 -0700 (PDT) Received: by 42.do-not-panic.com (Postfix, from userid 1000) id 6A8F942341; Sat, 9 May 2020 04:36:01 +0000 (UTC) From: Luis Chamberlain To: jeyu@kernel.org Cc: akpm@linux-foundation.org, arnd@arndb.de, rostedt@goodmis.org, mingo@redhat.com, aquini@redhat.com, cai@lca.pw, dyoung@redhat.com, bhe@redhat.com, peterz@infradead.org, tglx@linutronix.de, gpiccoli@canonical.com, pmladek@suse.com, tiwai@suse.de, schlad@suse.de, andriy.shevchenko@linux.intel.com, keescook@chromium.org, daniel.vetter@ffwll.ch, will@kernel.org, mchehab+samsung@kernel.org, kvalo@codeaurora.org, davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Luis Chamberlain , linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, brcm80211-dev-list@cypress.com, Arend van Spriel , Franky Lin , Hante Meuleman , Chi-Hsien Lin , Wright Feng , =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= , Pieter-Paul Giesberts Subject: [PATCH 14/15] brcm80211: use new module_firmware_crashed() Date: Sat, 9 May 2020 04:35:51 +0000 Message-Id: <20200509043552.8745-15-mcgrof@kernel.org> X-Mailer: git-send-email 2.23.0.rc1 In-Reply-To: <20200509043552.8745-1-mcgrof@kernel.org> References: <20200509043552.8745-1-mcgrof@kernel.org> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This makes use of the new module_firmware_crashed() to help annotate when firmware for device drivers crash. When firmware crashes devices can sometimes become unresponsive, and recovery sometimes requires a driver unload / reload and in the worst cases a reboot. Using a taint flag allows us to annotate when this happens clearly. Cc: linux-wireless@vger.kernel.org Cc: brcm80211-dev-list.pdl@broadcom.com Cc: brcm80211-dev-list@cypress.com Cc: Arend van Spriel Cc: Franky Lin Cc: Hante Meuleman Cc: Chi-Hsien Lin Cc: Wright Feng Cc: Kalle Valo Cc: "Rafał Miłecki" Cc: Pieter-Paul Giesberts Signed-off-by: Luis Chamberlain --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c index c88655acc78c..d623f83568b3 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c @@ -1393,6 +1393,7 @@ void brcmf_fw_crashed(struct device *dev) struct brcmf_pub *drvr = bus_if->drvr; bphy_err(drvr, "Firmware has halted or crashed\n"); + module_firmware_crashed(); brcmf_dev_coredump(dev); From patchwork Sat May 9 04:35:52 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luis Chamberlain X-Patchwork-Id: 1286523 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 49JvXn287Bz9sSg for ; Sat, 9 May 2020 14:36:25 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728866AbgEIEgW (ORCPT ); Sat, 9 May 2020 00:36:22 -0400 Received: from mail-pl1-f196.google.com ([209.85.214.196]:43377 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728846AbgEIEgT (ORCPT ); Sat, 9 May 2020 00:36:19 -0400 Received: by mail-pl1-f196.google.com with SMTP id z6so1625457plk.10; Fri, 08 May 2020 21:36:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=WzAUhm9PAzr7uU8H1Lc2ngEyBupzXwHNyDw+1FmrAuk=; b=ABo2hpRjR7QwDjQAzeVuBVN1+ujsAAnhezO+qg1r3MO1zyxXMWsonIYOiPhSECGsLQ kQ76j5GjlBCf6W1vpagB4SE8W5Dx9bRdB+8RzZhV6MMmboiZ9eALX7JE2MwBQAiNHMe1 J36mVZlOf6FPKwLJodnBjwcfpv55x7hMCfYRQE9YbwtRNT5DfpECsTQAalBAeQgG+JU7 C4Dwel2wfOZpGjBvbMJUOxx9fmnjD874Iw21JqoVc+pPyMzS4u7o8Vvl2Lf8bZ9tX4T2 G3+AD0DeQ8hz89fLXfNEZbIg2YzIUH1o+2qKOT1jzKzC/MQWkJ283b+LI8vhRes+QwCm ldXQ== X-Gm-Message-State: AGi0PuY6fLMTaLNQ2HrtvXDqfM8Ri5e9i8v/X5tFsHa2geKEJYQt5NmT C6wLYzBrJZ0Rdx9SSd09Q18= X-Google-Smtp-Source: APiQypLTFb2RAG3FyXNjeEw4HN1+FeVK1th9HhFtNsa33Z6gZafA063iGaEXxunyudg4OhViLAcglQ== X-Received: by 2002:a17:90b:19c9:: with SMTP id nm9mr9798057pjb.86.1588998978909; Fri, 08 May 2020 21:36:18 -0700 (PDT) Received: from 42.do-not-panic.com (42.do-not-panic.com. [157.230.128.187]) by smtp.gmail.com with ESMTPSA id b20sm3293544pff.8.2020.05.08.21.36.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 May 2020 21:36:15 -0700 (PDT) Received: by 42.do-not-panic.com (Postfix, from userid 1000) id 76BD542349; Sat, 9 May 2020 04:36:01 +0000 (UTC) From: Luis Chamberlain To: jeyu@kernel.org Cc: akpm@linux-foundation.org, arnd@arndb.de, rostedt@goodmis.org, mingo@redhat.com, aquini@redhat.com, cai@lca.pw, dyoung@redhat.com, bhe@redhat.com, peterz@infradead.org, tglx@linutronix.de, gpiccoli@canonical.com, pmladek@suse.com, tiwai@suse.de, schlad@suse.de, andriy.shevchenko@linux.intel.com, keescook@chromium.org, daniel.vetter@ffwll.ch, will@kernel.org, mchehab+samsung@kernel.org, kvalo@codeaurora.org, davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Luis Chamberlain , linux-wireless@vger.kernel.org, Lennert Buytenhek , "Gustavo A. R. Silva" , Johannes Berg , Ganapathi Bhat Subject: [PATCH 15/15] mwl8k: use new module_firmware_crashed() Date: Sat, 9 May 2020 04:35:52 +0000 Message-Id: <20200509043552.8745-16-mcgrof@kernel.org> X-Mailer: git-send-email 2.23.0.rc1 In-Reply-To: <20200509043552.8745-1-mcgrof@kernel.org> References: <20200509043552.8745-1-mcgrof@kernel.org> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This makes use of the new module_firmware_crashed() to help annotate when firmware for device drivers crash. When firmware crashes devices can sometimes become unresponsive, and recovery sometimes requires a driver unload / reload and in the worst cases a reboot. Using a taint flag allows us to annotate when this happens clearly. Cc: linux-wireless@vger.kernel.org Cc: Lennert Buytenhek Cc: Kalle Valo Cc: "Gustavo A. R. Silva" Cc: Johannes Berg Cc: Ganapathi Bhat Signed-off-by: Luis Chamberlain --- drivers/net/wireless/marvell/mwl8k.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/marvell/mwl8k.c b/drivers/net/wireless/marvell/mwl8k.c index 97f23f93f6e7..d609ef1bb879 100644 --- a/drivers/net/wireless/marvell/mwl8k.c +++ b/drivers/net/wireless/marvell/mwl8k.c @@ -1551,6 +1551,7 @@ static int mwl8k_tx_wait_empty(struct ieee80211_hw *hw) * the firmware has crashed */ if (priv->hw_restart_in_progress) { + module_firmware_crashed(); if (priv->hw_restart_owner == current) return 0; else