From patchwork Thu Apr 30 19:03:48 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Kiszka X-Patchwork-Id: 1280832 X-Patchwork-Delegate: lokeshvutla@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=web.de Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=web.de header.i=@web.de header.a=rsa-sha256 header.s=dbaedf251592 header.b=JUae4uT4; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 49ClD049mrz9sRf for ; Fri, 1 May 2020 05:04:00 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1BE4B81FCD; Thu, 30 Apr 2020 21:03:56 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=web.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=web.de header.i=@web.de header.b="JUae4uT4"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 2CD5582063; Thu, 30 Apr 2020 21:03:54 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from mout.web.de (mout.web.de [212.227.17.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 6D1AE81F7F for ; Thu, 30 Apr 2020 21:03:51 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=web.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=jan.kiszka@web.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1588273429; bh=djlTCyLPCCgZUGs79n1YKTYy7vxnSXGxYYQTIP/vnmE=; h=X-UI-Sender-Class:To:Cc:From:Subject:Date; b=JUae4uT4x6j7lq4H2rPFwzauUyhI9fai/I7T1FQ7vsoV5ihiISVFaF43s0XNQAQbu DN0kkAjpegrkdxSmrxoxdgzlqBiD0p3xi2oslJXQcwYvgss2E8KY4I+MsJDBI9Ksci kA0mtA0llOsY46pQJfBInGffZDtFkvqdAeZwlGAA= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from [192.168.1.10] ([95.157.53.180]) by smtp.web.de (mrweb105 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MJFhJ-1jiswg0qEN-00KgYt; Thu, 30 Apr 2020 21:03:49 +0200 To: "Andrew F. Davis" Cc: Andreas Dannenberg , Lokesh Vutla , U-Boot Mailing List From: Jan Kiszka Subject: am65x build issues Message-ID: <04446bbd-6858-b8ba-0328-ba7c10291d68@web.de> Date: Thu, 30 Apr 2020 21:03:48 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 Content-Language: en-US X-Provags-ID: V03:K1:vWbsmuLKCZ2KoC1JMRMqu2sLPRjb7s7j2u6xqER1DyvyZ9xPVnn +3srtbEb1pbko04v3TgJZfcLh7orLOMTLX3yV8trU6QM6COMMQ7MOCGYEzykyFIvx0xUiy5 pTUlD5A5eoEGDZylRqWV9xdPn98kHEKKx7pW6eKDeMUbUweQ5rkKYr02PbysY4+HjGk9v50 k3JM3NA11VICHPfo1SLVA== X-UI-Out-Filterresults: notjunk:1;V03:K0:BvBMfpRA3BQ=:vDhWHNFtmis3wiuIxGbgYz UgMQuvRB203FBbHojrTB6pqIbjlwmnc9/ekENVau57iHqo6SPaz6Nn15RdPMe2VuxMkLg5bFI 6Jjhv8HD+fH6G5CKC9uViYNEka38xf2VXQiAcAhv5ND7D/coX1vCdPflTQpdx4XO3M+NnDZ9G MkRqBbjTkjiUkowIsBOZa36ZOmENk/iDmzHeo4SheIVuFYcNbSLA5a+e3SV5K0FzXh55EMa4H RLXz9qa8A8jN+cYakaVkxAiPNtShXaVozFdnNiRsN5gtOPOr9gljKwHZnPtwAhP58apjN6D8+ iw8O8PHMhmwQUBh4reg/pSiZfgXKSTJEe0H6FiGX0pwdIP40x4vtbAkD6RYC4+DzSIoQittsP uPIMczXaz6tg3//I2mnJZQ8vAuuIrI0e93w4zZEBnEcFBN7rTEkQm+/p/n3LYVwHucWyQQnVE i9urWbazEP3sj7+SY/j+sB92QKgf6VhwTW/gJ4WrXaCawnoOoDxpUKkgZdVnAtkVDEwA/GIhk M2Bdyo3rpaoTzUWQEtNJ0ihu41I0MVdu/S+49uoUiGGbbFSvn8q7dUXmE27YVaiwQz7cXr7nR x+KUaMNNb9dKON+zq3eNGKIRAmBv9nECeRoOVipJY9oYhYYeXWYWliWBYL4yBgQWM47Yv/mRE L2SW/27c3NPt3zH1d+fPnqv2MBr0HA0fDijYmQL8vfASq0Dc2Ejdz8aWDoBTBJieIiq+Y/xTD a00RfJsNDOcF82GE3liARKSK2SUyVQqVXnbzwhr95paEqctkrYYj/st15LyhTAEXJj118gHt4 KJPzhlKSqqGoC1BCXtVZLwqQdEF5I5e3v5/Fv1OJ6wNfsU758SNlg4ly8cB45diPuuiDD8iBA DeyhGEhIAFX4hNDxyrMYvF283r5jiSJyNm3OLOHijZn3nWyPBxe4wsTG+DjbzjpNvqtxdCofE X9tUR0uCTyBNfflHbcHglFGRcwTZEqiPE54ug+4ks6jPgvt8fqosVF30teqMW+PtGaedrTqS5 Jyyynw+YrpWsaK4pOhXETaZ1SZdeRjKqBYl5vBMAwG70mpJ4A5cPip22SwaJfg3V5lbz5tTAF aqLfP56lSKLXTChkD6HtEZEmqVLbgXE7QSpqHbvVMBPPOok51XFq6/OhVaOmfkXhV9OW7/C4j sJ3OSFTh9RovfWMcdPHCYh/MpnQO8dLp/p0qxLyC+jMvyvsKg1NN0dEk8lD92oZvbjvWmfroG dqxAZJX6NaKsircRS X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.30rc1 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.2 at phobos.denx.de X-Virus-Status: Clean Hi all, I've noticed that building am65x_evm_a53_defconfig causes the dtbs to be built twice, once for the main u-boot and once for the spl. This is because of an extra dependency in mach-k3/config_secure.mk added by 508369672ca3. Why should the produced dtbs depend on the target that produces them? Why not simply this? Disclaimer: I didn't actually test the HS path, just the unsigned build. But also with this change, make -j remains broken for this target: [...] COPY u-boot.dtb MKIMAGE u-boot-dtb.img MKIMAGE u-boot.img CAT u-boot-dtb.bin COPY u-boot.bin CC spl/./lib/asm-offsets.s CC spl/./arch/arm/lib/asm-offsets.s ../tools/k3_fit_atf.sh \ spl/dts/k3-am654-base-board.dtb > u-boot-spl-k3.its LDS spl/u-boot-spl.lds FDTGREP spl/dts/k3-am654-base-board.dtb Usage: fdtgrep - extract portions from device tree [...] Error: Cannot open output file make[2]: *** [../scripts/Makefile.spl:465: spl/dts/k3-am654-base-board.dtb] Error 1 make[2]: *** Waiting for unfinished jobs.... Something is fishy with dependencies here. Any ideas? Thanks, Jan diff --git a/arch/arm/mach-k3/config_secure.mk b/arch/arm/mach-k3/config_secure.mk index 6d63c57665..cbe9b684fb 100644 --- a/arch/arm/mach-k3/config_secure.mk +++ b/arch/arm/mach-k3/config_secure.mk @@ -34,11 +34,8 @@ MKIMAGEFLAGS_u-boot.img_HS = -f auto -A $(ARCH) -T firmware -C none -O u-boot \ -n "U-Boot $(UBOOTRELEASE) for $(BOARD) board" -E \ $(patsubst %,-b arch/$(ARCH)/dts/%.dtb_HS,$(subst ",,$(CONFIG_OF_LIST))) -OF_LIST_TARGETS = $(patsubst %,arch/$(ARCH)/dts/%.dtb,$(subst ",,$(CONFIG_OF_LIST))) -$(OF_LIST_TARGETS): dtbs - u-boot-nodtb.bin_HS: u-boot-nodtb.bin FORCE $(call if_changed,k3secureimg) -u-boot.img_HS: u-boot-nodtb.bin_HS u-boot.img $(patsubst %.dtb,%.dtb_HS,$(OF_LIST_TARGETS)) FORCE +u-boot.img_HS: u-boot-nodtb.bin_HS u-boot.img dtbs FORCE $(call if_changed,mkimage)