From patchwork Wed Apr 22 10:10:24 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eugeniu Rosca X-Patchwork-Id: 1274932 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=de.adit-jv.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 496cgV2t9Nz9sSq for ; Wed, 22 Apr 2020 20:51:34 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732016AbgDVKv3 (ORCPT ); Wed, 22 Apr 2020 06:51:29 -0400 Received: from smtp1.de.adit-jv.com ([93.241.18.167]:57705 "EHLO smtp1.de.adit-jv.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728659AbgDVKLN (ORCPT ); Wed, 22 Apr 2020 06:11:13 -0400 Received: from localhost (smtp1.de.adit-jv.com [127.0.0.1]) by smtp1.de.adit-jv.com (Postfix) with ESMTP id D64783C004C; Wed, 22 Apr 2020 12:11:10 +0200 (CEST) Received: from smtp1.de.adit-jv.com ([127.0.0.1]) by localhost (smtp1.de.adit-jv.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4UNUtcHSYsUO; Wed, 22 Apr 2020 12:11:05 +0200 (CEST) Received: from HI2EXCH01.adit-jv.com (hi2exch01.adit-jv.com [10.72.92.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by smtp1.de.adit-jv.com (Postfix) with ESMTPS id 524B63C057F; Wed, 22 Apr 2020 12:11:04 +0200 (CEST) Received: from lxhi-065.adit-jv.com (10.72.94.60) by HI2EXCH01.adit-jv.com (10.72.92.24) with Microsoft SMTP Server (TLS) id 14.3.487.0; Wed, 22 Apr 2020 12:11:04 +0200 From: Eugeniu Rosca To: , , CC: Geert Uytterhoeven , Linus Walleij , Marek Vasut , Wolfram Sang , Sergei Shtylyov , Bartosz Golaszewski , Yoshihiro Shimoda , Biju Das , Grygorii Strashko , Chris Paterson , Yusuke Ashiduka , Torii Kenichi , Fukui Yohhei , Yasushi Asano , Yuichi Kusakabe , Andrew Gabbasov , Jiada Wang , Eugeniu Rosca , Eugeniu Rosca Subject: [RFC PATCH 1/3] dt-bindings: gpio-rcar: Add optional use-alternative-interrupt property Date: Wed, 22 Apr 2020 12:10:24 +0200 Message-ID: <20200422101026.9220-2-erosca@de.adit-jv.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200422101026.9220-1-erosca@de.adit-jv.com> References: <20200422101026.9220-1-erosca@de.adit-jv.com> MIME-Version: 1.0 X-Originating-IP: [10.72.94.60] Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org From: Torii Kenichi When setting this property, you must set alternate interrupt number in the 'interrupts' property. Signed-off-by: Torii Kenichi [erosca: tidy up the descriptions/comments] Signed-off-by: Eugeniu Rosca --- Documentation/devicetree/bindings/gpio/renesas,gpio-rcar.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/devicetree/bindings/gpio/renesas,gpio-rcar.txt b/Documentation/devicetree/bindings/gpio/renesas,gpio-rcar.txt index 10dce84b1545..aa5aea90431a 100644 --- a/Documentation/devicetree/bindings/gpio/renesas,gpio-rcar.txt +++ b/Documentation/devicetree/bindings/gpio/renesas,gpio-rcar.txt @@ -50,6 +50,9 @@ Optional properties: - clocks: Must contain a reference to the functional clock. The property is mandatory if the hardware implements a controllable functional clock for the GPIO instance. + - use-alternative-interrupt: Use 'alternative' GPIO interrupt instead + of 'normal' GPIO interrupt. When you specify this property, you must + also change the 'interrupts' DT property. - gpio-reserved-ranges: See gpio.txt. From patchwork Wed Apr 22 10:10:25 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Eugeniu Rosca X-Patchwork-Id: 1274931 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=de.adit-jv.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 496cg715r6z9sVD for ; Wed, 22 Apr 2020 20:51:15 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732028AbgDVKvH (ORCPT ); Wed, 22 Apr 2020 06:51:07 -0400 Received: from smtp1.de.adit-jv.com ([93.241.18.167]:57722 "EHLO smtp1.de.adit-jv.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727075AbgDVKLX (ORCPT ); Wed, 22 Apr 2020 06:11:23 -0400 Received: from localhost (smtp1.de.adit-jv.com [127.0.0.1]) by smtp1.de.adit-jv.com (Postfix) with ESMTP id 66CD83C057F; Wed, 22 Apr 2020 12:11:21 +0200 (CEST) Received: from smtp1.de.adit-jv.com ([127.0.0.1]) by localhost (smtp1.de.adit-jv.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OiO67EY15uNg; Wed, 22 Apr 2020 12:11:15 +0200 (CEST) Received: from HI2EXCH01.adit-jv.com (hi2exch01.adit-jv.com [10.72.92.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by smtp1.de.adit-jv.com (Postfix) with ESMTPS id EA02B3C004C; Wed, 22 Apr 2020 12:11:15 +0200 (CEST) Received: from lxhi-065.adit-jv.com (10.72.94.60) by HI2EXCH01.adit-jv.com (10.72.92.24) with Microsoft SMTP Server (TLS) id 14.3.487.0; Wed, 22 Apr 2020 12:11:15 +0200 From: Eugeniu Rosca To: , , CC: Geert Uytterhoeven , Linus Walleij , Marek Vasut , Wolfram Sang , Sergei Shtylyov , Bartosz Golaszewski , Yoshihiro Shimoda , Biju Das , Grygorii Strashko , Chris Paterson , Yusuke Ashiduka , Torii Kenichi , Fukui Yohhei , Yasushi Asano , Yuichi Kusakabe , Andrew Gabbasov , Jiada Wang , Eugeniu Rosca , Eugeniu Rosca Subject: [RFC PATCH 2/3] gpio: rcar: Add support for GPIO alternative interrupt Date: Wed, 22 Apr 2020 12:10:25 +0200 Message-ID: <20200422101026.9220-3-erosca@de.adit-jv.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200422101026.9220-1-erosca@de.adit-jv.com> References: <20200422101026.9220-1-erosca@de.adit-jv.com> MIME-Version: 1.0 X-Originating-IP: [10.72.94.60] Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org From: Torii Kenichi INTC-AP accepts both GPIO interrupt and GPIO alternative interrupt, but INTC-RT can only handle GPIO interrupt, as depicted in below excerpt from 'Figure 7.1 GPIO Block Configuration (1)' of 'R-Car3 HW User's Manual Rev.2.00, Jul 2019': +------------------------------+ | Interrupt display register +----> GPIO.ch* (to INTC-AP, INTC-RT) | (INTDTn) +----> GPIO.ch*A (to INTC-AP) +------------------------------+ It seems to be also the case for earlier Renesas SoCs like RZ/G, as per 'Figure 6.1 GPIO Block Configuration' in 'RZ/G Series User’s Manual: Hardware Rev.1.00 Sep 2016' [1]. To reduce the interference between RT domain (CR7/SH) and the AP domain (Cortex A5x) and to independently control GPIO interrupts in these two domains, add support for processing GPIO alternative interrupts in AP. This allows handling normal GPIO interrupts exclusively by INTC-RT. The change is DT-driven and depends on the enablement of the 'use-alternative-interrupt' DTS property. One caveat is that the 'interrupts' property update must go hand in hand with the newly added 'use-alternative-interrupt' property. [1] https://www.renesas.com/eu/en/products/microcontrollers-microprocessors/rz/rzg/rzg1m.html#documents Signed-off-by: Torii Kenichi [erosca: enrich commit description] Signed-off-by: Eugeniu Rosca --- drivers/gpio/gpio-rcar.c | 22 +++++++++++++++++----- 1 file changed, 17 insertions(+), 5 deletions(-) diff --git a/drivers/gpio/gpio-rcar.c b/drivers/gpio/gpio-rcar.c index 7284473c9fe3..6bbab447bba8 100644 --- a/drivers/gpio/gpio-rcar.c +++ b/drivers/gpio/gpio-rcar.c @@ -43,6 +43,8 @@ struct gpio_rcar_priv { bool has_outdtsel; bool has_both_edge_trigger; struct gpio_rcar_bank_info bank_info; + int intmsk; + int mskclr; }; #define IOINTSEL 0x00 /* General IO/Interrupt Switching Register */ @@ -56,6 +58,8 @@ struct gpio_rcar_priv { #define POSNEG 0x20 /* Positive/Negative Logic Select Register */ #define EDGLEVEL 0x24 /* Edge/level Select Register */ #define FILONOFF 0x28 /* Chattering Prevention On/Off Register */ +#define INTMSKS 0x38 /* Interrupt Sub Mask Register */ +#define MSKCLRS 0x3c /* Interrupt Sub Mask Clear Register */ #define OUTDTSEL 0x40 /* Output Data Select Register */ #define BOTHEDGE 0x4c /* One Edge/Both Edge Select Register */ @@ -90,7 +94,7 @@ static void gpio_rcar_irq_disable(struct irq_data *d) struct gpio_chip *gc = irq_data_get_irq_chip_data(d); struct gpio_rcar_priv *p = gpiochip_get_data(gc); - gpio_rcar_write(p, INTMSK, ~BIT(irqd_to_hwirq(d))); + gpio_rcar_write(p, p->intmsk, ~BIT(irqd_to_hwirq(d))); } static void gpio_rcar_irq_enable(struct irq_data *d) @@ -98,7 +102,7 @@ static void gpio_rcar_irq_enable(struct irq_data *d) struct gpio_chip *gc = irq_data_get_irq_chip_data(d); struct gpio_rcar_priv *p = gpiochip_get_data(gc); - gpio_rcar_write(p, MSKCLR, BIT(irqd_to_hwirq(d))); + gpio_rcar_write(p, p->mskclr, BIT(irqd_to_hwirq(d))); } static void gpio_rcar_config_interrupt_input_mode(struct gpio_rcar_priv *p, @@ -203,7 +207,7 @@ static irqreturn_t gpio_rcar_irq_handler(int irq, void *dev_id) unsigned int offset, irqs_handled = 0; while ((pending = gpio_rcar_read(p, INTDT) & - gpio_rcar_read(p, INTMSK))) { + gpio_rcar_read(p, p->intmsk))) { offset = __ffs(pending); gpio_rcar_write(p, INTCLR, BIT(offset)); generic_handle_irq(irq_find_mapping(p->gpio_chip.irq.domain, @@ -427,6 +431,14 @@ static int gpio_rcar_parse_dt(struct gpio_rcar_priv *p, unsigned int *npins) *npins = RCAR_MAX_GPIO_PER_BANK; } + if (of_get_property(np, "use-alternative-interrupt", NULL)) { + p->intmsk = INTMSKS; + p->mskclr = MSKCLRS; + } else { + p->intmsk = INTMSK; + p->mskclr = MSKCLR; + } + return 0; } @@ -544,7 +556,7 @@ static int gpio_rcar_suspend(struct device *dev) p->bank_info.iointsel = gpio_rcar_read(p, IOINTSEL); p->bank_info.inoutsel = gpio_rcar_read(p, INOUTSEL); p->bank_info.outdt = gpio_rcar_read(p, OUTDT); - p->bank_info.intmsk = gpio_rcar_read(p, INTMSK); + p->bank_info.intmsk = gpio_rcar_read(p, p->intmsk); p->bank_info.posneg = gpio_rcar_read(p, POSNEG); p->bank_info.edglevel = gpio_rcar_read(p, EDGLEVEL); if (p->has_both_edge_trigger) @@ -586,7 +598,7 @@ static int gpio_rcar_resume(struct device *dev) !!(p->bank_info.bothedge & mask)); if (p->bank_info.intmsk & mask) - gpio_rcar_write(p, MSKCLR, mask); + gpio_rcar_write(p, p->mskclr, mask); } } From patchwork Wed Apr 22 10:10:26 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eugeniu Rosca X-Patchwork-Id: 1274903 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=de.adit-jv.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 496bnb3wnZz9sVX for ; Wed, 22 Apr 2020 20:11:47 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729236AbgDVKLq (ORCPT ); Wed, 22 Apr 2020 06:11:46 -0400 Received: from smtp1.de.adit-jv.com ([93.241.18.167]:57742 "EHLO smtp1.de.adit-jv.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729220AbgDVKLj (ORCPT ); Wed, 22 Apr 2020 06:11:39 -0400 Received: from localhost (smtp1.de.adit-jv.com [127.0.0.1]) by smtp1.de.adit-jv.com (Postfix) with ESMTP id 17D993C0579; Wed, 22 Apr 2020 12:11:37 +0200 (CEST) Received: from smtp1.de.adit-jv.com ([127.0.0.1]) by localhost (smtp1.de.adit-jv.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id uza13biTiMxw; Wed, 22 Apr 2020 12:11:32 +0200 (CEST) Received: from HI2EXCH01.adit-jv.com (hi2exch01.adit-jv.com [10.72.92.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by smtp1.de.adit-jv.com (Postfix) with ESMTPS id 0DFC43C004C; Wed, 22 Apr 2020 12:11:32 +0200 (CEST) Received: from lxhi-065.adit-jv.com (10.72.94.60) by HI2EXCH01.adit-jv.com (10.72.92.24) with Microsoft SMTP Server (TLS) id 14.3.487.0; Wed, 22 Apr 2020 12:11:31 +0200 From: Eugeniu Rosca To: , , CC: Geert Uytterhoeven , Linus Walleij , Marek Vasut , Wolfram Sang , Sergei Shtylyov , Bartosz Golaszewski , Yoshihiro Shimoda , Biju Das , Grygorii Strashko , Chris Paterson , Yusuke Ashiduka , Torii Kenichi , Fukui Yohhei , Yasushi Asano , Yuichi Kusakabe , Andrew Gabbasov , Jiada Wang , Eugeniu Rosca , Eugeniu Rosca Subject: [RFC PATCH 3/3] [LOCAL] arm64: dts: renesas: ulcb: Showcase 'use-alternative-interrupt' Date: Wed, 22 Apr 2020 12:10:26 +0200 Message-ID: <20200422101026.9220-4-erosca@de.adit-jv.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200422101026.9220-1-erosca@de.adit-jv.com> References: <20200422101026.9220-1-erosca@de.adit-jv.com> MIME-Version: 1.0 X-Originating-IP: [10.72.94.60] Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org One caveat is that the 'interrupts' property update _must_ go hand in hand with the newly added 'use-alternative-interrupt' property. Is there an easy way to avoid it? Signed-off-by: Eugeniu Rosca --- arch/arm64/boot/dts/renesas/ulcb.dtsi | 40 ++++++++++++++++++++++++++++++++++++++++ 1 file changed, 40 insertions(+) diff --git a/arch/arm64/boot/dts/renesas/ulcb.dtsi b/arch/arm64/boot/dts/renesas/ulcb.dtsi index d2ba9598cd1e..168dadbd1185 100644 --- a/arch/arm64/boot/dts/renesas/ulcb.dtsi +++ b/arch/arm64/boot/dts/renesas/ulcb.dtsi @@ -174,6 +174,46 @@ &extalr_clk { clock-frequency = <32768>; }; +&gpio0 { + use-alternative-interrupt; + interrupts = ; +}; + +&gpio1 { + use-alternative-interrupt; + interrupts = ; +}; + +&gpio2 { + use-alternative-interrupt; + interrupts = ; +}; + +&gpio3 { + use-alternative-interrupt; + interrupts = ; +}; + +&gpio4 { + use-alternative-interrupt; + interrupts = ; +}; + +&gpio5 { + use-alternative-interrupt; + interrupts = ; +}; + +&gpio6 { + use-alternative-interrupt; + interrupts = ; +}; + +&gpio7 { + use-alternative-interrupt; + interrupts = ; +}; + &hdmi0 { status = "okay";