From patchwork Tue Apr 21 21:13:41 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Iain Buclaw X-Patchwork-Id: 1274519 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=sourceware.org; envelope-from=gcc-patches-bounces@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=gcc.gnu.org Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.a=rsa-sha256 header.s=default header.b=YW6kkw/n; dkim-atps=neutral Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 496GXC0xxYz9sRN for ; Wed, 22 Apr 2020 07:14:01 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 69715386F43F; Tue, 21 Apr 2020 21:13:58 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 69715386F43F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1587503638; bh=kRBbZbjfvY4eRiynaQozmdXBS/Bkk1XLxm4M23tQU2g=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=YW6kkw/nXLOnzpjeBfo+znBciZx6VS+H06l4xLc/uQWOrIj2rGwrvjldGlaAErKBH 6O8ttnc7+MKXLy31qQd3TOFOHrpKAqsd5YtOWugH3HZ7nOCCn8YgjQ9AzyO6vEj9XQ UZgaBFbsaCyKV9I7u2o5Xkv80mUXkhMq3kCuUcpI= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mout-p-102.mailbox.org (mout-p-102.mailbox.org [IPv6:2001:67c:2050::465:102]) by sourceware.org (Postfix) with ESMTPS id B44A5384B0C1 for ; Tue, 21 Apr 2020 21:13:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org B44A5384B0C1 Received: from smtp1.mailbox.org (smtp1.mailbox.org [IPv6:2001:67c:2050:105:465:1:1:0]) (using TLSv1.2 with cipher ECDHE-RSA-CHACHA20-POLY1305 (256/256 bits)) (No client certificate requested) by mout-p-102.mailbox.org (Postfix) with ESMTPS id 496GWz1Gh8zKmds; Tue, 21 Apr 2020 23:13:51 +0200 (CEST) X-Virus-Scanned: amavisd-new at heinlein-support.de Received: from smtp1.mailbox.org ([80.241.60.240]) by spamfilter04.heinlein-hosting.de (spamfilter04.heinlein-hosting.de [80.241.56.122]) (amavisd-new, port 10030) with ESMTP id DNsoN1qnaXrs; Tue, 21 Apr 2020 23:13:44 +0200 (CEST) To: gcc-patches@gcc.gnu.org Subject: [committed] libphobos: Remove GDCFLAGSX variable from configure scripts. Date: Tue, 21 Apr 2020 23:13:41 +0200 Message-Id: <20200421211341.9552-1-ibuclaw@gdcproject.org> MIME-Version: 1.0 X-Rspamd-Queue-Id: C64591776 X-Rspamd-Score: 0.30 / 15.00 / 15.00 X-Spam-Status: No, score=-26.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Iain Buclaw via Gcc-patches From: Iain Buclaw Reply-To: Iain Buclaw Errors-To: gcc-patches-bounces@gcc.gnu.org Sender: "Gcc-patches" Hi, This patch changes the testsuite to compile all tests with the same GDCFLAGS as used to build the library. Notably, this would now be using "-O2", whereas before the testsuite was compiling all tests with "-O0". That we are now compiling with "-O2", there is a possibility of previously hidden bugs getting exposed. Likewise, the time it takes to run the libphobos testsuite has increased by some considerable measure, especially the template-heavy libphobos.phobos and libphobos.phobos_shared unittests. If it is a noticeable problem, then can consider overriding these two test programs with "-O0" if run_expensive_tests is disabled. Bootstrapped and regression tested on x86_64-linux-gnu with --target_board configurations -m64,-m32,-mx32. Testsuite summaries: === gdc tests === Running target unix/-m32 === gdc Summary for unix/-m32 === # of expected passes 30546 Running target unix/-m64 === gdc Summary for unix/-m64 === # of expected passes 30546 Running target unix/-mx32 === gdc Summary for unix/-mx32 === # of expected passes 30546 === gdc Summary === # of expected passes 91638 === libphobos tests === Running target unix/-m32 === libphobos Summary for unix/-m32 === # of expected passes 752 # of unsupported tests 2 Running target unix/-m64 === libphobos Summary for unix/-m64 === # of expected passes 756 Running target unix/-mx32 FAIL: libphobos.phobos/std/experimental/allocator/building_blocks/kernighan_ritchie.d execution test FAIL: libphobos.phobos_shared/std/experimental/allocator/building_blocks/kernighan_ritchie.d execution test === libphobos Summary for unix/-mx32 === # of expected passes 750 # of unexpected failures 2 # of unsupported tests 2 === libphobos Summary === # of expected passes 2258 # of unexpected failures 2 # of unsupported tests 4 The new failure on X32 is caused by glibc bug in syscall interface: https://sourceware.org/bugzilla/show_bug.cgi?id=25810 Committed to mainline. Regards Iain. --- libphobos/ChangeLog: * Makefile.in: Regenerate. * configure: Regenerate. * configure.ac: Remove GDCFLAGSX. * libdruntime/Makefile.in: Regenerate. * src/Makefile.in: Regenerate. * testsuite/Makefile.in: Regenerate. * testsuite/testsuite_flags.in: Use GDCFLAGS in --gdcflags. * testsuite/libphobos.thread/fiber_guard_page.d: Test using -O0. --- libphobos/Makefile.in | 1 - libphobos/configure | 10 ++-------- libphobos/configure.ac | 5 ----- libphobos/libdruntime/Makefile.in | 1 - libphobos/src/Makefile.in | 1 - libphobos/testsuite/Makefile.in | 1 - .../testsuite/libphobos.thread/fiber_guard_page.d | 1 + libphobos/testsuite/testsuite_flags.in | 2 +- 8 files changed, 4 insertions(+), 18 deletions(-) diff --git a/libphobos/Makefile.in b/libphobos/Makefile.in index b464d605232..e51c2158b20 100644 --- a/libphobos/Makefile.in +++ b/libphobos/Makefile.in @@ -230,7 +230,6 @@ EXEEXT = @EXEEXT@ FGREP = @FGREP@ GDC = @GDC@ GDCFLAGS = @GDCFLAGS@ -GDCFLAGSX = @GDCFLAGSX@ GREP = @GREP@ INSTALL = @INSTALL@ INSTALL_DATA = @INSTALL_DATA@ diff --git a/libphobos/configure b/libphobos/configure index 2658cc1728a..c2b49132fda 100755 --- a/libphobos/configure +++ b/libphobos/configure @@ -634,7 +634,6 @@ am__EXEEXT_TRUE LTLIBOBJS LIBOBJS WARN_DFLAGS -GDCFLAGSX libtool_VERSION SPEC_PHOBOS_DEPS CHECKING_DFLAGS @@ -11650,7 +11649,7 @@ else lt_dlunknown=0; lt_dlno_uscore=1; lt_dlneed_uscore=2 lt_status=$lt_dlunknown cat > conftest.$ac_ext <<_LT_EOF -#line 11653 "configure" +#line 11652 "configure" #include "confdefs.h" #if HAVE_DLFCN_H @@ -11756,7 +11755,7 @@ else lt_dlunknown=0; lt_dlno_uscore=1; lt_dlneed_uscore=2 lt_status=$lt_dlunknown cat > conftest.$ac_ext <<_LT_EOF -#line 11759 "configure" +#line 11758 "configure" #include "confdefs.h" #if HAVE_DLFCN_H @@ -15433,11 +15432,6 @@ if test -z "$GDCFLAGS"; then fi -if test -z "$GDCFLAGSX"; then - GDCFLAGSX="-g" -fi - - WARN_DFLAGS="-Wall $WERROR_FLAG" diff --git a/libphobos/configure.ac b/libphobos/configure.ac index 9de36c84be7..c21da5908d0 100644 --- a/libphobos/configure.ac +++ b/libphobos/configure.ac @@ -256,11 +256,6 @@ if test -z "$GDCFLAGS"; then fi AC_SUBST(GDCFLAGS) -if test -z "$GDCFLAGSX"; then - GDCFLAGSX="-g" -fi -AC_SUBST(GDCFLAGSX) - WARN_DFLAGS="-Wall $WERROR_FLAG" AC_SUBST(WARN_DFLAGS) diff --git a/libphobos/libdruntime/Makefile.in b/libphobos/libdruntime/Makefile.in index 3bb023ffc97..4130e96d7be 100644 --- a/libphobos/libdruntime/Makefile.in +++ b/libphobos/libdruntime/Makefile.in @@ -596,7 +596,6 @@ EXEEXT = @EXEEXT@ FGREP = @FGREP@ GDC = @GDC@ GDCFLAGS = @GDCFLAGS@ -GDCFLAGSX = @GDCFLAGSX@ GREP = @GREP@ INSTALL = @INSTALL@ INSTALL_DATA = @INSTALL_DATA@ diff --git a/libphobos/src/Makefile.in b/libphobos/src/Makefile.in index e1b0588a690..4b1ae863a3f 100644 --- a/libphobos/src/Makefile.in +++ b/libphobos/src/Makefile.in @@ -346,7 +346,6 @@ EXEEXT = @EXEEXT@ FGREP = @FGREP@ GDC = @GDC@ GDCFLAGS = @GDCFLAGS@ -GDCFLAGSX = @GDCFLAGSX@ GREP = @GREP@ INSTALL = @INSTALL@ INSTALL_DATA = @INSTALL_DATA@ diff --git a/libphobos/testsuite/Makefile.in b/libphobos/testsuite/Makefile.in index 6f0eaf83405..66077fc19a9 100644 --- a/libphobos/testsuite/Makefile.in +++ b/libphobos/testsuite/Makefile.in @@ -174,7 +174,6 @@ EXEEXT = @EXEEXT@ FGREP = @FGREP@ GDC = @GDC@ GDCFLAGS = @GDCFLAGS@ -GDCFLAGSX = @GDCFLAGSX@ GREP = @GREP@ INSTALL = @INSTALL@ INSTALL_DATA = @INSTALL_DATA@ diff --git a/libphobos/testsuite/libphobos.thread/fiber_guard_page.d b/libphobos/testsuite/libphobos.thread/fiber_guard_page.d index 33a74597a09..49c22658542 100644 --- a/libphobos/testsuite/libphobos.thread/fiber_guard_page.d +++ b/libphobos/testsuite/libphobos.thread/fiber_guard_page.d @@ -1,3 +1,4 @@ +// { dg-options "-O0" } // { dg-shouldfail "segv or bus error" } import core.thread; import core.sys.posix.sys.mman; diff --git a/libphobos/testsuite/testsuite_flags.in b/libphobos/testsuite/testsuite_flags.in index 43e42810434..14b67950607 100755 --- a/libphobos/testsuite/testsuite_flags.in +++ b/libphobos/testsuite/testsuite_flags.in @@ -28,7 +28,7 @@ case ${query} in ;; --gdcflags) GDCFLAGS_default="-fmessage-length=0 -fno-show-column" - GDCFLAGS_config="@WARN_DFLAGS@ @GDCFLAGSX@ -fno-release -funittest" + GDCFLAGS_config="@WARN_DFLAGS@ @GDCFLAGS@ -fno-release -funittest" echo ${GDCFLAGS_default} ${GDCFLAGS_config} ;; --gdcpaths)