From patchwork Thu Apr 16 20:16:22 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefano Babic X-Patchwork-Id: 1271896 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=googlegroups.com (client-ip=2a00:1450:4864:20::23a; helo=mail-lj1-x23a.google.com; envelope-from=swupdate+bncbcxploxj6ikrbih24l2akgqeqnpon4y@googlegroups.com; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=googlegroups.com header.i=@googlegroups.com header.a=rsa-sha256 header.s=20161025 header.b=gJ3UMPCD; dkim-atps=neutral Received: from mail-lj1-x23a.google.com (mail-lj1-x23a.google.com [IPv6:2a00:1450:4864:20::23a]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4939VD19zbz9sP7 for ; Fri, 17 Apr 2020 06:16:35 +1000 (AEST) Received: by mail-lj1-x23a.google.com with SMTP id b26sf1463413ljp.0 for ; Thu, 16 Apr 2020 13:16:35 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1587068193; cv=pass; d=google.com; s=arc-20160816; b=NDWrracFlht8y10uTwXxsSGt9dOJALvVXdN1jMxpuNnI6gC/+Nk5FIYj5iWAASCepe 8DokvhRjbA7RG18exMx5klkpy6UnDPop9GNeaDGAy83C5g2g0WoQ6WpgQPwnOu/6zUlY SSNEntaj8o9ROM9wnNY8mqw17u0kGcBCsupwyrv1Ovht1158QBL1le5kY/1UMUGsn+XX HRLFLD8BnDXKfvQOsiYlIlY2APuRe1R7TU71f/Q3NsMpxHyZ5oTDxhaMnhiBG3qWVzD/ fJn2JVxDIctRJSGfHuf/MRUeMB6hn+tcaNnF/sV2AR1HdbfjnP/PUo4YDw1K6kUEC3tR oIIw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:dkim-signature; bh=vVJL26nfaFALAC63gVmS1IbwcFztdhCh58xx/teowyA=; b=cqX0691L1MTZg+3wr/ZdEgt7gVvcvD4csXrOIFFH6dCiFtE061DUZSNyDqYx7E11v5 NhBB/huoss61g2FOtM1cof6hL0TMra8URc/uteay6ZmsRMQ93PBdM6SoaSe9lyZPKiHT xoMMl/+o398PoWCPPXxk/tAPWRsuHtv+Hoyh4mj4AlX9AiO5BStTfsX+iTmoajZqO6XR +dYGXMujad4ykVMJZwaevDqzP/k5kt3dMRQcVSCMQGW8MCpPDiNOydckioRHRdVK8Bmy Fw944AMro8YqKaqMW56+0KvgqUhKxDJzuGR8pqbVga+7H2NK+vFIOcxTyVf2U74uHaNo 8Tfw== ARC-Authentication-Results: i=2; gmr-mx.google.com; spf=neutral (google.com: 212.18.0.9 is neither permitted nor denied by best guess record for domain of sbabic@denx.de) smtp.mailfrom=sbabic@denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:x-original-sender:x-original-authentication-results :precedence:mailing-list:list-id:list-post:list-help:list-archive :list-subscribe:list-unsubscribe; bh=vVJL26nfaFALAC63gVmS1IbwcFztdhCh58xx/teowyA=; b=gJ3UMPCDIZhVyS0bo+20lwihH9pMTzmKNR1R4AR6slOc0cXAMXUN72Vq7PILzdXIP5 Z2P2HceKMBjHzQm1whNsd5rymQM4seeYKkpR6kf/QyHrCJaT2TnA6WzonR40LgvtP7uJ lAbSfnGFzhb/lABiEKp/nBOsiz+ejKjyIQbw/lA1Lz5glVe+zEZTb11Uy7Zq9lVsbvKK kFGYSeCYUxG+EGFTEJvsygJ0lIrOR+9NPCgX9U43jOpOSoi7NqT4T/GneTC1Hgt2Opv+ Nm6Lj1wxdX9Z7vEBYYyLvFZSX+5Olhm0OTp0a9yIXxyD5/l523XlRZ+53qKUNKHCTrF3 VzRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=sender:x-gm-message-state:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :x-spam-checked-in-group:list-post:list-help:list-archive :list-subscribe:list-unsubscribe; bh=vVJL26nfaFALAC63gVmS1IbwcFztdhCh58xx/teowyA=; b=Km+s528qmzHj3Kkv3BtFnZspa21JWcxqQ5wwoynko5QWYCmFSiI/aI7uh6hVIFGbZF clD2e7VqGyRGFH3MB07J8OeDN+oN3LXBQUo2Vkx005Qm3efCmYHJqA4AP754VsJHUpeE guuNowqPNNrIcpN4emwHxOeIHJh6EH/g+Ckd/2Ch+Uur+4iozAoL6Vg4SQkr19TJtrIs vrugFRR0YloTjAMEmUdzhVly42Hma/jf0x38EYl24N9Watc78k3zsHTKCDF9Ei5JfSQI Va55s20/JBoGaekv9erIGVMht0r1qsQIYNP7vzmyAgysBvQNjM+rGamkpbScr+jtJ5B7 4uUQ== Sender: swupdate@googlegroups.com X-Gm-Message-State: AGi0PuYini5SMzltNsNhZnrIGdgK4w73aPOpEnVCb4U0P+rdEOC//C9R /0Onxg7Uu3O6BPRx0NnFlvk= X-Google-Smtp-Source: APiQypKWbl+BMV99gn0Al5YlxA/kpbD2FHOwZ2IjKtG/PNswxd286qBEQL16m7mKNWoGcjuhp7FUMw== X-Received: by 2002:ac2:57cb:: with SMTP id k11mr7101738lfo.19.1587068192857; Thu, 16 Apr 2020 13:16:32 -0700 (PDT) X-BeenThere: swupdate@googlegroups.com Received: by 2002:a2e:a179:: with SMTP id u25ls95895ljl.0.gmail; Thu, 16 Apr 2020 13:16:32 -0700 (PDT) X-Received: by 2002:a2e:b162:: with SMTP id a2mr7508168ljm.25.1587068192304; Thu, 16 Apr 2020 13:16:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587068192; cv=none; d=google.com; s=arc-20160816; b=W398Brn+sSeuTk9F6yQVu1HSk5cOD6v1WCC/ByQH5FiR76cT7a7Co/bVUMpJ1+p9PO bEU9aCcRk1lsJCGnPpGl08tGqJxl/TNXUPGxz22F8U0rtS2N/kkKFGhDgR3Km2VvP8t7 aJ+QtSXYqIjsAIHkZ2q3IPGDkwiuWQ8iBMPo14xspqXZnZTh00pFrNrQfeF/U2ChVm/8 6NCRCEfSH60aSILn5pRyAVIfinf4v0wyy/r/LjsXsYl/NogBVtRyRW+la7WzCgYnZAnZ e5S4SOitrdW6jIEQSPT5jOLychcHTOVZrx2zOBq/mQs6cD0GaTGRlYC/ZfWuNSbIFzH5 rGNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from; bh=tiHcGEiC5ckYP7DEnCNP5X1wDPrW4PGZJHSTJbj7OzQ=; b=DI+IOJKVAq5/we0Cx4rlzgQjDgxFypOadFVpf9yNDmd13OiiEIABOnuR2SVjOhBIKa PwqfONcU4P1emMidPWsNA/8XUEcUcoWtiKrwpAUaIRm3sbGFBUWIBb74uk5E51brQqkj 70myimoqYiFAKKmUfeSbgTz8tqVqhiQc9s0RDZtpKD2sy0Tz1MZEDvSYchJ48DcJJTpZ px4EF9DlahUfUh/9+Sh+gAJTSTTla/O4fdDwyNDGOvZMhm9I+foZM6p4WyUZ8hLmSezn aHDaCm7OGsdkwTe9E5ONv16hskPdlzCYXNJrSF5p+tfP0tR65+SLAFFRuSi1+hNX7q1b OJQQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=neutral (google.com: 212.18.0.9 is neither permitted nor denied by best guess record for domain of sbabic@denx.de) smtp.mailfrom=sbabic@denx.de Received: from mail-out.m-online.net (mail-out.m-online.net. [212.18.0.9]) by gmr-mx.google.com with ESMTPS id a12si309055ljm.2.2020.04.16.13.16.32 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 16 Apr 2020 13:16:32 -0700 (PDT) Received-SPF: neutral (google.com: 212.18.0.9 is neither permitted nor denied by best guess record for domain of sbabic@denx.de) client-ip=212.18.0.9; Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4939V75jD3z1qsbG; Thu, 16 Apr 2020 22:16:31 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4939V75bvMz1qqkp; Thu, 16 Apr 2020 22:16:31 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id jCCu9Lnaey-X; Thu, 16 Apr 2020 22:16:31 +0200 (CEST) Received: from babic.homelinux.org (host-88-217-136-221.customer.m-online.net [88.217.136.221]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPS; Thu, 16 Apr 2020 22:16:31 +0200 (CEST) Received: from localhost (mail.babic.homelinux.org [127.0.0.1]) by babic.homelinux.org (Postfix) with ESMTP id B4F0045405A4; Thu, 16 Apr 2020 22:16:30 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at babic.homelinux.org Received: from babic.homelinux.org ([IPv6:::1]) by localhost (mail.babic.homelinux.org [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id 2_SkKTw87nWC; Thu, 16 Apr 2020 22:16:28 +0200 (CEST) Received: from paperino.fritz.box (paperino.fritz.box [192.168.178.38]) by babic.homelinux.org (Postfix) with ESMTP id D623C4540953; Thu, 16 Apr 2020 22:16:23 +0200 (CEST) From: Stefano Babic To: swupdate@googlegroups.com Cc: Stefano Babic Subject: [swupdate] [PATCH] IPC: Fix coverity #292208 Date: Thu, 16 Apr 2020 22:16:22 +0200 Message-Id: <20200416201622.32387-5-sbabic@denx.de> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200416201622.32387-1-sbabic@denx.de> References: <20200416201622.32387-1-sbabic@denx.de> MIME-Version: 1.0 X-Original-Sender: sbabic@denx.de X-Original-Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 212.18.0.9 is neither permitted nor denied by best guess record for domain of sbabic@denx.de) smtp.mailfrom=sbabic@denx.de Precedence: list Mailing-list: list swupdate@googlegroups.com; contact swupdate+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: swupdate@googlegroups.com X-Google-Group-Id: 605343134186 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , Signed-off-by: Stefano Babic --- ipc/network_ipc.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/ipc/network_ipc.c b/ipc/network_ipc.c index 149c1be..96215e9 100644 --- a/ipc/network_ipc.c +++ b/ipc/network_ipc.c @@ -82,8 +82,9 @@ int ipc_postupdate(ipc_message *msg) { } memset(msg, 0, sizeof(*msg)); if (tmpbuf != NULL) { - strncpy(msg->data.instmsg.buf, tmpbuf, sizeof(msg->data.instmsg.buf)); - msg->data.instmsg.len = strnlen(tmpbuf, sizeof(msg->data.instmsg.buf)); + msg->data.instmsg.buf[sizeof(msg->data.instmsg.buf) - 1] = '\0'; + strncpy(msg->data.instmsg.buf, tmpbuf, sizeof(msg->data.instmsg.buf) - 1); + msg->data.instmsg.len = strnlen(tmpbuf, sizeof(msg->data.instmsg.buf) - 1); } msg->magic = IPC_MAGIC; msg->type = POST_UPDATE;