From patchwork Wed Dec 6 00:12:33 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Neuling X-Patchwork-Id: 844981 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3yrzZz207fz9s81 for ; Wed, 6 Dec 2017 11:12:43 +1100 (AEDT) Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 3yrzZz0KglzF0GN for ; Wed, 6 Dec 2017 11:12:43 +1100 (AEDT) X-Original-To: skiboot@lists.ozlabs.org Delivered-To: skiboot@lists.ozlabs.org Received: from ozlabs.org (bilbo.ozlabs.org [103.22.144.67]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3yrzZt6wX9zDrbh for ; Wed, 6 Dec 2017 11:12:38 +1100 (AEDT) Received: from localhost.localdomain (localhost [127.0.0.1]) by ozlabs.org (Postfix) with ESMTP id 3yrzZt5VV2z9s72; Wed, 6 Dec 2017 11:12:38 +1100 (AEDT) Received: by localhost.localdomain (Postfix, from userid 1000) id A8971EE77F4; Wed, 6 Dec 2017 11:12:38 +1100 (AEDT) From: Michael Neuling To: stewart@linux.vnet.ibm.com Date: Wed, 6 Dec 2017 11:12:33 +1100 Message-Id: <20171206001233.28188-1-mikey@neuling.org> X-Mailer: git-send-email 2.14.1 Subject: [Skiboot] [PATCH] IPMI: Fix platform.cec_reboot() null ptr checks X-BeenThere: skiboot@lists.ozlabs.org X-Mailman-Version: 2.1.24 Precedence: list List-Id: Mailing list for skiboot development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: skiboot@lists.ozlabs.org, mikey@neuling.org MIME-Version: 1.0 Errors-To: skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Skiboot" Kudos to Hugo Landau who reported this in: https://github.com/open-power/skiboot/issues/142 Reported-by: Hugo Landau Signed-off-by: Michael Neuling --- hw/ipmi/ipmi-attn.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/ipmi/ipmi-attn.c b/hw/ipmi/ipmi-attn.c index ef7153ed7c..8ff872c626 100644 --- a/hw/ipmi/ipmi-attn.c +++ b/hw/ipmi/ipmi-attn.c @@ -67,7 +67,7 @@ void __attribute__((noreturn)) ipmi_terminate(const char *msg) { /* Terminate called before initializing IPMI (early abort) */ if (!ipmi_present()) { - if (platform.cec_reboot()) + if (platform.cec_reboot) platform.cec_reboot(); goto out; } @@ -76,7 +76,7 @@ void __attribute__((noreturn)) ipmi_terminate(const char *msg) ipmi_log_terminate_event(msg); /* Reboot call */ - if (platform.cec_reboot()) + if (platform.cec_reboot) platform.cec_reboot(); out: